Subject: Re: [bug#69291] [PATCH 2/5] scripts: substitute: Allow not using with-timeout in download-nar.

From: Ludovic Courtès <[email-masked]>
Date: Fri, 23 Feb 2024 17:19:46 +0100

Christopher Baines <[email-masked]> skribis:

> I don't think the approach of using SIGALARM here for the timeout will work
> well in all cases (e.g. when using Guile Fibers), so make it possible to avoid
> this.
>
> * guix/scripts/substitute.scm (download-nar): Pass the fetch timeout in as an
> option.
>
> Change-Id: I8cbe6cdfa10cdaa7d41974cbea56a95f5efecfe6

The patch LGTM.

That said, maybe we should just pass #:timeout to ‘http-fetch’?  It’s
not strictly equivalent because it only controls the timeout on
connection establishment, but in practice it should have the same
effect.

Ludo’.