From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 19 11:17:25 2024 Received: (at submit) by debbugs.gnu.org; 19 Feb 2024 16:17:25 +0000 Received: from localhost ([127.0.0.1]:43276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc6Ka-0002Lr-VN for submit@debbugs.gnu.org; Mon, 19 Feb 2024 11:17:25 -0500 Received: from lists.gnu.org ([209.51.188.17]:50472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1rc6KY-0002Ld-Ia for submit@debbugs.gnu.org; Mon, 19 Feb 2024 11:17:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rc6K0-0003zW-Q9 for guix-patches@gnu.org; Mon, 19 Feb 2024 11:16:49 -0500 Received: from wolfsden.cz ([37.205.8.62]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <~@wolfsden.cz>) id 1rc6Ju-0006ry-6B for guix-patches@gnu.org; Mon, 19 Feb 2024 11:16:48 -0500 Received: by wolfsden.cz (Postfix, from userid 104) id F33B329BBE7; Mon, 19 Feb 2024 16:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1708359397; bh=oHBp3XPCL6CGkfwm1D47SNVLvZhoNeDvKvl+NnsR3qw=; h=From:To:Cc:Subject:Date; b=Gcl/OeE8ZXyFasps+R8ms9Q9kwTmJ3r4U+5fxJ6wjvErq7Mek4pShf6XLCqfDI14a dsPgMR3RXKPrdxkhZgRXqBp0tpHJs2ugmA+8+6Xd1cM5y3tyoGL5A6lo67FEHV0nHH LUg08O1Wk2YSitVIkd6fXsSaRKQhdpW5iCuFWS0Pm6fDCKxhiWBL7Y4SirrO+F+lcg MuFlM/gPmYUQ9zS7jS8Z7JVA2R8W4nZuXTyZZHKbrpqFvdcUzY+7ouArrrx9jngG3D eTAj78OOopfOPAlvLq5rD8apBtyT/TXmXCl28XFE7iVfDxPmb5XAfQziJOvSOyq3R5 qWL1OalV/50BfFk8CCKeySaRYGBX8s+e0lOutjBd+JoClaozg9D+0qL/Ipqg/r4lPO DJVImEZyKlcMnUYWcGK0npZPghv6uA9U11Pcq/BAae2dvgJzJv6XMxK2OFSrc9imtT 8H0C6d5rYN/QV0zwwAIR8J2Ue6I3LlaRzbbDtEoW3+f8AQIHwEc0VnBhFmL5TQAVTw sglOB/3swSZZ2+pG6IItQmeXnb7Y6PSEAEE2IIOQjJ+A06NwKEgXM4BmT2k4Cc83n4 v8MhmpOLLmrIgg3lQi8lqLZvWBCZ40gQsitulxWsmAfi/DtYm94Kd0r5HbU8mQCosx jdx3qII6wh9qY9hToM/VwTRM= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from localhost (unknown [146.70.134.183]) by wolfsden.cz (Postfix) with ESMTPSA id 1EC55294EF4; Mon, 19 Feb 2024 16:16:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1708359397; bh=oHBp3XPCL6CGkfwm1D47SNVLvZhoNeDvKvl+NnsR3qw=; h=From:To:Cc:Subject:Date; b=Gcl/OeE8ZXyFasps+R8ms9Q9kwTmJ3r4U+5fxJ6wjvErq7Mek4pShf6XLCqfDI14a dsPgMR3RXKPrdxkhZgRXqBp0tpHJs2ugmA+8+6Xd1cM5y3tyoGL5A6lo67FEHV0nHH LUg08O1Wk2YSitVIkd6fXsSaRKQhdpW5iCuFWS0Pm6fDCKxhiWBL7Y4SirrO+F+lcg MuFlM/gPmYUQ9zS7jS8Z7JVA2R8W4nZuXTyZZHKbrpqFvdcUzY+7ouArrrx9jngG3D eTAj78OOopfOPAlvLq5rD8apBtyT/TXmXCl28XFE7iVfDxPmb5XAfQziJOvSOyq3R5 qWL1OalV/50BfFk8CCKeySaRYGBX8s+e0lOutjBd+JoClaozg9D+0qL/Ipqg/r4lPO DJVImEZyKlcMnUYWcGK0npZPghv6uA9U11Pcq/BAae2dvgJzJv6XMxK2OFSrc9imtT 8H0C6d5rYN/QV0zwwAIR8J2Ue6I3LlaRzbbDtEoW3+f8AQIHwEc0VnBhFmL5TQAVTw sglOB/3swSZZ2+pG6IItQmeXnb7Y6PSEAEE2IIOQjJ+A06NwKEgXM4BmT2k4Cc83n4 v8MhmpOLLmrIgg3lQi8lqLZvWBCZ40gQsitulxWsmAfi/DtYm94Kd0r5HbU8mQCosx jdx3qII6wh9qY9hToM/VwTRM= From: Tomas Volf <~@wolfsden.cz> To: guix-patches@gnu.org Subject: [PATCH] gnu: libtorrent-rasterbar: Update to 2.0.10. Date: Mon, 19 Feb 2024 17:16:33 +0100 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=37.205.8.62; envelope-from=~@wolfsden.cz; helo=wolfsden.cz X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: submit Cc: Tomas Volf <~@wolfsden.cz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) * gnu/packages/bittorrent.scm (libtorrent-rasterbar): Update to 2.0.10. Change-Id: I9056b2cb6eac9740f95daf2fb73d874ca95f1a7f --- gnu/packages/bittorrent.scm | 32 +++++--------------------------- 1 file changed, 5 insertions(+), 27 deletions(-) diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm index 0d544235c1..34a7c17738 100644 --- a/gnu/packages/bittorrent.scm +++ b/gnu/packages/bittorrent.scm @@ -418,16 +418,10 @@ (define-public mktorrent (license (list l:public-domain ; sha1.*, used to build without OpenSSL l:gpl2+)))) ; with permission to link with OpenSSL -(define %v2_empty_file.torrent - (origin (method url-fetch) - (uri "https://github.com/arvidn/libtorrent/raw/v2.0.9/test/test_torrents/v2_empty_file.torrent") - (sha256 - (base32 "1hydgf0m9193hy9010wl0wrbz4k4cgrqg70jakx68pgi79jcqnrn")))) - (define-public libtorrent-rasterbar (package (name "libtorrent-rasterbar") - (version "2.0.9") + (version "2.0.10") (source (origin (method url-fetch) @@ -436,14 +430,7 @@ (define-public libtorrent-rasterbar "releases/download/v" version "/" "libtorrent-rasterbar-" version ".tar.gz")) (sha256 - (base32 "13kry578ifzz4m2f291bbd7v5v9zsi8y3mf38146cnqw0sv95kch")) - ;; https://github.com/arvidn/libtorrent/issues/7566 - ;; Remove when resolved. I would hope this to be fixed in 2.0.10. - (modules '((guix build utils))) - (snippet - #~(substitute* "test/test_copy_file.cpp" - (("EXT4_SUPER_MAGIC, EXT3_SUPER_MAGIC, XFS_SUPER_MAGIC" all) - (string-append all ", TMPFS_MAGIC\n")))))) + (base32 "0pc8rbcp7njbx8m02z47pcbbwcp5cjggbgq4sfjc19dc3n65p4zw")))) (build-system cmake-build-system) (arguments `(#:configure-flags '("-Dpython-bindings=ON" @@ -452,14 +439,6 @@ (define-public libtorrent-rasterbar #:parallel-tests? #f #:phases (modify-phases %standard-phases - ;; https://github.com/arvidn/libtorrent/issues/7567 - ;; Remove when resolved. I would hope this to be fixed in 2.0.10. - ;; Do not forget to remove the %v2_empty_file.torrent variable. - (add-before 'configure 'copy-v2_empty_file.torrent - (lambda* (#:key native-inputs inputs #:allow-other-keys) - (copy-file (assoc-ref (or native-inputs inputs) - "%v2_empty_file.torrent") - "test/test_torrents/v2_empty_file.torrent"))) (replace 'check (lambda* (#:key tests? parallel-tests? #:allow-other-keys) (let* ((disabled-tests @@ -500,10 +479,9 @@ (define-public libtorrent-rasterbar ;; "--output-on-failure") ))))))) (inputs (list boost openssl)) - (native-inputs `(("libfaketime" ,libfaketime) - ("python-wrapper" ,python-wrapper) - ("pkg-config" ,pkg-config) - ("%v2_empty_file.torrent" ,%v2_empty_file.torrent))) + (native-inputs (list libfaketime + python-wrapper + pkg-config)) (home-page "https://www.libtorrent.org/") (synopsis "Feature-complete BitTorrent implementation") (description base-commit: fdbf4192f5eaa7fdb5e6e2e98ada0726c8104824 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 06 09:08:40 2024 Received: (at 69276) by debbugs.gnu.org; 6 Aug 2024 13:08:40 +0000 Received: from localhost ([127.0.0.1]:60421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbJvc-0004Yp-C1 for submit@debbugs.gnu.org; Tue, 06 Aug 2024 09:08:40 -0400 Received: from layka.disroot.org ([178.21.23.139]:40086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbJvZ-0004Yc-Od for 69276@debbugs.gnu.org; Tue, 06 Aug 2024 09:08:38 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 264A740A16 for <69276@debbugs.gnu.org>; Tue, 6 Aug 2024 15:08:12 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jBdOylz4pCpa for <69276@debbugs.gnu.org>; Tue, 6 Aug 2024 15:08:11 +0200 (CEST) Message-ID: <9a9ec5ec-5b51-cad9-b01e-76d495752240@disroot.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1722949691; bh=jQv5vrSf27non4AWomZecKs7P/7e+zIwk3YG8vQoQIg=; h=Date:To:From:Subject; b=OmE4MG7U3ihD/OlZhcS/QAulM5NpK1p+s8/eVeO65HLjcLb/8pHibaw5oTEw98W3+ Tz5PUkcHdSaLV3wn8dicHLWtb7bMhLxeq+9jayhy5Q3wh8ajlKPu7OypB1n5RMrIhE iAPkH6T0kHwfgwx9mb6QnIgsJzBS1st1s8IMrtfucSbacKS/AbaKG1p6+HfgvLzxMo QAcEHYW1dL6xg96BC9nypbBGhDWpA/Inzn2HQuOIoX37+2ul6jiQ/jgV2kdb8f931Y nt/qXWcwS1GUcmaa43UrLEiDP9VrPaWDmZ8KradxoRQsT9Ihr8fAvs+w0IeYqZEED5 /WfZ8TuAMcFNw== Date: Tue, 6 Aug 2024 21:07:40 +0800 MIME-Version: 1.0 Content-Language: en-US To: 69276@debbugs.gnu.org From: Adam Faiz Subject: [PATCH 1/2] gnu: libtorrent-rasterbar: Update to 2.0.10. Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 69276 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >From 4af05095ca922bb6d0335a6e946a404d4764ac1f Mon Sep 17 00:00:00 2001 Message-ID: <4af05095ca922bb6d0335a6e946a404d4764ac1f.1722949379.git.adam.faiz@disroot.org> In-Reply-To: References: From: AwesomeAdam54321 Date: Tue, 6 Aug 2024 19:57:47 +0800 Subject: [PATCH 1/2] gnu: libtorrent-rasterbar: Update to 2.0.10. * gnu/packages/bittorrent.scm (libtorrent-rasterbar): Update to 2.0.10. [source]: Remove test/test_copy_file.cpp patch since it's resolved. [native-inputs]: Remove no longer needed file (v2_empty_file.torrent). [arguments]<#:phases>: And remove a phase copying it into the correct place. --- gnu/packages/bittorrent.scm | 28 +++------------------------- 1 file changed, 3 insertions(+), 25 deletions(-) diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm index 5c2fa9c688..abc598f7fa 100644 --- a/gnu/packages/bittorrent.scm +++ b/gnu/packages/bittorrent.scm @@ -418,16 +418,10 @@ (define-public mktorrent (license (list l:public-domain ; sha1.*, used to build without OpenSSL l:gpl2+)))) ; with permission to link with OpenSSL -(define %v2_empty_file.torrent - (origin (method url-fetch) - (uri "https://github.com/arvidn/libtorrent/raw/v2.0.9/test/test_torrents/v2_empty_file.torrent") - (sha256 - (base32 "1hydgf0m9193hy9010wl0wrbz4k4cgrqg70jakx68pgi79jcqnrn")))) - (define-public libtorrent-rasterbar (package (name "libtorrent-rasterbar") - (version "2.0.9") + (version "2.0.10") (source (origin (method url-fetch) @@ -436,14 +430,7 @@ (define-public libtorrent-rasterbar "releases/download/v" version "/" "libtorrent-rasterbar-" version ".tar.gz")) (sha256 - (base32 "13kry578ifzz4m2f291bbd7v5v9zsi8y3mf38146cnqw0sv95kch")) - ;; https://github.com/arvidn/libtorrent/issues/7566 - ;; Remove when resolved. I would hope this to be fixed in 2.0.10. - (modules '((guix build utils))) - (snippet - #~(substitute* "test/test_copy_file.cpp" - (("EXT4_SUPER_MAGIC, EXT3_SUPER_MAGIC, XFS_SUPER_MAGIC" all) - (string-append all ", TMPFS_MAGIC\n")))))) + (base32 "0pc8rbcp7njbx8m02z47pcbbwcp5cjggbgq4sfjc19dc3n65p4zw")))) (build-system cmake-build-system) (arguments `(#:configure-flags '("-Dpython-bindings=ON" @@ -452,14 +439,6 @@ (define-public libtorrent-rasterbar #:parallel-tests? #f #:phases (modify-phases %standard-phases - ;; https://github.com/arvidn/libtorrent/issues/7567 - ;; Remove when resolved. I would hope this to be fixed in 2.0.10. - ;; Do not forget to remove the %v2_empty_file.torrent variable. - (add-before 'configure 'copy-v2_empty_file.torrent - (lambda* (#:key native-inputs inputs #:allow-other-keys) - (copy-file (assoc-ref (or native-inputs inputs) - "%v2_empty_file.torrent") - "test/test_torrents/v2_empty_file.torrent"))) (replace 'check (lambda* (#:key tests? parallel-tests? #:allow-other-keys) (let* ((disabled-tests @@ -502,8 +481,7 @@ (define-public libtorrent-rasterbar (inputs (list boost openssl)) (native-inputs `(("libfaketime" ,libfaketime) ("python-wrapper" ,python-wrapper) - ("pkg-config" ,pkg-config) - ("%v2_empty_file.torrent" ,%v2_empty_file.torrent))) + ("pkg-config" ,pkg-config))) (home-page "https://www.libtorrent.org/") (synopsis "Feature-complete BitTorrent implementation") (description -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 06 09:10:10 2024 Received: (at 69276) by debbugs.gnu.org; 6 Aug 2024 13:10:10 +0000 Received: from localhost ([127.0.0.1]:60425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbJx4-0004cI-0Q for submit@debbugs.gnu.org; Tue, 06 Aug 2024 09:10:10 -0400 Received: from layka.disroot.org ([178.21.23.139]:59056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sbJx1-0004c8-TD for 69276@debbugs.gnu.org; Tue, 06 Aug 2024 09:10:08 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 83D0640D1E for <69276@debbugs.gnu.org>; Tue, 6 Aug 2024 15:09:43 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JvCG2_xBb38D for <69276@debbugs.gnu.org>; Tue, 6 Aug 2024 15:09:42 +0200 (CEST) Message-ID: <405ac53a-7195-4b9f-db06-022e6bb3433c@disroot.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1722949780; bh=lfEqqRGWCAuV8mnPyRTYD3toVMKoRr4lqszw4ZWA8gs=; h=Date:To:From:Subject; b=ZwL9lUDSVgIKe44LLfjJhhlum0zy2M+qvvSySprb+AP6cKL2NmhtdygIk7xOkeAPH FaDremx7Njn2bWglZU6m0sCx1N7DbFDeL/k2PuYIDpqR1dn0oyuBrap2uHQMBYt1BN DEXkEwfdjbIdTwq8p3stzsoOGvxPqdY6mS/Zz4u20OjZ+9xKCaByAQMFE1ye8Ia6G2 U9vKbH0RD3jJNiuI1lDy1NWyyr8UTXAToQ80DixuHnP9v09uAxx0Kzx3hxj2QUtCXX d8wb8/0VMH6AJbrRpVf9j7wywate9it4tXICNSMWu6j3DqXMYN7mOf92KicrtHy4BD ZjrxsVlyNzO5g== Date: Tue, 6 Aug 2024 21:09:17 +0800 MIME-Version: 1.0 Content-Language: en-US To: 69276@debbugs.gnu.org From: Adam Faiz Subject: [PATCH 2/2] gnu: libtorrent-rasterbar: Use gexps and new input style. Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 69276 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >From 646cc0c6857c41564eda8ccc0ade07ae16a18a6c Mon Sep 17 00:00:00 2001 Message-ID: <646cc0c6857c41564eda8ccc0ade07ae16a18a6c.1722949379.git.adam.faiz@disroot.org> In-Reply-To: References: From: AwesomeAdam54321 Date: Tue, 6 Aug 2024 20:55:13 +0800 Subject: [PATCH 2/2] gnu: libtorrent-rasterbar: Use gexps and new input style. * gnu/packages/bittorrent.scm (libtorrent-rasterbar)[arguments]: Use gexps. [native-inputs]: Drop labels. --- gnu/packages/bittorrent.scm | 75 +++++++++++++++++++------------------ 1 file changed, 38 insertions(+), 37 deletions(-) diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm index abc598f7fa..fa2765da5b 100644 --- a/gnu/packages/bittorrent.scm +++ b/gnu/packages/bittorrent.scm @@ -433,33 +433,34 @@ (define-public libtorrent-rasterbar (base32 "0pc8rbcp7njbx8m02z47pcbbwcp5cjggbgq4sfjc19dc3n65p4zw")))) (build-system cmake-build-system) (arguments - `(#:configure-flags '("-Dpython-bindings=ON" - "-Dbuild_tests=ON") - ;; Tests do not reliably work when executed in parallel. - #:parallel-tests? #f - #:phases - (modify-phases %standard-phases - (replace 'check - (lambda* (#:key tests? parallel-tests? #:allow-other-keys) - (let* ((disabled-tests - '( - ;; Requires a non-localhost IPv4 interface. - "test_upnp" - ;; test_ssl needs to be run separately. - "test_ssl")) - (exclude-regex (string-append "^(" - (string-join disabled-tests "|") - ")$")) - (timeout "600") - (jobs (if parallel-tests? - (number->string (parallel-job-count)) - "1"))) - (when tests? - (invoke "ctest" - "-E" exclude-regex - "-j" jobs - "--timeout" timeout - "--output-on-failure") + (list + #:configure-flags + #~'("-Dpython-bindings=ON" + "-Dbuild_tests=ON") + ;; Tests do not reliably work when executed in parallel. + #:parallel-tests? #f + #:phases + #~(modify-phases %standard-phases + (replace 'check + (lambda* (#:key tests? parallel-tests? #:allow-other-keys) + (let* ((disabled-tests + '(;; Requires a non-localhost IPv4 interface. + "test_upnp" + ;; test_ssl needs to be run separately. + "test_ssl")) + (exclude-regex (string-append "^(" + (string-join disabled-tests "|") + ")$")) + (timeout "600") + (jobs (if parallel-tests? + (number->string (parallel-job-count)) + "1"))) + (when tests? + (invoke "ctest" + "-E" exclude-regex + "-j" jobs + "--timeout" timeout + "--output-on-failure") ;; test_ssl relies on bundled TLS certificates with a fixed ;; expiry date. To ensure succesful builds in the future, ;; fake the time to be roughly that of the release. @@ -471,17 +472,17 @@ (define-public libtorrent-rasterbar ;; ;; Note: The test_ssl test times out in the ci. ;; Temporarily disable it until that is resolved. - ;; (invoke "faketime" "2022-10-24" - ;; "ctest" - ;; "-R" "^test_ssl$" - ;; "-j" jobs - ;; "--timeout" timeout - ;; "--output-on-failure") - ))))))) + #;(invoke "faketime" "2022-10-24" + "ctest" + "-R" "^test_ssl$" + "-j" jobs + "--timeout" timeout + "--output-on-failure")))))))) (inputs (list boost openssl)) - (native-inputs `(("libfaketime" ,libfaketime) - ("python-wrapper" ,python-wrapper) - ("pkg-config" ,pkg-config))) + (native-inputs + (list libfaketime + python-wrapper + pkg-config)) (home-page "https://www.libtorrent.org/") (synopsis "Feature-complete BitTorrent implementation") (description -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 05:13:05 2024 Received: (at submit) by debbugs.gnu.org; 6 Oct 2024 09:13:05 +0000 Received: from localhost ([127.0.0.1]:40143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxNK4-0003n8-Nl for submit@debbugs.gnu.org; Sun, 06 Oct 2024 05:13:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:51616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxNK3-0003n1-HS for submit@debbugs.gnu.org; Sun, 06 Oct 2024 05:13:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sxNJx-0003ZK-Gs for guix-patches@gnu.org; Sun, 06 Oct 2024 05:12:57 -0400 Received: from smtp84.cstnet.cn ([159.226.251.84] helo=cstnet.cn) by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1sxNJu-0001wN-GT for guix-patches@gnu.org; Sun, 06 Oct 2024 05:12:57 -0400 Received: from m (unknown [107.174.64.25]) by APP-05 (Coremail) with SMTP id zQCowAAnLvKGVAJnyBIzBA--.45775S2; Sun, 06 Oct 2024 17:12:43 +0800 (CST) From: Z572 To: Adam Faiz via Guix-patches via Subject: Re: [bug#69276] [PATCH 1/2] gnu: libtorrent-rasterbar: Update to 2.0.10. In-Reply-To: <9a9ec5ec-5b51-cad9-b01e-76d495752240@disroot.org> (Adam Faiz via Guix-patches via's message of "Tue, 6 Aug 2024 21:07:40 +0800") References: <9a9ec5ec-5b51-cad9-b01e-76d495752240@disroot.org> Date: Sun, 06 Oct 2024 17:12:33 +0800 Message-ID: <87cykdsigu.fsf@iscas.ac.cn> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-CM-TRANSID: zQCowAAnLvKGVAJnyBIzBA--.45775S2 X-Coremail-Antispam: 1UD129KBjvJXoWxArWxArWrCFWUurWktw1UKFg_yoWrGFW8pF ZxuryfKry8GryfGwsFgF4xKFn0grZxCFn09w4xXw1xGayYyFyktry2krWrAFW7Z34kAw47 X3yIva1rW398JFJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvGb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWxJVW8Jr1l84ACjcxK6I 8E87Iv6xkF7I0E14v26r4j6r4UJwAa7VASzI0EjI02j7AqF2xKxVCjxxvEa2IrM2AIxVAI cxkEcVAq07x20xvEncxIr21le4C267I2x7xF54xIwI1l5I8CrVACY4xI64kE6c02F40Ex7 xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Y z7v_Jr0_Gr1lF7xvr2IY64vIr41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr 0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY 17CE14v26r1Y6r17MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcV C0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY 6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa 73UjIFyTuYvjxUDsqWUUUUU X-Originating-IP: [107.174.64.25] X-CM-SenderInfo: x2kh0wxmxqyx3h6l2u1dvotugofq/ Received-SPF: pass client-ip=159.226.251.84; envelope-from=zhengjunjie@iscas.ac.cn; helo=cstnet.cn X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 69276-done@debbugs.gnu.org, Adam Faiz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Adam Faiz via Guix-patches via writes: > From 4af05095ca922bb6d0335a6e946a404d4764ac1f Mon Sep 17 00:00:00 2001 > Message-ID: <4af05095ca922bb6d0335a6e946a404d4764ac1f.1722949379.git.adam= .faiz@disroot.org> > In-Reply-To: > References: > From: AwesomeAdam54321 > Date: Tue, 6 Aug 2024 19:57:47 +0800 > Subject: [PATCH 1/2] gnu: libtorrent-rasterbar: Update to 2.0.10. > > * gnu/packages/bittorrent.scm (libtorrent-rasterbar): Update to 2.0.10. > [source]: Remove test/test_copy_file.cpp patch since it's resolv= ed. > [native-inputs]: Remove no longer needed file (v2_empty_file.torrent). > [arguments]<#:phases>: And remove a phase copying it into the correct pla= ce. > --- > gnu/packages/bittorrent.scm | 28 +++------------------------- > 1 file changed, 3 insertions(+), 25 deletions(-) > > diff --git a/gnu/packages/bittorrent.scm b/gnu/packages/bittorrent.scm > index 5c2fa9c688..abc598f7fa 100644 > --- a/gnu/packages/bittorrent.scm > +++ b/gnu/packages/bittorrent.scm > @@ -418,16 +418,10 @@ (define-public mktorrent > (license (list l:public-domain ; sha1.*, used to build without = OpenSSL > l:gpl2+)))) ; with permission to link with O= penSSL >=20=20 > -(define %v2_empty_file.torrent > - (origin (method url-fetch) > - (uri "https://github.com/arvidn/libtorrent/raw/v2.0.9/test/tes= t_torrents/v2_empty_file.torrent") > - (sha256 > - (base32 "1hydgf0m9193hy9010wl0wrbz4k4cgrqg70jakx68pgi79jcqnrn= ")))) > - > (define-public libtorrent-rasterbar > (package > (name "libtorrent-rasterbar") > - (version "2.0.9") > + (version "2.0.10") > (source > (origin > (method url-fetch) > @@ -436,14 +430,7 @@ (define-public libtorrent-rasterbar > "releases/download/v" version "/" > "libtorrent-rasterbar-" version ".tar.gz")) > (sha256 > - (base32 "13kry578ifzz4m2f291bbd7v5v9zsi8y3mf38146cnqw0sv95kch")) > - ;; https://github.com/arvidn/libtorrent/issues/7566 > - ;; Remove when resolved. I would hope this to be fixed in 2.0.10. > - (modules '((guix build utils))) > - (snippet > - #~(substitute* "test/test_copy_file.cpp" > - (("EXT4_SUPER_MAGIC, EXT3_SUPER_MAGIC, XFS_SUPER_MAGIC" all) > - (string-append all ", TMPFS_MAGIC\n")))))) > + (base32 "0pc8rbcp7njbx8m02z47pcbbwcp5cjggbgq4sfjc19dc3n65p4zw"))= )) > (build-system cmake-build-system) > (arguments > `(#:configure-flags '("-Dpython-bindings=3DON" > @@ -452,14 +439,6 @@ (define-public libtorrent-rasterbar > #:parallel-tests? #f > #:phases > (modify-phases %standard-phases > - ;; https://github.com/arvidn/libtorrent/issues/7567 > - ;; Remove when resolved. I would hope this to be fixed in 2.0.= 10. > - ;; Do not forget to remove the %v2_empty_file.torrent variable. > - (add-before 'configure 'copy-v2_empty_file.torrent > - (lambda* (#:key native-inputs inputs #:allow-other-keys) > - (copy-file (assoc-ref (or native-inputs inputs) > - "%v2_empty_file.torrent") > - "test/test_torrents/v2_empty_file.torrent"))) > (replace 'check > (lambda* (#:key tests? parallel-tests? #:allow-other-keys) > (let* ((disabled-tests > @@ -502,8 +481,7 @@ (define-public libtorrent-rasterbar > (inputs (list boost openssl)) > (native-inputs `(("libfaketime" ,libfaketime) > ("python-wrapper" ,python-wrapper) > - ("pkg-config" ,pkg-config) > - ("%v2_empty_file.torrent" ,%v2_empty_file.torrent))) > + ("pkg-config" ,pkg-config))) > (home-page "https://www.libtorrent.org/") > (synopsis "Feature-complete BitTorrent implementation") > (description adjust message, not use #; , push and close. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfr6klGDOXiwIdX/bO1qpk+Gi3/AFAmcCVIEACgkQO1qpk+Gi 3/DZ4w/9HgHuVaeFoZWGIZI5pXHXuYKQSgTcu1dxFZplPAjyzyaTCpoCtumx/2WH C4M0u2VUc7XapaNgDBG+FIcdOgsp2uKzE2LAg1ZDX7ruvcoY0b47q8nvVnmvHPli w7481djWWDwWix7Z1zEus3jF93je7Zummofe2tCGX5/ljqdNk1G4O0NVspKH46H4 GH6OgRptA1QCC387S1ttUbZzVSmd7ssM4Kyg9rotTR5UhoUH4ShKCRrhkpvhScpc RzFsyxLuNhhZuCA+RaZtQUDDfWH/s8jvdE0CgHGPDSJp51sVIAyhsLYO/TWEKhfn dFLmXOHJ1Z/3Dl6edMFIverUa7/hV0L4mCeoYOvN2J0v35rhNtBSl4sAYP0x6pJa vjhPxcRPlKFnArafgokmkd1bsT1n7s/6Xq0MMLDimxuDDAMfcEE2xWJnTZVAWzgq GCLbJzqKn7pwlGX9Yum+JecuXqR5lNaA2TyfmfND5hjy+yTYnjn9qn8xjT6ZRwGt pdnT9jnKfI9izi5fZmLZqvQQbsXUmpG0DB3ZxUtA8ABg2A3sLJNL4+94k3js8HYk 9FXOPb7VoNUoSC/N6RTG3usjyv8zu6/kPl894wdfsbOvHjejwqrgXC5g3+kkJOJv 7TQR+EevHnduHhiM1w84yejsLhSo1C8/OeblxB7i55IKEgndl/4= =/km3 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 15:15:35 2024 Received: (at 69276) by debbugs.gnu.org; 6 Oct 2024 19:15:35 +0000 Received: from localhost ([127.0.0.1]:42316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxWj9-0003GD-9S for submit@debbugs.gnu.org; Sun, 06 Oct 2024 15:15:35 -0400 Received: from mail-4316.protonmail.ch ([185.70.43.16]:46221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxWj7-0003Fz-A9 for 69276@debbugs.gnu.org; Sun, 06 Oct 2024 15:15:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1728242121; x=1728501321; bh=U2M4dT5pXPjeHPH2yMRsouW+Vqhx88Wb0GLpSM0+pQo=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=SE2LTP5evNEKUePRon9yOY8BBwAw6eWTWrPkBQ8+DQA7az/VTO1qCkP+FT0rNRxaO wGvXOmeLiUEnlml/8aszsiWRjeUL9vwclua2oe/2ECkS2n4RFs4A1hG3sRPjcFnQ04 CtRBT1YBWIJj4RfQij+ZyR4SibO+colm2v1yY1jGQaZoZcy8MsTXfHeQ2lkjhgpbxC 4IgbFYYjg8OvhMROGiubA8vPN0uWJ6IxU/8u1tN3s1Ldbwgot5FGuSo+TeaNL79byz 0m497k4t1RlwPx+X4H3gkGJfZ/UpCqQx685EGgeqqAQHkQeSMMyaYp2sEhJQ/IJdwn eQnbhLprkobrw== Date: Sun, 06 Oct 2024 19:15:16 +0000 To: Tomas Volf <~@wolfsden.cz>, guix-devel@gnu.org From: John Kehayias Subject: Re: 01/04: gnu: libtorrent-rasterbar: Update to 2.0.10. Message-ID: <87iku53uwy.fsf@protonmail.com> In-Reply-To: <87y131xgoa.fsf@wolfsden.cz> References: <172820540113.1389510.12193329113919899297@vcs3.savannah.gnu.org> <20241006090321.C8D6A1C1D84@vcs3.savannah.gnu.org> <87y131xgoa.fsf@wolfsden.cz> Feedback-ID: 7805494:user:proton X-Pm-Message-ID: a3d6ba2fdfa4e6d47fb03d08b95936d6131d9600 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 69276 Cc: 69276@debbugs.gnu.org, Z572 , Adam Faiz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dear Tomas (and CC'ing the debbugs number, co-author, and committer Z572), On Sun, Oct 06, 2024 at 07:52 PM, Tomas Volf wrote: > guix-commits@gnu.org writes: > >> z572 pushed a commit to branch master >> in repository guix. >> >> commit 37dede4c4d8c25a786f2a2e2a17ba54b4ba6283f >> Author: Adam Faiz via Guix-patches via >> AuthorDate: Tue Aug 6 21:07:40 2024 +0800 > > I have to admit I am not very happy regarding the change in the commit > author. While I understand the change itself might have been somewhat > trivial, I did work with upstream to merge the required changes for > 2.0.10, so having the authorship stolen like this leaves somewhat > unpleasant feeling. > I understand your frustration and while I thank you for bringing this to at= tention (we care about attribution here!), I do think this was escalated a = tiny bit in the heat of the moment. I don't see this message in the origina= l patch thread with the other author (Adam) and committer (Z572, still rela= tively new), so it is quite possible they didn't see this message you sent = until now. I should say, I do think it is good to raise awareness so we can all do bet= ter, but I think we should try to give some benefit of the doubt and look f= or the best way forward. Mistakes happen! I had accidentally lost the autho= r of some commits and realized after I had pushed them, raising this after = with guix-devel and the original authors for what remedy they would like. T= hough everything was okay, I felt bad, and still do, but at least it has ma= de me more vigilant. Let's remember we are all trying our best here and ima= gine ourselves on the other side. (Side note that upstream work to help out Guix and packaging is always welc= ome, so thank you for that! Though that is separate from authorship of comm= its on the Guix side, of course.) > Especially since applying for commit access has a number of commits as > one of prerequisites, having your address visible in `git log --author' > goes from "collecting internet points" into "actually somewhat > important". But even without that, I would still consider it not a nice > thing to do. > Part of having commit access is also accepting that mistakes will happen an= d you are expected to remedy, learn, and help us all do better (e.g. see ). This qu= ality I would say is much more important than just number of contributions,= though that experience is a more quantifiable prerequisite. As I hope a neutral third party, in this case I would suggest reverting the= commits and then reapplying them with author/co-author set appropriately. = I think this issue should have been brought up more directly with the parti= es involved, whether or not cc-ing guix-devel helps here I can't say. As I = said, I at least take it as a reminder of our responsibilities and potentia= l mistakes when we have commit access. While I could of course take this ac= tion myself, in following the link above, I leave it to those involved firs= t. > Have a nice day, > Tomas Let me also thank you for your contributions! I look forward to one day see= ing you announced as a new committer as you continue to contribute. But I h= ope when you are on that side and make a mistake, as we all do, that you ar= e given the benefit of the doubt, a chance to rectify, and help us all do b= etter. John PS: I know tone is hard and easily (wrongly) assumed in written communicati= on. Let me stress that all I wrote was meant to be understanding to your pe= rspective and feelings (which I'm sure many would share in the same circums= tances!) while also helping us reach a mutually beneficial remedy. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 18:03:02 2024 Received: (at 69276) by debbugs.gnu.org; 6 Oct 2024 22:03:02 +0000 Received: from localhost ([127.0.0.1]:42685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sxZLB-00042g-IC for submit@debbugs.gnu.org; Sun, 06 Oct 2024 18:03:02 -0400 Received: from wolfsden.cz ([37.205.8.62]:39946) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <~@wolfsden.cz>) id 1sxZL9-00042P-1c for 69276@debbugs.gnu.org; Sun, 06 Oct 2024 18:03:00 -0400 Received: by wolfsden.cz (Postfix, from userid 104) id 56A2C32195D; Sun, 6 Oct 2024 22:02:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1728252171; bh=cb4aHEJGrXOcLuUbMUD9KoS/8K8YvhisNACzqtYLcyQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=CBnrwvDPYYls2ZTDFhB3zMJUlSnx6q+E4E0xeLhB+6jnErSTaYa6BF9SIdBAN8MVR BpZKudkFuBfQx4RGj66lbaA1IadA0+sXnffAFiOsbmI4biUqvTE1dPAiwJmgjBf3H0 Ulpxh0Vv8jDpvs40Pfkdy4fujSt3bUc++4tcDveHDtUIGkUvuUByyTgISpug7aUgc3 IXd1c57++nIjHqTACpfPH5yHCmaXmYY5xjHQa5pWQaiw6292CYM9KYXeBxlYHhoCD0 /0NHqD9kKZ2MbbJbiwhR5fCiNkROLUyMCH1hsTey02lHnqq2icv5GW3r6+D+MvmX9d sm3T0bDBJUqRWWU1ZvYjuItz7UCUwvQr/cs7GcKzWdu9djcs28wtwXwFCT87BmBq/C v1FfiHyl0b7U7E6dgSvGdKq35PC2q640A3MOeNtryAMNgZrG2lH+CblJ+5tH0Wq3nm IXAjrg3bqp8sz7TqqbNJSaGbxlAXlMDs5xgt1yochMCRPG4JKc/SifWGyPyKdHy1V1 T2OF1j8M+eIgX6ScBeIVECReVCeV5tYhYS+a6tJHrMThuYHmigwJd7dAX8en7MW3PK k8t0ssWYXINwVfn1g0uHEjHTcWKa0S7TmWzVMbCyIPcpP2Qp3icTQZuwr1sl20OE68 EL6xJz8XctFnKsQPuwKL3KRI= X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on wolfsden X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from localhost (unknown [128.0.188.242]) by wolfsden.cz (Postfix) with ESMTPSA id 8527231EDCD; Sun, 6 Oct 2024 22:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=wolfsden.cz; s=mail; t=1728252170; bh=cb4aHEJGrXOcLuUbMUD9KoS/8K8YvhisNACzqtYLcyQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=NtdYiqzsm8EmEZgg18G4PWawyjeUs1oLPVDbthV4iIeR1tPze6lqb+K7GcxTCa8tt ToJXRYOhIK1BVa2mp7/a7QzT9aB1sfnUjjpe/j3Q9DQ+UeGsrCPu5mo+FCggGu4ytn i4o+BwUjRLzoNjgzcS10h8DuKqxucpBXJ59fS4wAvF8JRTsZJH3gEvcI/x3skwW5GV Ud1WNF0jwbbEnW9zwTg/2PTCpbtVkRKu5TdtULGkVQUoHQjG7bko4zmcLSNloQzqzX 1VddlCZ3LhMg8BcpHlN6MzNTsqeS7GIV3EQVMVvVq6/L73fe4ie2oIbyTXJle2Rk5K 47KjT6AzSIamiebtVyBbpeQw/mcRFnieYHRCXhWcjxVzS5t6EWsLbHqHOX23kIRPKj iXVtSU6FytQLjlrBWw7A1rx9cHVLc+FgcTBe5XkE3iJegZT2cwImJhwyOduKAeLVQO 5lyB4roROc7DFCjOOwY/CCuQkTzukl+vqbZrJgL3V9ILVcilTcaZmqoW8iJUb7MAyd ApErOKzNLPMO42hApOuk2i8XcHQ7mVwiKBrH65hH0SJT0fUN771Td6kt6IdfxZpSUZ AcFkr/U/sVE3iRzLY8KMDZmSMwBkuD1U1aP0r35jaRHUTD4UjWmT9RWoKtdblq7tUI RxXUAUVELHHDAuZtJGguhkoA= From: Tomas Volf <~@wolfsden.cz> To: John Kehayias Subject: Re: 01/04: gnu: libtorrent-rasterbar: Update to 2.0.10. In-Reply-To: <87iku53uwy.fsf@protonmail.com> (John Kehayias's message of "Sun, 06 Oct 2024 19:15:16 +0000") References: <172820540113.1389510.12193329113919899297@vcs3.savannah.gnu.org> <20241006090321.C8D6A1C1D84@vcs3.savannah.gnu.org> <87y131xgoa.fsf@wolfsden.cz> <87iku53uwy.fsf@protonmail.com> Mail-Followup-To: John Kehayias , guix-devel@gnu.org, 69276@debbugs.gnu.org, Z572 , Adam Faiz Date: Mon, 07 Oct 2024 00:02:50 +0200 Message-ID: <87plocyjn9.fsf@wolfsden.cz> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 69276 Cc: guix-devel@gnu.org, 69276@debbugs.gnu.org, Z572 , Adam Faiz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello John, John Kehayias writes: > Dear Tomas (and CC'ing the debbugs number, co-author, and committer Z572), > > On Sun, Oct 06, 2024 at 07:52 PM, Tomas Volf wrote: > >> guix-commits@gnu.org writes: >> >>> z572 pushed a commit to branch master >>> in repository guix. >>> >>> commit 37dede4c4d8c25a786f2a2e2a17ba54b4ba6283f >>> Author: Adam Faiz via Guix-patches via >>> AuthorDate: Tue Aug 6 21:07:40 2024 +0800 >> >> I have to admit I am not very happy regarding the change in the commit >> author. While I understand the change itself might have been somewhat >> trivial, I did work with upstream to merge the required changes for >> 2.0.10, so having the authorship stolen like this leaves somewhat >> unpleasant feeling. >> > > I understand your frustration and while I thank you for bringing this to > attention (we care about attribution here!), I do think this was escalate= d a > tiny bit in the heat of the moment. I don't see this message in the origi= nal > patch thread with the other author (Adam) and committer (Z572, still rela= tively > new), so it is quite possible they didn't see this message you sent until= now. > > I should say, I do think it is good to raise awareness so we can all do b= etter, > but I think we should try to give some benefit of the doubt and look for = the > best way forward. Mistakes happen! I had accidentally lost the author of = some > commits and realized after I had pushed them, raising this after with gui= x-devel > and the original authors for what remedy they would like. Though everythi= ng was > okay, I felt bad, and still do, but at least it has made me more vigilant= . Let's > remember we are all trying our best here and imagine ourselves on the oth= er > side. > > (Side note that upstream work to help out Guix and packaging is always > welcome, so thank you for that! Though that is separate from > authorship of commits on the Guix side, of course.) Hm, there is probably little bit of misunderstanding here. Yes, I was (am) a bit sad about this happening, but I did not really meant the email as an "escalation". And I did not send it to the debbugs bug first. I was just reacting to the commit I saw in guix-commits mailing list. It explicitly has guix-devel set as Reply-To (instead of, for example, the commit author), so I assumed here (guix-devel) is where should I raise the issue. I fully understand people (me included) make mistakes and I did not (and do not) assume ill intentions here. However, re-reading my original message I do think I should have taken a second breath and tune it down a notch (or two), for failing to do that I apologize. > >> Especially since applying for commit access has a number of commits as >> one of prerequisites, having your address visible in `git log --author' >> goes from "collecting internet points" into "actually somewhat >> important". But even without that, I would still consider it not a nice >> thing to do. >> > > Part of having commit access is also accepting that mistakes will happen = and you > are expected to remedy, learn, and help us all do better (e.g. see > ). This > quality I would say is much more important than just number of contributi= ons, > though that experience is a more quantifiable prerequisite. > > As I hope a neutral third party, in this case I would suggest reverting t= he > commits and then reapplying them with author/co-author set > appropriately. While I appreciate the suggestion from a neutral party, I do not insist on that. This is just one patch of many that I have sent (and hopefully will send). I would very much prefer z572 to spent time on merging new patches instead of redoing this one. Many of my patches were applied by z572, and I am grateful for their work. > I think this issue should have been brought up more directly with the > parties involved, whether or not cc-ing guix-devel helps here I can't > say. I reacted on this above already, but I will put up an explicit suggestion: Maybe the Reply-To on guix-commits should be the committer. > As I said, I at least take it as a reminder of our responsibilities > and potential mistakes when we have commit access. While I could of > course take this action myself, in following the link above, I leave > it to those involved first. > >> Have a nice day, >> Tomas > > Let me also thank you for your contributions! I look forward to one day s= eeing > you announced as a new committer as you continue to contribute. But I hop= e when > you are on that side and make a mistake, as we all do, that you are given= the > benefit of the doubt, a chance to rectify, and help us all do better. As do I :) > > John > > PS: I know tone is hard and easily (wrongly) assumed in written > communication. Let me stress that all I wrote was meant to be understandi= ng to > your perspective and feelings (which I'm sure many would share in the same > circumstances!) while also helping us reach a mutually beneficial > remedy. I appreciate your reply and calm, neutral view point trying to find a common way forward. Thank you for weighing in. Have a nice day, Tomas =2D-=20 There are only two hard things in Computer Science: cache invalidation, naming things and off-by-one errors. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJCBAEBCgAsFiEEt4NJs4wUfTYpiGikL7/ufbZ/wakFAmcDCQoOHH5Ad29sZnNk ZW4uY3oACgkQL7/ufbZ/wamSSQ/9FTHSPHAI1sXRUwSSfCuNtnabi7BhKUtsgbpP KGBCK4o5KktfLgQB0TIt9M/iLDqUXeeXboQZ4129wxp4n5aYCs1ddsT5LKAMeFrL IUaeSnpzpDnDnouT6QG5rABFcMD4qPXl6XbHdYqH7VT2B9riHDlF3SPmgKv3sVi/ OKKxuRKSHqCK+Ime8TTuiWfYkALed75X6bwqYAqo7uOThmRbM2AsXAW3ys0FVlEK BWSVHEDKgLPNKup6ysE7wJ4ffRs2fU3/MnidRQRcJftCSDIdMiReIpZ4cMgqLHmy 046FqRWmXwbIuVk2j15tXItPxeGham7E7bJhn90eLwqyvp103BaVMxyLNqVs+z6v svT8ICpkmnd+GOiY1BTwCF1iJ5QHTezusyeRgtvAfP0hgC1PStSYrWQaBGyLKnK8 n965J2QjBHxfqHF62tMGFIVFCw64zIgG+bbZVmWNxlR/+TeCZqnGCiaCnNDt7UhT bDckFbLhXht/AV6JH7f/wHqqBdNTUPBKZl94T3fOjMKc6wRooL7JpRLFIrWomahp z/Ov7gi8IhumUOrw37222/K/803jAM/KkFFhtJ6vGTGBjj9OrgUElBvwXEK391pL 65uw/MtEWIqtcvJFCSkem/WfV56SVe0hz4JfuMxbO0TQef/vIY9mt60e/7VxhgKW GPmmyX4= =L4m1 -----END PGP SIGNATURE----- --=-=-=-- From unknown Thu Jun 19 14:06:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 04 Nov 2024 12:24:17 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator