GNU bug report logs - #69251
[PATCH] gnu: Add r-abbreviate.

Previous Next

Package: guix-patches;

Reported by: Wiktor Żelazny <wz <at> freeshell.de>

Date: Sun, 18 Feb 2024 18:34:01 UTC

Severity: normal

Tags: patch

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 69251 <at> debbugs.gnu.org (full text, mbox):

From: Skyler Ferris <skyvine <at> protonmail.com>
To: Wiktor Żelazny <wz <at> freeshell.de>, 69251 <at> debbugs.gnu.org
Cc: Ricardo Wurmus <rekado <at> elephly.net>
Subject: Re: [bug#69251] [PATCH] gnu: Add r-abbreviate.
Date: Sun, 18 Feb 2024 23:05:46 +0000
Hi Wiktor,

Thanks for submitting this patch! I'm adding some review notes to this 
thread in hopes that whichever committer looks at this patch will be 
able to process it more efficiently. It looks clean to me overall. I did 
mark "Project is maintained" as "Attention" more as an indication to the 
committer than to you. I think this is fine but it seems abnormal to me, 
although I am new to reviewing patches so maybe it is more normal than I 
think. =) If you have any additional context to add I am sure it will be 
appreciated! I will send detailed notes about this and everything else I 
looked at in a separate email. I welcome any feedback you have about my 
review process.

Regards,
Skyler





This bug report was last modified 1 year and 91 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.