From unknown Wed Jun 18 23:02:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#69251 <69251@debbugs.gnu.org> To: bug#69251 <69251@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add r-abbreviate. Reply-To: bug#69251 <69251@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:02:16 +0000 retitle 69251 [PATCH] gnu: Add r-abbreviate. reassign 69251 guix-patches submitter 69251 Wiktor =C5=BBelazny severity 69251 normal tag 69251 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 18 13:33:16 2024 Received: (at submit) by debbugs.gnu.org; 18 Feb 2024 18:33:16 +0000 Received: from localhost ([127.0.0.1]:38031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rblyW-000427-5h for submit@debbugs.gnu.org; Sun, 18 Feb 2024 13:33:16 -0500 Received: from lists.gnu.org ([209.51.188.17]:43612) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rblyU-00041v-Ff for submit@debbugs.gnu.org; Sun, 18 Feb 2024 13:33:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbly9-00057g-4a for guix-patches@gnu.org; Sun, 18 Feb 2024 13:32:53 -0500 Received: from freeshell.de ([116.202.128.144]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbly7-0005ha-9q for guix-patches@gnu.org; Sun, 18 Feb 2024 13:32:52 -0500 Received: from localhost.localdomain (cst-prg-31-100.cust.vodafone.cz [46.135.31.100]) (Authenticated sender: wz) by freeshell.de (Postfix) with ESMTPSA id B5579B4503E7 for ; Sun, 18 Feb 2024 19:32:40 +0100 (CET) From: =?UTF-8?q?Wiktor=20=C5=BBelazny?= To: guix-patches@gnu.org Subject: [PATCH] gnu: Add r-abbreviate. Date: Sun, 18 Feb 2024 19:31:36 +0100 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: Ricardo Wurmus Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=116.202.128.144; envelope-from=wz@freeshell.de; helo=freeshell.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) * gnu/packages/cran.scm (r-abbreviate): New variable. --- gnu/packages/cran.scm | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm index bcb5ab4964..2a5de1d907 100644 --- a/gnu/packages/cran.scm +++ b/gnu/packages/cran.scm @@ -116,6 +116,26 @@ (define-module (gnu packages cran) #:use-module (gnu packages xml) #:use-module (gnu packages xorg)) +(define-public r-abbreviate + (package + (name "r-abbreviate") + (version "0.1") + (source + (origin + (method url-fetch) + (uri (cran-uri "abbreviate" version)) + (sha256 + (base32 "1cvjdbi17qz8gr5898zchm5fyz4n51z66lwps25v8a9mhwab8imi")))) + (properties `((upstream-name . "abbreviate"))) + (build-system r-build-system) + (home-page "https://github.com/sigbertklinke/abbreviate") + (synopsis "Readable string abbreviation") + (description + "This package abbreviates strings to a specified minimum number of characters, +such that the strings remain unique (if they originally were).") + ;; The license is mentioned in the DESCRIPTION file. + (license license:gpl3))) + (define-public r-aer (package (name "r-aer") base-commit: fdbf4192f5eaa7fdb5e6e2e98ada0726c8104824 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 18 18:06:31 2024 Received: (at 69251) by debbugs.gnu.org; 18 Feb 2024 23:06:31 +0000 Received: from localhost ([127.0.0.1]:39939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbqEw-0001ia-VS for submit@debbugs.gnu.org; Sun, 18 Feb 2024 18:06:31 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:57939) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbqEu-0001iL-KK for 69251@debbugs.gnu.org; Sun, 18 Feb 2024 18:06:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1708297561; x=1708556761; bh=7VOjlIfm2nuqkddd9tHfdSoycCCM8yUt5nseDEmvzKk=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=TS7o6fhgaB7v1BQthydNxX2bV1Wm4mEbQCZE9SzkIoQaBW9qKhbQ8wo+GuKzF2TCm 6xptZW3Kg7nr0LZzjobVB7dgj3K8y9eplI07xmfWPLuSRbpr8C9ANbDvOH9PTJgmnl 6MwiY+0o/lOO1DQYMlVknMxK059dYMw549Xg2TFkVeRWGD9WqtKOPBby3h7cPEcoi0 8tBc7MXSm1D86u/FbYIB8xKnsjUrqzUEtZtl82cfUyv7mB/p1+U+aT5HdDUnpVS5hp dgAFm7WmkLQllZoITxlrZtbLZ7KNFjBbWVfNIKHghKZUl/V2/Hv30P9LV/bHhhfzJG vQCSyNBak6uPw== Date: Sun, 18 Feb 2024 23:05:46 +0000 To: =?utf-8?Q?Wiktor_=C5=BBelazny?= , 69251@debbugs.gnu.org From: Skyler Ferris Subject: Re: [bug#69251] [PATCH] gnu: Add r-abbreviate. Message-ID: <1f1e5f47-7d6b-4feb-8f8c-3a3b511a6385@protonmail.com> In-Reply-To: References: Feedback-ID: 40635331:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 69251 Cc: Ricardo Wurmus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Hi Wiktor, Thanks for submitting this patch! I'm adding some review notes to this=20 thread in hopes that whichever committer looks at this patch will be=20 able to process it more efficiently. It looks clean to me overall. I did=20 mark "Project is maintained" as "Attention" more as an indication to the=20 committer than to you. I think this is fine but it seems abnormal to me,=20 although I am new to reviewing patches so maybe it is more normal than I=20 think. =3D) If you have any additional context to add I am sure it will be= =20 appreciated! I will send detailed notes about this and everything else I=20 looked at in a separate email. I welcome any feedback you have about my=20 review process. Regards, Skyler From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 18 18:07:25 2024 Received: (at 69251) by debbugs.gnu.org; 18 Feb 2024 23:07:25 +0000 Received: from localhost ([127.0.0.1]:39944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbqFp-0001kA-Bu for submit@debbugs.gnu.org; Sun, 18 Feb 2024 18:07:25 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:19271) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbqFn-0001jv-05 for 69251@debbugs.gnu.org; Sun, 18 Feb 2024 18:07:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1708297616; x=1708556816; bh=L+HzX9yJiyn9ziwFy4NipK6KADwY2e4YAwzg4PQ2uuA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Xl+qV7/rvnwmUkrwQhCUDLqiklEfUwyjxDdb2F18MM9Lv/jQqrSTG+pDohkhCBqP/ PDK5Dqj90Skah7hztIQCwDYDthgZvvFLRKnW4AjbnDffUlnus5xPkh3uLLx+weCqdH pfsb7ssRi2HCt+n99gfOwCO450JITU3HD8wgvfo/byUEArcZ3ImWmk4fUmHEg5NUYw dAb/RwlI0fMkoeTSw9Bc6YlGv0/s4TkZBNT4PJRGFvjPtVsLQ0tazxOMX5f/mUsrz1 p89fnm/P4IUT/xa10339j3aKsEmthMjHBywErryBJJgoI0Oy5DCegWdMrbxMEtuit+ 9UhwJYl21227g== Date: Sun, 18 Feb 2024 23:06:44 +0000 To: =?utf-8?Q?Wiktor_=C5=BBelazny?= , 69251@debbugs.gnu.org From: Skyler Ferris Subject: Re: [bug#69251] [PATCH] gnu: Add r-abbreviate. Message-ID: In-Reply-To: References: Feedback-ID: 40635331:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 69251 Cc: Ricardo Wurmus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Each section includes a checklist based on (and expands upon) the items=20 listed in the manual (22.7 "Submitting Patches"). Each checklist item=20 may have one of the following statuses: C: Commitable. This item looks as expected for a final commit. CC: Commitable with Context. Like commitable, but some notes have been=20 added providing context about anything notable or unusual. These notes=20 are provided for transparency and should not be interpreted as meaning=20 that I object to the patch. MR: Minor Repair. There is something about the patch which I think=20 should ideally be changed, but I do not think that the patch should be=20 refused on this basis alone. A: Attention. Something in the patch needs attention from the author,=20 the committer, or both. Resolving the matter may or may not require a=20 change to the patch. XX: This item is not relevant to the patch. Blank: I did not review this aspect of the patch. [C ] Applies cleanly (commit fdbf4192f5eaa7fdb5e6e2e98ada0726c8104824) [C ] Commit message looks correct & complete [CC] Cryptographic hash [A ] Project is maintained [C ] Synopsis & Description [C ] Package license matches source license [C ] No compiler warnings (guix project, not package build) [CC] `guix lint` output [C ] `guix style` output [C ] Package builds (my host is an x86_64 Xen guest) [=C2=A0 ] Builds for other architectures [C ] No bundled software [CC] Works in container with minimal inputs [C ] `guix size` output [XX] Dependent packages (`guix refresh --list-dependent PACKAGE`) [C ] `guix build --rounds=3D2` [C ] Gender-neutral wording [C ] One set of related changes [CC] Simulated guix pull # Cryptographic Hash I was not able to locate a cryptographic hash for this package. # Project is Maintained All of the commits are from the end of 2021 and the version remains at=20 "0.1". However, the package is doing something relatively simple and=20 there are no open issues on the GitHub page (to be fair, there is only=20 one closed issue and it was handled ~2 months after the project was=20 uploaded). There were about 1000 downloads within the past month at time of writing=20 (https://cranlogs.r-pkg.org/badges/last-month/abbreviate), implying that=20 some number of people are using the package. Combined with the lack of=20 issue reports, this gives some confidence that the lack of new commits=20 is "this doesn't need any changes" rather than "this is unmaintained". # guix lint There is a note that the source is not archived on Software Heritage or=20 Disarchive database. The 'archival' section in the "Invoking 'guix=20 lint'" chapter (9.8) indicates that the Software Heritage will pick up=20 the source at some point in the future. # Works in container with minimal inputs I used the following environment: $ ./pre-inst-env guix shell -C r-abbreviate r > library(abbreviate) Then I entered some of the example commands from the README. The calls=20 were successful and produced reasonable-looking output. # Simulated Guix Pull I committed the diff locally and used `--disable-authentication`, which=20 I think is fine because the signature on the commit is unrelated to the=20 contents of the commit in this context. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 19 07:58:42 2024 Received: (at 69251-done) by debbugs.gnu.org; 19 Feb 2024 12:58:42 +0000 Received: from localhost ([127.0.0.1]:40662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc3EG-0004ic-NC for submit@debbugs.gnu.org; Mon, 19 Feb 2024 07:58:42 -0500 Received: from sender4-of-o50.zoho.com ([136.143.188.50]:21098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc3ED-0004iT-C6 for 69251-done@debbugs.gnu.org; Mon, 19 Feb 2024 07:58:39 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1708347490; cv=none; d=zohomail.com; s=zohoarc; b=RfT5gkDKEpE2KlNdQz1fzm/GMzDpntdSd8HCvI4rbc1mgOOQotYnDLYq1a7UEUqePHC0ks2tLMcFWskG4YDi1dysicZD3nwUkl1r7URoyUAbet1ho+CwxyLFUV/I51VVyUincCVA1ms5dmyTXEl9to0mADFLLzKYqAw9Df1ThQ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1708347490; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=luA0cTMysy7FtneYIVbjZ1dbDCqrfYYZEfMSPK3aT0o=; b=A1dIL3PvMP78/h0nBm26Q00XzqW9jfGvh/VaGf9ZYbmc/yJWJZRBGyWiWsGox5mxiaxM72lXrJymGHqCrK+eoph2sKE57Bp7COT7sKuWjO7x1KUwBtSln2vKPwKW8O1bY634bZGLv0Zo+xKIXSyra8G2BgECc9RKvypxlyUvod8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1708347490; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=luA0cTMysy7FtneYIVbjZ1dbDCqrfYYZEfMSPK3aT0o=; b=WCiz20xJdXCJ9Tg265+du7pQ3PPJCJlVxYhE/3c5SJwBc6w7LRK90R0wNzZRv9v6 hflJmWWQlL72QFiY9AYfp4YkczyICQfRo9jCuTm92ISDU2AD71BIRlv655YUgmnt9PZ GfaG+WfgRpNX6/OXxiVQKn1hKac1fe2/noMomY2k= Received: from localhost (171-109-142-46.pool.kielnet.net [46.142.109.171]) by mx.zohomail.com with SMTPS id 1708347488188288.5879007093869; Mon, 19 Feb 2024 04:58:08 -0800 (PST) References: User-agent: mu4e 1.10.8; emacs 29.1 From: Ricardo Wurmus To: Wiktor =?utf-8?Q?=C5=BBelazny?= Subject: Re: [bug#69251] [PATCH] gnu: Add r-abbreviate. Date: Mon, 19 Feb 2024 13:57:16 +0100 In-reply-to: Message-ID: <87h6i4ehlv.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 69251-done Cc: 69251-done@debbugs.gnu.org, Skyler Ferris X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Wiktor =C5=BBelazny writes: > * gnu/packages/cran.scm (r-abbreviate): New variable. Applied, thank you! Skyler: Thanks for the review! --=20 Ricardo From unknown Wed Jun 18 23:02:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 19 Mar 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator