GNU bug report logs - #69248
[PATCH] Fix flymake lighter tool-tip from generating errors

Previous Next

Package: emacs;

Reported by: Robert Burks <rburksdev <at> gmail.com>

Date: Sun, 18 Feb 2024 18:31:04 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69248 in the body.
You can then email your comments to 69248 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#69248; Package emacs. (Sun, 18 Feb 2024 18:31:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Robert Burks <rburksdev <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 18 Feb 2024 18:31:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Burks <rburksdev <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix flymake lighter tool-tip from generating errors
Date: Fri, 16 Feb 2024 19:07:12 -0500
[Message part 1 (text/plain, inline)]
With a non-flymake window selected, hovering over the flymake line lighter
of an inactive window generates errors.  This also occurs where the
indicators are shown in describe mode help.

The attached patch corrects this issue.

Robert A. Burks
[Message part 2 (text/html, inline)]
[0001-Fix-flymake-lighter-tool-tip-from-generating-errors.patch (text/x-patch, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#69248; Package emacs. (Thu, 22 Feb 2024 14:07:02 GMT) Full text and rfc822 format available.

Message #8 received at 69248 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Spencer Baugh <sbaugh <at> janestreet.com>
Cc: 69248 <at> debbugs.gnu.org, Robert Burks <rburksdev <at> gmail.com>
Subject: Re: bug#69248: [PATCH] Fix flymake lighter tool-tip from generating
 errors
Date: Thu, 22 Feb 2024 14:04:24 +0000
On Thu, Feb 22, 2024 at 1:24 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
> > From: Robert Burks <rburksdev <at> gmail.com>
> > Date: Fri, 16 Feb 2024 19:07:12 -0500
> >
> > With a non-flymake window selected, hovering over the flymake line lighter of an inactive window generates
> > errors.  This also occurs where the indicators are shown in describe mode help.
> >
> > The attached patch corrects this issue.
>
> Thanks.
>
> João, could you please review the patch?

No, but I'm copying Spencer Baugh, who has expressed interest in becoming
Flymake maintainer (and has my full endorsement, though I haven't worked
out the bureaucracy, if there is any)

João




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#69248; Package emacs. (Thu, 22 Feb 2024 14:33:03 GMT) Full text and rfc822 format available.

Message #11 received at 69248 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Burks <rburksdev <at> gmail.com>, João Távora
 <joaotavora <at> gmail.com>
Cc: 69248 <at> debbugs.gnu.org
Subject: Re: bug#69248: [PATCH] Fix flymake lighter tool-tip from generating
 errors
Date: Thu, 22 Feb 2024 15:24:28 +0200
> From: Robert Burks <rburksdev <at> gmail.com>
> Date: Fri, 16 Feb 2024 19:07:12 -0500
> 
> With a non-flymake window selected, hovering over the flymake line lighter of an inactive window generates
> errors.  This also occurs where the indicators are shown in describe mode help.  
> 
> The attached patch corrects this issue.

Thanks.

João, could you please review the patch?




Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Fri, 23 Feb 2024 15:49:02 GMT) Full text and rfc822 format available.

Notification sent to Robert Burks <rburksdev <at> gmail.com>:
bug acknowledged by developer. (Fri, 23 Feb 2024 15:49:02 GMT) Full text and rfc822 format available.

Message #16 received at 69248-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: 69248-done <at> debbugs.gnu.org, rburksdev <at> gmail.com, joaotavora <at> gmail.com
Subject: Re: bug#69248: [PATCH] Fix flymake lighter tool-tip from generating
 errors
Date: Fri, 23 Feb 2024 17:48:04 +0200
> From: Spencer Baugh <sbaugh <at> janestreet.com>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  69248 <at> debbugs.gnu.org,  Robert Burks
>   <rburksdev <at> gmail.com>
> Date: Fri, 23 Feb 2024 10:40:41 -0500
> 
> João Távora <joaotavora <at> gmail.com> writes:
> >> João, could you please review the patch?
> >
> > No, but I'm copying Spencer Baugh, who has expressed interest in becoming
> > Flymake maintainer (and has my full endorsement, though I haven't worked
> > out the bureaucracy, if there is any)
> >
> > João
> 
> The patch seems correct, if someone with commit access could please
> apply it.

Thanks, installed, and closing the bug.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#69248; Package emacs. (Fri, 23 Feb 2024 15:56:01 GMT) Full text and rfc822 format available.

Message #19 received at 69248 <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: João Távora <joaotavora <at> gmail.com>
Cc: 69248 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Robert Burks <rburksdev <at> gmail.com>
Subject: Re: bug#69248: [PATCH] Fix flymake lighter tool-tip from generating
 errors
Date: Fri, 23 Feb 2024 10:40:41 -0500
João Távora <joaotavora <at> gmail.com> writes:
> On Thu, Feb 22, 2024 at 1:24 PM Eli Zaretskii <eliz <at> gnu.org> wrote:
>>
>> > From: Robert Burks <rburksdev <at> gmail.com>
>> > Date: Fri, 16 Feb 2024 19:07:12 -0500
>> >
>> > With a non-flymake window selected, hovering over the flymake line lighter of an inactive window generates
>> > errors.  This also occurs where the indicators are shown in describe mode help.
>> >
>> > The attached patch corrects this issue.
>>
>> Thanks.
>>
>> João, could you please review the patch?
>
> No, but I'm copying Spencer Baugh, who has expressed interest in becoming
> Flymake maintainer (and has my full endorsement, though I haven't worked
> out the bureaucracy, if there is any)
>
> João

The patch seems correct, if someone with commit access could please
apply it.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 23 Mar 2024 11:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 89 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.