GNU bug report logs - #69237
30.0.50; Toggle password visibility

Previous Next

Full log

Message #74 received at 69237 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
Cc: michael.albinus <at> gmx.de, 69237 <at> debbugs.gnu.org
Subject: Re: bug#69237: 30.0.50; Toggle password visibility
Date: Sun, 25 Feb 2024 16:09:13 +0200

> Cc: 69237-done <at> debbugs.gnu.org
> From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
> Date: Sun, 25 Feb 2024 13:34:26 +0000
> 
> Michael Albinus <michael.albinus <at> gmx.de> writes:
> 
> >> * Should we keep the double hyphen in "read-passwd--toggle-visibility"?
> >> Feeling like it connotes "Emacs internals" somewhat, and wondering if
> >> it's appropriate for interactive commands since they are "user-facing",
> >> and users might feel discouraged from remapping "internal-looking"
> >> commands.
> >
> > It is not intended that users call 'M-x read-passwd--toggle-visibility'.
> > It makes sense only when you are already editing the minibuffer, typing
> > the password.
> 
> Right, I don't expect many users to run this command via M-x.  My
> thinking went more toward users who might want to do…
> 
>   (keymap-unset read-passwd-map "\t" 'remove)
>   (keymap-set read-passwd-map "C-c \t" 'read-passwd--toggle-visibility)
> 
> … and who might feel uneasy about that "--" in their personal config.

IMO, commands should never have two dashes in their names, because
commands are never "internal", by their very definition.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.