From unknown Fri Jun 20 07:22:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#69237 <69237@debbugs.gnu.org> To: bug#69237 <69237@debbugs.gnu.org> Subject: Status: 30.0.50; Toggle password visibility Reply-To: bug#69237 <69237@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:22:20 +0000 retitle 69237 30.0.50; Toggle password visibility reassign 69237 emacs submitter 69237 Michael Albinus severity 69237 wishlist thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 18 13:24:23 2024 Received: (at submit) by debbugs.gnu.org; 18 Feb 2024 18:24:23 +0000 Received: from localhost ([127.0.0.1]:37352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rblpt-0003Nx-WB for submit@debbugs.gnu.org; Sun, 18 Feb 2024 13:24:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:53956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rblSR-0001mW-8S for submit@debbugs.gnu.org; Sun, 18 Feb 2024 13:00:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rayL1-0008WQ-AA for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2024 08:33:15 -0500 Received: from mout.gmx.net ([212.227.15.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rayKx-0006hY-UB for bug-gnu-emacs@gnu.org; Fri, 16 Feb 2024 08:33:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708090383; x=1708695183; i=michael.albinus@gmx.de; bh=TEts3SGTnB3xXenAnfqf8y5JxsompCN+/KcFtD2qyCI=; h=X-UI-Sender-Class:From:To:Subject:Date; b=l0SPsPAXYbF71B6idcO/g74/wpVxAk5UNX/51qIpHIOXMG5L3WI5994SWCoB7UCq /3xsO2pYmrXIJ297T/A38jzTfY6atzCjoMT8gSVUAD5IpuDg5aFUVJRl8guFj/SHf OrvgwN3DgzBySJP9SnDzD3yzVMU+aJQv08F/K34fGBWMB2MGUiolZ5kYtHhJGZtdV uaZWh4sDv7K6KGEE8w7gzVSREs2cRq7Nl2F5HYyEB/qRlAw7rL+hcyxjaGEYalSs9 hR1HIwOeqGkZZuUyD+F6wdxh2gEuYKUEUnTACL9FENrbFOTNX1xqvi4zoiLe0rdEK jCVENsajqJMfT0vKdA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MSbxD-1rPbYl3zIn-00Szx0 for ; Fri, 16 Feb 2024 14:33:03 +0100 From: Michael Albinus To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Toggle password visibility Date: Fri, 16 Feb 2024 14:33:02 +0100 Message-ID: <87zfw0ttyp.fsf@gmx.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:u2M3ndXZ8KE8zkP/PmjSIiHQfqD9dKzUK4RWB6xW0dIuxQULrVX +HgfD7xctUK4jt6fm0RDiSKAqCO7Y5fME/yfnaRdnEvv4fX6yPxtrPJORxk4vuFU2UdyU7x djM8ajZjIBL5rGMILwFWc6TVQCLKGcOrK4V8I66ryWzMjo0oRNreLXhlLIKjU7otE7KelS+ YyDJAA1tr4fUIPjgfvFNA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:8Q2Qb6WLSy4=;T1o20lQXMp5ppunElqTLxPM2EP7 0U936keJnkDpjONtzFJoyELdLgayS0EFRXuxruVCdSytY8utzEPHL5kg6/BU06nXVAgdo7q7B zkCaraxG65Yo3qpwaNHXxC3ZovtIDrUQikCcSINEPWiu9IqKO3i7vf+T905qRpXBowF6HLjW5 WGHDoh2RECDr3PuQbeAYSyja8+Di3A5qmTalbGIk4io61txtT9dBUMWglSDTftl0J13CLTG9v UT3tqJLcmUpctRVBtjRkUpY/Gji7m3mQpbRWJCbdn6HkL9P37tpZ9gCwnVGGRKdD2TfGUDKLq ggN2cSEwAPeKIFAAIxjC4C/a/7JPyqjXE4hEzeURTs1sFjjoiqkU02d/fqw1gdieI36dBEfTF 9FL2YmrydJnooLk8tkx8qEJ96QaBdvc1nVuSm5k+UwV7s49ZCU03PYiqrrqFJfp0eYqABdPa2 EIXcfTqeVjuMdzvfw1erjdvp11JaKdPvGyhR9SIgXG7OgAUsujA2c0JkQuoQ66FSt9b4WKtGE OroaBfIgxaaxGYWNn77rdrpZbrCpmQ30hR55MXts0WjPwXRmzYiJ7P49i1i26EcF7lxVSvPr4 ZMSUA3JfyrZrbtSeRKb4BHVL0vjppG56COz48Kg9rq1M54/yD5ikTG20gIpt3F2/fP10rQ0lj 14cza50LCLZzN4U+pqYYtS2BJlakTeNH2HiZi8LVR54ZUJePSbEAg5EIYgAOYrPkOfK5e08q5 Dx+MwyyP5H0vBs7on1zTjVl3I2AqGFqKwkKxGEzfHbWCEVwynTXfysWfsaK6k9aAhfLJ0LTy0 ereP+mdwYtgDzNYWu8OV8WKMjJXM/mc1q7Pl5QIEw/LpsoGGCWRr+Ep08I4PcdowKO Received-SPF: pass client-ip=212.227.15.18; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: 5 X-Spam_score: 0.5 X-Spam_bar: / X-Spam_report: (0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: We have `read-passwd', which reads a password in the minibuffer, hiding the input. However, modern password input boxes outside Emacs allow to show/hide the input while typing. The appended patch tries to implement this feature. The minibuffer in `read-passwd' has bound TAB to a function, which toggles visibility of the typed input. Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.3 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [185.89.39.16 listed in zen.spamhaus.org] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (michael.albinus[at]gmx.de) 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.2 (-) --=-=-= Content-Type: text/plain We have `read-passwd', which reads a password in the minibuffer, hiding the input. However, modern password input boxes outside Emacs allow to show/hide the input while typing. The appended patch tries to implement this feature. The minibuffer in `read-passwd' has bound TAB to a function, which toggles visibility of the typed input. On graphic displays, the mode-line has an additional indicator for whowing/hiding the typed password. Clicking on this indicator with mouse-1 toggles the password visibility. Comments? Best regards, Michael. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.39, cairo version 1.18.0) of 2024-01-07 built on gandalf Repository revision: 166b10e9f80dc78147601a87b6425f59860bcfe4 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12302004 System Description: Fedora Linux 39 (Workstation Edition) Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LIBOTF LIBSELINUX LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8 Major mode: Group Minor modes in effect: gnus-undo-mode: t display-time-mode: t delete-selection-mode: t icomplete-mode: t global-goto-address-mode: t goto-address-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/albinus/src/elpa/packages/debbugs/debbugs hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs /home/albinus/src/elpa/packages/debbugs/debbugs-org hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs-org /home/albinus/src/elpa/packages/debbugs/debbugs-gnu hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs-gnu /home/albinus/src/elpa/packages/debbugs/debbugs-guix hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs-guix /home/albinus/src/elpa/packages/debbugs/debbugs-browse hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs-browse /home/albinus/src/elpa/packages/debbugs/debbugs-pkg hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs-pkg /home/albinus/src/elpa/packages/debbugs/debbugs-autoloads hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs-autoloads /home/albinus/src/elpa/packages/debbugs/debbugs-compat hides /home/albinus/.emacs.d/elpa/debbugs-0.39/debbugs-compat /home/albinus/.emacs.d/elpa/helm-3.9.7/helm-packages hides /home/albinus/.emacs.d/elpa/helm-core-3.9.7/helm-packages ~/lisp/telepathy hides /home/albinus/.emacs.d/elpa/telepathy-20131209.1258/telepathy /home/albinus/src/elpa/packages/tramp-theme/tramp-theme-autoloads hides /home/albinus/.emacs.d/elpa/tramp-theme-0.2/tramp-theme-autoloads /home/albinus/src/elpa/packages/tramp-theme/tramp-theme hides /home/albinus/.emacs.d/elpa/tramp-theme-0.2/tramp-theme /home/albinus/src/elpa/packages/tramp-theme/tramp-theme-pkg hides /home/albinus/.emacs.d/elpa/tramp-theme-0.2/tramp-theme-pkg /home/albinus/.emacs.d/elpa/hydra-0.15.0/lv hides /home/albinus/.emacs.d/elpa/lv-0.15.0/lv /home/albinus/.emacs.d/elpa/transient-20240201.1100/transient hides /usr/local/share/emacs/30.0.50/lisp/transient ~/lisp/dbus hides /usr/local/share/emacs/30.0.50/lisp/net/dbus /home/albinus/src/tramp/lisp/tramp-sh hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-sh /home/albinus/src/tramp/lisp/tramp-fuse hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-fuse /home/albinus/src/tramp/lisp/tramp-loaddefs hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-loaddefs /home/albinus/src/tramp/lisp/tramp-ftp hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-ftp /home/albinus/src/tramp/lisp/tramp hides /usr/local/share/emacs/30.0.50/lisp/net/tramp /home/albinus/src/tramp/lisp/tramp-cache hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-cache /home/albinus/src/tramp/lisp/tramp-uu hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-uu /home/albinus/src/tramp/lisp/tramp-rclone hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-rclone /home/albinus/src/tramp/lisp/tramp-integration hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-integration /home/albinus/src/tramp/lisp/tramp-archive hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-archive /home/albinus/src/tramp/lisp/tramp-adb hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-adb /home/albinus/src/tramp/lisp/tramp-cmds hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-cmds /home/albinus/src/tramp/lisp/tramp-compat hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-compat /home/albinus/src/tramp/lisp/tramp-sudoedit hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-sudoedit /home/albinus/src/tramp/lisp/tramp-container hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-container /home/albinus/src/tramp/lisp/tramp-gvfs hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-gvfs /home/albinus/src/tramp/lisp/tramp-crypt hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-crypt /home/albinus/src/tramp/lisp/tramp-message hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-message /home/albinus/src/tramp/lisp/tramp-smb hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-smb /home/albinus/src/tramp/lisp/trampver hides /usr/local/share/emacs/30.0.50/lisp/net/trampver /home/albinus/src/tramp/lisp/tramp-sshfs hides /usr/local/share/emacs/30.0.50/lisp/net/tramp-sshfs Features: (shadow emacsbug whitespace vc-dir ewoc conf-mode smerge-mode diff org-element org-persist org-id org-refile avl-tree generator oc-basic ol-eww ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view filenotify ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi org org-macro org-pcomplete org-list org-footnote org-faces org-entities noutline outline ob-emacs-lisp org-table org-loaddefs cal-menu calendar cal-loaddefs ediff-vers ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util hyperspec nndoc gnus-dup debbugs-gnu debbugs-compat debbugs soap-client warnings mailalias debug backtrace cl-print timezone find-func shortdoc help-fns radix-tree eww mm-url macrostep-c cmacexp macrostep cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs add-log vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs log-view pcvs-util pulse xref project grep display-line-numbers url-queue gnus-fun shr-color color flow-fill mm-archive url-http url-gw url-auth gnus-gravatar gravatar dns url-cache smiley gnus-cite mail-extr gnus-bcklg textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async cl-extra gnus-ml debbugs-browse bug-reference disp-table qp pop3 utf-7 nndraft nnmh nnml network-stream nsm gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-cache gnus-sum shr pixel-fill kinsoku url-file svg time-stamp nnnil smtpmail gnus-demon nntp gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr magit-base magit-section cursor-sensor crm dash compat mule-util sort find-dired vc-git diff-mode easy-mmode misearch multi-isearch rng-xsd xsd-regexp rng-cmpct rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap sgml-mode facemenu dom nxml-util nxml-enc xmltok image-mode exif dired-aux compile text-property-search comp-run comp-common face-remap ob-shell ob ob-tangle ol org-src ob-ref ob-lob ob-table ob-exp ob-comint ob-core org-cycle org-fold org-fold-core ob-eval org-keys oc org-compat org-version org-macs vc vc-dispatcher time tramp-sh lxc-tramp lxd-tramp tramp trampver tramp-integration files-x tramp-message help-mode tramp-compat xdg shell pcomplete comint ansi-osc ring parse-time iso8601 time-date format-spec ansi-color tramp-loaddefs rx delsel ido jka-compr icomplete cus-edit pp cus-load icons wid-edit dired dired-loaddefs goto-addr thingatpt alert-autoloads android-mode-autoloads auth-source-gopass-autoloads auth-source-keytar-autoloads auth-source-kwallet-autoloads auth-source-xoauth2-autoloads auto-sudoedit-autoloads auto-virtualenv-autoloads auto-virtualenvwrapper-autoloads boxquote-autoloads clang-format-autoloads company-shell-autoloads company-autoloads counsel-toki-autoloads counsel-tramp-autoloads counsel-autoloads dbus-codegen-autoloads debbugs-autoloads dired-du-autoloads dired-rsync-autoloads dired-toggle-sudo-autoloads direnv-autoloads disk-usage-autoloads dockerfile-mode-autoloads editorconfig-charset-extras-autoloads editorconfig-custom-majormode-autoloads editorconfig-domain-specific-autoloads editorconfig-autoloads editorconfig-generate-autoloads ednc-autoloads el-get-autoloads envrc-autoloads etc-sudoers-mode-autoloads exec-path-from-shell-autoloads fontaine-autoloads forge-autoloads closql-autoloads emacsql-autoloads friendly-tramp-path-autoloads fzf-autoloads ggtags-autoloads ghub-autoloads gited-autoloads gitlab-ci-mode-flycheck-autoloads gitlab-ci-mode-autoloads flycheck-autoloads gntp-autoloads gnus-desktop-notify-autoloads helm-gitlab-autoloads helm-projectile-autoloads helm-autoloads helm-core-autoloads async-autoloads ibuffer-tramp-autoloads inheritenv-autoloads ivy-gitlab-autoloads gitlab-autoloads journalctl-mode-autoloads keepass-mode-autoloads keytar-autoloads kubernetes-autoloads log4e-autoloads lsp-java-autoloads dap-mode-autoloads lsp-docker-autoloads bui-autoloads lsp-latex-autoloads consult-autoloads lsp-treemacs-autoloads lsp-mode-autoloads f-autoloads lxc-tramp-autoloads lxd-tramp-autoloads magit-filenotify-autoloads magit-autoloads pcase git-commit-autoloads magit-popup-autoloads magit-section-autoloads marcopolo-autoloads mastodon-autoloads nexus-autoloads nnir-est-autoloads oauth2-autoloads ob-restclient-autoloads orderless-autoloads persist-autoloads pkg-info-autoloads epl-autoloads popup-autoloads projectile-autoloads promise-autoloads pylint-autoloads python-environment-autoloads deferred-autoloads pyvenv-autoloads recentf-remove-sudo-tramp-prefix-autoloads request-autoloads restclient-test-autoloads restclient-autoloads s3ed-autoloads finder-inf slime-autoloads macrostep-autoloads spinner-autoloads ssh-deploy-autoloads su-autoloads sudo-edit-autoloads sudo-ext-autoloads sudo-utils-autoloads swiper-autoloads ivy-autoloads sx-autoloads markdown-mode-autoloads telepathy-autoloads totp-autoloads totp-auth-autoloads base32-autoloads tramp-theme-autoloads transient-dwim-autoloads transient-autoloads treemacs-autoloads cfrs-autoloads posframe-autoloads ht-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads treepy-autoloads uuid-autoloads vdiff-autoloads hydra-autoloads lv-autoloads vertico-autoloads virtualenv-autoloads virtualenvwrapper-autoloads s-autoloads dash-autoloads web-server-autoloads wfnames-autoloads with-editor-autoloads info compat-autoloads yaml-autoloads yaml-mode-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 886899 163552) (symbols 48 39461 3) (strings 32 179866 14690) (string-bytes 1 5887530) (vectors 16 96047) (vector-slots 8 2459540 118160) (floats 8 849 18205) (intervals 56 34351 1182) (buffers 984 108)) --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable diff --git a/etc/images/README b/etc/images/README index a778d9ce6c3..77377d36b5a 100644 =2D-- a/etc/images/README +++ b/etc/images/README @@ -125,7 +125,7 @@ For more information see the adwaita-icon-theme reposi= tory at: https://gitlab.gnome.org/GNOME/adwaita-icon-theme -Emacs images and their source in the Adwaita/scalable directory: +Emacs images and their source in the Adwaita/symbolic directory: checked.svg ui/checkbox-checked-symbolic.svg unchecked.svg ui/checkbox-symbolic.svg @@ -137,3 +137,5 @@ Emacs images and their source in the Adwaita/scalable = directory: left.svg ui/pan-start-symbolic.svg right.svg ui/pan-end-symbolic.svg up.svg ui/pan-up-symbolic.svg + conceal.svg actions/view-conceal-symbolic.svg + reveal.svg actions/view-reveal-symbolic.svg diff --git a/etc/images/conceal.svg b/etc/images/conceal.svg new file mode 100644 index 00000000000..172b73ed3d3 =2D-- /dev/null +++ b/etc/images/conceal.svg @@ -0,0 +1,4 @@ + + + + diff --git a/etc/images/reveal.svg b/etc/images/reveal.svg new file mode 100644 index 00000000000..41ae3733a53 =2D-- /dev/null +++ b/etc/images/reveal.svg @@ -0,0 +1,4 @@ + + + + diff --git a/lisp/simple.el b/lisp/simple.el index 9a33049f4ca..667b6c84a66 100644 =2D-- a/lisp/simple.el +++ b/lisp/simple.el @@ -10858,6 +10858,80 @@ visible-mode (setq-local vis-mode-saved-buffer-invisibility-spec buffer-invisibility-spec) (setq buffer-invisibility-spec nil))) + +=0C +;; It would be preferable to use "=F0=9F=91=81" ("\N{EYE}"). However, th= ere is +;; no corresponding Unicode char with a slash. Therefore, we use images. +(defvar read-passwd-show-password-image "reveal.svg" + "Mode-line image to show a hidden password") + +(defvar read-passwd-hide-password-image "conceal.svg" + "Mode-line image to hide a visible password") + +(defvar read-passwd-mode-line-buffer nil + "Buffer to modify `mode-line-format' for showing/hiding passwords.") + +(defvar read-passwd-mode-line-string nil + "Propertized mode line indicator for showing/hiding passwords.") + +(defvar read-passwd-mode-line-display nil + "Display properties for `read-passwd-mode-line-string'.") + +(defun read-passwd--toggle-visibility () + "Toggle minibuffer contents visibility. +Adapt also mode line." + (interactive) + (with-current-buffer read-passwd-mode-line-buffer + (setq read-passwd--hide-password (not read-passwd--hide-password)) + (when (display-graphic-p) + (setq read-passwd-mode-line-display + (find-image + `((:type svg + :file ,(if read-passwd--hide-password + read-passwd-hide-password-image + read-passwd-show-password-image)) + :ascent center)) + read-passwd-mode-line-string + `(:propertize " " + display ,read-passwd-mode-line-display + help-echo "mouse-1: Toggle password visibility" + mouse-face mode-line-highlight + local-map + (keymap + (mode-line keymap (mouse-1 . read-passwd--toggle-visibilit= y))))) + (force-mode-line-update))) + (read-passwd--hide-password)) + +(define-minor-mode read-passwd-mode + "Toggle visibility of password in minibuffer." + :group 'mode-line + :group 'minibuffer + :keymap read-passwd-map + :version "30.1" + (setq read-passwd--hide-password nil + ;; Stolen from `eldoc-minibuffer-message'. + read-passwd-mode-line-buffer + (window-buffer + (or (window-in-direction 'above (minibuffer-window)) + (minibuffer-selected-window) + (get-largest-window)))) + + (when (display-graphic-p) + (if read-passwd-mode + (with-current-buffer read-passwd-mode-line-buffer + ;; Add `read-passwd-mode-line-string'. + (when (listp mode-line-format) + (setq mode-line-format + (cons '(:eval read-passwd-mode-line-string) + mode-line-format)))) + (with-current-buffer read-passwd-mode-line-buffer + ;; Remove `read-passwd-mode-line-string'. + (when (listp mode-line-format) + (setq mode-line-format (cdr mode-line-format)))))) + + (when read-passwd-mode + (read-passwd--toggle-visibility))) + =0C (defvar messages-buffer-mode-map (let ((map (make-sparse-keymap))) diff --git a/lisp/subr.el b/lisp/subr.el index c317d558e24..2f475891df9 100644 =2D-- a/lisp/subr.el +++ b/lisp/subr.el @@ -3375,14 +3375,23 @@ read-passwd-map (let ((map (make-sparse-keymap))) (set-keymap-parent map minibuffer-local-map) (define-key map "\C-u" #'delete-minibuffer-contents) ;bug#12570 + (define-key map "\t" #'read-passwd--toggle-visibility) map) "Keymap used while reading passwords.") -(defun read-password--hide-password () +(defvar read-passwd--hide-password t) + +(defun read-passwd--hide-password () + "Make minibuffer contents hidden or visible." (let ((beg (minibuffer-prompt-end))) (dotimes (i (1+ (- (buffer-size) beg))) - (put-text-property (+ i beg) (+ 1 i beg) - 'display (string (or read-hide-char ?*)))))) + (if read-passwd--hide-password + (put-text-property + (+ i beg) (+ 1 i beg) 'display (string (or read-hide-char ?*))= ) + (remove-list-of-text-properties (+ i beg) (+ 1 i beg) '(display))= ) + (put-text-property + (+ i beg) (+ 1 i beg) + 'help-echo "C-u: Clear password\nTAB: Toggle password visibility")= ))) (defun read-passwd (prompt &optional confirm default) "Read a password, prompting with PROMPT, and return it. @@ -3420,18 +3429,20 @@ read-passwd (setq-local inhibit-modification-hooks nil) ;bug#15501. (setq-local show-paren-mode nil) ;bug#16091. (setq-local inhibit--record-char t) - (add-hook 'post-command-hook #'read-password--hide-password n= il t)) + (read-passwd-mode 1) + (add-hook 'post-command-hook #'read-passwd--hide-password nil= t)) (unwind-protect (let ((enable-recursive-minibuffers t) (read-hide-char (or read-hide-char ?*))) (read-string prompt nil t default)) ; t =3D "no history" + (read-passwd-mode -1) (when (buffer-live-p minibuf) (with-current-buffer minibuf ;; Not sure why but it seems that there might be cases wher= e the ;; minibuffer is not always properly reset later on, so und= o ;; whatever we've done here (bug#11392). (remove-hook 'after-change-functions - #'read-password--hide-password 'local) + #'read-passwd--hide-password 'local) (kill-local-variable 'post-self-insert-hook) ;; And of course, don't keep the sensitive data around. (erase-buffer)))))))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 18 14:01:05 2024 Received: (at 69237) by debbugs.gnu.org; 18 Feb 2024 19:01:05 +0000 Received: from localhost ([127.0.0.1]:38302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbmPQ-0001lo-3X for submit@debbugs.gnu.org; Sun, 18 Feb 2024 14:01:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbmPO-0001XU-Bv for 69237@debbugs.gnu.org; Sun, 18 Feb 2024 14:01:02 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbmOy-0001uE-6m; Sun, 18 Feb 2024 14:00:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uj5DhTW39gmweqWXfiL3cHyXfJenYwetKh1oZwXSojk=; b=JnkQYfjmbT9A geods9y/QniVx+aoIxv+ELb7QwHyJzIJoI/6pVD20qx2UgOeUKq6F6oLpBr6jRiWEgj3XYOPKA1MM y4if/C+bcyRha3/jnnyu5Ox+x7kti6U2CwhGucmb25OKUlH42LQ0CO0otx19FPLunVV1qn+UD+0A/ 7LOLfvkJnqHrzv2fIRACrfq091EZ2uJ++pBq7xo4v+pNVSggFjUfYROTN5+N+yIgGGGCeipIpy4lv QAg450vHxKfqqPliFXsmwtU99HaD3GF7XlM9ocsbzQwIrLDC1QUQaUuLD6TaQH1PgDwa4LIq4jZ+d jzLV5vAkNCXWHEQ7gizF3g==; Date: Sun, 18 Feb 2024 21:00:28 +0200 Message-Id: <86v86lr41f.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-Reply-To: <87zfw0ttyp.fsf@gmx.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#69237: 30.0.50; Toggle password visibility References: <87zfw0ttyp.fsf@gmx.de> X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 69237 Cc: 69237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) > Date: Fri, 16 Feb 2024 14:33:02 +0100 > From: Michael Albinus via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > We have `read-passwd', which reads a password in the minibuffer, hiding > the input. However, modern password input boxes outside Emacs allow to > show/hide the input while typing. > > The appended patch tries to implement this feature. The minibuffer in > `read-passwd' has bound TAB to a function, which toggles visibility of > the typed input. > > On graphic displays, the mode-line has an additional indicator for > whowing/hiding the typed password. Clicking on this indicator with > mouse-1 toggles the password visibility. > > Comments? This is the 3rd bug report about the same issue. Did something go awry with debbugs today? From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 18 15:00:46 2024 Received: (at control) by debbugs.gnu.org; 18 Feb 2024 20:00:46 +0000 Received: from localhost ([127.0.0.1]:38391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbnLB-0003uo-Pf for submit@debbugs.gnu.org; Sun, 18 Feb 2024 15:00:46 -0500 Received: from mout.gmx.net ([212.227.15.15]:49367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbnL9-0003ua-G1 for control@debbugs.gnu.org; Sun, 18 Feb 2024 15:00:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708286416; x=1708891216; i=michael.albinus@gmx.de; bh=+DVsU5oZUB4jDfOoVYQyUooj+EdxLqjP+9oFT36eXUg=; h=X-UI-Sender-Class:Date:To:From:Subject; b=g008dLX2gZY1Ky0M79Yge12k2UiVsg+1KlsrgKfWE9v9LQ4EI2/3Rr6HVOQddbfo /7917mJkY1mP7MNRZR7fQ6IZU3yUShenfCoSLyt/LKNAuRC0+Wk/hLH4dFSvM4goU PExYKBz70vOA4waLJxgvEghSimPlb8SXNmA1e9HJzTqZWJJxgG5cpqRztmh3QAKtA L2FVLJwtjuEK32ppNKzNfmewG2x82hEWJTzQ7Ax2cQ1FVkMX79Fzsoavm1OyUFhgH 9u034qBtyWRFnKN9lC/SEbm5SY2HX+7JJQOwIbTAeMRjhKXFsUv+5rs8bhRnBGtep UyX3xCn7bhu90oK21A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M6llE-1raB2M1YVS-008J32 for ; Sun, 18 Feb 2024 21:00:16 +0100 Date: Sun, 18 Feb 2024 21:00:15 +0100 Message-Id: <87ttm5sfu8.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #69237 X-Provags-ID: V03:K1:E5jE34kP6rZNIrtdDSgTiHu9WpY6l+5xFqiHAp+EYkC1CuDtkLw waYzbRQf7q/Lwp7GqipXCoiUuqIiewFL7vXu6omZZZHpBfh4ZlREDYPw6CP048X5d/ITH+g P0Sd2LN2mFVAjVrrPPTXls93tv6ymtCJ4732bUXNRj1awop5Zu0+CB+cY1HPHHnZR7QH+6b DAwSvOHNzEZkJ/MHKwZCA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:rFQrVMCKwts=;HhuAzcmUt9SPmLB0SZBKRUYTzGL OjSP6Xdme0nm7CqgMdei3xvN+lhGvw/I59nh+WcON7lPywhYGIwU8zibVLEaI+q24xjKeu15v hag5T9+zF8z2pj4mLO+HzyVqwPSE5dmjgxBTFcABmxaadNQaMMW1htVS4ydHiJXTtj5KffNnO TbUFwcYjnIKtNd1yI5IFBGOPkRBjmwdcUgBdH7a6iTsqbcIc8+dazPMvWtQS/CRjT2LFtHhnk qgvcCkCkgz8C9pFbtyxcNenmkH7O5tx6etcBSljv2FCFPjkPPLfOVRkfPdAqOoY3ytLvSyXAs 5fArlAUX9Z3bWqc1zfeNaufy2PEgSzLorf+0Z5cZCFyH45LHM6U9qIpDXUu3yP6vv+yozvLhX FJm+lxtR46Zjc7obcpiiTe66NpXuB/Fo5KDSz8tj9db+rA1bDYiF/vOzoohDz8Y39dtnI+6H8 qzfMK5W/kU9OZb4zwpb3iGUjh9O6AoEYVujSQqdXD9im8iORELunOnE9PqR5KCreYPQMjarOK tAW25Jww3G+Yr31buUvGCEdJBpyJ9hbNPR0QM/AbmDkhe5tHvIa4X5Y6Wk7K+5tIkb4lCSyfY zbu1aMz37k47dW/o/LwyPgCpCoTVYIcaZyvS4rBtiRL8ZodaoDFutH6XuB8J+aGM2BOym4TxZ /EWLuEt2GcOq84aQElXC4s8Grt+KBrGJek1E06cs2b/NBcebEURWkPmogrB/wOJjm6ivwn8OA fLEM82CZOpjhdzpG0Nes/UkkugloW0FR4mRK96QJ6c3XgNRSl2JMI4GHyPomMqa9L1jusjfrV vakNhPvif0v9tVVhaZS1w8ERK+wUKbHC1eFzbEdtl+tHihqj4xkMT4YmyR31qKYeH3 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) merge 69237 69222 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 18 15:01:06 2024 Received: (at control) by debbugs.gnu.org; 18 Feb 2024 20:01:06 +0000 Received: from localhost ([127.0.0.1]:38396 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbnLW-0003w9-41 for submit@debbugs.gnu.org; Sun, 18 Feb 2024 15:01:06 -0500 Received: from mout.gmx.net ([212.227.15.19]:56267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbnLT-0003vD-2q for control@debbugs.gnu.org; Sun, 18 Feb 2024 15:01:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708286436; x=1708891236; i=michael.albinus@gmx.de; bh=EZPAonfKdYkLwXrdGsu9yn3IiYMR7Xf2vutXIDkRvE0=; h=X-UI-Sender-Class:Date:To:From:Subject; b=MTQJCu55LQdDRH+O052t5wViPiDaKFaXBSRhFSBL9fAjdVfLSPr/+ig0RC4tTMZH j49rP5lQQCebiMXX6qwkvPUHV9MpvFDGvTIYJUot+MssP0vSEq85WtE36RwRLBozl r0nErkazDVF1xsbLB2gQlZJTGrlbxtvCEeENZY0+fmBZT/yUarITSj2Mej06N52+b cewOoP2b+/sS5Xs4f/C3dm9JEFyfoGXxmRyAkhVqAB9XIicJGmDP/GyfQq2HtAGLl h7crnBftlmar5gvKvrUWdpgazoEt6Zj6jr2whQ1ft87Az8l2IHpO77LD9HhS1p1V0 VLbgpDprBnvP5XCT1Q== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MvbFs-1qlceo2gXm-00sh3U for ; Sun, 18 Feb 2024 21:00:36 +0100 Date: Sun, 18 Feb 2024 21:00:36 +0100 Message-Id: <87sf1psftn.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #69237 X-Provags-ID: V03:K1:JkQugTDTc6w+hWc23MRVlvNqYa8/lDt0ImsU/LRKlmd5/AuEAyo Wf9zu0HLhagvxSUJoUqiN2WZ7krf/UdRBgw1SMivemV5r8kf9EvVBViXl8ysM0/PLdMP/fH AbFXj0CkVanV1epK8oJKkszW2dDA/MFrkMBBPjOUs999VHG3UX/9k3R01aS/KQNGtklKGo4 SuQ1QFYBxAM8KIOjhv9CQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:/Z6Xst01Qzo=;hAPCKcebsSQ8vAQ6lZ66JgJNcex sLCVaWLf2NEcgoSqQ4cOclOvOzbDtFpOEWd2JiizVhfHHe+mlqkeW9NAtnIwOzezO24OHA6KQ dsHeh8Fo7g/hNpEichEJbSdhQFR/EC1So15kmkcvVN+peizjwVIFwaaYz//xjXuRxjiCyeuNW XVIdDwSbeKeKskRpzPL8ZOz8Amh1gxwasCQkVMoe3MxQ+bV/iNhGc8TqjWjtaUXeJKS/IBi1M FH+4CNwk0AwS67LYweqoc0yzhXr2G/SwjQSU1ExpJ10VfXg+WNKxBQ9eKs6Bj4GqXHc01HgCM hDv6fPomLJwwKKqIWt1DGqgm4gKz3Z9+hYAHPYoQkrfFifgMx4V8gk/GiLxI5ox4qxiV1THBs LRFPqHlugehkFkHlLOpkmsRB9yljbcROfrYhgtwyphzSVVHY742QEmqF48t+/mJXF4pCKsA2r +k3wGlbPu7Af+c4rdiimj9MBeKhnTbiGQ1HTt89hDWoXUpdlYerLbBN54KNAO+1n7/pA7gjCZ j/ti/D5xwTI15WmKSerlKkqhM6++txxKGMG92XnkUrFH8U+ZsfNMhxUPlmaNx9Ejsppfp6mwE 92yoINUAF9oI/685mQo3h0hey1iFWN7bEUXgTPW5rxdX3IH/IvoGjWSXLS9OQOzJ7CeOxOAUs FFfuldidgfejeCDUG7bzY40j8APVwoeRPf6bSs3RO1Dm5Pu+z8qt9AxNXvn042/Yz1SD8MwJW 1woW8ddeUYZH0kJM1ep33BWs/H1RAd908ATcV4QlTVddnxRDr87Pyz3BVzBOvYaLADb0ItmDK WK49noamXQ4PX/FAhOiM6hajBuZUc6mAd4ChCtJdfcfmd0kiZyHNgbon5Fp9l3azap X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) merge 69237 69235 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 18 15:04:30 2024 Received: (at 69237) by debbugs.gnu.org; 18 Feb 2024 20:04:30 +0000 Received: from localhost ([127.0.0.1]:38404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbnOo-00041w-2K for submit@debbugs.gnu.org; Sun, 18 Feb 2024 15:04:30 -0500 Received: from mout.gmx.net ([212.227.15.15]:52289) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbnOm-00041b-BT for 69237@debbugs.gnu.org; Sun, 18 Feb 2024 15:04:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708286642; x=1708891442; i=michael.albinus@gmx.de; bh=ahCrbs0x46xOtZPWdqo+1kDuzGlc9RLZXtQrdFsfFuQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=YMC0VyD/E3Qc+wv/3nrnsr6od8hhvXFkr0189sYgaXF5JxAAQzDr0kTJeg56CC0T T5a+2FQaNEsCwYEeRjRwjZ+gQJjs/ld20aZyO1brU3ICUvswiioDHd7ZTQjwycmCz ZjoYJUrByPNmknw7RugEP+afYJ7Jj5q8XGDfZ+n36evgEnvTvv6DKDKvF/DT2sSEn +dGU+eOMYBbptwtpsIvjpKXhtNABrvpMK7h8M0tMEBviA1bt3sNAjzu2Gg3Xkng8g bZx0uTUS/lUsle1HKVVIYVu0tE9CdzONF7uzayFZKxUHWMScRzrMaHjSmL4gnoRMc xG0PQylOXnuHeqGvjw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1McYCl-1r6K7w42NJ-00cyg9; Sun, 18 Feb 2024 21:04:02 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#69237: 30.0.50; Toggle password visibility In-Reply-To: <86v86lr41f.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 18 Feb 2024 21:00:28 +0200") References: <87zfw0ttyp.fsf@gmx.de> <86v86lr41f.fsf@gnu.org> Date: Sun, 18 Feb 2024 21:04:01 +0100 Message-ID: <87msrxsfny.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:QFcf+LfYTuam7+0kiKEt1Q/aiFGVT2PyIQvZhxjxGBMgZws9n1d OAD9tnHsfCdd1aMcmlhZ1zz23y7AD6rHWj0HvbSty3j2v1PxLdVD//4+zsh+2Wb/n8BR2Vn RV+28hU90l63w9fy1XZZ9pgqXiWBz6BOm6vAZQtQxLq9IK2gOejsbF8bOzv8HEBxkR01F0U rDP6D5LFfvJVFegRuWBPw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:ExTPoM1GxfI=;HksHPhr6uuGc1ZX9eynh4R3qqXw IzpcwR0rFwGC1od5nZqPagjUznr8teo6ROFlrTE4KBwJJ9SyQips5ip2WnhZqlDPJioCtlYuY fc6bnQP7Rgl77zwxPB796XEaaOn1fJpnJhG5iqaUa5FWyHSlZydMcA3MzoAt2YU6lRZl6grX0 MzcmkcRExnvlNX44KG5S5I6q5sUIliUQIaN4kWRsM4UgR0DFmfvQq1x8yP8nqzaa5/naTRXXG I4QRjSfug+kZgbODI3jxLvIp8AcZhqg7w1rry7yIXbENpLVOBgrfZhCZxA4vr/Ra8b38i153R ZKuBvYpdRkvM6mJuknzKilPcw+tguW6jpa5Hwy9G5jaej51CqcYAYlBVe3H9ytTmDEtQhrF6Z YnU4hxmRpXwKRxZH8SVqboRv3HqdT9L0Tya46bzyts4k/q/xeYB82yaBJGeKLlOa9NPDY2QTx 4wQ0lfh6BF4UEtclISfe5v0KFPOkuzGCD4U0u+DR7VR+V1kkmg9zItUoCFgswMSMHgk3sSecK x09at41fy98sKjgMBzmU5KqlIHZXt8bNxxPOWloCKpBiY1Q4opG4O0VLBpt0m6TzsR/CIxO40 ONghT6X0JyQnyQq0KytjuGR/ts9VtXln4AkcNPTXdXg3599vRkrtqIkXxJpfwDZAfMDy28og/ 5YAyHcO5fJ09uPvdUgdEzeMg35f4tt6TI7IHDhLMKo0O4ZuMRs1Vh3jvz+fKed+nf+YbW5JZa Silh18ww5T36bJRpW4WldhsJIdfH+4wUyeGrXclzEaTe+doOs8obHFaP2Av+FzddxxGvqd/6i SfG/7zqpLZf0UWSOVDNx+989N64r6dC4ap61b+jyNOnr3p5SwSTUJYS99jlV3SqdyV X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 69237 Cc: 69237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Eli Zaretskii writes: Hi Eli, >> Comments? > > This is the 3rd bug report about the same issue. > > Did something go awry with debbugs today? Yes. For some days (since Thursday or so), debbugs.gnu.org didn't handle new bug reports. See also the messages about on the help-debbugs ML. I've merged the first two reports with this one. Pls reply here. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 19 07:21:48 2024 Received: (at 69237) by debbugs.gnu.org; 19 Feb 2024 12:21:49 +0000 Received: from localhost ([127.0.0.1]:40541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc2ea-0006cr-FN for submit@debbugs.gnu.org; Mon, 19 Feb 2024 07:21:48 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc2eZ-0006cc-8c for 69237@debbugs.gnu.org; Mon, 19 Feb 2024 07:21:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc2e8-0002JJ-7C; Mon, 19 Feb 2024 07:21:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4QJQXqEM5W2HzRFe/bki9Qf0WcvjmZNTAS0OO/tyVJ0=; b=gUPB3Kx7ltr+ WhpHmjLMaPpgDJrDE4Bv8iH8Y8/AKQjQDZ8a9t9SQnjrWEHXagiU5AW5eAhiZFcLXImBG+KWrXpHQ lJ0lhIGhMaUU5I59ScqjE7F74Nj8kLmgybQ6gFrcWySaf9xNjmoF0HdKk9N+vLVsHACrz8ZqxpPG3 /K3358qmvD35/xmR4O0bazUhXjYm84gnrcpYJ7VfvV1KW4sELet4oErGWOS0Cjj9jsxjz0HIw6WX/ zMwk2iQ/F1w1S59DdJrpaUp7ZXKoRW2Rmw+on8DU0QJgbfm7tEU2FQ/08FLnwHIQNEM9yQYXEXTDc xuGh8guDNDWAnxrtb3IaYA==; Date: Mon, 19 Feb 2024 14:21:16 +0200 Message-Id: <8634tor6f7.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-Reply-To: <87zfw0ttyp.fsf@gmx.de> (bug-gnu-emacs@gnu.org) Subject: Re: bug#69237: 30.0.50; Toggle password visibility References: <87zfw0ttyp.fsf@gmx.de> X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 69237 Cc: 69237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) > Date: Fri, 16 Feb 2024 14:33:02 +0100 > From: Michael Albinus via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > We have `read-passwd', which reads a password in the minibuffer, hiding > the input. However, modern password input boxes outside Emacs allow to > show/hide the input while typing. > > The appended patch tries to implement this feature. The minibuffer in > `read-passwd' has bound TAB to a function, which toggles visibility of > the typed input. > > On graphic displays, the mode-line has an additional indicator for > whowing/hiding the typed password. Clicking on this indicator with > mouse-1 toggles the password visibility. I'm not sure TAB is the best candidate for this. I think it would be better to use some non-character key, like F9 or somesuch. And another one, for keyboards without function key. Also, this needs the appropriate documentation changes. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 19 10:55:26 2024 Received: (at 69237) by debbugs.gnu.org; 19 Feb 2024 15:55:26 +0000 Received: from localhost ([127.0.0.1]:43246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc5zK-0007CS-7K for submit@debbugs.gnu.org; Mon, 19 Feb 2024 10:55:26 -0500 Received: from mout.gmx.net ([212.227.15.15]:41069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc5zH-0007By-Ff for 69237@debbugs.gnu.org; Mon, 19 Feb 2024 10:55:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708358096; x=1708962896; i=michael.albinus@gmx.de; bh=r7W+6imQHhT9zN3V3N97dS8icg100X58hRjR1vOFSvc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=Jc4IM/pqb+Mf1HULsSiSsXs/5Dx+pC6PmvXOLdj0YYPuAb2X5giqVLgxz8+EIO6c 7ZjW/Sca/Tai2sBw3+zYc+bPfg4/HqBL/o5PkC92idFWNgVfcVlm8W2dPyM9gmJNd JiRINV+QoqmvxFnsN67Co0hEXSSK7/bUYUpfZWOfzir4CITSCKKjKI7N9tWoE3sLZ iYcgZLzQQnfG/m4hLGIIUt0lfghmU1pRyxAnx5Q4lICbR5i8LviL3JqgeISeNmw/o mv6qn4cq7oz42DJRVEm0FNf8cfMcgrCTkCoOC1GCUc7M+B0W6+xt3gZe8hmQ+3GRa qcihA0lMTBT7hpgyQw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MV67o-1rTkVq0G0c-00SBN3; Mon, 19 Feb 2024 16:54:56 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#69237: 30.0.50; Toggle password visibility In-Reply-To: <8634tor6f7.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Feb 2024 14:21:16 +0200") References: <87zfw0ttyp.fsf@gmx.de> <8634tor6f7.fsf@gnu.org> Date: Mon, 19 Feb 2024 16:54:55 +0100 Message-ID: <87cyssih4g.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:PvyzH8LLiMMECyOtGmIK4ODoSSYrrYzHJxy04iXoqGy36PV0b7U qNxoGvNvpbi5wh+FIuhrbUA+nMId4Rn4kBCJVTcY99EaNs7Q9xh6/FYFwxmwiEk8W21USs3 pdjjxhSFkKpOQJa+Xu62OkCRvyPl4PzSfKUzSHOHpSw43NDu1ZyH+Fqt8f84mKW06HimiO0 6hc8/nLrGetT0tYrpFKTg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:X/1D6lQBQJY=;mb8+9HUmDQNYIM5oXk6Q4P0W70x jUZxpqO17pN22SUH//mufy8OEha842aIqBqNMUNRjzOFbYLd7QhEF+nIcSveim5BVhmZGeCkv ySyhYH7p9XLbL4XfsAb1jxdw+9zild83IiIhT0wwlI+UHMBjrLfsCuQ2hUO0L3yEptnjDXUde kJlxD6Ea5chKqQjZs0cMFXkI4g44+io4y7Z67llYS0qQ+KXPc2wUN4VCX4Dr8nOpkW1589qrH 2K04/PrSh1HsNi7tAcTIB8lJNJBonRh0gRvPebaIHZ0GhYQAcSfkksv95E5g/dSG5YSEopisL xKsxCgq4u/uCcrQBJGWEYTBJKLMGXAP97NO15eeRfm9kPSQhBVVqT8oEkCT85mAu3F6h/XDBO jQFlmDR18UOuCay3FvlhpIhpL/3Gj8+SfklyIlFpFvsTZZt1gQevWUKmTMIOwNrt6zpbyvo7l iOLgUk0c5TKxcqVGRsSMRzvabzOunS29IVM02SGnWH9wuQA5yY/MVCCpy8holKxBjXxTU2DnV jZiPeAeKW/P92bNYnvmM4u1YmpXEIrwEwkrhrGx3aLLK1rS8S+aa1fH7jx842iS2fazyAqwvx VmBRdo57oTSm2DBSkNomqgVg2XV8tmdGNaFPqQbajQxg33CgRVP94p6ThGKNrs+CrzpoRuhBq oHmNRN0P+iUEo0KtwDNDIRiWPVQxNwyFYJNmQPAPlAI16sRjDYC+OgCeFoTI4WKlBQF5d01Yf En1KGoRTZrgsRWmnkczD8Lo+mq1IHrOGg8OQhQqTwQcI3vXreIzGSeF3aLgy/EM+52DpGIZfK QSI9OUeLBriy07znHBJeEOMfYP0jCa4VildJmbNyWaWuwyrr+9WhBmBT3I5dwKyD5v X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 69237 Cc: 69237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Eli Zaretskii writes: Hi Eli, > I'm not sure TAB is the best candidate for this. I think it would be > better to use some non-character key, like F9 or somesuch. And > another one, for keyboards without function key. As usual, I don't care too much about this, so I'm OK with any proposal. However, out of curiosity, what's wrong with TAB? I'm not aware that any password contains it. > Also, this needs the appropriate documentation changes. Sure. I've postponed this part until I know that the feature as such is accepted. > Thanks. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 19 10:55:44 2024 Received: (at control) by debbugs.gnu.org; 19 Feb 2024 15:55:44 +0000 Received: from localhost ([127.0.0.1]:43249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc5zc-0007DJ-Jx for submit@debbugs.gnu.org; Mon, 19 Feb 2024 10:55:44 -0500 Received: from mout.gmx.net ([212.227.17.21]:35957) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc5za-0007Cx-SX for control@debbugs.gnu.org; Mon, 19 Feb 2024 10:55:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708358116; x=1708962916; i=michael.albinus@gmx.de; bh=tA3WPILVAJAuf62BzJs0385t899Lr/ubvnY46lOt7U0=; h=X-UI-Sender-Class:Date:To:From:Subject; b=oJcWA8gHiPsJgWzfqn+y5NJOumCoEa6plTC1tf8LGyyehB8zTpBzLQ1i/krE/5L4 L3bqwG1HvL5ZfCzl9E25nH2HbH55FJG3ZEIuO0Ypq+dAZo2y88lz5IyILBLrOjmHt A/TM/DeKsrSBAJHsRXIuywlJOEFtz0Gh0xdiUjmotHTdPMVIPdjA0JFvtW4aDsNz9 rFKOtKbaBjrmoip/eBe9iaVMH0+RYYWvrRQqtK7bFl0DZHRVYRQ7kzUnqySTQYLB4 puJj9YCQNOt2hr3KrXD06T0pnRlFgsM51NlO6up5wfbdJuRY8IYmB1f8SvVdgArLb UM7uJF+Jc+cSfCXjQA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mplbx-1rAP0Q36FR-00qDiO for ; Mon, 19 Feb 2024 16:55:15 +0100 Date: Mon, 19 Feb 2024 16:55:15 +0100 Message-Id: <87bk8cih3w.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #69237 X-Provags-ID: V03:K1:Fhhn+dUY5YGD+ozz3nsm59POKWgHrkhQowDLH7y82uGW1rOoAJS lTbbApWRvrvSwL+nGTyzHFx56jd65TfsceKF+oy7kD8q6sCf2iNHj+hUdqGtKEb6Yx+fE/S swe9/fOlqR+xEgHVqAK+pWpRcGXkR1RHGrd3c9UlbCWcSC17/mEcXlscKnfNd/+KK5nawzQ 8oJYcxyDk7LlzasqDO9WA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:2y2nw6NlDO4=;DHS+bp4XSeWZUzm6UC2XJA4s6SV jvVxmFdWJjX8DPy/o5HxA9y8WvOAVYZyUcQVW8GLYe8EzJeVlfK/ehZCxv6elxwsVGVI5NlPT yymI4RMcB6e4Yzmhf7FCbF0REFFsHJwqOSoIt6Hi8HbxuMlAjVlXRa8tRsp3S1wkItlD4dpGl 4hum9osruT97BmR5A9Xit+zto530aWBFzbWHK7x2RxBHtOv8f8HhbihkxudC39fSnyAivlPIU A9DgcysN1HLS101wC/nthYWVRDsZCl+yREA/ZKSYwNZiSjpyjWZ2Lxw7BOdtEPwQFj/VGy8mi ijaRraxUKmYp6hQKPxMS51CEIdC97tpT9Mt652yz0scdhmZEtycLlx4IkW6n0K/Tb44ecVjiB u0iwQpbB+uHH6cQ1OtJA4qH5TPFDd4ZOxn7W9b6fEMiNW1Ojbx3MobVv2+p1Tx1Qo4ygypLQ/ s2ONlTdMVIbZJw/piqRM2u7SWiou23ccFXdsYdE05MVedX/7/1Zvego9V2moPMUZDMAQusMkq JuuDFTHxiSnG4KP4nhpnGNzfin7eHaP5+Ca0F/nIH2NSqOQDbVtZPoL8uxvmrEIs/PjeUHl6o xd+iu/SpSkMHxQZcJQBI7+BeoXdJn6BjIeapNPvUhuQUlH5pcDLYC79CoXkBeD12dB2QmbSHo KY6urUX/V1OnKXWh7RbvJvjBhBOxI4jA5c7ZpaIoHD/uZ2TaVEY2HKFs7CByE4qHveK/NYdkH SqJ7lEBB8qFL96+RnPuABdZ9kZN8HDzXu6UU6q8tyqOWyeEImqKmRe58t7/HEP2QyJqGv6ZEd rS4M5cqZJ5oxOkhX+BtZ1hSrSETIYSSSCJ6dHaReZSEKMVOo60VL7O3s7lovKQV5FX X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) severity 69237 wishlist quit From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 19 11:48:41 2024 Received: (at 69237) by debbugs.gnu.org; 19 Feb 2024 16:48:41 +0000 Received: from localhost ([127.0.0.1]:43304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc6or-0003Fe-3r for submit@debbugs.gnu.org; Mon, 19 Feb 2024 11:48:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc6op-0003Ep-25 for 69237@debbugs.gnu.org; Mon, 19 Feb 2024 11:48:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc6oN-0004t1-LQ; Mon, 19 Feb 2024 11:48:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dDrOCSx0WqYV0YP5seYwcjeuLGNIXcAmEe7LpPg6BG8=; b=flks7TKnhvAl JzEqIcYxPT+i8I73KSP/RtH7AEh2Z/zc15kydkVT5qM+Zq/LPYM5YPc4pXyHcwcT4CRjQYSdNxBd4 grT3nKtQntFCJy4Z2T/9ftb3l0JzOFwm4x8GRo49joYrx1zDrdvJ25pwGazYEv21tB5OAB5KZmLMV L6rttxU1K1wW8wYtAIISIff07rCFgqdoI3hKFT/xaEUZB1F9ax4lA0U/ME1csC15mo9irt7sqezmV LcswL8pCCaJGfz+s9MqZ7kZ++RE9XiQ5fu6hwMkWWhMrVF/IpgDi1GB71qpFlzjvOanBscZWsi2kR BU9goYsRt/BVtGpEzLzwqw==; Date: Mon, 19 Feb 2024 18:48:07 +0200 Message-Id: <86il2kpfi0.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-Reply-To: <87cyssih4g.fsf@gmx.de> (message from Michael Albinus on Mon, 19 Feb 2024 16:54:55 +0100) Subject: Re: bug#69237: 30.0.50; Toggle password visibility References: <87zfw0ttyp.fsf@gmx.de> <8634tor6f7.fsf@gnu.org> <87cyssih4g.fsf@gmx.de> X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 69237 Cc: 69237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) > From: Michael Albinus > Cc: 69237@debbugs.gnu.org > Date: Mon, 19 Feb 2024 16:54:55 +0100 > > Eli Zaretskii writes: > > Hi Eli, > > > I'm not sure TAB is the best candidate for this. I think it would be > > better to use some non-character key, like F9 or somesuch. And > > another one, for keyboards without function key. > > As usual, I don't care too much about this, so I'm OK with any > proposal. However, out of curiosity, what's wrong with TAB? I'm not > aware that any password contains it. Is it impossible for TAB to appear in a password? If it is, the TAB is okay, and my only reservation about that is that TAB is not generally interpreted in my mental model of "advanced" input patterns as something that hides/shows stuff. TAB is more about completion and similar functionality. But that's me. Let's hear opinions from others. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 19 12:09:30 2024 Received: (at 69237) by debbugs.gnu.org; 19 Feb 2024 17:09:30 +0000 Received: from localhost ([127.0.0.1]:43322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc790-0003tr-1W for submit@debbugs.gnu.org; Mon, 19 Feb 2024 12:09:30 -0500 Received: from mout.gmx.net ([212.227.15.18]:48353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc78v-0003tZ-RU for 69237@debbugs.gnu.org; Mon, 19 Feb 2024 12:09:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708362537; x=1708967337; i=michael.albinus@gmx.de; bh=rH1keO4lvFpN5kk14LW2SXP6//5M1/xeegKPH53x+Xs=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=XHiSwDBGSatSQZ5tDRFWhxWXfzPZHB1ayjHo/sMM4oeSiIyR9M4DqYKqCPlmM4aK BPvyt0TPJWIt3MS8zjvHr7gmXu2CpWk2Efs5HmirCFBMO605u4tXqSwvTlJ25Nw49 RTSHkHBmXxlCp43J5G+aZCwAaAohpKsrpSxQ4ZgF/pOvxVF5u4bRq6RkJfiLf8W3M KqpmJmV2LyZQlsMkOYdo0owrzprfseSnmLD1KcXt4lyO4juEo7P9c9wkheS2gMxCG M3S0/CcCWlVxysMm0d/B87ETIbDGGK2YnTFUjKxd16qkaWyQQYPuppLAlA4CRbQXx JV6aglQnYW7PZc/L1A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MHoRA-1rh7LL16PO-00EtWw; Mon, 19 Feb 2024 18:08:57 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#69237: 30.0.50; Toggle password visibility In-Reply-To: <86il2kpfi0.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Feb 2024 18:48:07 +0200") References: <87zfw0ttyp.fsf@gmx.de> <8634tor6f7.fsf@gnu.org> <87cyssih4g.fsf@gmx.de> <86il2kpfi0.fsf@gnu.org> Date: Mon, 19 Feb 2024 18:08:56 +0100 Message-ID: <87wmr0gz4n.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:TvN6nIERVIeL9CFxTjMnnvH7vPWMONYQEdJozvw24rvZCQua/LJ W8mXB+FEmNAEx6TBAzdBHc8EBYo6hJiNmf8x66Qdpd8m9//bdVI/03CkNTMG9E0GH+qaFOu 1aaHmvCTdyYy6Pk7WXTIm3UvS0dOkGQ88aM5gV6ybqsTFwaczBgRKZ/cvf6JcCOXsLXobRJ qHNqqY189R/w9FDiMSl0w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:OpDhWJmRrTY=;3yyflxIK53sF6g62Sb7TR/viFME q6Nn+leRdTcISA/Y+rekw8K4XNdk60qya9LW8QqE7pmER4wcGeMrnp1lqYdWFrDJ6kUI1JfhF xjdGoRF3u9Ld0PqViv/ZzzZqQIuAbpj8IHq2vjkK7UCZCxla8LDjx2OYfbFgseYzHiZK5whRc L5aF0nOxsMU/tS5whd8oGhiAsnDdriic6V36ya7LUMXqi01PKHUD5VUlF539n9RULwTttNOye lrNAZJp6EfeH13hLG/yo7r3UBYzFeNLuXDRIvWKUDMiPTSJPOqHzcNDjq+Pwa529hDV0gsNp8 PZVX2KmmyYpnWLTxTvTGhXTePXxbjlIq78o/CYDqpCACuSEPUczxZTRBSz/wkn1yhVimdSkWk qq5yulau+GBSYv6pp14+y1JqYQEE005qSFSb7cr6U7ro+hK8iV5MblmCm+WDJ5smS5uRpi4AN wC+kYci5zZmtcyExbCdyvtI7kREJ56+WQy0Vob8RaV7/sJKVoVGdjz9+ogWGyqna4y5DT55P5 JjZHYTl8rjuwZPH8jsdk91I/2TR6YgTrrSllCwDxuQRSeYLeZ1XKcOJgZ7Yp0iAXNmtTpj62p +GG6LdT+AmTDPSWfcwHDjc4mRtqBABkSioeCFisGKAjD3QJ15m3aho5gy4NNeOxuGLBlOd/YX PsEywmC7V/5OLDzwrffT93dR2juanC9GqwC54xdmOh/DC76RHBlYx/a/0cAG9a2MJgZZt/nBM c+y09c0J91Ml6wScb9kjfUMwHXCCHDZaWonyZ5vUHWEsfb+L9yRLH7J3VIkytvN5ltkYnOwoW N+dr1LVh7E1Nedg2x1cDl29erExWsbIDIvspvjcOHNjZxEQWUHdr+KKxONqrEwfINY Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 69237 Cc: 69237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Eli Zaretskii writes: Hi Eli, >> > I'm not sure TAB is the best candidate for this. I think it would be >> > better to use some non-character key, like F9 or somesuch. And >> > another one, for keyboards without function key. >> >> As usual, I don't care too much about this, so I'm OK with any >> proposal. However, out of curiosity, what's wrong with TAB? I'm not >> aware that any password contains it. > > Is it impossible for TAB to appear in a password? Passwords are often entered in HTML pages with a special password field, derived from text fields. On HTML pages, TAB is applied to jump to the next text field or anchor. See . So I doubt that TABs can be used in passwords. See also the discussion in the sytemd issue , where Lennart Poettering has said something similar about systemd-ask-password. > If it is, the TAB is okay, and my only reservation about that is that > TAB is not generally interpreted in my mental model of "advanced" > input patterns as something that hides/shows stuff. TAB is more about > completion and similar functionality. But that's me. > > Let's hear opinions from others. Yep. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 22 17:32:29 2024 Received: (at 69237) by debbugs.gnu.org; 22 Feb 2024 22:32:29 +0000 Received: from localhost ([127.0.0.1]:36709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdHc9-0003Fd-UI for submit@debbugs.gnu.org; Thu, 22 Feb 2024 17:32:29 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:61813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdHc4-0003F0-AD for 69237@debbugs.gnu.org; Thu, 22 Feb 2024 17:32:24 -0500 Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4125df3c40aso1795885e9.3 for <69237@debbugs.gnu.org>; Thu, 22 Feb 2024 14:31:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708641051; x=1709245851; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vQYK2dAKe89+ZxvaQurGeE4vke8q77RwUpOjSRLikwY=; b=cgoEOnoVhbAw/DDnR0Zd7gdbdscJpatgCgaxwssYcoc367PjNvgIteKHi3QMGtxBrC EpeFbd6Aqxl6miHwTkJ1HpiMHr7xH/XqK3KJIqz0CR+Sc+3ol9ccrm7CxY5wxSeMueV+ V/96Rt6E/ekXJ6HLIt9F896ub/MjofHMh8yDIebzO3oS4h8NrQsqJzbo5x11JfOVDwb7 qLjiL7g6M1K7868KWLJoPixVjehxcdz7rWESh/8lSH6zDSAqv5uz8VoaiBi7G8WzYr43 D/bQzptd+o70V85aGCqzMjojo0fhjrjM6eZQ2Eu0/OH3QCcgTZZVQ0IlZ62g455HCvY8 cNkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708641051; x=1709245851; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=vQYK2dAKe89+ZxvaQurGeE4vke8q77RwUpOjSRLikwY=; b=YW6mw/6vV15p26cjLeJe1QIvlC3t3qsa5zNIYIYEycVaQjVjlENh8WUBgVlKCU9t26 3gmX/102mfSXnrcOXRQAenFWL9EF6W7RANzyLk7mNTtMbu/7/11jxnDJLBJ1fAJKCrik kR251IsE8Wjti4cr3EnQ0hnFzovf6Srp4+vUhaJ+O4aFerduP4LC1mJbeDIOHPI3zPOM zONX/ir6GREpr304z46aMKhz5eTJe0310kJMQVuUzyEMZuq+pEcpYxY+oGoAw0FUcY12 0xBbt/l39cys1sUGThGTXUc9gH7EPbzBEfN+kToErqudJxRetMtMxZ3e1AtVw9ALTxVJ DIhA== X-Gm-Message-State: AOJu0Yy0lO8nNyLH8wC7t2tyePp26JWI85I1mm21uwxlbV/tCh5hexG8 VNyZJaB9rz1trdnZwRc7r/9SoXhpS9K8yDowU4AZOk9zJv4EI9px X-Google-Smtp-Source: AGHT+IHZ2+Ss2GOunq1n1or/r1IfykxqFPY3geszs/IY+QAJJHZehZhL6Ihe993VBlL4ybLHEXFTBg== X-Received: by 2002:a05:600c:218b:b0:412:16d8:d565 with SMTP id e11-20020a05600c218b00b0041216d8d565mr61737wme.15.1708641050698; Thu, 22 Feb 2024 14:30:50 -0800 (PST) Received: from hirondell ([194.42.239.18]) by smtp.gmail.com with ESMTPSA id g8-20020a056000118800b0033d8871acc3sm368832wrx.77.2024.02.22.14.30.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 14:30:49 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#69237: 30.0.50; Toggle password visibility In-Reply-To: <87zfw0ttyp.fsf@gmx.de> (Michael Albinus via's message of "Fri, 16 Feb 2024 14:33:02 +0100") References: <87zfw0ttyp.fsf@gmx.de> Date: Thu, 22 Feb 2024 22:30:48 +0000 Message-ID: <87h6i0xhbb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 69237 Cc: Michael Albinus , 69237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > We have `read-passwd', which reads a password in the minibuffer, hiding > the input. However, modern password input boxes outside Emacs allow to > show/hide the input while typing. > > The appended patch tries to implement this feature. The minibuffer in > `read-passwd' has bound TAB to a function, which toggles visibility of > the typed input. > > On graphic displays, the mode-line has an additional indicator for > whowing/hiding the typed password. Clicking on this indicator with > mouse-1 toggles the password visibility. > > Comments? Thank you so much for working on this! I've had my own half-baked implementation of this for months; never took the time to polish it up and submit. No strong feelings re. keybindings; I've been using C-c C-c because I wanted something easy to mash, but TAB fits that criterion as well. Not sure we can leverage any well-established mnemonic from other keymaps; FWIW=E2=80=A6 * TAB could be familiar to some outline users, but they'll probably associate that binding to (un)folding, not necessarily hiding/revealing; * hideshow has multiple bindings for "toggle-hiding", so not sure we can count on any single one having enough "mindshare". (Not too worried about needing to input TAB verbatim - I tend to naturally reach for C-q TAB when I need to do that, since in most contexts Emacs has a useful command bound to TAB instead of self-insert-command) Other than the keybinding, the only other musing I have is regarding the indicator: wondering if icons.el could help trim some of the boilerplate down. In any case, it would give the user some degree of control over how the indicator is shown (via the icon-preference option) even if we don't provide 'emoji nor 'symbol variants. Not overly familiar with that library though - if that's something you think might be worth looking into, the define-icon forms in outline.el might help you assess how helpful the library would actually be. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 23 10:43:55 2024 Received: (at 69237) by debbugs.gnu.org; 23 Feb 2024 15:43:55 +0000 Received: from localhost ([127.0.0.1]:48860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdXiM-0001js-4A for submit@debbugs.gnu.org; Fri, 23 Feb 2024 10:43:55 -0500 Received: from mout.gmx.net ([212.227.17.20]:57257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdXiI-0001jP-1k for 69237@debbugs.gnu.org; Fri, 23 Feb 2024 10:43:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708702998; x=1709307798; i=michael.albinus@gmx.de; bh=lKmCQCL6fjzgBZzmuUEa0F8P/WhlIoS15xtrzIbZL94=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=b4MvOCsZQouVCVIVwSyvMB3+pF+e5uQUSZG2hZGhOtBeSUkNz0Gb4UuzwabdKyCL UPtTWYe1D/cuPRmWXYTlSbK5WrWC05kHryJ7BIYcxpO386pk1DmTSm9lBqR2CV0mg 8WdZBQp4QF0pr6L47gE0UxMEcYBu+WGAQfMOz4eBIhOD4hlujXlvQhvYKKqPJe9UV TH6tJDkkXrZOVSy1CKlcbk37iaYMUIseiDf6H8FvZlojAch3hd1c5zu+OV3l28UsH aWbioXODlLKWnBCS3RFQOuoIk/lGIuOJ5OIyHR6Xy54pHErEXvrhhfPUIFtmW/uit Utf8f1nYbdrpaFS3OQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MQ5vc-1rHb0A1qhU-00M7OF; Fri, 23 Feb 2024 16:43:18 +0100 From: Michael Albinus To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Subject: Re: bug#69237: 30.0.50; Toggle password visibility In-Reply-To: <87h6i0xhbb.fsf@gmail.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Thu, 22 Feb 2024 22:30:48 +0000") References: <87zfw0ttyp.fsf@gmx.de> <87h6i0xhbb.fsf@gmail.com> Date: Fri, 23 Feb 2024 16:43:17 +0100 Message-ID: <8734tjrxt6.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:haPgsuOgR67ZgKObRNZO6QEVJmuGiJZLqQB3k6Yia1S0Bu/6hyQ aBCzeZsRD6gizJp8KeiTkpInJKViXSMc345glQx055X2GIm4PmPKebkHzo4eT4+iOvP4bTs 5V0NqANwgPjWTVuBmg7PMvSD444KwqOxBIQTB9UPofQBqah8X34HtS0ZY8xuRsbNTxaDVCK MKLJwTqXsWNHL0UzF3lEQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:jHrF/NxZHuo=;XSpMoh9e9IDj83bQ+CLZGmAAdTa vTBf6SIZHXPqkLrn2fRSHMDwWXwHZOrrQJJV5fvmo/75lOTW0N/g1CwI21n8KMG1DLDBmXiBl MBobo8EdoAyeLY9kKptOGDv8HSvfb3hk9uhSrzL5FauVx+CfzJPiUTg1eJYP5xDgyopmm4s1j Cl+GroHDHs2hjPMDHHeM4JG3TayDjHzBIO+NBMVFPGo0wEvwdTQdnboXz0+XqkLWy9JtbUkGI YJgXXbQaHbcGaxM7hwxWgOnz2xvvKqMT4+M9yakAs+e703HdoYe5ME1qDqnrCvkzxNvpGCSMC j+bszimGOrT7w1VLVZXImR4WFpAkdU6abbRxTvWibFTF01qv9BMGdOEi/Cb71JJPVQC0GAMuL XPJjW09Ov7orKagDAFMCi0tRojYTVt5+8cmwz2gTIiK4MtW/3kTP2kby7jcsNmAFiKwXMOTeW 9qk6hw5csUPg4lE8ARkcqJ2oto1W8FIdU+27x0Nz/9vl40YS8Y8FjdN77yuq1Q2No+Mox5Sv6 iTUqlPvmjWDNxgo9KdvB/0yF7gCdzNhmySZC56za2rQAkERQ7ZlkliMkOUky/ErNoBAiMWHq4 63UNFgoI9G0YcOm4VhkTMe9Yu5gJWIGSmsa1avqcG514aAN2hmLHOfDXZdJ9lAXJ4YwZ5Bse8 kSeyISezOK1zE0NZjTRYVBv4vUl3L3U+RoIAdsf6/qNMInatQHbcGvPlkGEI8BauCK/F3zZ7U r/41gaZmC3VdeKZ+XrpmJt3WKtySiCJHTPa3IKOjCXjKjmv+/uUr/YCq6x2OWl+vvR6dfu9YX CahJQ2e1g3XxzqtxxhPpIbigP51gRi2jXT2CExr3tFkgQ= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69237 Cc: "Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors" , 69237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable K=C3=A9vin Le Gouguec writes: Hi K=C3=A9vin, > No strong feelings re. keybindings; I've been using C-c C-c because I > wanted something easy to mash, but TAB fits that criterion as well. Not > sure we can leverage any well-established mnemonic from other keymaps; > FWIW=E2=80=A6 > > * TAB could be familiar to some outline users, but they'll probably > associate that binding to (un)folding, not necessarily hiding/revealing; > > * hideshow has multiple bindings for "toggle-hiding", so not sure we can > count on any single one having enough "mindshare". > > (Not too worried about needing to input TAB verbatim - I tend to > naturally reach for C-q TAB when I need to do that, since in most > contexts Emacs has a useful command bound to TAB instead of > self-insert-command) There are not so many comments on the keybindings. I guess this is because only few people read the bug-gnu-emacs ML. Let's install this on master, and see who hollers :-) > Other than the keybinding, the only other musing I have is regarding the > indicator: wondering if icons.el could help trim some of the boilerplate > down. In any case, it would give the user some degree of control over > how the indicator is shown (via the icon-preference option) even if we > don't provide 'emoji nor 'symbol variants. > > Not overly familiar with that library though - if that's something you > think might be worth looking into, the define-icon forms in outline.el > might help you assess how helpful the library would actually be. That's a good idea. I've implemented it, see the reworked patch appended. And now with documentation. Best regards, Michael. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable diff --git a/doc/lispref/minibuf.texi b/doc/lispref/minibuf.texi index aa27de72ba0..66dfdc93318 100644 =2D-- a/doc/lispref/minibuf.texi +++ b/doc/lispref/minibuf.texi @@ -2562,6 +2562,14 @@ Reading a Password The optional argument @var{default} specifies the default password to return if the user enters empty input. If @var{default} is @code{nil}, then @code{read-passwd} returns the null string in that case. + +This function uses @code{read-passwd-mode}, a minor mode. It binds two +keys in the minbuffer: @kbd{C-u} (@code{delete-minibuffer-contents}) +deletes the password, and @kbd{TAB} +(@code{read-passwd--toggle-visibility}) toggles the visibility of the +password. there is also an additional icon in the mode-line. Clicking +on this icon with @key{mouse-1} toggles the visibility of the password +as well. @end defun @node Minibuffer Commands diff --git a/etc/NEWS b/etc/NEWS index 7b248c3fe78..4c9fe4bcb12 100644 =2D-- a/etc/NEWS +++ b/etc/NEWS @@ -318,6 +318,12 @@ Previously, it was set to t but this broke remote fil= e name detection. ** Multi-character key echo now ends with a suggestion to use Help. Customize 'echo-keystrokes-help' to nil to prevent that. ++++ +** 'read-passwd' can toggle the visibility of passwords. +Use 'TAB' in the minibuffer to show or hide the password. Likewise, +there is an icon on the mode-line, which toggles the visibility of the +password when clicking with 'mouse-1'. + =0C * Editing Changes in Emacs 30.1 diff --git a/etc/images/README b/etc/images/README index a778d9ce6c3..77377d36b5a 100644 =2D-- a/etc/images/README +++ b/etc/images/README @@ -125,7 +125,7 @@ For more information see the adwaita-icon-theme reposi= tory at: https://gitlab.gnome.org/GNOME/adwaita-icon-theme -Emacs images and their source in the Adwaita/scalable directory: +Emacs images and their source in the Adwaita/symbolic directory: checked.svg ui/checkbox-checked-symbolic.svg unchecked.svg ui/checkbox-symbolic.svg @@ -137,3 +137,5 @@ Emacs images and their source in the Adwaita/scalable = directory: left.svg ui/pan-start-symbolic.svg right.svg ui/pan-end-symbolic.svg up.svg ui/pan-up-symbolic.svg + conceal.svg actions/view-conceal-symbolic.svg + reveal.svg actions/view-reveal-symbolic.svg diff --git a/etc/images/conceal.svg b/etc/images/conceal.svg new file mode 100644 index 00000000000..172b73ed3d3 =2D-- /dev/null +++ b/etc/images/conceal.svg @@ -0,0 +1,4 @@ + + + + diff --git a/etc/images/reveal.svg b/etc/images/reveal.svg new file mode 100644 index 00000000000..41ae3733a53 =2D-- /dev/null +++ b/etc/images/reveal.svg @@ -0,0 +1,4 @@ + + + + diff --git a/lisp/simple.el b/lisp/simple.el index 9a33049f4ca..3003de0f06a 100644 =2D-- a/lisp/simple.el +++ b/lisp/simple.el @@ -10858,6 +10858,85 @@ visible-mode (setq-local vis-mode-saved-buffer-invisibility-spec buffer-invisibility-spec) (setq buffer-invisibility-spec nil))) + +=0C +(defvar read-passwd--mode-line-buffer nil + "Buffer to modify `mode-line-format' for showing/hiding passwords.") + +(defvar read-passwd--mode-line-icon nil + "Propertized mode line icon for showing/hiding passwords.") + +(defun read-passwd--toggle-visibility () + "Toggle minibuffer contents visibility. +Adapt also mode line." + (interactive) + (setq read-passwd--hide-password (not read-passwd--hide-password)) + (with-current-buffer read-passwd--mode-line-buffer + (setq read-passwd--mode-line-icon + `(:propertize + ,(icon-string + (if read-passwd--hide-password + 'read-passwd--show-password-icon + 'read-passwd--hide-password-icon)) + mouse-face mode-line-highlight + local-map + (keymap + (mode-line keymap (mouse-1 . read-passwd--toggle-visibility)= )))) + (force-mode-line-update)) + (read-passwd--hide-password)) + +(define-minor-mode read-passwd-mode + "Toggle visibility of password in minibuffer." + :group 'mode-line + :group 'minibuffer + :keymap read-passwd-map + :version "30.1" + + (require 'icons) + ;; It would be preferable to use "=F0=9F=91=81" ("\N{EYE}"). However, = there is + ;; no corresponding Unicode char with a slash. So we use symbols as + ;; fallback only, with "=E2=A6=B5" ("\N{CIRCLE WITH HORIZONTAL BAR}") f= or + ;; hiding the password. + (define-icon read-passwd--show-password-icon nil + '((image "reveal.svg" :height (0.8 . em)) + (symbol "=F0=9F=91=81") + (text "")) + "Mode line icon to show a hidden password." + :group mode-line-faces + :version "30.1" + :help-echo "mouse-1: Toggle password visibility") + (define-icon read-passwd--hide-password-icon nil + '((image "conceal.svg" :height (0.8 . em)) + (symbol "=E2=A6=B5") + (text "")) + "Mode line icon to hide a visible password." + :group mode-line-faces + :version "30.1" + :help-echo "mouse-1: Toggle password visibility") + + (setq read-passwd--hide-password nil + ;; Stolen from `eldoc-minibuffer-message'. + read-passwd--mode-line-buffer + (window-buffer + (or (window-in-direction 'above (minibuffer-window)) + (minibuffer-selected-window) + (get-largest-window)))) + + (if read-passwd-mode + (with-current-buffer read-passwd--mode-line-buffer + ;; Add `read-passwd--mode-line-icon'. + (when (listp mode-line-format) + (setq mode-line-format + (cons '(:eval read-passwd--mode-line-icon) + mode-line-format)))) + (with-current-buffer read-passwd--mode-line-buffer + ;; Remove `read-passwd--mode-line-icon'. + (when (listp mode-line-format) + (setq mode-line-format (cdr mode-line-format))))) + + (when read-passwd-mode + (read-passwd--toggle-visibility))) + =0C (defvar messages-buffer-mode-map (let ((map (make-sparse-keymap))) diff --git a/lisp/subr.el b/lisp/subr.el index c317d558e24..555d0084545 100644 =2D-- a/lisp/subr.el +++ b/lisp/subr.el @@ -3375,14 +3375,23 @@ read-passwd-map (let ((map (make-sparse-keymap))) (set-keymap-parent map minibuffer-local-map) (define-key map "\C-u" #'delete-minibuffer-contents) ;bug#12570 + (define-key map "\t" #'read-passwd--toggle-visibility) map) "Keymap used while reading passwords.") -(defun read-password--hide-password () +(defvar read-passwd--hide-password t) + +(defun read-passwd--hide-password () + "Make password in minibuffer hidden or visible." (let ((beg (minibuffer-prompt-end))) (dotimes (i (1+ (- (buffer-size) beg))) - (put-text-property (+ i beg) (+ 1 i beg) - 'display (string (or read-hide-char ?*)))))) + (if read-passwd--hide-password + (put-text-property + (+ i beg) (+ 1 i beg) 'display (string (or read-hide-char ?*))= ) + (remove-list-of-text-properties (+ i beg) (+ 1 i beg) '(display))= ) + (put-text-property + (+ i beg) (+ 1 i beg) + 'help-echo "C-u: Clear password\nTAB: Toggle password visibility")= ))) (defun read-passwd (prompt &optional confirm default) "Read a password, prompting with PROMPT, and return it. @@ -3420,18 +3429,20 @@ read-passwd (setq-local inhibit-modification-hooks nil) ;bug#15501. (setq-local show-paren-mode nil) ;bug#16091. (setq-local inhibit--record-char t) - (add-hook 'post-command-hook #'read-password--hide-password n= il t)) + (read-passwd-mode 1) + (add-hook 'post-command-hook #'read-passwd--hide-password nil= t)) (unwind-protect (let ((enable-recursive-minibuffers t) (read-hide-char (or read-hide-char ?*))) (read-string prompt nil t default)) ; t =3D "no history" (when (buffer-live-p minibuf) (with-current-buffer minibuf + (read-passwd-mode -1) ;; Not sure why but it seems that there might be cases wher= e the ;; minibuffer is not always properly reset later on, so und= o ;; whatever we've done here (bug#11392). (remove-hook 'after-change-functions - #'read-password--hide-password 'local) + #'read-passwd--hide-password 'local) (kill-local-variable 'post-self-insert-hook) ;; And of course, don't keep the sensitive data around. (erase-buffer)))))))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 23 11:58:42 2024 Received: (at 69237) by debbugs.gnu.org; 23 Feb 2024 16:58:42 +0000 Received: from localhost ([127.0.0.1]:53942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdYsk-0005Zo-Ba for submit@debbugs.gnu.org; Fri, 23 Feb 2024 11:58:42 -0500 Received: from mail-lj1-f179.google.com ([209.85.208.179]:55566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdYsh-0005ZL-If for 69237@debbugs.gnu.org; Fri, 23 Feb 2024 11:58:41 -0500 Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2d0a4e1789cso13437931fa.3 for <69237@debbugs.gnu.org>; Fri, 23 Feb 2024 08:58:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708707429; x=1709312229; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HH6E2q5Rcew9EO5lnAqGTTZITmmCNpX54lNpFcU3qMI=; b=apjj0Cnx4+kjyoMyHprZQnpqUSBt1W8NTtjWgzyQowRe4WCgiyRJxzLWBAppZdvK34 R2apFm4XEnJRV65+uIKOT+xO8SO6MOBIODbLD57wO0W29jPJFs3dL0wnHRTbcZJ6Tz/r zLFOlFOAvwaU3XGzSBoqKvSmpFkDxXfLhoqWL0WxFE8+cITBvrqW0FqLVVCSJcC6cs/8 zRDzAk0qijFC4qYldbnB1q1RM/7RAQH1/WdUKBoaoe0AMC/LDTcliQspP69mMzi/q3xJ VWytd/OAcJUSeKEPILxqGZxOljr0EwGRxDBbvICCMBLOvoCmPyh5RlKwe01OXdgrCPKp I4/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708707429; x=1709312229; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=HH6E2q5Rcew9EO5lnAqGTTZITmmCNpX54lNpFcU3qMI=; b=trxHwVT0Uo9A0HPnoUZIS9NINkAVcG4VR9TjgJz46EykhiWDFCuhasnmQJoN6fjNdR I1K8npZUoiPbrreNY7D3Xgi8rAvQ0Mx6n6UvIikNZ6+jbmOC8sxTbFf+34yTfKNkw8HV K0ZeuhiC0xTIHC+hG9hpbnUfa+quCsVq8DSkIqGVKIyKHny+DvWbsA3k9TJeEUgo4BbF DH1AxOtAMGpNg3dHLIZJ8UkvbJWFRmG6VEr6JWwcoaH7qVXwOWy0RRa5q2c/AfZpJs6q dD15YoVwqsz9fqQBNPq4AStrJ4VffUgmNblblb2u8HIGkD7ee9/qccGZ8zIkUiwQpXzL 3/8w== X-Forwarded-Encrypted: i=1; AJvYcCUhFeudc20pMNu3NV8m+aDqFPRVkhGEBePGmq75e23EhLNZGHZwinyZhYC6U7O9f8FUXF2eq6JPCvt+JghBTUF1N1SP6wc= X-Gm-Message-State: AOJu0YxLHRykScbWqkkqU61jooXkh/dYF4oWGqv+i9o35fRbawLw4Ii2 vBwywjpMt3yhJQpNKt8B8hkWuyIKBIVN0bGQdBGhQL1H0QkNfF1Er2ArX8Teaa8Tgg== X-Google-Smtp-Source: AGHT+IH97R8jqWShdB4kdsP5Y23BqrzpImbo7NDa7SYBYFltEaoM8DsHTgjROgUkqKSJBWPyF54Ryg== X-Received: by 2002:a2e:a543:0:b0:2d2:31a8:cb12 with SMTP id e3-20020a2ea543000000b002d231a8cb12mr271793ljn.49.1708707428997; Fri, 23 Feb 2024 08:57:08 -0800 (PST) Received: from hirondell ([194.42.239.18]) by smtp.gmail.com with ESMTPSA id d5-20020a5d4f85000000b0033d9ee09b7asm3313959wru.107.2024.02.23.08.57.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 08:57:08 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Michael Albinus Subject: Re: bug#69237: 30.0.50; Toggle password visibility In-Reply-To: <8734tjrxt6.fsf@gmx.de> (Michael Albinus's message of "Fri, 23 Feb 2024 16:43:17 +0100") References: <87zfw0ttyp.fsf@gmx.de> <87h6i0xhbb.fsf@gmail.com> <8734tjrxt6.fsf@gmx.de> Date: Fri, 23 Feb 2024 16:56:55 +0000 Message-ID: <87v86f86g8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69237 Cc: "Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors" , 69237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: > K=C3=A9vin Le Gouguec writes: > > Hi K=C3=A9vin, > >> No strong feelings re. keybindings; I've been using C-c C-c because I >> wanted something easy to mash, but TAB fits that criterion as well. Not >> sure we can leverage any well-established mnemonic from other keymaps; >> FWIW=E2=80=A6 >> >> * TAB could be familiar to some outline users, but they'll probably >> associate that binding to (un)folding, not necessarily hiding/revealing; >> >> * hideshow has multiple bindings for "toggle-hiding", so not sure we can >> count on any single one having enough "mindshare". >> >> (Not too worried about needing to input TAB verbatim - I tend to >> naturally reach for C-q TAB when I need to do that, since in most >> contexts Emacs has a useful command bound to TAB instead of >> self-insert-command) > > There are not so many comments on the keybindings. I guess this is > because only few people read the bug-gnu-emacs ML. Let's install this on > master, and see who hollers :-) Works for me =F0=9F=98=8A Thanks for adding icons.el support! From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 04:25:27 2024 Received: (at 69237-done) by debbugs.gnu.org; 25 Feb 2024 09:25:27 +0000 Received: from localhost ([127.0.0.1]:57641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reAlC-0005rC-9D for submit@debbugs.gnu.org; Sun, 25 Feb 2024 04:25:27 -0500 Received: from mout.gmx.net ([212.227.15.19]:51065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reAXn-0005Cq-8T for 69237-done@debbugs.gnu.org; Sun, 25 Feb 2024 04:11:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708852264; x=1709457064; i=michael.albinus@gmx.de; bh=b6PrarMtI6Cc7uwxgqWiJ7/U5G+GPxZ1jQlEqjw+Bls=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=T1/CDohvmYSEVz1DN8No4thOeY0eZrw6l2oVfL+OwZN3WcmDH+1K2uQqALFPffqI J22HP7pNY+Ehnmfg3z70yRkvFryhZOUWci24/wvBL1XMUfO42u0wC8j8/tLy+aRgW LSYVqVIf4WJUB88tDcUPS/dK3r/yPQObKNrP5Z19bR38CoefJpa2OxTo1wd4IhsnU 2rt0nK8W/w0SHTWs4OJEH0OrAbTIMwEgA1LB8VPQ3DfWgQO4y8/SxEzKVfcLOYf36 x6MqQ1BAagXd01jO2vq9yvRUf17lba5amVvsSJ8VbVYawUx1jCDusYhoAnqTF/1UC p8IAjckdxuMhkikmgg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MZktZ-1rRMdk42y7-00Wjy9; Sun, 25 Feb 2024 10:11:04 +0100 From: Michael Albinus To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Subject: Re: bug#69237: 30.0.50; Toggle password visibility In-Reply-To: <87v86f86g8.fsf@gmail.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Fri, 23 Feb 2024 16:56:55 +0000") References: <87zfw0ttyp.fsf@gmx.de> <87h6i0xhbb.fsf@gmail.com> <8734tjrxt6.fsf@gmx.de> <87v86f86g8.fsf@gmail.com> Date: Sun, 25 Feb 2024 10:11:03 +0100 Message-ID: <87frxgvrh4.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Rsr0wJA+yWzHW/9rT7RjfmN0GlQD/w2/yjH6FK9NKtBzDsyKJyB ut780Yg+DlJGKbY5cenZD8UCEonEQlLShAFJOeG4S+08+vgtho44GIcifF05E8pFFIK11vh aOBa6hLfbavbJncjxYHV2HgRlpFMlL4t9u7vpNwcCyQBoWGojb1CXlLBqeW46TwRlFdSJ6s 0rTdwYDQHmlcadE7BTmQg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:wriyx59w/TM=;EiCcBjqvvJtmrlXKX7S9GbUEXx2 n+V1gOyXYigMBxBtwyQNTMjRFTbcI1LYRIhgiZE1Pw58BJARiYAIZrqwKLcDq08R5YcZWGBMS RCsgBdfTPUxS7qTK7VLBALhThO5S5HqnSCLfP4mqbZutl9ERUpdpBJgOWQdxjQ7zc6jdxiuSE +xgKllscpFvbH2dV9gaP0DleApEzIaipZjbaIOgI/iDsIZmCtLETBMgPDPPYyRJSGLzBNPhuU vP//+1EG/ME/hJx/2xJUgghel35mEbdQjNnE/ezGLLzkWXx85zlfSki0f9zFhnOTCmtf0Z99R jfp/4GQRfVULZ3JGgTPiBn9m+oiKsQLnkc++3sB0bUMjWPfqqTlyfL/yfbpd0uemwSQ3d03vc CphllukrA1S84EJ4xEsExlz0YUEE1FC8tI5jnkTKYj+F+XCDTrVudtKIb/BrYOc7ERlRYtQNx 30gaUSIZGozSxY7IgrIsPDiJQ9b1xRT2Q1+DXSkhIrWvByZ0tiic28I29KrWT9nh+RyTgv8lT yv0KyPB0Z5YuY54+SUvbz1FKqSLqSylMZTicpOISjib2IOzpxEfMx/8dkOx0V59gq6kPZ5J2x 25qgZy2WuMWypkYgSMGVPUJ2wBaTmc5dvESHracD6QcmSdGNK86UvltAeok8hoLeCbD7If9vt J6K7GI1EsqJzkdOtlUH9vIIL/fD8e239tNF6fCZghro/ZQO1LfYF2g6Hk5Vx4ZMh9ElYwnR31 6m6wDKUM8ydVT/FYKks6F9EFTkeWazFr4E7dBh1+YtB63grWmuDAOhfbqb9j5EPjPU9942F+4 GvLrnJL3nj/9rQufVRpoOzXtNn77FgR0uNJbdt2tiCTus= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69237-done Cc: 69237-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Version: 30.1 K=C3=A9vin Le Gouguec writes: Hi, >> There are not so many comments on the keybindings. I guess this is >> because only few people read the bug-gnu-emacs ML. Let's install this on >> master, and see who hollers :-) > > Works for me =F0=9F=98=8A Thanks for adding icons.el support! No further comments, so I have pushed this to master. Closing th bug. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 05:52:49 2024 Received: (at 69237-done) by debbugs.gnu.org; 25 Feb 2024 10:52:49 +0000 Received: from localhost ([127.0.0.1]:35091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reC7l-0004Gy-0o for submit@debbugs.gnu.org; Sun, 25 Feb 2024 05:52:49 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:49313) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reC7i-0004GV-HJ for 69237-done@debbugs.gnu.org; Sun, 25 Feb 2024 05:52:47 -0500 Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-33d8739ddd4so1737963f8f.2 for <69237-done@debbugs.gnu.org>; Sun, 25 Feb 2024 02:52:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708858275; x=1709463075; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i6DhtaMtkPhfOPU5YJQskzRlSVVJj5vyz9/FhHPM8bE=; b=cVppi988OJPvgBbxuBSU7FdQg1gaKSJ0gt+UAsCEzDcHkw6XtQv2i1GEJeuvgc0QXe LXKL0jqFSmjnEffSi6cLVPRzJFsse48R6LHMZygTwR08+UPLmIvODswRRLkOOXxOlFx9 WwnVMzD/G1QTRL+gprnzVHMz9J63OGNFw0/WRWgpfh12Sd2edb1fv2I9PHhf/sN7DZc7 CiLfctgVnWjZmhLLFFQe7rbXiDAhFXZPP155FSB91sQJLvBqa63bFc4gMDJjkJctOnB+ O7xhYkGG5LZ/T/kB5m36NlRynZNgSXS6Mcb9d6WD6Je7VXhn+z0udtyOFY1jBqOFNzT1 JnYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708858275; x=1709463075; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=i6DhtaMtkPhfOPU5YJQskzRlSVVJj5vyz9/FhHPM8bE=; b=sZPOKlKUlvTIf+hUau/bxsDnWl01okezQ/tOpK+kojvuDEpQfOGdcdYJbjvehwx/+c gP3+IaPoAy2NTToONKVJ8x33PcA1r9WPoO6ZB6U+wFPe9zr+XzR1gJK7HIGU3qLbaz5i Qk7PoZ2NK76zT6/Gb+H4/KW/pm8a3tbC85bFqHpR0kWI20hpR6CHn/PxdvTzHe8MLKdO qmkRB/Y8v9/jlOHxHD8cyqn7MsL/ivjXJ/9q+w/5w5fa4Pu2wyN3xSnthjYn3CiUtpX7 7uKofzz6JSBL6TlxrnWwkFebiwL2rhsXawkr1p06advOkXNLRxhZtOtCX9+UkMH4/soJ zdPA== X-Gm-Message-State: AOJu0YyyZpU71ODCcl7otWAT0aFcua77d4r29aD1JyToNBEmOli38Oo0 pfHFPDpEqz+o4XUJAMHOH1wAd2w30i97PWOhSXd6EjnEw70YoqRIVH3cxLxBTSCZDA== X-Google-Smtp-Source: AGHT+IErd9Dr0gXUn27pgQaX5Gl5LzpmCRprq5rapkU9TdxHK5bdMKO/qpBhe/qbk03+5Dc1l9GVyQ== X-Received: by 2002:a5d:500b:0:b0:33d:3fe6:720e with SMTP id e11-20020a5d500b000000b0033d3fe6720emr2511174wrt.17.1708858275440; Sun, 25 Feb 2024 02:51:15 -0800 (PST) Received: from hirondell (ip-185-104-136-49.ptr.icomera.net. [185.104.136.49]) by smtp.gmail.com with ESMTPSA id bs23-20020a056000071700b0033d5f5571b4sm4836721wrb.44.2024.02.25.02.51.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 02:51:14 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Michael Albinus Subject: Re: bug#69237: 30.0.50; Toggle password visibility In-Reply-To: <87frxgvrh4.fsf@gmx.de> (Michael Albinus's message of "Sun, 25 Feb 2024 10:11:03 +0100") References: <87zfw0ttyp.fsf@gmx.de> <87h6i0xhbb.fsf@gmail.com> <8734tjrxt6.fsf@gmx.de> <87v86f86g8.fsf@gmail.com> <87frxgvrh4.fsf@gmx.de> Date: Sun, 25 Feb 2024 10:50:56 +0000 Message-ID: <87o7c4yfzj.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69237-done Cc: 69237-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: >>> There are not so many comments on the keybindings. I guess this is >>> because only few people read the bug-gnu-emacs ML. Let's install this on >>> master, and see who hollers :-) >> >> Works for me =F0=9F=98=8A Thanks for adding icons.el support! > > No further comments, so I have pushed this to master. Closing th bug. Yay! Couple of belated comments, with the benefit of caffeine: * Should we keep the double hyphen in "read-passwd--toggle-visibility"? Feeling like it connotes "Emacs internals" somewhat, and wondering if it's appropriate for interactive commands since they are "user-facing", and users might feel discouraged from remapping "internal-looking" commands. * For the 'text icon variants, should we follow outline.el's example and use full verbs, like " reveal " and " conceal "? (Don't want to be a pest; I can take care of the follow-up patch if we agree with these tweaks, haven't done so yet because EBATTERY) From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 06:31:14 2024 Received: (at 69237-done) by debbugs.gnu.org; 25 Feb 2024 11:31:15 +0000 Received: from localhost ([127.0.0.1]:37673 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reCiw-0006KV-Hb for submit@debbugs.gnu.org; Sun, 25 Feb 2024 06:31:14 -0500 Received: from mout.gmx.net ([212.227.15.18]:46843) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reCiu-0006K5-Bg for 69237-done@debbugs.gnu.org; Sun, 25 Feb 2024 06:31:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708860641; x=1709465441; i=michael.albinus@gmx.de; bh=6Nz7LMvu0ykCOJmw1J+Q98/D5FkTxV6htQsJ5UI0Ui0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=Sx29KppBnbMveXOXTGk8theLKW9g96+DD+brfD0ZVvIZoSZQC0Tht5LFWBL+GZ6j d/MExQQjFJtubuFVi45uBP2190Ctpxv07FjMEzaTwveJouvUwESZ7Ek+DgJPHUNsO kcrEhhbly4DSaTld/7+3geMuqSnrOLCiG0dPsLcNubkUxhiKvHRlmfU0D/oi/C+Ah RPFPH5D+EPhe+5RRaPBSSRVR0rFI6nRgHXSZd0P0u/qEexivyRcNRyWs5BMiP7uiA Z7cc3B2lgzkzkPbuIJZTI0ustAiwELrDfilulsisAjvqKQYkPSrruwBdXrKW0zpDA tpRSDKwGeZjX8jS0TA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MKsjH-1rLJH70QST-00LH6Q; Sun, 25 Feb 2024 12:25:40 +0100 From: Michael Albinus To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Subject: Re: bug#69237: 30.0.50; Toggle password visibility In-Reply-To: <87o7c4yfzj.fsf@gmail.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Sun, 25 Feb 2024 10:50:56 +0000") References: <87zfw0ttyp.fsf@gmx.de> <87h6i0xhbb.fsf@gmail.com> <8734tjrxt6.fsf@gmx.de> <87v86f86g8.fsf@gmail.com> <87frxgvrh4.fsf@gmx.de> <87o7c4yfzj.fsf@gmail.com> Date: Sun, 25 Feb 2024 12:25:39 +0100 Message-ID: <877cisvl8s.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:cznbnISL0r4pwoq9ByJpcju3OXDpO2o8cklLmXSSQ5dHN0BNOea Ku4BZjlXIxQtZEckXsoH63NTx0qfFundE3fhISUJen9QLlV+mjlYDrF23yjId+AjAOhaQxj CrUJF8HqIv+VF07EtflbySl5MBEPlNrA+rPDhbi+2H9NFo1KfAaKsGFxHvKxq5Ha23VTyAJ PHlGFHdvDJNpctlG9vtmw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:wLnoIVbImS4=;rp+dbEZyxqYI4EZUBhKCLBmF1hr 8OISbvlWBpyEQ3CCVH1F7LhlVwywUcFj7gRPJVZJU6tl9Cc1xIWUmc0djdhmpnJ5TmawrIxV2 I4Ap1pluwfRkOAvtVRYW5M3tBuNpyAx+/vVNtM+siyl0Alkz6dKk5aY77Qqa2tgh+Wm/qqf7B 94uhA11/kaRMVv/HyyopCyGfk6T1Zlvqv3+rAFRJCh1jtCEoNNUn0x/jKe/bUjc1JNWtU3n6m ci9n3zFasBL9u/7WvbsQUmz2YjocfyEYBycvd79Dtnrmfas6FsUExMSyMvr0ISK7ZDOev4h5G QPRmgqK/Ugkha+MCndRLsU5FZr04mQ3ilorYaT0FPf6ZhU6/Z+zVL7Rvbf0onAjUqrV4xtpjf LILkk7veO1iZLVLQ2VGfY8I6fc9opVClvHy+yfqL+WCVNQrzihSnqPU/5wTR1Wgl8tqDrfFMu ZeOeRyOhS0CwSWiij0w0EWBDI/gZiBfpu3TyodSVpn0hcLt6mPA0E/szX2owAzM7ify0lJ3Hw IhA2khBYwIAla+NRBpt+Iob835xf7fewTshBJlU1+mhyen7pary0t2nrdMsOluuKVnwXu1no0 QIsGtuFhft5SZFo/BiZHfR/rVXulYzoJvGTxqPF+wiL5qa8w3ak1GTPd7rkIo5YeiHxqslt+a l7PuTvLs+nU6r6MDGGyE8/VbQ0cbd4o6KVvPZJx/anXxiVzqqvKizTbtn6rz9kbCXoXsZuyWM UMMsMftZ/LzDKs9LF7sk/T6iBi8XS+Zokld21P1ky8WaxJ6cANOauMSzTitrEXO1vZArXiSNv xX1Mv11c5901chiAFMtPlp2yWIEHmc1Mpv/4Ha39/dZ3s= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69237-done Cc: 69237-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) K=C3=A9vin Le Gouguec writes: Hi K=C3=A9vin, > * Should we keep the double hyphen in "read-passwd--toggle-visibility"? > Feeling like it connotes "Emacs internals" somewhat, and wondering if > it's appropriate for interactive commands since they are "user-facing", > and users might feel discouraged from remapping "internal-looking" > commands. It is not intended that users call 'M-x read-passwd--toggle-visibility'. It makes sense only when you are already editing the minibuffer, typing the password. > * For the 'text icon variants, should we follow outline.el's example and > use full verbs, like " reveal " and " conceal "? Hmm. It would be too much space of the mode-line, I fear. See the other examples, for example in tab-bar.el or tab-line.el. Best regards, M;ichael. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 08:36:07 2024 Received: (at 69237-done) by debbugs.gnu.org; 25 Feb 2024 13:36:07 +0000 Received: from localhost ([127.0.0.1]:45379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reEfn-0006BX-2m for submit@debbugs.gnu.org; Sun, 25 Feb 2024 08:36:07 -0500 Received: from mail-wr1-f47.google.com ([209.85.221.47]:47396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reEfj-0006Ap-MS for 69237-done@debbugs.gnu.org; Sun, 25 Feb 2024 08:36:04 -0500 Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-33dcad9e3a2so160082f8f.3 for <69237-done@debbugs.gnu.org>; Sun, 25 Feb 2024 05:35:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708868072; x=1709472872; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R7l3QzAH8/1j1h0Mdf5clHe2FSHTBGr1pN7CB/zbfQY=; b=Jp0ufdfyoWolGiv9KXyVoo7krsBpsSI8Zs8ICkWCPIn0j5L97sYMxWmfkEyB7AG8qC 2s6AoTJNz0GJGJ4NXiVTmyfO11woI1M3jQUjDWHSzHiKwczSFiuAT7rJY35yQDG+UMXn FMD8Qn2DqKemFhGfDEKpf9Lvbk91HV6i8xhv6LQsglezoWAU8CN6LRF6QCKGu60uBucQ kHznhu9GCLL9okIpMVM65GhWUWr/kg/c1RhWztsWHsc4c227Lnxj2zgWqrOS/Ct4rdxx HcJlFmBkYl/JUzN+7LnDNPx9vO8OiSyYZh4UpwkqYNF4x7cUyIu/qiJCqx+WQwupmWnI BMiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708868072; x=1709472872; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R7l3QzAH8/1j1h0Mdf5clHe2FSHTBGr1pN7CB/zbfQY=; b=LMMlgRCCxiO5+FMUnW9BB8S1pb8mJ+sUoe3HERAjRSanB3DzeI6w9/0SAvNj//Br84 UejLK787+En8UV2E7fDfo4bEIVXvgCeFVyUUY6xPJFpxAY6PxK4CeyJzU9xInB2AibAc EQmb2Gd52W2Dm27BsQHclkfNYAN8ggBFQMbPO1FTwC7B9qLdO8i7b7Yl38iGtcqeQL1d OKgT9CHRONAD2F3cbXgnwEKoZj9l1uyy0pbIS/8MYfKVkzfWn4rTKPiFpHJOhc2wZ2Bv gQm7VKmu+E3xSvejBx9eCp4UB38kTDhH8nvirvse5iLpKy688ZOheUji/Oce5Y+80Ad3 GWdw== X-Gm-Message-State: AOJu0YwBkyuZUD2TnKlckZM1xxnRZAeibbvBIwveoX8ggwQQkUQjW43E lssOnfdaNMps6V+5/hE4OBGFwCHGCDhL5EoMoA3h3h8JmltpX101t8ApGEuY8L49Dw== X-Google-Smtp-Source: AGHT+IHm0Kg/uZKXgbTcf5ZqhZKcb70m5pVQF+BSzTEkSvzVHt2iUWKw6EXsnWG33Wvu4vc0rPo81w== X-Received: by 2002:adf:e0c8:0:b0:33d:6fd8:90d3 with SMTP id m8-20020adfe0c8000000b0033d6fd890d3mr2914632wri.4.1708868072293; Sun, 25 Feb 2024 05:34:32 -0800 (PST) Received: from hirondell (ip-185-104-136-49.ptr.icomera.net. [185.104.136.49]) by smtp.gmail.com with ESMTPSA id e15-20020adf9bcf000000b0033dd15b0dafsm1590004wrc.26.2024.02.25.05.34.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 05:34:31 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Michael Albinus Subject: Re: bug#69237: 30.0.50; Toggle password visibility In-Reply-To: <877cisvl8s.fsf@gmx.de> (Michael Albinus's message of "Sun, 25 Feb 2024 12:25:39 +0100") References: <87zfw0ttyp.fsf@gmx.de> <87h6i0xhbb.fsf@gmail.com> <8734tjrxt6.fsf@gmx.de> <87v86f86g8.fsf@gmail.com> <87frxgvrh4.fsf@gmx.de> <87o7c4yfzj.fsf@gmail.com> <877cisvl8s.fsf@gmx.de> Date: Sun, 25 Feb 2024 13:34:26 +0000 Message-ID: <8734tgk6ql.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69237-done Cc: 69237-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: >> * Should we keep the double hyphen in "read-passwd--toggle-visibility"? >> Feeling like it connotes "Emacs internals" somewhat, and wondering if >> it's appropriate for interactive commands since they are "user-facing", >> and users might feel discouraged from remapping "internal-looking" >> commands. > > It is not intended that users call 'M-x read-passwd--toggle-visibility'. > It makes sense only when you are already editing the minibuffer, typing > the password. Right, I don't expect many users to run this command via M-x. My thinking went more toward users who might want to do=E2=80=A6 (keymap-unset read-passwd-map "\t" 'remove) (keymap-set read-passwd-map "C-c \t" 'read-passwd--toggle-visibility) =E2=80=A6 and who might feel uneasy about that "--" in their personal confi= g. >> * For the 'text icon variants, should we follow outline.el's example and >> use full verbs, like " reveal " and " conceal "? > > Hmm. It would be too much space of the mode-line, I fear. See the other > examples, for example in tab-bar.el or tab-line.el. Yep, those tab bar & line examples work very well because the symbols ("+", "x") ought to be familiar to users working with tabs in other UIs. For read-passwd, I'd argue it's a taller order to expect users to intuit what "o" and "x" mean. I'd also argue the extra mode-line space should not matter that much, since it's a transient situation that will last only until the user is done typing their password, and the displaced mode-line content might not be that relevant to the user in that exact moment anyway. Maybe we can bike-shed some shorter ASCII art, e.g. (reveal) <\> (conceal) (All those nits are pretty academic, admittedly, at least as far as I am concerned, as I do not expect to rebind the command, nor to rely on the 'text icon form) From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 09:09:50 2024 Received: (at 69237) by debbugs.gnu.org; 25 Feb 2024 14:09:50 +0000 Received: from localhost ([127.0.0.1]:47345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reFCQ-0007gR-04 for submit@debbugs.gnu.org; Sun, 25 Feb 2024 09:09:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reFCN-0007g7-Av for 69237@debbugs.gnu.org; Sun, 25 Feb 2024 09:09:48 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reFBs-0002Ft-WA; Sun, 25 Feb 2024 09:09:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=JN/7E23q5iBWML7v2puEjpeQyvGeXtW4s3rUzP+V8vQ=; b=quOz47hi/SmFpx9mf+6+ d1ebLb81c2Vc3RJCuGWcnXxyV1R52xHKWj1iXi5o0aDlgd25N72OZCTMM/Rx7WkM5F1xX6WPLkgaN FQ5xv4E4TCqkBFa8O2ONq1PcVq7ugqc1/FawR2ZEKKMeTcGEjuSaIcm87fwB/vXEDBf7s7/aIsDhw lE4BiDu+sx1SLGnws5PjPDEz2JhNQW73UOmB1tk+CAfX6xawG5aEdrUw18Q5AFut47ijtwD2yyGVs w3o9dwNOdxjGDW0QZIdeP0GaQZ3Gy7xc/u4+A3FlQ8Y77XZfG0JX/7HQuAh2BgMEHZEaoebWGY6XC 6xt2otJiBu5hmQ==; Date: Sun, 25 Feb 2024 16:09:13 +0200 Message-Id: <86v86cws8m.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec In-Reply-To: <8734tgk6ql.fsf@gmail.com> (message from =?utf-8?Q?K=C3=A9vin?= Le Gouguec on Sun, 25 Feb 2024 13:34:26 +0000) Subject: Re: bug#69237: 30.0.50; Toggle password visibility References: <87zfw0ttyp.fsf@gmx.de> <87h6i0xhbb.fsf@gmail.com> <8734tjrxt6.fsf@gmx.de> <87v86f86g8.fsf@gmail.com> <87frxgvrh4.fsf@gmx.de> <87o7c4yfzj.fsf@gmail.com> <877cisvl8s.fsf@gmx.de> <8734tgk6ql.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69237 Cc: michael.albinus@gmx.de, 69237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 69237-done@debbugs.gnu.org > From: Kévin Le Gouguec > Date: Sun, 25 Feb 2024 13:34:26 +0000 > > Michael Albinus writes: > > >> * Should we keep the double hyphen in "read-passwd--toggle-visibility"? > >> Feeling like it connotes "Emacs internals" somewhat, and wondering if > >> it's appropriate for interactive commands since they are "user-facing", > >> and users might feel discouraged from remapping "internal-looking" > >> commands. > > > > It is not intended that users call 'M-x read-passwd--toggle-visibility'. > > It makes sense only when you are already editing the minibuffer, typing > > the password. > > Right, I don't expect many users to run this command via M-x. My > thinking went more toward users who might want to do… > > (keymap-unset read-passwd-map "\t" 'remove) > (keymap-set read-passwd-map "C-c \t" 'read-passwd--toggle-visibility) > > … and who might feel uneasy about that "--" in their personal config. IMO, commands should never have two dashes in their names, because commands are never "internal", by their very definition. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 09:44:39 2024 Received: (at 69237) by debbugs.gnu.org; 25 Feb 2024 14:44:39 +0000 Received: from localhost ([127.0.0.1]:49466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reFk7-0003Us-8z for submit@debbugs.gnu.org; Sun, 25 Feb 2024 09:44:39 -0500 Received: from mout.gmx.net ([212.227.15.19]:35767) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reFk4-0003UR-JS for 69237@debbugs.gnu.org; Sun, 25 Feb 2024 09:44:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708872246; x=1709477046; i=michael.albinus@gmx.de; bh=3DiD5T8MjqXghawi70pws0ZN08Hbro8B0Kntojbl8QY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=BROAFJ46Lt/LjnqN8K2MUCnbpxeuhYSuML5tTcqjt2ydrZg0ufKswYAzWA3/hIYF qZM+TJQOJjh/YWb/WGJ9xpO2M4Lz5a5W1oph7ebJZIP0RbcBcyoFtOG9666A/BjAy PMI38kSky5P/b+3MVZ6Ou8EQH0Tn8i0Gb48wzKG2nFxcuZvp/FFWqvbtluFIAZ0vR wIEihL+lA8oHlcw0e9FTzvx5m9JwdSWH6A0LH9hStt16ylsFUGLet7qfhYKRi8fu1 Q50cgXzxDP7QPg+yZfnvGX1OYekAgaCQlsZpSKsfRSdVikqwny3TRdPoJkLDSyMv+ wf0vpUN0Sv2tTBLaBg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MrQIv-1r9tEY0M1X-00oYlL; Sun, 25 Feb 2024 15:38:53 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#69237: 30.0.50; Toggle password visibility In-Reply-To: <86v86cws8m.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 25 Feb 2024 16:09:13 +0200") References: <87zfw0ttyp.fsf@gmx.de> <87h6i0xhbb.fsf@gmail.com> <8734tjrxt6.fsf@gmx.de> <87v86f86g8.fsf@gmail.com> <87frxgvrh4.fsf@gmx.de> <87o7c4yfzj.fsf@gmail.com> <877cisvl8s.fsf@gmx.de> <8734tgk6ql.fsf@gmail.com> <86v86cws8m.fsf@gnu.org> Date: Sun, 25 Feb 2024 15:38:52 +0100 Message-ID: <87zfvotxqb.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:3q30cwqHV7s73eZEf06S6LIlJO6EFGfFF2mgoHBgGz2YruNxx4Q YcrilxZ13a1g+ZoyDcUHAoot1EFFT6GzgdzGJfqPcUB+SsgnqEKmfl6neAD9FA3HT+hA2rn sAC0xuRIM4jOr4PvqTTxCiIPLVOxXdkmrosnuTBIOPHs5jE1ndEnjZpw3CnKccivOTomei7 Xl2o+h1Q1Xg4yUl7EmwQQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:20PpDjBwHNA=;LCI0T68u3hNc7yMz5s6lV5KI4Fe 8emrn5k8BfV53vkqdds2WSlk9/6mHe1fTG3/pj8yafjTeTg5I64ZP0k4TEGyTpK29hT1RJzBO 7Ro5Ix7IC240zHIBP7++ipqnz9pi5qDKygkaiZJihzpDNjrOrrsn89ZFejYYc1odIL+0MetRE Iey58XWyiDemPIo083iL9tW9p/I5I00wGQUewBvN1NL2khuumJU2DomCTZPAFWEb4hqxB78KQ S/g49Ryz5/5nAn5nTCiFyTE2JlwikwE0x4EgracBeZAnKLp/kxR95cMK7EG4pz5TVZhDb0eOE 7gsgb500x1gIwRIi7nQq+lZR8Ye+WeQ+59bL0WBWd0olR13LFhz16IVeYjrrsExub0GqpOVQe uqaZVZoS9U8ui0cJTcK863DMJvyaHUPG0pEOYXX2VRV64Drvw8Ay28Hnm+Egd/3vdCnleXDfq gjBqZICdwvUmRyzvRoiDJwTNueOE7ulwigCNvs9mKsf6LQ3JEYKcMpPiGE1NMN5x4j5/vz7nF cXXaisOyDdmZ2buLGM/oUVG8geRZcfdW8IMAhuFF+A4/zJPm71Ko0Cylnru5uLq6TSxOViqTZ IBwAirWjNnaHd/GGTckC0k6jgUb8w/y9JV/cQeJyJlc9kJcfG3ObCH8EP/kZ2Y3V2A4Cmx5W5 wg2fI4xQH1+msxjiT/JSWohBxCm8BmDIUvCp5F8qdiVIu05TKIdtuSEekKXLW1DBFH8IcH5Wy 60MBW3O45psv/kNe+QqHsd/rutJCfWwuHhm3VGiTyjAskjqkSKgOSqRrhmBn+n/CiBgS08IJ9 EAePsrYiQXpTo/b2ed3TKgrepXY3x5s7de1iyYmR28/BQ= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69237 Cc: 69237@debbugs.gnu.org, =?utf-8?Q?K=C3=A9vin?= Le Gouguec X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: Hi, >> > It is not intended that users call 'M-x read-passwd--toggle-visibility= '. >> > It makes sense only when you are already editing the minibuffer, typing >> > the password. >>=20 >> Right, I don't expect many users to run this command via M-x. My >> thinking went more toward users who might want to do=E2=80=A6 >>=20 >> (keymap-unset read-passwd-map "\t" 'remove) >> (keymap-set read-passwd-map "C-c \t" 'read-passwd--toggle-visibility) >>=20 >> =E2=80=A6 and who might feel uneasy about that "--" in their personal co= nfig. > > IMO, commands should never have two dashes in their names, because > commands are never "internal", by their very definition. Changed. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 09:48:53 2024 Received: (at 69237) by debbugs.gnu.org; 25 Feb 2024 14:48:53 +0000 Received: from localhost ([127.0.0.1]:49763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reFoD-0003k2-1K for submit@debbugs.gnu.org; Sun, 25 Feb 2024 09:48:53 -0500 Received: from mout.gmx.net ([212.227.15.15]:46055) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reFoA-0003j2-4t for 69237@debbugs.gnu.org; Sun, 25 Feb 2024 09:48:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1708872499; x=1709477299; i=michael.albinus@gmx.de; bh=ll1OOCXaFMcNxe0qG6vR5OEPlpeoULB5gszJyxnFfC4=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=NDbBsOTElvxGu9olXWzhq+TQNwcs9sqXMAxrvX2YE7DgDctRce8Hna+uPUU6Dnh1 wW50hVsakGpWjLYzX+MsF1yOIGxuZveh9aOt/cm7SmLLGUHOPD8OnFOWFvK1d/Gof UqmW8TfV5Gwi5hdFNJlxZPnXqPO/wQtDM5FOaKuJB6vhrVKf+aRpg9lQ8TjC5VIxw q/5dsBs9VO7L87OHRdmbh3Ljf5besodE8Y+Lxdjh77OqkTeoGJ8dpgTNx0JuO65Xt vTc+V+8dou1QCI+qkIV2Ou7gtdPGSl3ULMhThMo2I648BIYHbVuUu4pJ7VHYrhuqn Fj/+xtCoZHAWRPGqqA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MlNpH-1rCfHD3qSj-00lkD8; Sun, 25 Feb 2024 15:48:18 +0100 From: Michael Albinus To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Subject: Re: bug#69237: 30.0.50; Toggle password visibility In-Reply-To: <8734tgk6ql.fsf@gmail.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Sun, 25 Feb 2024 13:34:26 +0000") References: <87zfw0ttyp.fsf@gmx.de> <87h6i0xhbb.fsf@gmail.com> <8734tjrxt6.fsf@gmx.de> <87v86f86g8.fsf@gmail.com> <87frxgvrh4.fsf@gmx.de> <87o7c4yfzj.fsf@gmail.com> <877cisvl8s.fsf@gmx.de> <8734tgk6ql.fsf@gmail.com> Date: Sun, 25 Feb 2024 15:48:18 +0100 Message-ID: <87edd0txal.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:Si2xWtfW8ii/eFyJoGbEbUpgrWMbKU1EfPnacEwdjYmZ1DuBidW c9y9ScFNchAHo3iFU1/hxeF951aqeLZCxiG1RgSd9m7aaPLPldftnDQxtD1qm8NSOBCbnCx 1pDcwaWVo1xbhkor9XEVglZzQO2vQjMCW8owuxWZEJs4DME3NdID8x5oT6FRnab1ud4/eCu C+lhOcg6OjPph4Tys3pnw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:7epQOHAl3vs=;YuSodQKG+u3SV+LWCVRz5dj+wnA bdd22N6qcDbHip6yvOy/9ViJPifOgGphOkvkDrrFL7rUbCdcJFdcSqNIUYKk7Kiu2kb4UjRA8 MG2QmIRTTJsIm9lhh4P37vNyNQ7lA8OiN7/9wl2qXEtEydcDQ1fQEUA2ojpI7FXg+IsXkabZ2 ny06Ntzd/V6ZyjZZW1b5Q0fC86hgh/QZM5NUnbHfuco1cTEteFHYykE6BPeEPWQGHpi5pEXhx unZEoFFH0WiLlwZ1bXKKvF/jYKqlxoDWAuBOl3zT53ZmdPEjHvxVrcidbMCgCbOyqpanWGdLz KjtCRze4JiPrlobcU9opxZt0sNY98t8H+EvDsl+7y4mQmpnM12Yr+Y6Cpqweq7oRcd2BxfnX4 6dnKDH0O0+5blCd60Jvewlzv3BEgwPn8eJulqJ5U/2eohbxXgkSaHzy50IxqIgYQgFUxjursU ox9Dr6n/v6IgMFOniljEwg7WJEnl5HtIdHmhWSY2/eT5pP6xL6X6AhPrYfBQC0DQJqlgqtaom GO/FqSsIwSojTS/56rsq93Ufqtbnc42W+6jEzfuQ72n0W+oVlDcqKV+4HDumsIZNpWZ8fJyZA iUuavKZ6oE0DGwoP57hyLIyqOAByCgzts/1rYFhXHUHu9yzyHR5HMnqheMWmuWODeTnoZ2Ji1 Gtl9tnjmcRPPn08NKB89I0EVWB1nAGRScaz1nLdKWwU97Fr4bjja+LZRGkPzFAV80WJTNtPTp tZWaEy4eUWQo3KZdEjmSv3dpkeauNbiryZSD4gw76NxzcCxLhdH+wmpwskgUale1+FjJ36rmv JlsQqTwsR3gh2M0SsAawh4RLEfkTejjLAwWkDI+dqdPKg= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69237 Cc: 69237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) K=C3=A9vin Le Gouguec writes: Hi K=C3=A9vin, > Maybe we can bike-shed some shorter ASCII art, e.g. > > (reveal) > <\> (conceal) Good idea. Bought. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 10:10:18 2024 Received: (at 69237) by debbugs.gnu.org; 25 Feb 2024 15:10:18 +0000 Received: from localhost ([127.0.0.1]:52782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reG8w-0005CJ-5F for submit@debbugs.gnu.org; Sun, 25 Feb 2024 10:10:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reG37-0004vB-CJ for 69237@debbugs.gnu.org; Sun, 25 Feb 2024 10:04:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reFiG-0000Oa-QF; Sun, 25 Feb 2024 09:42:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=HfPfe4Y9MldkGRcPzRYYKpMVlUT9p/pBx4cxPFTwxAU=; b=Ijh8cu+zxHYiis6PRGSJ jLXio3E58N3HdqqS8ht3L7rx/l2uJ+Xn+tescAglNVH6ljaX7tmvN6bFJqb9ll/P0FnMigzacfwnd 6VZqn/NCpfvrdioqraGM4sK5PlSXTv/+kXu1vzjio9K7wS4paAJwk2/2Q1vJLt1lGFXFlBYSlJggY LBaFWPrlksZPexDfjQsK1VU977J10mI3+n8kY/5fzT6v8hf458hTLgfdUh65FfBijjSUzfYxa4fAM h0zLI+y34CK+gxKUE9z9gFjTGNMJGvQBsJ/qbP6G4nwdyYNVXkaReOBhuEqTDav8v8ZIOnbaP0wZW TFRzRWPn1mx7nw==; Date: Sun, 25 Feb 2024 16:42:40 +0200 Message-Id: <86sf1gwqov.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-Reply-To: <87zfvotxqb.fsf@gmx.de> (message from Michael Albinus on Sun, 25 Feb 2024 15:38:52 +0100) Subject: Re: bug#69237: 30.0.50; Toggle password visibility References: <87zfw0ttyp.fsf@gmx.de> <87h6i0xhbb.fsf@gmail.com> <8734tjrxt6.fsf@gmx.de> <87v86f86g8.fsf@gmail.com> <87frxgvrh4.fsf@gmx.de> <87o7c4yfzj.fsf@gmail.com> <877cisvl8s.fsf@gmx.de> <8734tgk6ql.fsf@gmail.com> <86v86cws8m.fsf@gnu.org> <87zfvotxqb.fsf@gmx.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69237 Cc: 69237@debbugs.gnu.org, kevin.legouguec@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Michael Albinus > Cc: Kévin Le Gouguec , > 69237@debbugs.gnu.org > Date: Sun, 25 Feb 2024 15:38:52 +0100 > > Eli Zaretskii writes: > > > IMO, commands should never have two dashes in their names, because > > commands are never "internal", by their very definition. > > Changed. Thank you. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 10:29:38 2024 Received: (at 69237) by debbugs.gnu.org; 25 Feb 2024 15:29:38 +0000 Received: from localhost ([127.0.0.1]:53758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reGRd-00060n-Og for submit@debbugs.gnu.org; Sun, 25 Feb 2024 10:29:37 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:54732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reGRb-00060P-8Z for 69237@debbugs.gnu.org; Sun, 25 Feb 2024 10:29:35 -0500 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-40fd72f7125so18711335e9.1 for <69237@debbugs.gnu.org>; Sun, 25 Feb 2024 07:29:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708874884; x=1709479684; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oMf1nwh4OS6TDBTIVl3RGDP+5srl4ImFy1VWR2xpKtQ=; b=de8J94Wl9VWqalHygmBsH+5u6y1Qnu6DOGtPLOTP2pxi9n28GLzCtqloukEGdbc3kN DV8baiQsSJDYtuvFaPHSMdrSFgi3yNHY9tuMmS13FVPlWYcG1hCl8RyP5FtJU7tUInCC IGGs2zuFWnb/teoQP7VGBl4lKL0ZrW765akDwQuvzZ8T+VylQyQXmBwlxiPIa8/8p3yi DPqytaZh/p3JZnOTB8t+HcGnac/8Sr7dD4qZxfQNYaZIdwGrZZSCMTNEHdjwJqzE0VB7 ziy/xoTRG61zPvMVwUjy6aYbTNr5dFoydavudz/fcbimNpO9UCU8ntsvAkfgSLcXkYTm evDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708874884; x=1709479684; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oMf1nwh4OS6TDBTIVl3RGDP+5srl4ImFy1VWR2xpKtQ=; b=W2l/fZ4IK6b6SUSLDuocoxDIlGEie7KunJQqFBi60KGEXKshoDupL0qVZkiTe9+8GP hIfUqQJELdJ/fZM+rZhd5NmtMPq3m9SRDaPRk6JFY7K/J5d94a7433JSJSmSmxhpmiZI 37VXNo4gNQSEttx5jk40PkWfFxJUEHOPypmD2xLxBUpBBYkuKru77X243sVyhmbtXYhA H9SUV0qXzDEdUDIXVLzMEINbRuMzd30lTPfuhorbeex4cTqacHU2wngTKEJc5qKHTa1V oPd0hZcG71q6lswWOYEebEDNLoT3+EaY58o3+AxwAt3tVN1MkRY5cWv4CBHp6vH3cwYS WXtQ== X-Gm-Message-State: AOJu0YzmF5lesyuDx7f5Y/XWBGGJSv9KnE18kYHpJ8cL2o1W3lEPHdIN 4+dQ8O4MdZiDzN4gNTaFleyiLGulrt9DY9TGL4sdd7SKiQgneSXfaUk60DnQF2wlEQ== X-Google-Smtp-Source: AGHT+IFBUOG6lxI1My2s3sha8zstoaYZQad7I8zSoe+qXjo5Uh80D7EKsvsbJXWVdv+EBT0RFrYAtQ== X-Received: by 2002:a05:600c:1ca8:b0:412:a0a3:cde with SMTP id k40-20020a05600c1ca800b00412a0a30cdemr1864346wms.7.1708874883901; Sun, 25 Feb 2024 07:28:03 -0800 (PST) Received: from hirondell ([185.201.63.252]) by smtp.gmail.com with ESMTPSA id g14-20020a05600c310e00b00412a3420e71sm1662768wmo.0.2024.02.25.07.27.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 07:28:03 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Michael Albinus Subject: Re: bug#69237: 30.0.50; Toggle password visibility In-Reply-To: <87edd0txal.fsf@gmx.de> (Michael Albinus's message of "Sun, 25 Feb 2024 15:48:18 +0100") References: <87zfw0ttyp.fsf@gmx.de> <87h6i0xhbb.fsf@gmail.com> <8734tjrxt6.fsf@gmx.de> <87v86f86g8.fsf@gmail.com> <87frxgvrh4.fsf@gmx.de> <87o7c4yfzj.fsf@gmail.com> <877cisvl8s.fsf@gmx.de> <8734tgk6ql.fsf@gmail.com> <87edd0txal.fsf@gmx.de> Date: Sun, 25 Feb 2024 15:27:52 +0000 Message-ID: <87wmqspnrb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69237 Cc: 69237@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Albinus writes: > K=C3=A9vin Le Gouguec writes: > > Hi K=C3=A9vin, > >> Maybe we can bike-shed some shorter ASCII art, e.g. >> >> (reveal) >> <\> (conceal) > > Good idea. Bought. Ta everso =F0=9F=99=8F for that, the "hyphen-otomy", and again, for impleme= nting this very-much-appreciated feature! From unknown Fri Jun 20 07:22:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 27 Mar 2024 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator