Subject: Re: bug#69237: 30.0.50; Toggle password visibility

From: Eli Zaretskii <[email-masked]>
Date: Sun, 25 Feb 2024 16:09:13 +0200

> Cc: [email-masked]
> From: Kévin Le Gouguec <[email-masked]>
> Date: Sun, 25 Feb 2024 13:34:26 +0000
> 
> Michael Albinus <[email-masked]> writes:
> 
> >> * Should we keep the double hyphen in "read-passwd--toggle-visibility"?
> >> Feeling like it connotes "Emacs internals" somewhat, and wondering if
> >> it's appropriate for interactive commands since they are "user-facing",
> >> and users might feel discouraged from remapping "internal-looking"
> >> commands.
> >
> > It is not intended that users call 'M-x read-passwd--toggle-visibility'.
> > It makes sense only when you are already editing the minibuffer, typing
> > the password.
> 
> Right, I don't expect many users to run this command via M-x.  My
> thinking went more toward users who might want to do…
> 
>   (keymap-unset read-passwd-map "\t" 'remove)
>   (keymap-set read-passwd-map "C-c \t" 'read-passwd--toggle-visibility)
> 
> … and who might feel uneasy about that "--" in their personal config.

IMO, commands should never have two dashes in their names, because
commands are never "internal", by their very definition.