From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 18 13:24:12 2024 Received: (at submit) by debbugs.gnu.org; 18 Feb 2024 18:24:12 +0000 Received: from localhost ([127.0.0.1]:37314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rblpj-0003Kd-EB for submit@debbugs.gnu.org; Sun, 18 Feb 2024 13:24:12 -0500 Received: from lists.gnu.org ([209.51.188.17]:44974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rblNb-0001bb-9Q for submit@debbugs.gnu.org; Sun, 18 Feb 2024 12:55:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbZHW-0000sB-RQ for bug-gnu-emacs@gnu.org; Sun, 18 Feb 2024 00:00:02 -0500 Received: from mail-oi1-x22a.google.com ([2607:f8b0:4864:20::22a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rbZHU-0004LK-Sk for bug-gnu-emacs@gnu.org; Sun, 18 Feb 2024 00:00:02 -0500 Received: by mail-oi1-x22a.google.com with SMTP id 5614622812f47-3c1374db828so2957758b6e.1 for ; Sat, 17 Feb 2024 20:59:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708232398; x=1708837198; darn=gnu.org; h=subject:from:to:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=9SJJWm9OtFyo10xkXMr1+p1YncAHDfdk5XAOyo8OQQ4=; b=gLbQFURvqSmsNCRetbZm5fMgW+pMXKxpu+GO34Q/MV5YRe6RxgUhlrFq2Mz/DCoO6m Ka081TU2BsgG230jDWEsIu9mZDFY4QITOWeLq6Wgdri+KZFjQKrbjdVY+P62YToezJZ+ OMKwziIRy6XiM2kaNWpBH0d0g73WRsE6vDkdhsoPdTU11o+eMz5iOCTJyzY7/Nl0LvCw WDVmITJrKJSL6Rx+BuXHr30IFjaNTynkM/WjgiJOPMCG7yj5Ek3wL1tguA15vVAJZPt2 7e+0vQuBtUonGruGUJz2V9rZat/IE6R72gTximVMkEhlHSoJzvihTBnvuTokkT2rIrlk 1Esg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708232398; x=1708837198; h=subject:from:to:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9SJJWm9OtFyo10xkXMr1+p1YncAHDfdk5XAOyo8OQQ4=; b=eWZzT8/5vryUC75nPTeSEdgUIQjYk2YAvWJmFtmX9R1+uasxjvbyK1UDuQkWkk2wWN N8dHxSQ4hslWEtueW/QQv/g+vvZPXt8jVWdJ2svSIt+9D5ZfDdN1+t+5wDNK17UZpPam V/9NuNtBNNFQocFKlm+xYanjPrK1F/OADcx9jnLg5yvcPcyJId5JGVQrZe2lAo8N4qSt kUI8fvVNocaFAR+wTOhMRF7vBM0AZ4Px/pxOY4MARyJ0hAG1nKnjvLFJI47OX5whESPL wFz9wixAKYYlQ6/g5WBsgCo1haRI09jasBijmGWNcnA9rxFAh+6Sm7ez4hXK6yXvZtZ0 I9kg== X-Gm-Message-State: AOJu0Yxsodnq4jFjP5KCZR1rUuB3/Y+Gf2nl4bJlZvTt/Wr/GYGdpDhQ jx4gKc3MD7sdC4Ph+i86lfxfo0e8EFvI6UcOKpJLMUufBDNi5uh8tK25ZVhk X-Google-Smtp-Source: AGHT+IF3mIRkfCJbTlorjpYOsUMG2y0OZ/14WfHU1Uhr+ZGEtAiY8aOwPH4YbdWekjc8Y4kuPds7pQ== X-Received: by 2002:a05:6808:2190:b0:3bd:e392:fab9 with SMTP id be16-20020a056808219000b003bde392fab9mr12096993oib.38.1708232398349; Sat, 17 Feb 2024 20:59:58 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x10-20020aa784ca000000b006e3a69eb6c4sm1183290pfn.219.2024.02.17.20.59.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Feb 2024 20:59:57 -0800 (PST) Content-Type: multipart/mixed; boundary="------------NiElEgEt0E0fN7jgHH0AYus0" Message-ID: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> Date: Sat, 17 Feb 2024 20:59:57 -0800 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Jim Porter Subject: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Received-SPF: pass client-ip=2607:f8b0:4864:20::22a; envelope-from=jporterbugs@gmail.com; helo=mail-oi1-x22a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) This is a multi-part message in MIME format. --------------NiElEgEt0E0fN7jgHH0AYus0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit If you navigate back in EWW history, and then forward, you can never hit the "end": it keeps adding duplicate history elements, even though you're not visiting any new pages. To see this in action, start from `emacs -Q`, then: M-x eww RET fsf.org RET M-x eww RET gnu.org RET H ;; Notice that there's one item in the history: the FSF page[1] q ;; Close history window l ;; Go back one in the history to the FSF page H ;; Notice that there are two items in the history r ;; Go forward one, back at the GNU page r ;; Go forward again, now at the FSF page(?!) r ;; Ditto, now at the GNU page r ;; Repeat ad infinitum H ;; Now there are many entries, alternating between GNU and FSF Attached is a patch that fixes this. Now, 'eww-save-history' will update the history entry in-place when viewing a historical page, and 'eww-back-url' / 'eww-forward-url' take that into account. I also fixed the predicates for when the back/forward menu items were enabled. I think this is just a straightforward bug fix, so I didn't add a NEWS entry. I could add one though if it seems worthwhile. [1] EWW doesn't immediately add pages to the history when you navigate to them. Maybe it should, but that can be addressed another day. --------------NiElEgEt0E0fN7jgHH0AYus0 Content-Type: text/plain; charset=UTF-8; name="0001-When-navigating-through-history-in-EWW-don-t-keep-ad.patch" Content-Disposition: attachment; filename*0="0001-When-navigating-through-history-in-EWW-don-t-keep-ad.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAyZTkyNmZkZDgzYTJlYjZiNjhjYzIxYmY4NGVhNzc4ZTkyM2QzZTU1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgMTcgRmViIDIwMjQgMjA6NDk6MTUgLTA4MDAKU3ViamVjdDogW1BB VENIXSBXaGVuIG5hdmlnYXRpbmcgdGhyb3VnaCBoaXN0b3J5IGluIEVXVywgZG9uJ3Qga2Vl cCBhZGRpbmcgdG8KICdld3ctaGlzdG9yeScKClRoaXMgcmVzb2x2ZXMgYW4gaXNzdWUgd2hl cmUgbmF2aWdhdGluZyBiYWNrIGFuZCB0aGVuIGZvcndhcmQga2VwdAphZGRpbmcgbmV3IGhp c3RvcnkgZW50cmllcyBzbyB5b3UgY291bGQgbmV2ZXIgaGl0IHRoZSAiZW5kIi4KCiogbGlz cC9uZXQvZXd3LmVsIChld3ctaGlzdG9yeS1wb3NpdGlvbik6IEFkZCBkb2NzdHJpbmcuCihl d3ctbW9kZS1tYXAsIGV3dy1jb250ZXh0LW1lbnUpOiBVc2UgY29ycmVjdCBwcmVkaWNhdGVz IGZvciB3aGVuIHRvCmVuYWJsZSBiYWNrL2ZvcndhcmQuCihld3ctc2F2ZS1oaXN0b3J5KTog U2F2ZSBoaXN0b3J5IGVudHJ5IGluIGl0cyBvcmlnaW5hbCBwbGFjZSB3aGVuCnZpZXdpbmcg YSBoaXN0b3JpY2FsIHBhZ2UuCihld3ctYmFjay11cmwpOiBTZXQgJ2V3dy1oaXN0b3J5LXBv c2l0aW9uJyBiYXNlZCBvbiB0aGUgcmVzdWx0IG9mCidld3ctc2F2ZS1oaXN0b3J5Jy4KKGV3 dy1mb3J3YXJkLXVybCk6IFNldCAnZXd3LWhpc3RvcnktcG9zaXRpb24nIGRpcmVjdGx5LCBz aW5jZQonZXd3LXNhdmUtaGlzdG9yeScgbm8gbG9uZ2VyIGFkZHMgYSBuZXcgZW50cnkgaW4g dGhpcyBjYXNlLgotLS0KIGxpc3AvbmV0L2V3dy5lbCB8IDM5ICsrKysrKysrKysrKysrKysr KysrKysrKysrKystLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDI4IGluc2VydGlvbnMo KyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvbmV0L2V3dy5lbCBiL2xp c3AvbmV0L2V3dy5lbAppbmRleCA2YWUxZTZkM2QwYS4uODE5NmYyMjJhZDggMTAwNjQ0Ci0t LSBhL2xpc3AvbmV0L2V3dy5lbAorKysgYi9saXNwL25ldC9ld3cuZWwKQEAgLTMxMiw3ICsz MTIsMTAgQEAgZXd3LXZhbGlkLWNlcnRpZmljYXRlCiAKIChkZWZ2YXIgZXd3LWRhdGEgbmls KQogKGRlZnZhciBld3ctaGlzdG9yeSBuaWwpCi0oZGVmdmFyIGV3dy1oaXN0b3J5LXBvc2l0 aW9uIDApCisoZGVmdmFyIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDAKKyAgIlRoZSAxLWluZGV4 ZWQgcG9zaXRpb24gaW4gYGV3dy1oaXN0b3J5Jy4KK0lmIHplcm8sIEVXVyBpcyBhdCB0aGUg bmV3ZXN0IHBhZ2UsIHdoaWNoIGlzbid0IHlldCBwcmVzZW50IGluCitgZXd3LWhpc3Rvcnkn LiIpCiAoZGVmdmFyIGV3dy1wcm9tcHQtaGlzdG9yeSBuaWwpCiAKIChkZWZ2YXIgZXd3LWxv Y2FsLXJlZ2V4ICJsb2NhbGhvc3QiCkBAIC0xMTI5LDkgKzExMzIsOSBAQCBld3ctbW9kZS1t YXAKICAgICAgICAgICBbIlJlbG9hZCIgZXd3LXJlbG9hZCB0XQogICAgICAgICAgIFsiRm9s bG93IFVSTCBpbiBuZXcgYnVmZmVyIiBld3ctb3Blbi1pbi1uZXctYnVmZmVyXQogICAgICAg ICAgIFsiQmFjayB0byBwcmV2aW91cyBwYWdlIiBld3ctYmFjay11cmwKLSAgICAgICAgICAg OmFjdGl2ZSAobm90ICh6ZXJvcCAobGVuZ3RoIGV3dy1oaXN0b3J5KSkpXQorICAgICAgICAg ICA6YWN0aXZlICg8IGV3dy1oaXN0b3J5LXBvc2l0aW9uIChsZW5ndGggZXd3LWhpc3Rvcnkp KV0KICAgICAgICAgICBbIkZvcndhcmQgdG8gbmV4dCBwYWdlIiBld3ctZm9yd2FyZC11cmwK LSAgICAgICAgICAgOmFjdGl2ZSAobm90ICh6ZXJvcCBld3ctaGlzdG9yeS1wb3NpdGlvbikp XQorICAgICAgICAgICA6YWN0aXZlICg+IGV3dy1oaXN0b3J5LXBvc2l0aW9uIDEpXQogICAg ICAgICAgIFsiQnJvd3NlIHdpdGggZXh0ZXJuYWwgYnJvd3NlciIgZXd3LWJyb3dzZS13aXRo LWV4dGVybmFsLWJyb3dzZXIgdF0KICAgICAgICAgICBbIkRvd25sb2FkIiBld3ctZG93bmxv YWQgdF0KICAgICAgICAgICBbIlZpZXcgcGFnZSBzb3VyY2UiIGV3dy12aWV3LXNvdXJjZV0K QEAgLTExNTUsOSArMTE1OCw5IEBAIGV3dy1jb250ZXh0LW1lbnUKICAgICAoZWFzeS1tZW51 LWRlZmluZSBuaWwgZWFzeS1tZW51IG5pbAogICAgICAgJygiRXd3IgogICAgICAgICBbIkJh Y2sgdG8gcHJldmlvdXMgcGFnZSIgZXd3LWJhY2stdXJsCi0JIDp2aXNpYmxlIChub3QgKHpl cm9wIChsZW5ndGggZXd3LWhpc3RvcnkpKSldCisJIDphY3RpdmUgKDwgZXd3LWhpc3Rvcnkt cG9zaXRpb24gKGxlbmd0aCBld3ctaGlzdG9yeSkpXQogCVsiRm9yd2FyZCB0byBuZXh0IHBh Z2UiIGV3dy1mb3J3YXJkLXVybAotCSA6dmlzaWJsZSAobm90ICh6ZXJvcCBld3ctaGlzdG9y eS1wb3NpdGlvbikpXQorCSA6YWN0aXZlICg+IGV3dy1oaXN0b3J5LXBvc2l0aW9uIDEpXQog CVsiUmVsb2FkIiBld3ctcmVsb2FkIHRdKSkKICAgICAoZG9saXN0IChpdGVtIChyZXZlcnNl IChsb29rdXAta2V5IGVhc3ktbWVudSBbbWVudS1iYXIgZXd3XSkpKQogICAgICAgKHdoZW4g KGNvbnNwIGl0ZW0pCkBAIC0xMjgwLDE2ICsxMjgzLDIwIEBAIGV3dy1iYWNrLXVybAogICAo aW50ZXJhY3RpdmUgbmlsIGV3dy1tb2RlKQogICAod2hlbiAoPj0gZXd3LWhpc3RvcnktcG9z aXRpb24gKGxlbmd0aCBld3ctaGlzdG9yeSkpCiAgICAgKHVzZXItZXJyb3IgIk5vIHByZXZp b3VzIHBhZ2UiKSkKLSAgKGV3dy1zYXZlLWhpc3RvcnkpCi0gIChzZXRxIGV3dy1oaXN0b3J5 LXBvc2l0aW9uICgrIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDIpKQorICAoaWYgKGV3dy1zYXZl LWhpc3RvcnkpCisgICAgICA7OyBXZSB3ZXJlIGF0IHRoZSBsYXRlc3QgcGFnZSAod2hpY2gg d2FzIGp1c3QgYWRkZWQgdG8gdGhlCisgICAgICA7OyBoaXN0b3J5KSwgc28gZ28gYmFjayB0 d28gZW50cmllcy4KKyAgICAgIChzZXRxIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDIpCisgICAg KHNldHEgZXd3LWhpc3RvcnktcG9zaXRpb24gKDErIGV3dy1oaXN0b3J5LXBvc2l0aW9uKSkp CiAgIChld3ctcmVzdG9yZS1oaXN0b3J5IChlbHQgZXd3LWhpc3RvcnkgKDEtIGV3dy1oaXN0 b3J5LXBvc2l0aW9uKSkpKQogCiAoZGVmdW4gZXd3LWZvcndhcmQtdXJsICgpCiAgICJHbyB0 byB0aGUgbmV4dCBkaXNwbGF5ZWQgcGFnZS4iCiAgIChpbnRlcmFjdGl2ZSBuaWwgZXd3LW1v ZGUpCi0gICh3aGVuICh6ZXJvcCBld3ctaGlzdG9yeS1wb3NpdGlvbikKKyAgKHdoZW4gKDw9 IGV3dy1oaXN0b3J5LXBvc2l0aW9uIDEpCiAgICAgKHVzZXItZXJyb3IgIk5vIG5leHQgcGFn ZSIpKQogICAoZXd3LXNhdmUtaGlzdG9yeSkKKyAgKHNldHEgZXd3LWhpc3RvcnktcG9zaXRp b24gKDEtIGV3dy1oaXN0b3J5LXBvc2l0aW9uKSkKICAgKGV3dy1yZXN0b3JlLWhpc3Rvcnkg KGVsdCBld3ctaGlzdG9yeSAoMS0gZXd3LWhpc3RvcnktcG9zaXRpb24pKSkpCiAKIChkZWZ1 biBld3ctcmVzdG9yZS1oaXN0b3J5IChlbGVtKQpAQCAtMjI4OSwxMSArMjI5NiwyMSBAQCBl d3ctYm9va21hcmstbW9kZQogOzs7IEhpc3RvcnkgY29kZQogCiAoZGVmdW4gZXd3LXNhdmUt aGlzdG9yeSAoKQorICAiU2F2ZSB0aGUgY3VycmVudCBwYWdlJ3MgZGF0YSB0byB0aGUgaGlz dG9yeS4KK0lmIHRoZSBjdXJyZW50IHBhZ2UgaXMgYSBoaXN0b3JpYWwgb25lIGxvYWRlZCBm cm9tCitgZXd3LWhpc3RvcnknIChlLmcuIGJ5IGNhbGxpbmcgYGV3dy1iYWNrLXVybCcpLCB0 aGlzIHdpbGwgdXBkYXRlIHRoZQorcGFnZSdzIGVudHJ5IGluIGBld3ctaGlzdG9yeScgYW5k IHJldHVybiBuaWwuICBPdGhlcndpc2UsIGFkZCBhIG5ldworZW50cnkgdG8gYGV3dy1oaXN0 b3J5JyBhbmQgcmV0dXJuIHQuIgogICAocGxpc3QtcHV0IGV3dy1kYXRhIDpwb2ludCAocG9p bnQpKQogICAocGxpc3QtcHV0IGV3dy1kYXRhIDp0ZXh0IChidWZmZXItc3RyaW5nKSkKLSAg KGxldCAoKGhpc3RvcnktZGVsZXRlLWR1cGxpY2F0ZXMgbmlsKSkKLSAgICAoYWRkLXRvLWhp c3RvcnkgJ2V3dy1oaXN0b3J5IGV3dy1kYXRhIGV3dy1oaXN0b3J5LWxpbWl0IHQpKQotICAo c2V0cSBld3ctZGF0YSAobGlzdCA6dGl0bGUgIiIpKSkKKyAgKHByb2cxCisgICAgICAoaWYg KHplcm9wIGV3dy1oaXN0b3J5LXBvc2l0aW9uKQorICAgICAgICAgIChsZXQgKChoaXN0b3J5 LWRlbGV0ZS1kdXBsaWNhdGVzIG5pbCkpCisgICAgICAgICAgICAoYWRkLXRvLWhpc3Rvcnkg J2V3dy1oaXN0b3J5IGV3dy1kYXRhIGV3dy1oaXN0b3J5LWxpbWl0IHQpCisgICAgICAgICAg ICB0KQorICAgICAgICAoc2V0ZiAoZWx0IGV3dy1oaXN0b3J5ICgxLSBld3ctaGlzdG9yeS1w b3NpdGlvbikpIGV3dy1kYXRhKQorICAgICAgICBuaWwpCisgICAgKHNldHEgZXd3LWRhdGEg KGxpc3QgOnRpdGxlICIiKSkpKQogCiAoZGVmdmFyIGV3dy1jdXJyZW50LWJ1ZmZlcikKIAot LSAKMi4yNS4xCgo= --------------NiElEgEt0E0fN7jgHH0AYus0-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 19 07:12:43 2024 Received: (at 69232) by debbugs.gnu.org; 19 Feb 2024 12:12:43 +0000 Received: from localhost ([127.0.0.1]:40521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc2Vm-0006OC-PW for submit@debbugs.gnu.org; Mon, 19 Feb 2024 07:12:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc2Vk-0006Nu-9v for 69232@debbugs.gnu.org; Mon, 19 Feb 2024 07:12:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc2VJ-0000CX-Nn; Mon, 19 Feb 2024 07:12:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=v83KbppGFyEt2tia3j62uV4rkdww/I9T0fGeEdrYrJ4=; b=Bl5fVY2e53bD tlaMMGS+AL6PhUB0eZJZikkU2uswvxI2TwvmvfONa+TlykYlZzXTtLiXe+cOi6Rwqw1S0+HHnW6V/ dHVucX9i/aWFtCYLkR1hcJvLYPpVUYedxWwg8luv9CbHSCUko8DgmF5d0z4LzMu3ixxz7eeqF66LS 7IVDJmU6mW5A8u8vr0XL+HDACH1Y7G+0c4TKTgTPYO1+xj78h7lzhx75BP4GO5le1AnsRmPXNSYVM Ydw6I0NRgPEEX+5wQxvILJ3Kmq2NnDDtF/L3Th/CGFhw6OfpfMP9CvgOd+G9gxyFGFuZJj6rp6yFg AVz4hIsVq+7LVZua1zqxvQ==; Date: Mon, 19 Feb 2024 14:12:07 +0200 Message-Id: <864je4r6ug.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> (message from Jim Porter on Sat, 17 Feb 2024 20:59:57 -0800) Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) > Date: Sat, 17 Feb 2024 20:59:57 -0800 > From: Jim Porter > > If you navigate back in EWW history, and then forward, you can never hit > the "end": it keeps adding duplicate history elements, even though > you're not visiting any new pages. To see this in action, start from > `emacs -Q`, then: > > M-x eww RET fsf.org RET > M-x eww RET gnu.org RET > H ;; Notice that there's one item in the history: the FSF page[1] > q ;; Close history window > l ;; Go back one in the history to the FSF page > H ;; Notice that there are two items in the history > r ;; Go forward one, back at the GNU page > r ;; Go forward again, now at the FSF page(?!) > r ;; Ditto, now at the GNU page > r ;; Repeat ad infinitum > H ;; Now there are many entries, alternating between GNU and FSF > > Attached is a patch that fixes this. Now, 'eww-save-history' will update > the history entry in-place when viewing a historical page, and > 'eww-back-url' / 'eww-forward-url' take that into account. I also fixed > the predicates for when the back/forward menu items were enabled. > > I think this is just a straightforward bug fix, so I didn't add a NEWS > entry. I could add one though if it seems worthwhile. I'm not sure this is a bug fix, and I think this behavior change does need a NEWS entry. And have sure you are that no one will want the current behavior? From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 19 13:57:20 2024 Received: (at 69232) by debbugs.gnu.org; 19 Feb 2024 18:57:20 +0000 Received: from localhost ([127.0.0.1]:43407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc8pL-0006rM-Hc for submit@debbugs.gnu.org; Mon, 19 Feb 2024 13:57:20 -0500 Received: from mail-pl1-f180.google.com ([209.85.214.180]:44439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc8pI-0006r7-8L for 69232@debbugs.gnu.org; Mon, 19 Feb 2024 13:57:18 -0500 Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1d932f6ccfaso37805425ad.1 for <69232@debbugs.gnu.org>; Mon, 19 Feb 2024 10:56:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708368949; x=1708973749; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=qXDyyijlvRnuRCEkR0hCEeHVjx0ZJhHgMUjfzsYAK80=; b=kMQYmCNKk8DyQNaCKsSuV72yXWck3IYtMKcnhtD8HSKmO2Uu581bgCrtH7kS6y1O1v YpO+fvLXfwNkr/FT8YJ/Do5TWYUWRGqi/ifYuRCyhLi8Zs6bYp7jvlUwfgG+dvI/MVcN 7A/HtgkgsqPg0NXfinhg8pQrDPIeAXQi+r3I1QK1Yv9pSJVvgrR0DxL3ij2jW9G5+p6M dQMKPH3ap2nGGlHxMF8SiBy8AlnuXgSulpR4t1TC7Kgn63tf1voav/KjBQomPdMFwKbw pPyMo8S//wItAlDgVr8c+ZEDQTHp/2gVjYd5qSLUwBWWf1g3lbe95SYvsV7E50jJ+Rz+ W6zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708368949; x=1708973749; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=qXDyyijlvRnuRCEkR0hCEeHVjx0ZJhHgMUjfzsYAK80=; b=iqhdIWf/GUsVc1SHFFt8HZqK5cXLJsJqmHOJiq+fFDHByHVjVmmE8jS9gvK+Z82WhF dHpjCBVUaOFazIC2Bd9yPOD2qiPcKoGx6t9alO0xHM7qac2XFArDpnWYOOIPJEwmKKQE +JXhrZ18/lQ85DULjUU5YtQ2/eUA/pwFIPicW1FAO6WiYHxq/zhJwlimveMJBLH5y0FH B6aviWfWmOBnmojp906gwXGfQmxcLwHwxyY8FcDLrVqywMgB2zWNrpgRTbaBWi72eIPt KWB4rdE381cedtJEf2r3XdIkQGn722GnGVGwtqMHDV02WHKOsXHRWSEYTi+U+zsrZ2mp giHw== X-Gm-Message-State: AOJu0YygqguP3bKv7OU2Tqr0d2PANBjvKVK0kPABt6kj9dLAX4KMjKfe Dv3reUKe5FGrPzO6JR2Rw/H6tlDVpE1A4jNwgGxB8MHICtlbVjde X-Google-Smtp-Source: AGHT+IE7iu+LiPtCMj3hxk/LaRUAWKHE3TcsgQ+cvmIVLPR6qip4wwUIP9ipRsRYKyOmKTyaAUeKaA== X-Received: by 2002:a17:902:9304:b0:1db:3618:fed5 with SMTP id bc4-20020a170902930400b001db3618fed5mr10075105plb.53.1708368948998; Mon, 19 Feb 2024 10:55:48 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id h4-20020a170902eec400b001db7ed7ac34sm4680200plb.297.2024.02.19.10.55.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Feb 2024 10:55:48 -0800 (PST) Content-Type: multipart/mixed; boundary="------------VOh0NJfZTvteD0UvoLxcV67y" Message-ID: Date: Mon, 19 Feb 2024 10:55:49 -0800 MIME-Version: 1.0 Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Content-Language: en-US To: Eli Zaretskii References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> From: Jim Porter In-Reply-To: <864je4r6ug.fsf@gnu.org> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) This is a multi-part message in MIME format. --------------VOh0NJfZTvteD0UvoLxcV67y Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/19/2024 4:12 AM, Eli Zaretskii wrote: > I'm not sure this is a bug fix, and I think this behavior change does > need a NEWS entry. Ok, I added one. > And have sure you are that no one will want the current behavior? Well, I suppose I can't prove that there's no one who likes the current behavior. I'd be pretty surprised though, since I've never seen a browser that manages back/forward navigation like this. In *theory*, a person might be able to (ab)use this to track changes to a given page across refreshes, but that doesn't work consistently, since EWW doesn't always add a new history entry upon reloading. Given that you have to jump through some hoops to trigger this behavior (for example, this doesn't work if you're at a new page not in 'eww-history' yet), I doubt anyone has noticed that this is possible. On the off chance that someone wants a feature like that, I think we could do it in a better way, anyway. If you're still concerned that someone might prefer the current behavior, I could announce the change to emacs-devel after (or before) it merges in order to give people an opportunity to speak up. --------------VOh0NJfZTvteD0UvoLxcV67y Content-Type: text/plain; charset=UTF-8; name="0001-When-navigating-through-history-in-EWW-don-t-keep-ad.patch" Content-Disposition: attachment; filename*0="0001-When-navigating-through-history-in-EWW-don-t-keep-ad.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA4OWQ2MGQ0MWUyMDAxOTU5ZmE3M2YyMjlhN2Q5ODk1NWQxMGQ2Yzk4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgMTcgRmViIDIwMjQgMjA6NDk6MTUgLTA4MDAKU3ViamVjdDogW1BB VENIXSBXaGVuIG5hdmlnYXRpbmcgdGhyb3VnaCBoaXN0b3J5IGluIEVXVywgZG9uJ3Qga2Vl cCBhZGRpbmcgdG8KICdld3ctaGlzdG9yeScKClRoaXMgcmVzb2x2ZXMgYW4gaXNzdWUgd2hl cmUgbmF2aWdhdGluZyBiYWNrIGFuZCB0aGVuIGZvcndhcmQga2VwdAphZGRpbmcgbmV3IGhp c3RvcnkgZW50cmllcyBzbyB5b3UgY291bGQgbmV2ZXIgaGl0IHRoZSAiZW5kIiAoYnVnIzY5 MjMyKS4KCiogbGlzcC9uZXQvZXd3LmVsIChld3ctaGlzdG9yeS1wb3NpdGlvbik6IEFkZCBk b2NzdHJpbmcuCihld3ctbW9kZS1tYXAsIGV3dy1jb250ZXh0LW1lbnUpOiBVc2UgY29ycmVj dCBwcmVkaWNhdGVzIGZvciB3aGVuIHRvCmVuYWJsZSBiYWNrL2ZvcndhcmQuCihld3ctc2F2 ZS1oaXN0b3J5KTogU2F2ZSBoaXN0b3J5IGVudHJ5IGluIGl0cyBvcmlnaW5hbCBwbGFjZSB3 aGVuCnZpZXdpbmcgYSBoaXN0b3JpY2FsIHBhZ2UuCihld3ctYmFjay11cmwpOiBTZXQgJ2V3 dy1oaXN0b3J5LXBvc2l0aW9uJyBiYXNlZCBvbiB0aGUgcmVzdWx0IG9mCidld3ctc2F2ZS1o aXN0b3J5Jy4KKGV3dy1mb3J3YXJkLXVybCk6IFNldCAnZXd3LWhpc3RvcnktcG9zaXRpb24n IGRpcmVjdGx5LCBzaW5jZQonZXd3LXNhdmUtaGlzdG9yeScgbm8gbG9uZ2VyIGFkZHMgYSBu ZXcgZW50cnkgaW4gdGhpcyBjYXNlLgoKKiBldGMvTkVXUzogQW5ub3VuY2UgdGhpcyBjaGFu Z2UuCi0tLQogZXRjL05FV1MgICAgICAgIHwgIDcgKysrKysrKwogbGlzcC9uZXQvZXd3LmVs IHwgMzkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCiAyIGZpbGVz IGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggNDQ3NzExNjI0OGUuLmY5MjIzYTMxZmJk IDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtOTgyLDYgKzk4Miwx MyBAQCBXaGVuIGludm9rZWQgd2l0aCB0aGUgcHJlZml4IGFyZ3VtZW50ICgnQy11JyksCiBU aGlzIGlzIHVzZWZ1bCBmb3IgY29udGludWluZyByZWFkaW5nIHRoZSBVUkwgaW4gdGhlIGN1 cnJlbnQgYnVmZmVyCiB3aGVuIHRoZSBuZXcgVVJMIGlzIGZldGNoZWQuCiAKKy0tLQorKioq IEhpc3RvcnkgbmF2aWdhdGlvbiBpbiBFV1cgbm93IHdvcmtzIGxpa2Ugb3RoZXIgYnJvd3Nl cnMuCitQcmV2aW91c2x5LCB3aGVuIG5hdmlnYXRpbmcgYmFjayBhbmQgZm9yd2FyZCB0aHJv dWdoIHBhZ2UgaGlzdG9yeSBpbgorRVdXLCBuZXcgaGlzdG9yeSBlbnRyaWVzIGNvdWxkIGdl dCBhZGRlZCB0byB0aGUgaGlzdG9yeSBsaXN0LiAgTm93LCB3aGVuCituYXZpZ2F0aW5nIHRo cm91Z2ggaGlzdG9yeSwgRVdXIHByZXNlcnZlcyB0aGUgaGlzdG9yeSBsaXN0IGFuZCBvbmx5 CitkaXNwbGF5cyB0aGUgcmVsZXZhbnQgaGlzdG9yeSBlbnRyeS4KKwogKiogZ28tdHMtbW9k ZQogCiArKysKZGlmZiAtLWdpdCBhL2xpc3AvbmV0L2V3dy5lbCBiL2xpc3AvbmV0L2V3dy5l bAppbmRleCA2YWUxZTZkM2QwYS4uODE5NmYyMjJhZDggMTAwNjQ0Ci0tLSBhL2xpc3AvbmV0 L2V3dy5lbAorKysgYi9saXNwL25ldC9ld3cuZWwKQEAgLTMxMiw3ICszMTIsMTAgQEAgZXd3 LXZhbGlkLWNlcnRpZmljYXRlCiAKIChkZWZ2YXIgZXd3LWRhdGEgbmlsKQogKGRlZnZhciBl d3ctaGlzdG9yeSBuaWwpCi0oZGVmdmFyIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDApCisoZGVm dmFyIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDAKKyAgIlRoZSAxLWluZGV4ZWQgcG9zaXRpb24g aW4gYGV3dy1oaXN0b3J5Jy4KK0lmIHplcm8sIEVXVyBpcyBhdCB0aGUgbmV3ZXN0IHBhZ2Us IHdoaWNoIGlzbid0IHlldCBwcmVzZW50IGluCitgZXd3LWhpc3RvcnknLiIpCiAoZGVmdmFy IGV3dy1wcm9tcHQtaGlzdG9yeSBuaWwpCiAKIChkZWZ2YXIgZXd3LWxvY2FsLXJlZ2V4ICJs b2NhbGhvc3QiCkBAIC0xMTI5LDkgKzExMzIsOSBAQCBld3ctbW9kZS1tYXAKICAgICAgICAg ICBbIlJlbG9hZCIgZXd3LXJlbG9hZCB0XQogICAgICAgICAgIFsiRm9sbG93IFVSTCBpbiBu ZXcgYnVmZmVyIiBld3ctb3Blbi1pbi1uZXctYnVmZmVyXQogICAgICAgICAgIFsiQmFjayB0 byBwcmV2aW91cyBwYWdlIiBld3ctYmFjay11cmwKLSAgICAgICAgICAgOmFjdGl2ZSAobm90 ICh6ZXJvcCAobGVuZ3RoIGV3dy1oaXN0b3J5KSkpXQorICAgICAgICAgICA6YWN0aXZlICg8 IGV3dy1oaXN0b3J5LXBvc2l0aW9uIChsZW5ndGggZXd3LWhpc3RvcnkpKV0KICAgICAgICAg ICBbIkZvcndhcmQgdG8gbmV4dCBwYWdlIiBld3ctZm9yd2FyZC11cmwKLSAgICAgICAgICAg OmFjdGl2ZSAobm90ICh6ZXJvcCBld3ctaGlzdG9yeS1wb3NpdGlvbikpXQorICAgICAgICAg ICA6YWN0aXZlICg+IGV3dy1oaXN0b3J5LXBvc2l0aW9uIDEpXQogICAgICAgICAgIFsiQnJv d3NlIHdpdGggZXh0ZXJuYWwgYnJvd3NlciIgZXd3LWJyb3dzZS13aXRoLWV4dGVybmFsLWJy b3dzZXIgdF0KICAgICAgICAgICBbIkRvd25sb2FkIiBld3ctZG93bmxvYWQgdF0KICAgICAg ICAgICBbIlZpZXcgcGFnZSBzb3VyY2UiIGV3dy12aWV3LXNvdXJjZV0KQEAgLTExNTUsOSAr MTE1OCw5IEBAIGV3dy1jb250ZXh0LW1lbnUKICAgICAoZWFzeS1tZW51LWRlZmluZSBuaWwg ZWFzeS1tZW51IG5pbAogICAgICAgJygiRXd3IgogICAgICAgICBbIkJhY2sgdG8gcHJldmlv dXMgcGFnZSIgZXd3LWJhY2stdXJsCi0JIDp2aXNpYmxlIChub3QgKHplcm9wIChsZW5ndGgg ZXd3LWhpc3RvcnkpKSldCisJIDphY3RpdmUgKDwgZXd3LWhpc3RvcnktcG9zaXRpb24gKGxl bmd0aCBld3ctaGlzdG9yeSkpXQogCVsiRm9yd2FyZCB0byBuZXh0IHBhZ2UiIGV3dy1mb3J3 YXJkLXVybAotCSA6dmlzaWJsZSAobm90ICh6ZXJvcCBld3ctaGlzdG9yeS1wb3NpdGlvbikp XQorCSA6YWN0aXZlICg+IGV3dy1oaXN0b3J5LXBvc2l0aW9uIDEpXQogCVsiUmVsb2FkIiBl d3ctcmVsb2FkIHRdKSkKICAgICAoZG9saXN0IChpdGVtIChyZXZlcnNlIChsb29rdXAta2V5 IGVhc3ktbWVudSBbbWVudS1iYXIgZXd3XSkpKQogICAgICAgKHdoZW4gKGNvbnNwIGl0ZW0p CkBAIC0xMjgwLDE2ICsxMjgzLDIwIEBAIGV3dy1iYWNrLXVybAogICAoaW50ZXJhY3RpdmUg bmlsIGV3dy1tb2RlKQogICAod2hlbiAoPj0gZXd3LWhpc3RvcnktcG9zaXRpb24gKGxlbmd0 aCBld3ctaGlzdG9yeSkpCiAgICAgKHVzZXItZXJyb3IgIk5vIHByZXZpb3VzIHBhZ2UiKSkK LSAgKGV3dy1zYXZlLWhpc3RvcnkpCi0gIChzZXRxIGV3dy1oaXN0b3J5LXBvc2l0aW9uICgr IGV3dy1oaXN0b3J5LXBvc2l0aW9uIDIpKQorICAoaWYgKGV3dy1zYXZlLWhpc3RvcnkpCisg ICAgICA7OyBXZSB3ZXJlIGF0IHRoZSBsYXRlc3QgcGFnZSAod2hpY2ggd2FzIGp1c3QgYWRk ZWQgdG8gdGhlCisgICAgICA7OyBoaXN0b3J5KSwgc28gZ28gYmFjayB0d28gZW50cmllcy4K KyAgICAgIChzZXRxIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDIpCisgICAgKHNldHEgZXd3LWhp c3RvcnktcG9zaXRpb24gKDErIGV3dy1oaXN0b3J5LXBvc2l0aW9uKSkpCiAgIChld3ctcmVz dG9yZS1oaXN0b3J5IChlbHQgZXd3LWhpc3RvcnkgKDEtIGV3dy1oaXN0b3J5LXBvc2l0aW9u KSkpKQogCiAoZGVmdW4gZXd3LWZvcndhcmQtdXJsICgpCiAgICJHbyB0byB0aGUgbmV4dCBk aXNwbGF5ZWQgcGFnZS4iCiAgIChpbnRlcmFjdGl2ZSBuaWwgZXd3LW1vZGUpCi0gICh3aGVu ICh6ZXJvcCBld3ctaGlzdG9yeS1wb3NpdGlvbikKKyAgKHdoZW4gKDw9IGV3dy1oaXN0b3J5 LXBvc2l0aW9uIDEpCiAgICAgKHVzZXItZXJyb3IgIk5vIG5leHQgcGFnZSIpKQogICAoZXd3 LXNhdmUtaGlzdG9yeSkKKyAgKHNldHEgZXd3LWhpc3RvcnktcG9zaXRpb24gKDEtIGV3dy1o aXN0b3J5LXBvc2l0aW9uKSkKICAgKGV3dy1yZXN0b3JlLWhpc3RvcnkgKGVsdCBld3ctaGlz dG9yeSAoMS0gZXd3LWhpc3RvcnktcG9zaXRpb24pKSkpCiAKIChkZWZ1biBld3ctcmVzdG9y ZS1oaXN0b3J5IChlbGVtKQpAQCAtMjI4OSwxMSArMjI5NiwyMSBAQCBld3ctYm9va21hcmst bW9kZQogOzs7IEhpc3RvcnkgY29kZQogCiAoZGVmdW4gZXd3LXNhdmUtaGlzdG9yeSAoKQor ICAiU2F2ZSB0aGUgY3VycmVudCBwYWdlJ3MgZGF0YSB0byB0aGUgaGlzdG9yeS4KK0lmIHRo ZSBjdXJyZW50IHBhZ2UgaXMgYSBoaXN0b3JpYWwgb25lIGxvYWRlZCBmcm9tCitgZXd3LWhp c3RvcnknIChlLmcuIGJ5IGNhbGxpbmcgYGV3dy1iYWNrLXVybCcpLCB0aGlzIHdpbGwgdXBk YXRlIHRoZQorcGFnZSdzIGVudHJ5IGluIGBld3ctaGlzdG9yeScgYW5kIHJldHVybiBuaWwu ICBPdGhlcndpc2UsIGFkZCBhIG5ldworZW50cnkgdG8gYGV3dy1oaXN0b3J5JyBhbmQgcmV0 dXJuIHQuIgogICAocGxpc3QtcHV0IGV3dy1kYXRhIDpwb2ludCAocG9pbnQpKQogICAocGxp c3QtcHV0IGV3dy1kYXRhIDp0ZXh0IChidWZmZXItc3RyaW5nKSkKLSAgKGxldCAoKGhpc3Rv cnktZGVsZXRlLWR1cGxpY2F0ZXMgbmlsKSkKLSAgICAoYWRkLXRvLWhpc3RvcnkgJ2V3dy1o aXN0b3J5IGV3dy1kYXRhIGV3dy1oaXN0b3J5LWxpbWl0IHQpKQotICAoc2V0cSBld3ctZGF0 YSAobGlzdCA6dGl0bGUgIiIpKSkKKyAgKHByb2cxCisgICAgICAoaWYgKHplcm9wIGV3dy1o aXN0b3J5LXBvc2l0aW9uKQorICAgICAgICAgIChsZXQgKChoaXN0b3J5LWRlbGV0ZS1kdXBs aWNhdGVzIG5pbCkpCisgICAgICAgICAgICAoYWRkLXRvLWhpc3RvcnkgJ2V3dy1oaXN0b3J5 IGV3dy1kYXRhIGV3dy1oaXN0b3J5LWxpbWl0IHQpCisgICAgICAgICAgICB0KQorICAgICAg ICAoc2V0ZiAoZWx0IGV3dy1oaXN0b3J5ICgxLSBld3ctaGlzdG9yeS1wb3NpdGlvbikpIGV3 dy1kYXRhKQorICAgICAgICBuaWwpCisgICAgKHNldHEgZXd3LWRhdGEgKGxpc3QgOnRpdGxl ICIiKSkpKQogCiAoZGVmdmFyIGV3dy1jdXJyZW50LWJ1ZmZlcikKIAotLSAKMi4yNS4xCgo= --------------VOh0NJfZTvteD0UvoLxcV67y-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 19 14:17:57 2024 Received: (at 69232) by debbugs.gnu.org; 19 Feb 2024 19:17:57 +0000 Received: from localhost ([127.0.0.1]:43430 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc99I-0007Mw-Mb for submit@debbugs.gnu.org; Mon, 19 Feb 2024 14:17:57 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc99G-0007Mh-28 for 69232@debbugs.gnu.org; Mon, 19 Feb 2024 14:17:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc98p-0000UN-CL; Mon, 19 Feb 2024 14:17:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=mz6GbDz08ibP6Gi5TorTTWmsv4Vop6I74snU/WB5Lac=; b=CXJhU1B2i7Dp mqXoteG3CX0czvdgkfxU1mBRTNdQg/rVLjEmWhONtwsC057wIvG+9bJ+eODjqOoohRAMqCRz2Zig8 dADENeVSm3Q3pglnffF+qLnbISaP3goOOZ+YeAmRNu11uxDKxS4/BLz4HcdikKBCzn3oEV5psT5BV JDJzCujZKfcygKCRZiZ+9Oer6xLajFcZa6Y0HKwN2noT2namQYF2d1VFMcxa9F0UwTyBEUt7eVixT nz5pwAC43ObEnVMAfU95xbvvfBjNpm/CZ2kkf2Qm1H72riOtSnl8Q/HesHuloinge7lxY8KMeGDjI XWDN2ynsczJibl4wW35T/A==; Date: Mon, 19 Feb 2024 21:17:24 +0200 Message-Id: <868r3gp8l7.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Mon, 19 Feb 2024 10:55:49 -0800) Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) > Date: Mon, 19 Feb 2024 10:55:49 -0800 > Cc: 69232@debbugs.gnu.org > From: Jim Porter > > If you're still concerned that someone might prefer the current > behavior, I could announce the change to emacs-devel after (or before) > it merges in order to give people an opportunity to speak up. Maybe announce it now, so that in a week or two, when it's time to install, we could learn whether this change would bother someone. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 22 09:32:54 2024 Received: (at 69232) by debbugs.gnu.org; 22 Feb 2024 14:32:54 +0000 Received: from localhost ([127.0.0.1]:58511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdA85-0006WQ-1H for submit@debbugs.gnu.org; Thu, 22 Feb 2024 09:32:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdA80-0006W2-SN for 69232@debbugs.gnu.org; Thu, 22 Feb 2024 09:32:51 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rd91v-0002SY-Pa; Thu, 22 Feb 2024 08:22:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2epRgkFpPTRuGl679rVb6gXs3ehYBW5mhNDKek5VpLw=; b=G35UIe6Wx80/ MJ6kVvViI5ictpPck6WyiIsecFxDpZU0462iyL+5juhVIKjAwlK/ytYAd6m6xE5vNfMQkMlNE02h/ NHLPl56SgNXulrLORMwWqOGNiPg2z9uJdxcx1GmJ4E8FXi+edi5qkdsXxGEj/UY0lZCNJVxsotUMP EThlHDl42PQ5xcEeONRFtpI6plyRBwYVRnhdqxTpNF3FSVyRIE/ORjHV+A0xe8l7hKkhY9lJ3Dpbj vAHZOslZ0zd9VdEceZZYhz8mRuMOMlXvWp4YlXRWFoEjrAk0GjARuh4Ca5eNgUSfp6zN533PFu39u 4htATbImzqPgGHGgUdgM5A==; Date: Thu, 22 Feb 2024 15:22:26 +0200 Message-Id: <86y1bc1vn1.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Mon, 19 Feb 2024 10:55:49 -0800) Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) > Date: Mon, 19 Feb 2024 10:55:49 -0800 > Cc: 69232@debbugs.gnu.org > From: Jim Porter > > On 2/19/2024 4:12 AM, Eli Zaretskii wrote: > > I'm not sure this is a bug fix, and I think this behavior change does > > need a NEWS entry. > > Ok, I added one. Thanks, but I'm afraid it's somewhat confusing: > +*** History navigation in EWW now works like other browsers. > +Previously, when navigating back and forward through page history in > +EWW, new history entries could get added to the history list. Now, when > +navigating through history, EWW preserves the history list and only > +displays the relevant history entry. This doesn't really explain the nature of the change in behavior. AFAIU, the previous behavior was that going back in browsing history could add the old entries to the history instead of removing them; now going back will _never_ add entries to the history. Isn't that so? From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 22 12:20:20 2024 Received: (at 69232) by debbugs.gnu.org; 22 Feb 2024 17:20:20 +0000 Received: from localhost ([127.0.0.1]:43052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdCk6-00017Y-Aq for submit@debbugs.gnu.org; Thu, 22 Feb 2024 12:20:20 -0500 Received: from mail-pf1-f173.google.com ([209.85.210.173]:44070) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdCk3-000171-Jc for 69232@debbugs.gnu.org; Thu, 22 Feb 2024 12:20:17 -0500 Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6e4841ce028so2129117b3a.0 for <69232@debbugs.gnu.org>; Thu, 22 Feb 2024 09:19:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708622326; x=1709227126; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=zMH0K2PqPNa6qKSGxvcGpRPvpih+bmSuEWvxTtoRmkM=; b=i6VCISyfJquShShgP6JidjnkLiPI21KOXvTGNuVnhLN/BnbkKfrVacND1MInpCUJZx BkRKATZixUc0swJv+v09dArq82bnBu5Pzf0C6LEFMhQDX9xT1i+2BhsGsP8af365CEFN V6I2gWRHXAhSMZFPv0JadBt/sb3wsprCyTJdV5mmDs0QemdJTk0zAC/1BoQT+XETwydJ /MsdvUvKi/4Ld1opSPcXMEbU+wAA9Y+KFjqSbXLtUaJlRw4PLagXWU/Hq9XdDSWZwS08 m/nCl6gnuPvnAPwHfRl10RbS6pbtxbD35zoXyz6BkPUEjZ8z18aVSm2xb6zNGxk/u6xJ rpPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708622326; x=1709227126; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=zMH0K2PqPNa6qKSGxvcGpRPvpih+bmSuEWvxTtoRmkM=; b=DUwxSYjaShD/O9/NFYqQxg6TzpPB2fBccQqnlhm6qSIcJnQbMu/q/8cEPxkxQXH08b 5ulBY7G0U24DHhUy30rOcbgtIBdAi9TZdEg9q3fich8DMtQOD5Ez+aztu4JI/qRqSOMN S3uizBqMUGAIg5Pmj9xPgW3/OvdKs2vIb601FW/ij0jtQ1EwQU+Nut7UMzSngtyNa8k8 kyZfjDFGLmSLrMfRkAhQjaGAoNsmSC0VBCpCPRjVnT59xvT/Q/8Vrf3qzvlPtDnsGpXn IwWgaNuIHtxAQNfgIQjy5s+FdejbJUQbqE1xk4zYtFP2tEakeIB3b/yVk4FNSSXwlWgo jkbQ== X-Gm-Message-State: AOJu0YwYScOjtMoNooKofZ9kgztza6dc75TGrgHDXlfce99L8XjMyXMr ZQ68H68nHxuHZUeLnkCsnq5mtJr7/TcEUbH/n8hXWTyktNtjG0MM X-Google-Smtp-Source: AGHT+IGlN1y5hYbOjffZ+IuQSVzr/fw+EBRphkUFOYH/r+nxl1F2IDfdN+oZd0eT5KbbJyjPTIT2XQ== X-Received: by 2002:a05:6a00:179c:b0:6e4:69ee:bd74 with SMTP id s28-20020a056a00179c00b006e469eebd74mr12317146pfg.24.1708622326409; Thu, 22 Feb 2024 09:18:46 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id fb30-20020a056a002d9e00b006e45f735ea9sm8752042pfb.82.2024.02.22.09.18.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Feb 2024 09:18:45 -0800 (PST) Content-Type: multipart/mixed; boundary="------------rgNqgZnwIhuYNmSr5MquwzjG" Message-ID: <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> Date: Thu, 22 Feb 2024 09:18:47 -0800 MIME-Version: 1.0 Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Content-Language: en-US To: Eli Zaretskii References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> From: Jim Porter In-Reply-To: <86y1bc1vn1.fsf@gnu.org> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) This is a multi-part message in MIME format. --------------rgNqgZnwIhuYNmSr5MquwzjG Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/22/2024 5:22 AM, Eli Zaretskii wrote: >> Date: Mon, 19 Feb 2024 10:55:49 -0800 >> Cc: 69232@debbugs.gnu.org >> From: Jim Porter >> >> On 2/19/2024 4:12 AM, Eli Zaretskii wrote: >>> I'm not sure this is a bug fix, and I think this behavior change does >>> need a NEWS entry. >> >> Ok, I added one. > > Thanks, but I'm afraid it's somewhat confusing: > >> +*** History navigation in EWW now works like other browsers. >> +Previously, when navigating back and forward through page history in >> +EWW, new history entries could get added to the history list. Now, when >> +navigating through history, EWW preserves the history list and only >> +displays the relevant history entry. > > This doesn't really explain the nature of the change in behavior. > AFAIU, the previous behavior was that going back in browsing history > could add the old entries to the history instead of removing them; now > going back will _never_ add entries to the history. Isn't that so? In other browsers, you only add new entries to the back/forward history when you go to a totally new page (e.g. by clicking a link). If you just go back or forward, you should only change your position in the already-existing history. That's (roughly) what EWW does with the patch, with the exception that a new page doesn't go into the history immediately. Previously, every time you went back or forward, it added entries to the end of the history list. How does this look? --------------rgNqgZnwIhuYNmSr5MquwzjG Content-Type: text/plain; charset=UTF-8; name="0001-When-navigating-through-history-in-EWW-don-t-keep-ad.patch" Content-Disposition: attachment; filename*0="0001-When-navigating-through-history-in-EWW-don-t-keep-ad.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA1NGI1ODIwYjA5MTRhMzhiZmI0YmEzY2Q2ZWZiMzUzOGQ4NTQwYTRlIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgMTcgRmViIDIwMjQgMjA6NDk6MTUgLTA4MDAKU3ViamVjdDogW1BB VENIXSBXaGVuIG5hdmlnYXRpbmcgdGhyb3VnaCBoaXN0b3J5IGluIEVXVywgZG9uJ3Qga2Vl cCBhZGRpbmcgdG8KICdld3ctaGlzdG9yeScKClRoaXMgcmVzb2x2ZXMgYW4gaXNzdWUgd2hl cmUgbmF2aWdhdGluZyBiYWNrIGFuZCB0aGVuIGZvcndhcmQga2VwdAphZGRpbmcgbmV3IGhp c3RvcnkgZW50cmllcyBzbyB5b3UgY291bGQgbmV2ZXIgaGl0IHRoZSAiZW5kIiAoYnVnIzY5 MjMyKS4KCiogbGlzcC9uZXQvZXd3LmVsIChld3ctaGlzdG9yeS1wb3NpdGlvbik6IEFkZCBk b2NzdHJpbmcuCihld3ctbW9kZS1tYXAsIGV3dy1jb250ZXh0LW1lbnUpOiBVc2UgY29ycmVj dCBwcmVkaWNhdGVzIGZvciB3aGVuIHRvCmVuYWJsZSBiYWNrL2ZvcndhcmQuCihld3ctc2F2 ZS1oaXN0b3J5KTogU2F2ZSBoaXN0b3J5IGVudHJ5IGluIGl0cyBvcmlnaW5hbCBwbGFjZSB3 aGVuCnZpZXdpbmcgYSBoaXN0b3JpY2FsIHBhZ2UuCihld3ctYmFjay11cmwpOiBTZXQgJ2V3 dy1oaXN0b3J5LXBvc2l0aW9uJyBiYXNlZCBvbiB0aGUgcmVzdWx0IG9mCidld3ctc2F2ZS1o aXN0b3J5Jy4KKGV3dy1mb3J3YXJkLXVybCk6IFNldCAnZXd3LWhpc3RvcnktcG9zaXRpb24n IGRpcmVjdGx5LCBzaW5jZQonZXd3LXNhdmUtaGlzdG9yeScgbm8gbG9uZ2VyIGFkZHMgYSBu ZXcgZW50cnkgaW4gdGhpcyBjYXNlLgoKKiBldGMvTkVXUzogQW5ub3VuY2UgdGhpcyBjaGFu Z2UuCi0tLQogZXRjL05FV1MgICAgICAgIHwgIDcgKysrKysrKwogbGlzcC9uZXQvZXd3LmVs IHwgMzkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCiAyIGZpbGVz IGNoYW5nZWQsIDM1IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggNDQ3NzExNjI0OGUuLjM0MTQ2ZTkyMDFj IDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtOTgyLDYgKzk4Miwx MyBAQCBXaGVuIGludm9rZWQgd2l0aCB0aGUgcHJlZml4IGFyZ3VtZW50ICgnQy11JyksCiBU aGlzIGlzIHVzZWZ1bCBmb3IgY29udGludWluZyByZWFkaW5nIHRoZSBVUkwgaW4gdGhlIGN1 cnJlbnQgYnVmZmVyCiB3aGVuIHRoZSBuZXcgVVJMIGlzIGZldGNoZWQuCiAKKy0tLQorKioq IEhpc3RvcnkgbmF2aWdhdGlvbiBpbiBFV1cgbm93IHdvcmtzIGxpa2Ugb3RoZXIgYnJvd3Nl cnMuCitQcmV2aW91c2x5LCB3aGVuIG5hdmlnYXRpbmcgYmFjayBhbmQgZm9yd2FyZCB0aHJv dWdoIHBhZ2UgaGlzdG9yeSwgRVdXCit3b3VsZCBhZGQgYSBuZXcgZW50cnkgdG8gdGhlIGVu ZCBvZiB0aGUgaGlzdG9yeSBsaXN0IGVhY2ggdGltZS4gIE5vdywKK3doZW4gbmF2aWdhdGlu ZyB0aHJvdWdoIGhpc3RvcnksIEVXVyB1cGRhdGVzIGhpc3RvcnkgZWxlbWVudHMgaW4tcGxh Y2UsCitwcmVzZXJ2aW5nIHRoZSBvdmVyYWxsIGhpc3RvcnkgbGlzdC4KKwogKiogZ28tdHMt bW9kZQogCiArKysKZGlmZiAtLWdpdCBhL2xpc3AvbmV0L2V3dy5lbCBiL2xpc3AvbmV0L2V3 dy5lbAppbmRleCA2YWUxZTZkM2QwYS4uODE5NmYyMjJhZDggMTAwNjQ0Ci0tLSBhL2xpc3Av bmV0L2V3dy5lbAorKysgYi9saXNwL25ldC9ld3cuZWwKQEAgLTMxMiw3ICszMTIsMTAgQEAg ZXd3LXZhbGlkLWNlcnRpZmljYXRlCiAKIChkZWZ2YXIgZXd3LWRhdGEgbmlsKQogKGRlZnZh ciBld3ctaGlzdG9yeSBuaWwpCi0oZGVmdmFyIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDApCiso ZGVmdmFyIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDAKKyAgIlRoZSAxLWluZGV4ZWQgcG9zaXRp b24gaW4gYGV3dy1oaXN0b3J5Jy4KK0lmIHplcm8sIEVXVyBpcyBhdCB0aGUgbmV3ZXN0IHBh Z2UsIHdoaWNoIGlzbid0IHlldCBwcmVzZW50IGluCitgZXd3LWhpc3RvcnknLiIpCiAoZGVm dmFyIGV3dy1wcm9tcHQtaGlzdG9yeSBuaWwpCiAKIChkZWZ2YXIgZXd3LWxvY2FsLXJlZ2V4 ICJsb2NhbGhvc3QiCkBAIC0xMTI5LDkgKzExMzIsOSBAQCBld3ctbW9kZS1tYXAKICAgICAg ICAgICBbIlJlbG9hZCIgZXd3LXJlbG9hZCB0XQogICAgICAgICAgIFsiRm9sbG93IFVSTCBp biBuZXcgYnVmZmVyIiBld3ctb3Blbi1pbi1uZXctYnVmZmVyXQogICAgICAgICAgIFsiQmFj ayB0byBwcmV2aW91cyBwYWdlIiBld3ctYmFjay11cmwKLSAgICAgICAgICAgOmFjdGl2ZSAo bm90ICh6ZXJvcCAobGVuZ3RoIGV3dy1oaXN0b3J5KSkpXQorICAgICAgICAgICA6YWN0aXZl ICg8IGV3dy1oaXN0b3J5LXBvc2l0aW9uIChsZW5ndGggZXd3LWhpc3RvcnkpKV0KICAgICAg ICAgICBbIkZvcndhcmQgdG8gbmV4dCBwYWdlIiBld3ctZm9yd2FyZC11cmwKLSAgICAgICAg ICAgOmFjdGl2ZSAobm90ICh6ZXJvcCBld3ctaGlzdG9yeS1wb3NpdGlvbikpXQorICAgICAg ICAgICA6YWN0aXZlICg+IGV3dy1oaXN0b3J5LXBvc2l0aW9uIDEpXQogICAgICAgICAgIFsi QnJvd3NlIHdpdGggZXh0ZXJuYWwgYnJvd3NlciIgZXd3LWJyb3dzZS13aXRoLWV4dGVybmFs LWJyb3dzZXIgdF0KICAgICAgICAgICBbIkRvd25sb2FkIiBld3ctZG93bmxvYWQgdF0KICAg ICAgICAgICBbIlZpZXcgcGFnZSBzb3VyY2UiIGV3dy12aWV3LXNvdXJjZV0KQEAgLTExNTUs OSArMTE1OCw5IEBAIGV3dy1jb250ZXh0LW1lbnUKICAgICAoZWFzeS1tZW51LWRlZmluZSBu aWwgZWFzeS1tZW51IG5pbAogICAgICAgJygiRXd3IgogICAgICAgICBbIkJhY2sgdG8gcHJl dmlvdXMgcGFnZSIgZXd3LWJhY2stdXJsCi0JIDp2aXNpYmxlIChub3QgKHplcm9wIChsZW5n dGggZXd3LWhpc3RvcnkpKSldCisJIDphY3RpdmUgKDwgZXd3LWhpc3RvcnktcG9zaXRpb24g KGxlbmd0aCBld3ctaGlzdG9yeSkpXQogCVsiRm9yd2FyZCB0byBuZXh0IHBhZ2UiIGV3dy1m b3J3YXJkLXVybAotCSA6dmlzaWJsZSAobm90ICh6ZXJvcCBld3ctaGlzdG9yeS1wb3NpdGlv bikpXQorCSA6YWN0aXZlICg+IGV3dy1oaXN0b3J5LXBvc2l0aW9uIDEpXQogCVsiUmVsb2Fk IiBld3ctcmVsb2FkIHRdKSkKICAgICAoZG9saXN0IChpdGVtIChyZXZlcnNlIChsb29rdXAt a2V5IGVhc3ktbWVudSBbbWVudS1iYXIgZXd3XSkpKQogICAgICAgKHdoZW4gKGNvbnNwIGl0 ZW0pCkBAIC0xMjgwLDE2ICsxMjgzLDIwIEBAIGV3dy1iYWNrLXVybAogICAoaW50ZXJhY3Rp dmUgbmlsIGV3dy1tb2RlKQogICAod2hlbiAoPj0gZXd3LWhpc3RvcnktcG9zaXRpb24gKGxl bmd0aCBld3ctaGlzdG9yeSkpCiAgICAgKHVzZXItZXJyb3IgIk5vIHByZXZpb3VzIHBhZ2Ui KSkKLSAgKGV3dy1zYXZlLWhpc3RvcnkpCi0gIChzZXRxIGV3dy1oaXN0b3J5LXBvc2l0aW9u ICgrIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDIpKQorICAoaWYgKGV3dy1zYXZlLWhpc3Rvcnkp CisgICAgICA7OyBXZSB3ZXJlIGF0IHRoZSBsYXRlc3QgcGFnZSAod2hpY2ggd2FzIGp1c3Qg YWRkZWQgdG8gdGhlCisgICAgICA7OyBoaXN0b3J5KSwgc28gZ28gYmFjayB0d28gZW50cmll cy4KKyAgICAgIChzZXRxIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDIpCisgICAgKHNldHEgZXd3 LWhpc3RvcnktcG9zaXRpb24gKDErIGV3dy1oaXN0b3J5LXBvc2l0aW9uKSkpCiAgIChld3ct cmVzdG9yZS1oaXN0b3J5IChlbHQgZXd3LWhpc3RvcnkgKDEtIGV3dy1oaXN0b3J5LXBvc2l0 aW9uKSkpKQogCiAoZGVmdW4gZXd3LWZvcndhcmQtdXJsICgpCiAgICJHbyB0byB0aGUgbmV4 dCBkaXNwbGF5ZWQgcGFnZS4iCiAgIChpbnRlcmFjdGl2ZSBuaWwgZXd3LW1vZGUpCi0gICh3 aGVuICh6ZXJvcCBld3ctaGlzdG9yeS1wb3NpdGlvbikKKyAgKHdoZW4gKDw9IGV3dy1oaXN0 b3J5LXBvc2l0aW9uIDEpCiAgICAgKHVzZXItZXJyb3IgIk5vIG5leHQgcGFnZSIpKQogICAo ZXd3LXNhdmUtaGlzdG9yeSkKKyAgKHNldHEgZXd3LWhpc3RvcnktcG9zaXRpb24gKDEtIGV3 dy1oaXN0b3J5LXBvc2l0aW9uKSkKICAgKGV3dy1yZXN0b3JlLWhpc3RvcnkgKGVsdCBld3ct aGlzdG9yeSAoMS0gZXd3LWhpc3RvcnktcG9zaXRpb24pKSkpCiAKIChkZWZ1biBld3ctcmVz dG9yZS1oaXN0b3J5IChlbGVtKQpAQCAtMjI4OSwxMSArMjI5NiwyMSBAQCBld3ctYm9va21h cmstbW9kZQogOzs7IEhpc3RvcnkgY29kZQogCiAoZGVmdW4gZXd3LXNhdmUtaGlzdG9yeSAo KQorICAiU2F2ZSB0aGUgY3VycmVudCBwYWdlJ3MgZGF0YSB0byB0aGUgaGlzdG9yeS4KK0lm IHRoZSBjdXJyZW50IHBhZ2UgaXMgYSBoaXN0b3JpYWwgb25lIGxvYWRlZCBmcm9tCitgZXd3 LWhpc3RvcnknIChlLmcuIGJ5IGNhbGxpbmcgYGV3dy1iYWNrLXVybCcpLCB0aGlzIHdpbGwg dXBkYXRlIHRoZQorcGFnZSdzIGVudHJ5IGluIGBld3ctaGlzdG9yeScgYW5kIHJldHVybiBu aWwuICBPdGhlcndpc2UsIGFkZCBhIG5ldworZW50cnkgdG8gYGV3dy1oaXN0b3J5JyBhbmQg cmV0dXJuIHQuIgogICAocGxpc3QtcHV0IGV3dy1kYXRhIDpwb2ludCAocG9pbnQpKQogICAo cGxpc3QtcHV0IGV3dy1kYXRhIDp0ZXh0IChidWZmZXItc3RyaW5nKSkKLSAgKGxldCAoKGhp c3RvcnktZGVsZXRlLWR1cGxpY2F0ZXMgbmlsKSkKLSAgICAoYWRkLXRvLWhpc3RvcnkgJ2V3 dy1oaXN0b3J5IGV3dy1kYXRhIGV3dy1oaXN0b3J5LWxpbWl0IHQpKQotICAoc2V0cSBld3ct ZGF0YSAobGlzdCA6dGl0bGUgIiIpKSkKKyAgKHByb2cxCisgICAgICAoaWYgKHplcm9wIGV3 dy1oaXN0b3J5LXBvc2l0aW9uKQorICAgICAgICAgIChsZXQgKChoaXN0b3J5LWRlbGV0ZS1k dXBsaWNhdGVzIG5pbCkpCisgICAgICAgICAgICAoYWRkLXRvLWhpc3RvcnkgJ2V3dy1oaXN0 b3J5IGV3dy1kYXRhIGV3dy1oaXN0b3J5LWxpbWl0IHQpCisgICAgICAgICAgICB0KQorICAg ICAgICAoc2V0ZiAoZWx0IGV3dy1oaXN0b3J5ICgxLSBld3ctaGlzdG9yeS1wb3NpdGlvbikp IGV3dy1kYXRhKQorICAgICAgICBuaWwpCisgICAgKHNldHEgZXd3LWRhdGEgKGxpc3QgOnRp dGxlICIiKSkpKQogCiAoZGVmdmFyIGV3dy1jdXJyZW50LWJ1ZmZlcikKIAotLSAKMi4yNS4x Cgo= --------------rgNqgZnwIhuYNmSr5MquwzjG-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 22 14:07:20 2024 Received: (at 69232) by debbugs.gnu.org; 22 Feb 2024 19:07:20 +0000 Received: from localhost ([127.0.0.1]:50788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdEPf-0000yS-Ig for submit@debbugs.gnu.org; Thu, 22 Feb 2024 14:07:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdEPb-0000xs-QV for 69232@debbugs.gnu.org; Thu, 22 Feb 2024 14:07:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdEN3-0001TC-Im; Thu, 22 Feb 2024 14:04:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=G7WUch+HGfMEnAXJMXv3Yccy+seKfCLD2jWxz+3nNoE=; b=CuYOFB33zVtL oGk27wclC2vMpLvie1GqT8x0PAhCnloivTHkEc12ONwtLZNBT0gOvsLn2yav2xIyHi/bbBnmUs3J/ Rk427S3rMUWPJsP2Au+Fx5UDJOdUxZfgfP6AcxxPgSBKbQYAqlCS9iED2s/lo0FCvZ+2m450LS46f BkZVh5noWH+qTrX6hg8iRwk1Yh1rTU3KPAGvYYljBxNKHl+zrPYuBZIejUdF2+Jh4aXZhf+Buk2R7 CwIJ6H3Np99tChkgCcheIM61G8GNASFQlk6yXzylroeTVbn92xwPIkkLvtoh9abCfIGEjP5OoP7Hl RAEkvtuzCcK7fNR/ZMk5Ng==; Date: Thu, 22 Feb 2024 21:04:35 +0200 Message-Id: <86sf1k1fss.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> (message from Jim Porter on Thu, 22 Feb 2024 09:18:47 -0800) Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) > Date: Thu, 22 Feb 2024 09:18:47 -0800 > Cc: 69232@debbugs.gnu.org > From: Jim Porter > > On 2/22/2024 5:22 AM, Eli Zaretskii wrote: > >> Date: Mon, 19 Feb 2024 10:55:49 -0800 > >> Cc: 69232@debbugs.gnu.org > >> From: Jim Porter > >> > >> On 2/19/2024 4:12 AM, Eli Zaretskii wrote: > >>> I'm not sure this is a bug fix, and I think this behavior change does > >>> need a NEWS entry. > >> > >> Ok, I added one. > > > > Thanks, but I'm afraid it's somewhat confusing: > > > >> +*** History navigation in EWW now works like other browsers. > >> +Previously, when navigating back and forward through page history in > >> +EWW, new history entries could get added to the history list. Now, when > >> +navigating through history, EWW preserves the history list and only > >> +displays the relevant history entry. > > > > This doesn't really explain the nature of the change in behavior. > > AFAIU, the previous behavior was that going back in browsing history > > could add the old entries to the history instead of removing them; now > > going back will _never_ add entries to the history. Isn't that so? > > In other browsers, you only add new entries to the back/forward history > when you go to a totally new page (e.g. by clicking a link). If you just > go back or forward, you should only change your position in the > already-existing history. That's (roughly) what EWW does with the patch, > with the exception that a new page doesn't go into the history immediately. > > Previously, every time you went back or forward, it added entries to the > end of the history list. > > How does this look? It is IMO still not clear enough about the behavior change. It looks like you are describing what the old implementation did and the new one will do, instead of describing the behavior as it the user will see it. Can you instead describe the change in terms of user-facing behavior? From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 22 15:14:36 2024 Received: (at 69232) by debbugs.gnu.org; 22 Feb 2024 20:14:36 +0000 Received: from localhost ([127.0.0.1]:55489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdFSm-0004VP-Gv for submit@debbugs.gnu.org; Thu, 22 Feb 2024 15:14:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdFSk-0004V3-BE for 69232@debbugs.gnu.org; Thu, 22 Feb 2024 15:14:35 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdFSH-0005Nh-O3; Thu, 22 Feb 2024 15:14:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=cd1tusGQT+I8RZu1KxgTsjPfC4bmy9D9gjzyZL6klqY=; b=UYF6Ob0k266K l63N80Kd1vQgbyCdq5avz4bQGJkCTibQ2+P/1oRMBYGloraZn/gLAAckedgxxohUh0/ZreLBRjnbg Iagkhj4wHeYZn83cQH1snusMW2KjDWdhNEVACs2QmLujRoALxeBljk2qI528zzkx+/lZLpGBkoWFo 730ECN86bbyes8QoeU0KjkLnsNiUcYjn2bZ76iqwsdusne2Mac2VBNQ0gAzIcbPOP+5OjDab/F9W3 2Ruw7GpMupCrO10bTcI1DF2/5PMpYiPzQx2cTh0kcmdHQbaf/jgQWWhv/Bon7t98x7r7XZNCsHMv0 Knrtg8yQ6XdjcaxUaA0enQ==; Date: Thu, 22 Feb 2024 22:13:59 +0200 Message-Id: <86msrs1cl4.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> (message from Jim Porter on Thu, 22 Feb 2024 12:10:36 -0800) Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) > Date: Thu, 22 Feb 2024 12:10:36 -0800 > Cc: 69232@debbugs.gnu.org > From: Jim Porter > > On 2/22/2024 11:04 AM, Eli Zaretskii wrote: > > It is IMO still not clear enough about the behavior change. It looks > > like you are describing what the old implementation did and the new > > one will do, instead of describing the behavior as it the user will > > see it. Can you instead describe the change in terms of user-facing > > behavior? > > What about this? It mentions the (IMO) buggy behavior and how the new > implementation prevents that. Much better, thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 22 15:18:29 2024 Received: (at 69232) by debbugs.gnu.org; 22 Feb 2024 20:18:29 +0000 Received: from localhost ([127.0.0.1]:55832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdFWW-0004iZ-5s for submit@debbugs.gnu.org; Thu, 22 Feb 2024 15:18:29 -0500 Received: from mail-qt1-f170.google.com ([209.85.160.170]:54783) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdFWU-0004i0-2A for 69232@debbugs.gnu.org; Thu, 22 Feb 2024 15:18:26 -0500 Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-42dc86cc35dso15321cf.1 for <69232@debbugs.gnu.org>; Thu, 22 Feb 2024 12:18:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708633017; x=1709237817; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=OalSN+bJbF+G0iJtnPQgv4NqVpOV40WQQ4EDOT7Q7T0=; b=Riuyt4Hdthe1hybulcJpNyea5tWZ7Al8Ca7q1posjKU6PjcLM/bhACFbDkfXxsQgtG 00UCo2RQrmfuESPBypUmBT34aa603AMsN2jLvSvy0omXqpYqXbCH/cnEizJMoSYUJ74n qaR3KqGvuUXU3kP6dlKhs2BQ9pYojd1hiOLeVT1l0zWLVKDWEWStXMcRKSpkPKjMZ/YM I88HKxydPiiANnLG/SsmWyGBkyTwS08k2ZaI/1cjw/Kcdlry9anKocdl/aMxdhsW2p0h 4dbGJcDYogpTDwo2wO/ifhngtIFfvVQdjk1uBmaujsmHjsX2fhdcHnW41oGYN4sF5nT5 yqXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708633017; x=1709237817; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=OalSN+bJbF+G0iJtnPQgv4NqVpOV40WQQ4EDOT7Q7T0=; b=s3Gt7F4NmitxJQ52tB0naacD4eoIpOqMM3Xj/BFDBlp7TMa+bPBoCbUffr/6BtIInM TXGNPFlqTwcIB1Mxta7UdFpHOv/V985TRQlU0u/1jHv3ZziwaOM1x0YM24msGI0GPta0 RFOnZ57lbMU+2mArJSZXU35iTBvR6VXcVpRwBPvl7Q722fdpXpp4GQCSQ1bOMM6+288W F9QVWmGh/huhFJtysSCth+VlmqgIlWY17k8CmWuRS8At3kSNiIeW3sbo6aTafwlibgrZ PfY+myY/c05w3spCKzMxmyBKG4UFnjl0j90z6UASpm/AS8qdL3odPjCXRLZaVBDMmAVj nwrw== X-Gm-Message-State: AOJu0YzUB/5ZM+GX+z2dk6iAYKSVTle2ao1tvnXcO0IzJx6X6PdB4FR6 TetcXEmLElNKofgXvPLEykZ/jUT4xRyfb5oUya/KjfEEvT2aZZfoqebriXru X-Google-Smtp-Source: AGHT+IHWZCeXcN1SHRfpCasZlFlFLYpEsfnUpy1ZQ13BVdAPkvuQPF5kYgmfZQJ2DYgdO/KFUFVnZg== X-Received: by 2002:a17:90b:1017:b0:299:3236:734 with SMTP id gm23-20020a17090b101700b0029932360734mr18765885pjb.42.1708632640892; Thu, 22 Feb 2024 12:10:40 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id nb6-20020a17090b35c600b00296f2c1d2c9sm4468763pjb.18.2024.02.22.12.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Feb 2024 12:10:39 -0800 (PST) Content-Type: multipart/mixed; boundary="------------GTqhmgBL560AXibOE0PRefra" Message-ID: <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> Date: Thu, 22 Feb 2024 12:10:36 -0800 MIME-Version: 1.0 Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Content-Language: en-US To: Eli Zaretskii References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> From: Jim Porter In-Reply-To: <86sf1k1fss.fsf@gnu.org> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) This is a multi-part message in MIME format. --------------GTqhmgBL560AXibOE0PRefra Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/22/2024 11:04 AM, Eli Zaretskii wrote: > It is IMO still not clear enough about the behavior change. It looks > like you are describing what the old implementation did and the new > one will do, instead of describing the behavior as it the user will > see it. Can you instead describe the change in terms of user-facing > behavior? What about this? It mentions the (IMO) buggy behavior and how the new implementation prevents that. --------------GTqhmgBL560AXibOE0PRefra Content-Type: text/plain; charset=UTF-8; name="0001-When-navigating-through-history-in-EWW-don-t-keep-ad.patch" Content-Disposition: attachment; filename*0="0001-When-navigating-through-history-in-EWW-don-t-keep-ad.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAwZjI1Mjg0ODI1MjcyNjJmZjU5MTUzNTk1ZDdhM2YxMDUxNzE1M2NhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgMTcgRmViIDIwMjQgMjA6NDk6MTUgLTA4MDAKU3ViamVjdDogW1BB VENIXSBXaGVuIG5hdmlnYXRpbmcgdGhyb3VnaCBoaXN0b3J5IGluIEVXVywgZG9uJ3Qga2Vl cCBhZGRpbmcgdG8KICdld3ctaGlzdG9yeScKClRoaXMgcmVzb2x2ZXMgYW4gaXNzdWUgd2hl cmUgbmF2aWdhdGluZyBiYWNrIGFuZCB0aGVuIGZvcndhcmQga2VwdAphZGRpbmcgbmV3IGhp c3RvcnkgZW50cmllcyBzbyB5b3UgY291bGQgbmV2ZXIgaGl0IHRoZSAiZW5kIiAoYnVnIzY5 MjMyKS4KCiogbGlzcC9uZXQvZXd3LmVsIChld3ctaGlzdG9yeS1wb3NpdGlvbik6IEFkZCBk b2NzdHJpbmcuCihld3ctbW9kZS1tYXAsIGV3dy1jb250ZXh0LW1lbnUpOiBVc2UgY29ycmVj dCBwcmVkaWNhdGVzIGZvciB3aGVuIHRvCmVuYWJsZSBiYWNrL2ZvcndhcmQuCihld3ctc2F2 ZS1oaXN0b3J5KTogU2F2ZSBoaXN0b3J5IGVudHJ5IGluIGl0cyBvcmlnaW5hbCBwbGFjZSB3 aGVuCnZpZXdpbmcgYSBoaXN0b3JpY2FsIHBhZ2UuCihld3ctYmFjay11cmwpOiBTZXQgJ2V3 dy1oaXN0b3J5LXBvc2l0aW9uJyBiYXNlZCBvbiB0aGUgcmVzdWx0IG9mCidld3ctc2F2ZS1o aXN0b3J5Jy4KKGV3dy1mb3J3YXJkLXVybCk6IFNldCAnZXd3LWhpc3RvcnktcG9zaXRpb24n IGRpcmVjdGx5LCBzaW5jZQonZXd3LXNhdmUtaGlzdG9yeScgbm8gbG9uZ2VyIGFkZHMgYSBu ZXcgZW50cnkgaW4gdGhpcyBjYXNlLgoKKiBldGMvTkVXUzogQW5ub3VuY2UgdGhpcyBjaGFu Z2UuCi0tLQogZXRjL05FV1MgICAgICAgIHwgIDggKysrKysrKysKIGxpc3AvbmV0L2V3dy5l bCB8IDM5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLQogMiBmaWxl cyBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IDQ0NzcxMTYyNDhlLi45NDdmYjhjZjBm YyAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTk4Miw2ICs5ODIs MTQgQEAgV2hlbiBpbnZva2VkIHdpdGggdGhlIHByZWZpeCBhcmd1bWVudCAoJ0MtdScpLAog VGhpcyBpcyB1c2VmdWwgZm9yIGNvbnRpbnVpbmcgcmVhZGluZyB0aGUgVVJMIGluIHRoZSBj dXJyZW50IGJ1ZmZlcgogd2hlbiB0aGUgbmV3IFVSTCBpcyBmZXRjaGVkLgogCistLS0KKyoq KiBIaXN0b3J5IG5hdmlnYXRpb24gaW4gRVdXIG5vdyB3b3JrcyBsaWtlIG90aGVyIGJyb3dz ZXJzLgorUHJldmlvdXNseSwgd2hlbiBuYXZpZ2F0aW5nIGJhY2sgYW5kIGZvcndhcmQgdGhy b3VnaCBwYWdlIGhpc3RvcnksIEVXVword291bGQgYWRkIGEgZHVwbGljYXRlIGVudHJ5IHRv IHRoZSBlbmQgb2YgdGhlIGhpc3RvcnkgbGlzdCBlYWNoIHRpbWUuCitUaGlzIG1hZGUgaXQg aW1wb3NzaWJsZSB0byBuYXZpZ2F0ZSB0byB0aGUgImVuZCIgb2YgdGhlIGhpc3RvcnkgbGlz dC4KK05vdywgbmF2aWdhdGluZyB0aHJvdWdoIGhpc3RvcnkgaW4gRVdXIHNpbXBseSBjaGFu Z2VzIHlvdXIgcG9zaXRpb24gaW4KK3RoZSBoaXN0b3J5IGxpc3QsIGFsbG93aW5nIHlvdSB0 byByZWFjaCB0aGUgZW5kIGFzIGV4cGVjdGVkLgorCiAqKiBnby10cy1tb2RlCiAKICsrKwpk aWZmIC0tZ2l0IGEvbGlzcC9uZXQvZXd3LmVsIGIvbGlzcC9uZXQvZXd3LmVsCmluZGV4IDZh ZTFlNmQzZDBhLi44MTk2ZjIyMmFkOCAxMDA2NDQKLS0tIGEvbGlzcC9uZXQvZXd3LmVsCisr KyBiL2xpc3AvbmV0L2V3dy5lbApAQCAtMzEyLDcgKzMxMiwxMCBAQCBld3ctdmFsaWQtY2Vy dGlmaWNhdGUKIAogKGRlZnZhciBld3ctZGF0YSBuaWwpCiAoZGVmdmFyIGV3dy1oaXN0b3J5 IG5pbCkKLShkZWZ2YXIgZXd3LWhpc3RvcnktcG9zaXRpb24gMCkKKyhkZWZ2YXIgZXd3LWhp c3RvcnktcG9zaXRpb24gMAorICAiVGhlIDEtaW5kZXhlZCBwb3NpdGlvbiBpbiBgZXd3LWhp c3RvcnknLgorSWYgemVybywgRVdXIGlzIGF0IHRoZSBuZXdlc3QgcGFnZSwgd2hpY2ggaXNu J3QgeWV0IHByZXNlbnQgaW4KK2Bld3ctaGlzdG9yeScuIikKIChkZWZ2YXIgZXd3LXByb21w dC1oaXN0b3J5IG5pbCkKIAogKGRlZnZhciBld3ctbG9jYWwtcmVnZXggImxvY2FsaG9zdCIK QEAgLTExMjksOSArMTEzMiw5IEBAIGV3dy1tb2RlLW1hcAogICAgICAgICAgIFsiUmVsb2Fk IiBld3ctcmVsb2FkIHRdCiAgICAgICAgICAgWyJGb2xsb3cgVVJMIGluIG5ldyBidWZmZXIi IGV3dy1vcGVuLWluLW5ldy1idWZmZXJdCiAgICAgICAgICAgWyJCYWNrIHRvIHByZXZpb3Vz IHBhZ2UiIGV3dy1iYWNrLXVybAotICAgICAgICAgICA6YWN0aXZlIChub3QgKHplcm9wIChs ZW5ndGggZXd3LWhpc3RvcnkpKSldCisgICAgICAgICAgIDphY3RpdmUgKDwgZXd3LWhpc3Rv cnktcG9zaXRpb24gKGxlbmd0aCBld3ctaGlzdG9yeSkpXQogICAgICAgICAgIFsiRm9yd2Fy ZCB0byBuZXh0IHBhZ2UiIGV3dy1mb3J3YXJkLXVybAotICAgICAgICAgICA6YWN0aXZlIChu b3QgKHplcm9wIGV3dy1oaXN0b3J5LXBvc2l0aW9uKSldCisgICAgICAgICAgIDphY3RpdmUg KD4gZXd3LWhpc3RvcnktcG9zaXRpb24gMSldCiAgICAgICAgICAgWyJCcm93c2Ugd2l0aCBl eHRlcm5hbCBicm93c2VyIiBld3ctYnJvd3NlLXdpdGgtZXh0ZXJuYWwtYnJvd3NlciB0XQog ICAgICAgICAgIFsiRG93bmxvYWQiIGV3dy1kb3dubG9hZCB0XQogICAgICAgICAgIFsiVmll dyBwYWdlIHNvdXJjZSIgZXd3LXZpZXctc291cmNlXQpAQCAtMTE1NSw5ICsxMTU4LDkgQEAg ZXd3LWNvbnRleHQtbWVudQogICAgIChlYXN5LW1lbnUtZGVmaW5lIG5pbCBlYXN5LW1lbnUg bmlsCiAgICAgICAnKCJFd3ciCiAgICAgICAgIFsiQmFjayB0byBwcmV2aW91cyBwYWdlIiBl d3ctYmFjay11cmwKLQkgOnZpc2libGUgKG5vdCAoemVyb3AgKGxlbmd0aCBld3ctaGlzdG9y eSkpKV0KKwkgOmFjdGl2ZSAoPCBld3ctaGlzdG9yeS1wb3NpdGlvbiAobGVuZ3RoIGV3dy1o aXN0b3J5KSldCiAJWyJGb3J3YXJkIHRvIG5leHQgcGFnZSIgZXd3LWZvcndhcmQtdXJsCi0J IDp2aXNpYmxlIChub3QgKHplcm9wIGV3dy1oaXN0b3J5LXBvc2l0aW9uKSldCisJIDphY3Rp dmUgKD4gZXd3LWhpc3RvcnktcG9zaXRpb24gMSldCiAJWyJSZWxvYWQiIGV3dy1yZWxvYWQg dF0pKQogICAgIChkb2xpc3QgKGl0ZW0gKHJldmVyc2UgKGxvb2t1cC1rZXkgZWFzeS1tZW51 IFttZW51LWJhciBld3ddKSkpCiAgICAgICAod2hlbiAoY29uc3AgaXRlbSkKQEAgLTEyODAs MTYgKzEyODMsMjAgQEAgZXd3LWJhY2stdXJsCiAgIChpbnRlcmFjdGl2ZSBuaWwgZXd3LW1v ZGUpCiAgICh3aGVuICg+PSBld3ctaGlzdG9yeS1wb3NpdGlvbiAobGVuZ3RoIGV3dy1oaXN0 b3J5KSkKICAgICAodXNlci1lcnJvciAiTm8gcHJldmlvdXMgcGFnZSIpKQotICAoZXd3LXNh dmUtaGlzdG9yeSkKLSAgKHNldHEgZXd3LWhpc3RvcnktcG9zaXRpb24gKCsgZXd3LWhpc3Rv cnktcG9zaXRpb24gMikpCisgIChpZiAoZXd3LXNhdmUtaGlzdG9yeSkKKyAgICAgIDs7IFdl IHdlcmUgYXQgdGhlIGxhdGVzdCBwYWdlICh3aGljaCB3YXMganVzdCBhZGRlZCB0byB0aGUK KyAgICAgIDs7IGhpc3RvcnkpLCBzbyBnbyBiYWNrIHR3byBlbnRyaWVzLgorICAgICAgKHNl dHEgZXd3LWhpc3RvcnktcG9zaXRpb24gMikKKyAgICAoc2V0cSBld3ctaGlzdG9yeS1wb3Np dGlvbiAoMSsgZXd3LWhpc3RvcnktcG9zaXRpb24pKSkKICAgKGV3dy1yZXN0b3JlLWhpc3Rv cnkgKGVsdCBld3ctaGlzdG9yeSAoMS0gZXd3LWhpc3RvcnktcG9zaXRpb24pKSkpCiAKIChk ZWZ1biBld3ctZm9yd2FyZC11cmwgKCkKICAgIkdvIHRvIHRoZSBuZXh0IGRpc3BsYXllZCBw YWdlLiIKICAgKGludGVyYWN0aXZlIG5pbCBld3ctbW9kZSkKLSAgKHdoZW4gKHplcm9wIGV3 dy1oaXN0b3J5LXBvc2l0aW9uKQorICAod2hlbiAoPD0gZXd3LWhpc3RvcnktcG9zaXRpb24g MSkKICAgICAodXNlci1lcnJvciAiTm8gbmV4dCBwYWdlIikpCiAgIChld3ctc2F2ZS1oaXN0 b3J5KQorICAoc2V0cSBld3ctaGlzdG9yeS1wb3NpdGlvbiAoMS0gZXd3LWhpc3RvcnktcG9z aXRpb24pKQogICAoZXd3LXJlc3RvcmUtaGlzdG9yeSAoZWx0IGV3dy1oaXN0b3J5ICgxLSBl d3ctaGlzdG9yeS1wb3NpdGlvbikpKSkKIAogKGRlZnVuIGV3dy1yZXN0b3JlLWhpc3Rvcnkg KGVsZW0pCkBAIC0yMjg5LDExICsyMjk2LDIxIEBAIGV3dy1ib29rbWFyay1tb2RlCiA7Ozsg SGlzdG9yeSBjb2RlCiAKIChkZWZ1biBld3ctc2F2ZS1oaXN0b3J5ICgpCisgICJTYXZlIHRo ZSBjdXJyZW50IHBhZ2UncyBkYXRhIHRvIHRoZSBoaXN0b3J5LgorSWYgdGhlIGN1cnJlbnQg cGFnZSBpcyBhIGhpc3RvcmlhbCBvbmUgbG9hZGVkIGZyb20KK2Bld3ctaGlzdG9yeScgKGUu Zy4gYnkgY2FsbGluZyBgZXd3LWJhY2stdXJsJyksIHRoaXMgd2lsbCB1cGRhdGUgdGhlCitw YWdlJ3MgZW50cnkgaW4gYGV3dy1oaXN0b3J5JyBhbmQgcmV0dXJuIG5pbC4gIE90aGVyd2lz ZSwgYWRkIGEgbmV3CitlbnRyeSB0byBgZXd3LWhpc3RvcnknIGFuZCByZXR1cm4gdC4iCiAg IChwbGlzdC1wdXQgZXd3LWRhdGEgOnBvaW50IChwb2ludCkpCiAgIChwbGlzdC1wdXQgZXd3 LWRhdGEgOnRleHQgKGJ1ZmZlci1zdHJpbmcpKQotICAobGV0ICgoaGlzdG9yeS1kZWxldGUt ZHVwbGljYXRlcyBuaWwpKQotICAgIChhZGQtdG8taGlzdG9yeSAnZXd3LWhpc3RvcnkgZXd3 LWRhdGEgZXd3LWhpc3RvcnktbGltaXQgdCkpCi0gIChzZXRxIGV3dy1kYXRhIChsaXN0IDp0 aXRsZSAiIikpKQorICAocHJvZzEKKyAgICAgIChpZiAoemVyb3AgZXd3LWhpc3RvcnktcG9z aXRpb24pCisgICAgICAgICAgKGxldCAoKGhpc3RvcnktZGVsZXRlLWR1cGxpY2F0ZXMgbmls KSkKKyAgICAgICAgICAgIChhZGQtdG8taGlzdG9yeSAnZXd3LWhpc3RvcnkgZXd3LWRhdGEg ZXd3LWhpc3RvcnktbGltaXQgdCkKKyAgICAgICAgICAgIHQpCisgICAgICAgIChzZXRmIChl bHQgZXd3LWhpc3RvcnkgKDEtIGV3dy1oaXN0b3J5LXBvc2l0aW9uKSkgZXd3LWRhdGEpCisg ICAgICAgIG5pbCkKKyAgICAoc2V0cSBld3ctZGF0YSAobGlzdCA6dGl0bGUgIiIpKSkpCiAK IChkZWZ2YXIgZXd3LWN1cnJlbnQtYnVmZmVyKQogCi0tIAoyLjI1LjEKCg== --------------GTqhmgBL560AXibOE0PRefra-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 24 09:16:26 2024 Received: (at 69232) by debbugs.gnu.org; 24 Feb 2024 14:16:26 +0000 Received: from localhost ([127.0.0.1]:59012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdspG-0000ut-1H for submit@debbugs.gnu.org; Sat, 24 Feb 2024 09:16:26 -0500 Received: from mout.gmx.net ([212.227.15.18]:60805) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdspD-0000uW-FX for 69232@debbugs.gnu.org; Sat, 24 Feb 2024 09:16:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1708784152; x=1709388952; i=jimjoe@gmx.net; bh=e9Auda+VGgSo2QhmvGednYcB79J6ls5yZWp6szC2aKc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=Q09JTcpLvS//P1ZmecjaofT3zOikyJPJzIgruzwWE4J20XJhItzcbvaSqDNBeIl0 SZ2pCpRWJQUTx7V0ovIi9pbv2Olp/z0N0MZHEpgpntrsSH06c1Mm1Ne9fJarvKH/B B08m2tAuePR9cRaaBzlZwS68/HZEuILdmaCe6/hXje7rSR4WiCtu1KJq7l6Msjuqc 3Xcf80R4t4E+Jm+sRXrC2EiG0+xGxvMVREVYmPGdvBvFY7+egeWRas8LVDFkpXhx8 tjsDY5UCKGhmlogQ8Ce2V8TFRZ50q8b0muUuM3s3TUT5i+KphUjhKeEL2eQOeRzOM zSP/1NhBPAodFHmsmg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-15-5518 ([117.194.144.213]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MJVHe-1rK0WF3kJE-00JtOW; Sat, 24 Feb 2024 15:15:52 +0100 From: James Thomas To: Jim Porter Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop In-Reply-To: <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> (Jim Porter's message of "Thu, 22 Feb 2024 12:10:36 -0800") References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> Date: Sat, 24 Feb 2024 19:45:49 +0530 Message-ID: <87r0h2x816.fsf@outlook.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:HD40EDUfD5ybZ78m5FyF9kUa5Uw4r/8fuXJPplsMAd6p/iraCQh NhSuVuhANzziSSdCVyXriMvVoxobxHQTzNZXW+mF0KwPWjezJjjLEgO2J5RxOoR3HkK7DR2 jpYzZJL17WwlOpqEm/kUkYOi2ROW1UF5q9Yfizv8stULEKQhxfXVA1XaOJpqH9xFHMT4OGo HztmhKB/64c9qoRhzGGBQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:4yubWSGX44I=;ERvXNG5KQ7zNbuwXATEn+Et6eOL noTsUgCm9DmOjP2+Y5ynXjt2CB8i4GUEIgc2gjgf5KlyTEqHPJwEpb5BfoaEC69dkyJxzdcLU Tycl3uz4LxScQJYvypijFCZnniCdWezozf0NZTnlY4Tje7OqMZ0ICROOq6y/uMs3w7RAJSn8L YYqjkcpxZjIZPdLf+V50nAcmQ9IsbOwZzlhiA0NxeZdwT7rnQPzBuoaVjL5LHPrwWb5JDVPY/ MzGG0WfIBcTQTlJjN7welj3WMnMSjmQ4+OG/rzJBoGZ7A1HNKN2UFPN7T7AiYPBDqmVjdkpbn 6BZ0ZdSu8Le3Kfvg/CMzvWVMipz1LXfO8XojVLPceKXrRxqwc95fMfyCHyBkcr/AKUlzIRAw+ bAwIGJwknMKFPl02P9KhxsXZecav6IwJTqq9APW5JcvyczgWycCb1kYEwWbkWiy2wg+8bekqJ WuV4+vXmOgsNrHuBiR/nWyXSfmDa76q+tDaGTwbjWNomIiSocYXeapWPm6xFZZV0dQD/hEZAR +HK/ttXvl6rHE4wf+SFelu3ON9NBwrjat4aH2eK20NUWBqg4FFtL9cg/y1mn36E0IpMOyUYYL m2I/l8hb2LX2CbaJSU9GUZ/QL+eZh0F0EHEOJIRc91s1sHrYjsYgKzfI4eVlYyh5NPNaR2I+7 fqdqDN4f20CUD22HRFVmKoZXDjY/JcrmMEAOTlHuPIMf2HAtZOZY0KcQeL2LepaVJsy+kxgPd vPg+10879X2uYUDNxUXpIRRmJHMbNcZ5SdgcIzfj+Kc+CNMf86ThvYHiNsWi3bt3anHITRs99 IH+rusTHeh5PkBI4uI2P8A4K1/yXgq0mxvftWa8cym/6g= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Jim Porter wrote: > From 0f2528482527262ff59153595d7a3f10517153ca Mon Sep 17 00:00:00 2001 > From: Jim Porter > Date: Sat, 17 Feb 2024 20:49:15 -0800 > Subject: [PATCH] When navigating through history in EWW, don't keep adding to > 'eww-history' > > This resolves an issue where navigating back and then forward kept > adding new history entries so you could never hit the "end" (bug#69232). > > * lisp/net/eww.el (eww-history-position): Add docstring. > (eww-mode-map, eww-context-menu): Use correct predicates for when to > enable back/forward. > (eww-save-history): Save history entry in its original place when > viewing a historical page. > (eww-back-url): Set 'eww-history-position' based on the result of > 'eww-save-history'. > (eww-forward-url): Set 'eww-history-position' directly, since > 'eww-save-history' no longer adds a new entry in this case. > > * etc/NEWS: Announce this change. > --- > etc/NEWS | 8 ++++++++ > lisp/net/eww.el | 39 ++++++++++++++++++++++++++++----------- > 2 files changed, 36 insertions(+), 11 deletions(-) One possible problem with this patch, I realize now, is that if you navigate backward ('l') and then visit another link there, the new page is added to the very end of history rather than the immediate next position. This would be confusing if you, then, navigate back and find that it's not the page from which you followed the link. Perhaps the original code was a hack around this? -- James From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 24 09:44:17 2024 Received: (at 69232) by debbugs.gnu.org; 24 Feb 2024 14:44:17 +0000 Received: from localhost ([127.0.0.1]:60755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdtGC-000294-LY for submit@debbugs.gnu.org; Sat, 24 Feb 2024 09:44:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdtGA-00028f-PM for 69232@debbugs.gnu.org; Sat, 24 Feb 2024 09:44:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdstn-0006qP-93; Sat, 24 Feb 2024 09:21:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dTnE49DQCFuyFybSclOc3ZIpnl2vR/t8KQo06vNhFno=; b=rrinVLHCxvG3 wrBeKC1NmF3lEEozyLX2mGiiHq9YEO2z6NItGXxofrkrnyi6RVZiHUx2XT4srMJIcgXqlsjwp0Wh8 clhHtmM6roQgo+B9g4i3A/pzdNmT//qJIzDrws2eam3M/dNQQweFq8HCLOSwXLjXk82lqUqLC56+a t0o3bWQWteAfsqT7SusRC4lVRH7ViN8mMPx1fzsbGXRt5GLk0Kbc5YkAWs/LlzgFgB43O17MFNyz0 la+33Zy24/fot8ja1EfvoeaMof6+dhsoaFdb30zTJpekF4fDYjjcGiuU6yprsU3utqj6tzBDYznqT AKkyT8XmemVphHLow1MFFg==; Date: Sat, 24 Feb 2024 16:20:55 +0200 Message-Id: <8634tiymd4.fsf@gnu.org> From: Eli Zaretskii To: James Thomas In-Reply-To: <87r0h2x816.fsf@outlook.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69232 Cc: jporterbugs@gmail.com, 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 69232@debbugs.gnu.org > Date: Sat, 24 Feb 2024 19:45:49 +0530 > From: James Thomas via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > One possible problem with this patch, I realize now, is that if you > navigate backward ('l') and then visit another link there, the new page > is added to the very end of history rather than the immediate next > position. This would be confusing if you, then, navigate back and find > that it's not the page from which you followed the link. Perhaps the > original code was a hack around this? The only reasonable alternative is to throw away all the history after 'l', which I don't think is better. What do other browsers do in this situation? From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 24 17:37:01 2024 Received: (at 69232) by debbugs.gnu.org; 24 Feb 2024 22:37:01 +0000 Received: from localhost ([127.0.0.1]:37241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re0dg-0000Ii-Rf for submit@debbugs.gnu.org; Sat, 24 Feb 2024 17:37:01 -0500 Received: from mail-pl1-f170.google.com ([209.85.214.170]:49160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re0de-0000IF-MN for 69232@debbugs.gnu.org; Sat, 24 Feb 2024 17:36:59 -0500 Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1dc9222b337so1489085ad.2 for <69232@debbugs.gnu.org>; Sat, 24 Feb 2024 14:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708814128; x=1709418928; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=+IihduRrOFFN5GF1EOnlDRgF0Cb7efTODvnoXAtVB5Q=; b=Mfog3VKyb5issiDyKOLdAILTp2qGGpgDEwvFuS0aY2+xKLCftLjo5Zwd5G9XczjOGH LJWFtXaOcsWLwDJqBmdYx55vf87c1qbAmDewHGCR+S30PjTsvLZ6P3QAWw1Z7y5/fEcw HhydCp2WXhTtcrCSzz5kGy7Oa2RPvBYKM05igoMfeli0lCtepNy/UqiRE7pfc5kjZOLE DsinDPPA5OCFP7q0yXQ4oKuGY+wywJGwMRDgu+vKW1waqN78gTN5dh43bEzPNcm2UGZx nDjzE+q4wBvgRc5kFjeZrmlhzNS5l1NZ68wl+xdzUQIeLDrWUKUnso8eD0gmpxJxkhfo wjJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708814128; x=1709418928; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+IihduRrOFFN5GF1EOnlDRgF0Cb7efTODvnoXAtVB5Q=; b=RmQflFzl8H16YC9jbtr/0NACfJrjYc7y3IkkezguHyFTFao5JR2/7G3e1SGrCidYfj Hu9hb9YArw4s0+rtle6aEKlm+sLE4nVi81WhloBy1erYCG1sDcdzVHMQiU88QhDEU1Vz L2eRScSOeTbYUwa8WWChpsdClFv020rr2gK0yuQcrRpx1XMO/dX4yjNixW8n6PzV3/Ea jctOYRAXtq+6A34OQNCz2dxnGT98ph4pWEMAuQyrNxmQYu4OLrT8TabUef1low6rKBwS KlyFX74eNTkpFYMLQI85lFmXF4Xcc41ww4W/jJZm6Bnlxx0by5i8MF4DoORMaKtCnN8n Z7fw== X-Gm-Message-State: AOJu0Yw9Ec5p/21dv8Wgm4m3P9oXDx+Kk1vPxrCwWSLLQhIWsc7r4t5F s7qyBROAC4o5prSpjyAGOz8WuFh5KyG4EW5dRwN679J57BPy1MdRbTFrQ6Go X-Google-Smtp-Source: AGHT+IF7APeMPe9mbhoE/PrM/7bwGB52svIVkvEGM74a/dlDu6EwRI5gjvi5BZ/LFOP82RbS+7bwgw== X-Received: by 2002:a05:6a20:b721:b0:1a0:cc37:f850 with SMTP id fg33-20020a056a20b72100b001a0cc37f850mr3267159pzb.36.1708813763588; Sat, 24 Feb 2024 14:29:23 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id i4-20020a632204000000b005dc26144d96sm1516936pgi.75.2024.02.24.14.29.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Feb 2024 14:29:22 -0800 (PST) Message-ID: Date: Sat, 24 Feb 2024 14:29:21 -0800 MIME-Version: 1.0 Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop To: Eli Zaretskii , James Thomas References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> Content-Language: en-US From: Jim Porter In-Reply-To: <8634tiymd4.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/24/2024 6:20 AM, Eli Zaretskii wrote: >> Cc: 69232@debbugs.gnu.org >> Date: Sat, 24 Feb 2024 19:45:49 +0530 >> From: James Thomas via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> One possible problem with this patch, I realize now, is that if you >> navigate backward ('l') and then visit another link there, the new page >> is added to the very end of history rather than the immediate next >> position. This would be confusing if you, then, navigate back and find >> that it's not the page from which you followed the link. Perhaps the >> original code was a hack around this? I intentionally chose not to address this in my patch (though perhaps that's not the right call). > The only reasonable alternative is to throw away all the history after > 'l', which I don't think is better. > > What do other browsers do in this situation? They throw away any history after the page you clicked the link on (which I think is what you mean by the above). Another option might be, "If you're at a historical page and you click a link, add that page as a duplicate to the end of the history." That would partially restore the old behavior, but only in this case where things might otherwise be confusing. We could also add a user option to select between these behaviors, since the former is the de facto standard for browsers. (I think the real fix would be something like a history *tree*, but that's probably quite a bit more work.) From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 24 17:39:59 2024 Received: (at 69232) by debbugs.gnu.org; 24 Feb 2024 22:39:59 +0000 Received: from localhost ([127.0.0.1]:37493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re0gZ-0000SI-E9 for submit@debbugs.gnu.org; Sat, 24 Feb 2024 17:39:59 -0500 Received: from mout.gmx.net ([212.227.17.22]:39459) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re0gX-0000Ro-J8 for 69232@debbugs.gnu.org; Sat, 24 Feb 2024 17:39:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1708814366; x=1709419166; i=jimjoe@gmx.net; bh=OOYaTV8gFz1/prfA6uB1T8yhiCbkgSZXvZBEdN15cek=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=C0BF3IKIXppdCuBlfT58dFzJ/JtwJYs/GdS565QMU6x6vEz89yMDpuyE09kUi+i7 Oy1uB1PZVWqsiGDvyMsSIrIU4diP+te5lTb8KYxfrbnC0ViSjGyZR9URYoD3I21vl bWvl15+RpR/w5ZVw91o1597o2i+qx4GidtHZlB0tr3DvvuPG/jwe/w9C/vFSozUA0 sCkJWsh8xlROSanmQIIOVO/FcdCflXf/DNO0mVfzIBkAkOn2XQ1KIF/XjxnFoLOcs fnbc+6gFYQktRkM+qwXFuZB29nGnrpb5r8n84DMq2J6xOt3Ubro+3Iihf2JdlKEQD BKfeRsipLeVTOdsiyg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-15-5518 ([117.194.144.213]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MMobU-1rNR7M05g4-00IitX; Sat, 24 Feb 2024 23:34:16 +0100 From: James Thomas To: Eli Zaretskii Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop In-Reply-To: <8634tiymd4.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Feb 2024 16:20:55 +0200") References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> Date: Sun, 25 Feb 2024 04:04:13 +0530 Message-ID: <87cyslxziy.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:8QS+v9/UQQ+XmhDtbpwl5IFfvs+MDnUtMKDnIchpZAskYDOauhv dVok6O7G15f0usLrCePx2/1sx1w1chSzq/sa2PanFGfkrb+8oM6LQV2RNO0dU6ftAUFwvZC oy7h+Fgtt8//2XlRKs7X755gLJ2A6Bt8RRU+taGEqHX0ueWEje75AuVJFDKKpHLKIPdotv2 jc8MP6U9dSuJ9weXOCsxw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:5ZRTVkdjLH8=;/PPT6hTJzh2whFsNoyBH0cR5F58 yXL57i94D0eibelVMLCYwd2BjiVjXfldQ4li6IeVd5qK80bdzQM2P4MvkE9ysKreDqRoQ12St 4WyYgLCZdiwW+aQlVouJ081vEUfX1CiO/MSfH6rtjzYhlLK7yNcQwi+SjMR6YQ3tjHcA2P4dS +io6NCOkusuh5M7U21Xjl5srScjWQlbkpTAPOWz772/hpUCvAnQurspoKbsR6iA1uFoXszB9L JyLnuOUkwWaqZ6Urp3uYtGEWHdk6METPlGrR+KAIHexzkM4Wy542Xh9VtZa+YFAO2Dm5nvvZV vcXk2L8W9FKpPFh1jVnP1bHsAMiuEiP3CEy8wX+5Y01uxtRvyIh57rUULUS/rx8/+rWmS16sb YitxuB+r8se3yZIY4/50E1OlmlPa2g0EXk0Sc+8XgDjgByiIa0Hbpi1CNHx+3aNU2Qj9COD4J 3qzl5CDBo1CiPl2YILQro/Q0f9Qi/+Yuu985d0BBnj8NMxAkJZIUggh4E3mpGERATpWVNdcv+ 6vl1YXaWFxWUWE7e42ZmrhmcSkEm5cGgdg/iAGmy3Mcwh03ZpOrN0txtZwlVGecwU4zgJqR+9 WQ5EGEIgkcvTtXZGJlDrJZugYHBBoGBT9RSDPLJV0OzCZ60Pbs+CXh4M8nNKkYT7u/GVjP2NT OGX61o3yvY829QX/94OTX5omqnqPQ3qE9dry+1yieESzF73g9A9k3krWEvc1nwOJFBi/oU1oZ r1yb2LIAm465NqrF27Y6C/e2+5mxp9kTskYTqX20qsE9EiJxe1wx+1BSG8tsSPKNoXw9+IkkI Rhlj9WpIyQQHjnOScr0cw943ODfiqkd1EZKVzBTcbb1sE= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69232 Cc: jporterbugs@gmail.com, 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii wrote: > The only reasonable alternative is to throw away all the history after > 'l', which I don't think is better. > > What do other browsers do in this situation? Exactly that. Firefox, Chrome etc. for e.g. -- James From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 24 19:50:53 2024 Received: (at 69232) by debbugs.gnu.org; 25 Feb 2024 00:50:53 +0000 Received: from localhost ([127.0.0.1]:47715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re2jE-0007io-Rv for submit@debbugs.gnu.org; Sat, 24 Feb 2024 19:50:53 -0500 Received: from mout.gmx.net ([212.227.15.15]:49661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re2jC-0007iE-NE for 69232@debbugs.gnu.org; Sat, 24 Feb 2024 19:50:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1708822219; x=1709427019; i=jimjoe@gmx.net; bh=dwXDhOEi1YCekibojiE8fIxk+wbTjfgcsXXpkcJ9avk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=nCdALlcU2V3hpWVoka/XrsphPsybK18h+SlTNeJ4UeFrsO3ALXwaInikrGA5mZOK ivVVnSXhZYO3lPu9eVhlbb0n2owZzvMf/XHXWrCFDYJEVA4mSRZH6ccCMFlgI5PZI vEA3HfobDNJHKH4RQAhM0P25zw6O54rVkPSwpmlCIqgDG0wPYaf7uFpegNYIJGaSo xecWkTnBDoknGdHFcby0mZrZ6HXMzpmn6VaivkXRSnDrxpZebrf4ucEtQlodSvEnU iO+gjimR36SEIHDMXfsvODoOrrz2J8cBr7YyWRD1dhv9sd5w+YO1pagKQ/IeZKlsl +mDlO6jfBdnY5n2LZw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-15-5518 ([59.92.173.56]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MacSe-1r1wkD0LHO-00c72C; Sun, 25 Feb 2024 01:50:19 +0100 From: James Thomas To: Jim Porter Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop In-Reply-To: (Jim Porter's message of "Sat, 24 Feb 2024 14:29:21 -0800") References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> Date: Sun, 25 Feb 2024 06:20:15 +0530 Message-ID: <878r39xt88.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:rCZ64EgISesEPB1mqErK4q9qZ02Mnno0w4ZEE00nFk19wUhnvKT xikIwk1nR/82oRykg8Z/UEbr4Waf/fJT863DRve7V7wM294aJNPM7FQ7sg2YrUin6Dd3FYL kP8VknRXqdgj+FH63KgOJQRx/ca5HE6fwFgp3gxOW/9oAVlLlkUzz4Pqu+CITGevxE4S2nC kF/3kBRUbf/0Hcv/BnPmQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:5R6IlQOxbKE=;a3I7S+LoimZwcVKv7h56uCqRnTW /3VaLVES4KlSvWMFspgrO2BiyuSGvKsWe8Q9vqvrsMQRoc8IJeSHGhmMEeQcO0zJrkp0NBsrp t18R+vRrjkAH4BGisoiTgbgl897QxaFegxn2iyzuUA41IXtTYy/tsQa3RdKGVRYcuR/QMQaS9 cA+vR3o2IehgtwZLEeYkY4DCx405R4vq1xyygyZlSkNffQmtH36JYp3+hBR5qeEyxMFSYKdua 6W6Q+ruv8hc9q6mKLI4UNim6M9pNlBwT4Ynno/dNq4eDckL+KfJAidtXln5eA06nxiSxVkF5y wF2YVVRY67mTDwS92NVdNukCN3KZJYWOo8N/JI+qegKKNPcjFF9ENSZeR43zZ5N0/Bdo8C0u4 VtjphRC84DcyDAra1C666rMd+NL7vEt9Tyk7UQN8otrC50oXF/K44/rSVkY2/lytxczmJ0I2H HRrn5YSPrDMEFfshav1LMMjqbmsTg3sAlPqYc1RWlmEOxCKq5WRuuyIEK8UhKiu7R5dg15WWo 1bY1mIC0JWyD6vUiS+03unlMwjf77p/vtKVUVj51cFAkMLcWdADV0szoHeSR5RaQZ2KvoVCiO R/HZgHlzaRf6ByD+UYGDaTTZZACyQU4CzXBZO28tFd95uIbBxYuzzsLxSk7wf23zVyQ98Co0l wjwGC+b0ZqrjuZ7muZUobAakXhbrFcfAGlMtnwi6aphT4W636ZMTDtqT8Eu+PrT97knnWYKrq Ux2Htevu9sVCz7un5GY2HD5cdJH4qOfW30rj2eXCSXwsBfHVXkVqefGiku5/F3egnIXkRRMQx RtlZmjN/Lgv3czSKHdDPeqJUG8OvPIKS8rgD3pnGJBoCI= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69232 Cc: Eli Zaretskii , 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Jim Porter wrote: > Another option might be, "If you're at a historical page and you click > a link, add that page as a duplicate to the end of the history." That > would partially restore the old behavior, but only in this case where > things might otherwise be confusing. Just putting out a few ideas for refining this (in case it's opted for): My personal preference would be for the entire history up to that point be added (or be available), not just the source page of the link; so because that might sometimes be too much, (adding to the end) only the entire history up to the first occurrence of the source page. -- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 01:12:12 2024 Received: (at 69232) by debbugs.gnu.org; 25 Feb 2024 06:12:12 +0000 Received: from localhost ([127.0.0.1]:44338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re7kC-000206-0R for submit@debbugs.gnu.org; Sun, 25 Feb 2024 01:12:12 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1re7kA-0001zh-Di for 69232@debbugs.gnu.org; Sun, 25 Feb 2024 01:12:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1re7WA-0001ZP-6w; Sun, 25 Feb 2024 00:57:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7FFybqQ6rwv03HQNXYGpolf4djzV86FPwC7mLKtOAoE=; b=W5c8vk7wYErb +rZi9+wF/wC6gHkwA9ve1UgvpkRa0vZCM4uQRHGeT+CDxGuN2V47X4ujxG4qwgkhs7np6K0EqUolp RnaOKrDoJAsQ9eYGTJy+GgBzMOI0Dj/QDs20l+1TzRDpky0P200lAQAuShPG+SmsOSMQG9zs6FTi8 0uxoZSNU0rJ3IqJVEt4ZPnFxUn2MzTSbcaXujiisPaR9YnR70JoPHHzsKszllyh4ohnjzUHw2Kuq6 ehgpwi3dX2R8vJ7CAYGe//lhggzGeeR2J43AsS4O9TSGWFlLuJ3gu8T9KDnT6aYTMkFZR9yy+fmfv 1BiR34ROMi1MwFlt62JI4g==; Date: Sun, 25 Feb 2024 07:57:38 +0200 Message-Id: <86frxhxezx.fsf@gnu.org> From: Eli Zaretskii To: James Thomas In-Reply-To: <87cyslxziy.fsf@gmx.net> (message from James Thomas on Sun, 25 Feb 2024 04:04:13 +0530) Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69232 Cc: jporterbugs@gmail.com, 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: James Thomas > Cc: jporterbugs@gmail.com, 69232@debbugs.gnu.org > Date: Sun, 25 Feb 2024 04:04:13 +0530 > > Eli Zaretskii wrote: > > > The only reasonable alternative is to throw away all the history after > > 'l', which I don't think is better. > > > > What do other browsers do in this situation? > > Exactly that. Firefox, Chrome etc. for e.g. So maybe we should offer that as optional behavior? From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 15:07:27 2024 Received: (at 69232) by debbugs.gnu.org; 25 Feb 2024 20:07:27 +0000 Received: from localhost ([127.0.0.1]:44661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reKmV-0005jv-BS for submit@debbugs.gnu.org; Sun, 25 Feb 2024 15:07:27 -0500 Received: from mail-ua1-f47.google.com ([209.85.222.47]:54706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reKmS-0005ja-VV for 69232@debbugs.gnu.org; Sun, 25 Feb 2024 15:07:25 -0500 Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-7d130979108so1268177241.1 for <69232@debbugs.gnu.org>; Sun, 25 Feb 2024 12:06:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708891554; x=1709496354; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=XmfuCgPrkP3hdZF9PEkNx45heEs6tR0aC4uISMJHhNA=; b=DxVU9xWTZU2FRRkkX7EE0eCklqtUiDn0WlBuXTIxv9tcehpXJylRDM9JaZZdLNChhy Fp+N1F6ICkAG65n0k3aerehcTYSBJuoA13S4YkBWxfhmfq9MC4xJVFmf+yBPUfJK5MFi O95jN75iazfpmm4WK26rxctKGWEkn0gLZhTEpVS7TINwX0L99nhbJN+A7XScd0ZfHdxd tAEZaPEyExgA9k+dC6wuRO2IQHB4vj+IYwAk0ApslF2VkBmeZAjSkkobGJaOeQg8sDKM RiH6epjbEsq7TvOQzuvo1I1Q7BRFhHOPkuXIaCf0iw/40Mis+0RTQtBjVXv7jRtXOvz2 aedA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708891554; x=1709496354; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XmfuCgPrkP3hdZF9PEkNx45heEs6tR0aC4uISMJHhNA=; b=Jmd7J8ZNX9h5UqouLBYdW5BpgvJ/EsNZSy2KYi+Sn+TTei/qyyTHbZlfFfR2lweScB cZYJJyst3YQfK5uCaOh88wVi6TGXXLnNf+N4w3WQEpOhh/Jk2QITJ+vHViOREbFdYEs0 LQUl28dTXlh2V4GTEbqroNGSZLCa7PYOhx6e40TQ3UjlsZMiSsZNqlzwc3Ev+PUOq3KE kkgtL11dFPebUlyg4WvVroIMqkxfRkUzbvvlLfOUjvCC8/urILoNq5LoFI5qYijXF1eW 9+OzVrxDfshny7WXDRzOsnf5PloUOsMVVlabN0xwLpdUyWMuVZyatTy7FPbaTEymU8nd Ym9A== X-Gm-Message-State: AOJu0Yx8d4LE2XWm0uV0QkhPS2HlSGHBC1Z+rpBYTrNG5RSz9iIulExC hxl9g0ljEKRBKRMPHMZ4I3nYvSPJuFiSjx2RGfX5BAkTOBElgNlp0hRdmrHO X-Google-Smtp-Source: AGHT+IHz9r+f+LuT2D1lLpIXJsDc0tPfYZbZGQCexAzI1VMdSsLN9ORuaJBd0noJ1AGNbl+jvkIdFw== X-Received: by 2002:a17:902:dac9:b0:1dc:623d:1c3f with SMTP id q9-20020a170902dac900b001dc623d1c3fmr8058416plx.6.1708890041720; Sun, 25 Feb 2024 11:40:41 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 4-20020a170902c20400b001d6f8b31ddcsm2554307pll.3.2024.02.25.11.40.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Feb 2024 11:40:41 -0800 (PST) Message-ID: <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> Date: Sun, 25 Feb 2024 11:40:39 -0800 MIME-Version: 1.0 Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop To: Eli Zaretskii , James Thomas References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> Content-Language: en-US From: Jim Porter In-Reply-To: <86frxhxezx.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/24/2024 9:57 PM, Eli Zaretskii wrote: >> From: James Thomas >> Cc: jporterbugs@gmail.com, 69232@debbugs.gnu.org >> Date: Sun, 25 Feb 2024 04:04:13 +0530 >> >> Eli Zaretskii wrote: >> >>> The only reasonable alternative is to throw away all the history after >>> 'l', which I don't think is better. >>> >>> What do other browsers do in this situation? >> >> Exactly that. Firefox, Chrome etc. for e.g. > > So maybe we should offer that as optional behavior? If anything, I think this should be the default, with some other options provided for people who don't want to lose any history. That way the default behavior is what people know. How about this as an option for preserving history though: if you're at a historical page and you navigate to a link, open that link in a *new* buffer, copying over the history leading up to that link. That way, you have two separate history timelines and nothing ever gets lost or munged. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 15:18:29 2024 Received: (at 69232) by debbugs.gnu.org; 25 Feb 2024 20:18:29 +0000 Received: from localhost ([127.0.0.1]:45422 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reKxA-0006Gt-O8 for submit@debbugs.gnu.org; Sun, 25 Feb 2024 15:18:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reKx7-0006GM-Kw for 69232@debbugs.gnu.org; Sun, 25 Feb 2024 15:18:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reKUn-0007nw-UX; Sun, 25 Feb 2024 14:49:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CLIAvXabaKaA1fUhwUgfx0CppYKlBGA+Z9ene4Sx66E=; b=N+Z45NOUrYcB R8JwShCz/vYvlFKyYKCQ9UL6vjWpKkRKCxZFO9qBXyux5BdmJoCK4kFUVTiR/91DTB4jtkmYhLfzL WXYeeY9EOU4DEPN/pSQ3aiHZz/mWAFkTGwkqNZbT2C//RB/zZghb/XDla4L3vusf8gJ2Mqxb3PceP Y/NXuwRbydgPIffUKsRaGpbYv5J+/w8L8sj27OKDm/pc0ODI4j9sb0+myKw6RdSj7bLtFRl75Yl1g 3cvHxhLMMqOsOJMA8HnMNNjNB7f+QG0QFjDcKI5AupeH4EJO8tUOnND3eg+nqOSSQbrBi7PLyxgb6 UsJNWCpev2KS6/bMWnCi5A==; Date: Sun, 25 Feb 2024 21:49:07 +0200 Message-Id: <86bk84wci4.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> (message from Jim Porter on Sun, 25 Feb 2024 11:40:39 -0800) Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 25 Feb 2024 11:40:39 -0800 > Cc: 69232@debbugs.gnu.org > From: Jim Porter > > On 2/24/2024 9:57 PM, Eli Zaretskii wrote: > >> From: James Thomas > >> Cc: jporterbugs@gmail.com, 69232@debbugs.gnu.org > >> Date: Sun, 25 Feb 2024 04:04:13 +0530 > >> > >> Eli Zaretskii wrote: > >> > >>> The only reasonable alternative is to throw away all the history after > >>> 'l', which I don't think is better. > >>> > >>> What do other browsers do in this situation? > >> > >> Exactly that. Firefox, Chrome etc. for e.g. > > > > So maybe we should offer that as optional behavior? > > If anything, I think this should be the default, with some other options > provided for people who don't want to lose any history. That way the > default behavior is what people know. I don't think I mind. > How about this as an option for preserving history though: if you're at > a historical page and you navigate to a link, open that link in a *new* > buffer, copying over the history leading up to that link. That way, you > have two separate history timelines and nothing ever gets lost or munged. Sounds too complicated, and two backward-incompatible changes instead of just one. My recommendation is not to over-engineer this. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 17:43:02 2024 Received: (at 69232) by debbugs.gnu.org; 25 Feb 2024 22:43:03 +0000 Received: from localhost ([127.0.0.1]:56524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reND4-0007qO-Ap for submit@debbugs.gnu.org; Sun, 25 Feb 2024 17:43:02 -0500 Received: from mail-pg1-f182.google.com ([209.85.215.182]:49274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reND0-0007pi-3M for 69232@debbugs.gnu.org; Sun, 25 Feb 2024 17:42:58 -0500 Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5ce942efda5so1999022a12.2 for <69232@debbugs.gnu.org>; Sun, 25 Feb 2024 14:42:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708900887; x=1709505687; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=0uNute3p6mEE4YI6v7L+YKKdRNB+o0KXmduUFPteuF0=; b=hHU4WdQWI4THfX8qgYKWpO7jQ951Ljzx29HclYR7+rId2fA0SvutX+2oWeEISGYem1 Hy2obqyMTJmNHocN8iV8vSo7H79nqPivs2v9+PGDWKZsY0NEPiPolDJTRgBJ9oyu43SL hsW8UuMtzvaROeU4n7lmkLU/JqmksPOOUy8FNN2oO8OeJgzvfW5lCgrnGpAfnyF+/2Jj bXgNB4gkOO4adkJyn8oYygby7wtrQeOPihV4knT1abul7rfq+lKIHQeNlauBZKtsPBpX biHtGovKnCsKdDbfpAy2T3YOnvVZZN06i48syfhiRkpo3BGnzieQviDWc0eJfE4ymXe0 MVzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708900887; x=1709505687; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0uNute3p6mEE4YI6v7L+YKKdRNB+o0KXmduUFPteuF0=; b=twPDrFqCY6w3rOhVPk71xH5JnkZF7AAdng/vevxat2wyjdGm8BrbTuP7wTDl6fM4m7 KQ9/iOTMV5kVzbT2Oxs89yN4gUx3fpIv68yzPgl3+vXSiI3XtvnRxU1NOjEu3kTd1Fgm 420VHd38+md31VhF43/22iB/sErpsJfPMYkVA2ZuLvCTUrP+1RhIeff25NncV5kxDCfM XPeG6VuSoy+UTKrwmHpnRsKV5Nr1FQRP5MerIA7nkuYMIJtEgILiWXBzvhDphzOpNDHK QEFXPe1q8rf+AIyVFfQaV4aziL42BTjb9VVC+cLDAQACLuXd93XOh0MmyT2kl41il4j6 db9w== X-Gm-Message-State: AOJu0Yw3/3cJ/QfNNXP32kdJsC6Uqp8C/b7kLqrDxWOp8F823iLDT0NW 31qNmVTfVIsTuO4QauOJ4RCL5XA0FHTZ5HSXeqXmfd1pIyRZUP+c X-Google-Smtp-Source: AGHT+IGiamt/E9j0fVOxEY6YF9JT29qJGmz4JNRMgBBy21YqzMg4hbMp31vab0efABNRo9K+78bSaQ== X-Received: by 2002:a05:6a20:d903:b0:1a0:f7d0:e652 with SMTP id jd3-20020a056a20d90300b001a0f7d0e652mr4095953pzb.49.1708900887221; Sun, 25 Feb 2024 14:41:27 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a25-20020a62e219000000b006e4e600d15esm2695572pfi.160.2024.02.25.14.41.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Feb 2024 14:41:26 -0800 (PST) Message-ID: <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> Date: Sun, 25 Feb 2024 14:41:26 -0800 MIME-Version: 1.0 Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Content-Language: en-US To: Eli Zaretskii References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> From: Jim Porter In-Reply-To: <86bk84wci4.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/25/2024 11:49 AM, Eli Zaretskii wrote: >> If anything, I think this should be the default, with some other options >> provided for people who don't want to lose any history. That way the >> default behavior is what people know. > > I don't think I mind. Thanks. Even if there were multiple options, this is probably what I'd choose, if only out of habit. >> How about this as an option for preserving history though: if you're at >> a historical page and you navigate to a link, open that link in a *new* >> buffer, copying over the history leading up to that link. That way, you >> have two separate history timelines and nothing ever gets lost or munged. > > Sounds too complicated, and two backward-incompatible changes instead > of just one. My recommendation is not to over-engineer this. I'm ok with implementing any combination of options here to make people happy (within reason; let's keep the number of possibilities to a few). If that means just making EWW work like other browsers, for better or worse, that's ok too. We can always revisit the decision to add more options later. In any case, I'm going to look into writing some regression tests for this code so that we can be sure it works correctly. From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 28 18:40:55 2024 Received: (at 69232) by debbugs.gnu.org; 28 Feb 2024 23:40:55 +0000 Received: from localhost ([127.0.0.1]:55527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfTXi-0002mN-5p for submit@debbugs.gnu.org; Wed, 28 Feb 2024 18:40:54 -0500 Received: from mail-pf1-f175.google.com ([209.85.210.175]:57841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfTXe-0002m6-PM for 69232@debbugs.gnu.org; Wed, 28 Feb 2024 18:40:51 -0500 Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-6e5629d5237so223053b3a.3 for <69232@debbugs.gnu.org>; Wed, 28 Feb 2024 15:40:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709163558; x=1709768358; darn=debbugs.gnu.org; h=in-reply-to:content-language:references:cc:to:from:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=0yQhaPB8RKW7Bs6O/hl3ngVNmtn/IeQclZJstITPzP4=; b=GHjy29/eRc92qlI0r+qNKvzHbhXV5bOsYb7tN88tPCHtmNEWnKzat9u7ExH4hOkl+y kQmYa7ehndrFL4SMqJDpyL4AChgYPRvmYr0fKtPkX/NbDV4HOIBIsk49MPHmyqVnLAsI YuRhk35cRbDkCvpGROnHa1gWCFFA4j4xnenv5D+D9yaxs+1MbUTavVRSamBRmvEjj7aS 7/kbRB+nH5zj71boxSrw4L/TIndaxpirkeaqAUMILSmYQ7R+qhcnDWRFAxl3tvIT8Kxw 7mGBRAXkAnndTLAgkZlIfYLwfs5D/ZSxxTtpnMgoseOthJ+5xCrnDNHgr+NF2eOGthAg gbFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709163558; x=1709768358; h=in-reply-to:content-language:references:cc:to:from:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0yQhaPB8RKW7Bs6O/hl3ngVNmtn/IeQclZJstITPzP4=; b=duGBQuVwa1dtU9mAjtxIJE2ZuTPh2GmXFGTmlq+4gezNyeIRM6DXURPe3SllD1iEXs m1FTna4a0HsTwyqyACBKfqeIcnui2YiIajjJWcTchvOeZBn8NpWT5kyzHmDW8IMD+Gqi cyDAPjqqaEUQe+NKhlpYeXK5ZacTzrYk6+eFX9a5R3esGNhb9RejLBlMlUA8F/ol+pKU 2Zb4cln4tgp0v91sY3832JMXPcERHTyXzcLXhsNMddYACKVKuLbEhedglr3AYI3dsKSx XblBNZEByIWwkc6ZgZwhKcWjpBN0/2PnsB1CbRWENbBCSWPshecU/kO5XNcb829gKKQc z7UQ== X-Gm-Message-State: AOJu0Ywo0MXieuAf4gYyKAyeEPaVQXLwR7uxAwxF5TCJbbprAIEVqKai wW6xGO7T6UbMU9LXKpSviVUEtMRJ9He6lt2WN/ljYVmri9U2zSIR X-Google-Smtp-Source: AGHT+IE2WFQA7j1SVDXzKC0aukfcBUB4XBtshsCNKQ96d8iu8i+Wcn4HIHgW3/pSUq8/1vxtxZXHXw== X-Received: by 2002:a05:6a00:4e43:b0:6e5:4b1f:5b51 with SMTP id gu3-20020a056a004e4300b006e54b1f5b51mr591854pfb.24.1709163557615; Wed, 28 Feb 2024 15:39:17 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id c18-20020a056a00009200b006e2dde36edesm12363pfj.120.2024.02.28.15.39.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Feb 2024 15:39:16 -0800 (PST) Content-Type: multipart/mixed; boundary="------------M13m285eAsWPq7PObQzYF80h" Message-ID: <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> Date: Wed, 28 Feb 2024 15:39:16 -0800 MIME-Version: 1.0 Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop From: Jim Porter To: Eli Zaretskii References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> Content-Language: en-US In-Reply-To: <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------M13m285eAsWPq7PObQzYF80h Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/25/2024 2:41 PM, Jim Porter wrote: > On 2/25/2024 11:49 AM, Eli Zaretskii wrote: >>> If anything, I think this should be the default, with some other options >>> provided for people who don't want to lose any history. That way the >>> default behavior is what people know. >> >> I don't think I mind. > > Thanks. Even if there were multiple options, this is probably what I'd > choose, if only out of habit. Here's a patch that deletes "future history" in the case we'd previously discussed. I also added some regression tests for this. I think this all works correctly, but it's probably worth some manual testing over a few days just to be on the safe side. --------------M13m285eAsWPq7PObQzYF80h Content-Type: text/plain; charset=UTF-8; name="0001-When-navigating-through-history-in-EWW-don-t-keep-ad.patch" Content-Disposition: attachment; filename*0="0001-When-navigating-through-history-in-EWW-don-t-keep-ad.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBjOTdiMzBkYTZiMTZhNTUzMzY1YzFlY2M0ZDlkNGNkZDExMzk1ZGY0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgMTcgRmViIDIwMjQgMjA6NDk6MTUgLTA4MDAKU3ViamVjdDogW1BB VENIXSBXaGVuIG5hdmlnYXRpbmcgdGhyb3VnaCBoaXN0b3J5IGluIEVXVywgZG9uJ3Qga2Vl cCBhZGRpbmcgdG8KICdld3ctaGlzdG9yeScKClRoaXMgcmVzb2x2ZXMgYW4gaXNzdWUgd2hl cmUgbmF2aWdhdGluZyBiYWNrIGFuZCB0aGVuIGZvcndhcmQga2VwdAphZGRpbmcgbmV3IGhp c3RvcnkgZW50cmllcyBzbyB5b3UgY291bGQgbmV2ZXIgaGl0IHRoZSAiZW5kIiAoYnVnIzY5 MjMyKS4KCiogbGlzcC9uZXQvZXd3LmVsIChld3ctaGlzdG9yeS1wb3NpdGlvbik6IEFkZCBk b2NzdHJpbmcuCihld3ctbW9kZS1tYXAsIGV3dy1jb250ZXh0LW1lbnUpOiBVc2UgY29ycmVj dCBwcmVkaWNhdGVzIGZvciB3aGVuIHRvCmVuYWJsZSBiYWNrL2ZvcndhcmQuCihld3ctc2F2 ZS1oaXN0b3J5KTogU2F2ZSBoaXN0b3J5IGVudHJ5IGluIGl0cyBvcmlnaW5hbCBwbGFjZSB3 aGVuCnZpZXdpbmcgYSBoaXN0b3JpY2FsIHBhZ2UuICBOZXcgYXJndW1lbnQgQ0xFQVItRlVU VVJFLgooZXd3LXNldHVwLWJ1ZmZlciwgZXd3LWZvbGxvdy1saW5rLCBld3ctcmVhZGFibGUp OiBDbGVhciBmdXR1cmUgaGlzdG9yeS4KKGV3dy1iYWNrLXVybCk6IFNldCAnZXd3LWhpc3Rv cnktcG9zaXRpb24nIGJhc2VkIG9uIHRoZSByZXN1bHQgb2YKJ2V3dy1zYXZlLWhpc3Rvcnkn LgooZXd3LWZvcndhcmQtdXJsKTogU2V0ICdld3ctaGlzdG9yeS1wb3NpdGlvbicgZGlyZWN0 bHksIHNpbmNlCidld3ctc2F2ZS1oaXN0b3J5JyBubyBsb25nZXIgYWRkcyBhIG5ldyBlbnRy eSBpbiB0aGlzIGNhc2UuCgoqIHRlc3QvbGlzcC9uZXQvZXd3LXRlc3RzLmVsOiBOZXcgZmls ZS4KCiogZXRjL05FV1M6IEFubm91bmNlIHRoaXMgY2hhbmdlLgotLS0KIGV0Yy9ORVdTICAg ICAgICAgICAgICAgICAgIHwgIDEwICsrKysKIGxpc3AvbmV0L2V3dy5lbCAgICAgICAgICAg IHwgIDUzICsrKysrKysrKysrKy0tLS0tLQogdGVzdC9saXNwL25ldC9ld3ctdGVzdHMuZWwg fCAxMDggKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMyBmaWxlcyBj aGFuZ2VkLCAxNTYgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCiBjcmVhdGUgbW9k ZSAxMDA2NDQgdGVzdC9saXNwL25ldC9ld3ctdGVzdHMuZWwKCmRpZmYgLS1naXQgYS9ldGMv TkVXUyBiL2V0Yy9ORVdTCmluZGV4IDZkNDQ0ZGFmMTUyLi43OTgzYzRiZTI1YiAxMDA2NDQK LS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTEwMDQsNiArMTAwNCwxNiBAQCBX aGVuIGludm9rZWQgd2l0aCB0aGUgcHJlZml4IGFyZ3VtZW50ICgnQy11JyksCiBUaGlzIGlz IHVzZWZ1bCBmb3IgY29udGludWluZyByZWFkaW5nIHRoZSBVUkwgaW4gdGhlIGN1cnJlbnQg YnVmZmVyCiB3aGVuIHRoZSBuZXcgVVJMIGlzIGZldGNoZWQuCiAKKy0tLQorKioqIEhpc3Rv cnkgbmF2aWdhdGlvbiBpbiBFV1cgbm93IHdvcmtzIGxpa2Ugb3RoZXIgYnJvd3NlcnMuCitQ cmV2aW91c2x5LCB3aGVuIG5hdmlnYXRpbmcgYmFjayBhbmQgZm9yd2FyZCB0aHJvdWdoIHBh Z2UgaGlzdG9yeSwgRVdXCit3b3VsZCBhZGQgYSBkdXBsaWNhdGUgZW50cnkgdG8gdGhlIGVu ZCBvZiB0aGUgaGlzdG9yeSBsaXN0IGVhY2ggdGltZS4KK1RoaXMgbWFkZSBpdCBpbXBvc3Np YmxlIHRvIG5hdmlnYXRlIHRvIHRoZSAiZW5kIiBvZiB0aGUgaGlzdG9yeSBsaXN0LgorTm93 LCBuYXZpZ2F0aW5nIHRocm91Z2ggaGlzdG9yeSBpbiBFV1cgc2ltcGx5IGNoYW5nZXMgeW91 ciBwb3NpdGlvbiBpbgordGhlIGhpc3RvcnkgbGlzdCwgYWxsb3dpbmcgeW91IHRvIHJlYWNo IHRoZSBlbmQgYXMgZXhwZWN0ZWQuICBJbgorYWRkaXRpb24sIHdoZW4gbmF2aWdhdGluZyB0 byBhIG5ldyBwYWdlIGZyb20gYSBoaXN0b3JpY2FsIG9uZSwgRVdXCitkZWxldGVzIHRoZSBo aXN0b3J5IGVudHJpZXMgYWZ0ZXIgdGhlIGN1cnJlbnQgcGFnZS4KKwogKiogZ28tdHMtbW9k ZQogCiArKysKZGlmZiAtLWdpdCBhL2xpc3AvbmV0L2V3dy5lbCBiL2xpc3AvbmV0L2V3dy5l bAppbmRleCA1YTI1ZWVmOWUzYy4uOTA0Yzc3OGNiMGEgMTAwNjQ0Ci0tLSBhL2xpc3AvbmV0 L2V3dy5lbAorKysgYi9saXNwL25ldC9ld3cuZWwKQEAgLTMxMiw3ICszMTIsMTAgQEAgZXd3 LXZhbGlkLWNlcnRpZmljYXRlCiAKIChkZWZ2YXIgZXd3LWRhdGEgbmlsKQogKGRlZnZhciBl d3ctaGlzdG9yeSBuaWwpCi0oZGVmdmFyIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDApCisoZGVm dmFyIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDAKKyAgIlRoZSAxLWluZGV4ZWQgcG9zaXRpb24g aW4gYGV3dy1oaXN0b3J5Jy4KK0lmIHplcm8sIEVXVyBpcyBhdCB0aGUgbmV3ZXN0IHBhZ2Us IHdoaWNoIGlzbid0IHlldCBwcmVzZW50IGluCitgZXd3LWhpc3RvcnknLiIpCiAoZGVmdmFy IGV3dy1wcm9tcHQtaGlzdG9yeSBuaWwpCiAKIChkZWZ2YXIgZXd3LWxvY2FsLXJlZ2V4ICJs b2NhbGhvc3QiCkBAIC05NTgsNyArOTYxLDcgQEAgZXd3LWRpc3BsYXktcGRmCiAoZGVmdW4g ZXd3LXNldHVwLWJ1ZmZlciAoKQogICAod2hlbiAob3IgKHBsaXN0LWdldCBld3ctZGF0YSA6 dXJsKQogICAgICAgICAgICAgKHBsaXN0LWdldCBld3ctZGF0YSA6ZG9tKSkKLSAgICAoZXd3 LXNhdmUtaGlzdG9yeSkpCisgICAgKGV3dy1zYXZlLWhpc3RvcnkgdCkpCiAgIChsZXQgKChp bmhpYml0LXJlYWQtb25seSB0KSkKICAgICAocmVtb3ZlLW92ZXJsYXlzKQogICAgIChlcmFz ZS1idWZmZXIpKQpAQCAtMTAzNiw3ICsxMDM5LDcgQEAgZXd3LXJlYWRhYmxlCiAJCShsaWJ4 bWwtcGFyc2UtaHRtbC1yZWdpb24gKHBvaW50LW1pbikgKHBvaW50LW1heCkpKSkKICAgICAg ICAgIChiYXNlIChwbGlzdC1nZXQgZXd3LWRhdGEgOnVybCkpKQogICAgIChld3ctc2NvcmUt cmVhZGFiaWxpdHkgZG9tKQotICAgIChld3ctc2F2ZS1oaXN0b3J5KQorICAgIChld3ctc2F2 ZS1oaXN0b3J5IHQpCiAgICAgKGV3dy1kaXNwbGF5LWh0bWwgbmlsIG5pbAogICAgICAgICAg ICAgICAgICAgICAgIChsaXN0ICdiYXNlIChsaXN0IChjb25zICdocmVmIGJhc2UpKQogICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChld3ctaGlnaGVzdC1yZWFkYWJpbGl0eSBkb20p KQpAQCAtMTEyOSw5ICsxMTMyLDkgQEAgZXd3LW1vZGUtbWFwCiAgICAgICAgICAgWyJSZWxv YWQiIGV3dy1yZWxvYWQgdF0KICAgICAgICAgICBbIkZvbGxvdyBVUkwgaW4gbmV3IGJ1ZmZl ciIgZXd3LW9wZW4taW4tbmV3LWJ1ZmZlcl0KICAgICAgICAgICBbIkJhY2sgdG8gcHJldmlv dXMgcGFnZSIgZXd3LWJhY2stdXJsCi0gICAgICAgICAgIDphY3RpdmUgKG5vdCAoemVyb3Ag KGxlbmd0aCBld3ctaGlzdG9yeSkpKV0KKyAgICAgICAgICAgOmFjdGl2ZSAoPCBld3ctaGlz dG9yeS1wb3NpdGlvbiAobGVuZ3RoIGV3dy1oaXN0b3J5KSldCiAgICAgICAgICAgWyJGb3J3 YXJkIHRvIG5leHQgcGFnZSIgZXd3LWZvcndhcmQtdXJsCi0gICAgICAgICAgIDphY3RpdmUg KG5vdCAoemVyb3AgZXd3LWhpc3RvcnktcG9zaXRpb24pKV0KKyAgICAgICAgICAgOmFjdGl2 ZSAoPiBld3ctaGlzdG9yeS1wb3NpdGlvbiAxKV0KICAgICAgICAgICBbIkJyb3dzZSB3aXRo IGV4dGVybmFsIGJyb3dzZXIiIGV3dy1icm93c2Utd2l0aC1leHRlcm5hbC1icm93c2VyIHRd CiAgICAgICAgICAgWyJEb3dubG9hZCIgZXd3LWRvd25sb2FkIHRdCiAgICAgICAgICAgWyJW aWV3IHBhZ2Ugc291cmNlIiBld3ctdmlldy1zb3VyY2VdCkBAIC0xMTU1LDkgKzExNTgsOSBA QCBld3ctY29udGV4dC1tZW51CiAgICAgKGVhc3ktbWVudS1kZWZpbmUgbmlsIGVhc3ktbWVu dSBuaWwKICAgICAgICcoIkV3dyIKICAgICAgICAgWyJCYWNrIHRvIHByZXZpb3VzIHBhZ2Ui IGV3dy1iYWNrLXVybAotCSA6dmlzaWJsZSAobm90ICh6ZXJvcCAobGVuZ3RoIGV3dy1oaXN0 b3J5KSkpXQorCSA6YWN0aXZlICg8IGV3dy1oaXN0b3J5LXBvc2l0aW9uIChsZW5ndGggZXd3 LWhpc3RvcnkpKV0KIAlbIkZvcndhcmQgdG8gbmV4dCBwYWdlIiBld3ctZm9yd2FyZC11cmwK LQkgOnZpc2libGUgKG5vdCAoemVyb3AgZXd3LWhpc3RvcnktcG9zaXRpb24pKV0KKwkgOmFj dGl2ZSAoPiBld3ctaGlzdG9yeS1wb3NpdGlvbiAxKV0KIAlbIlJlbG9hZCIgZXd3LXJlbG9h ZCB0XSkpCiAgICAgKGRvbGlzdCAoaXRlbSAocmV2ZXJzZSAobG9va3VwLWtleSBlYXN5LW1l bnUgW21lbnUtYmFyIGV3d10pKSkKICAgICAgICh3aGVuIChjb25zcCBpdGVtKQpAQCAtMTI4 MCwxNiArMTI4MywyMCBAQCBld3ctYmFjay11cmwKICAgKGludGVyYWN0aXZlIG5pbCBld3ct bW9kZSkKICAgKHdoZW4gKD49IGV3dy1oaXN0b3J5LXBvc2l0aW9uIChsZW5ndGggZXd3LWhp c3RvcnkpKQogICAgICh1c2VyLWVycm9yICJObyBwcmV2aW91cyBwYWdlIikpCi0gIChld3ct c2F2ZS1oaXN0b3J5KQotICAoc2V0cSBld3ctaGlzdG9yeS1wb3NpdGlvbiAoKyBld3ctaGlz dG9yeS1wb3NpdGlvbiAyKSkKKyAgKGlmIChld3ctc2F2ZS1oaXN0b3J5KQorICAgICAgOzsg V2Ugd2VyZSBhdCB0aGUgbGF0ZXN0IHBhZ2UgKHdoaWNoIHdhcyBqdXN0IGFkZGVkIHRvIHRo ZQorICAgICAgOzsgaGlzdG9yeSksIHNvIGdvIGJhY2sgdHdvIGVudHJpZXMuCisgICAgICAo c2V0cSBld3ctaGlzdG9yeS1wb3NpdGlvbiAyKQorICAgIChzZXRxIGV3dy1oaXN0b3J5LXBv c2l0aW9uICgxKyBld3ctaGlzdG9yeS1wb3NpdGlvbikpKQogICAoZXd3LXJlc3RvcmUtaGlz dG9yeSAoZWx0IGV3dy1oaXN0b3J5ICgxLSBld3ctaGlzdG9yeS1wb3NpdGlvbikpKSkKIAog KGRlZnVuIGV3dy1mb3J3YXJkLXVybCAoKQogICAiR28gdG8gdGhlIG5leHQgZGlzcGxheWVk IHBhZ2UuIgogICAoaW50ZXJhY3RpdmUgbmlsIGV3dy1tb2RlKQotICAod2hlbiAoemVyb3Ag ZXd3LWhpc3RvcnktcG9zaXRpb24pCisgICh3aGVuICg8PSBld3ctaGlzdG9yeS1wb3NpdGlv biAxKQogICAgICh1c2VyLWVycm9yICJObyBuZXh0IHBhZ2UiKSkKICAgKGV3dy1zYXZlLWhp c3RvcnkpCisgIChzZXRxIGV3dy1oaXN0b3J5LXBvc2l0aW9uICgxLSBld3ctaGlzdG9yeS1w b3NpdGlvbikpCiAgIChld3ctcmVzdG9yZS1oaXN0b3J5IChlbHQgZXd3LWhpc3RvcnkgKDEt IGV3dy1oaXN0b3J5LXBvc2l0aW9uKSkpKQogCiAoZGVmdW4gZXd3LXJlc3RvcmUtaGlzdG9y eSAoZWxlbSkKQEAgLTE5NTgsNyArMTk2NSw3IEBAIGV3dy1mb2xsb3ctbGluawogICAgICAo KGFuZCAoc2V0cSB0YXJnZXQgKHVybC10YXJnZXQgKHVybC1nZW5lcmljLXBhcnNlLXVybCB1 cmwpKSkKIAkgICAoZXd3LXNhbWUtcGFnZS1wIHVybCAocGxpc3QtZ2V0IGV3dy1kYXRhIDp1 cmwpKSkKICAgICAgIChsZXQgKChwb2ludCAocG9pbnQpKSkKLQkoZXd3LXNhdmUtaGlzdG9y eSkKKwkoZXd3LXNhdmUtaGlzdG9yeSB0KQogCShwbGlzdC1wdXQgZXd3LWRhdGEgOnVybCB1 cmwpCiAgICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCiAgICAgICAgIChpZi1sZXQg KChtYXRjaCAodGV4dC1wcm9wZXJ0eS1zZWFyY2gtZm9yd2FyZCAnc2hyLXRhcmdldC1pZCB0 YXJnZXQgIydtZW1iZXIpKSkKQEAgLTIyODgsMTIgKzIyOTUsMjggQEAgZXd3LWJvb2ttYXJr LW1vZGUKIAogOzs7IEhpc3RvcnkgY29kZQogCi0oZGVmdW4gZXd3LXNhdmUtaGlzdG9yeSAo KQorKGRlZnVuIGV3dy1zYXZlLWhpc3RvcnkgKCZvcHRpb25hbCBjbGVhci1mdXR1cmUpCisg ICJTYXZlIHRoZSBjdXJyZW50IHBhZ2UncyBkYXRhIHRvIHRoZSBoaXN0b3J5LgorSWYgdGhl IGN1cnJlbnQgcGFnZSBpcyBhIGhpc3RvcmlhbCBvbmUgbG9hZGVkIGZyb20KK2Bld3ctaGlz dG9yeScgKGUuZy4gYnkgY2FsbGluZyBgZXd3LWJhY2stdXJsJyksIHRoaXMgd2lsbCB1cGRh dGUgdGhlCitwYWdlJ3MgZW50cnkgaW4gYGV3dy1oaXN0b3J5JyBhbmQgcmV0dXJuIG5pbC4g IE90aGVyd2lzZSwgYWRkIGEgbmV3CitlbnRyeSB0byBgZXd3LWhpc3RvcnknIGFuZCByZXR1 cm4gdC4KKworSWYgQ0xFQVItRlVUVVJFIGlzIG5vbi1uaWwsIGNsZWFyIGFueSBmdXR1cmUg aGlzdG9yeSBlbGVtZW50cyBmcm9tCitgZXd3LWhpc3RvcnknLiIKICAgKHBsaXN0LXB1dCBl d3ctZGF0YSA6cG9pbnQgKHBvaW50KSkKICAgKHBsaXN0LXB1dCBld3ctZGF0YSA6dGV4dCAo YnVmZmVyLXN0cmluZykpCi0gIChsZXQgKChoaXN0b3J5LWRlbGV0ZS1kdXBsaWNhdGVzIG5p bCkpCi0gICAgKGFkZC10by1oaXN0b3J5ICdld3ctaGlzdG9yeSBld3ctZGF0YSBld3ctaGlz dG9yeS1saW1pdCB0KSkKLSAgKHNldHEgZXd3LWRhdGEgKGxpc3QgOnRpdGxlICIiKSkpCisg IChwcm9nMQorICAgICAgKGlmICh6ZXJvcCBld3ctaGlzdG9yeS1wb3NpdGlvbikKKyAgICAg ICAgICAobGV0ICgoaGlzdG9yeS1kZWxldGUtZHVwbGljYXRlcyBuaWwpKQorICAgICAgICAg ICAgKGFkZC10by1oaXN0b3J5ICdld3ctaGlzdG9yeSBld3ctZGF0YSBld3ctaGlzdG9yeS1s aW1pdCB0KQorICAgICAgICAgICAgdCkKKyAgICAgICAgKHNldGYgKGVsdCBld3ctaGlzdG9y eSAoMS0gZXd3LWhpc3RvcnktcG9zaXRpb24pKSBld3ctZGF0YSkKKyAgICAgICAgKHdoZW4g KGFuZCBjbGVhci1mdXR1cmUgKD4gZXd3LWhpc3RvcnktcG9zaXRpb24gMSkpCisgICAgICAg ICAgKHNldHEgZXd3LWhpc3RvcnkgKG50aGNkciAoMS0gZXd3LWhpc3RvcnktcG9zaXRpb24p IGV3dy1oaXN0b3J5KQorICAgICAgICAgICAgICAgIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDEp KQorICAgICAgICBuaWwpCisgICAgKHNldHEgZXd3LWRhdGEgKGxpc3QgOnRpdGxlICIiKSkp KQogCiAoZGVmdmFyIGV3dy1jdXJyZW50LWJ1ZmZlcikKIApkaWZmIC0tZ2l0IGEvdGVzdC9s aXNwL25ldC9ld3ctdGVzdHMuZWwgYi90ZXN0L2xpc3AvbmV0L2V3dy10ZXN0cy5lbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uOWZlYmFhMzMxOTMKLS0tIC9k ZXYvbnVsbAorKysgYi90ZXN0L2xpc3AvbmV0L2V3dy10ZXN0cy5lbApAQCAtMCwwICsxLDEw OCBAQAorOzs7IGV3dy10ZXN0cy5lbCAtLS0gdGVzdHMgZm9yIGV3dy5lbCAgLSotIGxleGlj YWwtYmluZGluZzogdDsgLSotCisKKzs7IENvcHlyaWdodCAoQykgMjAyNCBGcmVlIFNvZnR3 YXJlIEZvdW5kYXRpb24sIEluYy4KKworOzsgVGhpcyBmaWxlIGlzIHBhcnQgb2YgR05VIEVt YWNzLgorCis7OyBHTlUgRW1hY3MgaXMgZnJlZSBzb2Z0d2FyZTogeW91IGNhbiByZWRpc3Ry aWJ1dGUgaXQgYW5kL29yIG1vZGlmeQorOzsgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBH TlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBhcyBwdWJsaXNoZWQgYnkKKzs7IHRoZSBGcmVl IFNvZnR3YXJlIEZvdW5kYXRpb24sIGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2Us IG9yCis7OyAoYXQgeW91ciBvcHRpb24pIGFueSBsYXRlciB2ZXJzaW9uLgorCis7OyBHTlUg RW1hY3MgaXMgZGlzdHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1 bCwKKzs7IGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBs aWVkIHdhcnJhbnR5IG9mCis7OyBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQ QVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlCis7OyBHTlUgR2VuZXJhbCBQdWJsaWMgTGlj ZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorCis7OyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQg YSBjb3B5IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorOzsgYWxvbmcgd2l0 aCBHTlUgRW1hY3MuICBJZiBub3QsIHNlZSA8aHR0cHM6Ly93d3cuZ251Lm9yZy9saWNlbnNl cy8+LgorCis7OzsgQ29tbWVudGFyeToKKworOzs7IENvZGU6CisKKyhyZXF1aXJlICdlcnQp CisocmVxdWlyZSAnZXd3KQorCisoZGVmbWFjcm8gZXd3LXRlc3QtLXdpdGgtbW9jay1yZXRy aWV2ZSAoJnJlc3QgYm9keSkKKyAgIkV2YWx1YXRlIEJPRFkgd2l0aCBhIG1vY2sgaW1wbGVt ZW50YXRpb24gb2YgYGV3dy1yZXRyaWV2ZScuCitUaGlzIGF2b2lkcyBuZXR3b3JrIHJlcXVl c3RzIGR1cmluZyBvdXIgdGVzdHMuICBBZGRpdGlvbmFsbHksIHByZXBhcmUgYQordGVtcG9y YXJ5IEVXVyBidWZmZXIgZm9yIG91ciB0ZXN0cy4iCisgIChkZWNsYXJlIChpbmRlbnQgMCkp CisgICAgYChjbC1sZXRmICgoKHN5bWJvbC1mdW5jdGlvbiAnZXd3LXJldHJpZXZlKQorICAg ICAgICAgICAgICAgIChsYW1iZGEgKHVybCBjYWxsYmFjayBhcmdzKQorICAgICAgICAgICAg ICAgICAgKHdpdGgtdGVtcC1idWZmZXIKKyAgICAgICAgICAgICAgICAgICAgOzsgV3JpdGUg b3V0IGFuIGVtcHR5IGxpc3Qgb2YgaGVhZGVycyBhbmQgdGhlIFVSTAorICAgICAgICAgICAg ICAgICAgICA7OyBhcyBvdXIgYm9keS4KKyAgICAgICAgICAgICAgICAgICAgKGluc2VydCAi XG4iIHVybCkKKyAgICAgICAgICAgICAgICAgICAgKGFwcGx5IGNhbGxiYWNrIG5pbCBhcmdz KSkpKSkKKyAgICAgICAod2l0aC10ZW1wLWJ1ZmZlcgorICAgICAgICAgKGV3dy1tb2RlKQor ICAgICAgICAgLEBib2R5KSkpCisKKyhkZWZ1biBld3ctdGVzdC0taGlzdG9yeS11cmxzICgp CisgIChtYXBjYXIgKGxhbWJkYSAoZWxlbSkgKHBsaXN0LWdldCBlbGVtIDp1cmwpKSBld3ct aGlzdG9yeSkpCisKKzs7OyBUZXN0czoKKworKGVydC1kZWZ0ZXN0IGV3dy10ZXN0L2hpc3Rv cnkvbmV3LXBhZ2UgKCkKKyAgIlRlc3QgdGhhdCB3aGVuIHZpc2l0aW5nIGEgbmV3IHBhZ2Us IHRoZSBwcmV2aW91cyBvbmUgZ29lcyBpbnRvIHRoZSBoaXN0b3J5LiIKKyAgKGV3dy10ZXN0 LS13aXRoLW1vY2stcmV0cmlldmUKKyAgICAoZXd3ICJvbmUuaW52YWxpZCIpCisgICAgKGV3 dyAidHdvLmludmFsaWQiKQorICAgIChzaG91bGQgKGVxdWFsIChld3ctdGVzdC0taGlzdG9y eS11cmxzKQorICAgICAgICAgICAgICAgICAgICcoImh0dHA6Ly9vbmUuaW52YWxpZC8iKSkp CisgICAgKGV3dyAidGhyZWUuaW52YWxpZCIpCisgICAgKHNob3VsZCAoZXF1YWwgKGV3dy10 ZXN0LS1oaXN0b3J5LXVybHMpCisgICAgICAgICAgICAgICAgICAgJygiaHR0cDovL3R3by5p bnZhbGlkLyIKKyAgICAgICAgICAgICAgICAgICAgICJodHRwOi8vb25lLmludmFsaWQvIikp KSkpCisKKyhlcnQtZGVmdGVzdCBld3ctdGVzdC9oaXN0b3J5L2JhY2stZm9yd2FyZCAoKQor ICAiVGVzdCB0aGF0IG5hdmlnYXRpbmcgdGhyb3VnaCBoaXN0b3J5IGp1c3QgY2hhbmdlcyBv dXIgaGlzdG9yeSBwb3NpdGlvbi4KK1NlZSBidWcjNjkyMzIuIgorICAoZXd3LXRlc3QtLXdp dGgtbW9jay1yZXRyaWV2ZQorICAgIChld3cgIm9uZS5pbnZhbGlkIikKKyAgICAoZXd3ICJ0 d28uaW52YWxpZCIpCisgICAgKGV3dyAidGhyZWUuaW52YWxpZCIpCisgICAgKGxldCAoKHVy bC1oaXN0b3J5ICcoImh0dHA6Ly90aHJlZS5pbnZhbGlkLyIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAiaHR0cDovL3R3by5pbnZhbGlkLyIKKyAgICAgICAgICAgICAgICAgICAgICAg ICAiaHR0cDovL29uZS5pbnZhbGlkLyIpKSkKKyAgICAgIDs7IEdvIGJhY2sgb25lIHBhZ2Uu ICBUaGlzIHNob3VsZCBhZGQgInRocmVlLmludmFsaWQiIHRvIHRoZQorICAgICAgOzsgaGlz dG9yeSwgbWFraW5nIG91ciBwb3NpdGlvbiBpbiB0aGUgbGlzdCAyLgorICAgICAgKGV3dy1i YWNrLXVybCkKKyAgICAgIChzaG91bGQgKGVxdWFsIChld3ctdGVzdC0taGlzdG9yeS11cmxz KSB1cmwtaGlzdG9yeSkpCisgICAgICAoc2hvdWxkICg9IGV3dy1oaXN0b3J5LXBvc2l0aW9u IDIpKQorICAgICAgOzsgR28gYmFjayBhZ2Fpbi4KKyAgICAgIChld3ctYmFjay11cmwpCisg ICAgICAoc2hvdWxkIChlcXVhbCAoZXd3LXRlc3QtLWhpc3RvcnktdXJscykgdXJsLWhpc3Rv cnkpKQorICAgICAgKHNob3VsZCAoPSBld3ctaGlzdG9yeS1wb3NpdGlvbiAzKSkKKyAgICAg IDs7IEF0IHRoZSBiZWdpbm5pbmcgb2YgdGhlIGhpc3RvcnksIHNvIHRyeWluZyB0byBnbyBi YWNrIHNob3VsZAorICAgICAgOzsgc2lnbmFsIGFuIGVycm9yLgorICAgICAgKHNob3VsZC1l cnJvciAoZXd3LWJhY2stdXJsKSkKKyAgICAgIDs7IEdvIGZvcndhcmQgb25jZS4KKyAgICAg IChld3ctZm9yd2FyZC11cmwpCisgICAgICAoc2hvdWxkIChlcXVhbCAoZXd3LXRlc3QtLWhp c3RvcnktdXJscykgdXJsLWhpc3RvcnkpKQorICAgICAgKHNob3VsZCAoPSBld3ctaGlzdG9y eS1wb3NpdGlvbiAyKSkKKyAgICAgIDs7IEdvIGZvcndhcmQgYWdhaW4uCisgICAgICAoZXd3 LWZvcndhcmQtdXJsKQorICAgICAgKHNob3VsZCAoZXF1YWwgKGV3dy10ZXN0LS1oaXN0b3J5 LXVybHMpIHVybC1oaXN0b3J5KSkKKyAgICAgIChzaG91bGQgKD0gZXd3LWhpc3RvcnktcG9z aXRpb24gMSkpCisgICAgICA7OyBBdCB0aGUgZW5kIG9mIHRoZSBoaXN0b3J5LCBzbyB0cnlp bmcgdG8gZ28gZm9yd2FyZCBzaG91bGQKKyAgICAgIDs7IHNpZ25hbCBhbiBlcnJvci4KKyAg ICAgIChzaG91bGQtZXJyb3IgKGV3dy1mb3J3YXJkLXVybCkpKSkpCisKKyhlcnQtZGVmdGVz dCBld3ctdGVzdC9oaXN0b3J5L2NsZWFyLWZ1dHVyZSAoKQorICAiVGVzdCB0aGF0IGdvaW5n IHRvIGEgbmV3IHBhZ2UgZnJvbSBhIGhpc3RvcmljYWwgb25lIGNsZWFycyBmdXR1cmUgaGlz dG9yeS4KK1NlZSBidWcjNjkyMzIuIgorICAoZXd3LXRlc3QtLXdpdGgtbW9jay1yZXRyaWV2 ZQorICAgIChld3cgIm9uZS5pbnZhbGlkIikKKyAgICAoZXd3ICJ0d28uaW52YWxpZCIpCisg ICAgKGV3dyAidGhyZWUuaW52YWxpZCIpCisgICAgKGV3dy1iYWNrLXVybCkKKyAgICAoZXd3 ICJmb3VyLmludmFsaWQiKQorICAgIChzaG91bGQgKGVxdWFsIChld3ctdGVzdC0taGlzdG9y eS11cmxzKSAnKCJodHRwOi8vdHdvLmludmFsaWQvIgorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICJodHRwOi8vb25lLmludmFsaWQvIikpKQorICAg IChzaG91bGQgKD0gZXd3LWhpc3RvcnktcG9zaXRpb24gMCkpKSkKKworKHByb3ZpZGUgJ2V3 dy10ZXN0cykKKzs7IGV3dy10ZXN0cy5lbCBlbmRzIGhlcmUKLS0gCjIuMjUuMQoK --------------M13m285eAsWPq7PObQzYF80h-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 29 02:27:41 2024 Received: (at 69232) by debbugs.gnu.org; 29 Feb 2024 07:27:41 +0000 Received: from localhost ([127.0.0.1]:59114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfapR-00055I-8f for submit@debbugs.gnu.org; Thu, 29 Feb 2024 02:27:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfapP-00054v-SR for 69232@debbugs.gnu.org; Thu, 29 Feb 2024 02:27:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfaSB-0003Ko-D6; Thu, 29 Feb 2024 02:03:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dWWLdi/4Gdnd25MJvmbdJhSFRYJKDdUMAF/BkhukO6A=; b=YajQ8DZjFFzT jB95fYC7tvZHHeec9VqQe9uVoZkZ/C6afjEUtqIsV4F2J77Hkw8eXVMAmv8WsajSEGurtuSyd87rT m5PkRt4Fg4h7UhjKRb0sxvj0hObqF/Ki5Hh1FupR+Hvdq8gbtAn7HG0m3fDNbJFL/E2YiCAbPd9C1 kem6vA2cfWsCS8s2MVtMdB0pwk85NRuWB4gOW4CVPTNcDovHto1I1++5JaGYSW6F5NfdhlA6qXxvw VK0FcaHxpyJ1/fE01GEYliVamyYDmI5FHeXrb/uMKnHta0oedkgQxhwWx97WtD9mzF3xX4hG/yCiQ sh7ZlIe0+f9RvNF2BMKhcw==; Date: Thu, 29 Feb 2024 09:03:33 +0200 Message-Id: <86plwfsqey.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> (message from Jim Porter on Wed, 28 Feb 2024 15:39:16 -0800) Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 28 Feb 2024 15:39:16 -0800 > From: Jim Porter > Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net > > On 2/25/2024 2:41 PM, Jim Porter wrote: > > On 2/25/2024 11:49 AM, Eli Zaretskii wrote: > >>> If anything, I think this should be the default, with some other options > >>> provided for people who don't want to lose any history. That way the > >>> default behavior is what people know. > >> > >> I don't think I mind. > > > > Thanks. Even if there were multiple options, this is probably what I'd > > choose, if only out of habit. > > Here's a patch that deletes "future history" in the case we'd previously > discussed. I also added some regression tests for this. I think this all > works correctly, but it's probably worth some manual testing over a few > days just to be on the safe side. Thanks, but I thought we were talking about some user option, since at least some people said they don't like what other browsers do? > +(defun eww-save-history (&optional clear-future) > + "Save the current page's data to the history. > +If the current page is a historial one loaded from > +`eww-history' (e.g. by calling `eww-back-url'), this will update the > +page's entry in `eww-history' and return nil. Otherwise, add a new > +entry to `eww-history' and return t. > + > +If CLEAR-FUTURE is non-nil, clear any future history elements from > +`eww-history'." This should probably explain what it means by "future history elements". Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 29 12:33:43 2024 Received: (at 69232) by debbugs.gnu.org; 29 Feb 2024 17:33:43 +0000 Received: from localhost ([127.0.0.1]:35279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfkHv-0002hM-2o for submit@debbugs.gnu.org; Thu, 29 Feb 2024 12:33:43 -0500 Received: from mail-pg1-f169.google.com ([209.85.215.169]:54529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfkHt-0002hA-Kc for 69232@debbugs.gnu.org; Thu, 29 Feb 2024 12:33:42 -0500 Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-517ab9a4a13so897498a12.1 for <69232@debbugs.gnu.org>; Thu, 29 Feb 2024 09:33:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709227928; x=1709832728; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=i9s/HThN0CYbGiEsW9gs9QIvrPDaxuCg6frrC5KE4Ts=; b=ZbLxD9AXyH4PfP0EunoumtmUeGBBZndens6SOoh23grRKPY3HnatD7SgIzayp28Nxn V88JIBk7QjSj0h/8dIyDDbecnPP+lVp9TXnYBo0NJfMlZe5j5iPPeF2FQooqXFv4NNZt ZAx0k6A1TagXZPmWd5MDfZ0T51bYcB9soLXCrvWZvVWkX7DeqZUP0n6z1uvyEGBfWoKp 0SgpzOgsXOJ3zT345+7mOQOWQjhSRaW6PDe9sMmn2I17d11ulRsdARMdB6Re1fUqfXiE xCNSYX0T+uEVjEWnLhk8KDxHMuL4V/D50kDQmYOY2J+rOkl9rHcMnJcT+W+bVaMo8c6P XHLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709227928; x=1709832728; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i9s/HThN0CYbGiEsW9gs9QIvrPDaxuCg6frrC5KE4Ts=; b=syzzR/ulom6WZCY1X6yS/tDY7dcZ5P8CzddNZVsXFxnqc06yka8lkaUCHloGX7xUks V/6yy365Gprh5Yz0DCOg3znjvIoIREWY/hVhLZxpmPnrqjlrsvR5laCH9XkWRC1T2AM3 bTcINhK5S/KNFK4F/UTWUaOffUr7Xp19tONlbPX/QyfVpZSKv7fP3MMMiFR4YlEgVuLk EIGGtffQrfkmsLLqAxIglAsGvdS1hYIOvNUZnfzAIkH/HYl84s/q6zg5IbiLbek+oPB4 i570kptC8q+72VwWe10MS2WLAxRD9InwVkWMWaFJebmTLbSf59fw5DVJ1frQPPyub6uw p0Kw== X-Gm-Message-State: AOJu0Yxh6YqseDOmlCwu7yZjUabo1YBvQa2rznU2WcR2EaeAqSh2EJxl j996VQ7Xl9PwwKvYUR6fuaCqSPeTXy/6QXpOvJqXHi1D0nUStPA9 X-Google-Smtp-Source: AGHT+IF4gcdyiKaxDrZEFFkAIu5bWlZOY9gtKQeRdsCawh0OKOnHEPO2IN1RsW2WJ3+SOQg2UORzOQ== X-Received: by 2002:a17:90b:4b4f:b0:29b:b70:5ace with SMTP id mi15-20020a17090b4b4f00b0029b0b705acemr2485361pjb.16.1709227928305; Thu, 29 Feb 2024 09:32:08 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id h16-20020a17090a051000b0029932d64c2bsm1900358pjh.17.2024.02.29.09.32.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Feb 2024 09:32:07 -0800 (PST) Message-ID: <77426857-4d81-29da-9b1a-70931393215e@gmail.com> Date: Thu, 29 Feb 2024 09:32:09 -0800 MIME-Version: 1.0 Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Content-Language: en-US To: Eli Zaretskii References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> <86plwfsqey.fsf@gnu.org> From: Jim Porter In-Reply-To: <86plwfsqey.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/28/2024 11:03 PM, Eli Zaretskii wrote: > Thanks, but I thought we were talking about some user option, since at > least some people said they don't like what other browsers do? I'll wait to see if James has anything to say about this patch, but my understanding was that his problem was that the first version of my patch *didn't* work like other browsers, and he wanted something closer to that. I don't mind adding an option though, once we have an idea of what options we'd want to support. One simple way might be to add some option like 'eww-history-replacement-function' (name suggestions welcome), which runs any time the user is at a historical page and navigates to a new one. This would default to the hypothetical function 'eww-history-delete-future' and do what my latest patch does. Then users can write their own functions to modify the behavior. It would also be nice to have an option like the Emacs 29 behavior, but with the bug in my original report still fixed. I'm not sure exactly the best implementation for this yet though... From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 29 18:31:21 2024 Received: (at 69232) by debbugs.gnu.org; 29 Feb 2024 23:31:21 +0000 Received: from localhost ([127.0.0.1]:35650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfps1-0000zo-A9 for submit@debbugs.gnu.org; Thu, 29 Feb 2024 18:31:21 -0500 Received: from mout.gmx.net ([212.227.15.15]:50339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfpru-0000zV-AT for 69232@debbugs.gnu.org; Thu, 29 Feb 2024 18:31:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1709249440; x=1709854240; i=jimjoe@gmx.net; bh=lNY9EV7DlrQFZWpvzEtF5JAugz618rRNHieUerHBJ+s=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=sWXndZhD9+19Km8AJrb8ft6ogpcbBJuroFRb/zap+FzG6ZVe4qWWl8mC3HC2CLu8 yp+TghuSYEm4K/WyriGE0PpH2d89c2yngMDe2ZcQud1dxA/dV329nRlQtdIV4pCAL s6CzpjQOnSf/hc+5EcrvjlUrKt+qO6QNwWDnYiDHX/sw2ttOzLEDvS3dJIcuKmGfV M2QQHgml3cZbLf2P4LGwgBgXV1EL8XFNAx7+YUR3oxJBlDFLNEUnlglpiYIjMCdIa qFqx8EIYpAoE00ZUDqR0mKhCNLDuwhvpdDngkQU+44Y6H7Z/lX0XKnR/LorrM0wCq Mqq2LY7WzG63gzuVDw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-15-5518 ([117.216.1.160]) by mail.gmx.net (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MbzuH-1rAMK01m3T-00dUT7; Fri, 01 Mar 2024 00:30:40 +0100 From: James Thomas To: Jim Porter Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop In-Reply-To: <77426857-4d81-29da-9b1a-70931393215e@gmail.com> (Jim Porter's message of "Thu, 29 Feb 2024 09:32:09 -0800") References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> <86plwfsqey.fsf@gnu.org> <77426857-4d81-29da-9b1a-70931393215e@gmail.com> Date: Fri, 01 Mar 2024 05:00:34 +0530 Message-ID: <878r32u9ut.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:kFBboma4B3iAHDQRAULfjyJ82kh1QOM3c5Fcq2ExG+AvS326JqG Tf984p0A1zfuJUY14N00wEkygsbAFmYUoY3iStkjgcertIeOGLJbqFSdknN6HoaOO3zrEPQ GH/4pZb2OmA3yu3f6FVFAlBGqnZZMHRAj/GYFsIwOCOBQrgsvkLC9LL/eOBwsnMY+74pzEV 4dW77gdP01GPgdn7Zw+Sw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:wcPMDfT5h0w=;mMTVOcwLvgwpjk1o+Aopl7JRTpq pWO6rT+yOhRokoCRsDRo6JdgfWrwZYili2JQU//+ZgNmnwZMRfVQPx0HQgFCphe3fQUNchFQ+ M8ZNEMtSRTSUUZz6FobgdDB39p6b6hnYOT9xZhDzIub72BROs0Jg9RPlV3dybOZ6h/oiekVFq 58sB2xzu0ICyddqQ8HtrpQDl48pd5RXgeWO2J+MbcxqGzXc3JDdXweoOLhGT3Ft2tN5i9r5aF eE90qipwQgdpM83U8nDvd6VT3/yynyem/GSdXgDaTU4jyxTTHAIDGbozaUw0Yg8+U2SS7wiTN zcPIHmlJnkCE0xcjBJIfKLD9i2ZFQfslaBke5fx3W9/dHbAjXDBWjQHhKmVNLNluDfS84wgse IActCb6Au5slksjWhwDzpfru+PEE5Fwar2kjJ2hiTWcHOwMyH3KwL3rjfMEqm+gRQDfhfku9D VddyaL81056Jufu6w5OCuZ9F8cmExFpQzBCQ/pxGq5DB/PxKoQUBtklg/2V5Yvw3nduX/OgJF CIg3FC4IMXjP7NfD+tR3pBHEiw//b44DCgit9MgYUUOMT7XQ2JBGaSrwJexLGiGLetGg3MRWN HwuNBpSAKJj3Orya4dkMXhcem1wdnbK1p3bp96OWIznGd2d0RUAyRlU6dSk9j8sPRpYmQLZv+ v2AtoZpetb3g1N/o96Tvq+EjjcvpBkOIAheADvCYe6cW7v8QQZD6JDzRavrD7iMq6uLcPeWvJ hhvXO/KXE5Md3ZC0hSuKLVhPv8Ot8qrDeqEAIbpVmASbUDlcEhXCrfqek2YAa9p9NAfAEgIUx g6mLGm4+tSrcmwbyKBaTD6oqX4fGjXvWeyrr8oIMm5udg= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69232 Cc: Eli Zaretskii , 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Jim Porter wrote: > On 2/28/2024 11:03 PM, Eli Zaretskii wrote: >> Thanks, but I thought we were talking about some user option, since at >> least some people said they don't like what other browsers do? > > I'll wait to see if James has anything to say about this patch, but my > understanding was that his problem was that the first version of my > patch *didn't* work like other browsers, and he wanted something > closer to that. The current patch is much better for me personally: 'l' and 'r' now do what they're supposed to do. But my ideal (short of any advanced 'tree' mechanism), as I originally stated, would've been to _insert_ (rather than _replace_) the new history at the position in the current history where it's created (but I see that there's no SOP for that in (info "(elisp) Minibuffer History"), and that there could be performance implications). > I don't mind adding an option though, once we have an idea of what > options we'd want to support. One simple way might be to add some > option like 'eww-history-replacement-function' (name suggestions > welcome), which runs any time the user is at a historical page and > navigates to a new one. This would default to the hypothetical > function 'eww-history-delete-future' and do what my latest patch does. > Then users can write their own functions to modify the behavior. Why not simply make 'eww-save-history' customizable? > It would also be nice to have an option like the Emacs 29 behavior, > but with the bug in my original report still fixed. I'm not sure > exactly the best implementation for this yet though... TBH I don't think anyone would have been (ab)using it effectively because each 'l' or 'r' made things more complicated; but the advantage that *all* of history was available with 'H'. (I'm using this patch and will let you know if I see anything amiss) Regards, James From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 29 20:01:58 2024 Received: (at 69232) by debbugs.gnu.org; 1 Mar 2024 01:01:59 +0000 Received: from localhost ([127.0.0.1]:35733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfrHi-0003UB-JX for submit@debbugs.gnu.org; Thu, 29 Feb 2024 20:01:58 -0500 Received: from mail-il1-f181.google.com ([209.85.166.181]:53441) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfrHg-0003Tt-57 for 69232@debbugs.gnu.org; Thu, 29 Feb 2024 20:01:57 -0500 Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-365c773ae6cso5732015ab.2 for <69232@debbugs.gnu.org>; Thu, 29 Feb 2024 17:01:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709254823; x=1709859623; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=WRgWetmmZEdcGdyYkQN8Gn/xqywyzhy/3AjCV7ZkWzs=; b=d8uJgm+86laOn3opuhHih+f8Ox5zALikHdrUZo3Rms/+wGK2BhF22KZOsj9qdlgwrN FQphyiXvsMLoicOQH1IUBbWFNbfiv9ihAUa4pf3x2SjPMnfO47jzBGX8Q2Y10F+MoRZI vIxaWoy4zU7GtlX9sx4bM5dtDzJd+tGhqNpVMgZ8A2UerkOCDUHUjBF9iQFjxLB0/SId f9mLpOAsEGNPFiR5jVB4ZZb6X8Ol9/eHuPxD/D8JwhXak0qCBwZo5fB6TyJnccV8IL6H BwYVq4DoBZk7JEYx8L4AZ+9KyggtL/pS3XQtFBvZWra8UlrOFxIZteUYB9RCWAWbQKK3 rHQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709254823; x=1709859623; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WRgWetmmZEdcGdyYkQN8Gn/xqywyzhy/3AjCV7ZkWzs=; b=hH8BsdBENcXIbA8SlTKx/kInW9yyBgseYKtQZp3ifzLNtnCZgMIHs8MJqJZjfcA78O smP6SsLMPfZ3d75XH9OHbPAkrGw6/ahLKT8v0GJMwJt0Hxofy4dtgVZk+UVi/nwz2tb3 IXnN6EilWGVJeJd/1fM0cIPCkTvm/FEYNZRJWXX1DpFjMrJxUAI2OW2VkV6gFy1Jo37e WPq0gl9JdS7BGxC9xFbCqqZHDiVKYFaZlIgl59usPoUGwS0I1kpa27L2ofxNloXFXO5w Rxsw8G5Ttzwj0g+7IXF2o88STPTgnFWxyNNN/oa20FvUNsBf8djH0utMfIMYA59gkBKR wzPQ== X-Forwarded-Encrypted: i=1; AJvYcCU1zd5fpCsOOlZKZXrdMxRTotNrGMPif+cnGtCoWUDQJn3/Kw4sQnPDWCvc0cdXjTt7um09wLnyLzyfpZ8v4b7+ZyCsmSA= X-Gm-Message-State: AOJu0YwDPEwEW2ExXlpJZg/QgNHYS9Vz5HYI+dKJb4zKj++9c94fEhsK hlfHchjPPjGmK5FTZflJbx8L6+gjQjadfFgpXBkwQFcvcKHqeO2Y X-Google-Smtp-Source: AGHT+IEXyTHcGU4sXpyPubDkqdaWNp7Zf6piDvOTw77J6GlHloKjZ/dfrfkdQBB/s7NAvtz27UH2JA== X-Received: by 2002:a05:6e02:19ce:b0:365:1959:c288 with SMTP id r14-20020a056e0219ce00b003651959c288mr329684ill.30.1709254822886; Thu, 29 Feb 2024 17:00:22 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id j36-20020a63fc24000000b0059b2316be86sm1896162pgi.46.2024.02.29.17.00.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Feb 2024 17:00:22 -0800 (PST) Message-ID: Date: Thu, 29 Feb 2024 17:00:22 -0800 MIME-Version: 1.0 Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop To: James Thomas References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> <86plwfsqey.fsf@gnu.org> <77426857-4d81-29da-9b1a-70931393215e@gmail.com> <878r32u9ut.fsf@gmx.net> Content-Language: en-US From: Jim Porter In-Reply-To: <878r32u9ut.fsf@gmx.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69232 Cc: Eli Zaretskii , 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/29/2024 3:30 PM, James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > The current patch is much better for me personally: 'l' and 'r' now do > what they're supposed to do. But my ideal (short of any advanced 'tree' > mechanism), as I originally stated, would've been to _insert_ (rather > than _replace_) the new history at the position in the current history > where it's created (but I see that there's no SOP for that in (info > "(elisp) Minibuffer History"), and that there could be performance > implications). That shouldn't be too hard to do, at the very least with the appropriate hooks (i.e. you might need to write some Elisp depending on how many built-in options we want to support, but you won't have to use 'advice-add'). > Why not simply make 'eww-save-history' customizable? In a general sense, that's the idea. I don't want to make 'eww-save-history' itself customizable though, since a) I want to let people define a history pruning/fixup function and b) I don't want that customizable function to have to be responsible for saving the current page's history; 'eww-save-history' can do that for us. In practice though, I think it'll all work out about the same, albeit easier to use. > TBH I don't think anyone would have been (ab)using it effectively > because each 'l' or 'r' made things more complicated; but the advantage > that *all* of history was available with 'H'. Yeah, I think the main thing we need here is some option to prevent loss of existing history. > (I'm using this patch and will let you know if I see anything amiss) I already found one issue with reloading messing up history, but that was an easy fix. Once I finish up the other parts of my v3 patch, I'll post it here. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 29 21:11:58 2024 Received: (at 69232) by debbugs.gnu.org; 1 Mar 2024 02:11:58 +0000 Received: from localhost ([127.0.0.1]:35800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfsNR-0005QZ-52 for submit@debbugs.gnu.org; Thu, 29 Feb 2024 21:11:58 -0500 Received: from mail-pf1-f182.google.com ([209.85.210.182]:60610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfsNN-0005QM-Va for 69232@debbugs.gnu.org; Thu, 29 Feb 2024 21:11:55 -0500 Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6e56da425b5so1264082b3a.0 for <69232@debbugs.gnu.org>; Thu, 29 Feb 2024 18:11:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709259020; x=1709863820; darn=debbugs.gnu.org; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=GP2XaiznDjObiZEhFbw021fLN8pKRNqWFalccXg2zgY=; b=JQ8/kNNn5WU3Wsiher8tMS/5kQaUNbVksX3KJeYHuXkRiVDXCfwH37JL4corRG53di tAnrLouRi6+EnKlqinjxEkU0IKqgqd/vIeFWe17SpM3VXCN4Lvb+MtvzBRodijowahl7 WdS46o0z37NBQLOvbFM+OPGiHMYOkuhwlU74Svwp0NZ6VZON7iDqFDCB4kuLRYSvrLV8 nOwF/NdvPyw3cJpNXs9J4s9/njYTN3UkTakg+hTB+65tBtg11QsRGlpQjD/PW0B+yqiL ou6VeV1exnSKb4mT2EKr0ebuxLNtNwpkfltri5zUjUf3NcRrFfqNEMPU5AF5tx/E/UwQ 6Rbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709259020; x=1709863820; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=GP2XaiznDjObiZEhFbw021fLN8pKRNqWFalccXg2zgY=; b=w+SfDBMncicjuCcV8ofByPGhlFOh3BCFxiTqLXQ4lPUOXd0GSlxeZHRVi9M6LrxioH po+r6IJaO9Wq2zqUk34uxSEQbjSiyzyusQVL1P3MvUExRyzgxfKTfaMrIqzOjg2biOQj r64GJv/T3JYUipuv3CqX0WNU8DMscyGAG/7MK27xo2gDd0FxWdKIa52tkzOnO6u3L9lR D812YHkleGrgQDn2VlFGLiyTSGLUHsIm458sR26iAgR8Mj9o4Gyk2U7SDyH6dy6EZ4ZX p9vA7pv1RovLY/dr3gr86d0TCulemsP9BYPTkaoxRneKxoRNr4hMwfQOXvWQxoZeevIj K8sg== X-Forwarded-Encrypted: i=1; AJvYcCVI21Y51lZiBwIgwQMDTQ14M9LXXrD2ai2Crb/Ptb8jSo7/AQDS6e5icPAiOrWDCRcCfFzQJnm2aciSbq2jJcy/DK3Yt/4= X-Gm-Message-State: AOJu0Yyi0kuDkHlF0LI6xU8NSQlkKqfT0W0p+B58H21GCHiVwnBwH5k3 x2Iu3sSw03qziqxz3Ax4hM4co3hruUhzdcx0JS/IBHaJgJs9ezW9 X-Google-Smtp-Source: AGHT+IG0AQJXIImNLgd+H/YISGJN7W08d/wflC8WG/6uLg7fEBL+K3LqsWpm4+4uAmnBjsyEgnIQUQ== X-Received: by 2002:a17:903:187:b0:1dc:adb2:628c with SMTP id z7-20020a170903018700b001dcadb2628cmr456243plg.34.1709259020255; Thu, 29 Feb 2024 18:10:20 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id p1-20020a170902e74100b001dca68a8a00sm2175386plf.139.2024.02.29.18.10.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Feb 2024 18:10:19 -0800 (PST) Content-Type: multipart/mixed; boundary="------------gG00H1G0ERRREejvIFo9gNZR" Message-ID: <99e36690-ffbe-f373-50d2-32c92717a560@gmail.com> Date: Thu, 29 Feb 2024 18:10:19 -0800 MIME-Version: 1.0 Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Content-Language: en-US From: Jim Porter To: James Thomas References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> <86plwfsqey.fsf@gnu.org> <77426857-4d81-29da-9b1a-70931393215e@gmail.com> <878r32u9ut.fsf@gmx.net> In-Reply-To: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69232 Cc: Eli Zaretskii , 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------gG00H1G0ERRREejvIFo9gNZR Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/29/2024 5:00 PM, Jim Porter wrote: > I already found one issue with reloading messing up history, but that > was an easy fix. Once I finish up the other parts of my v3 patch, I'll > post it here. I've only lightly tested this so far, but this version adds an 'eww-before-browse-function' option which lets you customize how EWW manipulates history before browsing to a new page. I've added functions for the default behavior ('eww-clear-future-history'), and for cloning all the "parent" entries ('eww-clone-previous-history')[1]. You can also set it to 'ignore', which will just preserve the old entries and add the new page to the end (which is the behavior v1 of my patch had). I've also added more regression tests to make sure this all works as expected. How does this look? [1] See the docstring for a longer explanation of how this works. --------------gG00H1G0ERRREejvIFo9gNZR Content-Type: text/plain; charset=UTF-8; name="0001-When-navigating-through-history-in-EWW-don-t-keep-ad.patch" Content-Disposition: attachment; filename*0="0001-When-navigating-through-history-in-EWW-don-t-keep-ad.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA2MzkxYmNmMTNmZTBhMjZhYmE2N2VmM2U3N2E1MWVjN2I5Y2E2Y2MxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgMTcgRmViIDIwMjQgMjA6NDk6MTUgLTA4MDAKU3ViamVjdDogW1BB VENIXSBXaGVuIG5hdmlnYXRpbmcgdGhyb3VnaCBoaXN0b3J5IGluIEVXVywgZG9uJ3Qga2Vl cCBhZGRpbmcgdG8KICdld3ctaGlzdG9yeScKClRoaXMgcmVzb2x2ZXMgYW4gaXNzdWUgd2hl cmUgbmF2aWdhdGluZyBiYWNrIGFuZCB0aGVuIGZvcndhcmQga2VwdAphZGRpbmcgbmV3IGhp c3RvcnkgZW50cmllcyBzbyB5b3UgY291bGQgbmV2ZXIgaGl0IHRoZSAiZW5kIiAoYnVnIzY5 MjMyKS4KCiogbGlzcC9uZXQvZXd3LmVsIChld3ctYmVmb3JlLWJyb3dzZS1mdW5jdGlvbik6 IE5ldyBvcHRpb24uCihld3ctaGlzdG9yeS1wb3NpdGlvbik6IEFkZCBkb2NzdHJpbmcuCihl d3ctbW9kZS1tYXAsIGV3dy1jb250ZXh0LW1lbnUpOiBVc2UgY29ycmVjdCBwcmVkaWNhdGVz IGZvciB3aGVuIHRvCmVuYWJsZSBiYWNrL2ZvcndhcmQuCihld3ctc2F2ZS1oaXN0b3J5KTog U2F2ZSBoaXN0b3J5IGVudHJ5IGluIGl0cyBvcmlnaW5hbCBwbGFjZSB3aGVuCnZpZXdpbmcg YSBoaXN0b3JpY2FsIHBhZ2UuCihld3ctLWJlZm9yZS1icm93c2UpOiBOZXcgZnVuY3Rpb24u Li4KKGV3dywgZXd3LWZvbGxvdy1saW5rLCBld3ctcmVhZGFibGUpOiAuLi4gY2FsbCBpdC4K KGV3dy1yZW5kZXIpOiBEb24ndCBzZXQgJ2V3dy1oaXN0b3J5LXBvc2l0aW9uJyBoZXJlLi4u Cihld3ctLWJlZm9yZS1icm93c2UpOiAuLi4gaW5zdGVhZCwgc2V0IGl0IGhlcmUuCihld3ct YmFjay11cmwpOiBTZXQgJ2V3dy1oaXN0b3J5LXBvc2l0aW9uJyBiYXNlZCBvbiB0aGUgcmVz dWx0IG9mCidld3ctc2F2ZS1oaXN0b3J5Jy4KKGV3dy1mb3J3YXJkLXVybCk6IFNldCAnZXd3 LWhpc3RvcnktcG9zaXRpb24nIGRpcmVjdGx5LCBzaW5jZQonZXd3LXNhdmUtaGlzdG9yeScg bm8gbG9uZ2VyIGFkZHMgYSBuZXcgZW50cnkgaW4gdGhpcyBjYXNlLgooZXd3LWNsZWFyLWZ1 dHVyZS1oaXN0b3J5LCBld3ctY2xvbmUtcHJldmlvdXMtaGlzdG9yeSk6IE5ldyBmdW5jdGlv bnMuCgoqIHRlc3QvbGlzcC9uZXQvZXd3LXRlc3RzLmVsOiBOZXcgZmlsZS4KCiogZXRjL05F V1M6IEFubm91bmNlIHRoaXMgY2hhbmdlLgotLS0KIGV0Yy9ORVdTICAgICAgICAgICAgICAg ICAgIHwgIDEyICsrKwogbGlzcC9uZXQvZXd3LmVsICAgICAgICAgICAgfCAgODQgKysrKysr KysrKysrKystLS0KIHRlc3QvbGlzcC9uZXQvZXd3LXRlc3RzLmVsIHwgMTc5ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMjYzIGlu c2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IHRlc3Qv bGlzcC9uZXQvZXd3LXRlc3RzLmVsCgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVX UwppbmRleCA2ZDQ0NGRhZjE1Mi4uNjJmMzYwYmMxMTIgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdT CisrKyBiL2V0Yy9ORVdTCkBAIC0xMDA0LDYgKzEwMDQsMTggQEAgV2hlbiBpbnZva2VkIHdp dGggdGhlIHByZWZpeCBhcmd1bWVudCAoJ0MtdScpLAogVGhpcyBpcyB1c2VmdWwgZm9yIGNv bnRpbnVpbmcgcmVhZGluZyB0aGUgVVJMIGluIHRoZSBjdXJyZW50IGJ1ZmZlcgogd2hlbiB0 aGUgbmV3IFVSTCBpcyBmZXRjaGVkLgogCistLS0KKyoqKiBIaXN0b3J5IG5hdmlnYXRpb24g aW4gRVdXIG5vdyB3b3JrcyBsaWtlIG90aGVyIGJyb3dzZXJzLgorUHJldmlvdXNseSwgd2hl biBuYXZpZ2F0aW5nIGJhY2sgYW5kIGZvcndhcmQgdGhyb3VnaCBwYWdlIGhpc3RvcnksIEVX Vword291bGQgYWRkIGEgZHVwbGljYXRlIGVudHJ5IHRvIHRoZSBlbmQgb2YgdGhlIGhpc3Rv cnkgbGlzdCBlYWNoIHRpbWUuCitUaGlzIG1hZGUgaXQgaW1wb3NzaWJsZSB0byBuYXZpZ2F0 ZSB0byB0aGUgImVuZCIgb2YgdGhlIGhpc3RvcnkgbGlzdC4KK05vdywgbmF2aWdhdGluZyB0 aHJvdWdoIGhpc3RvcnkgaW4gRVdXIHNpbXBseSBjaGFuZ2VzIHlvdXIgcG9zaXRpb24gaW4K K3RoZSBoaXN0b3J5IGxpc3QsIGFsbG93aW5nIHlvdSB0byByZWFjaCB0aGUgZW5kIGFzIGV4 cGVjdGVkLiAgSW4KK2FkZGl0aW9uLCB3aGVuIG5hdmlnYXRpbmcgdG8gYSBuZXcgcGFnZSBm cm9tIGEgaGlzdG9yaWNhbCBvbmUsIEVXVworZGVsZXRlcyB0aGUgaGlzdG9yeSBlbnRyaWVz IGFmdGVyIHRoZSBjdXJyZW50IHBhZ2UuICBUbyBjaGFuZ2UgdGhlCitiZWhhdmlvciB3aGVu IG5hdmlnYXRpbmcgZnJvbSBoaXN0b3JpY2FsIHBhZ2VzLCB5b3UgY2FuIGN1c3RvbWl6ZQor J2V3dy1iZWZvcmUtYnJvd3NlLWZ1bmN0aW9uJy4KKwogKiogZ28tdHMtbW9kZQogCiArKysK ZGlmZiAtLWdpdCBhL2xpc3AvbmV0L2V3dy5lbCBiL2xpc3AvbmV0L2V3dy5lbAppbmRleCA1 YTI1ZWVmOWUzYy4uOGM4MmY5MmFmMmEgMTAwNjQ0Ci0tLSBhL2xpc3AvbmV0L2V3dy5lbAor KysgYi9saXNwL25ldC9ld3cuZWwKQEAgLTE4Miw2ICsxODIsMTQgQEAgZXd3LWJyb3dzZS11 cmwtbmV3LXdpbmRvdy1pcy10YWIKICAgICAgICAgICAgICAgICAgKGNvbnN0IDp0YWcgIk9w ZW4gbmV3IHRhYiB3aGVuIHRhYiBiYXIgaXMgZW5hYmxlZCIgdGFiLWJhcikKICAgICAgICAg ICAgICAgICAgKGNvbnN0IDp0YWcgIk5ldmVyIG9wZW4gVVJMIGluIG5ldyB0YWIiIG5pbCkp KQogCisoZGVmY3VzdG9tIGV3dy1iZWZvcmUtYnJvd3NlLWZ1bmN0aW9uICMnZXd3LWNsZWFy LWZ1dHVyZS1oaXN0b3J5CisgICJBIGZ1bmN0aW9uIHRvIGNhbGwgYmVmb3JlIGJyb3dzaW5n IHRvIGEgbmV3IHBhZ2UuCitCeSBkZWZhdWx0LCB0aGlzIHJlbW92ZXMgYW55IGVudHJpZXMg aW4gdGhlIGhpc3RvcnkgdGhhdCBjb21lIGFmdGVyIHRoZQorY3VycmVudCBwYWdlIChzZWUg YGV3dy1jbGVhci1mdXR1cmUtaGlzdG9yeScpLiIKKyAgOnZlcnNpb24gIjMwLjEiCisgIDpn cm91cCAnZXd3CisgIDp0eXBlICdmdW5jdGlvbikKKwogKGRlZmN1c3RvbSBld3ctYWZ0ZXIt cmVuZGVyLWhvb2sgbmlsCiAgICJBIGhvb2sgY2FsbGVkIGFmdGVyIGV3dyBoYXMgZmluaXNo ZWQgcmVuZGVyaW5nIHRoZSBidWZmZXIuIgogICA6dmVyc2lvbiAiMjUuMSIKQEAgLTMxMiw3 ICszMjAsMTAgQEAgZXd3LXZhbGlkLWNlcnRpZmljYXRlCiAKIChkZWZ2YXIgZXd3LWRhdGEg bmlsKQogKGRlZnZhciBld3ctaGlzdG9yeSBuaWwpCi0oZGVmdmFyIGV3dy1oaXN0b3J5LXBv c2l0aW9uIDApCisoZGVmdmFyIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDAKKyAgIlRoZSAxLWlu ZGV4ZWQgcG9zaXRpb24gaW4gYGV3dy1oaXN0b3J5Jy4KK0lmIHplcm8sIEVXVyBpcyBhdCB0 aGUgbmV3ZXN0IHBhZ2UsIHdoaWNoIGlzbid0IHlldCBwcmVzZW50IGluCitgZXd3LWhpc3Rv cnknLiIpCiAoZGVmdmFyIGV3dy1wcm9tcHQtaGlzdG9yeSBuaWwpCiAKIChkZWZ2YXIgZXd3 LWxvY2FsLXJlZ2V4ICJsb2NhbGhvc3QiCkBAIC00MDIsNiArNDEzLDcgQEAgZXd3CiAgICAg KHQKICAgICAgKGdldC1idWZmZXItY3JlYXRlICIqZXd3KiIpKSkpCiAgIChld3ctc2V0dXAt YnVmZmVyKQorICAoZXd3LS1iZWZvcmUtYnJvd3NlKQogICA7OyBDaGVjayB3aGV0aGVyIHRo ZSBkb21haW4gb25seSB1c2VzICJIaWdobHkgUmVzdHJpY3RlZCIgVW5pY29kZQogICA7OyBJ RE5BIGNoYXJhY3RlcnMuICBJZiBub3QsIHRyYW5zZm9ybSB0byBwdW55Y29kZSB0byBpbmRp Y2F0ZSB0aGF0CiAgIDs7IHRoZXJlIG1heSBiZSBmdW5ueSBidXNpbmVzcyBnb2luZyBvbi4K QEAgLTY1NCw3ICs2NjYsNiBAQCBld3ctcmVuZGVyCiAJICAgICh3aXRoLWN1cnJlbnQtYnVm ZmVyIGJ1ZmZlcgogCSAgICAgIChwbGlzdC1wdXQgZXd3LWRhdGEgOnVybCB1cmwpCiAJICAg ICAgKGV3dy0tYWZ0ZXItcGFnZS1jaGFuZ2UpCi0JICAgICAgKHNldHEgZXd3LWhpc3Rvcnkt cG9zaXRpb24gMCkKIAkgICAgICAoYW5kIGxhc3QtY29kaW5nLXN5c3RlbS11c2VkCiAJCSAg IChzZXQtYnVmZmVyLWZpbGUtY29kaW5nLXN5c3RlbSBsYXN0LWNvZGluZy1zeXN0ZW0tdXNl ZCkpCiAgICAgICAgICAgICAgICh1bmxlc3Mgc2hyLWZpbGwtdGV4dApAQCAtOTA1LDYgKzkx NiwxMSBAQCBld3ctdXBkYXRlLWhlYWRlci1saW5lLWZvcm1hdAogCQkgYCgoP3UgLiAsKG9y IHVybCAiIikpCiAJCSAgICg/dCAuICx0aXRsZSkpKSkpKSkpCiAKKyhkZWZ1biBld3ctLWJl Zm9yZS1icm93c2UgKCkKKyAgKGZ1bmNhbGwgZXd3LWJlZm9yZS1icm93c2UtZnVuY3Rpb24p CisgIChzZXRxIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDAKKyAgICAgICAgZXd3LWRhdGEgKGxp c3QgOnRpdGxlICIiKSkpCisKIChkZWZ1biBld3ctLWFmdGVyLXBhZ2UtY2hhbmdlICgpCiAg IChld3ctdXBkYXRlLWhlYWRlci1saW5lLWZvcm1hdCkKICAgKGV3dy0tcmVuYW1lLWJ1ZmZl cikpCkBAIC0xMDM3LDYgKzEwNTMsNyBAQCBld3ctcmVhZGFibGUKICAgICAgICAgIChiYXNl IChwbGlzdC1nZXQgZXd3LWRhdGEgOnVybCkpKQogICAgIChld3ctc2NvcmUtcmVhZGFiaWxp dHkgZG9tKQogICAgIChld3ctc2F2ZS1oaXN0b3J5KQorICAgIChld3ctLWJlZm9yZS1icm93 c2UpCiAgICAgKGV3dy1kaXNwbGF5LWh0bWwgbmlsIG5pbAogICAgICAgICAgICAgICAgICAg ICAgIChsaXN0ICdiYXNlIChsaXN0IChjb25zICdocmVmIGJhc2UpKQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgIChld3ctaGlnaGVzdC1yZWFkYWJpbGl0eSBkb20pKQpAQCAtMTEy OSw5ICsxMTQ2LDkgQEAgZXd3LW1vZGUtbWFwCiAgICAgICAgICAgWyJSZWxvYWQiIGV3dy1y ZWxvYWQgdF0KICAgICAgICAgICBbIkZvbGxvdyBVUkwgaW4gbmV3IGJ1ZmZlciIgZXd3LW9w ZW4taW4tbmV3LWJ1ZmZlcl0KICAgICAgICAgICBbIkJhY2sgdG8gcHJldmlvdXMgcGFnZSIg ZXd3LWJhY2stdXJsCi0gICAgICAgICAgIDphY3RpdmUgKG5vdCAoemVyb3AgKGxlbmd0aCBl d3ctaGlzdG9yeSkpKV0KKyAgICAgICAgICAgOmFjdGl2ZSAoPCBld3ctaGlzdG9yeS1wb3Np dGlvbiAobGVuZ3RoIGV3dy1oaXN0b3J5KSldCiAgICAgICAgICAgWyJGb3J3YXJkIHRvIG5l eHQgcGFnZSIgZXd3LWZvcndhcmQtdXJsCi0gICAgICAgICAgIDphY3RpdmUgKG5vdCAoemVy b3AgZXd3LWhpc3RvcnktcG9zaXRpb24pKV0KKyAgICAgICAgICAgOmFjdGl2ZSAoPiBld3ct aGlzdG9yeS1wb3NpdGlvbiAxKV0KICAgICAgICAgICBbIkJyb3dzZSB3aXRoIGV4dGVybmFs IGJyb3dzZXIiIGV3dy1icm93c2Utd2l0aC1leHRlcm5hbC1icm93c2VyIHRdCiAgICAgICAg ICAgWyJEb3dubG9hZCIgZXd3LWRvd25sb2FkIHRdCiAgICAgICAgICAgWyJWaWV3IHBhZ2Ug c291cmNlIiBld3ctdmlldy1zb3VyY2VdCkBAIC0xMTU1LDkgKzExNzIsOSBAQCBld3ctY29u dGV4dC1tZW51CiAgICAgKGVhc3ktbWVudS1kZWZpbmUgbmlsIGVhc3ktbWVudSBuaWwKICAg ICAgICcoIkV3dyIKICAgICAgICAgWyJCYWNrIHRvIHByZXZpb3VzIHBhZ2UiIGV3dy1iYWNr LXVybAotCSA6dmlzaWJsZSAobm90ICh6ZXJvcCAobGVuZ3RoIGV3dy1oaXN0b3J5KSkpXQor CSA6YWN0aXZlICg8IGV3dy1oaXN0b3J5LXBvc2l0aW9uIChsZW5ndGggZXd3LWhpc3Rvcnkp KV0KIAlbIkZvcndhcmQgdG8gbmV4dCBwYWdlIiBld3ctZm9yd2FyZC11cmwKLQkgOnZpc2li bGUgKG5vdCAoemVyb3AgZXd3LWhpc3RvcnktcG9zaXRpb24pKV0KKwkgOmFjdGl2ZSAoPiBl d3ctaGlzdG9yeS1wb3NpdGlvbiAxKV0KIAlbIlJlbG9hZCIgZXd3LXJlbG9hZCB0XSkpCiAg ICAgKGRvbGlzdCAoaXRlbSAocmV2ZXJzZSAobG9va3VwLWtleSBlYXN5LW1lbnUgW21lbnUt YmFyIGV3d10pKSkKICAgICAgICh3aGVuIChjb25zcCBpdGVtKQpAQCAtMTI4MCwxNiArMTI5 NywyMCBAQCBld3ctYmFjay11cmwKICAgKGludGVyYWN0aXZlIG5pbCBld3ctbW9kZSkKICAg KHdoZW4gKD49IGV3dy1oaXN0b3J5LXBvc2l0aW9uIChsZW5ndGggZXd3LWhpc3RvcnkpKQog ICAgICh1c2VyLWVycm9yICJObyBwcmV2aW91cyBwYWdlIikpCi0gIChld3ctc2F2ZS1oaXN0 b3J5KQotICAoc2V0cSBld3ctaGlzdG9yeS1wb3NpdGlvbiAoKyBld3ctaGlzdG9yeS1wb3Np dGlvbiAyKSkKKyAgKGlmIChld3ctc2F2ZS1oaXN0b3J5KQorICAgICAgOzsgV2Ugd2VyZSBh dCB0aGUgbGF0ZXN0IHBhZ2UgKHdoaWNoIHdhcyBqdXN0IGFkZGVkIHRvIHRoZQorICAgICAg OzsgaGlzdG9yeSksIHNvIGdvIGJhY2sgdHdvIGVudHJpZXMuCisgICAgICAoc2V0cSBld3ct aGlzdG9yeS1wb3NpdGlvbiAyKQorICAgIChzZXRxIGV3dy1oaXN0b3J5LXBvc2l0aW9uICgx KyBld3ctaGlzdG9yeS1wb3NpdGlvbikpKQogICAoZXd3LXJlc3RvcmUtaGlzdG9yeSAoZWx0 IGV3dy1oaXN0b3J5ICgxLSBld3ctaGlzdG9yeS1wb3NpdGlvbikpKSkKIAogKGRlZnVuIGV3 dy1mb3J3YXJkLXVybCAoKQogICAiR28gdG8gdGhlIG5leHQgZGlzcGxheWVkIHBhZ2UuIgog ICAoaW50ZXJhY3RpdmUgbmlsIGV3dy1tb2RlKQotICAod2hlbiAoemVyb3AgZXd3LWhpc3Rv cnktcG9zaXRpb24pCisgICh3aGVuICg8PSBld3ctaGlzdG9yeS1wb3NpdGlvbiAxKQogICAg ICh1c2VyLWVycm9yICJObyBuZXh0IHBhZ2UiKSkKICAgKGV3dy1zYXZlLWhpc3RvcnkpCisg IChzZXRxIGV3dy1oaXN0b3J5LXBvc2l0aW9uICgxLSBld3ctaGlzdG9yeS1wb3NpdGlvbikp CiAgIChld3ctcmVzdG9yZS1oaXN0b3J5IChlbHQgZXd3LWhpc3RvcnkgKDEtIGV3dy1oaXN0 b3J5LXBvc2l0aW9uKSkpKQogCiAoZGVmdW4gZXd3LXJlc3RvcmUtaGlzdG9yeSAoZWxlbSkK QEAgLTE5NTksNiArMTk4MCw3IEBAIGV3dy1mb2xsb3ctbGluawogCSAgIChld3ctc2FtZS1w YWdlLXAgdXJsIChwbGlzdC1nZXQgZXd3LWRhdGEgOnVybCkpKQogICAgICAgKGxldCAoKHBv aW50IChwb2ludCkpKQogCShld3ctc2F2ZS1oaXN0b3J5KQorICAgICAgICAoZXd3LS1iZWZv cmUtYnJvd3NlKQogCShwbGlzdC1wdXQgZXd3LWRhdGEgOnVybCB1cmwpCiAgICAgICAgIChn b3RvLWNoYXIgKHBvaW50LW1pbikpCiAgICAgICAgIChpZi1sZXQgKChtYXRjaCAodGV4dC1w cm9wZXJ0eS1zZWFyY2gtZm9yd2FyZCAnc2hyLXRhcmdldC1pZCB0YXJnZXQgIydtZW1iZXIp KSkKQEAgLTIyODksMTEgKzIzMTEsNDkgQEAgZXd3LWJvb2ttYXJrLW1vZGUKIDs7OyBIaXN0 b3J5IGNvZGUKIAogKGRlZnVuIGV3dy1zYXZlLWhpc3RvcnkgKCkKKyAgIlNhdmUgdGhlIGN1 cnJlbnQgcGFnZSdzIGRhdGEgdG8gdGhlIGhpc3RvcnkuCitJZiB0aGUgY3VycmVudCBwYWdl IGlzIGEgaGlzdG9yaWFsIG9uZSBsb2FkZWQgZnJvbQorYGV3dy1oaXN0b3J5JyAoZS5nLiBi eSBjYWxsaW5nIGBld3ctYmFjay11cmwnKSwgdGhpcyB3aWxsIHVwZGF0ZSB0aGUKK3BhZ2Un cyBlbnRyeSBpbiBgZXd3LWhpc3RvcnknIGFuZCByZXR1cm4gbmlsLiAgT3RoZXJ3aXNlLCBh ZGQgYSBuZXcKK2VudHJ5IHRvIGBld3ctaGlzdG9yeScgYW5kIHJldHVybiB0LiIKICAgKHBs aXN0LXB1dCBld3ctZGF0YSA6cG9pbnQgKHBvaW50KSkKICAgKHBsaXN0LXB1dCBld3ctZGF0 YSA6dGV4dCAoYnVmZmVyLXN0cmluZykpCi0gIChsZXQgKChoaXN0b3J5LWRlbGV0ZS1kdXBs aWNhdGVzIG5pbCkpCi0gICAgKGFkZC10by1oaXN0b3J5ICdld3ctaGlzdG9yeSBld3ctZGF0 YSBld3ctaGlzdG9yeS1saW1pdCB0KSkKLSAgKHNldHEgZXd3LWRhdGEgKGxpc3QgOnRpdGxl ICIiKSkpCisgIChpZiAoemVyb3AgZXd3LWhpc3RvcnktcG9zaXRpb24pCisgICAgICAobGV0 ICgoaGlzdG9yeS1kZWxldGUtZHVwbGljYXRlcyBuaWwpKQorICAgICAgICAoYWRkLXRvLWhp c3RvcnkgJ2V3dy1oaXN0b3J5IGV3dy1kYXRhIGV3dy1oaXN0b3J5LWxpbWl0IHQpCisgICAg ICAgIChzZXRxIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDEpCisgICAgICAgIHQpCisgICAgKHNl dGYgKGVsdCBld3ctaGlzdG9yeSAoMS0gZXd3LWhpc3RvcnktcG9zaXRpb24pKSBld3ctZGF0 YSkKKyAgICBuaWwpKQorCisoZGVmdW4gZXd3LWNsZWFyLWZ1dHVyZS1oaXN0b3J5ICgpCisg ICJSZW1vdmUgYW55IGVudHJpZXMgaW4gYGV3dy1oaXN0b3J5JyBhZnRlciB0aGUgY3VycmVu dGx5LXNob3duIG9uZS4KK1RoaXMgaXMgdXNlZnVsIGZvciBgZXd3LWJlZm9yZS1icm93c2Ut ZnVuY3Rpb24nIHRvIG1ha2UgRVdXJ3MgbmF2aWdhdGlvbgordG8gYSBuZXcgcGFnZSBmcm9t IGEgaGlzdG9yaWNhbCBvbmUgd29yayBsaWtlIG90aGVyIHdlYiBicm93c2VyczogaXQKK3dp bGwgY2xlYXIgYW55IFwiZnV0dXJlXCIgaGlzdG9yeSBlbGVtZW50cyBiZWZvcmUgYWRkaW5n IHRoZSBuZXcgcGFnZSB0bwordGhlIGVuZCBvZiB0aGUgaGlzdG9yeS4iCisgICh3aGVuICg+ IGV3dy1oaXN0b3J5LXBvc2l0aW9uIDEpCisgICAgKHNldHEgZXd3LWhpc3RvcnkgKG50aGNk ciAoMS0gZXd3LWhpc3RvcnktcG9zaXRpb24pIGV3dy1oaXN0b3J5KSkpKQorCisoZGVmdW4g ZXd3LWNsb25lLXByZXZpb3VzLWhpc3RvcnkgKCkKKyAgIkNsb25lIGFuZCBwcmVwZW5kIGVu dHJpZXMgaW4gYGV3dy1oaXN0b3J5JyB1cCB0byB0aGUgY3VycmVudGx5LXNob3duIG9uZS4K K1RoZXNlIGNsb25lZCBlbnRyaWVzIGdldCBhZGRlZCB0byB0aGUgYmVnaW5uaW5nIG9mIGBl d3ctaGlzdG9yeScgc28gdGhhdAoraXQncyBwb3NzaWJsZSB0byBuYXZpZ2F0ZSBiYWNrIHRv IHRoZSB2ZXJ5IGZpcnN0IHBhZ2UgZm9yIHRoaXMgRVdXCit3aXRob3V0IGRlbGV0aW5nIGFu eSBoaXN0b3J5IGVudHJpZXMuCisKK0ZvciBleGFtcGxlLCBpZiBgZXd3LWhpc3RvcnknIGxv b2tzIGxpa2UgdGhpcyAoZ29pbmcgZnJvbSBvbGRlc3QgdG8KK25ld2VzdCwgd2l0aCBcIipc IiBtYXJraW5nIHRoZSBjdXJyZW50IHBhZ2UpOgorCisgIEEgQiBDKiBEIEUKKwordGhlbiBj YWxsaW5nIHRoaXMgZnVuY3Rpb24gdXBkYXRlcyBgZXd3LWhpc3RvcnknIHRvOgorCisgIEEg QiBDIEQgRSBBIEIgQyoKKworVGhpcyBpcyB1c2VmdWwgZm9yIHNldHRpbmcgYGV3dy1iZWZv cmUtYnJvd3NlLWZ1bmN0aW9uJyAod2hpY2ggc2VlKS4iCisgICh3aGVuICg+IGV3dy1oaXN0 b3J5LXBvc2l0aW9uIDEpCisgICAgKHNldHEgZXd3LWhpc3RvcnkgKGFwcGVuZCAobnRoY2Ry ICgxLSBld3ctaGlzdG9yeS1wb3NpdGlvbikgZXd3LWhpc3RvcnkpCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBld3ctaGlzdG9yeSkpKSkKIAogKGRlZnZhciBld3ctY3VycmVu dC1idWZmZXIpCiAKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9uZXQvZXd3LXRlc3RzLmVsIGIv dGVzdC9saXNwL25ldC9ld3ctdGVzdHMuZWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAuLjhlMDU2NTIxZmM3Ci0tLSAvZGV2L251bGwKKysrIGIvdGVzdC9saXNw L25ldC9ld3ctdGVzdHMuZWwKQEAgLTAsMCArMSwxNzkgQEAKKzs7OyBld3ctdGVzdHMuZWwg LS0tIHRlc3RzIGZvciBld3cuZWwgIC0qLSBsZXhpY2FsLWJpbmRpbmc6IHQ7IC0qLQorCis7 OyBDb3B5cmlnaHQgKEMpIDIwMjQgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCisK Kzs7IFRoaXMgZmlsZSBpcyBwYXJ0IG9mIEdOVSBFbWFjcy4KKworOzsgR05VIEVtYWNzIGlz IGZyZWUgc29mdHdhcmU6IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vciBtb2RpZnkK Kzs7IGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEdlbmVyYWwgUHVibGljIExpY2Vu c2UgYXMgcHVibGlzaGVkIGJ5Cis7OyB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBl aXRoZXIgdmVyc2lvbiAzIG9mIHRoZSBMaWNlbnNlLCBvcgorOzsgKGF0IHlvdXIgb3B0aW9u KSBhbnkgbGF0ZXIgdmVyc2lvbi4KKworOzsgR05VIEVtYWNzIGlzIGRpc3RyaWJ1dGVkIGlu IHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCis7OyBidXQgV0lUSE9VVCBBTlkg V0FSUkFOVFk7IHdpdGhvdXQgZXZlbiB0aGUgaW1wbGllZCB3YXJyYW50eSBvZgorOzsgTUVS Q0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2Vl IHRoZQorOzsgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9yIG1vcmUgZGV0YWlscy4K KworOzsgWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05VIEdlbmVy YWwgUHVibGljIExpY2Vuc2UKKzs7IGFsb25nIHdpdGggR05VIEVtYWNzLiAgSWYgbm90LCBz ZWUgPGh0dHBzOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4KKworOzs7IENvbW1lbnRhcnk6 CisKKzs7OyBDb2RlOgorCisocmVxdWlyZSAnZXJ0KQorKHJlcXVpcmUgJ2V3dykKKworKGRl ZnZhciBld3ctdGVzdC0tcmVzcG9uc2UtZnVuY3Rpb24gKGxhbWJkYSAodXJsKSAoY29uY2F0 ICJcbiIgdXJsKSkKKyAgIkEgZnVuY3Rpb24gZm9yIHJldHVybmluZyBhIG1vY2sgcmVzcG9u c2UgZm9yIFVSTC4KK1RoZSBkZWZhdWx0IGp1c3QgcmV0dXJucyBhbiBlbXB0eSBsaXN0IG9m IGhlYWRlcnMgVVJMIGFzIHRoZSBib2R5LiIpCisKKyhkZWZtYWNybyBld3ctdGVzdC0td2l0 aC1tb2NrLXJldHJpZXZlICgmcmVzdCBib2R5KQorICAiRXZhbHVhdGUgQk9EWSB3aXRoIGEg bW9jayBpbXBsZW1lbnRhdGlvbiBvZiBgZXd3LXJldHJpZXZlJy4KK1RoaXMgYXZvaWRzIG5l dHdvcmsgcmVxdWVzdHMgZHVyaW5nIG91ciB0ZXN0cy4gIEFkZGl0aW9uYWxseSwgcHJlcGFy ZSBhCit0ZW1wb3JhcnkgRVdXIGJ1ZmZlciBmb3Igb3VyIHRlc3RzLiIKKyAgKGRlY2xhcmUg KGluZGVudCAxKSkKKyAgICBgKGNsLWxldGYgKCgoc3ltYm9sLWZ1bmN0aW9uICdld3ctcmV0 cmlldmUpCisgICAgICAgICAgICAgICAgKGxhbWJkYSAodXJsIGNhbGxiYWNrIGFyZ3MpCisg ICAgICAgICAgICAgICAgICAod2l0aC10ZW1wLWJ1ZmZlcgorICAgICAgICAgICAgICAgICAg ICAoaW5zZXJ0IChmdW5jYWxsIGV3dy10ZXN0LS1yZXNwb25zZS1mdW5jdGlvbiB1cmwpKQor ICAgICAgICAgICAgICAgICAgICAoYXBwbHkgY2FsbGJhY2sgbmlsIGFyZ3MpKSkpKQorICAg ICAgICh3aXRoLXRlbXAtYnVmZmVyCisgICAgICAgICAoZXd3LW1vZGUpCisgICAgICAgICAs QGJvZHkpKSkKKworKGRlZnVuIGV3dy10ZXN0LS1oaXN0b3J5LXVybHMgKCkKKyAgKG1hcGNh ciAobGFtYmRhIChlbGVtKSAocGxpc3QtZ2V0IGVsZW0gOnVybCkpIGV3dy1oaXN0b3J5KSkK KworOzs7IFRlc3RzOgorCisoZXJ0LWRlZnRlc3QgZXd3LXRlc3QvaGlzdG9yeS9uZXctcGFn ZSAoKQorICAiVGVzdCB0aGF0IHdoZW4gdmlzaXRpbmcgYSBuZXcgcGFnZSwgdGhlIHByZXZp b3VzIG9uZSBnb2VzIGludG8gdGhlIGhpc3RvcnkuIgorICAoZXd3LXRlc3QtLXdpdGgtbW9j ay1yZXRyaWV2ZQorICAgIChld3cgIm9uZS5pbnZhbGlkIikKKyAgICAoZXd3ICJ0d28uaW52 YWxpZCIpCisgICAgKHNob3VsZCAoZXF1YWwgKGV3dy10ZXN0LS1oaXN0b3J5LXVybHMpCisg ICAgICAgICAgICAgICAgICAgJygiaHR0cDovL29uZS5pbnZhbGlkLyIpKSkKKyAgICAoZXd3 ICJ0aHJlZS5pbnZhbGlkIikKKyAgICAoc2hvdWxkIChlcXVhbCAoZXd3LXRlc3QtLWhpc3Rv cnktdXJscykKKyAgICAgICAgICAgICAgICAgICAnKCJodHRwOi8vdHdvLmludmFsaWQvIgor ICAgICAgICAgICAgICAgICAgICAgImh0dHA6Ly9vbmUuaW52YWxpZC8iKSkpKSkKKworKGVy dC1kZWZ0ZXN0IGV3dy10ZXN0L2hpc3RvcnkvYmFjay1mb3J3YXJkICgpCisgICJUZXN0IHRo YXQgbmF2aWdhdGluZyB0aHJvdWdoIGhpc3RvcnkganVzdCBjaGFuZ2VzIG91ciBoaXN0b3J5 IHBvc2l0aW9uLgorU2VlIGJ1ZyM2OTIzMi4iCisgIChld3ctdGVzdC0td2l0aC1tb2NrLXJl dHJpZXZlCisgICAgKGV3dyAib25lLmludmFsaWQiKQorICAgIChld3cgInR3by5pbnZhbGlk IikKKyAgICAoZXd3ICJ0aHJlZS5pbnZhbGlkIikKKyAgICAobGV0ICgodXJsLWhpc3Rvcnkg JygiaHR0cDovL3RocmVlLmludmFsaWQvIgorICAgICAgICAgICAgICAgICAgICAgICAgICJo dHRwOi8vdHdvLmludmFsaWQvIgorICAgICAgICAgICAgICAgICAgICAgICAgICJodHRwOi8v b25lLmludmFsaWQvIikpKQorICAgICAgOzsgR28gYmFjayBvbmUgcGFnZS4gIFRoaXMgc2hv dWxkIGFkZCAidGhyZWUuaW52YWxpZCIgdG8gdGhlCisgICAgICA7OyBoaXN0b3J5LCBtYWtp bmcgb3VyIHBvc2l0aW9uIGluIHRoZSBsaXN0IDIuCisgICAgICAoZXd3LWJhY2stdXJsKQor ICAgICAgKHNob3VsZCAoZXF1YWwgKGV3dy10ZXN0LS1oaXN0b3J5LXVybHMpIHVybC1oaXN0 b3J5KSkKKyAgICAgIChzaG91bGQgKD0gZXd3LWhpc3RvcnktcG9zaXRpb24gMikpCisgICAg ICA7OyBHbyBiYWNrIGFnYWluLgorICAgICAgKGV3dy1iYWNrLXVybCkKKyAgICAgIChzaG91 bGQgKGVxdWFsIChld3ctdGVzdC0taGlzdG9yeS11cmxzKSB1cmwtaGlzdG9yeSkpCisgICAg ICAoc2hvdWxkICg9IGV3dy1oaXN0b3J5LXBvc2l0aW9uIDMpKQorICAgICAgOzsgQXQgdGhl IGJlZ2lubmluZyBvZiB0aGUgaGlzdG9yeSwgc28gdHJ5aW5nIHRvIGdvIGJhY2sgc2hvdWxk CisgICAgICA7OyBzaWduYWwgYW4gZXJyb3IuCisgICAgICAoc2hvdWxkLWVycm9yIChld3ct YmFjay11cmwpKQorICAgICAgOzsgR28gZm9yd2FyZCBvbmNlLgorICAgICAgKGV3dy1mb3J3 YXJkLXVybCkKKyAgICAgIChzaG91bGQgKGVxdWFsIChld3ctdGVzdC0taGlzdG9yeS11cmxz KSB1cmwtaGlzdG9yeSkpCisgICAgICAoc2hvdWxkICg9IGV3dy1oaXN0b3J5LXBvc2l0aW9u IDIpKQorICAgICAgOzsgR28gZm9yd2FyZCBhZ2Fpbi4KKyAgICAgIChld3ctZm9yd2FyZC11 cmwpCisgICAgICAoc2hvdWxkIChlcXVhbCAoZXd3LXRlc3QtLWhpc3RvcnktdXJscykgdXJs LWhpc3RvcnkpKQorICAgICAgKHNob3VsZCAoPSBld3ctaGlzdG9yeS1wb3NpdGlvbiAxKSkK KyAgICAgIDs7IEF0IHRoZSBlbmQgb2YgdGhlIGhpc3RvcnksIHNvIHRyeWluZyB0byBnbyBm b3J3YXJkIHNob3VsZAorICAgICAgOzsgc2lnbmFsIGFuIGVycm9yLgorICAgICAgKHNob3Vs ZC1lcnJvciAoZXd3LWZvcndhcmQtdXJsKSkpKSkKKworKGVydC1kZWZ0ZXN0IGV3dy10ZXN0 L2hpc3RvcnkvcmVsb2FkLWluLXBsYWNlICgpCisgICJUZXN0IHRoYXQgcmVsb2FkaW5nIGhp c3RvcmljYWwgcGFnZXMgdXBkYXRlcyB0aGVpciBoaXN0b3J5IGVudHJ5IGluLXBsYWNlLgor U2VlIGJ1ZyM2OTIzMi4iCisgIChld3ctdGVzdC0td2l0aC1tb2NrLXJldHJpZXZlCisgICAg KGV3dyAib25lLmludmFsaWQiKQorICAgIChld3cgInR3by5pbnZhbGlkIikKKyAgICAoZXd3 ICJ0aHJlZS5pbnZhbGlkIikKKyAgICAoZXd3LWJhY2stdXJsKQorICAgIDs7IE1ha2Ugc3Vy ZSBvdXIgaGlzdG9yeSBoYXMgdGhlIG9yaWdpbmFsIHBhZ2UgdGV4dC4KKyAgICAoc2hvdWxk IChlcXVhbCAocGxpc3QtZ2V0IChudGggMSBld3ctaGlzdG9yeSkgOnRleHQpCisgICAgICAg ICAgICAgICAgICAgImh0dHA6Ly90d28uaW52YWxpZC8iKSkKKyAgICAoc2hvdWxkICg9IGV3 dy1oaXN0b3J5LXBvc2l0aW9uIDIpKQorICAgIDs7IFJlbG9hZCB0aGUgcGFnZS4KKyAgICAo bGV0ICgoZXd3LXRlc3QtLXJlc3BvbnNlLWZ1bmN0aW9uCisgICAgICAgICAgIChsYW1iZGEg KHVybCkgKGNvbmNhdCAiXG5yZWxvYWRlZCAiIHVybCkpKSkKKyAgICAgIChld3ctcmVsb2Fk KQorICAgICAgKHNob3VsZCAoPSBld3ctaGlzdG9yeS1wb3NpdGlvbiAyKSkpCisgICAgOzsg R28gdG8gYW5vdGhlciBwYWdlLCBhbmQgbWFrZSBzdXJlIHRoZSBoaXN0b3J5IGlzIGNvcnJl Y3QsCisgICAgOzsgaW5jbHVkaW5nIHRoZSByZWxvYWRlZCBwYWdlIHRleHQuCisgICAgKGV3 dyAiZm91ci5pbnZhbGlkIikKKyAgICAoc2hvdWxkIChlcXVhbCAoZXd3LXRlc3QtLWhpc3Rv cnktdXJscykgJygiaHR0cDovL3R3by5pbnZhbGlkLyIKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAiaHR0cDovL29uZS5pbnZhbGlkLyIpKSkKKyAg ICAoc2hvdWxkIChlcXVhbCAocGxpc3QtZ2V0IChudGggMCBld3ctaGlzdG9yeSkgOnRleHQp CisgICAgICAgICAgICAgICAgICAgInJlbG9hZGVkIGh0dHA6Ly90d28uaW52YWxpZC8iKSkK KyAgICAoc2hvdWxkICg9IGV3dy1oaXN0b3J5LXBvc2l0aW9uIDApKSkpCisKKyhlcnQtZGVm dGVzdCBld3ctdGVzdC9oaXN0b3J5L2JlZm9yZS1uYXZpZ2F0ZS9jbGVhci1mdXR1cmUtaGlz dG9yeSAoKQorICAiVGVzdCB0aGF0IGdvaW5nIHRvIGEgbmV3IHBhZ2UgZnJvbSBhIGhpc3Rv cmljYWwgb25lIGNsZWFycyBmdXR1cmUgaGlzdG9yeS4KK1NlZSBidWcjNjkyMzIuIgorICAo ZXd3LXRlc3QtLXdpdGgtbW9jay1yZXRyaWV2ZQorICAgIChld3cgIm9uZS5pbnZhbGlkIikK KyAgICAoZXd3ICJ0d28uaW52YWxpZCIpCisgICAgKGV3dyAidGhyZWUuaW52YWxpZCIpCisg ICAgKGV3dy1iYWNrLXVybCkKKyAgICAoZXd3ICJmb3VyLmludmFsaWQiKQorICAgIChld3cg ImZpdmUuaW52YWxpZCIpCisgICAgKHNob3VsZCAoZXF1YWwgKGV3dy10ZXN0LS1oaXN0b3J5 LXVybHMpICcoImh0dHA6Ly9mb3VyLmludmFsaWQvIgorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICJodHRwOi8vdHdvLmludmFsaWQvIgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJodHRwOi8vb25lLmlu dmFsaWQvIikpKQorICAgIChzaG91bGQgKD0gZXd3LWhpc3RvcnktcG9zaXRpb24gMCkpKSkK KworKGVydC1kZWZ0ZXN0IGV3dy10ZXN0L2hpc3RvcnkvYmVmb3JlLW5hdmlnYXRlL2lnbm9y ZS1oaXN0b3J5ICgpCisgICJUZXN0IHRoYXQgZ29pbmcgdG8gYSBuZXcgcGFnZSBmcm9tIGEg aGlzdG9yaWNhbCBvbmUgcHJlc2VydmVzIGhpc3RvcnkuCitUaGlzIHNldHMgYGV3dy1iZWZv cmUtYnJvd3NlLWZ1bmN0aW9uJyB0byBgaWdub3JlJyB0byBwcmVzZXJ2ZSBoaXN0b3J5Lgor U2VlIGJ1ZyM2OTIzMi4iCisgIChsZXQgKChld3ctYmVmb3JlLWJyb3dzZS1mdW5jdGlvbiAj J2lnbm9yZSkpCisgICAgKGV3dy10ZXN0LS13aXRoLW1vY2stcmV0cmlldmUKKyAgICAgIChl d3cgIm9uZS5pbnZhbGlkIikKKyAgICAgIChld3cgInR3by5pbnZhbGlkIikKKyAgICAgIChl d3cgInRocmVlLmludmFsaWQiKQorICAgICAgKGV3dy1iYWNrLXVybCkKKyAgICAgIChld3cg ImZvdXIuaW52YWxpZCIpCisgICAgICAoZXd3ICJmaXZlLmludmFsaWQiKQorICAgICAgKHNo b3VsZCAoZXF1YWwgKGV3dy10ZXN0LS1oaXN0b3J5LXVybHMpICcoImh0dHA6Ly9mb3VyLmlu dmFsaWQvIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgImh0dHA6Ly90aHJlZS5pbnZhbGlkLyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICJodHRwOi8vdHdvLmludmFsaWQvIgorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImh0dHA6Ly9vbmUuaW52 YWxpZC8iKSkpCisgICAgICAoc2hvdWxkICg9IGV3dy1oaXN0b3J5LXBvc2l0aW9uIDApKSkp KQorCisoZXJ0LWRlZnRlc3QgZXd3LXRlc3QvaGlzdG9yeS9iZWZvcmUtbmF2aWdhdGUvY2xv bmUtcHJldmlvdXMgKCkKKyAgIlRlc3QgdGhhdCBnb2luZyB0byBhIG5ldyBwYWdlIGZyb20g YSBoaXN0b3JpY2FsIG9uZSBjbG9uZXMgcHJpb3IgaGlzdG9yeS4KK1RoaXMgc2V0cyBgZXd3 LWJlZm9yZS1icm93c2UtZnVuY3Rpb24nIHRvIGBld3ctY2xvbmUtcHJldmlvdXMtaGlzdG9y eScKK3RvIGNsb25lIHRoZSBoaXN0b3J5LiAgU2VlIGJ1ZyM2OTIzMi4iCisgIChsZXQgKChl d3ctYmVmb3JlLWJyb3dzZS1mdW5jdGlvbiAjJ2V3dy1jbG9uZS1wcmV2aW91cy1oaXN0b3J5 KSkKKyAgICAoZXd3LXRlc3QtLXdpdGgtbW9jay1yZXRyaWV2ZQorICAgICAgKGV3dyAib25l LmludmFsaWQiKQorICAgICAgKGV3dyAidHdvLmludmFsaWQiKQorICAgICAgKGV3dyAidGhy ZWUuaW52YWxpZCIpCisgICAgICAoZXd3LWJhY2stdXJsKQorICAgICAgKGV3dyAiZm91ci5p bnZhbGlkIikKKyAgICAgIChld3cgImZpdmUuaW52YWxpZCIpCisgICAgICAoc2hvdWxkIChl cXVhbCAoZXd3LXRlc3QtLWhpc3RvcnktdXJscykKKyAgICAgICAgICAgICAgICAgICAgICco OzsgTmV3IHBhZ2UgYW5kIGNsb25lZCBoaXN0b3J5LgorICAgICAgICAgICAgICAgICAgICAg ICAiaHR0cDovL2ZvdXIuaW52YWxpZC8iCisgICAgICAgICAgICAgICAgICAgICAgICJodHRw Oi8vdHdvLmludmFsaWQvIgorICAgICAgICAgICAgICAgICAgICAgICAiaHR0cDovL29uZS5p bnZhbGlkLyIKKyAgICAgICAgICAgICAgICAgICAgICAgOzsgT3JpZ2luYWwgaGlzdG9yeS4K KyAgICAgICAgICAgICAgICAgICAgICAgImh0dHA6Ly90aHJlZS5pbnZhbGlkLyIKKyAgICAg ICAgICAgICAgICAgICAgICAgImh0dHA6Ly90d28uaW52YWxpZC8iCisgICAgICAgICAgICAg ICAgICAgICAgICJodHRwOi8vb25lLmludmFsaWQvIikpKQorICAgICAgKHNob3VsZCAoPSBl d3ctaGlzdG9yeS1wb3NpdGlvbiAwKSkpKSkKKworKHByb3ZpZGUgJ2V3dy10ZXN0cykKKzs7 IGV3dy10ZXN0cy5lbCBlbmRzIGhlcmUKLS0gCjIuMjUuMQoK --------------gG00H1G0ERRREejvIFo9gNZR-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 01 02:27:20 2024 Received: (at 69232) by debbugs.gnu.org; 1 Mar 2024 07:27:20 +0000 Received: from localhost ([127.0.0.1]:35959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfxIe-0008P9-AG for submit@debbugs.gnu.org; Fri, 01 Mar 2024 02:27:20 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfxIb-0008Ou-A8 for 69232@debbugs.gnu.org; Fri, 01 Mar 2024 02:27:18 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rfxI3-00079Z-S8; Fri, 01 Mar 2024 02:26:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=g1PV7XqqeXNOTeQL5YwkHcIzuyfcpKGf/MgcIXG3U38=; b=i3b7Zj8ds8Gh aqdCAf5iRxNQorFgiAhGMiD5oyzgv0mEJ5F1lcBsEI7kc3ReUt8f6M5qw4beOvFUrMw9fmp7oXsBi 9TdO1aCqf4Y8uQZ/qvI0nddWMJrSwLDovQxQUPBtr+/T8+KohuYU3LfK5M8bWn3jU/EjVIB04SvpN Fnq9WqffxYW45Gdca6+tWq9AwciE1eXwKKIXVwV2V3kDLjVj1kjnTTXDYok4RIANn208P1gYk2Wmn 72K+Fi4fRaD9xUI4F0r7HVKd8aUI5gAWKOWLnxF8sxbmZK86JwwO/68yGFtjK1zjz7OZBCurX1kWU usF/nHAt4fYu2jHgLwTDTQ==; Date: Fri, 01 Mar 2024 09:26:41 +0200 Message-Id: <86wmqmquoe.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <99e36690-ffbe-f373-50d2-32c92717a560@gmail.com> (message from Jim Porter on Thu, 29 Feb 2024 18:10:19 -0800) Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> <86plwfsqey.fsf@gnu.org> <77426857-4d81-29da-9b1a-70931393215e@gmail.com> <878r32u9ut.fsf@gmx.net> <99e36690-ffbe-f373-50d2-32c92717a560@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 29 Feb 2024 18:10:19 -0800 > From: Jim Porter > Cc: Eli Zaretskii , 69232@debbugs.gnu.org > > On 2/29/2024 5:00 PM, Jim Porter wrote: > > I already found one issue with reloading messing up history, but that > > was an easy fix. Once I finish up the other parts of my v3 patch, I'll > > post it here. > > I've only lightly tested this so far, but this version adds an > 'eww-before-browse-function' option which lets you customize how EWW > manipulates history before browsing to a new page. I've added functions > for the default behavior ('eww-clear-future-history'), and for cloning > all the "parent" entries ('eww-clone-previous-history')[1]. You can also > set it to 'ignore', which will just preserve the old entries and add the > new page to the end (which is the behavior v1 of my patch had). > > I've also added more regression tests to make sure this all works as > expected. > > How does this look? Thanks. I have a usability comment below. > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -1004,6 +1004,18 @@ When invoked with the prefix argument ('C-u'), > This is useful for continuing reading the URL in the current buffer > when the new URL is fetched. > > +--- > +*** History navigation in EWW now works like other browsers. > +Previously, when navigating back and forward through page history, EWW > +would add a duplicate entry to the end of the history list each time. > +This made it impossible to navigate to the "end" of the history list. > +Now, navigating through history in EWW simply changes your position in > +the history list, allowing you to reach the end as expected. In > +addition, when navigating to a new page from a historical one, EWW "historical" here should be in quotes (and perhaps explained in parentheses), otherwise people might misinterpret or fail to understand what it alludes to. > +(defcustom eww-before-browse-function #'eww-clear-future-history > + "A function to call before browsing to a new page. > +By default, this removes any entries in the history that come after the > +current page (see `eww-clear-future-history')." The doc string should describe the known possible values of the option. Now for the usability issue: It's okay to have this is a variable (to allow future extensions, which might be unrelated to history), but having a function for user option, and one that is more general than being about history traversal, is not the best ides: it makes customization harder for users who are not Lisp programmers. Therefore, I suggest a history-specific defcustom, whose possible values could be 'clear', 'clone', and 'add', and whose effect will be to call the corresponding function via eww-before-browse-function. The defcustom could also have a user-defined function value to allow additional functions, of course. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 01 03:51:20 2024 Received: (at 69232) by debbugs.gnu.org; 1 Mar 2024 08:51:20 +0000 Received: from localhost ([127.0.0.1]:36069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfybu-0002Ex-V2 for submit@debbugs.gnu.org; Fri, 01 Mar 2024 03:51:20 -0500 Received: from mout.gmx.net ([212.227.15.18]:53461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfybe-0002E3-80 for 69232@debbugs.gnu.org; Fri, 01 Mar 2024 03:51:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1709283028; x=1709887828; i=jimjoe@gmx.net; bh=Pvz2fd4kH7VrTY+87/MlfVXhraecuUSf2yTyS43Ejr4=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=e2AVU27RmKXfGE/Ug3diMFlJoJlKmKsPu4e3cz15SJXiB0vNYTZIyzZEocm9BcCZ W38+gQAaB6nY5vs5Q2Y1Mu/zJfq1B1ukWTmFmVIqBQ+K9icg/W2ulyrk6KATdbEMn wMth3w4hRymup3oVh+EkGut7jvmgQUN1UWgb4WRZi4/vEsxJrwPvCXfzBubJFEtL5 MkIQmW7fyD6uRiTjurXXcM6uQRAsnuSOMwvdCRmvbapKRc/7kay9A/PfN2x87v3Vl QZQ6wrpwid1OLtnJ7r5zhG7H17ZYNSxeG+HCUsxqLrlAWm++zZdvA3DjRZjRk8knV i+nB3q9XImTAHsrz3g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-15-5518 ([117.216.1.160]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1N9MpS-1qlp711ike-015FhP; Fri, 01 Mar 2024 09:50:27 +0100 From: James Thomas To: Jim Porter Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop In-Reply-To: <99e36690-ffbe-f373-50d2-32c92717a560@gmail.com> (Jim Porter's message of "Thu, 29 Feb 2024 18:10:19 -0800") References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> <86plwfsqey.fsf@gnu.org> <77426857-4d81-29da-9b1a-70931393215e@gmail.com> <878r32u9ut.fsf@gmx.net> <99e36690-ffbe-f373-50d2-32c92717a560@gmail.com> Date: Fri, 01 Mar 2024 14:20:23 +0530 Message-ID: <87cysee3ow.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:9+j3QQpk0sfKXkwJEo42r+bpr59h3QdhZzSc78wrXQQ1+ccYiGG VvayarKJlxbUsahLWH3VzbbV7oIp0iJs8wmbQMq6ya3Lk/fzmcsoHZ2Iu0idZjU26mh8iVb JUHnC7kjp02iw+J2PErAahQOCJ5LsEdUfrEzVPVOrUMamXKPOpWjiMGXl4imcFaB1ulP4nA JTp76i0zqwjX+X0yKoxGw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:4fvCZYlqqiM=;l8ENa4IdM+H8ZFIkv2g7bDsQ9kc NomCdabF3X2b8TgOIQYbTqh+GwnV5F3yvYKxb9TJNsyTtwSI6BSc6RuGD5LI7zk78pDUwwXl3 HZykeIm4NT3Ry5fvqBpVlK5dqApnkACSa/eVVRW8C/89SMrYeHw9du/xJvsYtVfOpb8w1RXFb BJDNMgPi2E5swC77L/o4LLg0wzNid2k5lz9Lk1GDyvfYgezLFlvR8y6QeyO2jmaMKUI70c3D2 be7JVTLJ8KpTHEOjiCWC7ohK3O/7yT6zkH0ibVV5x1iMvoshC09C+X65YUDoarvfkDOTN+MEr vaB5oC/lg2hF97fRQ7TazY1xXnU7UCrWGS9huaTimfZWwUhM8ObO7k6e1C8LyjrTcejlOrQnr CmxLMuiRly3GVut7sKY32b2oO2TiBUmxH9pEjdhtZngVv66qwCUDhPyTH9GJdjACzX6+AzvIh fSZJJhX5ZyGjzxgD1VvA6GcJORlrYg/myfSuTyl18FJgf6ctlxsQEpXSG3qodpbeCYq/YN+eD vSGVtqNOdFHGT3+TiXkNrVOG572mP2bmSHgZfmUZYmp3dZZt2NiCilQczFKf6qHwbEOBJTEEt mWThNd5sorWwPcZzx92By/cbIVhyG+8AWoubXraiRxowjzrCGVI9JyIgc5PSZEqEbLStXdXZS qeLGlipfp49svV16TrOc8rDmli7AoN6R8KuvYWfmWeEh4rODb4vRV/QOT0Ua+VsoxjRUr6mtW p5IiE7j3v6J95kyKLMSuwoF5R0LRo9RC9Za/jZrcJVHvl6YokK+NoOhy9ByAyr7/XkXD3cXFG hFWF4KhGEZDnJvhSUktqJXEqs9x6cAF+Jb4dWA/+lGIj4= X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69232 Cc: Eli Zaretskii , 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Jim Porter wrote: > On 2/29/2024 5:00 PM, Jim Porter wrote: >> I already found one issue with reloading messing up history, but >> that was an easy fix. Once I finish up the other parts of my v3 >> patch, I'll post it here. > > I've only lightly tested this so far, but this version adds an > 'eww-before-browse-function' option which lets you customize how EWW > manipulates history before browsing to a new page. I've added > functions for the default behavior ('eww-clear-future-history'), and > for cloning all the "parent" entries > ('eww-clone-previous-history')[1]. You can also set it to 'ignore', > which will just preserve the old entries and add the new page to the > end (which is the behavior v1 of my patch had). > > I've also added more regression tests to make sure this all works as > expected. > > How does this look? I'm using it with the following: --8<---------------cut here---------------start------------->8--- (defun eww-clone-previous-history-upto-first () "Like `eww-clone-previous-history', but only clone up to the first occurrence of the current page in the history." (when (> eww-history-position 1) (setq eww-history (append (cl-subseq eww-history (- 0 (cl-position-if (lambda (elt) (equal (plist-get elt :url) (eww-current-url))) eww-history :from-end) 1)) eww-history)))) (setq eww-before-browse-function #'eww-clone-previous-history-upto-first) --8<---------------cut here---------------end--------------->8--- ...for getting the behaviour I'd referred to earlier: > ... so because that might sometimes be too much, (adding to the end) > only the entire history up to the first occurrence of the source page. Will report back if I see any problems. Regards, James From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 01 06:57:37 2024 Received: (at 69232) by debbugs.gnu.org; 1 Mar 2024 11:57:37 +0000 Received: from localhost ([127.0.0.1]:36214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rg1WD-0007Oq-Bf for submit@debbugs.gnu.org; Fri, 01 Mar 2024 06:57:37 -0500 Received: from mout.gmx.net ([212.227.15.19]:52171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rg1W8-0007OW-Oi for 69232@debbugs.gnu.org; Fri, 01 Mar 2024 06:57:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1709294218; x=1709899018; i=jimjoe@gmx.net; bh=Q/SAgGlBm0nS/tb4J50xDSXyQ/XVy8Y2KRrj8B9lfMM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=NXyI/+WC1sU+viM4vLphsyhU4Ts/7sKHSfJMS4l6/4kVoHzHC7O5nt4tz5NebljN jsuVWOV+wMjsUV3A6y1zbj6QOFQGJbaFdkXp0u4F1fXhk0I7hWL1nXt7XK8If9Drq /HZDHbFQfuIVIRJ0ij1b64kHBcx3y0P3t9R2nFN3IuPP5+She6ReU5cDg7FCJS71c qJpORK3qStG/XYBt+NwTophh0wMscSsMI+76YkAgdod2nyERTqvwWBuGDcUzKFWW2 giMDwkUPJ0kyoVXCTWAY5ZWAC8f106Xofej2YI89pnUuHy3bYEo+bGqNzEgrMZgGP CTejvgD5KThU+aqJ1g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from user-Inspiron-15-5518 ([117.216.1.160]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MKbgE-1rRfW93AY0-00Kw8d; Fri, 01 Mar 2024 12:56:58 +0100 From: James Thomas To: Jim Porter Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop In-Reply-To: <87cysee3ow.fsf@gmx.net> (James Thomas's message of "Fri, 01 Mar 2024 14:20:23 +0530") References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> <86plwfsqey.fsf@gnu.org> <77426857-4d81-29da-9b1a-70931393215e@gmail.com> <878r32u9ut.fsf@gmx.net> <99e36690-ffbe-f373-50d2-32c92717a560@gmail.com> <87cysee3ow.fsf@gmx.net> Date: Fri, 01 Mar 2024 17:26:54 +0530 Message-ID: <878r32dv21.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:rB6jMikMrmGu2tDddARcXi1rxx20eHpzfbxNt7ReEA2ilXKpmSV teqUy/PQdqCEstm542z7STZ5xR7nelMf/Noym+Tz5KOLqoXVpKlWxwZktt7pa5Vm/7Fmpls +xEhbvKarcFjiZ7DlFA5FOY0D4vJb+1mop3IZZOglH7+W1YXJC+4IqS0j6jD1RIwpfVS0HT iQwD+ltg4xa2K6hrhHhJQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:1/nyUnNBR3U=;rv5oV8f2tTaZT7YZOvKwfGNzB2j xI68qJCkKlELxJM9BaNTSt+S+4NhqmBXA9x5Ma23iNZfkqF7ebh7122V7AbrAikd8+uCvrjIY ThsMcJL81kebi1kV3tCoTDIQ/ygGLHv9Y8GN29N8CKbaT/ecU5SeUYo8j1XxsBljMeQX5mEy0 NGdOe3/WrEcWK+HZ3xJPhJbTObUO+/cN5DUQT7kBIZ0tXmVGzqlw2/GgJh51f5OcnLgzmvN1N 7eZWSI9HPH+BRbK2UT1U7TU3pqV0ND7CGbPekWQRhlUnBwS1Pkc2vpIJkxeHY/uZ08IEJtea3 47qw8PjBWDtmWr4zwFylTDhvly0IzLnH3Ku35Q09dIujwE16gUU/LnvQGFRlqjd99xegXoWqa YC5QM4U05cP9JnYUkeMsFAIX2msow/Z7eXdl0qTZ3O97OPurOJwLzV9d/h6WsRgl7oLcOmQKA j5w8/kirb2l8rM2196JQS14qujFyKbrHp0gfvVXsBLvJggMXuaENF683pftTvy/lXAtG1CD9i ybxhKY0dSTKUUHMS9OXhjUQYCSAKenKcBKfxMtYAD5hc33J2qXSd8FTs2AkGKf1mKpjT6ft3a Ot6VOey3k9m44E3MfMKl0z6wDLlbArwKHzPjcQcDdqXmT7IBgH3uFktoDlOruzEPSRZgP/xGI gACPPXXGKHYrT6SzXzPiI7BardtN/fQw8/4LSV0SePVmkXVa9lCEdxO8hcCzdjygXEKV+ecLv UFqmPmqgOPfx3WkichwCRshagKH16Nt/PFPG1w9CqkaXfvUUxX1QMsQ2glAZtp3fEGp9Vf56V GQ+Z4sij1rlel6T0BE88oyMTSbA5pG/+I8kPnoeAFR9OI= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69232 Cc: Eli Zaretskii , 69232@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) James Thomas wrote: > I'm using it with the following: It had a small error; corrected version: --8<---------------cut here---------------start------------->8--- (defun eww-clone-previous-history-upto-first () "Like `eww-clone-previous-history', but only clone up to the first occurrence of the current page in the history." (when (> eww-history-position 1) (setq eww-history (append (cl-subseq eww-history (cl-position-if (lambda (elt) (equal (plist-get elt :url) (eww-current-url))) eww-history :from-end)) eww-history)))) (setq eww-before-browse-function #'eww-clone-previous-history-upto-first) --8<---------------cut here---------------end--------------->8--- Regards, James From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 01 15:14:52 2024 Received: (at 69232) by debbugs.gnu.org; 1 Mar 2024 20:14:52 +0000 Received: from localhost ([127.0.0.1]:37540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rg9HP-0006uG-D1 for submit@debbugs.gnu.org; Fri, 01 Mar 2024 15:14:52 -0500 Received: from mail-pl1-f174.google.com ([209.85.214.174]:55672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rg9HJ-0006tm-QK for 69232@debbugs.gnu.org; Fri, 01 Mar 2024 15:14:49 -0500 Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1dcd6a3da83so18952695ad.3 for <69232@debbugs.gnu.org>; Fri, 01 Mar 2024 12:14:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709323991; x=1709928791; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=s63mwJMVRZ8XPA/kYFxvQ/CLVyexw6PJQcjD55VR93g=; b=SLC6mWbRUPxPLGEUBzcGAyngtKncn8MlEtgve28TxXjDPtc0bP1P9nyGBhBFCp4N86 k3/pAGcSGOqXRXON2x9m3q4RejhKQVf8HwrMKHgj5XEYi9j/TKXdSCPge7veg7j04K3+ 64RPywe5dHrcWtz6Tg7xzY596Cn5blYitFPt/UjTyhOgjot84T69ecqnOGUl7nlVfoZh 7c4x+d8Y+e0GYtEJOSbpqB1jbfH/OZz59D5g+BbQNf+EsXoxU5xR64EK4lqelz2FvQDG 049gwcaVm2F40R0sv4D0oIebDt+q6y3XAQkrDWgpl3y8X6svXajFPwXexqXjKP5Wc+UK /P7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709323991; x=1709928791; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=s63mwJMVRZ8XPA/kYFxvQ/CLVyexw6PJQcjD55VR93g=; b=dicF40WWSb0fUplPCS/ra6F2/+iYg0C8NdKASWhjszaY9MjvtpYH67XlhZ938V92sy lRVI9iVN0QrI4i81Spv4/SjkJmiU5Ksj9BWKD0irj6+h/kTdtLEQ2GnaX9EXWuzhp2/g 0XC82BZog34ve7c2AQY3c9kpa+cSDXaZrnYbCKOC3/YqObqQeLc9lJTYpoIOq2RPQPMN 1Eg3izcJmpKJSYGvdq7KME/4NIRiZHKnYlP465sD/rnwpWqktw3Yo2gJK4zrnZ4PeCM6 RYDdQ+FQAcWZqRM9XYrFDYOrEvPS7FIYFqqE/F1MiLEJn749VKEZS4DaAe8GicjZU73g gcYw== X-Gm-Message-State: AOJu0Yy33aMwiJPdoczrzKk3zFVu8ZRUTAj9jnkhlJmNIK9PTuip3k2Y SDMcTgjfmKyDpbftOQq5LaAVPadS4WzlhfYZL8J59UWwk2Jmhh47 X-Google-Smtp-Source: AGHT+IFX6IzHt6dWZjAtXGiH7kfAI+5MUimnHnQVRhyBh/v/FnHUjZmU5VRFjIaCYjiwNSeVCtRA5w== X-Received: by 2002:a17:903:1248:b0:1dc:744f:5317 with SMTP id u8-20020a170903124800b001dc744f5317mr2646736plh.50.1709323991013; Fri, 01 Mar 2024 12:13:11 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id n4-20020a170903110400b001dc391cc28fsm3841586plh.121.2024.03.01.12.13.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Mar 2024 12:13:09 -0800 (PST) Content-Type: multipart/mixed; boundary="------------C5T9UISQ3TNjfLiF0tUzqaQw" Message-ID: Date: Fri, 1 Mar 2024 12:13:08 -0800 MIME-Version: 1.0 Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Content-Language: en-US To: Eli Zaretskii References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> <86plwfsqey.fsf@gnu.org> <77426857-4d81-29da-9b1a-70931393215e@gmail.com> <878r32u9ut.fsf@gmx.net> <99e36690-ffbe-f373-50d2-32c92717a560@gmail.com> <86wmqmquoe.fsf@gnu.org> From: Jim Porter In-Reply-To: <86wmqmquoe.fsf@gnu.org> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------C5T9UISQ3TNjfLiF0tUzqaQw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/29/2024 11:26 PM, Eli Zaretskii wrote: > Thanks. I have a usability comment below. Thanks for taking a look. > "historical" here should be in quotes (and perhaps explained in > parentheses), otherwise people might misinterpret or fail to > understand what it alludes to. Done. I've also added a short description about this to the EWW manual so that people in the future know they can tweak this behavior. >> +(defcustom eww-before-browse-function #'eww-clear-future-history >> + "A function to call before browsing to a new page. >> +By default, this removes any entries in the history that come after the >> +current page (see `eww-clear-future-history')." > > The doc string should describe the known possible values of the > option. Done. > Now for the usability issue: It's okay to have this is a variable (to > allow future extensions, which might be unrelated to history), but > having a function for user option, and one that is more general than > being about history traversal, is not the best ides: it makes > customization harder for users who are not Lisp programmers. After sleeping on this, I think I agree. I had debated whether to add something like 'eww-before-browse-hook', but then I reasoned that I really want exactly *one* of these history-modification functions to run before browsing, so I made it '...-function'. But that's not right either, since it would mess things up if someone wanted to use this as a hook (they'd need to write their own Lisp function to do everything). There might be some use in the future for 'eww-before-browse-hook', but I can't think of any off the top of my head, so I've just changed this to 'eww-before-browse-history-function'. If we want a more general hook later, we can always add it when we know more. > Therefore, I suggest a history-specific defcustom, whose possible > values could be 'clear', 'clone', and 'add', and whose effect will be > to call the corresponding function via eww-before-browse-function. > The defcustom could also have a user-defined function value to allow > additional functions, of course. I've done something close to this, though I retained the previous form where the possible values are things like 'eww-delete-future-history'. That keeps the code to *use* this option simpler (no special-case symbol names), and the only difference with your suggestion is that users who manually edit their init.el will have a longer symbol name to type. For Customize users, I added 'function-item' choices so they should just be able to click on the option they want without having to worry about the exact symbol name. If you strongly prefer to have this accept non-function symbol names like 'clear', let me know and I can change it. I don't care too much, but this way seemed simpler and easier to maintain. --------------C5T9UISQ3TNjfLiF0tUzqaQw Content-Type: text/plain; charset=UTF-8; name="0001-When-navigating-through-history-in-EWW-don-t-keep-ad.patch" Content-Disposition: attachment; filename*0="0001-When-navigating-through-history-in-EWW-don-t-keep-ad.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAxM2I5NzA5Yzc2MjgzOTY3YTBlMjczOTIyNjQxNjg1ZjQ0MDY4M2UzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFNhdCwgMTcgRmViIDIwMjQgMjA6NDk6MTUgLTA4MDAKU3ViamVjdDogW1BB VENIXSBXaGVuIG5hdmlnYXRpbmcgdGhyb3VnaCBoaXN0b3J5IGluIEVXVywgZG9uJ3Qga2Vl cCBhZGRpbmcgdG8KICdld3ctaGlzdG9yeScKClRoaXMgcmVzb2x2ZXMgYW4gaXNzdWUgd2hl cmUgbmF2aWdhdGluZyBiYWNrIGFuZCB0aGVuIGZvcndhcmQga2VwdAphZGRpbmcgbmV3IGhp c3RvcnkgZW50cmllcyBzbyB5b3UgY291bGQgbmV2ZXIgaGl0IHRoZSAiZW5kIiAoYnVnIzY5 MjMyKS4KCiogbGlzcC9uZXQvZXd3LmVsIChld3ctYmVmb3JlLWJyb3dzZS1oaXN0b3J5LWZ1 bmN0aW9uKTogTmV3IG9wdGlvbi4KKGV3dy1oaXN0b3J5LXBvc2l0aW9uKTogQWRkIGRvY3N0 cmluZy4KKGV3dy1tb2RlLW1hcCwgZXd3LWNvbnRleHQtbWVudSk6IFVzZSBjb3JyZWN0IHBy ZWRpY2F0ZXMgZm9yIHdoZW4gdG8KZW5hYmxlIGJhY2svZm9yd2FyZC4KKGV3dy1zYXZlLWhp c3RvcnkpOiBTYXZlIGhpc3RvcnkgZW50cnkgaW4gaXRzIG9yaWdpbmFsIHBsYWNlIHdoZW4K dmlld2luZyBhIGhpc3RvcmljYWwgcGFnZS4KKGV3dy0tYmVmb3JlLWJyb3dzZSk6IE5ldyBm dW5jdGlvbi4uLgooZXd3LCBld3ctZm9sbG93LWxpbmssIGV3dy1yZWFkYWJsZSk6IC4uLiBj YWxsIGl0LgooZXd3LXJlbmRlcik6IERvbid0IHNldCAnZXd3LWhpc3RvcnktcG9zaXRpb24n IGhlcmUuLi4KKGV3dy0tYmVmb3JlLWJyb3dzZSk6IC4uLiBpbnN0ZWFkLCBzZXQgaXQgaGVy ZS4KKGV3dy1iYWNrLXVybCk6IFNldCAnZXd3LWhpc3RvcnktcG9zaXRpb24nIGJhc2VkIG9u IHRoZSByZXN1bHQgb2YKJ2V3dy1zYXZlLWhpc3RvcnknLgooZXd3LWZvcndhcmQtdXJsKTog U2V0ICdld3ctaGlzdG9yeS1wb3NpdGlvbicgZGlyZWN0bHksIHNpbmNlCidld3ctc2F2ZS1o aXN0b3J5JyBubyBsb25nZXIgYWRkcyBhIG5ldyBlbnRyeSBpbiB0aGlzIGNhc2UuCihld3ct ZGVsZXRlLWZ1dHVyZS1oaXN0b3J5LCBld3ctY2xvbmUtcHJldmlvdXMtaGlzdG9yeSk6IE5l dyBmdW5jdGlvbnMuCgoqIHRlc3QvbGlzcC9uZXQvZXd3LXRlc3RzLmVsOiBOZXcgZmlsZS4K CiogZXRjL05FV1M6IEFubm91bmNlIHRoaXMgY2hhbmdlLgotLS0KIGRvYy9taXNjL2V3dy50 ZXhpICAgICAgICAgIHwgICA5ICsrCiBldGMvTkVXUyAgICAgICAgICAgICAgICAgICB8ICAx MyArKysKIGxpc3AvbmV0L2V3dy5lbCAgICAgICAgICAgIHwgMTIzICsrKysrKysrKysrKysr KysrKysrKystLS0KIHRlc3QvbGlzcC9uZXQvZXd3LXRlc3RzLmVsIHwgMTc5ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDQgZmlsZXMgY2hhbmdlZCwgMzEyIGlu c2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IHRlc3Qv bGlzcC9uZXQvZXd3LXRlc3RzLmVsCgpkaWZmIC0tZ2l0IGEvZG9jL21pc2MvZXd3LnRleGkg Yi9kb2MvbWlzYy9ld3cudGV4aQppbmRleCA1ZTY5YjExZDM0Ny4uZDMxZmNmMTgwMmIgMTAw NjQ0Ci0tLSBhL2RvYy9taXNjL2V3dy50ZXhpCisrKyBiL2RvYy9taXNjL2V3dy50ZXhpCkBA IC0xOTIsNiArMTkyLDE1IEBAIEJhc2ljcwogYnVmZmVyIEBmaWxleypld3cgaGlzdG9yeSp9 LiAgVGhlIGhpc3RvcnkgaXMgbG9zdCB3aGVuIEVXVyBpcyBxdWl0LgogSWYgeW91IHdhbnQg dG8gcmVtZW1iZXIgd2Vic2l0ZXMgeW91IGNhbiB1c2UgYm9va21hcmtzLgogCitAdmluZGV4 IGV3dy1iZWZvcmUtYnJvd3NlLWhpc3RvcnktZnVuY3Rpb24KKyAgQnkgZGVmYXVsdCwgd2hl biBicm93c2luZyB0byBhIG5ldyBwYWdlIGZyb20gYSBgYGhpc3RvcmljYWwnJyBvbmUKKyhp LmUuQDogYSBwYWdlIGxvYWRlZCBieSBuYXZpZ2F0aW5nIGJhY2sgdmlhIEBjb2Rle2V3dy1i YWNrLXVybH0pLCBFV1cKK3dpbGwgZmlyc3QgZGVsZXRlIGFueSBoaXN0b3J5IGVudHJpZXMg bmV3ZXIgdGhhbiB0aGUgY3VycmVudCBwYWdlLiAgVGhpcworaXMgdGhlIHNhbWUgYmVoYXZp b3IgYXMgbW9zdCBvdGhlciB3ZWIgYnJvd3NlcnMuICBZb3UgY2FuIGNoYW5nZSB0aGlzIGJ5 CitjdXN0b21pemluZyBAY29kZXtld3ctYmVmb3JlLWJyb3dzZS1oaXN0b3J5LWZ1bmN0aW9u fSB0byBhbm90aGVyIHZhbHVlLgorRm9yIGV4YW1wbGUsIHNldHRpbmcgaXQgdG8gQGNvZGV7 aWdub3JlfSB3aWxsIHByZXNlcnZlIHRoZSBleGlzdGluZworaGlzdG9yeSBlbnRyaWVzIGFu ZCBzaW1wbHkgcHJlcGVuZCB0aGUgbmV3IHBhZ2UgdG8gdGhlIGhpc3RvcnkgbGlzdC4KKwog QHZpbmRleCBld3ctaGlzdG9yeS1saW1pdAogICBBbG9uZyB3aXRoIHRoZSBVUkxzIHZpc2l0 ZWQsIEVXVyBhbHNvIHJlbWVtYmVycyBib3RoIHRoZSByZW5kZXJlZAogcGFnZSAoYXMgaXQg YXBwZWFycyBpbiB0aGUgYnVmZmVyKSBhbmQgaXRzIHNvdXJjZS4gIFRoaXMgY2FuIHRha2Ug YQpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCA2ZDQ0NGRhZjE1Mi4u N2U4MGY4M2QyMzEgMTAwNjQ0Ci0tLSBhL2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC0x MDA0LDYgKzEwMDQsMTkgQEAgV2hlbiBpbnZva2VkIHdpdGggdGhlIHByZWZpeCBhcmd1bWVu dCAoJ0MtdScpLAogVGhpcyBpcyB1c2VmdWwgZm9yIGNvbnRpbnVpbmcgcmVhZGluZyB0aGUg VVJMIGluIHRoZSBjdXJyZW50IGJ1ZmZlcgogd2hlbiB0aGUgbmV3IFVSTCBpcyBmZXRjaGVk LgogCistLS0KKyoqKiBIaXN0b3J5IG5hdmlnYXRpb24gaW4gRVdXIG5vdyB3b3JrcyBsaWtl IG90aGVyIGJyb3dzZXJzLgorUHJldmlvdXNseSwgd2hlbiBuYXZpZ2F0aW5nIGJhY2sgYW5k IGZvcndhcmQgdGhyb3VnaCBwYWdlIGhpc3RvcnksIEVXVword291bGQgYWRkIGEgZHVwbGlj YXRlIGVudHJ5IHRvIHRoZSBlbmQgb2YgdGhlIGhpc3RvcnkgbGlzdCBlYWNoIHRpbWUuCitU aGlzIG1hZGUgaXQgaW1wb3NzaWJsZSB0byBuYXZpZ2F0ZSB0byB0aGUgImVuZCIgb2YgdGhl IGhpc3RvcnkgbGlzdC4KK05vdywgbmF2aWdhdGluZyB0aHJvdWdoIGhpc3RvcnkgaW4gRVdX IHNpbXBseSBjaGFuZ2VzIHlvdXIgcG9zaXRpb24gaW4KK3RoZSBoaXN0b3J5IGxpc3QsIGFs bG93aW5nIHlvdSB0byByZWFjaCB0aGUgZW5kIGFzIGV4cGVjdGVkLiAgSW4KK2FkZGl0aW9u LCB3aGVuIGJyb3dzaW5nIHRvIGEgbmV3IHBhZ2UgZnJvbSBhICJoaXN0b3JpY2FsIiBvbmUg KGkuZS4gYQorcGFnZSBsb2FkZWQgYnkgbmF2aWdhdGluZyBiYWNrIHRocm91Z2ggaGlzdG9y eSksIEVXVyBkZWxldGVzIHRoZSBoaXN0b3J5CitlbnRyaWVzIG5ld2VyIHRoYW4gdGhlIGN1 cnJlbnQgcGFnZS4gIFRvIGNoYW5nZSB0aGUgYmVoYXZpb3Igd2hlbgorYnJvd3NpbmcgZnJv bSAiaGlzdG9yaWNhbCIgcGFnZXMsIHlvdSBjYW4gY3VzdG9taXplCisnZXd3LWJlZm9yZS1i cm93c2UtaGlzdG9yeS1mdW5jdGlvbicuCisKICoqIGdvLXRzLW1vZGUKIAogKysrCmRpZmYg LS1naXQgYS9saXNwL25ldC9ld3cuZWwgYi9saXNwL25ldC9ld3cuZWwKaW5kZXggNWEyNWVl ZjllM2MuLjZlMzE2ODdmMDcxIDEwMDY0NAotLS0gYS9saXNwL25ldC9ld3cuZWwKKysrIGIv bGlzcC9uZXQvZXd3LmVsCkBAIC0xODIsNiArMTgyLDMzIEBAIGV3dy1icm93c2UtdXJsLW5l dy13aW5kb3ctaXMtdGFiCiAgICAgICAgICAgICAgICAgIChjb25zdCA6dGFnICJPcGVuIG5l dyB0YWIgd2hlbiB0YWIgYmFyIGlzIGVuYWJsZWQiIHRhYi1iYXIpCiAgICAgICAgICAgICAg ICAgIChjb25zdCA6dGFnICJOZXZlciBvcGVuIFVSTCBpbiBuZXcgdGFiIiBuaWwpKSkKIAor KGRlZmN1c3RvbSBld3ctYmVmb3JlLWJyb3dzZS1oaXN0b3J5LWZ1bmN0aW9uICMnZXd3LWRl bGV0ZS1mdXR1cmUtaGlzdG9yeQorICAiQSBmdW5jdGlvbiB0byBjYWxsIHRvIHVwZGF0ZSBo aXN0b3J5IGJlZm9yZSBicm93c2luZyB0byBhIG5ldyBwYWdlLgorRVdXIHByb3ZpZGVzIHRo ZSBmb2xsb3dpbmcgdmFsdWVzIGZvciB0aGlzIG9wdGlvbjoKKworKiBgZXd3LWRlbGV0ZS1m dXR1cmUtaGlzdG9yeSc6IERlbGV0ZSBhbnkgaGlzdG9yeSBlbnRyaWVzIGFmdGVyIHRoZQor Y3VycmVudGx5LXNob3duIG9uZS4gIFRoaXMgaXMgdGhlIGRlZmF1bHQgYmVoYXZpb3IsIGFu ZCB3b3JrcyB0aGUgc2FtZQorYXMgaW4gbW9zdCBvdGhlciB3ZWIgYnJvd3NlcnMuCisKKyog YGV3dy1jbG9uZS1wcmV2aW91cy1oaXN0b3J5JzogQ2xvbmUgYW5kIHByZXBlbmQgYW55IGhp c3RvcnkgZW50cmllcyB1cAorICB0byB0aGUgY3VycmVudGx5LXNob3duIG9uZS4gIFRoaXMg aXMgbGlrZSBgZXd3LWRlbGV0ZS1mdXR1cmUtaGlzdG9yeScsCisgIGV4Y2VwdCB0aGF0IGl0 IHByZXNlcnZlcyB0aGUgcHJldmlvdXMgY29udGVudHMgb2YgdGhlIGhpc3RvcnkgbGlzdCBh dAorICB0aGUgZW5kLgorCisqIGBpZ25vcmUnOiBQcmVzZXJ2ZSB0aGUgY3VycmVudCBoaXN0 b3J5IHVuY2hhbmdlZC4gIFRoaXMgd2lsbCByZXN1bHQgaW4KKyAgdGhlIG5ldyBwYWdlIHNp bXBseSBiZWluZyBwcmVwZW5kZWQgdG8gdGhlIGV4aXN0aW5nIGhpc3RvcnkgbGlzdC4KKwor WW91IGNhbiBhbHNvIHNldCB0aGlzIHRvIGFueSBvdGhlciBmdW5jdGlvbiB5b3Ugd2lzaC4i CisgIDp2ZXJzaW9uICIzMC4xIgorICA6Z3JvdXAgJ2V3dworICA6dHlwZSAnKGNob2ljZSAo ZnVuY3Rpb24taXRlbSA6dGFnICJEZWxldGUgZnV0dXJlIGhpc3RvcnkiCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGV3dy1kZWxldGUtZnV0dXJlLWhpc3RvcnkpCisgICAg ICAgICAgICAgICAgIChmdW5jdGlvbi1pdGVtIDp0YWcgIkNsb25lIHByZXZpb3VzIGhpc3Rv cnkiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGV3dy1jbG9uZS1wcmV2aW91 cy1oaXN0b3J5KQorICAgICAgICAgICAgICAgICAoZnVuY3Rpb24taXRlbSA6dGFnICJQcmVz ZXJ2ZSBoaXN0b3J5IgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpZ25vcmUp CisgICAgICAgICAgICAgICAgIChmdW5jdGlvbiA6dGFnICJDdXN0b20gZnVuY3Rpb24iKSkp CisKIChkZWZjdXN0b20gZXd3LWFmdGVyLXJlbmRlci1ob29rIG5pbAogICAiQSBob29rIGNh bGxlZCBhZnRlciBld3cgaGFzIGZpbmlzaGVkIHJlbmRlcmluZyB0aGUgYnVmZmVyLiIKICAg OnZlcnNpb24gIjI1LjEiCkBAIC0zMTIsNyArMzM5LDEwIEBAIGV3dy12YWxpZC1jZXJ0aWZp Y2F0ZQogCiAoZGVmdmFyIGV3dy1kYXRhIG5pbCkKIChkZWZ2YXIgZXd3LWhpc3Rvcnkgbmls KQotKGRlZnZhciBld3ctaGlzdG9yeS1wb3NpdGlvbiAwKQorKGRlZnZhciBld3ctaGlzdG9y eS1wb3NpdGlvbiAwCisgICJUaGUgMS1pbmRleGVkIHBvc2l0aW9uIGluIGBld3ctaGlzdG9y eScuCitJZiB6ZXJvLCBFV1cgaXMgYXQgdGhlIG5ld2VzdCBwYWdlLCB3aGljaCBpc24ndCB5 ZXQgcHJlc2VudCBpbgorYGV3dy1oaXN0b3J5Jy4iKQogKGRlZnZhciBld3ctcHJvbXB0LWhp c3RvcnkgbmlsKQogCiAoZGVmdmFyIGV3dy1sb2NhbC1yZWdleCAibG9jYWxob3N0IgpAQCAt NDAyLDYgKzQzMiw3IEBAIGV3dwogICAgICh0CiAgICAgIChnZXQtYnVmZmVyLWNyZWF0ZSAi KmV3dyoiKSkpKQogICAoZXd3LXNldHVwLWJ1ZmZlcikKKyAgKGV3dy0tYmVmb3JlLWJyb3dz ZSkKICAgOzsgQ2hlY2sgd2hldGhlciB0aGUgZG9tYWluIG9ubHkgdXNlcyAiSGlnaGx5IFJl c3RyaWN0ZWQiIFVuaWNvZGUKICAgOzsgSUROQSBjaGFyYWN0ZXJzLiAgSWYgbm90LCB0cmFu c2Zvcm0gdG8gcHVueWNvZGUgdG8gaW5kaWNhdGUgdGhhdAogICA7OyB0aGVyZSBtYXkgYmUg ZnVubnkgYnVzaW5lc3MgZ29pbmcgb24uCkBAIC02NTQsNyArNjg1LDYgQEAgZXd3LXJlbmRl cgogCSAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciBidWZmZXIKIAkgICAgICAocGxpc3QtcHV0 IGV3dy1kYXRhIDp1cmwgdXJsKQogCSAgICAgIChld3ctLWFmdGVyLXBhZ2UtY2hhbmdlKQot CSAgICAgIChzZXRxIGV3dy1oaXN0b3J5LXBvc2l0aW9uIDApCiAJICAgICAgKGFuZCBsYXN0 LWNvZGluZy1zeXN0ZW0tdXNlZAogCQkgICAoc2V0LWJ1ZmZlci1maWxlLWNvZGluZy1zeXN0 ZW0gbGFzdC1jb2Rpbmctc3lzdGVtLXVzZWQpKQogICAgICAgICAgICAgICAodW5sZXNzIHNo ci1maWxsLXRleHQKQEAgLTkwNSw2ICs5MzUsMTEgQEAgZXd3LXVwZGF0ZS1oZWFkZXItbGlu ZS1mb3JtYXQKIAkJIGAoKD91IC4gLChvciB1cmwgIiIpKQogCQkgICAoP3QgLiAsdGl0bGUp KSkpKSkpKQogCisoZGVmdW4gZXd3LS1iZWZvcmUtYnJvd3NlICgpCisgIChmdW5jYWxsIGV3 dy1iZWZvcmUtYnJvd3NlLWhpc3RvcnktZnVuY3Rpb24pCisgIChzZXRxIGV3dy1oaXN0b3J5 LXBvc2l0aW9uIDAKKyAgICAgICAgZXd3LWRhdGEgKGxpc3QgOnRpdGxlICIiKSkpCisKIChk ZWZ1biBld3ctLWFmdGVyLXBhZ2UtY2hhbmdlICgpCiAgIChld3ctdXBkYXRlLWhlYWRlci1s aW5lLWZvcm1hdCkKICAgKGV3dy0tcmVuYW1lLWJ1ZmZlcikpCkBAIC0xMDM3LDYgKzEwNzIs NyBAQCBld3ctcmVhZGFibGUKICAgICAgICAgIChiYXNlIChwbGlzdC1nZXQgZXd3LWRhdGEg OnVybCkpKQogICAgIChld3ctc2NvcmUtcmVhZGFiaWxpdHkgZG9tKQogICAgIChld3ctc2F2 ZS1oaXN0b3J5KQorICAgIChld3ctLWJlZm9yZS1icm93c2UpCiAgICAgKGV3dy1kaXNwbGF5 LWh0bWwgbmlsIG5pbAogICAgICAgICAgICAgICAgICAgICAgIChsaXN0ICdiYXNlIChsaXN0 IChjb25zICdocmVmIGJhc2UpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIChld3ct aGlnaGVzdC1yZWFkYWJpbGl0eSBkb20pKQpAQCAtMTEyOSw5ICsxMTY1LDkgQEAgZXd3LW1v ZGUtbWFwCiAgICAgICAgICAgWyJSZWxvYWQiIGV3dy1yZWxvYWQgdF0KICAgICAgICAgICBb IkZvbGxvdyBVUkwgaW4gbmV3IGJ1ZmZlciIgZXd3LW9wZW4taW4tbmV3LWJ1ZmZlcl0KICAg ICAgICAgICBbIkJhY2sgdG8gcHJldmlvdXMgcGFnZSIgZXd3LWJhY2stdXJsCi0gICAgICAg ICAgIDphY3RpdmUgKG5vdCAoemVyb3AgKGxlbmd0aCBld3ctaGlzdG9yeSkpKV0KKyAgICAg ICAgICAgOmFjdGl2ZSAoPCBld3ctaGlzdG9yeS1wb3NpdGlvbiAobGVuZ3RoIGV3dy1oaXN0 b3J5KSldCiAgICAgICAgICAgWyJGb3J3YXJkIHRvIG5leHQgcGFnZSIgZXd3LWZvcndhcmQt dXJsCi0gICAgICAgICAgIDphY3RpdmUgKG5vdCAoemVyb3AgZXd3LWhpc3RvcnktcG9zaXRp b24pKV0KKyAgICAgICAgICAgOmFjdGl2ZSAoPiBld3ctaGlzdG9yeS1wb3NpdGlvbiAxKV0K ICAgICAgICAgICBbIkJyb3dzZSB3aXRoIGV4dGVybmFsIGJyb3dzZXIiIGV3dy1icm93c2Ut d2l0aC1leHRlcm5hbC1icm93c2VyIHRdCiAgICAgICAgICAgWyJEb3dubG9hZCIgZXd3LWRv d25sb2FkIHRdCiAgICAgICAgICAgWyJWaWV3IHBhZ2Ugc291cmNlIiBld3ctdmlldy1zb3Vy Y2VdCkBAIC0xMTU1LDkgKzExOTEsOSBAQCBld3ctY29udGV4dC1tZW51CiAgICAgKGVhc3kt bWVudS1kZWZpbmUgbmlsIGVhc3ktbWVudSBuaWwKICAgICAgICcoIkV3dyIKICAgICAgICAg WyJCYWNrIHRvIHByZXZpb3VzIHBhZ2UiIGV3dy1iYWNrLXVybAotCSA6dmlzaWJsZSAobm90 ICh6ZXJvcCAobGVuZ3RoIGV3dy1oaXN0b3J5KSkpXQorCSA6YWN0aXZlICg8IGV3dy1oaXN0 b3J5LXBvc2l0aW9uIChsZW5ndGggZXd3LWhpc3RvcnkpKV0KIAlbIkZvcndhcmQgdG8gbmV4 dCBwYWdlIiBld3ctZm9yd2FyZC11cmwKLQkgOnZpc2libGUgKG5vdCAoemVyb3AgZXd3LWhp c3RvcnktcG9zaXRpb24pKV0KKwkgOmFjdGl2ZSAoPiBld3ctaGlzdG9yeS1wb3NpdGlvbiAx KV0KIAlbIlJlbG9hZCIgZXd3LXJlbG9hZCB0XSkpCiAgICAgKGRvbGlzdCAoaXRlbSAocmV2 ZXJzZSAobG9va3VwLWtleSBlYXN5LW1lbnUgW21lbnUtYmFyIGV3d10pKSkKICAgICAgICh3 aGVuIChjb25zcCBpdGVtKQpAQCAtMTI4MCwxNiArMTMxNiwyMCBAQCBld3ctYmFjay11cmwK ICAgKGludGVyYWN0aXZlIG5pbCBld3ctbW9kZSkKICAgKHdoZW4gKD49IGV3dy1oaXN0b3J5 LXBvc2l0aW9uIChsZW5ndGggZXd3LWhpc3RvcnkpKQogICAgICh1c2VyLWVycm9yICJObyBw cmV2aW91cyBwYWdlIikpCi0gIChld3ctc2F2ZS1oaXN0b3J5KQotICAoc2V0cSBld3ctaGlz dG9yeS1wb3NpdGlvbiAoKyBld3ctaGlzdG9yeS1wb3NpdGlvbiAyKSkKKyAgKGlmIChld3ct c2F2ZS1oaXN0b3J5KQorICAgICAgOzsgV2Ugd2VyZSBhdCB0aGUgbGF0ZXN0IHBhZ2UgKHdo aWNoIHdhcyBqdXN0IGFkZGVkIHRvIHRoZQorICAgICAgOzsgaGlzdG9yeSksIHNvIGdvIGJh Y2sgdHdvIGVudHJpZXMuCisgICAgICAoc2V0cSBld3ctaGlzdG9yeS1wb3NpdGlvbiAyKQor ICAgIChzZXRxIGV3dy1oaXN0b3J5LXBvc2l0aW9uICgxKyBld3ctaGlzdG9yeS1wb3NpdGlv bikpKQogICAoZXd3LXJlc3RvcmUtaGlzdG9yeSAoZWx0IGV3dy1oaXN0b3J5ICgxLSBld3ct aGlzdG9yeS1wb3NpdGlvbikpKSkKIAogKGRlZnVuIGV3dy1mb3J3YXJkLXVybCAoKQogICAi R28gdG8gdGhlIG5leHQgZGlzcGxheWVkIHBhZ2UuIgogICAoaW50ZXJhY3RpdmUgbmlsIGV3 dy1tb2RlKQotICAod2hlbiAoemVyb3AgZXd3LWhpc3RvcnktcG9zaXRpb24pCisgICh3aGVu ICg8PSBld3ctaGlzdG9yeS1wb3NpdGlvbiAxKQogICAgICh1c2VyLWVycm9yICJObyBuZXh0 IHBhZ2UiKSkKICAgKGV3dy1zYXZlLWhpc3RvcnkpCisgIChzZXRxIGV3dy1oaXN0b3J5LXBv c2l0aW9uICgxLSBld3ctaGlzdG9yeS1wb3NpdGlvbikpCiAgIChld3ctcmVzdG9yZS1oaXN0 b3J5IChlbHQgZXd3LWhpc3RvcnkgKDEtIGV3dy1oaXN0b3J5LXBvc2l0aW9uKSkpKQogCiAo ZGVmdW4gZXd3LXJlc3RvcmUtaGlzdG9yeSAoZWxlbSkKQEAgLTE5NTksNiArMTk5OSw3IEBA IGV3dy1mb2xsb3ctbGluawogCSAgIChld3ctc2FtZS1wYWdlLXAgdXJsIChwbGlzdC1nZXQg ZXd3LWRhdGEgOnVybCkpKQogICAgICAgKGxldCAoKHBvaW50IChwb2ludCkpKQogCShld3ct c2F2ZS1oaXN0b3J5KQorICAgICAgICAoZXd3LS1iZWZvcmUtYnJvd3NlKQogCShwbGlzdC1w dXQgZXd3LWRhdGEgOnVybCB1cmwpCiAgICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikp CiAgICAgICAgIChpZi1sZXQgKChtYXRjaCAodGV4dC1wcm9wZXJ0eS1zZWFyY2gtZm9yd2Fy ZCAnc2hyLXRhcmdldC1pZCB0YXJnZXQgIydtZW1iZXIpKSkKQEAgLTIyODksMTEgKzIzMzAs NjkgQEAgZXd3LWJvb2ttYXJrLW1vZGUKIDs7OyBIaXN0b3J5IGNvZGUKIAogKGRlZnVuIGV3 dy1zYXZlLWhpc3RvcnkgKCkKKyAgIlNhdmUgdGhlIGN1cnJlbnQgcGFnZSdzIGRhdGEgdG8g dGhlIGhpc3RvcnkuCitJZiB0aGUgY3VycmVudCBwYWdlIGlzIGEgaGlzdG9yaWFsIG9uZSBs b2FkZWQgZnJvbQorYGV3dy1oaXN0b3J5JyAoZS5nLiBieSBjYWxsaW5nIGBld3ctYmFjay11 cmwnKSwgdGhpcyB3aWxsIHVwZGF0ZSB0aGUKK3BhZ2UncyBlbnRyeSBpbiBgZXd3LWhpc3Rv cnknIGFuZCByZXR1cm4gbmlsLiAgT3RoZXJ3aXNlLCBhZGQgYSBuZXcKK2VudHJ5IHRvIGBl d3ctaGlzdG9yeScgYW5kIHJldHVybiB0LiIKICAgKHBsaXN0LXB1dCBld3ctZGF0YSA6cG9p bnQgKHBvaW50KSkKICAgKHBsaXN0LXB1dCBld3ctZGF0YSA6dGV4dCAoYnVmZmVyLXN0cmlu ZykpCi0gIChsZXQgKChoaXN0b3J5LWRlbGV0ZS1kdXBsaWNhdGVzIG5pbCkpCi0gICAgKGFk ZC10by1oaXN0b3J5ICdld3ctaGlzdG9yeSBld3ctZGF0YSBld3ctaGlzdG9yeS1saW1pdCB0 KSkKLSAgKHNldHEgZXd3LWRhdGEgKGxpc3QgOnRpdGxlICIiKSkpCisgIChpZiAoemVyb3Ag ZXd3LWhpc3RvcnktcG9zaXRpb24pCisgICAgICAobGV0ICgoaGlzdG9yeS1kZWxldGUtZHVw bGljYXRlcyBuaWwpKQorICAgICAgICAoYWRkLXRvLWhpc3RvcnkgJ2V3dy1oaXN0b3J5IGV3 dy1kYXRhIGV3dy1oaXN0b3J5LWxpbWl0IHQpCisgICAgICAgIChzZXRxIGV3dy1oaXN0b3J5 LXBvc2l0aW9uIDEpCisgICAgICAgIHQpCisgICAgKHNldGYgKGVsdCBld3ctaGlzdG9yeSAo MS0gZXd3LWhpc3RvcnktcG9zaXRpb24pKSBld3ctZGF0YSkKKyAgICBuaWwpKQorCisoZGVm dW4gZXd3LWRlbGV0ZS1mdXR1cmUtaGlzdG9yeSAoKQorICAiUmVtb3ZlIGFueSBlbnRyaWVz IGluIGBld3ctaGlzdG9yeScgYWZ0ZXIgdGhlIGN1cnJlbnRseS1zaG93biBvbmUuCitUaGlz IGlzIHVzZWZ1bCBmb3IgYGV3dy1iZWZvcmUtYnJvd3NlLWhpc3RvcnktZnVuY3Rpb24nIHRv IG1ha2UgRVdXJ3MKK25hdmlnYXRpb24gdG8gYSBuZXcgcGFnZSBmcm9tIGEgaGlzdG9yaWNh bCBvbmUgd29yayBsaWtlIG90aGVyIHdlYgorYnJvd3NlcnM6IGl0IHdpbGwgZGVsZXRlIGFu eSBcImZ1dHVyZVwiIGhpc3RvcnkgZWxlbWVudHMgYmVmb3JlIGFkZGluZwordGhlIG5ldyBw YWdlIHRvIHRoZSBlbmQgb2YgdGhlIGhpc3RvcnkuCisKK0ZvciBleGFtcGxlLCBpZiBgZXd3 LWhpc3RvcnknIGxvb2tzIGxpa2UgdGhpcyAoZ29pbmcgZnJvbSBuZXdlc3QgdG8KK29sZGVz dCwgd2l0aCBcIipcIiBtYXJraW5nIHRoZSBjdXJyZW50IHBhZ2UpOgorCisgIEUgRCBDKiBC IEEKKwordGhlbiBjYWxsaW5nIHRoaXMgZnVuY3Rpb24gdXBkYXRlcyBgZXd3LWhpc3Rvcnkn IHRvOgorCisgIEMqIEIgQSIKKyAgKHdoZW4gKD4gZXd3LWhpc3RvcnktcG9zaXRpb24gMSkK KyAgICAoc2V0cSBld3ctaGlzdG9yeSAobnRoY2RyICgxLSBld3ctaGlzdG9yeS1wb3NpdGlv bikgZXd3LWhpc3RvcnkpCisgICAgICAgICAgOzsgV2UgZG9uJ3QgcmVhbGx5IG5lZWQgdG8g c2V0IHRoaXMgc2luY2UgYGV3dy0tYmVmb3JlLWJyb3dzZScKKyAgICAgICAgICA7OyBzZXRz IGl0IHRvbywgYnV0IHRoaXMgZW5zdXJlcyB0aGF0IG90aGVyIGNhbGxlcnMgY2FuIHVzZQor ICAgICAgICAgIDs7IHRoaXMgZnVuY3Rpb24gYW5kIGdldCB0aGUgZXhwZWN0ZWQgcmVzdWx0 cy4KKyAgICAgICAgICBld3ctaGlzdG9yeS1wb3NpdGlvbiAxKSkpCisKKyhkZWZ1biBld3ct Y2xvbmUtcHJldmlvdXMtaGlzdG9yeSAoKQorICAiQ2xvbmUgYW5kIHByZXBlbmQgZW50cmll cyBpbiBgZXd3LWhpc3RvcnknIHVwIHRvIHRoZSBjdXJyZW50bHktc2hvd24gb25lLgorVGhl c2UgY2xvbmVkIGVudHJpZXMgZ2V0IGFkZGVkIHRvIHRoZSBiZWdpbm5pbmcgb2YgYGV3dy1o aXN0b3J5JyBzbyB0aGF0CitpdCdzIHBvc3NpYmxlIHRvIG5hdmlnYXRlIGJhY2sgdG8gdGhl IHZlcnkgZmlyc3QgcGFnZSBmb3IgdGhpcyBFV1cKK3dpdGhvdXQgZGVsZXRpbmcgYW55IGhp c3RvcnkgZW50cmllcy4KKworRm9yIGV4YW1wbGUsIGlmIGBld3ctaGlzdG9yeScgbG9va3Mg bGlrZSB0aGlzIChnb2luZyBmcm9tIG5ld2VzdCB0bworb2xkZXN0LCB3aXRoIFwiKlwiIG1h cmtpbmcgdGhlIGN1cnJlbnQgcGFnZSk6CisKKyAgRSBEIEMqIEIgQQorCit0aGVuIGNhbGxp bmcgdGhpcyBmdW5jdGlvbiB1cGRhdGVzIGBld3ctaGlzdG9yeScgdG86CisKKyAgQyogQiBB IEUgRCBDIEQgQQorCitUaGlzIGlzIHVzZWZ1bCBmb3Igc2V0dGluZyBgZXd3LWJlZm9yZS1i cm93c2UtaGlzdG9yeS1mdW5jdGlvbicgKHdoaWNoCitzZWUpLiIKKyAgKHdoZW4gKD4gZXd3 LWhpc3RvcnktcG9zaXRpb24gMSkKKyAgICAoc2V0cSBld3ctaGlzdG9yeSAodGFrZSBld3ct aGlzdG9yeS1saW1pdAorICAgICAgICAgICAgICAgICAgICAgICAgICAgIChhcHBlbmQgKG50 aGNkciAoMS0gZXd3LWhpc3RvcnktcG9zaXRpb24pCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGV3dy1oaXN0b3J5KQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgZXd3LWhpc3RvcnkpKQorICAgICAgICAgIDs7IEFzIHdpdGgg YGV3dy1kZWxldGUtZnV0dXJlLWhpc3RvcnknLCB3ZSBkb24ndCByZWFsbHkgbmVlZAorICAg ICAgICAgIDs7IHRvIHNldCB0aGlzIHNpbmNlIGBld3ctLWJlZm9yZS1icm93c2UnIHNldHMg aXQgdG9vLCBidXQKKyAgICAgICAgICA7OyBsZXQncyBiZSB0aG9yb3VnaC4KKyAgICAgICAg ICBld3ctaGlzdG9yeS1wb3NpdGlvbiAxKSkpCiAKIChkZWZ2YXIgZXd3LWN1cnJlbnQtYnVm ZmVyKQogCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvbmV0L2V3dy10ZXN0cy5lbCBiL3Rlc3Qv bGlzcC9uZXQvZXd3LXRlc3RzLmVsCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAw MDAwMDAwLi5jZWQ4NDMyMmUzYQotLS0gL2Rldi9udWxsCisrKyBiL3Rlc3QvbGlzcC9uZXQv ZXd3LXRlc3RzLmVsCkBAIC0wLDAgKzEsMTc5IEBACis7OzsgZXd3LXRlc3RzLmVsIC0tLSB0 ZXN0cyBmb3IgZXd3LmVsICAtKi0gbGV4aWNhbC1iaW5kaW5nOiB0OyAtKi0KKworOzsgQ29w eXJpZ2h0IChDKSAyMDI0IEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5jLgorCis7OyBU aGlzIGZpbGUgaXMgcGFydCBvZiBHTlUgRW1hY3MuCisKKzs7IEdOVSBFbWFjcyBpcyBmcmVl IHNvZnR3YXJlOiB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IgbW9kaWZ5Cis7OyBp dCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGFz IHB1Ymxpc2hlZCBieQorOzsgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgZWl0aGVy IHZlcnNpb24gMyBvZiB0aGUgTGljZW5zZSwgb3IKKzs7IChhdCB5b3VyIG9wdGlvbikgYW55 IGxhdGVyIHZlcnNpb24uCisKKzs7IEdOVSBFbWFjcyBpcyBkaXN0cmlidXRlZCBpbiB0aGUg aG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorOzsgYnV0IFdJVEhPVVQgQU5ZIFdBUlJB TlRZOyB3aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKzs7IE1FUkNIQU5U QUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUK Kzs7IEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisKKzs7 IFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBHZW5lcmFsIFB1 YmxpYyBMaWNlbnNlCis7OyBhbG9uZyB3aXRoIEdOVSBFbWFjcy4gIElmIG5vdCwgc2VlIDxo dHRwczovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4uCisKKzs7OyBDb21tZW50YXJ5OgorCis7 OzsgQ29kZToKKworKHJlcXVpcmUgJ2VydCkKKyhyZXF1aXJlICdld3cpCisKKyhkZWZ2YXIg ZXd3LXRlc3QtLXJlc3BvbnNlLWZ1bmN0aW9uIChsYW1iZGEgKHVybCkgKGNvbmNhdCAiXG4i IHVybCkpCisgICJBIGZ1bmN0aW9uIGZvciByZXR1cm5pbmcgYSBtb2NrIHJlc3BvbnNlIGZv ciBVUkwuCitUaGUgZGVmYXVsdCBqdXN0IHJldHVybnMgYW4gZW1wdHkgbGlzdCBvZiBoZWFk ZXJzIFVSTCBhcyB0aGUgYm9keS4iKQorCisoZGVmbWFjcm8gZXd3LXRlc3QtLXdpdGgtbW9j ay1yZXRyaWV2ZSAoJnJlc3QgYm9keSkKKyAgIkV2YWx1YXRlIEJPRFkgd2l0aCBhIG1vY2sg aW1wbGVtZW50YXRpb24gb2YgYGV3dy1yZXRyaWV2ZScuCitUaGlzIGF2b2lkcyBuZXR3b3Jr IHJlcXVlc3RzIGR1cmluZyBvdXIgdGVzdHMuICBBZGRpdGlvbmFsbHksIHByZXBhcmUgYQor dGVtcG9yYXJ5IEVXVyBidWZmZXIgZm9yIG91ciB0ZXN0cy4iCisgIChkZWNsYXJlIChpbmRl bnQgMSkpCisgICAgYChjbC1sZXRmICgoKHN5bWJvbC1mdW5jdGlvbiAnZXd3LXJldHJpZXZl KQorICAgICAgICAgICAgICAgIChsYW1iZGEgKHVybCBjYWxsYmFjayBhcmdzKQorICAgICAg ICAgICAgICAgICAgKHdpdGgtdGVtcC1idWZmZXIKKyAgICAgICAgICAgICAgICAgICAgKGlu c2VydCAoZnVuY2FsbCBld3ctdGVzdC0tcmVzcG9uc2UtZnVuY3Rpb24gdXJsKSkKKyAgICAg ICAgICAgICAgICAgICAgKGFwcGx5IGNhbGxiYWNrIG5pbCBhcmdzKSkpKSkKKyAgICAgICAo d2l0aC10ZW1wLWJ1ZmZlcgorICAgICAgICAgKGV3dy1tb2RlKQorICAgICAgICAgLEBib2R5 KSkpCisKKyhkZWZ1biBld3ctdGVzdC0taGlzdG9yeS11cmxzICgpCisgIChtYXBjYXIgKGxh bWJkYSAoZWxlbSkgKHBsaXN0LWdldCBlbGVtIDp1cmwpKSBld3ctaGlzdG9yeSkpCisKKzs7 OyBUZXN0czoKKworKGVydC1kZWZ0ZXN0IGV3dy10ZXN0L2hpc3RvcnkvbmV3LXBhZ2UgKCkK KyAgIlRlc3QgdGhhdCB3aGVuIHZpc2l0aW5nIGEgbmV3IHBhZ2UsIHRoZSBwcmV2aW91cyBv bmUgZ29lcyBpbnRvIHRoZSBoaXN0b3J5LiIKKyAgKGV3dy10ZXN0LS13aXRoLW1vY2stcmV0 cmlldmUKKyAgICAoZXd3ICJvbmUuaW52YWxpZCIpCisgICAgKGV3dyAidHdvLmludmFsaWQi KQorICAgIChzaG91bGQgKGVxdWFsIChld3ctdGVzdC0taGlzdG9yeS11cmxzKQorICAgICAg ICAgICAgICAgICAgICcoImh0dHA6Ly9vbmUuaW52YWxpZC8iKSkpCisgICAgKGV3dyAidGhy ZWUuaW52YWxpZCIpCisgICAgKHNob3VsZCAoZXF1YWwgKGV3dy10ZXN0LS1oaXN0b3J5LXVy bHMpCisgICAgICAgICAgICAgICAgICAgJygiaHR0cDovL3R3by5pbnZhbGlkLyIKKyAgICAg ICAgICAgICAgICAgICAgICJodHRwOi8vb25lLmludmFsaWQvIikpKSkpCisKKyhlcnQtZGVm dGVzdCBld3ctdGVzdC9oaXN0b3J5L2JhY2stZm9yd2FyZCAoKQorICAiVGVzdCB0aGF0IG5h dmlnYXRpbmcgdGhyb3VnaCBoaXN0b3J5IGp1c3QgY2hhbmdlcyBvdXIgaGlzdG9yeSBwb3Np dGlvbi4KK1NlZSBidWcjNjkyMzIuIgorICAoZXd3LXRlc3QtLXdpdGgtbW9jay1yZXRyaWV2 ZQorICAgIChld3cgIm9uZS5pbnZhbGlkIikKKyAgICAoZXd3ICJ0d28uaW52YWxpZCIpCisg ICAgKGV3dyAidGhyZWUuaW52YWxpZCIpCisgICAgKGxldCAoKHVybC1oaXN0b3J5ICcoImh0 dHA6Ly90aHJlZS5pbnZhbGlkLyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAiaHR0cDov L3R3by5pbnZhbGlkLyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAiaHR0cDovL29uZS5p bnZhbGlkLyIpKSkKKyAgICAgIDs7IEdvIGJhY2sgb25lIHBhZ2UuICBUaGlzIHNob3VsZCBh ZGQgInRocmVlLmludmFsaWQiIHRvIHRoZQorICAgICAgOzsgaGlzdG9yeSwgbWFraW5nIG91 ciBwb3NpdGlvbiBpbiB0aGUgbGlzdCAyLgorICAgICAgKGV3dy1iYWNrLXVybCkKKyAgICAg IChzaG91bGQgKGVxdWFsIChld3ctdGVzdC0taGlzdG9yeS11cmxzKSB1cmwtaGlzdG9yeSkp CisgICAgICAoc2hvdWxkICg9IGV3dy1oaXN0b3J5LXBvc2l0aW9uIDIpKQorICAgICAgOzsg R28gYmFjayBhZ2Fpbi4KKyAgICAgIChld3ctYmFjay11cmwpCisgICAgICAoc2hvdWxkIChl cXVhbCAoZXd3LXRlc3QtLWhpc3RvcnktdXJscykgdXJsLWhpc3RvcnkpKQorICAgICAgKHNo b3VsZCAoPSBld3ctaGlzdG9yeS1wb3NpdGlvbiAzKSkKKyAgICAgIDs7IEF0IHRoZSBiZWdp bm5pbmcgb2YgdGhlIGhpc3RvcnksIHNvIHRyeWluZyB0byBnbyBiYWNrIHNob3VsZAorICAg ICAgOzsgc2lnbmFsIGFuIGVycm9yLgorICAgICAgKHNob3VsZC1lcnJvciAoZXd3LWJhY2st dXJsKSkKKyAgICAgIDs7IEdvIGZvcndhcmQgb25jZS4KKyAgICAgIChld3ctZm9yd2FyZC11 cmwpCisgICAgICAoc2hvdWxkIChlcXVhbCAoZXd3LXRlc3QtLWhpc3RvcnktdXJscykgdXJs LWhpc3RvcnkpKQorICAgICAgKHNob3VsZCAoPSBld3ctaGlzdG9yeS1wb3NpdGlvbiAyKSkK KyAgICAgIDs7IEdvIGZvcndhcmQgYWdhaW4uCisgICAgICAoZXd3LWZvcndhcmQtdXJsKQor ICAgICAgKHNob3VsZCAoZXF1YWwgKGV3dy10ZXN0LS1oaXN0b3J5LXVybHMpIHVybC1oaXN0 b3J5KSkKKyAgICAgIChzaG91bGQgKD0gZXd3LWhpc3RvcnktcG9zaXRpb24gMSkpCisgICAg ICA7OyBBdCB0aGUgZW5kIG9mIHRoZSBoaXN0b3J5LCBzbyB0cnlpbmcgdG8gZ28gZm9yd2Fy ZCBzaG91bGQKKyAgICAgIDs7IHNpZ25hbCBhbiBlcnJvci4KKyAgICAgIChzaG91bGQtZXJy b3IgKGV3dy1mb3J3YXJkLXVybCkpKSkpCisKKyhlcnQtZGVmdGVzdCBld3ctdGVzdC9oaXN0 b3J5L3JlbG9hZC1pbi1wbGFjZSAoKQorICAiVGVzdCB0aGF0IHJlbG9hZGluZyBoaXN0b3Jp Y2FsIHBhZ2VzIHVwZGF0ZXMgdGhlaXIgaGlzdG9yeSBlbnRyeSBpbi1wbGFjZS4KK1NlZSBi dWcjNjkyMzIuIgorICAoZXd3LXRlc3QtLXdpdGgtbW9jay1yZXRyaWV2ZQorICAgIChld3cg Im9uZS5pbnZhbGlkIikKKyAgICAoZXd3ICJ0d28uaW52YWxpZCIpCisgICAgKGV3dyAidGhy ZWUuaW52YWxpZCIpCisgICAgKGV3dy1iYWNrLXVybCkKKyAgICA7OyBNYWtlIHN1cmUgb3Vy IGhpc3RvcnkgaGFzIHRoZSBvcmlnaW5hbCBwYWdlIHRleHQuCisgICAgKHNob3VsZCAoZXF1 YWwgKHBsaXN0LWdldCAobnRoIDEgZXd3LWhpc3RvcnkpIDp0ZXh0KQorICAgICAgICAgICAg ICAgICAgICJodHRwOi8vdHdvLmludmFsaWQvIikpCisgICAgKHNob3VsZCAoPSBld3ctaGlz dG9yeS1wb3NpdGlvbiAyKSkKKyAgICA7OyBSZWxvYWQgdGhlIHBhZ2UuCisgICAgKGxldCAo KGV3dy10ZXN0LS1yZXNwb25zZS1mdW5jdGlvbgorICAgICAgICAgICAobGFtYmRhICh1cmwp IChjb25jYXQgIlxucmVsb2FkZWQgIiB1cmwpKSkpCisgICAgICAoZXd3LXJlbG9hZCkKKyAg ICAgIChzaG91bGQgKD0gZXd3LWhpc3RvcnktcG9zaXRpb24gMikpKQorICAgIDs7IEdvIHRv IGFub3RoZXIgcGFnZSwgYW5kIG1ha2Ugc3VyZSB0aGUgaGlzdG9yeSBpcyBjb3JyZWN0LAor ICAgIDs7IGluY2x1ZGluZyB0aGUgcmVsb2FkZWQgcGFnZSB0ZXh0LgorICAgIChld3cgImZv dXIuaW52YWxpZCIpCisgICAgKHNob3VsZCAoZXF1YWwgKGV3dy10ZXN0LS1oaXN0b3J5LXVy bHMpICcoImh0dHA6Ly90d28uaW52YWxpZC8iCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgImh0dHA6Ly9vbmUuaW52YWxpZC8iKSkpCisgICAgKHNo b3VsZCAoZXF1YWwgKHBsaXN0LWdldCAobnRoIDAgZXd3LWhpc3RvcnkpIDp0ZXh0KQorICAg ICAgICAgICAgICAgICAgICJyZWxvYWRlZCBodHRwOi8vdHdvLmludmFsaWQvIikpCisgICAg KHNob3VsZCAoPSBld3ctaGlzdG9yeS1wb3NpdGlvbiAwKSkpKQorCisoZXJ0LWRlZnRlc3Qg ZXd3LXRlc3QvaGlzdG9yeS9iZWZvcmUtbmF2aWdhdGUvZGVsZXRlLWZ1dHVyZS1oaXN0b3J5 ICgpCisgICJUZXN0IHRoYXQgZ29pbmcgdG8gYSBuZXcgcGFnZSBmcm9tIGEgaGlzdG9yaWNh bCBvbmUgZGVsZXRlcyBmdXR1cmUgaGlzdG9yeS4KK1NlZSBidWcjNjkyMzIuIgorICAoZXd3 LXRlc3QtLXdpdGgtbW9jay1yZXRyaWV2ZQorICAgIChld3cgIm9uZS5pbnZhbGlkIikKKyAg ICAoZXd3ICJ0d28uaW52YWxpZCIpCisgICAgKGV3dyAidGhyZWUuaW52YWxpZCIpCisgICAg KGV3dy1iYWNrLXVybCkKKyAgICAoZXd3ICJmb3VyLmludmFsaWQiKQorICAgIChld3cgImZp dmUuaW52YWxpZCIpCisgICAgKHNob3VsZCAoZXF1YWwgKGV3dy10ZXN0LS1oaXN0b3J5LXVy bHMpICcoImh0dHA6Ly9mb3VyLmludmFsaWQvIgorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICJodHRwOi8vdHdvLmludmFsaWQvIgorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJodHRwOi8vb25lLmludmFs aWQvIikpKQorICAgIChzaG91bGQgKD0gZXd3LWhpc3RvcnktcG9zaXRpb24gMCkpKSkKKwor KGVydC1kZWZ0ZXN0IGV3dy10ZXN0L2hpc3RvcnkvYmVmb3JlLW5hdmlnYXRlL2lnbm9yZS1o aXN0b3J5ICgpCisgICJUZXN0IHRoYXQgZ29pbmcgdG8gYSBuZXcgcGFnZSBmcm9tIGEgaGlz dG9yaWNhbCBvbmUgcHJlc2VydmVzIGhpc3RvcnkuCitUaGlzIHNldHMgYGV3dy1iZWZvcmUt YnJvd3NlLWhpc3RvcnktZnVuY3Rpb24nIHRvIGBpZ25vcmUnIHRvIHByZXNlcnZlCitoaXN0 b3J5LiAgU2VlIGJ1ZyM2OTIzMi4iCisgIChsZXQgKChld3ctYmVmb3JlLWJyb3dzZS1oaXN0 b3J5LWZ1bmN0aW9uICMnaWdub3JlKSkKKyAgICAoZXd3LXRlc3QtLXdpdGgtbW9jay1yZXRy aWV2ZQorICAgICAgKGV3dyAib25lLmludmFsaWQiKQorICAgICAgKGV3dyAidHdvLmludmFs aWQiKQorICAgICAgKGV3dyAidGhyZWUuaW52YWxpZCIpCisgICAgICAoZXd3LWJhY2stdXJs KQorICAgICAgKGV3dyAiZm91ci5pbnZhbGlkIikKKyAgICAgIChld3cgImZpdmUuaW52YWxp ZCIpCisgICAgICAoc2hvdWxkIChlcXVhbCAoZXd3LXRlc3QtLWhpc3RvcnktdXJscykgJygi aHR0cDovL2ZvdXIuaW52YWxpZC8iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiaHR0cDovL3RocmVlLmludmFsaWQvIgorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgImh0dHA6Ly90d28uaW52YWxp ZC8iCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAi aHR0cDovL29uZS5pbnZhbGlkLyIpKSkKKyAgICAgIChzaG91bGQgKD0gZXd3LWhpc3Rvcnkt cG9zaXRpb24gMCkpKSkpCisKKyhlcnQtZGVmdGVzdCBld3ctdGVzdC9oaXN0b3J5L2JlZm9y ZS1uYXZpZ2F0ZS9jbG9uZS1wcmV2aW91cyAoKQorICAiVGVzdCB0aGF0IGdvaW5nIHRvIGEg bmV3IHBhZ2UgZnJvbSBhIGhpc3RvcmljYWwgb25lIGNsb25lcyBwcmlvciBoaXN0b3J5Lgor VGhpcyBzZXRzIGBld3ctYmVmb3JlLWJyb3dzZS1oaXN0b3J5LWZ1bmN0aW9uJyB0bworYGV3 dy1jbG9uZS1wcmV2aW91cy1oaXN0b3J5JyB0byBjbG9uZSB0aGUgaGlzdG9yeS4gIFNlZSBi dWcjNjkyMzIuIgorICAobGV0ICgoZXd3LWJlZm9yZS1icm93c2UtaGlzdG9yeS1mdW5jdGlv biAjJ2V3dy1jbG9uZS1wcmV2aW91cy1oaXN0b3J5KSkKKyAgICAoZXd3LXRlc3QtLXdpdGgt bW9jay1yZXRyaWV2ZQorICAgICAgKGV3dyAib25lLmludmFsaWQiKQorICAgICAgKGV3dyAi dHdvLmludmFsaWQiKQorICAgICAgKGV3dyAidGhyZWUuaW52YWxpZCIpCisgICAgICAoZXd3 LWJhY2stdXJsKQorICAgICAgKGV3dyAiZm91ci5pbnZhbGlkIikKKyAgICAgIChld3cgImZp dmUuaW52YWxpZCIpCisgICAgICAoc2hvdWxkIChlcXVhbCAoZXd3LXRlc3QtLWhpc3Rvcnkt dXJscykKKyAgICAgICAgICAgICAgICAgICAgICcoOzsgTmV3IHBhZ2UgYW5kIGNsb25lZCBo aXN0b3J5LgorICAgICAgICAgICAgICAgICAgICAgICAiaHR0cDovL2ZvdXIuaW52YWxpZC8i CisgICAgICAgICAgICAgICAgICAgICAgICJodHRwOi8vdHdvLmludmFsaWQvIgorICAgICAg ICAgICAgICAgICAgICAgICAiaHR0cDovL29uZS5pbnZhbGlkLyIKKyAgICAgICAgICAgICAg ICAgICAgICAgOzsgT3JpZ2luYWwgaGlzdG9yeS4KKyAgICAgICAgICAgICAgICAgICAgICAg Imh0dHA6Ly90aHJlZS5pbnZhbGlkLyIKKyAgICAgICAgICAgICAgICAgICAgICAgImh0dHA6 Ly90d28uaW52YWxpZC8iCisgICAgICAgICAgICAgICAgICAgICAgICJodHRwOi8vb25lLmlu dmFsaWQvIikpKQorICAgICAgKHNob3VsZCAoPSBld3ctaGlzdG9yeS1wb3NpdGlvbiAwKSkp KSkKKworKHByb3ZpZGUgJ2V3dy10ZXN0cykKKzs7IGV3dy10ZXN0cy5lbCBlbmRzIGhlcmUK LS0gCjIuMjUuMQoK --------------C5T9UISQ3TNjfLiF0tUzqaQw-- From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 02 02:38:42 2024 Received: (at 69232) by debbugs.gnu.org; 2 Mar 2024 07:38:42 +0000 Received: from localhost ([127.0.0.1]:37895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rgJxC-0001Zt-8G for submit@debbugs.gnu.org; Sat, 02 Mar 2024 02:38:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51288) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rgJx9-0001Zg-U4 for 69232@debbugs.gnu.org; Sat, 02 Mar 2024 02:38:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rgJwc-00034u-Cp; Sat, 02 Mar 2024 02:38:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sEEfn6kgLlEurM/gzLteigsF6Knsvc8Mbd2C18dzEyw=; b=QwMM/+Guh0u5 SNJQy2/MW74kPIDqrcJw+Sj7lX07Nr4l2Ihw8JBQwa8aae193WZPKlsWXY3W0DBsn4DxlB/PL3htJ lV0QzmXPJA+83v6ABPAVXRAr/SskwHkc4EZUokcCK80U4CKHgEo5Iu7Q3/DXFqq/OojRggkCwANum QwVeCxlkYevV86+jEROJ9aKy0dYqAxv5tkXvCpM1HFtdTf1pbqNdwxoK7MKtEwW8kEV+CDvj5ulRS NazknEwl50owKiGoh7OLtR+sAKn+VUqe3BIn6FS60m9o1BtUuPZO2GXh+lTCulu6bpNQme8ssQ5eD eJ94/tYE+auozgiTx+KeVA==; Date: Sat, 02 Mar 2024 09:38:03 +0200 Message-Id: <86plwdozhg.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Fri, 1 Mar 2024 12:13:08 -0800) Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> <86plwfsqey.fsf@gnu.org> <77426857-4d81-29da-9b1a-70931393215e@gmail.com> <878r32u9ut.fsf@gmx.net> <99e36690-ffbe-f373-50d2-32c92717a560@gmail.com> <86wmqmquoe.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69232 Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 1 Mar 2024 12:13:08 -0800 > Cc: 69232@debbugs.gnu.org, jimjoe@gmx.net > From: Jim Porter > > > Therefore, I suggest a history-specific defcustom, whose possible > > values could be 'clear', 'clone', and 'add', and whose effect will be > > to call the corresponding function via eww-before-browse-function. > > The defcustom could also have a user-defined function value to allow > > additional functions, of course. > > I've done something close to this, though I retained the previous form > where the possible values are things like 'eww-delete-future-history'. > That keeps the code to *use* this option simpler (no special-case symbol > names), and the only difference with your suggestion is that users who > manually edit their init.el will have a longer symbol name to type. > > For Customize users, I added 'function-item' choices so they should just > be able to click on the option they want without having to worry about > the exact symbol name. > > If you strongly prefer to have this accept non-function symbol names > like 'clear', let me know and I can change it. I don't care too much, > but this way seemed simpler and easier to maintain. I think what you did is functionally equivalent, and not harder to use in practice. So I'm okay with this version of the patch. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 06 19:28:18 2024 Received: (at 69232-done) by debbugs.gnu.org; 7 Mar 2024 00:28:18 +0000 Received: from localhost ([127.0.0.1]:52119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ri1cP-0001tC-OX for submit@debbugs.gnu.org; Wed, 06 Mar 2024 19:28:17 -0500 Received: from mail-pg1-f180.google.com ([209.85.215.180]:45150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ri1cN-0001sy-6I for 69232-done@debbugs.gnu.org; Wed, 06 Mar 2024 19:28:15 -0500 Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-5d8b276979aso222915a12.2 for <69232-done@debbugs.gnu.org>; Wed, 06 Mar 2024 16:27:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709771198; x=1710375998; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=KYehtwRRLucN89zcNJszYQjlS6S8lExmK+Pm2iktAPg=; b=eBhybC2tiz4AcXTqciHPjFa+lQjjlkNGhN57Qou8NWYTLUAyhNKWP+O9D7MipJ7HHs 3fEqwCediPGlurypd4YYWGs/ouWAUjz4JaJcLX89msIQsYBb69qdV0b4tWNKTqgHar32 vWWy3k+KtQnyqammot19CBEDflSsKrk2PwItvKbbiGuySfJhkP3+O6AukDhkGzPJR+Ka awVV5IIo/1UOukevaxmogXRz35BaQnW9ml1Z+/3GjT62ZcyMcFxG4B2/DAtXu26rVsl9 IajRpBh6oN+QQx5eLokV+FUfaBSdY0kxlQMxAA3jjauQ6bGV69vJ4J+Y+zSmZ3X0CHGd yVFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709771198; x=1710375998; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KYehtwRRLucN89zcNJszYQjlS6S8lExmK+Pm2iktAPg=; b=C1rQ4A+1PnQzaqkPcPoX/drCLxMCUnJrv5deY1cHja3bUB6o58GhCADhdNVyyUltyj 0rcwdw4+zethtK3ow4W8AAn2g73OSQQTI3SjPlgVBEwCeMA4LGJY7iC5gi9JjV1xfKUi twus7QohRce1S6wzY06OXeUKoTlxns/cXyLuOmRP4Uw4Dfs/o/XL7yxOaaNcoBhmpI/P CvRjzJ8IXhT68Dno+uQgUKvDSKTUqwx3RdshZuhWjPdcHaTeVgvlQZZEaggFCI7YFBx6 37+xQOl9cEGSRgmuTEO67uAHizCPEfnmRPTzdatiAYS8zZkHl+LP/LfoFrxjZGOBquFY CovQ== X-Gm-Message-State: AOJu0Yx1NvCLKwnfOOVAYCY3YNJxNT9G8AtPhcU9yRULhPJKVn83VQw+ 4WCnJudU3x2mLA25gthqk+IpBT8wFU9NqxZkkyBlJFuR3DAwNR8u X-Google-Smtp-Source: AGHT+IFICbyWqu+fe5e/BqrKGGzVxce5uBsYKgZsSkiyE4Fl94z7m0kBjqxT261E2pns7chNTY6OZQ== X-Received: by 2002:a17:90a:3047:b0:29a:cbfb:5b28 with SMTP id q7-20020a17090a304700b0029acbfb5b28mr13563428pjl.13.1709771197908; Wed, 06 Mar 2024 16:26:37 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id o6-20020a17090ab88600b0029a56afe382sm309702pjr.39.2024.03.06.16.26.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Mar 2024 16:26:37 -0800 (PST) Message-ID: Date: Wed, 6 Mar 2024 16:26:36 -0800 MIME-Version: 1.0 Subject: Re: bug#69232: 30.0.50; [PATCH] EWW history navigation gets caught in a loop Content-Language: en-US To: Eli Zaretskii References: <8013cc7e-d5de-b793-261f-4b34fbdf360e@gmail.com> <864je4r6ug.fsf@gnu.org> <86y1bc1vn1.fsf@gnu.org> <557131a7-d400-cba5-2b0e-7ec99e8d7fc2@gmail.com> <86sf1k1fss.fsf@gnu.org> <969e4621-fd6f-48cb-2aef-d265971dd56a@gmail.com> <87r0h2x816.fsf@outlook.com> <8634tiymd4.fsf@gnu.org> <87cyslxziy.fsf@gmx.net> <86frxhxezx.fsf@gnu.org> <3f0da1b2-e256-6124-4d6a-47c922ccd64f@gmail.com> <86bk84wci4.fsf@gnu.org> <7b67c305-1e41-9db2-55d3-f74f1ac302a6@gmail.com> <10a0d839-24f6-b521-1504-a5ca568b3dcc@gmail.com> <86plwfsqey.fsf@gnu.org> <77426857-4d81-29da-9b1a-70931393215e@gmail.com> <878r32u9ut.fsf@gmx.net> <99e36690-ffbe-f373-50d2-32c92717a560@gmail.com> <86wmqmquoe.fsf@gnu.org> <86plwdozhg.fsf@gnu.org> From: Jim Porter In-Reply-To: <86plwdozhg.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69232-done Cc: 69232-done@debbugs.gnu.org, jimjoe@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 3/1/2024 11:38 PM, Eli Zaretskii wrote: > I think what you did is functionally equivalent, and not harder to use > in practice. So I'm okay with this version of the patch. Thanks. As it's been a couple of weeks since I posted about this on emacs-devel, and there haven't been any further comments, I've merged this to master as 59e470dd5de. If there are any followup issues about this though, just let me know. From unknown Sat Jun 21 10:40:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 04 Apr 2024 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator