GNU bug report logs - #69189
30.0.50; minibuffer-visible-completions doesn't work in completing-read-multiple

Previous Next

Full log

View this message in rfc822 format

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: 69189 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>, Juri Linkov <juri <at> linkov.net>
Subject: bug#69189: 30.0.50; minibuffer-visible-completions doesn't work in completing-read-multiple
Date: Wed, 07 Aug 2024 11:19:40 -0400

[Message part 1 (text/plain, inline)]

Here's a patch to fix this.

Eli, is this OK for emacs-30?  Since this is fixing a bug in a
customization which is new in Emacs 30.

[0001-Support-minibuffer-visible-completions-in-completing.patch (text/x-patch, inline)]

From 6688344ce5ffb0738751d83a4a8acc4068b453e5 Mon Sep 17 00:00:00 2001
From: Spencer Baugh <sbaugh <at> janestreet.com>
Date: Wed, 7 Aug 2024 11:18:02 -0400
Subject: [PATCH] Support minibuffer-visible-completions in
 completing-read-multiple

All that's required is to add minibuffer-visible-completions-map on
top of the completing-read-multiple map; this is the same thing that
minibuffer-visible-completions does in completing-read-default.

* lisp/emacs-lisp/crm.el (completing-read-multiple): Add
minibuffer-visible-completions-map (bug#69189)
---
 lisp/emacs-lisp/crm.el | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lisp/emacs-lisp/crm.el b/lisp/emacs-lisp/crm.el
index 253dfc6237a..422a8d52dcf 100644
--- a/lisp/emacs-lisp/crm.el
+++ b/lisp/emacs-lisp/crm.el
@@ -238,6 +238,11 @@ completing-read-multiple
   (let* ((map (if require-match
                   crm-local-must-match-map
                 crm-local-completion-map))
+         (map (if minibuffer-visible-completions
+                  (make-composed-keymap
+                   (list minibuffer-visible-completions-map
+                         map))
+                map))
          input)
     (minibuffer-with-setup-hook
         (lambda ()
-- 
2.39.3

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.