From unknown Sun Jun 22 07:37:11 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#69186 <69186@debbugs.gnu.org> To: bug#69186 <69186@debbugs.gnu.org> Subject: Status: [PATCH] Recognize functions and macros as defuns in cmake-ts-mode Reply-To: bug#69186 <69186@debbugs.gnu.org> Date: Sun, 22 Jun 2025 14:37:11 +0000 retitle 69186 [PATCH] Recognize functions and macros as defuns in cmake-ts-= mode reassign 69186 emacs submitter 69186 J=C3=B6rg Bornemann severity 69186 normal tag 69186 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 18 13:15:53 2024 Received: (at submit) by debbugs.gnu.org; 18 Feb 2024 18:15:53 +0000 Received: from localhost ([127.0.0.1]:36899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rblhe-0002RC-Ot for submit@debbugs.gnu.org; Sun, 18 Feb 2024 13:15:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:53956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rblQT-0001mW-Jx for submit@debbugs.gnu.org; Sun, 18 Feb 2024 12:58:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbRHm-0004RW-Mt for bug-gnu-emacs@gnu.org; Sat, 17 Feb 2024 15:27:46 -0500 Received: from ms-10.1blu.de ([178.254.4.101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rbRHk-0006PS-5n for bug-gnu-emacs@gnu.org; Sat, 17 Feb 2024 15:27:46 -0500 Received: from [93.228.120.14] (helo=barf.jbornemann.de) by ms-10.1blu.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rbRHg-005gs9-2Y for bug-gnu-emacs@gnu.org; Sat, 17 Feb 2024 21:27:40 +0100 From: =?utf-8?Q?J=C3=B6rg_Bornemann?= To: bug-gnu-emacs@gnu.org Subject: [PATCH] Recognize functions and macros as defuns in cmake-ts-mode Date: Sat, 17 Feb 2024 21:26:58 +0100 Message-ID: <8734tq4z1p.fsf@jbornemann.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Con-Id: 36794 X-Con-U: 0-foss X-Originating-IP: 93.228.120.14 Received-SPF: pass client-ip=178.254.4.101; envelope-from=foss@jbornemann.de; helo=ms-10.1blu.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 18 Feb 2024 13:15:48 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) --=-=-= Content-Type: text/plain Tags: patch This might exceed the lines of code for the Copyright-paperwork-exempt marker. From my side, FSF paperwork is done and my "assignment awaits a countersignature from the deputy directory" since a while. In the meantime, let's have this change reviewed. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-02-16 built on barf Repository revision: 4b89fb08bdd7d0249698bc0ed578555d6755724d Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12201009 System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure --with-x --with-x-toolkit=gtk3 --with-native-compilation --with-imagemagick --with-json --with-sound=alsa --with-mailutils --with-file-notification=yes --prefix /home/jobor/dev/emacs-master' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Recognize-functions-and-macros-as-defuns-in-cmake-ts.patch >From 474c7872ca1950761ed4b377e5e8477bb775965e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Bornemann?= Date: Sat, 17 Feb 2024 21:18:02 +0100 Subject: [PATCH] Recognize functions and macros as defuns in cmake-ts-mode * lisp/progmodes/cmake-ts-mode.el (cmake-ts-mode--function-name): Renamed to cmake-ts-mode--defun-name since the function handles now functions and macros. (cmake-ts-mode--defun-name): Return text of the first 'argument' node below 'function_def' and 'macro_def' nodes. (cmake-ts-mode): Set up treesit-defun-type-regexp and treesit-defun-name-function. Change the imenu setup to recognize macros too. Since we have set up treesit-defun-name-function, we don't have to pass cmake-ts-mode--function-name anymore. To make `treesit-defun-at-point' work properly, we have to recognize function_def/macro_def nodes, not the lower-level *_command nodes. --- lisp/progmodes/cmake-ts-mode.el | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/lisp/progmodes/cmake-ts-mode.el b/lisp/progmodes/cmake-ts-mode.el index 29c9e957d3c..850133ac935 100644 --- a/lisp/progmodes/cmake-ts-mode.el +++ b/lisp/progmodes/cmake-ts-mode.el @@ -193,13 +193,14 @@ cmake-ts-mode--font-lock-settings '((ERROR) @font-lock-warning-face)) "Tree-sitter font-lock settings for `cmake-ts-mode'.") -(defun cmake-ts-mode--function-name (node) - "Return the function name of NODE. -Return nil if there is no name or if NODE is not a function node." +(defun cmake-ts-mode--defun-name (node) + "Return the defun name of NODE. +Return nil if there is no name or if NODE is not a defun node. We +consider CMake functions and macros as defuns." (pcase (treesit-node-type node) - ("function_command" + ((or "function_def" "macro_def") (treesit-node-text - (treesit-search-subtree node "^argument$" nil nil 2) + (treesit-search-subtree node "^argument$" nil nil 3) t)))) ;;;###autoload @@ -216,9 +217,15 @@ cmake-ts-mode (setq-local comment-end "") (setq-local comment-start-skip (rx "#" (* (syntax whitespace)))) + ;; Defuns. + (setq-local treesit-defun-type-regexp (rx (or "function" "macro") + "_def")) + (setq-local treesit-defun-name-function #'cmake-ts-mode--defun-name) + ;; Imenu. (setq-local treesit-simple-imenu-settings - `(("Function" "\\`function_command\\'" nil cmake-ts-mode--function-name))) + `(("Function" "^function_def$") + ("Macro" "^macro_def$"))) (setq-local which-func-functions nil) ;; Indent. -- 2.39.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 20 11:08:34 2024 Received: (at 69186) by debbugs.gnu.org; 20 Feb 2024 16:08:34 +0000 Received: from localhost ([127.0.0.1]:46395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcSfZ-0005Oa-Ro for submit@debbugs.gnu.org; Tue, 20 Feb 2024 11:08:34 -0500 Received: from mail-4018.proton.ch ([185.70.40.18]:31567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcSfS-0005OG-6f for 69186@debbugs.gnu.org; Tue, 20 Feb 2024 11:08:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail; t=1708445276; x=1708704476; bh=rl/b9Ru4EMEwc8K0YLdjAA6MiRX92xFtdBoJjQblvqI=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=KdzSJt16SoTEaqsnp2bBDbHhiQWtwcBrc0066k7g6mnZCFjKJQixxhwMfI8Mq+NQ1 buCeLU/UbzLLc51NlEyX+iBSGu9TCfle8nbFuOq98/T3lspHFMm1AaIDPWnnm6MiTO Qmva9KQkLSrE8nPla3ObiijXkkBgbVxQzHepLgGDA7W2Rug72HhJyH0IyeSlD9xJfC sQwip2b47ZnQS2SlFfPdjZ6iqo3dAefeCe8nsD1gEveo1efPJm/pTHdu7+PaYfV5yV j8t+nAwf26ZH7pEpVQjAIcLuxNcPMFeXzSvWsAW4fj13juItxnOiFT6ct30A7TJD3N vnGO49R4XziHg== Date: Tue, 20 Feb 2024 16:07:46 +0000 To: =?utf-8?Q?J=C3=B6rg_Bornemann?= From: Randy Taylor Subject: Re: bug#69186: [PATCH] Recognize functions and macros as defuns in cmake-ts-mode Message-ID: In-Reply-To: <8734tq4z1p.fsf@jbornemann.de> References: <8734tq4z1p.fsf@jbornemann.de> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 69186 Cc: 69186@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) On Saturday, February 17th, 2024 at 15:26, J=C3=B6rg Bornemann wrote: >=20 >=20 > Tags: patch >=20 >=20 > This might exceed the lines of code for the Copyright-paperwork-exempt > marker. From my side, FSF paperwork is done and my "assignment awaits a > countersignature from the deputy directory" since a while. In the > meantime, let's have this change reviewed. Thanks, I'll try to take a look later tonight. From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 20 22:34:54 2024 Received: (at 69186) by debbugs.gnu.org; 21 Feb 2024 03:34:54 +0000 Received: from localhost ([127.0.0.1]:47534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcdNm-0006Xc-7e for submit@debbugs.gnu.org; Tue, 20 Feb 2024 22:34:54 -0500 Received: from mail-4022.proton.ch ([185.70.40.22]:53645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcdNj-0006XP-9Y for 69186@debbugs.gnu.org; Tue, 20 Feb 2024 22:34:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail; t=1708486462; x=1708745662; bh=jsj3UjREkgBhM5MSd6BMGVHN/a7FyKBm174ghTnnBLE=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=CojF9ktNqXXYkVDNw49xeaYmnU3SDPW/VH0cN0R0fO2nWo8P1DwUopgVTBjua6sjx tPrSW85sEWigVZuhW/lMbOJUlexy99IF8V1os1MBYSoY6rBdXIuwiFsCDS0+5JrOiT j2puIf0lV2uMvLhi46NvNTdLnLenX5Sv0etKZmVpnfR5IkZbTD8E5XvBBJV0aQdKN8 LP6ZhmaMgcg5KVlSgzyZWW3MmwWnx0eoNyDqdYfWtuV+w546U9FZsAUtcoIESynga9 77fFlqDv0ZyQGHpdjeQFQ7NklIrG+4aXEroZIgL5jqZjPXt/KLyhIONaSQzoqOpZRd +ckK3d3WpOMtA== Date: Wed, 21 Feb 2024 03:34:05 +0000 To: =?utf-8?Q?J=C3=B6rg_Bornemann?= From: Randy Taylor Subject: Re: bug#69186: [PATCH] Recognize functions and macros as defuns in cmake-ts-mode Message-ID: In-Reply-To: <8734tq4z1p.fsf@jbornemann.de> References: <8734tq4z1p.fsf@jbornemann.de> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 69186 Cc: 69186@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) On Saturday, February 17th, 2024 at 15:26, J=C3=B6rg Bornemann wrote: >=20 >=20 > Tags: patch >=20 >=20 > This might exceed the lines of code for the Copyright-paperwork-exempt > marker. From my side, FSF paperwork is done and my "assignment awaits a > countersignature from the deputy directory" since a while. In the > meantime, let's have this change reviewed. Thanks for working on this, it looks good to me. I have a few small nits: +(defun cmake-ts-mode--defun-name (node) + "Return the defun name of NODE. +Return nil if there is no name or if NODE is not a defun node. We +consider CMake functions and macros as defuns." I would drop the last sentence. In the commit message: (cmake-ts-mode): Set up treesit-defun-type-regexp and treesit-defun-name-function. Change the imenu setup to recognize macros One more space needed before "Change". From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 21 15:54:07 2024 Received: (at 69186) by debbugs.gnu.org; 21 Feb 2024 20:54:07 +0000 Received: from localhost ([127.0.0.1]:41340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rctbP-0007Tc-Vh for submit@debbugs.gnu.org; Wed, 21 Feb 2024 15:54:07 -0500 Received: from mail-41103.protonmail.ch ([185.70.41.103]:28663) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rctbE-0007ST-Fj for 69186@debbugs.gnu.org; Wed, 21 Feb 2024 15:54:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail; t=1708548801; x=1708808001; bh=F//5l6yvfvwpbCGwdEdbM4UjksG0+Hcio7BlZM20HLY=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=RrrHGG6swmHvrGQeczZadz7+QzmM8zO+YQR6oI/f/rAjIvebrSEst5D76irZc5hML D10fZN7+jbX9L9fQjdJss3V1H7v+87+VRV6cMGEtfmJYtyZ8Vxb0IrQKY+uLwsfEZw s5fH6NQz/WigXgRoU70uYPu0vdJ+MrnzcJiyrvz2XE86U/Z3ikBI7R8QMA8omgefRi GP7jxdFzVVGZtXHkB07+wLS/Vq9XHyv40pRzreCtuZyaoQwRl8jLWtrtzFl8NycBLK mdmKwM10IUgRHmpJ1LEMrBPZu16cUaicwxwExsNr204AfZfzotxaLns4+QAF8k1fSn pvR/T+h5jlSkw== Date: Wed, 21 Feb 2024 20:53:13 +0000 To: =?utf-8?Q?J=C3=B6rg_Bornemann?= From: Randy Taylor Subject: Re: bug#69186: [PATCH] Recognize functions and macros as defuns in cmake-ts-mode Message-ID: In-Reply-To: <6d1eabbc-36ee-4518-a0c4-eb6526590ed6@jbornemann.de> References: <8734tq4z1p.fsf@jbornemann.de> <6d1eabbc-36ee-4518-a0c4-eb6526590ed6@jbornemann.de> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 69186 Cc: 69186@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) On Wednesday, February 21st, 2024 at 15:05, J=C3=B6rg Bornemann wrote: >=20 >=20 > On 2/21/24 04:34, Randy Taylor wrote: >=20 > > Thanks for working on this, it looks good to me. >=20 >=20 > Thanks for the review! >=20 > > I have a few small nits: >=20 > [...] >=20 > I've picked the nits and rebased the change. > And the paperwork is also done from all sides now. >=20 >=20 > Cheers, >=20 > J=C3=B6rg Great, thanks! Can someone install this on master? Thanks in advance. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 22 00:15:54 2024 Received: (at 69186) by debbugs.gnu.org; 22 Feb 2024 05:15:54 +0000 Received: from localhost ([127.0.0.1]:49558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rd1R3-0007yk-8N for submit@debbugs.gnu.org; Thu, 22 Feb 2024 00:15:54 -0500 Received: from ms-10.1blu.de ([178.254.4.101]:35376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcsrH-0004xy-Lf for 69186@debbugs.gnu.org; Wed, 21 Feb 2024 15:06:25 -0500 Received: from [93.228.123.162] (helo=[192.168.188.102]) by ms-10.1blu.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rcsqt-00CyDB-Jr; Wed, 21 Feb 2024 21:05:59 +0100 Content-Type: multipart/mixed; boundary="------------YSEvy8VIZtUS1nPsiJLvmB4f" Message-ID: <6d1eabbc-36ee-4518-a0c4-eb6526590ed6@jbornemann.de> Date: Wed, 21 Feb 2024 21:05:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69186: [PATCH] Recognize functions and macros as defuns in cmake-ts-mode To: Randy Taylor References: <8734tq4z1p.fsf@jbornemann.de> Content-Language: en-US From: =?UTF-8?Q?J=C3=B6rg_Bornemann?= In-Reply-To: X-Con-Id: 36794 X-Con-U: 0-jb X-Originating-IP: 93.228.123.162 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 69186 X-Mailman-Approved-At: Thu, 22 Feb 2024 00:15:52 -0500 Cc: 69186@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) This is a multi-part message in MIME format. --------------YSEvy8VIZtUS1nPsiJLvmB4f Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/21/24 04:34, Randy Taylor wrote: > Thanks for working on this, it looks good to me. Thanks for the review! > I have a few small nits: [...] I've picked the nits and rebased the change. And the paperwork is also done from all sides now. Cheers, Jörg --------------YSEvy8VIZtUS1nPsiJLvmB4f Content-Type: text/x-patch; charset=UTF-8; name="0001-Recognize-functions-and-macros-as-defuns-in-cmake-ts.patch" Content-Disposition: attachment; filename*0="0001-Recognize-functions-and-macros-as-defuns-in-cmake-ts.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBlYjQ4Mjg4ZGVmMDZhMzBiN2ExMmMxNjY0ODk3MDkzZTIyNmNjYTIxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sj1DMz1CNnJnPTIwQm9ybmVtYW5u Pz0gPGZvc3NAamJvcm5lbWFubi5kZT4KRGF0ZTogU2F0LCAxNyBGZWIgMjAyNCAyMToxODow MiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIFJlY29nbml6ZSBmdW5jdGlvbnMgYW5kIG1hY3Jv cyBhcyBkZWZ1bnMgaW4gY21ha2UtdHMtbW9kZQoKKiBsaXNwL3Byb2dtb2Rlcy9jbWFrZS10 cy1tb2RlLmVsIChjbWFrZS10cy1tb2RlLS1mdW5jdGlvbi1uYW1lKToKUmVuYW1lZCB0byBj bWFrZS10cy1tb2RlLS1kZWZ1bi1uYW1lIHNpbmNlIHRoZSBmdW5jdGlvbiBoYW5kbGVzIG5v dwpmdW5jdGlvbnMgYW5kIG1hY3Jvcy4KKGNtYWtlLXRzLW1vZGUtLWRlZnVuLW5hbWUpOiBS ZXR1cm4gdGV4dCBvZiB0aGUgZmlyc3QgJ2FyZ3VtZW50JyBub2RlCmJlbG93ICdmdW5jdGlv bl9kZWYnIGFuZCAnbWFjcm9fZGVmJyBub2Rlcy4KKGNtYWtlLXRzLW1vZGUpOiBTZXQgdXAg dHJlZXNpdC1kZWZ1bi10eXBlLXJlZ2V4cCBhbmQKdHJlZXNpdC1kZWZ1bi1uYW1lLWZ1bmN0 aW9uLiAgQ2hhbmdlIHRoZSBpbWVudSBzZXR1cCB0byByZWNvZ25pemUgbWFjcm9zCnRvby4g IFNpbmNlIHdlIGhhdmUgc2V0IHVwIHRyZWVzaXQtZGVmdW4tbmFtZS1mdW5jdGlvbiwgd2Ug ZG9uJ3QgaGF2ZSB0bwpwYXNzIGNtYWtlLXRzLW1vZGUtLWZ1bmN0aW9uLW5hbWUgYW55bW9y ZS4KClRvIG1ha2UgYHRyZWVzaXQtZGVmdW4tYXQtcG9pbnQnIHdvcmsgcHJvcGVybHksIHdl IGhhdmUgdG8gcmVjb2duaXplCmZ1bmN0aW9uX2RlZi9tYWNyb19kZWYgbm9kZXMsIG5vdCB0 aGUgbG93ZXItbGV2ZWwgKl9jb21tYW5kIG5vZGVzLgotLS0KIGxpc3AvcHJvZ21vZGVzL2Nt YWtlLXRzLW1vZGUuZWwgfCAxOCArKysrKysrKysrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2Vk LCAxMiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Av cHJvZ21vZGVzL2NtYWtlLXRzLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy9jbWFrZS10cy1t b2RlLmVsCmluZGV4IDI5YzllOTU3ZDNjLi40NWM0ODgyZDg3MyAxMDA2NDQKLS0tIGEvbGlz cC9wcm9nbW9kZXMvY21ha2UtdHMtbW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9jbWFr ZS10cy1tb2RlLmVsCkBAIC0xOTMsMTMgKzE5MywxMyBAQCBjbWFrZS10cy1tb2RlLS1mb250 LWxvY2stc2V0dGluZ3MKICAgICcoKEVSUk9SKSBAZm9udC1sb2NrLXdhcm5pbmctZmFjZSkp CiAgICJUcmVlLXNpdHRlciBmb250LWxvY2sgc2V0dGluZ3MgZm9yIGBjbWFrZS10cy1tb2Rl Jy4iKQogCi0oZGVmdW4gY21ha2UtdHMtbW9kZS0tZnVuY3Rpb24tbmFtZSAobm9kZSkKLSAg IlJldHVybiB0aGUgZnVuY3Rpb24gbmFtZSBvZiBOT0RFLgotUmV0dXJuIG5pbCBpZiB0aGVy ZSBpcyBubyBuYW1lIG9yIGlmIE5PREUgaXMgbm90IGEgZnVuY3Rpb24gbm9kZS4iCisoZGVm dW4gY21ha2UtdHMtbW9kZS0tZGVmdW4tbmFtZSAobm9kZSkKKyAgIlJldHVybiB0aGUgZGVm dW4gbmFtZSBvZiBOT0RFLgorUmV0dXJuIG5pbCBpZiB0aGVyZSBpcyBubyBuYW1lIG9yIGlm IE5PREUgaXMgbm90IGEgZGVmdW4gbm9kZS4iCiAgIChwY2FzZSAodHJlZXNpdC1ub2RlLXR5 cGUgbm9kZSkKLSAgICAoImZ1bmN0aW9uX2NvbW1hbmQiCisgICAgKChvciAiZnVuY3Rpb25f ZGVmIiAibWFjcm9fZGVmIikKICAgICAgKHRyZWVzaXQtbm9kZS10ZXh0Ci0gICAgICAodHJl ZXNpdC1zZWFyY2gtc3VidHJlZSBub2RlICJeYXJndW1lbnQkIiBuaWwgbmlsIDIpCisgICAg ICAodHJlZXNpdC1zZWFyY2gtc3VidHJlZSBub2RlICJeYXJndW1lbnQkIiBuaWwgbmlsIDMp CiAgICAgICB0KSkpKQogCiA7OzsjIyNhdXRvbG9hZApAQCAtMjE2LDkgKzIxNiwxNSBAQCBj bWFrZS10cy1tb2RlCiAgICAgKHNldHEtbG9jYWwgY29tbWVudC1lbmQgIiIpCiAgICAgKHNl dHEtbG9jYWwgY29tbWVudC1zdGFydC1za2lwIChyeCAiIyIgKCogKHN5bnRheCB3aGl0ZXNw YWNlKSkpKQogCisgICAgOzsgRGVmdW5zLgorICAgIChzZXRxLWxvY2FsIHRyZWVzaXQtZGVm dW4tdHlwZS1yZWdleHAgKHJ4IChvciAiZnVuY3Rpb24iICJtYWNybyIpCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIl9kZWYiKSkKKyAgICAoc2V0 cS1sb2NhbCB0cmVlc2l0LWRlZnVuLW5hbWUtZnVuY3Rpb24gIydjbWFrZS10cy1tb2RlLS1k ZWZ1bi1uYW1lKQorCiAgICAgOzsgSW1lbnUuCiAgICAgKHNldHEtbG9jYWwgdHJlZXNpdC1z aW1wbGUtaW1lbnUtc2V0dGluZ3MKLSAgICAgICAgICAgICAgICBgKCgiRnVuY3Rpb24iICJc XGBmdW5jdGlvbl9jb21tYW5kXFwnIiBuaWwgY21ha2UtdHMtbW9kZS0tZnVuY3Rpb24tbmFt ZSkpKQorICAgICAgICAgICAgICAgIGAoKCJGdW5jdGlvbiIgIl5mdW5jdGlvbl9kZWYkIikK KyAgICAgICAgICAgICAgICAgICgiTWFjcm8iICJebWFjcm9fZGVmJCIpKSkKICAgICAoc2V0 cS1sb2NhbCB3aGljaC1mdW5jLWZ1bmN0aW9ucyBuaWwpCiAKICAgICA7OyBJbmRlbnQuCi0t IAoyLjM5LjIKCg== --------------YSEvy8VIZtUS1nPsiJLvmB4f-- From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 22 08:04:33 2024 Received: (at 69186-done) by debbugs.gnu.org; 22 Feb 2024 13:04:33 +0000 Received: from localhost ([127.0.0.1]:53433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rd8kb-0002UT-Ir for submit@debbugs.gnu.org; Thu, 22 Feb 2024 08:04:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rd8kZ-0002UB-F9 for 69186-done@debbugs.gnu.org; Thu, 22 Feb 2024 08:04:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rd8k4-0006uV-7J; Thu, 22 Feb 2024 08:04:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=eM4H0b05P60HJqsMQVDUUPkAxzeTCsoCrdWoJiyE/4Y=; b=U35FnL/Yh/U+XuKlcNd8 YuS5jJKxJE2UHhn/4azm1vbSNX7UlLsyHpw8i3m4vtq8QxfxHZn6kvgt0Thwm2auoN7RXcOKY0mHc dWND3RCtYkwFxVHH3XMv2MWKHhlwyHSr6aGa5llmpWfcjhaMeD29lC5smAA5WDIbW2GG9J0vElK+S 8h0IcZPCYvAL4Gws1jV3O4O/b993sH2QQsv54+EHEo/WtK7M2jIHsztYTo7+P+y+rr3mOlQ+hkMCK tREbVCLBvkzRL/cY+RMxpPsgikNaXdDIWY636NrPq60O98g2WSZw4LM/Js3kcbaxzLvLqTfb4cLAi Gd4cG2pqkBAEMw==; Date: Thu, 22 Feb 2024 15:03:57 +0200 Message-Id: <861q943b2a.fsf@gnu.org> From: Eli Zaretskii To: =?utf-8?Q?J=C3=B6rg?= Bornemann In-Reply-To: <6d1eabbc-36ee-4518-a0c4-eb6526590ed6@jbornemann.de> (message from =?utf-8?Q?J=C3=B6rg?= Bornemann on Wed, 21 Feb 2024 21:05:59 +0100) Subject: Re: bug#69186: [PATCH] Recognize functions and macros as defuns in cmake-ts-mode References: <8734tq4z1p.fsf@jbornemann.de> <6d1eabbc-36ee-4518-a0c4-eb6526590ed6@jbornemann.de> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 69186-done Cc: dev@rjt.dev, 69186-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) > Cc: 69186@debbugs.gnu.org > Date: Wed, 21 Feb 2024 21:05:59 +0100 > From: Jörg Bornemann > > On 2/21/24 04:34, Randy Taylor wrote: > > > Thanks for working on this, it looks good to me. > > Thanks for the review! > > > I have a few small nits: > [...] > > I've picked the nits and rebased the change. > And the paperwork is also done from all sides now. Thanks, installed on master, and closing the bug. From unknown Sun Jun 22 07:37:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 22 Mar 2024 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator