GNU bug report logs - #69169
[PATCH 00/46] Add netavark

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69169 in the body.
You can then email your comments to 69169 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: guix-patches <at> gnu.org
Cc: Tomas Volf <~@wolfsden.cz>
Subject: [PATCH 00/46] Add netavark
Date: Thu, 15 Feb 2024 21:20:01 +0100

This series adds netavark, which will be required for next major version of
podman.

It also adds new #:cargo-native-inputs argument to the build system in order
to support crates that call native tooling during a build (prost-build)
without the need to have (native-inputs) on all user.

Tomas Volf (46):
  build-system: cargo: Add #:cargo-native-inputs argument.
  gnu: Add rust-pulldown-cmark-to-cmark-10.
  gnu: Add rust-sync-wrapper-0.1.
  gnu: Add rust-multer-2.
  gnu: Add rust-iri-string-0.7.
  gnu: Add rust-tower-http-0.4.
  gnu: Add rust-axum-macros-0.3.
  gnu: Add rust-axum-core-0.3.
  gnu: Add rust-axum-0.6.
  gnu: rust-async-stream-impl-0.3: Update to 0.3.5.
  gnu: rust-async-stream-0.3: Update to 0.3.5.
  gnu: Add rust-sysctl-0.5.
  gnu: Add rust-prost-derive-0.12.
  gnu: Add rust-prost-0.12.
  gnu: Add rust-prost-types-0.12.
  gnu: Add rust-prost-build-0.12.
  gnu: Add rust-tonic-build-0.10.
  gnu: Add rust-tonic-0.10.
  gnu: Add rust-nftables-0.3.
  gnu: Add rust-netlink-sys-0.8.
  gnu: Add rust-netlink-packet-utils-0.5.
  gnu: Add rust-netlink-packet-core-0.7.
  gnu: Add rust-netlink-packet-generic-0.3.
  gnu: Add rust-netlink-packet-route-0.18.
  gnu: Add rust-netlink-packet-route-0.19.
  gnu: Add rust-netlink-proto-0.11.
  gnu: Add rust-genetlink-0.2.
  gnu: Add rust-mptcp-pm-0.1.
  gnu: Add rust-rtnetlink-0.14.
  gnu: Add rust-ethtool-0.2.
  gnu: Add rust-nispor-1.
  gnu: Add rust-etherparse-0.13.
  gnu: Add rust-dhcproto-macros-0.1.
  gnu: Add rust-dhcproto-0.9.
  gnu: Add rust-mozim-0.2.
  gnu: Add rust-iptables-0.5.
  gnu: Add rust-env-filter-0.1.
  gnu: rust-anstyle-1: Update to 1.0.6.
  gnu: Add rust-env-logger-0.11.
  gnu: rust-rkyv-derive-0.7: Update to 0.7.44.
  gnu: rust-rkyv-0.7: Update to 0.7.44.
  gnu: Add rust-pure-rust-locales-0.8.
  gnu: Add rust-windows-metadata-0.52.
  gnu: Add rust-windows-bindgen-0.52.
  gnu: rust-chrono-0.4: Update to 0.4.34.
  gnu: Add netavark.

 doc/guix.texi                   |   4 +-
 gnu/packages/crates-io.scm      | 881 +++++++++++++++++++++++++++++++-
 gnu/packages/crates-web.scm     | 218 ++++++++
 gnu/packages/crates-windows.scm |  41 ++
 gnu/packages/rust-apps.scm      |  57 +++
 guix/build-system/cargo.scm     |  17 +-
 6 files changed, 1194 insertions(+), 24 deletions(-)


base-commit: c5a716a965ca8881a9fb150c2cee8da4c1e62d10
--
2.41.0

Message #10 received at 69169-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Tomas Volf <~@wolfsden.cz>
Cc: 69170-done <at> debbugs.gnu.org, 69169-done <at> debbugs.gnu.org
Subject: Re: [bug#69170] [PATCH rust-team 00/46] Add netavark
Date: Sun, 18 Feb 2024 14:39:23 +0200

[Message part 1 (text/plain, inline)]

I pushed the patches to the rust-team branch without the change for
cargo-native-inputs and without the snippet for prost-build.  I also
adjusted some of the patches so that the packages built.

On Thu, Feb 15, 2024 at 09:25:48PM +0100, Tomas Volf wrote:
> This series adds netavark, which will be required for next major version of
> podman.
> 
> It also adds new #:cargo-native-inputs argument to the build system in order
> to support crates that call native tooling during a build (prost-build)
> without the need to have (native-inputs) on all user.
> 
> Tomas Volf (46):
>   build-system: cargo: Add #:cargo-native-inputs argument.
>   gnu: Add rust-pulldown-cmark-to-cmark-10.
>   gnu: Add rust-sync-wrapper-0.1.
>   gnu: Add rust-multer-2.
>   gnu: Add rust-iri-string-0.7.
>   gnu: Add rust-tower-http-0.4.
>   gnu: Add rust-axum-macros-0.3.
>   gnu: Add rust-axum-core-0.3.
>   gnu: Add rust-axum-0.6.
>   gnu: rust-async-stream-impl-0.3: Update to 0.3.5.
>   gnu: rust-async-stream-0.3: Update to 0.3.5.
>   gnu: Add rust-sysctl-0.5.
>   gnu: Add rust-prost-derive-0.12.
>   gnu: Add rust-prost-0.12.
>   gnu: Add rust-prost-types-0.12.
>   gnu: Add rust-prost-build-0.12.
>   gnu: Add rust-tonic-build-0.10.
>   gnu: Add rust-tonic-0.10.
>   gnu: Add rust-nftables-0.3.
>   gnu: Add rust-netlink-sys-0.8.
>   gnu: Add rust-netlink-packet-utils-0.5.
>   gnu: Add rust-netlink-packet-core-0.7.
>   gnu: Add rust-netlink-packet-generic-0.3.
>   gnu: Add rust-netlink-packet-route-0.18.
>   gnu: Add rust-netlink-packet-route-0.19.
>   gnu: Add rust-netlink-proto-0.11.
>   gnu: Add rust-genetlink-0.2.
>   gnu: Add rust-mptcp-pm-0.1.
>   gnu: Add rust-rtnetlink-0.14.
>   gnu: Add rust-ethtool-0.2.
>   gnu: Add rust-nispor-1.
>   gnu: Add rust-etherparse-0.13.
>   gnu: Add rust-dhcproto-macros-0.1.
>   gnu: Add rust-dhcproto-0.9.
>   gnu: Add rust-mozim-0.2.
>   gnu: Add rust-iptables-0.5.
>   gnu: Add rust-env-filter-0.1.
>   gnu: rust-anstyle-1: Update to 1.0.6.
>   gnu: Add rust-env-logger-0.11.
>   gnu: rust-rkyv-derive-0.7: Update to 0.7.44.
>   gnu: rust-rkyv-0.7: Update to 0.7.44.
>   gnu: Add rust-pure-rust-locales-0.8.
>   gnu: Add rust-windows-metadata-0.52.
>   gnu: Add rust-windows-bindgen-0.52.
>   gnu: rust-chrono-0.4: Update to 0.4.34.
>   gnu: Add netavark.
> 
>  doc/guix.texi                   |   4 +-
>  gnu/packages/crates-io.scm      | 881 +++++++++++++++++++++++++++++++-
>  gnu/packages/crates-web.scm     | 218 ++++++++
>  gnu/packages/crates-windows.scm |  41 ++
>  gnu/packages/rust-apps.scm      |  57 +++
>  guix/build-system/cargo.scm     |  17 +-
>  6 files changed, 1194 insertions(+), 24 deletions(-)
> 
> 
> base-commit: c5a716a965ca8881a9fb150c2cee8da4c1e62d10
> --
> 2.41.0
> 
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 69169 <at> debbugs.gnu.org (full text, mbox):

From: Tomas Volf <~@wolfsden.cz>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 69170 <at> debbugs.gnu.org, 69169 <at> debbugs.gnu.org
Subject: Re: [bug#69170] [PATCH rust-team 00/46] Add netavark
Date: Sun, 18 Feb 2024 15:04:12 +0100

[Message part 1 (text/plain, inline)]

On 2024-02-18 14:39:23 +0200, Efraim Flashner wrote:
> I pushed the patches to the rust-team branch without the change for
> cargo-native-inputs and without the snippet for prost-build.  I also
> adjusted some of the patches so that the packages built.

Well I am just happy it was merged, so no complains here, but I have to admit I
am curious.  Is it really expected that every user of prost-build will need to
add protobuf into native-inputs?

What if, in some new version, it starts requiring some-other-package instead of
protobuf?  All the downstream users will need to be adjusted as well.  That
seems somewhat sub-optimal.  So I am trying to understand the reasoning here.

Thanks and have a nice day,
Tomas Volf

--
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 69169 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Tomas Volf <~@wolfsden.cz>
Cc: 69170 <at> debbugs.gnu.org, 69169 <at> debbugs.gnu.org
Subject: Re: [bug#69170] [PATCH rust-team 00/46] Add netavark
Date: Tue, 20 Feb 2024 09:50:23 +0200

[Message part 1 (text/plain, inline)]

On Sun, Feb 18, 2024 at 03:04:12PM +0100, Tomas Volf wrote:
> On 2024-02-18 14:39:23 +0200, Efraim Flashner wrote:
> > I pushed the patches to the rust-team branch without the change for
> > cargo-native-inputs and without the snippet for prost-build.  I also
> > adjusted some of the patches so that the packages built.
> 
> Well I am just happy it was merged, so no complains here, but I have to admit I
> am curious.  Is it really expected that every user of prost-build will need to
> add protobuf into native-inputs?

Only in situations where it is needed.  In actuality we only needed it
in prost-build itself and in netavark.

> What if, in some new version, it starts requiring some-other-package instead of
> protobuf?  All the downstream users will need to be adjusted as well.  That
> seems somewhat sub-optimal.  So I am trying to understand the reasoning here.

The patch you sent hardcoded the path to protobuf into the source of
prost-build, which we try not to do.  Also, using something like
cargo-native-inputs is (to me) a little "too magical" to make sure that
we have the required native-inputs in future builds.  However! Don't let
me nay-say it, if you feel strongly about it then do continue to push
for it. Ideally we'd have a true graph of the dependencies among the
rust packages rather than cargo-inputs and cargo-development-inputs, but
we still don't have anything like the antioxidant-build-system yet.

Another package which had to have an included perl dependency everywhere
was the rust-ring packages. In the end I ended up going and rebuilding
nearly all the pre-generated files in the sources so that we would have
a ready-to-use source tarball without the need for perl everywhere.
Seeing that protobuf was only needed in these two packages I don't think
prost-build needs that currently, but it's also an option.

> Thanks and have a nice day,
> Tomas Volf
> 
> --
> There are only two hard things in Computer Science:
> cache invalidation, naming things and off-by-one errors.



-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.