GNU bug report logs - #69166
[PATCH 0/2] Fix random test failures and update leptonica

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69166 in the body.
You can then email your comments to 69166 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: guix-patches <at> gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH 0/2] Fix random test failures and update leptonica
Date: Thu, 15 Feb 2024 16:44:10 +0400

Hello Guix,

This series fixes random test failures I observed while building leptonica,
and updates it to the latest version while we're at it.

I observed, on Debian and Guix (guix shell -D ...), that running the tests in
parallel (e.g. "make check -j16") fails sometimes. And building leptonica using
"guix build leptonica --check --rounds=10 --no-grafts" fails for me every
time. It doesn't fail anymore when disabling parallel tests.

This fixes #65441.

Ahmad Draidi (2):
  gnu: leptonica: Fix random test failures.
  gnu: leptonica: Update to 1.84.1.

 gnu/packages/image.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)


base-commit: 06014750338159a03a6374d7ebdd783c210b3715
-- 
2.41.0

Message #8 received at 69166 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 69166 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH 1/2] gnu: leptonica: Fix random test failures.
Date: Thu, 15 Feb 2024 16:55:22 +0400

Fixes <https://issues.guix.gnu.org/65441>.

Running tests in parallel (e.g. "make check -j16") causes random test
failures. Same behavior observed on Debian.

* gnu/packages/image.scm (leptonica)[arguments]: Disable parallel tests.

Change-Id: I629c6c8be626a704be046dc79ea4480896cd11cc
---
 gnu/packages/image.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 1f434667f8..8ca928c616 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -779,6 +779,8 @@ (define-public leptonica
            zlib))
     (arguments
      (list
+      ;; Parallel tests cause some tests to fail randomly. Same thing observed on Debian.
+      #:parallel-tests? #f
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'unpack 'patch-reg-wrapper
-- 
2.41.0

Message #11 received at 69166 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 69166 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH 2/2] gnu: leptonica: Update to 1.84.1.
Date: Thu, 15 Feb 2024 16:55:23 +0400

* gnu/packages/image.scm (leptonica): Update to 1.84.1.

Change-Id: I9070ca7f08c0c3114fa7a5a414695051b587f00b
---
 gnu/packages/image.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
index 8ca928c616..4eeedeed59 100644
--- a/gnu/packages/image.scm
+++ b/gnu/packages/image.scm
@@ -752,7 +752,7 @@ (define-public libtiff
 (define-public leptonica
   (package
     (name "leptonica")
-    (version "1.83.1")
+    (version "1.84.1")
     (source
      (origin
        (method git-fetch)
@@ -761,7 +761,7 @@ (define-public leptonica
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "1j7qf9flb48q0aymf0yx9rypy3bs6hfjcln08zmy8qn2qcjzrmvi"))))
+        (base32 "0b4ikf1p2ll4310n4dg5lg0b79wys71fb6nj22i7pz17wjdma0j8"))))
     (build-system gnu-build-system)
     (native-inputs
      (list gnuplot ;needed for test suite
-- 
2.41.0

Message #16 received at 69166-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Ahmad Draidi <a.r.draidi <at> redscript.org>
Cc: 69166-done <at> debbugs.gnu.org
Subject: Re: [bug#69166] [PATCH 0/2] Fix random test failures and update
 leptonica
Date: Sat, 24 Feb 2024 10:24:25 +0000

[Message part 1 (text/plain, inline)]

Patches applied as df5653adcbd1f9799f810f46d514b2ca4112af97 and
following.
Thanks.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.