From unknown Sun Jun 22 00:52:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69141: [PATCH] Allow attaching files at point using 'gnus-dired-attach' Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Feb 2024 11:59:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 69141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 69141@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.170799829324976 (code B ref -1); Thu, 15 Feb 2024 11:59:03 +0000 Received: (at submit) by debbugs.gnu.org; 15 Feb 2024 11:58:13 +0000 Received: from localhost ([127.0.0.1]:54235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raaNY-0006Ug-QK for submit@debbugs.gnu.org; Thu, 15 Feb 2024 06:58:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:42358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raaNS-0006TL-TF for submit@debbugs.gnu.org; Thu, 15 Feb 2024 06:58:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raZfC-0006cp-KH for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 06:12:22 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raZfA-00065L-Vs for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 06:12:22 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 05E86240101 for ; Thu, 15 Feb 2024 12:12:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707995538; bh=84iJZu0RPYjfe1igP10iKPlyuR8ufREqtGjRVKfjNIY=; h=From:To:Subject:OpenPGP:Date:Message-ID:MIME-Version:Content-Type: From; b=SRF3yO8OmkYF7EfM+iFC4aiw5Klxgni56hQvgALb9Bzp0jYNSeC/8pEHUP0mfpJKe 7ap7/R1uYl9MJannyaRt0GZXsNbOThzf21FlA2ylLcDHs2knf9T5pD9EmuhAlELRYP HSWv3H1GyuBk4Zuy9p9+3Ceio4wPawhd9KBBlrZh7s+8KWXFYMrYsliE80SVGvODm6 jC/RbihZJmIM4GOHQQZQfHANvyxRjQClE6zOQZ9UhNzjtjMWTJfiMGCZkbK95+TJ2a EBPiee4qUoZZ3cFBqGT30dyIoB8wxxA6v31IaT6vEQJIeiHUK3hdYGA3ccsed86geX 9z/EzhoApDzmg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TbC813jlkz6ty8 for ; Thu, 15 Feb 2024 12:12:17 +0100 (CET) From: Philip Kaludercic OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Thu, 15 Feb 2024 11:12:16 +0000 Message-ID: <87v86qnfqn.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) --=-=-= Content-Type: text/plain I use this command frequently, and am just as frequently mildly annoyed that attachments are always added at the bottom of the message buffer, instead of at point as is the case with 'mml-attach-file' (usually this is mild enough that I'd immediately forget about it). This patch allows disabling the behaviour: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Allow-attaching-files-at-point-using-'gnus-dired-a.patch Content-Description: [PATCH] Allow attaching files at point using 'gnus-dired-attach' >From 9a5e9c51e74a278580eb670769b6093388a6109a Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Thu, 15 Feb 2024 12:10:12 +0100 Subject: [PATCH] Allow attaching files at point using 'gnus-dired-attach' * lisp/gnus/gnus-dired.el (gnus-dired-attach-at-end): Add option. (gnus-dired-attach): Respect it. --- lisp/gnus/gnus-dired.el | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lisp/gnus/gnus-dired.el b/lisp/gnus/gnus-dired.el index 48c1aef968b..740caab349d 100644 --- a/lisp/gnus/gnus-dired.el +++ b/lisp/gnus/gnus-dired.el @@ -111,6 +111,11 @@ gnus-dired-mail-buffers (autoload 'gnus-completing-read "gnus-util") +(defcustom gnus-dired-attach-at-end t + "Non-nil means that files should be attached at the end of a buffer." + :group 'mail ;; dired? + :type 'boolean) + ;; Method to attach files to a mail composition. (defun gnus-dired-attach (files-to-attach) "Attach dired's marked files to a gnus message composition. @@ -161,7 +166,8 @@ gnus-dired-attach ;; set buffer to destination buffer, and attach files (set-buffer destination) - (goto-char (point-max)) ;attach at end of buffer + (when gnus-dired-attach-at-end + (goto-char (point-max))) ;attach at end of buffer (while files-to-attach (mml-attach-file (car files-to-attach) (or (mm-default-file-type (car files-to-attach)) -- 2.43.0 --=-=-=-- From unknown Sun Jun 22 00:52:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69141: [PATCH] Allow attaching files at point using 'gnus-dired-attach' Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Feb 2024 18:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 69141@debbugs.gnu.org Received: via spool by 69141-submit@debbugs.gnu.org id=B69141.170819344629207 (code B ref 69141); Sat, 17 Feb 2024 18:11:01 +0000 Received: (at 69141) by debbugs.gnu.org; 17 Feb 2024 18:10:46 +0000 Received: from localhost ([127.0.0.1]:33825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbP9C-0007b0-F6 for submit@debbugs.gnu.org; Sat, 17 Feb 2024 13:10:46 -0500 Received: from mail.ericabrahamsen.net ([52.70.2.18]:57314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbP9A-0007ao-Db for 69141@debbugs.gnu.org; Sat, 17 Feb 2024 13:10:45 -0500 Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 4DDD6FA183; Sat, 17 Feb 2024 18:10:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1708193418; bh=MJmtJm5bpdMwljcnCCmSaeBM6pY4wj6grHaBuNi59eA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=nW8JWVlaXL7HkoY210FOw7rLBYhRHx4z+9ZG9XAUGZjdT2WTXtjB+Cx3W9IO3NjYG 8r+zWiW7h+6zthylBmg6rSbNds0xgkjgc+DYeVKvatOTTmdqFSJ5hAILWTKv5rF3Sb cBRgDZGw6BbALsfo0bAlTrSlVi5Y11SHD86JjEMc= From: Eric Abrahamsen In-Reply-To: <87v86qnfqn.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 15 Feb 2024 11:12:16 +0000") References: <87v86qnfqn.fsf@posteo.net> Date: Sat, 17 Feb 2024 10:10:16 -0800 Message-ID: <87bk8fq7w7.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) Philip Kaludercic writes: > I use this command frequently, and am just as frequently mildly annoyed > that attachments are always added at the bottom of the message buffer, > instead of at point as is the case with 'mml-attach-file' (usually this > is mild enough that I'd immediately forget about it). This patch allows > disabling the behaviour: This looks fine to me, thank you. Would you add a :version to the defcustom, and also a mention (with index entry) in the Gnus manual, "Interaction with other modes -> Dired"? I guess 'mail is a fine group for the defcustom, kind of hard to say. From unknown Sun Jun 22 00:52:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69141: [PATCH] Allow attaching files at point using 'gnus-dired-attach' Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Feb 2024 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eric Abrahamsen Cc: 69141@debbugs.gnu.org Received: via spool by 69141-submit@debbugs.gnu.org id=B69141.170835809427568 (code B ref 69141); Mon, 19 Feb 2024 15:55:02 +0000 Received: (at 69141) by debbugs.gnu.org; 19 Feb 2024 15:54:54 +0000 Received: from localhost ([127.0.0.1]:43241 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc5yn-0007AZ-L3 for submit@debbugs.gnu.org; Mon, 19 Feb 2024 10:54:54 -0500 Received: from mout01.posteo.de ([185.67.36.65]:42351) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc5yl-0007AG-4b for 69141@debbugs.gnu.org; Mon, 19 Feb 2024 10:54:52 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 93267240028 for <69141@debbugs.gnu.org>; Mon, 19 Feb 2024 16:54:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1708358063; bh=sA+9nL9f7a/vAxkq6VT6XG1N7j0ZqQR0Cg5nIXkCTXA=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=YFHg8xEQ5mtSSVyM51npQk7LALM97InooH413MACsJbQYa8qv1YEAIcBY9a1Pmk7w uSFrjU9Vcd5x0RyDtAVbcjml8Ew800+4Vlz9PEO+Y/0zbVjUGOszyQs87SzRBFEaDE lIvPiRC1wRa2S97OSaVh2wUpPykA5iYJRiy0NOCI64vTawjQg05/3BUkCzwhLMSPyR IYvla15Pk0znvY18GxH9kM0fYOXDlGHE9r/t2Lwrt7egqz4SAQi2R2dCAwBC/pDa4W +TDTSWirlZGpn/kDQInrvuy5eI6EiwGbTeMvsss9NQxMUF3t6n+qUlzmbKCj/3194Q r+QDtfnfXwt8Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TdnCf71bpz9rxL; Mon, 19 Feb 2024 16:54:22 +0100 (CET) From: Philip Kaludercic In-Reply-To: <87bk8fq7w7.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 17 Feb 2024 10:10:16 -0800") References: <87v86qnfqn.fsf@posteo.net> <87bk8fq7w7.fsf@ericabrahamsen.net> OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Mon, 19 Feb 2024 15:54:22 +0000 Message-ID: <878r3gbgb5.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) --=-=-= Content-Type: text/plain Eric Abrahamsen writes: > Philip Kaludercic writes: > >> I use this command frequently, and am just as frequently mildly annoyed >> that attachments are always added at the bottom of the message buffer, >> instead of at point as is the case with 'mml-attach-file' (usually this >> is mild enough that I'd immediately forget about it). This patch allows >> disabling the behaviour: > > This looks fine to me, thank you. Would you add a :version to the > defcustom, and also a mention (with index entry) in the Gnus manual, > "Interaction with other modes -> Dired"? > > I guess 'mail is a fine group for the defcustom, kind of hard to say. How does this look like: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Allow-attaching-files-at-point-using-gnus-dired-atta.patch >From a61cf2688bc952864a5c394a4f06b64c48a906e2 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Thu, 15 Feb 2024 12:10:12 +0100 Subject: [PATCH] Allow attaching files at point using 'gnus-dired-attach' * lisp/gnus/gnus-dired.el (gnus-dired-attach-at-end): Add option. (gnus-dired-attach): Respect it. * doc/misc/gnus.texi (Other modes): Document it. (Bug#69141) --- doc/misc/gnus.texi | 5 ++++- lisp/gnus/gnus-dired.el | 9 ++++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/doc/misc/gnus.texi b/doc/misc/gnus.texi index 2f8f97e5845..98196310b5c 100644 --- a/doc/misc/gnus.texi +++ b/doc/misc/gnus.texi @@ -26695,9 +26695,12 @@ Other modes @table @kbd @item C-c C-m C-a @findex gnus-dired-attach +@vindex gnus-dired-attach-at-end @cindex attachments, selection via dired Send dired's marked files as an attachment (@code{gnus-dired-attach}). -You will be prompted for a message buffer. +You will be prompted for a message buffer. By default it will attach +files to the end of the message buffer, but you can modify that +behaviour by customising @code{gnus-dired-attach-at-end}. @item C-c C-m C-l @findex gnus-dired-find-file-mailcap diff --git a/lisp/gnus/gnus-dired.el b/lisp/gnus/gnus-dired.el index 48c1aef968b..f33c5f7f2e5 100644 --- a/lisp/gnus/gnus-dired.el +++ b/lisp/gnus/gnus-dired.el @@ -111,6 +111,12 @@ gnus-dired-mail-buffers (autoload 'gnus-completing-read "gnus-util") +(defcustom gnus-dired-attach-at-end t + "Non-nil means that files should be attached at the end of a buffer." + :group 'mail ;; dired? + :version "30.1" + :type 'boolean) + ;; Method to attach files to a mail composition. (defun gnus-dired-attach (files-to-attach) "Attach dired's marked files to a gnus message composition. @@ -161,7 +167,8 @@ gnus-dired-attach ;; set buffer to destination buffer, and attach files (set-buffer destination) - (goto-char (point-max)) ;attach at end of buffer + (when gnus-dired-attach-at-end + (goto-char (point-max))) ;attach at end of buffer (while files-to-attach (mml-attach-file (car files-to-attach) (or (mm-default-file-type (car files-to-attach)) -- 2.43.0 --=-=-=-- From unknown Sun Jun 22 00:52:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69141: [PATCH] Allow attaching files at point using 'gnus-dired-attach' Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Feb 2024 16:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: 69141@debbugs.gnu.org Received: via spool by 69141-submit@debbugs.gnu.org id=B69141.17083597159584 (code B ref 69141); Mon, 19 Feb 2024 16:22:02 +0000 Received: (at 69141) by debbugs.gnu.org; 19 Feb 2024 16:21:55 +0000 Received: from localhost ([127.0.0.1]:43282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc6Ow-0002UV-V6 for submit@debbugs.gnu.org; Mon, 19 Feb 2024 11:21:55 -0500 Received: from mail.ericabrahamsen.net ([52.70.2.18]:42332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc6Ot-0002UE-Hl for 69141@debbugs.gnu.org; Mon, 19 Feb 2024 11:21:53 -0500 Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 97082FA02C; Mon, 19 Feb 2024 16:21:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1708359683; bh=piWRe7uXfaYz87lNY2tc1sLw5CIa7qAnOqMrtoYrNKo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=l7Y7VRrYnqxO9BMbaYY4sJQhml+EnZCc0t/spq3rmJNCp/lyagbNXmiEdvpraa+4D ZPmZA5Pk8uEAN3zXuUWIeQOLmu78ah0kFsspzFl19xszTWfO0v2/6kO8dE9ZjcGkbd lSuPk/IdFn0u4FQAegiht9z/94qY20s7z+PBkYeM= From: Eric Abrahamsen In-Reply-To: <878r3gbgb5.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 19 Feb 2024 15:54:22 +0000") References: <87v86qnfqn.fsf@posteo.net> <87bk8fq7w7.fsf@ericabrahamsen.net> <878r3gbgb5.fsf@posteo.net> Date: Mon, 19 Feb 2024 08:21:21 -0800 Message-ID: <87edd8mnlq.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) On 02/19/24 15:54 PM, Philip Kaludercic wrote: > Eric Abrahamsen writes: > >> Philip Kaludercic writes: >> >>> I use this command frequently, and am just as frequently mildly annoyed >>> that attachments are always added at the bottom of the message buffer, >>> instead of at point as is the case with 'mml-attach-file' (usually this >>> is mild enough that I'd immediately forget about it). This patch allows >>> disabling the behaviour: >> >> This looks fine to me, thank you. Would you add a :version to the >> defcustom, and also a mention (with index entry) in the Gnus manual, >> "Interaction with other modes -> Dired"? >> >> I guess 'mail is a fine group for the defcustom, kind of hard to say. > > How does this look like: Looks good! Thanks. From unknown Sun Jun 22 00:52:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69141: [PATCH] Allow attaching files at point using 'gnus-dired-attach' Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Feb 2024 16:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: eric@ericabrahamsen.net, 69141@debbugs.gnu.org Received: via spool by 69141-submit@debbugs.gnu.org id=B69141.170836160913271 (code B ref 69141); Mon, 19 Feb 2024 16:54:02 +0000 Received: (at 69141) by debbugs.gnu.org; 19 Feb 2024 16:53:29 +0000 Received: from localhost ([127.0.0.1]:43314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc6tU-0003Rx-LX for submit@debbugs.gnu.org; Mon, 19 Feb 2024 11:53:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc6tS-0003Rg-MK for 69141@debbugs.gnu.org; Mon, 19 Feb 2024 11:53:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rc6t1-0005rA-U4; Mon, 19 Feb 2024 11:52:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Oa3tFA26ZJW43gQ8eOLKQy0Eb6fEAPFyDXI6iM+qZdI=; b=iwetCu2gTr2s L+p/Ha4G0L3trsW3aktIL72Q6oRcSbc+b3XyBPKzfnWEiIvZix05/O1IQ4Uu7s+4KJFip74XFThWo lbQqANcPSmGSxRqdidQiKjG78xIKqf6xmAIaMlZi7/78ATZgekzQe7zyrFaI71TbXKlhCwcpUHnKh UZPbVOS7sn01NqDPB0LY9yMdvRt5xQofd32Y8NZ+RsdUu7lq9LPD4/C6meU/XaFCAUNxJCqmOFr8n iKyiB2JHAlvJleRxkwCZoZ573xx7prL0Ymo9dFbAstVA01i3kt5fZ0DZNeT7Q41vQJUdXrXKBv3K7 YNvOZrvIsDZBHRDF76U0+w==; Date: Mon, 19 Feb 2024 18:52:58 +0200 Message-Id: <86frxopf9x.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <878r3gbgb5.fsf@posteo.net> (message from Philip Kaludercic on Mon, 19 Feb 2024 15:54:22 +0000) References: <87v86qnfqn.fsf@posteo.net> <87bk8fq7w7.fsf@ericabrahamsen.net> <878r3gbgb5.fsf@posteo.net> X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) > Cc: 69141@debbugs.gnu.org > From: Philip Kaludercic > Date: Mon, 19 Feb 2024 15:54:22 +0000 > > Eric Abrahamsen writes: > > > Philip Kaludercic writes: > > > >> I use this command frequently, and am just as frequently mildly annoyed > >> that attachments are always added at the bottom of the message buffer, > >> instead of at point as is the case with 'mml-attach-file' (usually this > >> is mild enough that I'd immediately forget about it). This patch allows > >> disabling the behaviour: > > > > This looks fine to me, thank you. Would you add a :version to the > > defcustom, and also a mention (with index entry) in the Gnus manual, > > "Interaction with other modes -> Dired"? > > > > I guess 'mail is a fine group for the defcustom, kind of hard to say. > > How does this look like: Just as comment from the sidelines, by someone who doesn't use Gnus: isn't this quite a bit of ado about very little? AFAIK and IME, the way attachments are shown on the receiving end is completely up to MUA on that end; having them embedded inside the body of the email message doesn't necessarily mean it will be shown as part of the message. In fact, there are widely used MUAs out there which will always show attachments on a specially-assigned spot of the MUA display. So the usability of this option seems to have a known effect on a couple of Emacs based MUAs, and otherwise all bets are off. Right? From unknown Sun Jun 22 00:52:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69141: [PATCH] Allow attaching files at point using 'gnus-dired-attach' Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Feb 2024 19:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic , Eric Abrahamsen Cc: 69141@debbugs.gnu.org Received: via spool by 69141-submit@debbugs.gnu.org id=B69141.170836930126851 (code B ref 69141); Mon, 19 Feb 2024 19:02:01 +0000 Received: (at 69141) by debbugs.gnu.org; 19 Feb 2024 19:01:41 +0000 Received: from localhost ([127.0.0.1]:43411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc8tZ-0006z0-Hf for submit@debbugs.gnu.org; Mon, 19 Feb 2024 14:01:41 -0500 Received: from mail-ed1-f46.google.com ([209.85.208.46]:56403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc8tX-0006ym-1n for 69141@debbugs.gnu.org; Mon, 19 Feb 2024 14:01:40 -0500 Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-55a179f5fa1so6338717a12.0 for <69141@debbugs.gnu.org>; Mon, 19 Feb 2024 11:01:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708369212; x=1708974012; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=XIdwA+UnVvDI0c4L/3OzMHdk7TeJVcZaEWvjGtFzYkc=; b=M/P2c0eLAVNteB2uLTBlpFh4Y905n3S32bcPG+qj8dzIGvOw5oHypeWQ2ixu1UuNyw iDhbmU+jfXiW4KlJHss7S6pealKfunB8MU7Qlv7+H/HAvpBDxi2831aE9vE1jcRxqwU/ peRs8zJUf6J5EIVmGkK86R/Jz+sWUxdRH5eo3N6hz10ouguv3pZ16x3KT0IDMAXGfrM5 MQiY7dhDj4337extyJAbvhjCPNpkdGXmdcrAkQ2S2tacAoJASKhMJMJxrbtjWd+40m2P nzLj9UlZ4HVXYQ3iTHmnBitmDmVDGGVksj6GvE1UgaAoIjTHzHdQc+S54l8MYaxANtv6 y7oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708369212; x=1708974012; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XIdwA+UnVvDI0c4L/3OzMHdk7TeJVcZaEWvjGtFzYkc=; b=xJcEQyNw+TsTX25WfaN0xwD6PJzB6Y/kxVjmElhHNHmeDjKqOxNeppGlGI5D9d1Rl/ JJeLWPBOCzAuQ8/2keFev1bC3EOTf5s+uIj+dkBPFMZGKuvLTgRWzfWZ1DWAwdw1uGqQ vVRbV9RY9cdQAMKNs2X1P8LPlvy1F4MYocBQG9HmsE199xF1D7Cfx6vMRi4ORoZNRx2g xhpD6d9EefeNNloK+QkGuvtgUpijI8b/F2dOD7jDsd4jqts9r37j+1Pk4pxMkCevO+WE MOZC86fvDUmtlJfMSiZSIrt4wYX4dw7j2vFJqt7H4/aZBKI921vKFsXpaUed1IfmqywW EhEA== X-Gm-Message-State: AOJu0YxZEzaMIy9I/9GxMlb6HMUAmW2uYg4EtqiVZgc/dVegx/Va/EVv 1Df96/8U2+Uo6+w3wmkKkt0udIaVPGkYQM01gU2loiba1HYOfw+P78lQfNEyoV+xBJzQNsWP7hs es/PcJblcvpagOR7wL7Rc86p6AJw= X-Google-Smtp-Source: AGHT+IHKAMivNC1zwUpzmZvjzfff2e38Ep93CiGlJCzxxBQDKlBYcU+QCCL0nrk9m5q2H5kRcK/WsOSNOQJVhRvOSb8= X-Received: by 2002:a05:6402:31e1:b0:564:bcb1:45f6 with SMTP id dy1-20020a05640231e100b00564bcb145f6mr36116edb.15.1708369211863; Mon, 19 Feb 2024 11:00:11 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 19 Feb 2024 14:00:11 -0500 From: Stefan Kangas In-Reply-To: <878r3gbgb5.fsf@posteo.net> References: <87v86qnfqn.fsf@posteo.net> <87bk8fq7w7.fsf@ericabrahamsen.net> <878r3gbgb5.fsf@posteo.net> MIME-Version: 1.0 Date: Mon, 19 Feb 2024 14:00:11 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Philip Kaludercic writes: > How does this look like: Thanks for fixing this longstanding issue with `gnus-dired-attach'. From unknown Sun Jun 22 00:52:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69141: [PATCH] Allow attaching files at point using 'gnus-dired-attach' Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Feb 2024 19:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: Eric Abrahamsen , 69141@debbugs.gnu.org Received: via spool by 69141-submit@debbugs.gnu.org id=B69141.170836938126973 (code B ref 69141); Mon, 19 Feb 2024 19:03:02 +0000 Received: (at 69141) by debbugs.gnu.org; 19 Feb 2024 19:03:01 +0000 Received: from localhost ([127.0.0.1]:43415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc8uq-00070z-VF for submit@debbugs.gnu.org; Mon, 19 Feb 2024 14:03:01 -0500 Received: from mout02.posteo.de ([185.67.36.66]:50597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc8uo-00070l-Bf for 69141@debbugs.gnu.org; Mon, 19 Feb 2024 14:02:59 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 9F564240103 for <69141@debbugs.gnu.org>; Mon, 19 Feb 2024 20:02:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1708369350; bh=H2gbm25zbnE9J8P33Iziq7kXinGFQI0qV7Bedoxl3UU=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=OFJ/EcXIWZbygW6LPHTg+mED5qh4WeCd+KhD9j7E1eWqEpkWyLs7O2EdZiOA+eqM0 mwVt3vCH3GeYzRXvOZJLuHY2Jo+QUybWRu1+DvHYfkun/S6VW1xfg4QbkIcql4Mk1Y m8RoDMe9wF5YkZUWFGqg1Fs8DoVP8hIY9BfSZYAyIugG1iTtEvwI4SMN0E2eaObWqh 0hs5vHYjTujx7T7ShZafIOuE++vfJrd2nYlN3yaAtXX4pJOL8Wx7VytxyKBlNCzrki OIco/+T9u3Q2lSlGev6CuhQNPgM2CKzvIKlpbBQ7lSF0jnJRocgw0SgU29y/GitUfl Ie0zdXOjzie9g== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TdsNj73P3z9rxF; Mon, 19 Feb 2024 20:02:29 +0100 (CET) From: Philip Kaludercic In-Reply-To: (Stefan Kangas's message of "Mon, 19 Feb 2024 14:00:11 -0500") References: <87v86qnfqn.fsf@posteo.net> <87bk8fq7w7.fsf@ericabrahamsen.net> <878r3gbgb5.fsf@posteo.net> OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Mon, 19 Feb 2024 19:02:29 +0000 Message-ID: <87cyss9t16.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) Stefan Kangas writes: > Philip Kaludercic writes: > >> How does this look like: > > Thanks for fixing this longstanding issue with `gnus-dired-attach'. I am glad to know that I wasn't the only one annoyed by this minor and extremely easy-to-fix issue ^^ Do you think it would be OK to modify the default behaviour? If so, I guess we should mention it in NEWS and point out how to restore the old behaviour, for anyone would really needs it. From unknown Sun Jun 22 00:52:30 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Philip Kaludercic Subject: bug#69141: closed (Re: bug#69141: [PATCH] Allow attaching files at point using 'gnus-dired-attach') Message-ID: References: <878r3g9t0o.fsf@posteo.net> <87v86qnfqn.fsf@posteo.net> X-Gnu-PR-Message: they-closed 69141 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 69141@debbugs.gnu.org Date: Mon, 19 Feb 2024 19:04:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1708369442-27083-1" This is a multi-part message in MIME format... ------------=_1708369442-27083-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #69141: [PATCH] Allow attaching files at point using 'gnus-dired-attach' which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 69141@debbugs.gnu.org. --=20 69141: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D69141 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1708369442-27083-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 69141-done) by debbugs.gnu.org; 19 Feb 2024 19:03:21 +0000 Received: from localhost ([127.0.0.1]:43419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc8vA-00071t-Ba for submit@debbugs.gnu.org; Mon, 19 Feb 2024 14:03:20 -0500 Received: from mout02.posteo.de ([185.67.36.66]:55265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc8v4-00071c-UQ for 69141-done@debbugs.gnu.org; Mon, 19 Feb 2024 14:03:18 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 12D17240104 for <69141-done@debbugs.gnu.org>; Mon, 19 Feb 2024 20:02:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1708369368; bh=GcvyXDzzGyBMadjFv9OHbFGQtQ0IAEchUpJWfWiWNFA=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=pQ+O4KSd5E+5EiVOLwMkpx8nEJj2D6fYCjlK3/cDqUJ0cjp6b8dvJBIcAUYVuW3cL z3C2bmh6wMSVw6hg7co+2sVmnHYALDKWWwLdVu2FB1Cbu25e1C7cZZJPB+UHKqXEjy VK7FpUIvNKNi+5nUQBwpCQekDhzH9P9rzO3tUM5dghI/Okw7oTNLkH7sbIjQAytcD3 ygLJfZqMY2nfpKihCQ0aXhP7gXstocwv4JIKYdNjT13r+4x9rWtgji6mELneEoONZJ sMG4fLG1i/uV5foIJ6LGIu4O06D/os2cSkAB31648u8lQWI0JmbndFaB94kl3l1QR1 7SJtlFjIJKdOg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TdsP34yjSz6ty0; Mon, 19 Feb 2024 20:02:47 +0100 (CET) From: Philip Kaludercic To: Eric Abrahamsen Subject: Re: bug#69141: [PATCH] Allow attaching files at point using 'gnus-dired-attach' In-Reply-To: <87edd8mnlq.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Mon, 19 Feb 2024 08:21:21 -0800") References: <87v86qnfqn.fsf@posteo.net> <87bk8fq7w7.fsf@ericabrahamsen.net> <878r3gbgb5.fsf@posteo.net> <87edd8mnlq.fsf@ericabrahamsen.net> OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Mon, 19 Feb 2024 19:02:47 +0000 Message-ID: <878r3g9t0o.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 69141-done Cc: 69141-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) Eric Abrahamsen writes: > On 02/19/24 15:54 PM, Philip Kaludercic wrote: >> Eric Abrahamsen writes: >> >>> Philip Kaludercic writes: >>> >>>> I use this command frequently, and am just as frequently mildly annoyed >>>> that attachments are always added at the bottom of the message buffer, >>>> instead of at point as is the case with 'mml-attach-file' (usually this >>>> is mild enough that I'd immediately forget about it). This patch allows >>>> disabling the behaviour: >>> >>> This looks fine to me, thank you. Would you add a :version to the >>> defcustom, and also a mention (with index entry) in the Gnus manual, >>> "Interaction with other modes -> Dired"? >>> >>> I guess 'mail is a fine group for the defcustom, kind of hard to say. >> >> How does this look like: > > Looks good! Thanks. Pushed, thank you for your comments. ------------=_1708369442-27083-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 15 Feb 2024 11:58:13 +0000 Received: from localhost ([127.0.0.1]:54235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raaNY-0006Ug-QK for submit@debbugs.gnu.org; Thu, 15 Feb 2024 06:58:13 -0500 Received: from lists.gnu.org ([209.51.188.17]:42358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raaNS-0006TL-TF for submit@debbugs.gnu.org; Thu, 15 Feb 2024 06:58:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raZfC-0006cp-KH for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 06:12:22 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1raZfA-00065L-Vs for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 06:12:22 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 05E86240101 for ; Thu, 15 Feb 2024 12:12:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707995538; bh=84iJZu0RPYjfe1igP10iKPlyuR8ufREqtGjRVKfjNIY=; h=From:To:Subject:OpenPGP:Date:Message-ID:MIME-Version:Content-Type: From; b=SRF3yO8OmkYF7EfM+iFC4aiw5Klxgni56hQvgALb9Bzp0jYNSeC/8pEHUP0mfpJKe 7ap7/R1uYl9MJannyaRt0GZXsNbOThzf21FlA2ylLcDHs2knf9T5pD9EmuhAlELRYP HSWv3H1GyuBk4Zuy9p9+3Ceio4wPawhd9KBBlrZh7s+8KWXFYMrYsliE80SVGvODm6 jC/RbihZJmIM4GOHQQZQfHANvyxRjQClE6zOQZ9UhNzjtjMWTJfiMGCZkbK95+TJ2a EBPiee4qUoZZ3cFBqGT30dyIoB8wxxA6v31IaT6vEQJIeiHUK3hdYGA3ccsed86geX 9z/EzhoApDzmg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TbC813jlkz6ty8 for ; Thu, 15 Feb 2024 12:12:17 +0100 (CET) From: Philip Kaludercic To: bug-gnu-emacs@gnu.org Subject: [PATCH] Allow attaching files at point using 'gnus-dired-attach' OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Thu, 15 Feb 2024 11:12:16 +0000 Message-ID: <87v86qnfqn.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.5 (----) --=-=-= Content-Type: text/plain I use this command frequently, and am just as frequently mildly annoyed that attachments are always added at the bottom of the message buffer, instead of at point as is the case with 'mml-attach-file' (usually this is mild enough that I'd immediately forget about it). This patch allows disabling the behaviour: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Allow-attaching-files-at-point-using-'gnus-dired-a.patch Content-Description: [PATCH] Allow attaching files at point using 'gnus-dired-attach' >From 9a5e9c51e74a278580eb670769b6093388a6109a Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Thu, 15 Feb 2024 12:10:12 +0100 Subject: [PATCH] Allow attaching files at point using 'gnus-dired-attach' * lisp/gnus/gnus-dired.el (gnus-dired-attach-at-end): Add option. (gnus-dired-attach): Respect it. --- lisp/gnus/gnus-dired.el | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lisp/gnus/gnus-dired.el b/lisp/gnus/gnus-dired.el index 48c1aef968b..740caab349d 100644 --- a/lisp/gnus/gnus-dired.el +++ b/lisp/gnus/gnus-dired.el @@ -111,6 +111,11 @@ gnus-dired-mail-buffers (autoload 'gnus-completing-read "gnus-util") +(defcustom gnus-dired-attach-at-end t + "Non-nil means that files should be attached at the end of a buffer." + :group 'mail ;; dired? + :type 'boolean) + ;; Method to attach files to a mail composition. (defun gnus-dired-attach (files-to-attach) "Attach dired's marked files to a gnus message composition. @@ -161,7 +166,8 @@ gnus-dired-attach ;; set buffer to destination buffer, and attach files (set-buffer destination) - (goto-char (point-max)) ;attach at end of buffer + (when gnus-dired-attach-at-end + (goto-char (point-max))) ;attach at end of buffer (while files-to-attach (mml-attach-file (car files-to-attach) (or (mm-default-file-type (car files-to-attach)) -- 2.43.0 --=-=-=-- ------------=_1708369442-27083-1-- From unknown Sun Jun 22 00:52:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69141: [PATCH] Allow attaching files at point using 'gnus-dired-attach' Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Feb 2024 20:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Philip Kaludercic Cc: Eric Abrahamsen , 69141@debbugs.gnu.org Received: via spool by 69141-submit@debbugs.gnu.org id=B69141.17083749173884 (code B ref 69141); Mon, 19 Feb 2024 20:36:02 +0000 Received: (at 69141) by debbugs.gnu.org; 19 Feb 2024 20:35:17 +0000 Received: from localhost ([127.0.0.1]:43527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcAM8-00010Z-IA for submit@debbugs.gnu.org; Mon, 19 Feb 2024 15:35:16 -0500 Received: from mail-ed1-f46.google.com ([209.85.208.46]:60854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcAM5-00010G-Bp for 69141@debbugs.gnu.org; Mon, 19 Feb 2024 15:35:15 -0500 Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5645960cd56so2263756a12.1 for <69141@debbugs.gnu.org>; Mon, 19 Feb 2024 12:34:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708374826; x=1708979626; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=aL/fIUCR/pCZheDMx/K/gUnUCdHcOK2wxTOvB0/T804=; b=V1q36PU7kkm2tDl5Vu9GAPDtiA6nmLEhFmDB39p7512vpznFW6Y82iQAaaduxgEo8b F9cgnq6QH0IsnJLs4s9nRcVo3AEbT14A1NaRNtejVumAg/CP0krfDMd7q/Ii/zvFjHtd lSe0bSBibnsF0OCDJETNnhCEFi+1L1fRqO49ORS1RrPGYRFLSt44C/sSJ3oi3LiPnsNL Gg/Z8HN9ED7lebXmdDbTrNePIWMuXh8quQDLWb0TuoXTAFA1A05xAE7eNwFytonVd3TA FvUbQThRgC5dxxKtkntBh6pQMzP78zMha5P7cHlEUkp3cKEeMT0BDPXsgDYE7wVtYDMD ikkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708374826; x=1708979626; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aL/fIUCR/pCZheDMx/K/gUnUCdHcOK2wxTOvB0/T804=; b=m+DDEqHZhbH/NF1wQ06jnRxqjVgS005FHvzgto7i1xO5POi62NFf4DxyjOxfUDQJ4U Ejyr0pHheOdhN/jAdHyBlq7OhBXG1y/r+5qg0LVzRsuiCPdA2W40sZ33xyJSYJvZy8se Cz9VnrS47gUKp+6iORJTZN/gf/lrW9suxV2bpTbydOeEoAbqEhewzo2y4NvwPXoNRKp7 SWb79uT3kYUjnCIdOYqAsVGIbdLBLCvw66WQ9fsOxiF/gDDXBT6kiMNknZe+MG57s6Na +NADln+YOv94DKx6ZlgjQc2K3gqx2MhWexjH5kltEcUcO7foGVHKSn+69oV0yEF0KXzN xHJQ== X-Forwarded-Encrypted: i=1; AJvYcCVG1EhTaALbKDlNCD5tr8XhFB4yWrSYnkMcEYfNawJgwA22sb2z31Le44W/VmQtvFf+9wPKXpYSi6qgNkxj2uHUb+Ifwgk= X-Gm-Message-State: AOJu0YwcIapkHdeVmQiNTakeSmfgIWQUvj0GSk2glybCz/22HWluTGGX G8j33andpuCxhDHTWYFjGkwLQmwvn9TpwE9WCf9867JDYnKkb33T4h4lIOxw0jfFYFAKFfe3MNW ULdyL5CV/uJD92Ym87tDXvyBRv/Y= X-Google-Smtp-Source: AGHT+IFklLKLgFVn+HMotbk30SClvp7ZURxOTWOjDJWljPC1Ut7uJhXyufotO7JEIde86SPrG2qGpcNKZXYhKZclpk0= X-Received: by 2002:aa7:d9c8:0:b0:564:9e80:8356 with SMTP id v8-20020aa7d9c8000000b005649e808356mr1558717eds.20.1708374825726; Mon, 19 Feb 2024 12:33:45 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 19 Feb 2024 15:33:45 -0500 From: Stefan Kangas In-Reply-To: <87cyss9t16.fsf@posteo.net> References: <87v86qnfqn.fsf@posteo.net> <87bk8fq7w7.fsf@ericabrahamsen.net> <878r3gbgb5.fsf@posteo.net> <87cyss9t16.fsf@posteo.net> MIME-Version: 1.0 Date: Mon, 19 Feb 2024 15:33:45 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) Philip Kaludercic writes: > Do you think it would be OK to modify the default behaviour? If so, I > guess we should mention it in NEWS and point out how to restore the old > behaviour, for anyone would really needs it. I'm not sure it's worth changing it, because other attach commands in message-mode adds attachments in place, which kind of makes sense if you are dealing with in-line images. So I can realistically see users wanting either behaviour, and providing an option does that. WDYT? From unknown Sun Jun 22 00:52:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69141: [PATCH] Allow attaching files at point using 'gnus-dired-attach' Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Feb 2024 02:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: Eric Abrahamsen , Philip Kaludercic , 69141@debbugs.gnu.org Received: via spool by 69141-submit@debbugs.gnu.org id=B69141.170839587519187 (code B ref 69141); Tue, 20 Feb 2024 02:25:01 +0000 Received: (at 69141) by debbugs.gnu.org; 20 Feb 2024 02:24:35 +0000 Received: from localhost ([127.0.0.1]:43944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcFoA-0004zO-O7 for submit@debbugs.gnu.org; Mon, 19 Feb 2024 21:24:35 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:45153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcFo5-0004z5-Af for 69141@debbugs.gnu.org; Mon, 19 Feb 2024 21:24:33 -0500 Received: by mail-pj1-f65.google.com with SMTP id 98e67ed59e1d1-2998950e951so926207a91.2 for <69141@debbugs.gnu.org>; Mon, 19 Feb 2024 18:24:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708395782; x=1709000582; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gUOslWMvtV2bgZET1U+RxdWZoNi8kwCzBdlqvZ97y3k=; b=njMpzRNe1I/kIB1GRwIbx7WjA3eSQYiBYrfeQ1ZASp2YGtAYwemgAjL2CrzBW0CfOH gZUAXPr9yzQ807RxysdX82LqgF7m1HwyHML5CTKZjWw93kimPEn7+Eoe4A7WPmNluj2w cFGIbbYvYL9wHX97doabBAbgbeHsWk9Nd46hiWx3a9CHbHubPjSUniiU1qF27PEDsa5g P/Kd0OeX2aoIdcCqwUyMaGPbES2q0EewDvem+wmPkmVnLWkv8NTAdqU4KOvOJs5sME13 9+s+g5F+RJd8u7gLd2L0H/5WK4n2IKsk8A/Z/0/VyKQxZlQBUINOkI1hYpYlLHFxvpU6 ywoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708395782; x=1709000582; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=gUOslWMvtV2bgZET1U+RxdWZoNi8kwCzBdlqvZ97y3k=; b=ZEy1+0uD+eUxtKPSFysDT7ROoxebWItwFWO35XDApnZ3Jryit/nVMtybJJk902wswt e7qehK4ZwYmhbpVjcAUhoKsLq2+Nx/XwLdAXiQMwPjdLTcdJcB/9iz//OcCnYO37sSZD 1VTLv584B6uT5VjSvv8G7htYDp8FmbwcIlUqVZ35MgYQPjCYMmRMCqmVNuEcrL7aLRxY sIifWPFyj0yhWJ6wYqUM80wAUAjWGTwbXveJ0AaAYK/mzNUMdWGs2blpqbx8qEi3RpBr hfENAYAa5L+SEIPA147nI5vYXtRT3wjZ5tJkFk5/2GFfh9jcbANDLDY4SFHES/RuAaJq 2QCQ== X-Forwarded-Encrypted: i=1; AJvYcCXVqtX5i2AQ3/pdjGh3HhQaWfQ2eI1OwB5FfsUQN+DWVer0UXlVdnE35ImeJLYIwpidhV7LcNf87D49Xf0OCWHDzeggp5k= X-Gm-Message-State: AOJu0Yz1TBDMmtdF4FKhO65gqWsLuzxnheuEgJXL35/Y7ZKbSU/EQVxs TKFmvoaB0mhNFAQLpQdZ0RMHfC4d0Sd7HsQOxycaCJfHryO8mkVJ X-Google-Smtp-Source: AGHT+IG9EM8ps5W8uAqK5U1+t3y+KZ5/ysTLWRGpvigF2YBNcRVaXbsSnFB280k3d3cObs8T4pO/NQ== X-Received: by 2002:a17:90b:1902:b0:299:5579:33fd with SMTP id mp2-20020a17090b190200b00299557933fdmr5014685pjb.8.1708395780874; Mon, 19 Feb 2024 18:23:00 -0800 (PST) Received: from localhost ([115.240.90.130]) by smtp.gmail.com with ESMTPSA id c24-20020a17090ad91800b0029948cb4367sm5984645pjv.23.2024.02.19.18.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Feb 2024 18:23:00 -0800 (PST) From: Visuwesh In-Reply-To: (Stefan Kangas's message of "Mon, 19 Feb 2024 15:33:45 -0500") References: <87v86qnfqn.fsf@posteo.net> <87bk8fq7w7.fsf@ericabrahamsen.net> <878r3gbgb5.fsf@posteo.net> <87cyss9t16.fsf@posteo.net> Date: Tue, 20 Feb 2024 07:52:50 +0530 Message-ID: <87wmqzswlh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) [=E0=AE=A4=E0=AE=BF=E0=AE=99=E0=AF=8D=E0=AE=95=E0=AE=B3=E0=AF=8D =E0=AE=AA= =E0=AE=BF=E0=AE=AA=E0=AF=8D=E0=AE=B0=E0=AE=B5=E0=AE=B0=E0=AE=BF 19, 2024] S= tefan Kangas wrote: > Philip Kaludercic writes: > >> Do you think it would be OK to modify the default behaviour? If so, I >> guess we should mention it in NEWS and point out how to restore the old >> behaviour, for anyone would really needs it. > > I'm not sure it's worth changing it, because other attach commands in > message-mode adds attachments in place, which kind of makes sense if you > are dealing with in-line images. So I can realistically see users > wanting either behaviour, and providing an option does that. > > WDYT? Although as Eli pointed, the place where the attachment shows up is completely up to the MUA, I always found it annoying that the dired command attaches it at the end since it made it (1) hard for me to know whether I attached the file, and (2) hard to present the attachment in a relevant place to other Gnus others. So I ended up resorting to drag-n-drop from dired (now I use yank-media to attach copied files in clipboard). I wouldn't mind having this new defcustom default to nil. From unknown Sun Jun 22 00:52:30 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69141: [PATCH] Allow attaching files at point using 'gnus-dired-attach' Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Feb 2024 10:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: Eric Abrahamsen , 69141@debbugs.gnu.org Received: via spool by 69141-submit@debbugs.gnu.org id=B69141.17089425662828 (code B ref 69141); Mon, 26 Feb 2024 10:17:02 +0000 Received: (at 69141) by debbugs.gnu.org; 26 Feb 2024 10:16:06 +0000 Received: from localhost ([127.0.0.1]:51762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reY1l-0000jW-W5 for submit@debbugs.gnu.org; Mon, 26 Feb 2024 05:16:06 -0500 Received: from mout02.posteo.de ([185.67.36.66]:51025) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reY1j-0000it-6i for 69141@debbugs.gnu.org; Mon, 26 Feb 2024 05:16:04 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 3F4B1240101 for <69141@debbugs.gnu.org>; Mon, 26 Feb 2024 11:15:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1708942532; bh=neI/N8CGSE4MBBW38vY1aR0DNhxc6WG8Jp+ns6cDJW0=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=RH/UcsP5/bPAhJKlXUJtxueFffTMkZoYe4DmpW5wdBOm2R7b7l1E1C9F2KbkTzzOQ Otr80EX1MeecAYNWZWRG3iq1S7aI69Vv6vKQTZ370fe+GbGTYwKGb+emtGVqfUh6Zx sonsR75/xmp53wkYDe9Cy8wMpbVMvK4EhIBVLRtwxzDQE3ak6hKUFK35rILDCpEYbk 9uTL1MRb0G8QzA5bmmlfqsWHCWstWSoDFEL6CP3GjC0NrOukVw4lDR9RhSDhr33UU/ hu9mBPBj6F4yJ8610g+ob+c3Hdd9b8xRDBOJY2SWoFu/tZdhplF8kCHQHoRM29gN2u ykAuX/AL0AuGg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TjxMR2tvhz9rxN; Mon, 26 Feb 2024 11:15:31 +0100 (CET) From: Philip Kaludercic In-Reply-To: (Stefan Kangas's message of "Mon, 19 Feb 2024 15:33:45 -0500") References: <87v86qnfqn.fsf@posteo.net> <87bk8fq7w7.fsf@ericabrahamsen.net> <878r3gbgb5.fsf@posteo.net> <87cyss9t16.fsf@posteo.net> OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Mon, 26 Feb 2024 10:15:30 +0000 Message-ID: <875xybcz0d.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > Philip Kaludercic writes: > >> Do you think it would be OK to modify the default behaviour? If so, I >> guess we should mention it in NEWS and point out how to restore the old >> behaviour, for anyone would really needs it. > > I'm not sure it's worth changing it, because other attach commands in > message-mode adds attachments in place, which kind of makes sense if you > are dealing with in-line images. So I can realistically see users > wanting either behaviour, and providing an option does that. > > WDYT? The argument for changing it would precisely be to be more consistent with what other commands do. The argument against it, as usual, would be that it could conceivably break someones workflow. -- Philip Kaludercic on peregrine