GNU bug report logs - #69141
[PATCH] Allow attaching files at point using 'gnus-dired-attach'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69141 in the body.
You can then email your comments to 69141 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Allow attaching files at point using 'gnus-dired-attach'
Date: Thu, 15 Feb 2024 11:12:16 +0000

[Message part 1 (text/plain, inline)]

I use this command frequently, and am just as frequently mildly annoyed
that attachments are always added at the bottom of the message buffer,
instead of at point as is the case with 'mml-attach-file' (usually this
is mild enough that I'd immediately forget about it).  This patch allows
disabling the behaviour:

[0001-Allow-attaching-files-at-point-using-'gnus-dired-a.patch (text/x-patch, attachment)]

Message #8 received at 69141 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 69141 <at> debbugs.gnu.org
Subject: Re: bug#69141: [PATCH] Allow attaching files at point using
 'gnus-dired-attach'
Date: Sat, 17 Feb 2024 10:10:16 -0800

Philip Kaludercic <philipk <at> posteo.net> writes:

> I use this command frequently, and am just as frequently mildly annoyed
> that attachments are always added at the bottom of the message buffer,
> instead of at point as is the case with 'mml-attach-file' (usually this
> is mild enough that I'd immediately forget about it).  This patch allows
> disabling the behaviour:

This looks fine to me, thank you. Would you add a :version to the
defcustom, and also a mention (with index entry) in the Gnus manual,
"Interaction with other modes -> Dired"?

I guess 'mail is a fine group for the defcustom, kind of hard to say.

Message #11 received at 69141 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 69141 <at> debbugs.gnu.org
Subject: Re: bug#69141: [PATCH] Allow attaching files at point using
 'gnus-dired-attach'
Date: Mon, 19 Feb 2024 15:54:22 +0000

[Message part 1 (text/plain, inline)]

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> I use this command frequently, and am just as frequently mildly annoyed
>> that attachments are always added at the bottom of the message buffer,
>> instead of at point as is the case with 'mml-attach-file' (usually this
>> is mild enough that I'd immediately forget about it).  This patch allows
>> disabling the behaviour:
>
> This looks fine to me, thank you. Would you add a :version to the
> defcustom, and also a mention (with index entry) in the Gnus manual,
> "Interaction with other modes -> Dired"?
>
> I guess 'mail is a fine group for the defcustom, kind of hard to say.

How does this look like:

[0001-Allow-attaching-files-at-point-using-gnus-dired-atta.patch (text/x-patch, attachment)]

Message #14 received at 69141 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 69141 <at> debbugs.gnu.org
Subject: Re: bug#69141: [PATCH] Allow attaching files at point using
 'gnus-dired-attach'
Date: Mon, 19 Feb 2024 08:21:21 -0800

On 02/19/24 15:54 PM, Philip Kaludercic wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> Philip Kaludercic <philipk <at> posteo.net> writes:
>>
>>> I use this command frequently, and am just as frequently mildly annoyed
>>> that attachments are always added at the bottom of the message buffer,
>>> instead of at point as is the case with 'mml-attach-file' (usually this
>>> is mild enough that I'd immediately forget about it).  This patch allows
>>> disabling the behaviour:
>>
>> This looks fine to me, thank you. Would you add a :version to the
>> defcustom, and also a mention (with index entry) in the Gnus manual,
>> "Interaction with other modes -> Dired"?
>>
>> I guess 'mail is a fine group for the defcustom, kind of hard to say.
>
> How does this look like:

Looks good! Thanks.

Message #17 received at 69141 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: eric <at> ericabrahamsen.net, 69141 <at> debbugs.gnu.org
Subject: Re: bug#69141: [PATCH] Allow attaching files at point using
 'gnus-dired-attach'
Date: Mon, 19 Feb 2024 18:52:58 +0200

> Cc: 69141 <at> debbugs.gnu.org
> From: Philip Kaludercic <philipk <at> posteo.net>
> Date: Mon, 19 Feb 2024 15:54:22 +0000
> 
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
> 
> > Philip Kaludercic <philipk <at> posteo.net> writes:
> >
> >> I use this command frequently, and am just as frequently mildly annoyed
> >> that attachments are always added at the bottom of the message buffer,
> >> instead of at point as is the case with 'mml-attach-file' (usually this
> >> is mild enough that I'd immediately forget about it).  This patch allows
> >> disabling the behaviour:
> >
> > This looks fine to me, thank you. Would you add a :version to the
> > defcustom, and also a mention (with index entry) in the Gnus manual,
> > "Interaction with other modes -> Dired"?
> >
> > I guess 'mail is a fine group for the defcustom, kind of hard to say.
> 
> How does this look like:

Just as comment from the sidelines, by someone who doesn't use Gnus:
isn't this quite a bit of ado about very little?  AFAIK and IME, the
way attachments are shown on the receiving end is completely up to MUA
on that end; having them embedded inside the body of the email message
doesn't necessarily mean it will be shown as part of the message.  In
fact, there are widely used MUAs out there which will always show
attachments on a specially-assigned spot of the MUA display.  So the
usability of this option seems to have a known effect on a couple of
Emacs based MUAs, and otherwise all bets are off.  Right?

Message #20 received at 69141 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>,
 Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 69141 <at> debbugs.gnu.org
Subject: Re: bug#69141: [PATCH] Allow attaching files at point using
 'gnus-dired-attach'
Date: Mon, 19 Feb 2024 14:00:11 -0500

Philip Kaludercic <philipk <at> posteo.net> writes:

> How does this look like:

Thanks for fixing this longstanding issue with `gnus-dired-attach'.

Message #23 received at 69141 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>, 69141 <at> debbugs.gnu.org
Subject: Re: bug#69141: [PATCH] Allow attaching files at point using
 'gnus-dired-attach'
Date: Mon, 19 Feb 2024 19:02:29 +0000

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> How does this look like:
>
> Thanks for fixing this longstanding issue with `gnus-dired-attach'.

I am glad to know that I wasn't the only one annoyed by this minor and
extremely easy-to-fix issue ^^

Do you think it would be OK to modify the default behaviour?  If so, I
guess we should mention it in NEWS and point out how to restore the old
behaviour, for anyone would really needs it.

Message #28 received at 69141-done <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 69141-done <at> debbugs.gnu.org
Subject: Re: bug#69141: [PATCH] Allow attaching files at point using
 'gnus-dired-attach'
Date: Mon, 19 Feb 2024 19:02:47 +0000

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> On 02/19/24 15:54 PM, Philip Kaludercic wrote:
>> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>>
>>> Philip Kaludercic <philipk <at> posteo.net> writes:
>>>
>>>> I use this command frequently, and am just as frequently mildly annoyed
>>>> that attachments are always added at the bottom of the message buffer,
>>>> instead of at point as is the case with 'mml-attach-file' (usually this
>>>> is mild enough that I'd immediately forget about it).  This patch allows
>>>> disabling the behaviour:
>>>
>>> This looks fine to me, thank you. Would you add a :version to the
>>> defcustom, and also a mention (with index entry) in the Gnus manual,
>>> "Interaction with other modes -> Dired"?
>>>
>>> I guess 'mail is a fine group for the defcustom, kind of hard to say.
>>
>> How does this look like:
>
> Looks good! Thanks.

Pushed, thank you for your comments.

Message #31 received at 69141 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>, 69141 <at> debbugs.gnu.org
Subject: Re: bug#69141: [PATCH] Allow attaching files at point using
 'gnus-dired-attach'
Date: Mon, 19 Feb 2024 15:33:45 -0500

Philip Kaludercic <philipk <at> posteo.net> writes:

> Do you think it would be OK to modify the default behaviour?  If so, I
> guess we should mention it in NEWS and point out how to restore the old
> behaviour, for anyone would really needs it.

I'm not sure it's worth changing it, because other attach commands in
message-mode adds attachments in place, which kind of makes sense if you
are dealing with in-line images.  So I can realistically see users
wanting either behaviour, and providing an option does that.

WDYT?

Message #34 received at 69141 <at> debbugs.gnu.org (full text, mbox):

From: Visuwesh <visuweshm <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>,
 Philip Kaludercic <philipk <at> posteo.net>, 69141 <at> debbugs.gnu.org
Subject: Re: bug#69141: [PATCH] Allow attaching files at point using
 'gnus-dired-attach'
Date: Tue, 20 Feb 2024 07:52:50 +0530

[திங்கள் பிப்ரவரி 19, 2024] Stefan Kangas wrote:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> Do you think it would be OK to modify the default behaviour?  If so, I
>> guess we should mention it in NEWS and point out how to restore the old
>> behaviour, for anyone would really needs it.
>
> I'm not sure it's worth changing it, because other attach commands in
> message-mode adds attachments in place, which kind of makes sense if you
> are dealing with in-line images.  So I can realistically see users
> wanting either behaviour, and providing an option does that.
>
> WDYT?

Although as Eli pointed, the place where the attachment shows up is
completely up to the MUA, I always found it annoying that the dired
command attaches it at the end since it made it (1) hard for me to know
whether I attached the file, and (2) hard to present the attachment in a
relevant place to other Gnus others.  So I ended up resorting to
drag-n-drop from dired (now I use yank-media to attach copied files in
clipboard).  I wouldn't mind having this new defcustom default to nil.

Message #37 received at 69141 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eric Abrahamsen <eric <at> ericabrahamsen.net>, 69141 <at> debbugs.gnu.org
Subject: Re: bug#69141: [PATCH] Allow attaching files at point using
 'gnus-dired-attach'
Date: Mon, 26 Feb 2024 10:15:30 +0000

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Philip Kaludercic <philipk <at> posteo.net> writes:
>
>> Do you think it would be OK to modify the default behaviour?  If so, I
>> guess we should mention it in NEWS and point out how to restore the old
>> behaviour, for anyone would really needs it.
>
> I'm not sure it's worth changing it, because other attach commands in
> message-mode adds attachments in place, which kind of makes sense if you
> are dealing with in-line images.  So I can realistically see users
> wanting either behaviour, and providing an option does that.
>
> WDYT?

The argument for changing it would precisely be to be more consistent
with what other commands do.  The argument against it, as usual, would
be that it could conceivably break someones workflow.

-- 
	Philip Kaludercic on peregrine

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.