GNU bug report logs - #69096
[PATCH] Set default value for 'vc-default-patch-addressee'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69096 in the body.
You can then email your comments to 69096 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Set default value for 'vc-default-patch-addressee'
Date: Tue, 13 Feb 2024 09:54:16 +0000

[Message part 1 (text/plain, inline)]

Apparently we forgot to set this option back when it was added, but it
makes sense to have it along with 'vc-prepare-patches-separately'.

[0001-dir-locals-el--Set-'vc-default-patch-addresse.patch (text/x-patch, attachment)]

Message #8 received at 69096 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: 69096 <at> debbugs.gnu.org
Subject: Re: bug#69096: [PATCH] Set default value for
 'vc-default-patch-addressee'
Date: Fri, 03 May 2024 07:36:34 +0000

Philip Kaludercic <philipk <at> posteo.net> writes:

> Apparently we forgot to set this option back when it was added, but it
> makes sense to have it along with 'vc-prepare-patches-separately'.

ping?

Message #11 received at 69096 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>, Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 69096 <at> debbugs.gnu.org
Subject: Re: bug#69096: [PATCH] Set default value for
 'vc-default-patch-addressee'
Date: Sat, 04 May 2024 14:44:40 +0300

> From: Philip Kaludercic <philipk <at> posteo.net>
> Date: Fri, 03 May 2024 07:36:34 +0000
> 
> Philip Kaludercic <philipk <at> posteo.net> writes:
> 
> > Apparently we forgot to set this option back when it was added, but it
> > makes sense to have it along with 'vc-prepare-patches-separately'.
> 
> ping?

Dmitry?

I'm okay with this, FWIW.

Message #14 received at 69096 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>, Philip Kaludercic <philipk <at> posteo.net>
Cc: 69096 <at> debbugs.gnu.org
Subject: Re: bug#69096: [PATCH] Set default value for
 'vc-default-patch-addressee'
Date: Sat, 4 May 2024 16:34:47 +0300

Hi Eli,

On 04/05/2024 14:44, Eli Zaretskii wrote:
>> From: Philip Kaludercic<philipk <at> posteo.net>
>> Date: Fri, 03 May 2024 07:36:34 +0000
>>
>> Philip Kaludercic<philipk <at> posteo.net>  writes:
>>
>>> Apparently we forgot to set this option back when it was added, but it
>>> makes sense to have it along with 'vc-prepare-patches-separately'.
>> ping?
> Dmitry?
> 
> I'm okay with this, FWIW.

I didn't think this was my area, but the change also LGTM.

Message #17 received at 69096 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 69096 <at> debbugs.gnu.org
Subject: Re: bug#69096: [PATCH] Set default value for
 'vc-default-patch-addressee'
Date: Sat, 04 May 2024 14:15:39 +0000

Dmitry Gutov <dmitry <at> gutov.dev> writes:

> Hi Eli,
>
> On 04/05/2024 14:44, Eli Zaretskii wrote:
>>> From: Philip Kaludercic<philipk <at> posteo.net>
>>> Date: Fri, 03 May 2024 07:36:34 +0000
>>>
>>> Philip Kaludercic<philipk <at> posteo.net>  writes:
>>>
>>>> Apparently we forgot to set this option back when it was added, but it
>>>> makes sense to have it along with 'vc-prepare-patches-separately'.
>>> ping?
>> Dmitry?
>> I'm okay with this, FWIW.
>
> I didn't think this was my area, but the change also LGTM.

Yes, I worked on vc-prepare-patch and related functionality for the most
part, hence the suggestion.

-- 
	Philip Kaludercic on peregrine

Message #20 received at 69096 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>, Eli Zaretskii <eliz <at> gnu.org>, 
 Philip Kaludercic <philipk <at> posteo.net>
Cc: 69096 <at> debbugs.gnu.org
Subject: Re: bug#69096: [PATCH] Set default value for
 'vc-default-patch-addressee'
Date: Mon, 20 May 2024 00:48:52 +0200

Dmitry Gutov <dmitry <at> gutov.dev> writes:

> Hi Eli,
>
> On 04/05/2024 14:44, Eli Zaretskii wrote:
>>> From: Philip Kaludercic<philipk <at> posteo.net>
>>> Date: Fri, 03 May 2024 07:36:34 +0000
>>>
>>> Philip Kaludercic<philipk <at> posteo.net>  writes:
>>>
>>>> Apparently we forgot to set this option back when it was added, but it
>>>> makes sense to have it along with 'vc-prepare-patches-separately'.
>>> ping?
>> Dmitry?
>>
>> I'm okay with this, FWIW.
>
> I didn't think this was my area, but the change also LGTM.

Philip, did you push this already?

If no, please go ahead, if yes, don't forget to close the bug.  ;-)

Message #25 received at 69096-done <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, Eli Zaretskii <eliz <at> gnu.org>,
 69096-done <at> debbugs.gnu.org
Subject: Re: bug#69096: [PATCH] Set default value for
 'vc-default-patch-addressee'
Date: Mon, 20 May 2024 06:35:32 +0000

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Dmitry Gutov <dmitry <at> gutov.dev> writes:
>
>> Hi Eli,
>>
>> On 04/05/2024 14:44, Eli Zaretskii wrote:
>>>> From: Philip Kaludercic<philipk <at> posteo.net>
>>>> Date: Fri, 03 May 2024 07:36:34 +0000
>>>>
>>>> Philip Kaludercic<philipk <at> posteo.net>  writes:
>>>>
>>>>> Apparently we forgot to set this option back when it was added, but it
>>>>> makes sense to have it along with 'vc-prepare-patches-separately'.
>>>> ping?
>>> Dmitry?
>>>
>>> I'm okay with this, FWIW.
>>
>> I didn't think this was my area, but the change also LGTM.
>
> Philip, did you push this already?

No I haven't yet, but I will right after this message.

> If no, please go ahead, if yes, don't forget to close the bug.  ;-)

Thanks, I was just wanting for another ACK.

-- 
	Philip Kaludercic on peregrine

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.