From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 13 02:45:20 2024 Received: (at submit) by debbugs.gnu.org; 13 Feb 2024 07:45:20 +0000 Received: from localhost ([127.0.0.1]:41009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZnTk-0005az-28 for submit@debbugs.gnu.org; Tue, 13 Feb 2024 02:45:20 -0500 Received: from lists.gnu.org ([209.51.188.17]:56798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZnTh-0005ap-Aq for submit@debbugs.gnu.org; Tue, 13 Feb 2024 02:45:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZnTN-0007tq-WF for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 02:44:58 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZnTI-00046R-Hm for bug-gnu-emacs@gnu.org; Tue, 13 Feb 2024 02:44:57 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id C5142E0007 for ; Tue, 13 Feb 2024 07:44:48 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: window-state-put doesn't update current buffer Organization: LINKOV.NET X-Debbugs-Cc: martin rudalics Date: Tue, 13 Feb 2024 09:39:29 +0200 Message-ID: <86il2s6cva.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=217.70.183.196; envelope-from=juri@linkov.net; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Martin, could you help to understand what is missing in 'window-state-put' that it doesn't set the current buffer correctly like 'set-window-configuration' does. For example, here the message says that the current-buffer and point still have old values coming from the old buffer that was current before calling 'window-state-put': (let (ws) (info) (setq ws (window-state-get nil 'writable)) (quit-window) (window-state-put ws nil 'safe) (message "! %S %S %S" (point) (current-buffer) (window-buffer))) However, 'set-window-configuration' works correctly and sets the restored buffer as current: (let (wc) (info) (setq wc (current-window-configuration)) (quit-window) (set-window-configuration wc nil t) (message "! %S %S %S" (point) (current-buffer) (window-buffer))) From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 14 04:12:33 2024 Received: (at 69093) by debbugs.gnu.org; 14 Feb 2024 09:12:33 +0000 Received: from localhost ([127.0.0.1]:50397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raBJg-0003jZ-PI for submit@debbugs.gnu.org; Wed, 14 Feb 2024 04:12:33 -0500 Received: from mout.gmx.net ([212.227.17.20]:43177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raBJe-0003jF-Bo for 69093@debbugs.gnu.org; Wed, 14 Feb 2024 04:12:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1707901925; x=1708506725; i=rudalics@gmx.at; bh=HCudOsX7T76S68OZyHF+GjmyE8rCVLb8SgQYgPrH4s4=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=kv4z0AbtdpWVdG4Zg1QezkilXn5FMYzm3ALxqIMhM1484Fcpo0YEUZ1rNamF8EVh jn/Xeq5pP1x3kVEVPVutWcqUM22VlV7l+KBfOE4gZGVSH8En+qy0VH/zfS7r2pD/B UP1jJ4ROR2tkZWAnpbmU0Jc8WipapmTYCIZHSA0zfeE3zezW/xmzcuV0sCgQJpABJ nEbEs11NkRbi0D/6XDEPk4M8wm0HdqiYFEROo9VM78jU0qf3x7SJp+JmvEM1b4ySF o/EX6PX7XAgtGMC8CWUEIWVFe6lk/vaU11FUhfmi7vaVAQcfN7n6HGekkRDPmh1Kt q8tK7DVxYdS/7kmAzg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.187]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MOiDX-1rKbRC2N8Z-00QBpz; Wed, 14 Feb 2024 10:12:05 +0100 Message-ID: <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> Date: Wed, 14 Feb 2024 10:12:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69093: window-state-put doesn't update current buffer To: Juri Linkov , 69093@debbugs.gnu.org References: <86il2s6cva.fsf@mail.linkov.net> Content-Language: en-US From: martin rudalics In-Reply-To: <86il2s6cva.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:o1bTYK1QPQquh9uRhwqqokMQbAW/f44W1FAj9X3ABB/D0/Fa3T8 3ct7Wso58ueM/s8w56oG5RDjTbdyVZhBWZzL5wmxhVna7GolsZ7oR6UO0tc/ytRTCFbyeM8 dc5WtkrvneRzpTj+fs6izxLuL/neDKK9eMhQmWJbbRnspMVwflAILaO+ht+zzcoBLPW6DIh 8c4y6g/0TLNH254/ZlrzA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:6Xe0LvYepKs=;FVNTcuK+e06Nw8YAikGIsF2MlJ6 eAVcJhFJkcS/ck00UZEtDD8lkBRCnNSNrZiJOquNxDa+MdlYJjeNmmmRSZuNrjCBanmN0jkPT YgtpZlWTeEdwB5bobS5vdp7S4LGX52ClipR4BRKbqEddca1BlMAMYSI04/jWimSG0NNUUgpJv NfPxIlsHyxt3xZ8/efKG0IuJ6tc+Xub1/w9kd6+g4OmfWKF45PUVWPBhV61pXmMgZyKme4l42 ThAKzK1wfDXhRgp6hajqMb1CV+baBmMgssXvpnrWuxPdLAdCNvZfl+3j1jEQQurJFd9QzxEel P9gWgLfwutv7EDqd9hEsudLnJdPVF/iFhZOIeUDkigDdebPtA+TVWT5T4GbRSFwraxGARP/Tq rxJsAzmKk6rOBpYX59GKfTzcSvJWjTdb7Bv5Dpw73pUyFukzsm2OWHddMSQTbVn97rZXdA5GN MviK1MOtqhdnqYGI3y7INguiPtd62RArJ6j0raotxngnWQ+15x9snb6H63ksMbseIYdskarD3 j5ZdcKcwqsBCC/ECmT8lTBHmyL17dKs72+45tU6s9ror/yp49QPztJG5ywnItVRxr9xyQK8h2 TJWGPXyUqYfmepVNXKohug0Aaoc9nU8AKEu729nEQ1VYy7I/I6p8RP0fXGgz2YP2LrWfPIpTW RDwdXzatSHb8KUHfhNhK6Z/1rhjKb9pC/GrlRjEBpAJK+D5pPb9U+L4+yX+CQVHnz7z/cT4Ik MPsOk5SitdY5ynn4Pyit1CAohZObPZJ4PyDbFXOx0TOhSVx9+9fErzgJqWMIKq3SNRIiHcZWU iDfbXM0HrKuiL2lbZccV5qsP1WOD6LjmziE19V3c3hkwc= X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 69093 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) > Martin, could you help to understand what is missing in > 'window-state-put' that it doesn't set the current buffer > correctly like 'set-window-configuration' does. The "current buffer" is not part of the state of a window. It is part of a more global state. Have a look at frameset.el which does at some time "Restore selected frame, buffer and point." As for what 'set-window-configuration' additionally does, have a look at 'current-window-configuration' where you can see that besides XSETBUFFER (data->f_current_buffer, current_buffer); it also saves the selected frame, scroll and selected windows of that frame's minibuffer or the frame that should receive input focus. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 15 02:43:25 2024 Received: (at 69093) by debbugs.gnu.org; 15 Feb 2024 07:43:25 +0000 Received: from localhost ([127.0.0.1]:53904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raWOy-0007fV-JR for submit@debbugs.gnu.org; Thu, 15 Feb 2024 02:43:24 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:58225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1raWOv-0007ew-36 for 69093@debbugs.gnu.org; Thu, 15 Feb 2024 02:43:22 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id AE17540007; Thu, 15 Feb 2024 07:42:35 +0000 (UTC) From: Juri Linkov To: martin rudalics Subject: Re: bug#69093: window-state-put doesn't update current buffer In-Reply-To: <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> (martin rudalics's message of "Wed, 14 Feb 2024 10:12:04 +0100") Organization: LINKOV.NET References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> Date: Thu, 15 Feb 2024 09:29:33 +0200 Message-ID: <86cysy1c7e.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) >> Martin, could you help to understand what is missing in >> 'window-state-put' that it doesn't set the current buffer >> correctly like 'set-window-configuration' does. > > The "current buffer" is not part of the state of a window. It is part > of a more global state. Have a look at frameset.el which does at some > time "Restore selected frame, buffer and point." > > As for what 'set-window-configuration' additionally does, have a look at > 'current-window-configuration' where you can see that besides > > XSETBUFFER (data->f_current_buffer, current_buffer); > > it also saves the selected frame, scroll and selected windows of that > frame's minibuffer or the frame that should receive input focus. Thanks for explanations. I see this line in 'set-window-configuration': Fset_buffer (new_current_buffer); Do you think this is the right fix? diff --git a/lisp/window.el b/lisp/window.el index 6df20353b5e..34e6c5d4a4f 100644 --- a/lisp/window.el +++ b/lisp/window.el @@ -6498,7 +6503,8 @@ window-state-put (when (and (window-valid-p window) (eq (window-deletable-p window) t)) (delete-window window)))) - (window--check frame)))) + (window--check frame) + (set-buffer (window-buffer))))) (defun window-state-buffers (state) "Return all buffers saved to the given window state STATE." From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 16 04:40:07 2024 Received: (at 69093) by debbugs.gnu.org; 16 Feb 2024 09:40:07 +0000 Received: from localhost ([127.0.0.1]:57866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rauhT-0003IE-C1 for submit@debbugs.gnu.org; Fri, 16 Feb 2024 04:40:07 -0500 Received: from mout.gmx.net ([212.227.17.20]:49715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rauhQ-0003Hc-Vy for 69093@debbugs.gnu.org; Fri, 16 Feb 2024 04:40:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1708076377; x=1708681177; i=rudalics@gmx.at; bh=BLnrmsX3ERvTagvC0G1eJEkNncfL4yIIRob7g/3rXnU=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=ZoAZMBLEwHrnl9OoM7O0h6Py0Ml2cN0hb03rBS/iesxXWvOBA0MxAp6cza0IDHic 92W4qDMYkNtZioH8kewXw8THk8vLj9B/3cRxvARomwBaUjnVPZ/86Xy0pCjGBDqbO 3fUBZwTBkgILbgOh+v69+goZBBuwdmof8lD5Y7Pw1JEnET3g5vAPwHde+ctuJnLMw 4SWCeqhlCuZgiddpLQ8R1Lyy+TOQDSu6bH2Rgvbt0kjYh7pzQpEgwxOq+WMm7sUoC mNV0nJoPiul0UjrpS5ZDKHX0oeqyFtX24hSAFOzQ4QGByFyAqJWP1dVsqYe77xCWe ufUTFlRNu/uu0JwYJg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([46.125.249.69]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MJmGP-1rGtlY2o6T-00K7dQ; Fri, 16 Feb 2024 10:39:37 +0100 Message-ID: <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> Date: Fri, 16 Feb 2024 10:39:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69093: window-state-put doesn't update current buffer To: Juri Linkov References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> Content-Language: en-US From: martin rudalics In-Reply-To: <86cysy1c7e.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:VwPOUtGGLyBh+oGVdZAE0di2XYzX6P8fsCkXKdWGWy72ZSy6T6z MaYBycK9k5a2+/ATpUMv1jkOOeoZEVFEG5F+NCNJNYrE4ge0aK6x5mi62u4Azj6D78LNNCH WmxppTFr4TW4FN2UW9e0IYFAgbK/saoN9UTgZHggVxQxY3VGI3TPk/aPTJd5he+qO6S2iI4 qiJuSDWx8n3DYptK6NdRQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:KaLGIkRfH78=;uz+xNau7K5uam8IMQvEzl7Oi16d 21ioMHBCzOXiT/7zlcO/H9tOwBJEPtIE5XeyN4p24DfWCnO2th7DaX7C2GLGcpVp5k9+Np+Ip syOL9dBr5Ohm1tV8lQ8wSJrYJEvERvBODaEbRawHE1m1N733jF4M3QACbey023mG/QAdfECoZ VvoFwryiPXS909zji6ac9OzZhFWzrt+LXHRLntdIVXJ0kyw6WzzTSVhNHAUv1w4ThMFnelCyv Y+7z+XWDaLXcCWSG4mqRFpRM08qWzrpiRVjv7S/ONKk7Cul1mKysUvCQNsFjpORay+lYxq449 SpTcUTuFXKM2ILhVBo6uKV9Spf9U2mgAYhE9l1kqc1ts8uJy0a7fdPA6WjDauJGPoy3BKaiWn x3JqjwbgsmcrGPfln+qKHi8vOkYuLtnxtzvJ2O7VqCrBjZUloLBmcP+9oRd+U9T2UgAJ0tHSK fUg1PCIcTR5PfvFsINijl2yA2Ta6bfvj0gHtWD4Algcxb6pa8Ao21CK0cz45yHJIxEqgpl7mH TZ7bITYVfdQ4ZNC/U4AqG2QG4L6GlIsRfuYYtGV4h+gHrQVJsuk90w8lKL4ftKPmaP/Pq4HVo g5/39Sk7dbOwA2izxphVv8tzYSK3Szqp0gyDYkzMq7YWLsioalP3qtn3wg0/9pLqeCCMe+L0s 02NlocVGEEONyeOVG2NtgwKScyypJufmFRY+KlWWCm1Jgc2Wv7xgRGD4YmqixMc5KfGlfRwkt zwNWgjfNjfACu9sFyqJbnL9LlYUZYMY4eWgNTEPn9XwbtSXVf6duCIt+ThrDH7dDO128AFQsE v2D40/+lDiv5w76hI/iBiGfITPr/eOb5BH5nLH2K0OYwk= X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) > Thanks for explanations. I see this line in 'set-window-configuration': > > Fset_buffer (new_current_buffer); > > Do you think this is the right fix? No. I think the right fix would be to remove the above line from 'set-window-configuration'. We can't do that because some applications might depend on the current behavior. But I am quite confident that nobody fully understands 'set-window-configuration' anyway and can predict what it does when selected frame, current buffer and the buffer and frame stored in the CONFIGURATION argument mismatch. Or could you tell beforehand which buffer will be current after (let ((configuration (current-window-configuration))) (pop-to-buffer "*Messages*" '((display-buffer-pop-up-frame))) (set-window-configuration configuration) (current-buffer)) I think that the behavior of (let ((frame (selected-frame)) (state (window-state-get))) (pop-to-buffer "*Messages*" '((display-buffer-pop-up-frame))) (window-state-put state (frame-root-window frame)) (current-buffer)) is much more consistent in this regard. I'd say that any code run in a state where the buffer of the selected window and the current buffer are not the same - regardless of whether this happens when a state/configuration is saved or restored - should simply report an error. But that ship has sailed long ago. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 16 06:47:00 2024 Received: (at 69093) by debbugs.gnu.org; 16 Feb 2024 11:47:00 +0000 Received: from localhost ([127.0.0.1]:57952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rawgG-0001C8-5K for submit@debbugs.gnu.org; Fri, 16 Feb 2024 06:47:00 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rawgD-0001Bv-9s for 69093@debbugs.gnu.org; Fri, 16 Feb 2024 06:46:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rawfl-00013D-7y; Fri, 16 Feb 2024 06:46:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xBqfoNU50/t1pr1Py5/1wa45gtVFY2xJFG9q1bWyLx8=; b=hIJ/JA5aByTQ bdqlNCYjNPD4/0XzEk9gSp293QChdWoyzhEu2g0YPJINoXIQ5Tt+QjfKbElOoxjPRBABburNk9LQj Lh69/X3worcZ76kXAmGvnE0tzjlX7C420mv5uMSr5Jgu6YFnlhKtU3Zd4oeP4PnfNmd78RyGwrBMB HK5T80MEL6Tt8uJe4Sv1Ox3B0rK4OF5GvvNRddImpvE79rrdRPu9UHsDaxqkXt/ugeaDJSA6t/bKe 6fi2ZNC2yIEd8V/u4WTg1BlEeDVZTAzWPsquAEdoV6oGr/1DmTq91OghQzZm2aa/Ngf/UmLPH01Dz EsiriXXAUcUnujt9Nh+Zpw==; Date: Fri, 16 Feb 2024 13:46:24 +0200 Message-Id: <86r0hcvdgv.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> (bug-gnu-emacs@gnu.org) Subject: Re: bug#69093: window-state-put doesn't update current buffer References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.2 (-----) > Cc: 69093@debbugs.gnu.org > Date: Fri, 16 Feb 2024 10:39:36 +0100 > From: martin rudalics via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > Thanks for explanations. I see this line in 'set-window-configuration': > > > > Fset_buffer (new_current_buffer); > > > > Do you think this is the right fix? > > No. I think the right fix would be to remove the above line from > 'set-window-configuration'. We can't do that because some applications > might depend on the current behavior. But I am quite confident that > nobody fully understands 'set-window-configuration' anyway and can > predict what it does when selected frame, current buffer and the buffer > and frame stored in the CONFIGURATION argument mismatch. A more worrisome aspect of such a change would be the gazillion uses of save-window-excursion. > I'd say that any code run in a state where the buffer of the selected > window and the current buffer are not the same - regardless of whether > this happens when a state/configuration is saved or restored - should > simply report an error. Some do, others don't. Still others silently correct the mismatch. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 18 02:48:07 2024 Received: (at 69093) by debbugs.gnu.org; 18 Feb 2024 07:48:07 +0000 Received: from localhost ([127.0.0.1]:34124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbbuB-0003iU-46 for submit@debbugs.gnu.org; Sun, 18 Feb 2024 02:48:07 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:33423) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rbbu8-0003hY-94 for 69093@debbugs.gnu.org; Sun, 18 Feb 2024 02:48:04 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id F3A0740004; Sun, 18 Feb 2024 07:47:16 +0000 (UTC) From: Juri Linkov To: martin rudalics Subject: Re: bug#69093: window-state-put doesn't update current buffer In-Reply-To: <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> (martin rudalics's message of "Fri, 16 Feb 2024 10:39:36 +0100") Organization: LINKOV.NET References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> Date: Sun, 18 Feb 2024 09:43:09 +0200 Message-ID: <86msryw7gy.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) > Or could you tell beforehand which buffer will be current after > > (let ((configuration (current-window-configuration))) > (pop-to-buffer "*Messages*" '((display-buffer-pop-up-frame))) > (set-window-configuration configuration) > (current-buffer)) Does this ambiguity exist only for multi-frame setups where a system window manager decides what frame to select afterwards? From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 19 04:43:30 2024 Received: (at 69093) by debbugs.gnu.org; 19 Feb 2024 09:43:30 +0000 Received: from localhost ([127.0.0.1]:40346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc0BO-0001xQ-77 for submit@debbugs.gnu.org; Mon, 19 Feb 2024 04:43:30 -0500 Received: from mout.gmx.net ([212.227.17.20]:51487) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc0BM-0001xE-F2 for 69093@debbugs.gnu.org; Mon, 19 Feb 2024 04:43:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1708335781; x=1708940581; i=rudalics@gmx.at; bh=lGDuGdb0vv636W2DKpyjuTpKkTpfNa1FcY9LBJTJ4+w=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=DUxDLfAMbUppZzisHU48RIiyr1h37SQaIiAIFZbwBYfCMwUYaBJ45um0lsdIFUdl Fe38A7nVStb4hl4VtzkieXflNb4qOZCKExI13q8pP25f/9vgzNZKxPQtRHnV8NldW XgEC3Hc97S5uy/5ebsfvjoSxBmXVjCeoppm+3YVIK++pjgkW7UxEa0wAdOngPlD/5 sk4V6vMQT0zjojo5dTQ3lfQxGGcrfJywyrRy0hA7u8HyCcp9wTEzFz779TwdMCB8J BOYDzbLvg3fLV3/myxKmLYmLJia/GAz0yui5D7xPuYL6jp5eU5U6crcMYPE9PR7mi mkfn94lnBSuXBcx5ZQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([46.125.249.97]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MBUqF-1rnFm60WmF-00D1kP; Mon, 19 Feb 2024 10:43:01 +0100 Message-ID: Date: Mon, 19 Feb 2024 10:43:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69093: window-state-put doesn't update current buffer Content-Language: en-US To: Juri Linkov References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <86msryw7gy.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:RPc4T5+PMDq0oOvUXdX6e3GbYwmT9uUA5wR9d8RaNv/CWg18kNn 6J9HKZosP4jEsoEpwcsizRer1cFKoSgSf9T6h6U1bfFWZ66/06bmDC6m04WlAUBfE9wCLnL zVQSLci0Bi8Mg/r9ZfNFmsvTM4MeMSCWmWZ4Em1b30EUBW/2ccJbIGTiRGoi4juIcVB+h5g yVgZOScQvMyJqwCiEw+4g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:9N7f7zeLzaE=;5R6r8tZNwCEYcWDzjp56aICyBZj xKC/Cq8tKFAsdaKNLK4EZ/QchChrpx7l9CymVXp1WvaAM0MqnswId7UewiUBv2pgvCbIUoJyt 8Is72Y80LMKif/0PIgDGCx2B5y63jY5GdmDjQzvXbIojwTbPE5Vk6tcOv8EdramLxZlEGv3Cv e3jWcgbrdZ8sYt+FD90gGITpwseTiPoCF1fhg1hY2AENO+9WOXPB/U7RXFk4Hqk+oxRSVHbtE V1H/T3K5wt9bRnIPv5wg/NSBq3doxt0MXpoTZ9GpiwSbLHGeSJiTXVaupoYOMVs1Ohs1JAA8m xCfAPcPFIEKVlpzeNXi92lN5oFDCEvfKgxqa/adFz4RWOYQc8pbUiOYgPL5SzOzWopW0ok14e hBo+HNP7GuKFf+SUaPYkrdVfT1V18BjAOP43VPSofcAzQKK0C+R18QjqGMjKY6ZahlJhFqy6A KpvhKUFuOuJBZ7S7bS1Sc9ZVqb1Kxcx8bIQznkfKm5uWF/4omAPekCJDBAz03JlbW9dvze1Av M5vGi4acHXfmZEZF1gp+BjhWVjM8mWemcUwmrGx0KMaQ0Kd2TwNOEpJh2wy4YR1Imp0DWHkIj CEOxFTfE4vGrMl47WkTwr1zmNEXzQsG6Lh292oZxo+E5A4djiXZWB7I6XZ+ZrJ8NsIGXsSfDP cNsGmLSlE5GgkZVAUlauz5zy/XNfd0F8UMEPdm22Tqcw2uxvOsq+TVxoLMbQBseSGSWHJQd6I ZijGqaVMSOByLTJolnj3KTNV+B3bX7J3pJ4CjsxogUIGdZsC3ZrJyTb8sQttYgSoGp+N+sfPc OlvyqJvYRBoSJ5e/3ypEl6IYIO8vgRkzHnCIC5QUF9r8c= X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) >> Or could you tell beforehand which buffer will be current after >> >> (let ((configuration (current-window-configuration))) >> (pop-to-buffer "*Messages*" '((display-buffer-pop-up-frame))) >> (set-window-configuration configuration) >> (current-buffer)) > > Does this ambiguity exist only for multi-frame setups where > a system window manager decides what frame to select afterwards? The system window manager here does only what Emacs tells it to do. But note that multi-frame setups got more and more broken since Emacs 26 and are maybe not used frequently nowadays. So you probably needn't give them much attention in the first place. martin From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 19 12:36:56 2024 Received: (at 69093) by debbugs.gnu.org; 19 Feb 2024 17:36:56 +0000 Received: from localhost ([127.0.0.1]:43341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc7ZX-0004cM-LD for submit@debbugs.gnu.org; Mon, 19 Feb 2024 12:36:56 -0500 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:34430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rc7ZR-0004c7-A4 for 69093@debbugs.gnu.org; Mon, 19 Feb 2024 12:36:53 -0500 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 41JFxhi0011556; Mon, 19 Feb 2024 17:36:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=zIK/nDmmI9rvMLFt59WXi3ZByKrwwnyAuEn3xIvkPl0=; b=Nc0aUBXgiLdLazgWnBB+j8np7BXVOh+bo6fT2g6BAkAub0cxCQiPwUVrmCeguMhu142m 6eavNduNGl6bKYxWMaMYCpgj6z62wr5dK3Uo7AtaiqZGkOC7nVGFPbTFVn4lRpWoKHQM /AyDkBNsbS/lN9rJRDYMgW/6kkxKtI8NR76LWART6uyjq5YL4VJSvS++33OsH40FDpb4 yl3y1fKQo2yhi2xplWepyPEWchcdOcEooFUuKpQGAom7KzFZQLTfIjUCqkhSscffJDXj Zx127U+qy6VNa6RMR9uVuRhPZL6vH7An6133lbJ8WkEq11u7ILi3AkLx4hQYWFJRHM0j dQ== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wakd24rpj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Feb 2024 17:36:26 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 41JFiuW6021097; Mon, 19 Feb 2024 17:36:26 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2169.outbound.protection.outlook.com [104.47.73.169]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3wak86b99w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Feb 2024 17:36:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C2bgKxJLqjozYn54bJ3mVl8oArvmxczdJHYqHSIH2qcovcBi5Vq72pRLX7wqdOQdx9BRrMWiiMVqlyyaRAugLMPB6gotCUDjyRbmFv5Zg0G8/tLN2U0f3KoBSnEfHOLJuPXnJu8NIhvscnjDw+X3IyNY9ogasxA+hQDWpqxEuUq+VBNlERiW1qIFsJCGRoiNad00XM0JOLS7A7kC97i1G7RsA82qvt5i/BkqxttfrakrRFJEafwqMvq0ck/xcIx90VtJUaMKO8BZ2Te0P8JMaTo+WPkBT9SxYugJffQf+sqm8Cgruq5xWF83PA8vWg2hSVtFiffUQLBZylhgZE53kQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zIK/nDmmI9rvMLFt59WXi3ZByKrwwnyAuEn3xIvkPl0=; b=ezVQ1Wl+2xAvVcCilzy/1NO+YaSfdtACoTisN06JiHWek0r0glkbpPN+SHRMv/prQVzhAj79cBrLL2Aj4UMpOo0183L7PrycQaEo7W8tavEXsmc0tQhB4G3V460DIXtLXCbsZyUHlNtf6GShfoZ3KV7jv+E9LCsFKfsK0vgYk2v4UJDk91BbRgq8/hPOIPliJGUsWZ1a6bTggsj3tuYzTZ2BJb8MFQ7LjPXZVjTyU8hWJ18rLQzxJIynE4Fq4BSBHLkGudOGPd0sc4g3XQWCZTp60d+sZKK8X2bX+Ba8iqsWoKkZLrPMsIp7rfboljNRQ/Ux5E+RM7wn8zK+CqOPRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zIK/nDmmI9rvMLFt59WXi3ZByKrwwnyAuEn3xIvkPl0=; b=qOvW8Vto0WD6xoYMfGlZ9NXSXAH7Ho2nhJADVCu6uwI4DR8mNE4GFIo4I4rilX/AKCLsYr7ep77MUT3WjRXYjtsr162qEqm3yAB9+WEtXQ6p2GXuwhyA0cF3qfIUHDhRgGeD59QJFh+bHDODhr/8WNYkPNmzwEJeVU4FxyenX7o= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BN0PR10MB5063.namprd10.prod.outlook.com (2603:10b6:408:126::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.39; Mon, 19 Feb 2024 17:36:23 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::d9bc:c5bb:7fc4:cf9f]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::d9bc:c5bb:7fc4:cf9f%5]) with mapi id 15.20.7292.036; Mon, 19 Feb 2024 17:36:23 +0000 From: Drew Adams To: martin rudalics , Juri Linkov Subject: RE: [External] : bug#69093: window-state-put doesn't update current buffer Thread-Topic: [External] : bug#69093: window-state-put doesn't update current buffer Thread-Index: AQHaYxgv1R4WMZuuZ0uqU/GyZ9zz/bER60Tw Date: Mon, 19 Feb 2024 17:36:23 +0000 Message-ID: References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|BN0PR10MB5063:EE_ x-ms-office365-filtering-correlation-id: a3c722b6-426d-4d03-1472-08dc31714aba x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rRKjfcgY8MPefRwbfSg0whqUmALS79qiKRE4KQnBZK0jRG/TxA9CEk8fJJurJQiYjut23Cag5M/H3Txw1cuLrEJPCq77ATirAlzECdNParEUH3dkmtCRvEOlj+gP9WefJ+8x6KZAzEmE2HAVcOLIHvXlni8O5/sbYN9w+qF/Rn1tZ6NbU2g0hHHWOu7xYDQOT8nb/DJOmJALtxBcVdp5IZql8vthFFhBxLO7gen75pTKIo7Q8zlDCeq3NZ/H6v1ZAst0iFbvIC2QJafG67Alg4Kt1Q/h8lrvzeN4BOuF24LmSFb9ifEAd2v8s/a5csELcucCcwsf6Qukc3C6upF2z0eAmzayikzug9AYsQ+yZf6xoae3rbamdI8TL8kY2egLVx9KXvTCEyAjJouIBmZFCHW1JtU6pvYYrRZ3IRK/RdfquqBYRjvTxLbqLIte7RyEhIdqUn0wnc0rGdOL8DEIKBpup5nndcd5e2wkpP9nHHeX6atM7UhFFj/Q565ztlXtMI99d+rrpd2rRlAkxURzciebjmVKj0NeKBI35pwDeB5ccjwKv0+W2o69aYgHcuPJHh7AR+Rcb/g3Ekl2qGjF1fj4Vk6efw6HGjCh4O9Quy9xg65Po2DdSUdsG0jQ1hdO x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SWRPeXQyY2w2dS9KSkcxbktvaVVNbmd2aXBER2RQcGdObFdFdHBGaWdkSnZK?= =?utf-8?B?RTRrYWtFS1gybEgyOXA3cktmekR4bzdDcFh2K2xLTmNmREhOcU9EVnZhcGFM?= =?utf-8?B?K2NtdXRITmJrNmx2MmRna3BSRTYxNDRNVW43V2lzenRCRHV4VGtZUms5ZG9M?= =?utf-8?B?M2Rzd1NBb1RKRzJmOGZsQkNqWCtra0h2dTQwa2hxS2oxL2xvb0RxdHZUUUls?= =?utf-8?B?ZjMwUDV3VStUa0JuU3pzM2lTa1NlcTEwaFVkWWpjcnJ0MHB6bUVSYmNadEVq?= =?utf-8?B?STFrVlpTekF6Z1p4VklnYnhuRUoxazhVRFArQlZmZVFYQWE4YXZMSVRhM204?= =?utf-8?B?QXVQWjZvbW9EQ204UWtYN3hjdWZXb04vOGFOcm9yemMrSzVhTmlaTStFQnBk?= =?utf-8?B?MVoyb0pGbFlHTWFSK3VETXhoQmhvV0xoTzZGUkIxcTgxVXlQZWE5ZXRhZWJG?= =?utf-8?B?TXBLY2xVSVZJRzI4cmFUTFYrWDhBcXhNVUNmVWVMNnlhN2NBd2pMdHBFR1ZK?= =?utf-8?B?OUt0YVZLMWVCbC9CNlpmdlJxeUlOd2VXMVpSRWx3TXBtTG1sWWtzMjZ1Vklw?= =?utf-8?B?U3lLQk1RdHRPNkUrL1pRc251UTBBeHBQV0h2Szc0V0toMGk2OFkvMzl5cDZF?= =?utf-8?B?cVl6SWNQS3dvOUlxakpBMTRRdnBOMHdlY0Q4TU9WU0RFN0oxNGwvKzVkK2Qr?= =?utf-8?B?Q1I1b3czOVF6T2dkSm9FS3JSazEyZEpnMHJHb1dNWEY5MzhsN0hSZzN0cTRn?= =?utf-8?B?WUFNTFZwQWV0VTBwRzIyL2JOa2NKU3V5TWFtK1pNaGhJaENoSVdBN1pnV1RD?= =?utf-8?B?QWxQSUpmcG9Waml3eUdlVDV1M1FId2pOWCt1L1U0eGxlTW12ZmVOVFI5WVBj?= =?utf-8?B?c2NVazRlUkdkYUhnOW1DVGVoVkJsTXFkVzc3SEtmaUsvVFN1aU1MQnExVSt1?= =?utf-8?B?Tk5NNmhYbE53dEROK1RxNnpsKzN4NmFzTjZ3WWphZTVtZkhJbEVueDVwWktC?= =?utf-8?B?K2VpTjZ6ZTViVHQ1ZFFKaDk5MkYwelhDUkZnTGdxMlJTOTRNMDZrVnN6SnBr?= =?utf-8?B?Y0Z4NWwvdGdjSVhJcnZQbzBpQlpxdEc0YVN6UjRrdkhWQnJLZDRlZkVWUFVW?= =?utf-8?B?K2FVMnRvdXdSNVgzK2VPbm1wUHNuTmk3WEFCRmJXN2lqaC9McmhKVW5vUUF3?= =?utf-8?B?QTB3enl5ZDVuMGFYMVJQOTlIQTdmU3lXbU1UUlhhTmE3YkpEdStFWGZvRmtP?= =?utf-8?B?bFhoTDl4YzRwN1QwbGRRZmpReEhJdzAyVU5vbGxrSWJMQWJkYWlqV285ZVBQ?= =?utf-8?B?RnNUOWtsVjdnV1RySVlPS0dScUYvb0VORnhINDVEWVNZZDBMSEkvYUUzZXgy?= =?utf-8?B?UjNlUXYxOTQreWtoSDdqNmQyZ2w0bXRhRWJUNFMwMDYzVVA2NG5VYWI3eWNH?= =?utf-8?B?T2EvR2Q5cmxVMWRxYVZiVXJGR1EwemtZOTFkT3JiUWswN0RuSTBXYW5JWWxv?= =?utf-8?B?VkN0UmRHNXBSWGM3ZlR4Z1hqK2dObDhOOHVPSU5WcEJPNzFxb1YvdVMvdG92?= =?utf-8?B?WUJ6YnJwUFBidW5nN0VKanNvN1ZqcEY5WFRma1EvSVBCTmNhVFFGODU3YzFX?= =?utf-8?B?djkzR0xkQVpuRHV5dGUreUZ2dVY3ZWpLRmFJT2VuRzg1UTUvQXpBNzRiRlF5?= =?utf-8?B?MVZtUSttMitzSitXTlRxWTlFUmR6NlBCbTFJV2FoamJQOW5CTlZsNThEN3VY?= =?utf-8?B?MUI4aWRielBTRThlQVBBRHE3Qk0zVmNDQWdpT1djYWh5ZHRXRUNRNTdkTXJq?= =?utf-8?B?YytJMkYzL2dJUjFBdDFvV2NSRi9aUUNSQVdYTkp6bjdsMzJVeGRlbGRKL1Y0?= =?utf-8?B?bm9MSWZTRzJrd0VrTEF0K3h4cjVpRVMxdVJUSDBMemgxRkI2YjdvWVdzS1JC?= =?utf-8?B?MzNYNXBhV2JwYVN4cjdwS0VlZDlUWGJLa2VRN0hDMG52cDVoZHJNYzc0SjBr?= =?utf-8?B?bUZlVkRZRnFrb2d0c3NsNXYrMnE0ZlhGYWFTYWZ5cTJXbGtvZFpYeDlGUy9n?= =?utf-8?B?Wm50ODJ6VDZ0UVNNQVlHVzFuQUEvQlZYNkE4dEx6Q3JLc3kwWmxRVnBoK0tS?= =?utf-8?Q?A9bu0iI8s6T7lDqMP+9SEfKsk?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 2A3B/XxbAI3aL3Ntp8AEhD/DebfXQ5ml5G+DtJB6lyONYQJMB0Lr9JBXuNhK7Lnh+EA6jfSbbfAgnZZ6Jf33h0sVhqcMfiA3Ms9LnQZeA5cWhDcjLErcrD/uzfRiTebb4pRYBoBFcbVSk2Wl1j9tWqE4BjyMA+E8aFeh20O6d1kpClbU+ispdy1o7IvLwC1S6CF9VVOn1leHF/ejmoHCLsAieBDh5BSls6EBYGIstm++JQ8MFkqycixkPFjDXgMjA8jd6+K5LlmqDzA+jwlka9MRLZnukcvYlv2DOFAoTKbHRhMzP7ZoFPBRtKXOAPiU3WOYojykPkhb5HXP/KgVeGZ+liqazOZ9mdtd5pc/glG+QwTiRr9MqZ3qdZmP/hYm7kj3ceaJ2OhPoEWV6OS+SuGe+0Amk3CWR9A/fXbn13KsSDRdEPGdXAUKiz2pClzTnPnJXE2KeEO/7Ws4bB40SbIXmj6q3ZCwOb3YfhMtCNEpdSuTNwtmCVr39bTs0geUDc8IbZ1V1P5OcLhlpDJ2RfYSRF817VtXoe1HwwSZl0kPowEOxT6NwXD99EpFGmWN6OfdBoTA+xuEPB+cx3UDWVJX/CQOYgG4rvaCg7/YlPk= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a3c722b6-426d-4d03-1472-08dc31714aba X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2024 17:36:23.3835 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JOcOlqtg3xQRelMfVJiGnIw/nFsgwyF27FXKbfSre21POUoHONUyXHtTX3IK/E4HdA6YuLnopY7tAagENo0MmA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5063 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-02-19_14,2024-02-19_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 adultscore=0 mlxlogscore=906 bulkscore=0 malwarescore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2402190132 X-Proofpoint-GUID: oKMPyvCeop-sziOeNNY5Cq7g3vxMs_6s X-Proofpoint-ORIG-GUID: oKMPyvCeop-sziOeNNY5Cq7g3vxMs_6s X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 69093 Cc: "69093@debbugs.gnu.org" <69093@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) PiBub3RlIHRoYXQgbXVsdGktZnJhbWUgc2V0dXBzIGdvdCBtb3JlIGFuZCBtb3JlDQo+IGJyb2tl biBzaW5jZSBFbWFjcyAyNg0KDQpZZXMuICBVbmZvcnR1bmF0ZWx5IHRoZSBwYXNzaXZlIHZvaWNl IGlzIG5lZWRlZA0KaGVyZSBiZWNhdXNlIG11Y2ggaGFzIGNoYW5nZWQgd2l0aG91dCBvdXIgYmVp bmcNCmFibGUgdG8gaWRlbnRpZnkgYW5kIHNheSB3aG8vd2hhdCBjaGFuZ2VkIHdoYXQuDQoNCj4g YW5kIGFyZSBtYXliZSBub3QgdXNlZCBmcmVxdWVudGx5IG5vd2FkYXlzLg0KDQpUaGV5IF9uZXZl cl8gd2VyZSBmcmVxdWVudGx5IHVzZWQuICBUaGV5IHdlcmUNCnN0YW5kYXJkIGluIEVwb2NoLCBi dXQgbmV2ZXIgaW50ZWdyYXRlZCBpbnRvDQpHTlUgRW1hY3MgT09UQi4gIEdOVSBFbWFjcyB1c2Vy cyBvZiB0aGVtIGhhdmUNCmFsd2F5cyBiZWVuIG91dGxpZXJzLiAgRHVubm8gd2hldGhlciBTdGVm YW4gTQ0Kc3RpbGwgdXNlcyBhIHN0YW5kYWxvbmUgbWluaWJ1ZmZlci4gIElmIG5vdCwNCkkgbWln aHQgYmUgdGhlIG9ubHkgdXNlciB3aG8gZG9lcy4NCg0KPiBTbyB5b3UgcHJvYmFibHkgbmVlZG4n dCBnaXZlIHRoZW0gbXVjaA0KPiBhdHRlbnRpb24gaW4gdGhlIGZpcnN0IHBsYWNlLg0KDQpUaGF0 J3MgdGhlIHByb2JsZW0gaW4gdGhlIGZpcnN0IHBsYWNlLCBhbmQgSU1PDQp0aGUgcmVhc29uIHRo ZXkndmUgbmV2ZXIgYmVlbiB1c2VkIGZyZXF1ZW50bHkuDQpFbWFjcyBkZXZlbG9wZXJzIGRvbid0 LCB0aGVtc2VsdmVzLCB1c2UgdGhlbSwNCmFuZCBzbyBkb24ndCB0ZXN0IGNoYW5nZXMgYWdhaW5z dCB0aGVtLC4uLg0KVmljaW91cyBjaXJjbGUuICBUb28gYmFkLg0KDQooTm8sIEkgZG9uJ3QgaGF2 ZSB0aGUgdGltZSBhbnltb3JlIHRvIHRyeSB0bw0KdHJhY2sgZG93biB3aGF0IG1pZ2h0IGhhdmUg YnJva2VuIHdoYXQgJiB3aGVuLg0KSnVzdCBzYXlpbmcgdGhhdCB0aGlzIGlzIHVuZm9ydHVuYXRl LiAgVGhpbmdzDQptaWdodCBoYXZlIGJlZW4gZGlmZmVyZW50IGlmIEdOVSBFbWFjcyBoYWQsDQpt YW55IG1vb24gYWdvLCBwcm92aWRlZCBhIHN0YW5kYWxvbmUgbWluaWJ1ZmZlcg0KT09UQiwgYSBs YSBFcG9jaC4pDQo= From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 20 02:59:18 2024 Received: (at 69093) by debbugs.gnu.org; 20 Feb 2024 07:59:18 +0000 Received: from localhost ([127.0.0.1]:44229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcL26-00063Z-1J for submit@debbugs.gnu.org; Tue, 20 Feb 2024 02:59:18 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:47499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcL23-00063J-LE for 69093@debbugs.gnu.org; Tue, 20 Feb 2024 02:59:16 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 5CC68C0004; Tue, 20 Feb 2024 07:58:47 +0000 (UTC) From: Juri Linkov To: martin rudalics Subject: Re: bug#69093: window-state-put doesn't update current buffer In-Reply-To: (martin rudalics's message of "Mon, 19 Feb 2024 10:43:00 +0100") Organization: LINKOV.NET References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> Date: Tue, 20 Feb 2024 09:40:11 +0200 Message-ID: <86il2jhb7o.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) >>> Or could you tell beforehand which buffer will be current after >>> >>> (let ((configuration (current-window-configuration))) >>> (pop-to-buffer "*Messages*" '((display-buffer-pop-up-frame))) >>> (set-window-configuration configuration) >>> (current-buffer)) >> >> Does this ambiguity exist only for multi-frame setups where >> a system window manager decides what frame to select afterwards? > > The system window manager here does only what Emacs tells it to do. But > note that multi-frame setups got more and more broken since Emacs 26 and > are maybe not used frequently nowadays. So you probably needn't give > them much attention in the first place. Ok, since it's impossible to fix 'window-state-put', let's narrow the scope just to the single-frame case in the caller 'tab-bar-select-tab': diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index d653f339fea..efca893fc16 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -1477,7 +1489,8 @@ tab-bar-select-tab ;; `window-state-put' fails when called in the minibuffer (when (window-minibuffer-p) (select-window (get-mru-window))) - (window-state-put ws nil 'safe))) + (window-state-put ws nil 'safe) + (set-buffer (window-buffer)))) ;; Select the minibuffer when it was active before switching tabs (when (and minibuffer-was-active (active-minibuffer-window)) From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 21 04:05:33 2024 Received: (at 69093) by debbugs.gnu.org; 21 Feb 2024 09:05:33 +0000 Received: from localhost ([127.0.0.1]:47877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rciXh-0006pm-Qx for submit@debbugs.gnu.org; Wed, 21 Feb 2024 04:05:33 -0500 Received: from mout.gmx.net ([212.227.17.20]:46143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rciXc-0006pO-R2 for 69093@debbugs.gnu.org; Wed, 21 Feb 2024 04:05:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1708506295; x=1709111095; i=rudalics@gmx.at; bh=RCU0a+gdWwGNn2wAEr/Qfuq2gPToJxgIZ4Z/poCS4+0=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=ZnphwLJXZ9e5vzlvNz+10hRS+cdkms6DmFzKl0MfYuiw5w6nAzvkTsaaxCgzAZXm oLQWiy/+9QvkxAFGBup+YqzWr3xbP9+PvMYtDCybIJF+4mVSEuQHmjPgsPrfn0/7b oydn3fATi4/V5gxwcNXlN12qCbkK7heg5jMcNh6tzjwb/TCAfjluZPdBwSPqBi4Io xBOsFRkCgURGdvw3fWkg/OdMJzfByqTCiVDqyrPDIbg4qM1+CU6K6smnlt+MDslWW bL5jGBbzkyJRhwWlMGWeG6Sep6hYEJc0X+YtTiYtRQLig5qEkj4TpT6sf8ZlREwab 5SSVhUrwubwoZ8wXQQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([46.125.249.57]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1M2f9b-1re5BA2pcV-004E4C; Wed, 21 Feb 2024 10:04:55 +0100 Message-ID: <843eff0e-134a-4ade-8c9f-c49166f85241@gmx.at> Date: Wed, 21 Feb 2024 10:04:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69093: window-state-put doesn't update current buffer To: Juri Linkov References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> <86il2jhb7o.fsf@mail.linkov.net> Content-Language: en-US From: martin rudalics In-Reply-To: <86il2jhb7o.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:KGoSwpWzWJYlqqBmHo1GoGVG2DZDW66OPn36y7zYO7WevBMUnZW QTbBGcPAVbsJwe3yl0tyxfWB4C1IEukaRt/7OGkMPnIyVQ9LbiF8wQqzkjHc1cHPLXFAWcw A7wxxnw/ZdHl+cVHWtpSbITm8HGKwQ/yA9b6U+32TZ54en82dfOJQffzOzOGssyKZB5pQCM YbzWy86zpLjJoSG9aP1Vw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:t6YpB+gd7e0=;lZU+vjK/tnWCZDTPxvhWncbqjsL jeHq5XZJwrqp/RGhbQTjTEEwd/9NoJd8lboY7bsVueyxh2lW0YmokZ3oHntz2PBhUJBbPB4kS Hj3s6/+2Sy5lArEpCtaCspjIZoQj6tMAIzocpdE0dgHgjpt5CtNXeIwARDZDE1voWxrGykvUM rdBYNicwo1HAdMsjyx+BKJwkH7Qcn1N/iQEMTKwJ/8aIIS4RQezMjbyEZ58OX9npqkqJhCPyp lqP7WQUftoz60nOMpyScHMNHZ8uzanAQgMu8v76TXI+QfP5J/aLSYRCdEdninqnwxqC0fLHRo n/ZJ8LZ8q4ypImjR1eKK2bk25mxmqBuEgEKShqc0TOWztGynGLUI7rC9O2i63DlZ3FVZ2GTvJ kb3reG1Foe92aHZ9g+GJ1y4YcqatkyiEzRy84uISXaV2+ztHd8fOyHDfjCxEmV/PCiFcjLppm ibgStA0reF/vQpl59FkdMyNhY5uJCW+9sNkFRZoTttjOvyBsnB1LOkPnOU4GBPNZQ/Ym5uinl 6RDkrnLVTkbZpMExKyA9/hcI/vV/yhQA6wyto7KLrOIlgNUEJPWhAfs+9ULxeupb053yhKw/U 8JNSKhtpAKYPNF3lnTfSxhlBBSB/5QV3THdezLc1pNMlUlz//h3Ly+vsqvKrRf0ZMHLe3FwA1 /b2pSZp2NIcov6N0MrGX/vJrWODPGE/a8JJQ99aYdWpgd5GHQPGB2AHNtr+56LIlkXRiePWRW gp4y4pbSEb1eYqFW0ya/2EiCtxZEEv2mMKwiBTOh9yATYApIqvk9A2RUaIiiH08W/Le3Ql+VD Hem/nYspiuLAZQaNc73nrrDhcailR2b+sPwsdVdQDs+fc= X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) I'd say that saving a window configuration where the current buffer is _not_ shown in the selected window is never right. So can you give me a practical example where you think that this > + (set-buffer (window-buffer)))) is useful or needed? martin From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 21 12:39:55 2024 Received: (at 69093) by debbugs.gnu.org; 21 Feb 2024 17:39:55 +0000 Received: from localhost ([127.0.0.1]:57178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcqZX-0003rF-27 for submit@debbugs.gnu.org; Wed, 21 Feb 2024 12:39:55 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:37641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcqZQ-0003qB-6F for 69093@debbugs.gnu.org; Wed, 21 Feb 2024 12:39:48 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id E5BDB20007; Wed, 21 Feb 2024 17:38:58 +0000 (UTC) From: Juri Linkov To: martin rudalics Subject: Re: bug#69093: window-state-put doesn't update current buffer In-Reply-To: <843eff0e-134a-4ade-8c9f-c49166f85241@gmx.at> (martin rudalics's message of "Wed, 21 Feb 2024 10:04:54 +0100") Organization: LINKOV.NET References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> <86il2jhb7o.fsf@mail.linkov.net> <843eff0e-134a-4ade-8c9f-c49166f85241@gmx.at> Date: Wed, 21 Feb 2024 19:27:37 +0200 Message-ID: <86y1bdviba.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) > I'd say that saving a window configuration where the current buffer is > _not_ shown in the selected window is never right. So can you give me a > practical example where you think that this > >> + (set-buffer (window-buffer)))) > > is useful or needed? This fix is needed for this case: (defun pulse-momentary-highlight-one-line (&optional point face) (save-excursion (goto-char (or point (point))) (let ((start (progn (vertical-motion 0) (point))) (end (progn (vertical-motion 1) (point)))) (pulse-momentary-highlight-region start end face)))) It expects that 'point' should be in the current buffer that is displayed in the selected window. But this hook fails: (add-hook 'tab-bar-tab-post-select-functions (lambda (_from-tab _to-tab) (pulse-momentary-highlight-one-line))) because this new hook is called in the patch below after finishing 'window-state-put' that doesn't set the current buffer to the window's buffer. So after 'window-state-put' finishes, the current buffer stays in some previous buffer. diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index 3e1d8278b04..50679f54474 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -1499,7 +1565,10 @@ tab-bar-select-tab (tab-bar--current-tab-make (nth to-index tabs))) (unless tab-bar-mode - (message "Selected tab '%s'" (alist-get 'name to-tab)))) + (message "Selected tab '%s'" (alist-get 'name to-tab))) + + (run-hook-with-args 'tab-bar-tab-post-select-functions + from-tab to-tab)) (force-mode-line-update)))) From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 22 04:10:24 2024 Received: (at 69093) by debbugs.gnu.org; 22 Feb 2024 09:10:24 +0000 Received: from localhost ([127.0.0.1]:38069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rd55z-0008Q1-Ij for submit@debbugs.gnu.org; Thu, 22 Feb 2024 04:10:24 -0500 Received: from mout.gmx.net ([212.227.15.15]:44623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rd4uh-0005AR-JI for 69093@debbugs.gnu.org; Thu, 22 Feb 2024 03:58:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1708592294; x=1709197094; i=rudalics@gmx.at; bh=35q8CWCkFMtgu545y2ievFCd037ciTzbx4ixI2fH4kA=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=cN+s+lVetfsw/UY6zuJtNmlicH6PtopZDFwpUypv44FowCYE52Dm6z+TRJZnMZLQ QUNHK/wjS0mt1b7ae9LThPScVBNYOfgF1EELva2h3BemsbKgEvWZXiy21yTwMJVOC kGSHDOkIhjYnIVZbasKNaw6Lgphrp/CG2PtrCf5nm/KH7C10cbFzb/XMQI22Sy/QO 99TNH2N1cPHrzXDWBQE6pAJ3rLhWU4NtAFznTfX1xFVcwocruDosvF/SS7ydpXYml cxoDhO4Jqc3VMxkOoUGRKPAfGKie4YnnORwBZXXJnuFRx+M3r606CYBANFIf5TS+E bdPAYCr/wMLpWEOknw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([213.142.96.173]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N2mFi-1qwPN33k5M-013AWQ; Thu, 22 Feb 2024 09:58:13 +0100 Message-ID: Date: Thu, 22 Feb 2024 09:58:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69093: window-state-put doesn't update current buffer To: Juri Linkov References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> <86il2jhb7o.fsf@mail.linkov.net> <843eff0e-134a-4ade-8c9f-c49166f85241@gmx.at> <86y1bdviba.fsf@mail.linkov.net> Content-Language: en-US From: martin rudalics In-Reply-To: <86y1bdviba.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 X-Provags-ID: V03:K1:dX7lomwmc+ahlEXFyKJJd2sc+y5DT7qNghe8eoMIibW45x4m8tn GViHIZGqJqJ/PlsmKFzSNVkHRBr8mwKRhWAUVYnSilEiFaBci20N6/AZycbUZqLFBzdmOdy mXT82RzBcSGMcy/I/FEEVw3kIicAwGrGHUp6Xc9T70I1vhPZ6OFjM+m69g0fLYxAV+Hv8ua +SXn2VHA2RoTI7/FZOXsg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:XRAHGMIn0eA=;yQR81zPQlynkM53VpDuQnOjfYrM TEs1DUe1FVCvHyuxIU5B0Ct1wAbOMfVYzVW/sZGwi8JEgkNV+ZP5Vm+gHV+zQlzmGtqTamBiQ hA5mu2KOokDKNQCzvXaCUpRO9UXLlpSb+yW9xeaCF+mYe4YZiEMVZNrueSXxuEld3yWNcsqlh w4Q1Y0z8m+hxrVCOs8L9ia89fqQT81vEwBrY41r+H77lErFzhvy29xV/f4BLsKIKv3syKA9M5 U4Vt47OIWqGeT1rlLsjb4HaA16cD85mZuYL8S9fsY0LVc+0NHpCxbSTbyfsohTH0bD0NSKNPh jskukd/Ffa/lI8v2pXA10VsewP4bNKXCRPyBcuiFvl6HshyYBTDW3SOxA76SlFlwx0q6Hj9O4 wgQirg1vJizvm56auKvwTi/PvPZYsMgGrIq6avJ783MIuu+BjtCkMaRgumRmBnATQ5+9WlUOJ ImbK/XPPeHwWWi04M26sgu8iKNQegeH7TSuEvgDLrSJcZPPkt3G1/tI1i/1397kyL6JII1vwc XkcVorTv8YXbD9B+o/0qpRDCahl42ksyywFBP1xEDBUrla/+c2jzKkL1oJuPIrNizGlJDo4iJ nPKfmPvsJ7e547c6sUdfadg6vi5Dw+lRK7h2io0z6Lp4vZmMd77P6f++DLWiaSp3jLTqUAFzW eLoGTMzxulRfOP+tq1ndCM215ZkPssgIKRSFI/kiErs4GRM+KTxBQPMhjW5CG479+KI/AmJ6L cdYsOCFSI1rjnWrGLzOIn5mLcsIEabzETgahiLBapUazoaw23oIMbG7SmAK+ep8VhrpVt+tQX 5BzsrAqyEmMtgNWY8432D1XDmX/MK5eWuQUgz8xpf3gMM= X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) ID4gVGhpcyBmaXggaXMgbmVlZGVkIGZvciB0aGlzIGNhc2U6DQogPg0KID4gKGRlZnVuIHB1 bHNlLW1vbWVudGFyeS1oaWdobGlnaHQtb25lLWxpbmUgKCZvcHRpb25hbCBwb2ludCBmYWNl KQ0KID4gICAgKHNhdmUtZXhjdXJzaW9uDQogPiAgICAgIChnb3RvLWNoYXIgKG9yIHBvaW50 IChwb2ludCkpKQ0KID4gICAgICAobGV0ICgoc3RhcnQgKHByb2duICh2ZXJ0aWNhbC1tb3Rp b24gMCkgKHBvaW50KSkpDQogPiAgICAgICAgICAgIChlbmQgKHByb2duICh2ZXJ0aWNhbC1t b3Rpb24gMSkgKHBvaW50KSkpKQ0KID4gICAgICAgIChwdWxzZS1tb21lbnRhcnktaGlnaGxp Z2h0LXJlZ2lvbiBzdGFydCBlbmQgZmFjZSkpKSkNCiA+DQogPiBJdCBleHBlY3RzIHRoYXQg J3BvaW50JyBzaG91bGQgYmUgaW4gdGhlIGN1cnJlbnQgYnVmZmVyDQogPiB0aGF0IGlzIGRp c3BsYXllZCBpbiB0aGUgc2VsZWN0ZWQgd2luZG93Lg0KDQpUaGlzIGZ1bmN0aW9uIHdpbGwg cHJvYmFibHkgbm90IERUUlQgd2hlbiB0aGUgc2FtZSBidWZmZXIgaXMgZGlzcGxheWVkDQpp biB0d28gd2luZG93cyB3aXRoIGRpZmZlcmVudCB2YWx1ZXMgb2YgcG9pbnQuICBJdCBzaG91 bGQgdXNlIGFuIG92ZXJsYXkNCndpdGggYSAnd2luZG93JyBwcm9wZXJ0eS4NCg0KID4gQnV0 IHRoaXMgaG9vayBmYWlsczoNCiA+DQogPiAoYWRkLWhvb2sgJ3RhYi1iYXItdGFiLXBvc3Qt c2VsZWN0LWZ1bmN0aW9ucw0KID4gICAgICAgICAgICAobGFtYmRhIChfZnJvbS10YWIgX3Rv LXRhYikNCiA+ICAgICAgICAgICAgICAocHVsc2UtbW9tZW50YXJ5LWhpZ2hsaWdodC1vbmUt bGluZSkpKQ0KID4NCiA+IGJlY2F1c2UgdGhpcyBuZXcgaG9vayBpcyBjYWxsZWQgaW4gdGhl IHBhdGNoIGJlbG93DQogPiBhZnRlciBmaW5pc2hpbmcgJ3dpbmRvdy1zdGF0ZS1wdXQnIHRo YXQgZG9lc24ndA0KID4gc2V0IHRoZSBjdXJyZW50IGJ1ZmZlciB0byB0aGUgd2luZG93J3Mg YnVmZmVyLg0KID4gU28gYWZ0ZXIgJ3dpbmRvdy1zdGF0ZS1wdXQnIGZpbmlzaGVzLA0KID4g dGhlIGN1cnJlbnQgYnVmZmVyIHN0YXlzIGluIHNvbWUgcHJldmlvdXMgYnVmZmVyLg0KDQpJ ZiBieSAiZmFpbHMiIHlvdSBtZWFuIHRoYXQgJ3dpbmRvdy1zdGF0ZS1wdXQnIGRvZXMgbm90 IHNlbGVjdCB0aGUNCndpbmRvdyBzZWxlY3RlZCBhdCB0aGUgdGltZSB0aGUgY29ycmVzcG9u ZGluZyAnd2luZG93LXN0YXRlLWdldCcgd2FzDQpydW4sIHRoZW4geW91IHNob3VsZCBmaXgg dGhpcyBpbiB0aGUgdGFiIGJhciBjb2RlIGJ5IHJlY29yZGluZyB0aGUNCmZyYW1lJ3Mgc2Vs ZWN0ZWQgd2luZG93IHRvZ2V0aGVyIHdpdGggdGhlIHN0YXRlIGFuZCwgZGVwZW5kaW5nIG9u DQp3aGV0aGVyIHRoZSBmcmFtZSB5b3UgcHV0IHRoZSBzdGF0ZSBpbnRvIGlzIHNlbGVjdGVk IG9yIG5vdCwgZWl0aGVyIHNldA0KdGhhdCBmcmFtZSdzIHNlbGVjdGVkIHdpbmRvdyBvciBz ZWxlY3QgdGhhdCB3aW5kb3cuICBUaGUgbGF0dGVyIGNhc2UNCnNob3VsZCB0aGVuIG1ha2Ug dGhhdCB3aW5kb3cncyBidWZmZXIgY3VycmVudC4NCg0KSWYgYnkgImZhaWxzIiB5b3UgbWVh biB0aGF0IHNvbWV0aGluZyBpbiDigJh3aW5kb3ctc3RhdGUtcHV04oCZIG1ha2VzIHRoZQ0K c2VsZWN0ZWQgd2luZG93IG5vdCBzaG93IHRoZSBjdXJyZW50IGJ1ZmZlciwgd2UgaGF2ZSB0 byBkaWcgZnVydGhlci4NCg0KQnV0IGluIG5laXRoZXIgY2FzZSB1c2UgJ3NldC1idWZmZXIn IHRvIGZpeCBhIHdpbmRvdy9idWZmZXIgcmVsYXRpb25zaGlwDQp0aGF0IGhhcyBiZWVuIHNj cmV3ZWQgdXAgZWxzZXdoZXJlLg0KDQptYXJ0aW4NCg== From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 22 12:42:22 2024 Received: (at 69093) by debbugs.gnu.org; 22 Feb 2024 17:42:22 +0000 Received: from localhost ([127.0.0.1]:44682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdD5S-0002IZ-HD for submit@debbugs.gnu.org; Thu, 22 Feb 2024 12:42:22 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:33387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdD5R-0002IC-3Q for 69093@debbugs.gnu.org; Thu, 22 Feb 2024 12:42:21 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 1BE966000B; Thu, 22 Feb 2024 17:41:30 +0000 (UTC) From: Juri Linkov To: martin rudalics Subject: Re: bug#69093: window-state-put doesn't update current buffer In-Reply-To: (martin rudalics's message of "Thu, 22 Feb 2024 09:58:12 +0100") Organization: LINKOV.NET References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> <86il2jhb7o.fsf@mail.linkov.net> <843eff0e-134a-4ade-8c9f-c49166f85241@gmx.at> <86y1bdviba.fsf@mail.linkov.net> Date: Thu, 22 Feb 2024 19:23:36 +0200 Message-ID: <86sf1ks9oj.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: juri@linkov.net X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.6 (---) >> (defun pulse-momentary-highlight-one-line (&optional point face) >> (save-excursion >> (goto-char (or point (point))) >> (let ((start (progn (vertical-motion 0) (point))) >> (end (progn (vertical-motion 1) (point)))) >> (pulse-momentary-highlight-region start end face)))) >> >> It expects that 'point' should be in the current buffer >> that is displayed in the selected window. > > This function will probably not DTRT when the same buffer is displayed > in two windows with different values of point. It should use an overlay > with a 'window' property. Agreed, a 'window' property would be nice. > If by "fails" you mean that 'window-state-put' does not select the > window selected at the time the corresponding 'window-state-get' was > run, then you should fix this in the tab bar code by recording the > frame's selected window together with the state and, depending on > whether the frame you put the state into is selected or not, either set > that frame's selected window or select that window. The latter case > should then make that window's buffer current. The window state already has information about the selected window: (selected . t) > If by "fails" you mean that something in ‘window-state-put’ makes the > selected window not show the current buffer, we have to dig further. 'window-state-put' fails to select the previously selected window's buffer with the property (selected . t). From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 23 03:48:40 2024 Received: (at 69093) by debbugs.gnu.org; 23 Feb 2024 08:48:40 +0000 Received: from localhost ([127.0.0.1]:51510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdREV-0007z3-E8 for submit@debbugs.gnu.org; Fri, 23 Feb 2024 03:48:40 -0500 Received: from mout.gmx.net ([212.227.17.20]:40717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdRES-0007y6-VB for 69093@debbugs.gnu.org; Fri, 23 Feb 2024 03:48:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1708678087; x=1709282887; i=rudalics@gmx.at; bh=iibiGadoWeyIPJnUE3/G7cCmQMUO0T32yd5V5hdrq38=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=auVph83HAs/zPaUUNrheiqACpXxKex2oedR7bhabSR5oQSAfrARtGTWc5YDfkpFM c3RLoLs9CtMF1P6ShX3Lowl5PcF+ELg2r02AaCIaAMYmo/8CgzYBjqji2J9zjzBOA 9PABlQzt1iQyRbf06GewlEgc39KqCl/7A1PVPkA12SmXxEWlAFZl3zB6zn1vz6u2R 9hvVD8ZN5tTJsSm4Mw+BIn0EEd/Uqsx/2eH/JPQDrhvhhMd6fw5HqCjSawYgqC4RV u5Req7RUNXEFmTMYMRESVd1ugqx1Bdn3kbyw0qu/auJpzceenGzpHUynHz5KbKUYR G39d5czZZtuOpIkPRw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([213.142.96.37]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N1Obb-1qu9m93S6V-012pHG; Fri, 23 Feb 2024 09:48:06 +0100 Message-ID: <5307fa5c-725a-4d73-ae2f-07668e4bd5b3@gmx.at> Date: Fri, 23 Feb 2024 09:48:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69093: window-state-put doesn't update current buffer To: Juri Linkov References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> <86il2jhb7o.fsf@mail.linkov.net> <843eff0e-134a-4ade-8c9f-c49166f85241@gmx.at> <86y1bdviba.fsf@mail.linkov.net> <86sf1ks9oj.fsf@mail.linkov.net> Content-Language: en-US From: martin rudalics In-Reply-To: <86sf1ks9oj.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 X-Provags-ID: V03:K1:YcJ6KlQv7f9xpHx7as+4YjcMzQO0hWyPChoW8ZY5llGtDsk8cfS 9WGXxCZTg+56mCy7Hr/U0eNNHs7rMmYNXSHmsTMhhUT56nZ5/xOk8Pa/Z2Qak1/iJl31HHX WlsQHsTvpI0I2G2NoarNEb4ce3DU7gYSipC+Fn6BOb5a0q2c79diLRiU7HJ1gmVquYD+dIb Xfv7mgzLx4G1tXxcag1kw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:hcz/HC6CzZE=;LvljKjNIIcCgNDi9+Y0HWZKLMul 8DW5ZyVmGRK4oij7IjkqPzmkx1pa0IUiEbkW4+rpFOV5QJdgtndg9QQGvJJeMiqh7ILtp0eFC L4tqKhYyyD4njUGOwfyBr7YVZEx/+h4vJTCd/aQL5imupo+KlJZDk5IPuiZxkgF46Ozs1+I3/ nsPv4f4gkf/XgnOJam81JVZj4Ao60syO1tmHf9OghPG41krTlB7MTsxVY24HGAyAq6f/PrsHf 13sl2xvyhOBnr3smGFi+xbnBZ/TcHBOWdB/jixPzp0mMlu7pZnATYo40IM/BGElb/u8DtODsB OjEtT0/YA89wMnTWRugoZp7onI/Irl0tdetNkRI8vZ3oDRfguOYDvsSVMnn7SQSODAqG8g15l khGVhnIhJSO61mwCLURYU367IRuBhnayAPcxbKhPP9YExlnvdLzKA+GHA6RhKFp/FuuHeS12q itSpLy8PRRSg1eKcTLVGoPUSf4gpBR3ytivjVdifLtjmOPCB4BYk6gLaaPzYVBXFYyXasImAQ WjRjwQOBItA6/+opKZq60QGzju4LjY+ypOM/Ww6e2qC7RKpzhRFCBeMdZIk2yrMQVe/1jJS4b Qf1e3SwHmROZDDcLRAfLt+p5r54KZaFYRkUz+uN9/MIF9qjCpftj1HG2JBJViXmP/LxvZIBNO v9sys9qVkA5DeBQBCSSVXonHathxaKXrXBsxn7fbXJPlOOMAxsTZu2rqR0FZ6gDf1pkfpad1k biEH7UZyvvXe4ra8MnOk9NtE4OJuRx1wrFZmCxPS8c3qJXOwG50AYRTckv4G+JZgAsrpqK13m J526j5LUmC/NeePp5CZpKp7h8e1oZImkeE/fXpuuac9Pg= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) ID4+IElmIGJ5ICJmYWlscyIgeW91IG1lYW4gdGhhdCBzb21ldGhpbmcgaW4g4oCYd2luZG93 LXN0YXRlLXB1dOKAmSBtYWtlcyB0aGUNCiA+PiBzZWxlY3RlZCB3aW5kb3cgbm90IHNob3cg dGhlIGN1cnJlbnQgYnVmZmVyLCB3ZSBoYXZlIHRvIGRpZyBmdXJ0aGVyLg0KID4NCiA+IFRo ZSB3aW5kb3cgc3RhdGUgYWxyZWFkeSBoYXMgaW5mb3JtYXRpb24gYWJvdXQgdGhlIHNlbGVj dGVkIHdpbmRvdzoNCiA+DQogPiAgICAoc2VsZWN0ZWQgLiB0KQ0KDQpJIGZvcmdvdC4gIElm IHRoZSBzZWxlY3RlZCB3aW5kb3cgaXMgcGFydCBvZiB0aGUgc2F2ZWQgc3RhdGUsIHRoaXMg aXMNCnNldC4NCg0KID4gJ3dpbmRvdy1zdGF0ZS1wdXQnIGZhaWxzIHRvIHNlbGVjdCB0aGUg cHJldmlvdXNseSBzZWxlY3RlZA0KID4gd2luZG93J3MgYnVmZmVyIHdpdGggdGhlIHByb3Bl cnR5IChzZWxlY3RlZCAuIHQpLg0KDQpJdCBzaG91bGQgaGF2ZSBzZWxlY3RlZCBpdCBoZXJl DQoNCgkJOzsgU2VsZWN0IHdpbmRvdyBpZiBpdCdzIHRoZSBzZWxlY3RlZCBvbmUuDQoJCSh3 aGVuIChjZHIgKGFzc3EgJ3NlbGVjdGVkIHN0YXRlKSkNCgkJICAoc2VsZWN0LXdpbmRvdyB3 aW5kb3cpKQ0KDQpQbGVhc2UgZmlyc3QgY2hlY2sgd2hldGhlciB0aGlzICdzZWxlY3Qtd2lu ZG93JyBjYWxsIGlzIGV4ZWN1dGVkIGF0IGFsbA0KaW4geW91ciBzY2VuYXJpby4gIElmIGl0 IGlzLCBwbGVhc2UgZmluZCBvdXQgd2hpY2ggd2luZG93IGFwcGFyZW50bHkNCmdldHMgc2Vs ZWN0ZWQgaW5zdGVhZCBhZnRlcndhcmRzIGFuZCB0cnkgdG8gZmluZCBvdXQgd2h5LiAgSWYg dGhlcmUncyBubw0KY2x1ZSwgeW91IHdvdWxkIGhhdmUgdG8gZmluZCBvdXQgd2hvIHVuZG9l cyB0aGF0IHNlbGVjdGlvbiBmaXJzdCBieQ0KcHV0dGluZyBhIGJyZWFrcG9pbnQgaW50byBG c2VsZWN0X3dpbmRvdyBhbmQsIGlmIHRoYXQgZmFpbHMsIGJ5IHB1dHRpbmcNCmEgYnJlYWtw b2ludCBpbnRvIHNlbGVjdF93aW5kb3cgKHdoaWNoIGNhbiBiZSBhIHBhaW4pLg0KDQptYXJ0 aW4NCg== From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 24 15:25:20 2024 Received: (at 69093) by debbugs.gnu.org; 24 Feb 2024 20:25:20 +0000 Received: from localhost ([127.0.0.1]:55261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdyaF-0001o6-QN for submit@debbugs.gnu.org; Sat, 24 Feb 2024 15:25:20 -0500 Received: from mslow1.mail.gandi.net ([217.70.178.240]:46671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdyaD-0001ng-Vo for 69093@debbugs.gnu.org; Sat, 24 Feb 2024 15:25:18 -0500 Received: from relay6-d.mail.gandi.net (unknown [217.70.183.198]) by mslow1.mail.gandi.net (Postfix) with ESMTP id CAFE1C28B6 for <69093@debbugs.gnu.org>; Sat, 24 Feb 2024 17:55:42 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 8A594C0007; Sat, 24 Feb 2024 17:55:16 +0000 (UTC) From: Juri Linkov To: martin rudalics Subject: Re: bug#69093: window-state-put doesn't update current buffer In-Reply-To: <5307fa5c-725a-4d73-ae2f-07668e4bd5b3@gmx.at> (martin rudalics's message of "Fri, 23 Feb 2024 09:48:05 +0100") Organization: LINKOV.NET References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> <86il2jhb7o.fsf@mail.linkov.net> <843eff0e-134a-4ade-8c9f-c49166f85241@gmx.at> <86y1bdviba.fsf@mail.linkov.net> <86sf1ks9oj.fsf@mail.linkov.net> <5307fa5c-725a-4d73-ae2f-07668e4bd5b3@gmx.at> Date: Sat, 24 Feb 2024 19:32:56 +0200 Message-ID: <86o7c5epiv.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) >> 'window-state-put' fails to select the previously selected >> window's buffer with the property (selected . t). > > It should have selected it here > > ;; Select window if it's the selected one. > (when (cdr (assq 'selected state)) > (select-window window)) > > Please first check whether this 'select-window' call is executed at all > in your scenario. If it is, please find out which window apparently > gets selected instead afterwards and try to find out why. The right window is selected, and its buffer becomes current. > If there's no clue, you would have to find out who undoes that > selection first by putting a breakpoint into Fselect_window and, if > that fails, by putting a breakpoint into select_window (which can be > a pain). The problem is that afterwards the same function undoes the setting of current buffer. In window--state-put-2, select-window is inside with-current-buffer that undoes the current buffer selection: (with-current-buffer buffer ... ;; Select window if it's the selected one. (when (cdr (assq 'selected state)) (select-window window)) Also in window-state-put, with-temp-buffer undoes the current buffer: (with-temp-buffer (set-window-buffer window (current-buffer)) (window--state-put-1 state window nil totals pixelwise) (window--state-put-2 ignore pixelwise)) From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 04:18:03 2024 Received: (at 69093) by debbugs.gnu.org; 25 Feb 2024 09:18:03 +0000 Received: from localhost ([127.0.0.1]:57129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reAe1-0005Vc-S1 for submit@debbugs.gnu.org; Sun, 25 Feb 2024 04:18:03 -0500 Received: from mout.gmx.net ([212.227.15.15]:50163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reAdy-0005Uz-W3 for 69093@debbugs.gnu.org; Sun, 25 Feb 2024 04:18:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1708852647; x=1709457447; i=rudalics@gmx.at; bh=npEoSttfwXtL0XKueR720EMHJlN89cxQZwN9qwbvGAg=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=X6IgNkRhPlN3NOYRtqWEFG1i/fxvxtCkWC35utyy751CARRuxCy3qHPYhqvDC5xd xa549PtmbjzNxVDTIzN0ebLQ6hneMuFWtDmgudcYalb56N6cLoxa8ACLSPfd9SkKF 4svVoFg0JWjRztWPtzjzkLJd4ZC1uG4lzNAD9vXIqoAqYD3dsuUxEtfVFXHttCWKc /K51X7e5OAVJ4YBBEcNQIcoNTk+TcTN8wnYaEOFZAFz7OvSHhnKqQIWZs4oAOR8Dq KqX14ys4pfRwXPonjSNN8hs8xnCDLFvwkBNhy59eaEssUvvidPGEx6xERm4WThNkN RZqR7s7BbzEGXMM+4w== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.120]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M3DJv-1rcnak2m5d-003Zq6; Sun, 25 Feb 2024 10:17:27 +0100 Content-Type: multipart/mixed; boundary="------------aR0enOl28RnEkWC18jG0TQDX" Message-ID: Date: Sun, 25 Feb 2024 10:17:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69093: window-state-put doesn't update current buffer To: Juri Linkov References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> <86il2jhb7o.fsf@mail.linkov.net> <843eff0e-134a-4ade-8c9f-c49166f85241@gmx.at> <86y1bdviba.fsf@mail.linkov.net> <86sf1ks9oj.fsf@mail.linkov.net> <5307fa5c-725a-4d73-ae2f-07668e4bd5b3@gmx.at> <86o7c5epiv.fsf@mail.linkov.net> Content-Language: en-US From: martin rudalics In-Reply-To: <86o7c5epiv.fsf@mail.linkov.net> X-Provags-ID: V03:K1:Oe5Xt5fG6MD7OtW61ZeCGoeXlBFjcieXVyOilvL7ZjSI0xeuZ7u QjRfqaayIOcjZejAIGykt71jmNK0/9vrUaG9muHs5neiE0ZOay4bQ0jolyuMrUgZCv73hT6 RzFgeIFYG/lki5A+aFBD+2Zcm1W228LSoAWXJEiaqu956epYKsa8Bv3PCqqGRyQptnqaEN5 GVpdlMS/g1X6K4DuH8RoQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Rx0Q5vcnFPo=;5RXqybw1T/JzoheD3A5kpI6Q6gR XO2Q+YIQHao8WmKWJ7iW1k7uELDxoAr3+0/aiTb+9eneBEPECpJ7WCeilNtbu+k1Zwf5QfoCk FUvABJFca3nFkCWqcq2hmAvhdx5xS6DQNb5p3pF/6VdfdrHfk6yDW8acWNAcRP+Llb51NyiFD pO44TKwDhXDt2Zs6VeiCCSQZb9NOpx9krAO3QEKRi/H1yQ3I8swe7IjFPEnJvHH4WNHEZGzF5 TfIQh/Y7PrLuAVKYliMb8Y71Uh7yFx1AhYiXIDVN5j1SQMxJ1+IVnadeApeBQALdlLFNYpiFF fkuQIqphxkaKjEwXtGKLB5puI0kbOHAAy6Lwb+THzSS2ZWXQEvicM5nkHMqeykFRYY73o3M+9 GbfQcEA0ISwuhxrHgkTT/V099Val7wWKNU416dC6YlV7LJn2vuF7n8mt34dMor7xRHQa43mZt CDsXVr02mqSypp/qvv06aJ3u7ZZGGTs07/GaAF+BvqnWtETRAIAW+/IhxINvh4mNtm1uwGcdI xcuNG9srgNYEdm7uvcGKd+WbnupBQuL4wGOQTq94PZ7PTSBNXeaSbi/i9dTA/XGt0o/S+3nET pfZSlW+EbeM6Ndpm5TmC2FuwpztfDyc4RDAxSYq/CETakFYuWzYh//QWJHerCnvM2r0dMo2Mg yzJNkS6X1t6WKQMhrJZVPpMjPzzWLonj1ZjNIVKbOsypQon5z+732nbtPr6NPlG+Ga8kq+QeN L+wq1A03Xvn+pNONYp5QzVSo2IUpMYCzxqnQnChqvXIjDRh6lusLJH0iAqbLXsjYZ+TIpqhvl h3twzO8InncjIvHsGFi6UZeptoJvJjQobZK0/Ec+tGMQM= X-Spam-Score: 2.9 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > The problem is that afterwards the same function undoes the setting of > current buffer. In window--state-put-2, select-window is inside > with-current-buffer that undoes the current buffer selecti [...] Content analysis details: (2.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.120 listed in zen.spamhaus.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.15 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.15 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > The problem is that afterwards the same function undoes the setting of > current buffer. In window--state-put-2, select-window is inside > with-current-buffer that undoes the current buffer selecti [...] Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.15.15 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.120 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.15 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -0.0 T_SCC_BODY_TEXT_LINE No description available. -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager This is a multi-part message in MIME format. --------------aR0enOl28RnEkWC18jG0TQDX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > The problem is that afterwards the same function undoes the setting of > current buffer. In window--state-put-2, select-window is inside > with-current-buffer that undoes the current buffer selection: > > (with-current-buffer buffer > ... > ;; Select window if it's the selected one. > (when (cdr (assq 'selected state)) > (select-window window)) > > Also in window-state-put, with-temp-buffer undoes the current buffer: > > (with-temp-buffer > (set-window-buffer window (current-buffer)) > (window--state-put-1 state window nil totals pixelwise) > (window--state-put-2 ignore pixelwise)) Silly me. So far this apparently never caused any problems because command_loop_1 makes the buffer of the selected window current. But it will affect any code running after calling 'window-state-put' up to and including the next 'post-command-hook'. The attached patch (including the former changes) should fix it. I left the old 'select-window' call in just for the case that its effect is used elsewhere in a function called by 'window--state-put-2' later. Many thanks for the analysis, martin --------------aR0enOl28RnEkWC18jG0TQDX Content-Type: text/x-patch; charset=UTF-8; name="keep-windows.diff" Content-Disposition: attachment; filename="keep-windows.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3Avd2luZG93LmVsIGIvbGlzcC93aW5kb3cuZWwKaW5kZXggZTEw MGYyNTUyNmIuLjhlOTY2YjU5NGY4IDEwMDY0NAotLS0gYS9saXNwL3dpbmRvdy5lbAorKysg Yi9saXNwL3dpbmRvdy5lbApAQCAtNjE3NCw2ICs2MTc0LDEyIEBAIHdpbmRvdy1zdGF0ZS1w dXQtbGlzdAogKGRlZnZhciB3aW5kb3ctc3RhdGUtcHV0LXN0YWxlLXdpbmRvd3MgbmlsCiAg ICJIZWxwZXIgdmFyaWFibGUgZm9yIGB3aW5kb3ctc3RhdGUtcHV0Jy4iKQogCisoZGVmdmFy IHdpbmRvdy1zdGF0ZS1wdXQta2VwdC13aW5kb3dzIG5pbAorICAiSGVscGVyIHZhcmlhYmxl IGZvciBgd2luZG93LXN0YXRlLXB1dCcuIikKKworKGRlZnZhciB3aW5kb3ctc3RhdGUtcHV0 LXNlbGVjdGVkLXdpbmRvdyBuaWwKKyAgIkhlbHBlciB2YXJpYWJsZSBmb3IgYHdpbmRvdy1z dGF0ZS1wdXQnLiIpCisKIChkZWZ1biB3aW5kb3ctLXN0YXRlLXB1dC0xIChzdGF0ZSAmb3B0 aW9uYWwgd2luZG93IGlnbm9yZSB0b3RhbHMgcGl4ZWx3aXNlKQogICAiSGVscGVyIGZ1bmN0 aW9uIGZvciBgd2luZG93LXN0YXRlLXB1dCcuIgogICAobGV0ICgodHlwZSAoY2FyIHN0YXRl KSkpCkBAIC02Mjc4LDkgKzYyODQsMTAgQEAgd2luZG93LS1zdGF0ZS1wdXQtMgogCSAgKHNl dC13aW5kb3ctcGFyYW1ldGVyIHdpbmRvdyAoY2FyIHBhcmFtZXRlcikgKGNkciBwYXJhbWV0 ZXIpKSkpCiAgICAgICA7OyBQcm9jZXNzIGJ1ZmZlciByZWxhdGVkIHN0YXRlLgogICAgICAg KHdoZW4gc3RhdGUKLQkobGV0ICgoYnVmZmVyIChnZXQtYnVmZmVyIChjYXIgc3RhdGUpKSkK LQkgICAgICAoc3RhdGUgKGNkciBzdGF0ZSkpKQotCSAgKGlmIGJ1ZmZlcgorCShsZXQqICgo b2xkLWJ1ZmZlci1vci1uYW1lIChjYXIgc3RhdGUpKQorCSAgICAgICAoYnVmZmVyIChnZXQt YnVmZmVyIG9sZC1idWZmZXItb3ItbmFtZSkpCisJICAgICAgIChzdGF0ZSAoY2RyIHN0YXRl KSkpCisJICAoaWYgKGJ1ZmZlci1saXZlLXAgYnVmZmVyKQogCSAgICAgICh3aXRoLWN1cnJl bnQtYnVmZmVyIGJ1ZmZlcgogCQkoc2V0LXdpbmRvdy1idWZmZXIgd2luZG93IGJ1ZmZlcikK IAkJKHNldC13aW5kb3ctaHNjcm9sbCB3aW5kb3cgKGNkciAoYXNzcSAnaHNjcm9sbCBzdGF0 ZSkpKQpAQCAtNjM0OCw3ICs2MzU1LDE4IEBAIHdpbmRvdy0tc3RhdGUtcHV0LTIKIAkJICAo c2V0LXdpbmRvdy1wb2ludCB3aW5kb3cgKGNkciAoYXNzcSAncG9pbnQgc3RhdGUpKSkpCiAJ CTs7IFNlbGVjdCB3aW5kb3cgaWYgaXQncyB0aGUgc2VsZWN0ZWQgb25lLgogCQkod2hlbiAo Y2RyIChhc3NxICdzZWxlY3RlZCBzdGF0ZSkpCi0JCSAgKHNlbGVjdC13aW5kb3cgd2luZG93 KSkKKwkJICA7OyBUaGlzIHVzZWQgdG8gY2FsbCAnc2VsZWN0LXdpbmRvdycgd2hpY2gsIGhv d2V2ZXIsCisJCSAgOzsgY2FuIGJlIHBhcnRpYWxseSB1bmRvbmUgYmVjYXVzZSB0aGUgY3Vy cmVudCBidWZmZXIKKwkJICA7OyBtYXkgc3Vic2VxdWVudGx5IGNoYW5nZSB0d2ljZTogV2hl biBsZWF2aW5nIHRoZQorCQkgIDs7IHByZXNlbnQgJ3dpdGgtY3VycmVudC1idWZmZXInIGFu ZCB3aGVuIGxlYXZpbmcgdGhlCisJCSAgOzsgY29udGFpbmluZyAnd2l0aC10ZW1wLWJ1ZmZl cicgZm9ybSAoQnVnIzY5MDkzKS4KKwkJICA7OyAnd2luZG93LXN0YXRlLXB1dC1zZWxlY3Rl ZC13aW5kb3cnIHNob3VsZCBub3cgd29yaworCQkgIDs7IGFyb3VuZCB0aGF0IGJ1ZyBidXQg d2UgbGVhdmUgdGhpcyAnc2VsZWN0LXdpbmRvdycKKwkJICA7OyBpbiBzaW5jZSBzb21lIGNv ZGUgcnVuIGJlZm9yZSB0aGUgcGFydCB0aGF0IGZpeGVkCisJCSAgOzsgaXQgbWlnaHQgc3Rp bGwgcmVmZXIgdG8gdGhpcyB3aW5kb3cgYXMgdGhlIHNlbGVjdGVkCisJCSAgOzsgb25lLgor CQkgIChzZWxlY3Qtd2luZG93IHdpbmRvdykKKwkJICAoc2V0cSB3aW5kb3ctc3RhdGUtcHV0 LXNlbGVjdGVkLXdpbmRvdyB3aW5kb3cpKQogICAgICAgICAgICAgICAgIChzZXQtd2luZG93 LW5leHQtYnVmZmVycwogICAgICAgICAgICAgICAgICB3aW5kb3cKICAgICAgICAgICAgICAg ICAgKGRlbHEgbmlsIChtYXBjYXIgKGxhbWJkYSAoYnVmZmVyKQpAQCAtNjM3NSw3ICs2Mzkz LDIwIEBAIHdpbmRvdy0tc3RhdGUtcHV0LTIKIAkgICAgOzsgc2F2ZSB0aGUgd2luZG93IHdp dGggdGhlIGludGVudGlvbiBvZiBkZWxldGluZyBpdCBsYXRlcgogCSAgICA7OyBpZiBwb3Nz aWJsZS4KIAkgICAgKHN3aXRjaC10by1wcmV2LWJ1ZmZlciB3aW5kb3cpCi0JICAgIChwdXNo IHdpbmRvdyB3aW5kb3ctc3RhdGUtcHV0LXN0YWxlLXdpbmRvd3MpKSkpKSkpCisJICAgIChp ZiB3aW5kb3cta2VwdC13aW5kb3dzLWZ1bmN0aW9ucworCQkobGV0KiAoKHN0YXJ0IChjZHIg KGFzc3EgJ3N0YXJ0IHN0YXRlKSkpCisJCSAgICAgICA7OyBIYW5kbGUgYm90aCAtIG1hcmtl ciBwb3NpdGlvbnMgZnJvbSB3cml0YWJsZQorCQkgICAgICAgOzsgc3RhdGVzIGFuZCBtYXJr ZXJzIGZyb20gbm9uLXdyaXRhYmxlIHN0YXRlcy4KKwkJICAgICAgIChzdGFydC1wb3MgKGlm IChtYXJrZXJwIHN0YXJ0KQorCQkJCSAgICAgIChtYXJrZXItbGFzdC1wb3NpdGlvbiBzdGFy dCkKKwkJCQkgICAgc3RhcnQpKQorCQkgICAgICAgKHBvaW50IChjZHIgKGFzc3EgJ3BvaW50 IHN0YXRlKSkpCisJCSAgICAgICAocG9pbnQtcG9zIChpZiAobWFya2VycCBwb2ludCkKKwkJ CQkgICAgICAobWFya2VyLWxhc3QtcG9zaXRpb24gcG9pbnQpCisJCQkJICAgIHBvaW50KSkp CisJCSAgKHB1c2ggKGxpc3Qgd2luZG93IG9sZC1idWZmZXItb3ItbmFtZSBzdGFydC1wb3Mg cG9pbnQtcG9zKQorCQkJd2luZG93LXN0YXRlLXB1dC1rZXB0LXdpbmRvd3MpKQorCSAgICAg IChwdXNoIHdpbmRvdyB3aW5kb3ctc3RhdGUtcHV0LXN0YWxlLXdpbmRvd3MpKSkpKSkpKQog CiAoZGVmdW4gd2luZG93LXN0YXRlLXB1dCAoc3RhdGUgJm9wdGlvbmFsIHdpbmRvdyBpZ25v cmUpCiAgICJQdXQgd2luZG93IHN0YXRlIFNUQVRFIGludG8gV0lORE9XLgpAQCAtNjM4OCw4 ICs2NDE5LDIwIEBAIHdpbmRvdy1zdGF0ZS1wdXQKIE9wdGlvbmFsIGFyZ3VtZW50IElHTk9S RSBub24tbmlsIG1lYW5zIGlnbm9yZSBtaW5pbXVtIHdpbmRvdwogc2l6ZXMgYW5kIGZpeGVk IHNpemUgcmVzdHJpY3Rpb25zLiAgSUdOT1JFIGVxdWFsIGBzYWZlJyBtZWFucwogd2luZG93 cyBjYW4gZ2V0IGFzIHNtYWxsIGFzIGB3aW5kb3ctc2FmZS1taW4taGVpZ2h0JyBhbmQKLWB3 aW5kb3ctc2FmZS1taW4td2lkdGgnLiIKK2B3aW5kb3ctc2FmZS1taW4td2lkdGgnLgorCitJ ZiB0aGUgYWJub3JtYWwgaG9vayBgd2luZG93LWtlcHQtd2luZG93cy1mdW5jdGlvbnMnIGlz IG5vbi1uaWwsCituZXZlciBkZWxldGUgYW55IHdpbmRvd3Mgc2F2ZWQgYnkgU1RBVEUgd2hv c2UgYnVmZmVycyB3ZXJlCitkZWxldGVkIHNpbmNlIFNUQVRFIHdhcyBzYXZlZC4gIFJhdGhl ciBzaG93IHNvbWUgbGl2ZSBidWZmZXIgaW4KK3RoZW0gYW5kIGNhbGwgZWFjaCBmdW5jdGlv biBpbiBgd2luZG93LWtlcHQtd2luZG93cy1mdW5jdGlvbnMnCit3aXRoIGEgbGlzdCBvZiB0 d28gYXJndW1lbnRzOiB0aGUgZnJhbWUgd2hlcmUgU1RBVEUgd2FzIHB1dCBhbmQgYQorbGlz dCBvZiBlbnRyaWVzIGZvciBlYWNoIHN1Y2ggd2luZG93LiAgRWFjaCBlbnRyeSBjb250YWlu cyBmb3VyCitlbGVtZW50cyAtIHRoZSB3aW5kb3csIGl0cyBvbGQgYnVmZmVyIGFuZCB0aGUg bGFzdCBwb3NpdGlvbnMgb2YKK2B3aW5kb3ctc3RhcnQnIGFuZCBgd2luZG93LXBvaW50JyBm b3IgdGhlIGJ1ZmZlciBpbiB0aGF0IHdpbmRvdy4KK0Fsd2F5cyBjaGVjayB0aGUgd2luZG93 IGZvciBsaXZlbmVzcyBiZWNhdXNlIGFub3RoZXIgZnVuY3Rpb24gcnVuCitieSB0aGlzIGhv b2sgbWF5IGhhdmUgZGVsZXRlZCBpdC4iCiAgIChzZXRxIHdpbmRvdy1zdGF0ZS1wdXQtc3Rh bGUtd2luZG93cyBuaWwpCisgIChzZXRxIHdpbmRvdy1zdGF0ZS1wdXQta2VwdC13aW5kb3dz IG5pbCkKIAogICA7OyBXaGVuIFdJTkRPVyBpcyBpbnRlcm5hbCBvciBuaWwsIHJlZHVjZSBp dCB0byBhIGxpdmUgb25lLAogICA7OyB0aGVuIGNyZWF0ZSBhIG5ldyB3aW5kb3cgb24gdGhl IHNhbWUgZnJhbWUgdG8gcHV0IFNUQVRFIGludG8uCkBAIC02NDgyLDYgKzY1MjUsNyBAQCB3 aW5kb3ctc3RhdGUtcHV0CiAJKGVycm9yICJXaW5kb3cgJXMgdG9vIHNtYWxsIHRvIGFjY29t bW9kYXRlIHN0YXRlIiB3aW5kb3cpCiAgICAgICAoc2V0cSBzdGF0ZSAoY2RyIHN0YXRlKSkK ICAgICAgIChzZXRxIHdpbmRvdy1zdGF0ZS1wdXQtbGlzdCBuaWwpCisgICAgICAoc2V0cSB3 aW5kb3ctc3RhdGUtcHV0LXNlbGVjdGVkLXdpbmRvdyBuaWwpCiAgICAgICA7OyBXb3JrIG9u IHRoZSB3aW5kb3dzIG9mIGEgdGVtcG9yYXJ5IGJ1ZmZlciB0byBtYWtlIHN1cmUgdGhhdAog ICAgICAgOzsgc3BsaXR0aW5nIHByb2NlZWRzIHJlZ2FyZGxlc3Mgb2YgYW55IGJ1ZmZlciBs b2NhbCB2YWx1ZXMgb2YKICAgICAgIDs7IGB3aW5kb3ctc2l6ZS1maXhlZCcuICBSZWxlYXNl IHRoYXQgYnVmZmVyIGFmdGVyIHRoZSBidWZmZXJzIG9mCkBAIC02NDkwLDE0ICs2NTM0LDIx IEBAIHdpbmRvdy1zdGF0ZS1wdXQKIAkoc2V0LXdpbmRvdy1idWZmZXIgd2luZG93IChjdXJy ZW50LWJ1ZmZlcikpCiAJKHdpbmRvdy0tc3RhdGUtcHV0LTEgc3RhdGUgd2luZG93IG5pbCB0 b3RhbHMgcGl4ZWx3aXNlKQogCSh3aW5kb3ctLXN0YXRlLXB1dC0yIGlnbm9yZSBwaXhlbHdp c2UpKQorICAgICAgKHdoZW4gKHdpbmRvdy1saXZlLXAgd2luZG93LXN0YXRlLXB1dC1zZWxl Y3RlZC13aW5kb3cpCisJKHNlbGVjdC13aW5kb3cgd2luZG93LXN0YXRlLXB1dC1zZWxlY3Rl ZC13aW5kb3cpKQogICAgICAgKHdoaWxlIHdpbmRvdy1zdGF0ZS1wdXQtc3RhbGUtd2luZG93 cwogCShsZXQgKCh3aW5kb3cgKHBvcCB3aW5kb3ctc3RhdGUtcHV0LXN0YWxlLXdpbmRvd3Mp KSkKLSAgICAgICAgICA7OyBBdm9pZCB0aGF0ICd3aW5kb3ctZGVsZXRhYmxlLXAnIHRocm93 cyBhbiBlcnJvciBpZiB3aW5kb3cKKwkgIDs7IEF2b2lkIHRoYXQgJ3dpbmRvdy1kZWxldGFi bGUtcCcgdGhyb3dzIGFuIGVycm9yIGlmIHdpbmRvdwogICAgICAgICAgIDs7IHdhcyBhbHJl YWR5IGRlbGV0ZWQgd2hlbiBleGl0aW5nICd3aXRoLXRlbXAtYnVmZmVyJyBhYm92ZQogICAg ICAgICAgIDs7IChCdWcjNTQwMjgpLgogCSAgKHdoZW4gKGFuZCAod2luZG93LXZhbGlkLXAg d2luZG93KQogICAgICAgICAgICAgICAgICAgICAgKGVxICh3aW5kb3ctZGVsZXRhYmxlLXAg d2luZG93KSB0KSkKIAkgICAgKGRlbGV0ZS13aW5kb3cgd2luZG93KSkpKQorICAgICAgKHdo ZW4gd2luZG93LWtlcHQtd2luZG93cy1mdW5jdGlvbnMKKwkocnVuLWhvb2std2l0aC1hcmdz CisJICd3aW5kb3cta2VwdC13aW5kb3dzLWZ1bmN0aW9ucworCSBmcmFtZSB3aW5kb3ctc3Rh dGUtcHV0LWtlcHQtd2luZG93cykKKwkoc2V0cSB3aW5kb3ctc3RhdGUtcHV0LWtlcHQtd2lu ZG93cyBuaWwpKQogICAgICAgKHdpbmRvdy0tY2hlY2sgZnJhbWUpKSkpCiAKIChkZWZ1biB3 aW5kb3ctc3RhdGUtYnVmZmVycyAoc3RhdGUpCmRpZmYgLS1naXQgYS9zcmMvbWFya2VyLmMg Yi9zcmMvbWFya2VyLmMKaW5kZXggMzc3ZjZmYmU4ZGIuLjE0YjlmNjNmMGNkIDEwMDY0NAot LS0gYS9zcmMvbWFya2VyLmMKKysrIGIvc3JjL21hcmtlci5jCkBAIC00NTgsNiArNDU4LDE4 IEBAIERFRlVOICgibWFya2VyLXBvc2l0aW9uIiwgRm1hcmtlcl9wb3NpdGlvbiwgU21hcmtl cl9wb3NpdGlvbiwgMSwgMSwgMCwKICAgcmV0dXJuIFFuaWw7CiB9CiAKK0RFRlVOICgibWFy a2VyLWxhc3QtcG9zaXRpb24iLCBGbWFya2VyX2xhc3RfcG9zaXRpb24sIFNtYXJrZXJfbGFz dF9wb3NpdGlvbiwgMSwgMSwgMCwKKyAgICAgICBkb2M6IC8qIFJldHVybiBsYXN0IHBvc2l0 aW9uIG9mIE1BUktFUiBpbiBpdHMgYnVmZmVyLgorVGhpcyBpcyBsaWtlIGBtYXJrZXItcG9z aXRpb24nIHdpdGggb25lIGV4Y2VwdGlvbjogIElmIHRoZSBidWZmZXIgb2YKK01BUktFUiBp cyBkZWFkLCBpdCByZXR1cm5zIHRoZSBsYXN0IHBvc2l0aW9uIG9mIE1BUktFUiBpbiB0aGF0 IGJ1ZmZlcgorYmVmb3JlIGl0IHdhcyBraWxsZWQuICAqLykKKyAgKExpc3BfT2JqZWN0IG1h cmtlcikKK3sKKyAgQ0hFQ0tfTUFSS0VSIChtYXJrZXIpOworCisgIHJldHVybiBtYWtlX2Zp eG51bSAoWE1BUktFUiAobWFya2VyKS0+Y2hhcnBvcyk7Cit9CisKIC8qIENoYW5nZSBNIHNv IGl0IHBvaW50cyB0byBCIGF0IENIQVJQT1MgYW5kIEJZVEVQT1MuICAqLwogCiBzdGF0aWMg dm9pZApAQCAtODI1LDYgKzgzNyw3IEBAIHZlcmlmeV9ieXRlcG9zIChwdHJkaWZmX3QgY2hh cnBvcykKIHN5bXNfb2ZfbWFya2VyICh2b2lkKQogewogICBkZWZzdWJyICgmU21hcmtlcl9w b3NpdGlvbik7CisgIGRlZnN1YnIgKCZTbWFya2VyX2xhc3RfcG9zaXRpb24pOwogICBkZWZz dWJyICgmU21hcmtlcl9idWZmZXIpOwogICBkZWZzdWJyICgmU3NldF9tYXJrZXIpOwogICBk ZWZzdWJyICgmU2NvcHlfbWFya2VyKTsKZGlmZiAtLWdpdCBhL3NyYy93aW5kb3cuYyBiL3Ny Yy93aW5kb3cuYwppbmRleCAzYTU0ZjdjZTdiMS4uOGUwMDJkNzBkYjYgMTAwNjQ0Ci0tLSBh L3NyYy93aW5kb3cuYworKysgYi9zcmMvd2luZG93LmMKQEAgLTcwOTAsNiArNzA5MCwyNCBA QCBERUZVTiAoInNldC13aW5kb3ctY29uZmlndXJhdGlvbiIsIEZzZXRfd2luZG93X2NvbmZp Z3VyYXRpb24sCiB0aGUgbWluaS13aW5kb3cgb2YgdGhlIGZyYW1lIGRvZXNuJ3QgZ2V0IHNl dCB0byB0aGUgY29ycmVzcG9uZGluZyBlbGVtZW50CiBvZiBDT05GSUdVUkFUSU9OLgogCitO b3JtYWxseSwgdGhpcyBmdW5jdGlvbiB3aWxsIHRyeSB0byBkZWxldGUgYW55IGRlYWQgd2lu ZG93IGluCitDT05GSUdVUkFUSU9OIHdob3NlIGJ1ZmZlciBoYXMgYmVlbiBkZWxldGVkIHNp bmNlIENPTkZJR1VSQVRJT04gd2FzCittYWRlLiAgSG93ZXZlciwgaWYgdGhlIGFibm9ybWFs IGhvb2sgYHdpbmRvdy1rZXB0LXdpbmRvd3MtZnVuY3Rpb25zJyBpcworbm9uLW5pbCwgaXQg d2lsbCBwcmVzZXJ2ZSBzdWNoIGEgd2luZG93IGluIHRoZSByZXN0b3JlZCBsYXlvdXQgYW5k IHNob3cKK2Fub3RoZXIgYnVmZmVyIGluIGl0LgorCitBZnRlciByZXN0b3JpbmcgdGhlIGZy YW1lIGxheW91dCwgdGhpcyBmdW5jdGlvbiBydW5zIHRoZSBhYm5vcm1hbCBob29rCitgd2lu ZG93LWtlcHQtd2luZG93cy1mdW5jdGlvbnMnIHdpdGggdHdvIGFyZ3VtZW50cyAtIHRoZSBm cmFtZSB3aG9zZQorbGF5b3V0IGl0IGhhcyByZXN0b3JlZCBhbmQgYSBsaXN0IG9mIGVudHJp ZXMgZm9yIGVhY2ggd2luZG93IHdob3NlCitidWZmZXIgaGFzIGJlZW4gZm91bmQgZGVhZCB3 aGVuIGl0IHRyaWVkIHRvIHJlc3RvcmUgQ09ORklHVVJBVElPTjogRWFjaAorZW50cnkgaXMg YSBsaXN0IG9mIGZvdXIgZWxlbWVudHMgPHdpbmRvdywgYnVmZmVyLCBzdGFydCwgcG9pbnQ+ IHdoZXJlCitgd2luZG93JyBkZW5vdGVzIHRoZSB3aW5kb3cgd2hvc2UgYnVmZmVyIHdhcyBm b3VuZCBkZWFkLCBgYnVmZmVyJworZGVub3RlcyB0aGUgZGVhZCBidWZmZXIsIGFuZCBgc3Rh cnQnIGFuZCBgcG9pbnQnIGRlbm90ZSB0aGUgbGFzdCBrbm93bgorcG9zaXRpb25zIG9mIGB3 aW5kb3ctc3RhcnQnIGFuZCBgd2luZG93LXBvaW50JyBvZiB0aGUgYnVmZmVyIGluIHRoYXQK K3dpbmRvdy4gIEFueSBmdW5jdGlvbiBydW4gYnkgdGhpcyBob29rIHNob3VsZCBjaGVjayB0 aGUgd2luZG93IGZvcgorbGl2ZW5lc3MgYmVjYXVzZSBhbm90aGVyIGZ1bmN0aW9uIHJ1biBi eSB0aGlzIGhvb2sgbWF5IGhhdmUgZGVsZXRlZCBpdAoraW4gdGhlIG1lYW50aW1lLiIKKwog SWYgQ09ORklHVVJBVElPTiB3YXMgbWFkZSBmcm9tIGEgZnJhbWUgdGhhdCBpcyBub3cgZGVs ZXRlZCwKIG9ubHkgZnJhbWUtaW5kZXBlbmRlbnQgdmFsdWVzIGNhbiBiZSByZXN0b3JlZC4g IEluIHRoaXMgY2FzZSwKIHRoZSByZXR1cm4gdmFsdWUgaXMgbmlsLiAgT3RoZXJ3aXNlIHRo ZSB2YWx1ZSBpcyB0LiAgKi8pCkBAIC03MTAwLDYgKzcxMTgsNyBAQCBERUZVTiAoInNldC13 aW5kb3ctY29uZmlndXJhdGlvbiIsIEZzZXRfd2luZG93X2NvbmZpZ3VyYXRpb24sCiAgIHN0 cnVjdCBMaXNwX1ZlY3RvciAqc2F2ZWRfd2luZG93czsKICAgTGlzcF9PYmplY3QgbmV3X2N1 cnJlbnRfYnVmZmVyOwogICBMaXNwX09iamVjdCBmcmFtZTsKKyAgTGlzcF9PYmplY3Qga2Vw dF93aW5kb3dzID0gUW5pbDsKICAgTGlzcF9PYmplY3Qgb2xkX2ZyYW1lID0gc2VsZWN0ZWRf ZnJhbWU7CiAgIHN0cnVjdCBmcmFtZSAqZjsKICAgcHRyZGlmZl90IG9sZF9wb2ludCA9IC0x OwpAQCAtNzM0MCw2ICs3MzU5LDExIEBAIERFRlVOICgic2V0LXdpbmRvdy1jb25maWd1cmF0 aW9uIiwgRnNldF93aW5kb3dfY29uZmlndXJhdGlvbiwKIAkJICAgQlVGX1BUIChYQlVGRkVS ICh3LT5jb250ZW50cykpLAogCQkgICBCVUZfUFRfQllURSAoWEJVRkZFUiAody0+Y29udGVu dHMpKSk7CiAJICAgICAgdy0+c3RhcnRfYXRfbGluZV9iZWcgPSB0cnVlOworCSAgICAgIGlm ICghTklMUCAoVndpbmRvd19rZXB0X3dpbmRvd3NfZnVuY3Rpb25zKSkKKwkJa2VwdF93aW5k b3dzID0gRmNvbnMgKGxpc3Q0ICh3aW5kb3csIHAtPmJ1ZmZlciwKKwkJCQkJICAgICBGbWFy a2VyX2xhc3RfcG9zaXRpb24gKHAtPnN0YXJ0KSwKKwkJCQkJICAgICBGbWFya2VyX2xhc3Rf cG9zaXRpb24gKHAtPnBvaW50bSkpLAorCQkJCSAgICAgIGtlcHRfd2luZG93cyk7CiAJICAg IH0KIAkgIGVsc2UgaWYgKCFOSUxQICh3LT5zdGFydCkpCiAJICAgIC8qIExlYWYgd2luZG93 IGhhcyBubyBsaXZlIGJ1ZmZlciwgZ2V0IG9uZS4gICovCkBAIC03MzYwLDYgKzczODQsMTEg QEAgREVGVU4gKCJzZXQtd2luZG93LWNvbmZpZ3VyYXRpb24iLCBGc2V0X3dpbmRvd19jb25m aWd1cmF0aW9uLAogCQlkZWFkX3dpbmRvd3MgPSBGY29ucyAod2luZG93LCBkZWFkX3dpbmRv d3MpOwogCSAgICAgIC8qIE1ha2Ugc3VyZSB3aW5kb3cgaXMgbm8gbW9yZSBkZWRpY2F0ZWQu ICAqLwogCSAgICAgIHdzZXRfZGVkaWNhdGVkICh3LCBRbmlsKTsKKwkgICAgICBpZiAoIU5J TFAgKFZ3aW5kb3dfa2VwdF93aW5kb3dzX2Z1bmN0aW9ucykpCisJCWtlcHRfd2luZG93cyA9 IEZjb25zIChsaXN0NCAod2luZG93LCBwLT5idWZmZXIsCisJCQkJCSAgICAgRm1hcmtlcl9s YXN0X3Bvc2l0aW9uIChwLT5zdGFydCksCisJCQkJCSAgICAgRm1hcmtlcl9sYXN0X3Bvc2l0 aW9uIChwLT5wb2ludG0pKSwKKwkJCQkgICAgICBrZXB0X3dpbmRvd3MpOwogCSAgICB9CiAJ fQogCkBAIC03NDExLDEyICs3NDQwLDEzIEBAIERFRlVOICgic2V0LXdpbmRvdy1jb25maWd1 cmF0aW9uIiwgRnNldF93aW5kb3dfY29uZmlndXJhdGlvbiwKICAgICAgIHVuYmxvY2tfaW5w dXQgKCk7CiAKICAgICAgIC8qIFNjYW4gZGVhZCBidWZmZXIgd2luZG93cy4gICovCi0gICAg ICBmb3IgKDsgQ09OU1AgKGRlYWRfd2luZG93cyk7IGRlYWRfd2luZG93cyA9IFhDRFIgKGRl YWRfd2luZG93cykpCi0JewotCSAgd2luZG93ID0gWENBUiAoZGVhZF93aW5kb3dzKTsKLQkg IGlmIChXSU5ET1dfTElWRV9QICh3aW5kb3cpICYmICFFUSAod2luZG93LCBGUkFNRV9ST09U X1dJTkRPVyAoZikpKQotCSAgICBkZWxldGVfZGVsZXRhYmxlX3dpbmRvdyAod2luZG93KTsK LQl9CisgICAgICBpZiAoIU5JTFAgKFZ3aW5kb3dfa2VwdF93aW5kb3dzX2Z1bmN0aW9ucykp CisJZm9yICg7IENPTlNQIChkZWFkX3dpbmRvd3MpOyBkZWFkX3dpbmRvd3MgPSBYQ0RSIChk ZWFkX3dpbmRvd3MpKQorCSAgeworCSAgICB3aW5kb3cgPSBYQ0FSIChkZWFkX3dpbmRvd3Mp OworCSAgICBpZiAoV0lORE9XX0xJVkVfUCAod2luZG93KSAmJiAhRVEgKHdpbmRvdywgRlJB TUVfUk9PVF9XSU5ET1cgKGYpKSkKKwkgICAgICBkZWxldGVfZGVsZXRhYmxlX3dpbmRvdyAo d2luZG93KTsKKwkgIH0KIAogICAgICAgLyogUmVjb3JkIHRoZSBzZWxlY3RlZCB3aW5kb3cn cyBidWZmZXIgaGVyZS4gIFRoZSB3aW5kb3cgc2hvdWxkCiAJIGFscmVhZHkgYmUgdGhlIHNl bGVjdGVkIG9uZSBmcm9tIHRoZSBjYWxsIGFib3ZlLiAgKi8KQEAgLTc0NjMsNiArNzQ5Mywx MSBAQCBERUZVTiAoInNldC13aW5kb3ctY29uZmlndXJhdGlvbiIsIEZzZXRfd2luZG93X2Nv bmZpZ3VyYXRpb24sCiAgIG1pbmlidWZfc2VsZWN0ZWRfd2luZG93ID0gZGF0YS0+bWluaWJ1 Zl9zZWxlY3RlZF93aW5kb3c7CiAKICAgU0FGRV9GUkVFICgpOworCisgIGlmICghTklMUCAo VnJ1bl9ob29rcykgJiYgIU5JTFAgKFZ3aW5kb3dfa2VwdF93aW5kb3dzX2Z1bmN0aW9ucykp CisgICAgcnVuX2hvb2tfd2l0aF9hcmdzXzIgKFF3aW5kb3dfa2VwdF93aW5kb3dzX2Z1bmN0 aW9ucywgZnJhbWUsCisJCQkgIGtlcHRfd2luZG93cyk7CisKICAgcmV0dXJuIEZSQU1FX0xJ VkVfUCAoZikgPyBRdCA6IFFuaWw7CiB9CiAKQEAgLTg0NjAsNiArODQ5NSw4IEBAIHN5bXNf b2Zfd2luZG93ICh2b2lkKQogICBERUZTWU0gKFFoZWFkZXJfbGluZV9mb3JtYXQsICJoZWFk ZXItbGluZS1mb3JtYXQiKTsKICAgREVGU1lNIChRdGFiX2xpbmVfZm9ybWF0LCAidGFiLWxp bmUtZm9ybWF0Iik7CiAgIERFRlNZTSAoUW5vX290aGVyX3dpbmRvdywgIm5vLW90aGVyLXdp bmRvdyIpOworICBERUZTWU0gKFF3aW5kb3dfa2VwdF93aW5kb3dzX2Z1bmN0aW9ucywKKwkg ICJ3aW5kb3cta2VwdC13aW5kb3dzLWZ1bmN0aW9ucyIpOwogCiAgIERFRlZBUl9MSVNQICgi dGVtcC1idWZmZXItc2hvdy1mdW5jdGlvbiIsIFZ0ZW1wX2J1ZmZlcl9zaG93X2Z1bmN0aW9u LAogCSAgICAgICBkb2M6IC8qIE5vbi1uaWwgbWVhbnMgY2FsbCBhcyBmdW5jdGlvbiB0byBk aXNwbGF5IGEgaGVscCBidWZmZXIuCkBAIC04NjE3LDYgKzg2NTQsMjggQEAgc3ltc19vZl93 aW5kb3cgKHZvaWQpCiBjYWxsIGlzIHBlcmZvcm1lZCB3aXRoIHRoZSBmcmFtZSB0ZW1wb3Jh cmlseSBzZWxlY3RlZC4gICovKTsKICAgVndpbmRvd19jb25maWd1cmF0aW9uX2NoYW5nZV9o b29rID0gUW5pbDsKIAorICBERUZWQVJfTElTUCAoIndpbmRvdy1rZXB0LXdpbmRvd3MtZnVu Y3Rpb25zIiwKKwkgICAgICAgVndpbmRvd19rZXB0X3dpbmRvd3NfZnVuY3Rpb25zLAorCSAg ICAgICBkb2M6IC8qIEZ1bmN0aW9ucyBydW4gYWZ0ZXIgcmVzdG9yaW5nIGEgd2luZG93IGNv bmZpZ3VyYXRpb24gb3Igc3RhdGUuCitUaGVzZSBmdW5jdGlvbnMgYXJlIGNhbGxlZCBieSBg c2V0LXdpbmRvdy1jb25maWd1cmF0aW9uJyBhbmQKK2B3aW5kb3ctc3RhdGUtcHV0Jy4gIFdo ZW4gdGhlIHZhbHVlIG9mIHRoaXMgdmFyaWFibGUgaXMgbm9uLW5pbCwgdGhlc2UKK2Z1bmN0 aW9ucyByZXN0b3JlIGFueSB3aW5kb3cgd2hvc2UgYnVmZmVyIGhhcyBiZWVuIGRlbGV0ZWQg c2luY2UgdGhlCitjb3JyZXNwb25kaW5nIGNvbmZpZ3VyYXRpb24gb3Igc3RhdGUgd2FzIHNh dmVkLiAgUmF0aGVyIHRoYW4gZGVsZXRpbmcKK3N1Y2ggYSB3aW5kb3csIGBzZXQtd2luZG93 LWNvbmZpZ3VyYXRpb24nIGFuZCBgd2luZG93LXN0YXRlLXB1dCcgc2hvdworc29tZSBsaXZl IGJ1ZmZlciBpbiBpdC4KKworVGhlIHZhbHVlIHNob3VsZCBiZSBhIGxpc3Qgb2YgZnVuY3Rp b25zIHRoYXQgdGFrZSB0d28gYXJndW1lbnRzLiAgVGhlCitmaXJzdCBhcmd1bWVudCBzcGVj aWZpZXMgdGhlIGZyYW1lIHdob3NlIGNvbmZpZ3VyYXRpb24gaGFzIGJlZW4KK3Jlc3RvcmVk LiAgVGhlIHNlY29uZCBhcmd1bWVudCwgaWYgbm9uLW5pbCwgc3BlY2lmaWVzIGEgbGlzdCBv ZiBlbnRyaWVzCitmb3IgZWFjaCB3aW5kb3cgd2hvc2UgYnVmZmVyIGhhcyBiZWVuIGZvdW5k IGRlYWQgYXQgdGhlIHRpbWUKKydzZXQtd2luZG93LWNvbmZpZ3VyYXRpb24nIG9yIGB3aW5k b3ctc3RhdGUtcHV0JyB0cmllZCB0byByZXN0b3JlIGl0IGluCit0aGF0IHdpbmRvdy4gIEVh Y2ggZW50cnkgaXMgYSBsaXN0IG9mIGZvdXIgdmFsdWVzIC0gdGhlIHdpbmRvdyB3aG9zZQor YnVmZmVyIHdhcyBmb3VuZCBkZWFkLCB0aGUgZGVhZCBidWZmZXIsIGFuZCB0aGUgcG9zaXRp b25zIG9mIHN0YXJ0IGFuZAorcG9pbnQgb2YgdGhlIGJ1ZmZlciBpbiB0aGF0IHdpbmRvdy4g IE5vdGUgdGhhdCB0aGUgd2luZG93IG1heSBiZSBhbHJlYWR5CitkZWFkIHNpbmNlIGFub3Ro ZXIgZnVuY3Rpb24gb24gdGhpcyBsaXN0IG1heSBoYXZlIGRlbGV0ZWQgaXQgaW4gdGhlCitt ZWFudGltZS4gICovKTsKKyAgVndpbmRvd19rZXB0X3dpbmRvd3NfZnVuY3Rpb25zID0gUW5p bDsKKwogICBERUZWQVJfTElTUCAoInJlY2VudGVyLXJlZGlzcGxheSIsIFZyZWNlbnRlcl9y ZWRpc3BsYXksCiAJICAgICAgIGRvYzogLyogTm9uLW5pbCBtZWFucyBgcmVjZW50ZXInIHJl ZHJhd3MgZW50aXJlIGZyYW1lLgogSWYgdGhpcyBvcHRpb24gaXMgbm9uLW5pbCwgdGhlbiB0 aGUgYHJlY2VudGVyJyBjb21tYW5kIHdpdGggYSBuaWwK --------------aR0enOl28RnEkWC18jG0TQDX-- From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 25 14:12:12 2024 Received: (at 69093) by debbugs.gnu.org; 25 Feb 2024 19:12:12 +0000 Received: from localhost ([127.0.0.1]:40409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reJv1-0002sn-Sz for submit@debbugs.gnu.org; Sun, 25 Feb 2024 14:12:12 -0500 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:54703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reJuz-0002sN-Ly for 69093@debbugs.gnu.org; Sun, 25 Feb 2024 14:12:10 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 269E2E0009; Sun, 25 Feb 2024 19:11:28 +0000 (UTC) From: Juri Linkov To: martin rudalics Subject: Re: bug#69093: window-state-put doesn't update current buffer In-Reply-To: (martin rudalics's message of "Sun, 25 Feb 2024 10:17:24 +0100") Organization: LINKOV.NET References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> <86il2jhb7o.fsf@mail.linkov.net> <843eff0e-134a-4ade-8c9f-c49166f85241@gmx.at> <86y1bdviba.fsf@mail.linkov.net> <86sf1ks9oj.fsf@mail.linkov.net> <5307fa5c-725a-4d73-ae2f-07668e4bd5b3@gmx.at> <86o7c5epiv.fsf@mail.linkov.net> Date: Sun, 25 Feb 2024 20:19:35 +0200 Message-ID: <86a5noxswg.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > The attached patch (including the former changes) should fix it. I left > the old 'select-window' call in just for the case that its effect is > used elsewhere in a function called by 'window--state-put-2' later. Thank you very much. I confirm that everything works nicely. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 26 03:48:05 2024 Received: (at 69093) by debbugs.gnu.org; 26 Feb 2024 08:48:05 +0000 Received: from localhost ([127.0.0.1]:45943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reWeb-000523-B7 for submit@debbugs.gnu.org; Mon, 26 Feb 2024 03:48:05 -0500 Received: from mout.gmx.net ([212.227.15.18]:43959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reWeY-00051N-Nv for 69093@debbugs.gnu.org; Mon, 26 Feb 2024 03:48:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1708937251; x=1709542051; i=rudalics@gmx.at; bh=Ho8vpH3MZD8nFcWXKICjt6lrlsmn5ac0hyzetdNHgn8=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=iODDgc9QJP5uG6Ovh6rvr7smoxYueqHNpfspQa2QfhjspGRPHC73HtsAhfywlJeO n2/1G0KZTyfe30c1Z4EWfP+9Ja0qrlgKcwc9R7KcPz8NHOpgOEY8zHFDrr74yz+60 o6qW/PSCfson/owA14fXp36BZzFOgHaAsNq4FeCwmUJFFrtZPrhGSyjjMn3sK6WRJ AH2gNhQ9eM7JlTFhIk6SD6nbhzElAqCHoxICBm5v29rQobVcF8G6yTiCu4L/m9/9H C7gw0qopptB3oG9e3S+9LlQsNbcbQRmPRmvP6nmYXQPHFeAPjJqfkLJv+nikKOcy/ PxV8bZ4gwjnMA0h71A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.152]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MG9gE-1rff9G0kZA-00Gajo; Mon, 26 Feb 2024 09:42:30 +0100 Message-ID: <174f5ab5-0c19-420f-a976-ab3e6a08cc54@gmx.at> Date: Mon, 26 Feb 2024 09:42:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69093: window-state-put doesn't update current buffer To: Juri Linkov References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> <86il2jhb7o.fsf@mail.linkov.net> <843eff0e-134a-4ade-8c9f-c49166f85241@gmx.at> <86y1bdviba.fsf@mail.linkov.net> <86sf1ks9oj.fsf@mail.linkov.net> <5307fa5c-725a-4d73-ae2f-07668e4bd5b3@gmx.at> <86o7c5epiv.fsf@mail.linkov.net> <86a5noxswg.fsf@mail.linkov.net> Content-Language: en-US From: martin rudalics In-Reply-To: <86a5noxswg.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:KfzUTx0cS+TcfiJqCaXA+nhxsFQIptKWx+50M5aW5iN3oTUio9G x/oKTF2Ar1tFAYWaY6QYezO3gAFHjxxSUv+Twgk2+Yna5/SnHaKA3BkZyLxI/4KjUidl+Rg omsPordsBl2ry9gpDZwv7eXQAhET8TrKtAyU3zdTxVc8g/UdJ1GIhICd1e2kZH5+pVnhDo5 xm0Y6k9gcUwT8/Aaxd1Zg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:302Pe2ZCSBU=;ZIehDZ8gK1APDfnEF9fBcx+7uu0 W2k6N1BW/eFtYBMSvJNaAHbcl1Pnr8m1x/9qE+Or6QkyAh81YaqXImag4CaKJNBvsLQL0wuM4 q2w6Ox0XQKr54LIVaJoBWAjGUSNQiHiKYNFGT4D+jc2WL69rWOUjaAvBDptsTqzZ8KZzaGYtN 3hLhqPR7EQjX5WCbZNy1m/lkwe6tMGsIebsWY1eQMxbdV58aJRcya28l+4aZvMx6GB4XSVLLn IcteXfgOQIqN84Pzz5PpdAiIugBIwph+UbED4L8/tJjzluImyz+63/qRlwiq7CVHvw2gtSLVz XEWiWueIQML89+bFhoZVJ5+lv17/86KVJxgEo8UYpjMbCH2TGjVAnrArIgHnnoNPfTKo4wS6U MaKq/SideaIw/Mav1ZCPElE5oe2ehdbLSKBzChb3/kFgbbcgbT90MeknKHr4B6qvUFWIbN571 LPDhODsQFmChhfyjCOXXDza320dtGvcVBCQ/aZn5nAxNhZ5pI101cmr0gp8Ss1xc8vnkcmNWy MCD3hOkjIp1cHbXgCSIR9e74gHyBY494KuiifdFsc3RHSlC4laD0WijLDxR60bNFwyS/Dg50S xp4cgbx6n98uOP+EKqRlKG0A6le+Eye+bkRWAnx7zJjIuCSeKUgZnKwxAabBCxLSroIObv3j2 ps4uvxVlUED4KbBzf4g/10JD8govaMW54+QpfXgPsBNtcO4dTa7kyLJ4HgSZtcSgYrxeqeqL3 0dJHZ5HUioV/dZefP/Rfb1vaJRwt34cIF2y+2jxhsPjRsM+r7cCjUI88tpLcJNKxTQABIYN8B p6HajuM0XsZwJacv9lcxaLA0IPd4ELiwoxyr1OqvXBe3M= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Thank you very much. I confirm that everything works nicely. If no problems come up within a week, I'll try to install it. Thanks for testing, martin From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 04 04:41:03 2024 Received: (at 69093) by debbugs.gnu.org; 4 Mar 2024 09:41:03 +0000 Received: from localhost ([127.0.0.1]:41973 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rh4og-00051S-RP for submit@debbugs.gnu.org; Mon, 04 Mar 2024 04:41:03 -0500 Received: from mout.gmx.net ([212.227.17.22]:44079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rh4oe-00050V-Dt for 69093@debbugs.gnu.org; Mon, 04 Mar 2024 04:41:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1709545224; x=1710150024; i=rudalics@gmx.at; bh=CyLSzZ60evA4Z585ZAS+VZ9FCDPzQzU1N/ySvAcqdPs=; h=X-UI-Sender-Class:Date:Subject:From:To:Cc:References: In-Reply-To; b=fivSmszT32ZSg3dvVO3zVTFkPZPC6QfPrzz62S0ts4GDl7VikKiv9oPYlhpM+BN6 qYQF6/GQ5XZ4Y103UyuW67SwPBI1v63rTbax1YZxGQ4M0MKMp7JEtFYXnklWWHzy+ VXndTz38kZbuBPTtReGsLWxqhrE4sUhzBkOgWzl4thzGs4QMiPEKBUp4T/6fpM6KW 0Qrpf/+nqoQEUNmvG5u/jHFqV+/EgVcS9nEHCbKKgeIE0Q7OKiOW6APYCg3dxtn4Y IiyK3ArJTF/BfbdYl3VxYgSLQb6DwHXkl1RUA/dPxiDFtO8Wb5ZyLqzfUfC+u90B7 pDKYUaQx6G5fpk3kxA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.212]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MxDkm-1qwnqa0BqK-00xXsP; Mon, 04 Mar 2024 10:40:24 +0100 Message-ID: Date: Mon, 4 Mar 2024 10:40:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#69093: window-state-put doesn't update current buffer From: martin rudalics To: Juri Linkov References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> <86il2jhb7o.fsf@mail.linkov.net> <843eff0e-134a-4ade-8c9f-c49166f85241@gmx.at> <86y1bdviba.fsf@mail.linkov.net> <86sf1ks9oj.fsf@mail.linkov.net> <5307fa5c-725a-4d73-ae2f-07668e4bd5b3@gmx.at> <86o7c5epiv.fsf@mail.linkov.net> <86a5noxswg.fsf@mail.linkov.net> <174f5ab5-0c19-420f-a976-ab3e6a08cc54@gmx.at> Content-Language: en-US In-Reply-To: <174f5ab5-0c19-420f-a976-ab3e6a08cc54@gmx.at> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:Xn+wMn6l/s5YTTqC4qyWM2Wj4YmOi2toSyVzQu8JwYwZH+P6js1 noa2NXkORQPuVHwI1SsLoTn3XpsZK0a+QMMBFCRSKJDSZd/HJe2cyCRdAMW6e2+t7X35z0+ DPBrJv1l3YmbrKDAFHZPzeUZNVIDq13HrZ+l6iynx7Ekmd5M79ZbPmaszR5UdKvyGh9tjmx Szx406T3kWIWX5HACRY2w== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:sorS3x3vQGE=;CWot2WpR0a6KvLABpsq+f6VIF3D Qz3QN0j60+XHg6lMXJYf43gzDc4oUzV/LtIWzwjQjXaA5X3vuyv1FzWrk958eXJoGnVYLNKLo kCCKxFSVmzyB6QBGwyG7dbonMP9BnFApF1Upz0IWRRUc5d02+U5lrqMNX1TKJiR7SZzeHrHzN iHHblvTzhqDkrgWeg+X4EAMSzxJT2iXCLNg5p0MphpFvXDqAwJ4cT/RTUgE7K5QWFKXdgvX5P V2EevfLcap2Rc3sAVlBJVHiItHQAsCtpO2/77np1+lDPt2m3UOoOqFlX1NxhZes2Nmq14vDU6 rdwzXlyU+3HhuzRjifHmj6LVPJzbpR7DYY/vNAroDr/oPJ8HVoqPpuXomqih3bgWpWDeKZcA9 vimht6h+w5izn8JFPILGDaWJpB0lkV4wdaYOHw0aG2sC3XcEpZY7cS5OfkfXBvuEPkdXcIXWT LDbDpFyI9VbaZmwRD0w55G6KJk5i7lI+IPhO1L/d8stogMBLybYgjyQF/+B3PQDaycnTT89E0 QggbN6dmg3EuFp1hPuiPgnvWESAmw/xWPk8YvHxOSO8CUOcyqkIZsULCIpqdnYMGA8RGo4K6a 4EkgNPsKxys6YumFr59R6b5al9AlfXMbmPb4xizqqxf6mYC3ekjX398wUBYCg/iFo+jSZImer QaaZN1oImDFvYtNG+9e1VjmgBQG8T6Yl0O4X1/+FZZldsa+DRz/xDZfIgzD5R5WmLVdXE+7Bv 7H4dZ0SJ4904YKAr5KYrRPuJSoXCIhJ3HZvqO6gtOZqfG54WdKb/HVsoIcOfDcZqo534o2SQy o8215rSqrmN+Q4tpEY7cePyHucP/PZo5NMlbFs+dMAMbY= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) All changes should be on master now. Thanks for the reviews, martin From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 05 12:16:55 2024 Received: (at 69093) by debbugs.gnu.org; 5 Mar 2024 17:16:55 +0000 Received: from localhost ([127.0.0.1]:48882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhYPO-0004hz-PS for submit@debbugs.gnu.org; Tue, 05 Mar 2024 12:16:54 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:57325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhYPM-0004hf-Cu; Tue, 05 Mar 2024 12:16:53 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 8A92EC0002; Tue, 5 Mar 2024 17:16:14 +0000 (UTC) From: Juri Linkov To: martin rudalics Subject: Re: bug#69093: window-state-put doesn't update current buffer In-Reply-To: (martin rudalics's message of "Mon, 4 Mar 2024 10:40:23 +0100") Organization: LINKOV.NET References: <86il2s6cva.fsf@mail.linkov.net> <2387160a-717f-4164-a0ad-cd831cabd60f@gmx.at> <86cysy1c7e.fsf@mail.linkov.net> <9bc224fd-265b-42a6-9315-9e1caa9e7172@gmx.at> <86msryw7gy.fsf@mail.linkov.net> <86il2jhb7o.fsf@mail.linkov.net> <843eff0e-134a-4ade-8c9f-c49166f85241@gmx.at> <86y1bdviba.fsf@mail.linkov.net> <86sf1ks9oj.fsf@mail.linkov.net> <5307fa5c-725a-4d73-ae2f-07668e4bd5b3@gmx.at> <86o7c5epiv.fsf@mail.linkov.net> <86a5noxswg.fsf@mail.linkov.net> <174f5ab5-0c19-420f-a976-ab3e6a08cc54@gmx.at> Date: Tue, 05 Mar 2024 19:14:58 +0200 Message-ID: <86sf14r46l.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 69093 Cc: 69093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 69093 30.0.50 thanks > All changes should be on master now. Thanks. I confirm 'window-state-put' working, so I was able to add 'tab-bar-tab-post-select-functions'. From unknown Sat Jun 21 03:26:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 03 Apr 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator