GNU bug report logs - #69088
[PATCH] Eagerly indent first field in tables in lua-ts-mode

Previous Next

Package: emacs;

Reported by: john muhl <jm <at> pub.pink>

Date: Tue, 13 Feb 2024 02:29:02 UTC

Severity: normal

Tags: patch

Merged with 69089

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69089: closed ([PATCH] Eagerly indent first field in tables
 in lua-ts-mode)
Date: Sat, 17 Feb 2024 08:59:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 17 Feb 2024 10:58:12 +0200
with message-id <865xynv55n.fsf <at> gnu.org>
and subject line Re: bug#69088: [PATCH] Eagerly indent first field in tables in lua-ts-mode
has caused the debbugs.gnu.org bug report #69088,
regarding [PATCH] Eagerly indent first field in tables in lua-ts-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69088: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69088
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Eagerly indent first field in tables in lua-ts-mode
Date: Mon, 12 Feb 2024 19:23:03 -0600
Tags: patch

lua-ts-mode supports aligning sibling fields to the first field
so that you can have code like:

  local t = { a = 1,
              b = 2, }

However if you prefer to put the first field on a newline like:

  local t = {
      a = 1,
      b = 2,
  }

the indentation doesn’t happen until you press RET after the
first comma. So you initially have something like (where | is
point):

  local t = {
  |
  }

This fixes that so the initial indentation is correct from the
beginning:

  local t = {
      |
  }


[Message part 3 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>
Cc: dmitry <at> gutov.dev, 69088-done <at> debbugs.gnu.org
Subject: Re: bug#69088: [PATCH] Eagerly indent first field in tables in
 lua-ts-mode
Date: Sat, 17 Feb 2024 10:58:12 +0200
> Cc: 69088 <at> debbugs.gnu.org
> Date: Mon, 12 Feb 2024 21:42:01 -0600
> From:  john muhl via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Dmitry Gutov <dmitry <at> gutov.dev> writes:
> 
> > On 13/02/2024 04:49, john muhl via Bug reports for GNU Emacs, the
> > Swiss army knife of text editors wrote:
> >> +     ((and (lambda (node &rest _) (null node))
> >> +           (parent-is "table_constructor"))
> >
> > That's probably the same as (match null "table_constructor")
> 
> Yes it is. Thanks for the pointer.

Thanks, installed on master, and closing the bug.


This bug report was last modified 1 year and 187 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.