From unknown Sat Sep 20 00:51:32 2025 X-Loop: help-debbugs@gnu.org Subject: bug#69087: [PATCH] ; Resolve a FIXME in rst.el Resent-From: =?UTF-8?Q?J=C3=B6rg?= Bornemann Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2024 21:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 69087 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 69087@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.170777310330813 (code B ref -1); Mon, 12 Feb 2024 21:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 12 Feb 2024 21:25:03 +0000 Received: from localhost ([127.0.0.1]:60481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZdnQ-00080S-Rm for submit@debbugs.gnu.org; Mon, 12 Feb 2024 16:25:03 -0500 Received: from lists.gnu.org ([2001:470:142::17]:49720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZdZq-0006ud-JW for submit@debbugs.gnu.org; Mon, 12 Feb 2024 16:10:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZdZS-0003F5-NR for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 16:10:34 -0500 Received: from ms-10.1blu.de ([178.254.4.101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZdZP-0006l2-QX for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 16:10:34 -0500 Received: from [79.242.79.138] (helo=barf.jbornemann.de) by ms-10.1blu.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rZdZK-007UAp-Rp for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 22:10:26 +0100 From: =?UTF-8?Q?J=C3=B6rg?= Bornemann Date: Mon, 12 Feb 2024 22:10:26 +0100 Message-ID: <87frxxmlrx.fsf@jbornemann.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Con-Id: 36794 X-Con-U: 0-foss X-Originating-IP: 79.242.79.138 Received-SPF: pass client-ip=178.254.4.101; envelope-from=foss@jbornemann.de; helo=ms-10.1blu.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Mailman-Approved-At: Mon, 12 Feb 2024 16:24:59 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Tags: patch This patch resolves a trivial FIXME in rst.el. In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-01-18 built on barf Repository revision: ef01b634d219bcceda17dcd61024c7a12173b88c Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12201009 System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure --prefix /usr/local --with-x-toolkit=gtk3 --with-xwidgets --with-imagemagick --with-json --with-tree-sitter --with-small-ja-dic --with-native-compilation' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Resolve-a-FIXME-in-rst.el.patch >From d4cc0fe4ddfe016e76516370d742a67c29b66690 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Bornemann?= Date: Mon, 12 Feb 2024 21:56:42 +0100 Subject: [PATCH] ; Resolve a FIXME in rst.el * lisp/textmodes/rst.el (rst-define-key): Use :documentation for the dynamically created docstrings of deprecated bindings. --- lisp/textmodes/rst.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/textmodes/rst.el b/lisp/textmodes/rst.el index 2cd78943883..5fbff4ba888 100644 --- a/lisp/textmodes/rst.el +++ b/lisp/textmodes/rst.el @@ -1147,14 +1147,14 @@ rst-define-key (unless (fboundp forwarder-function) (defalias forwarder-function (lambda () + (:documentation + (format "Deprecated binding for %s, use \\[%s] instead." + def def)) (interactive) (call-interactively def) (message "[Deprecated use of key %s; use key %s instead]" (key-description (this-command-keys)) - (key-description key))) - ;; FIXME: In Emacs-25 we could use (:documentation ...) instead. - (format "Deprecated binding for %s, use \\[%s] instead." - def def))) + (key-description key))))) (dolist (dep-key deprecated) (define-key keymap dep-key forwarder-function))))) -- 2.39.2 --=-=-=-- From unknown Sat Sep 20 00:51:32 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?J=C3=B6rg?= Bornemann Subject: bug#69087: closed (Re: bug#69087: [PATCH] ; Resolve a FIXME in rst.el) Message-ID: References: <867cj8r2fe.fsf@gnu.org> <87frxxmlrx.fsf@jbornemann.de> X-Gnu-PR-Message: they-closed 69087 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 69087@debbugs.gnu.org Date: Tue, 13 Feb 2024 12:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1707826382-3301-1" This is a multi-part message in MIME format... ------------=_1707826382-3301-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #69087: [PATCH] ; Resolve a FIXME in rst.el which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 69087@debbugs.gnu.org. --=20 69087: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D69087 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1707826382-3301-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 69087-done) by debbugs.gnu.org; 13 Feb 2024 12:12:11 +0000 Received: from localhost ([127.0.0.1]:42491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZrdy-0000pq-L8 for submit@debbugs.gnu.org; Tue, 13 Feb 2024 07:12:10 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZrdt-0000p7-0N for 69087-done@debbugs.gnu.org; Tue, 13 Feb 2024 07:12:08 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZrbN-0002xM-DK; Tue, 13 Feb 2024 07:09:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=mzEnq0WI1PSSqH40t7jnLyZqGVXFelmeVIWotdo+t8g=; b=HuOwY1tYjy5k9cvW18y0 OcARh2UG39IxLTFnaazIvdhDVQ5hmO5Jkj9G2ldG6eedsgyK+ckySUwHNePuR2Tt9X02TDcPlGnIp NUgxPaGXtI4rN5VbHj4Nf++VcAP8Bk2miJjTi1UK9BRPerSB7TwTigILuiT3P3og71x4traMKgCjd Ns0w0wWiO78k2gqw10VHP/3UScMVntUnfaN3vpncrHx6j5CqDnJoB8uBLxiOLpcq15HjZJ60dSs7G XomGc2OwHgqIa7we6uXhcm9kwXLAfO7qNDikRXyaH+B46bcb3RVF8yjVOi4n/uX3fiYzWhl5wIA7M RzZGSb7Uf9MRfQ==; Date: Tue, 13 Feb 2024 14:09:25 +0200 Message-Id: <867cj8r2fe.fsf@gnu.org> From: Eli Zaretskii To: =?iso-8859-1?Q?J=F6rg?= Bornemann In-Reply-To: <87frxxmlrx.fsf@jbornemann.de> (message from =?iso-8859-1?Q?J?= =?iso-8859-1?Q?=F6rg?= Bornemann on Mon, 12 Feb 2024 22:10:26 +0100) Subject: Re: bug#69087: [PATCH] ; Resolve a FIXME in rst.el References: <87frxxmlrx.fsf@jbornemann.de> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 69087-done Cc: 69087-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jörg Bornemann > Date: Mon, 12 Feb 2024 22:10:26 +0100 > > This patch resolves a trivial FIXME in rst.el. Thanks, installed on master, and closing the bug. ------------=_1707826382-3301-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Feb 2024 21:25:03 +0000 Received: from localhost ([127.0.0.1]:60481 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZdnQ-00080S-Rm for submit@debbugs.gnu.org; Mon, 12 Feb 2024 16:25:03 -0500 Received: from lists.gnu.org ([2001:470:142::17]:49720) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZdZq-0006ud-JW for submit@debbugs.gnu.org; Mon, 12 Feb 2024 16:10:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZdZS-0003F5-NR for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 16:10:34 -0500 Received: from ms-10.1blu.de ([178.254.4.101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZdZP-0006l2-QX for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 16:10:34 -0500 Received: from [79.242.79.138] (helo=barf.jbornemann.de) by ms-10.1blu.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1rZdZK-007UAp-Rp for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 22:10:26 +0100 From: =?utf-8?Q?J=C3=B6rg_Bornemann?= To: bug-gnu-emacs@gnu.org Subject: [PATCH] ; Resolve a FIXME in rst.el Date: Mon, 12 Feb 2024 22:10:26 +0100 Message-ID: <87frxxmlrx.fsf@jbornemann.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Con-Id: 36794 X-Con-U: 0-foss X-Originating-IP: 79.242.79.138 Received-SPF: pass client-ip=178.254.4.101; envelope-from=foss@jbornemann.de; helo=ms-10.1blu.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 12 Feb 2024 16:24:59 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain Tags: patch This patch resolves a trivial FIXME in rst.el. In GNU Emacs 29.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.38, cairo version 1.16.0) of 2024-01-18 built on barf Repository revision: ef01b634d219bcceda17dcd61024c7a12173b88c Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12201009 System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure --prefix /usr/local --with-x-toolkit=gtk3 --with-xwidgets --with-imagemagick --with-json --with-tree-sitter --with-small-ja-dic --with-native-compilation' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-Resolve-a-FIXME-in-rst.el.patch >From d4cc0fe4ddfe016e76516370d742a67c29b66690 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rg=20Bornemann?= Date: Mon, 12 Feb 2024 21:56:42 +0100 Subject: [PATCH] ; Resolve a FIXME in rst.el * lisp/textmodes/rst.el (rst-define-key): Use :documentation for the dynamically created docstrings of deprecated bindings. --- lisp/textmodes/rst.el | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lisp/textmodes/rst.el b/lisp/textmodes/rst.el index 2cd78943883..5fbff4ba888 100644 --- a/lisp/textmodes/rst.el +++ b/lisp/textmodes/rst.el @@ -1147,14 +1147,14 @@ rst-define-key (unless (fboundp forwarder-function) (defalias forwarder-function (lambda () + (:documentation + (format "Deprecated binding for %s, use \\[%s] instead." + def def)) (interactive) (call-interactively def) (message "[Deprecated use of key %s; use key %s instead]" (key-description (this-command-keys)) - (key-description key))) - ;; FIXME: In Emacs-25 we could use (:documentation ...) instead. - (format "Deprecated binding for %s, use \\[%s] instead." - def def))) + (key-description key))))) (dolist (dep-key deprecated) (define-key keymap dep-key forwarder-function))))) -- 2.39.2 --=-=-=-- ------------=_1707826382-3301-1--