GNU bug report logs - #69079
[PATCH] Add 'customize-toggle-option' command

Previous Next

Full log

Message #23 received at 69079 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 69079 <at> debbugs.gnu.org
Subject: Re: bug#69079: [PATCH] Add 'customize-toggle-option' command
Date: Tue, 13 Feb 2024 14:40:49 +0200

> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: 69079 <at> debbugs.gnu.org
> Date: Tue, 13 Feb 2024 00:14:38 +0000
> 
> >> My assumption was that the command would only be invoked interactivly,
> >> so I can either make that explicit with an `interactive-only' or repeat
> >> the check.  What do you think would be better?
> >
> > I think an explicit test is better, since then we get to display a
> > user-friendly error message, instead of relying on Lisp errors to
> > explain themselves.
> >
> > Btw, are you sure that the users can never succeed in inputting a
> > non-boolean option with the way you prompt them?
> 
> No, that was not ensured, and I think it is better not to.  I have
> adjusted the patch to check and prompt the user if the user option is
> non-boolean, in case they know what they are doing.  WDYT?

LGTM, although I haven't tried to actually use the code.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.