From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 12 02:05:48 2024 Received: (at submit) by debbugs.gnu.org; 12 Feb 2024 07:05:48 +0000 Received: from localhost ([127.0.0.1]:33298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZQNw-0005wR-4H for submit@debbugs.gnu.org; Mon, 12 Feb 2024 02:05:48 -0500 Received: from lists.gnu.org ([2001:470:142::17]:56326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZQNt-0005w2-Gc for submit@debbugs.gnu.org; Mon, 12 Feb 2024 02:05:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZQNW-0005Bd-MA for guix-patches@gnu.org; Mon, 12 Feb 2024 02:05:22 -0500 Received: from vmi571514.contaboserver.net ([75.119.130.101] helo=mail.laesvuori.fi) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZQNU-00052y-B1 for guix-patches@gnu.org; Mon, 12 Feb 2024 02:05:21 -0500 Received: from X-kone.org.aalto.fi (unknown [130.233.144.131]) by mail.laesvuori.fi (Postfix) with ESMTPSA id 76777342FBD; Mon, 12 Feb 2024 08:05:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laesvuori.fi; s=mail; t=1707721552; bh=F3Bf7v7rZNmR01NJLUGi4CrSkUVGVF6dNU25BxScZ+U=; h=From:To:Cc:Subject:Date; b=fIVQ+2j3YHD4yFqZLJMIMjPlDts0qwqZJ1qEZm+FZLkHKpIsWmVOsNEuQLtsaaR91 aje1vSLQ79LUmZ7JGXam+U5NNJvYwqkKz3kwAQcLKQNv+q5nNwNIBG4f/MBMAaaV1t 3bCNB4QCqWRPrigiB/v+6ZPcv/1n+gcJdLNgrJQE= From: Saku Laesvuori To: guix-patches@gnu.org Subject: [PATCH] gnu: kitsas: Update to 5.4.1 Date: Mon, 12 Feb 2024 09:03:57 +0200 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=75.119.130.101; envelope-from=saku@laesvuori.fi; helo=mail.laesvuori.fi X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_PDS_PRO_TLD=0.01, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Saku Laesvuori X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * gnu/packages/finance.scm (kitsas): Update to 5.4.1. Change-Id: I968579d762ebecef9f9e8b602682587a054c41ad --- gnu/packages/finance.scm | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm index 98a220385b..96e2729dda 100644 --- a/gnu/packages/finance.scm +++ b/gnu/packages/finance.scm @@ -1307,7 +1307,7 @@ (define-public keepkey-agent (define-public kitsas (package (name "kitsas") - (version "4.0.3") + (version "5.4.1") (source (origin (method git-fetch) (uri (git-reference @@ -1316,17 +1316,24 @@ (define-public kitsas (file-name (git-file-name name version)) (sha256 (base32 - "0hrbsqqm6v2pmjq17s7i4akjgclz3d051mg02vcykq80xgxvbkgf")))) + "16zkfpl5d9ia202fqg5vrhjqdw0g6wp044ih6n7nz2hbxj9y3m1z")))) (build-system qt-build-system) - (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5)) + (inputs (list libzip qtsvg qtwebengine qt5compat)) (arguments (list #:tests? #f ;XXX: some tests fail and others segfault #:test-target "check" + #:qtbase qtbase #:phases #~(modify-phases %standard-phases (replace 'configure (lambda* _ (invoke "qmake" "kitsasproject.pro" "CONFIG+=release"))) + ;; The tests are not maintained and some don't even build + (add-before 'configure 'disable-broken-tests + (lambda _ + (substitute* "kitsasproject.pro" + ((" *(unittest|testit).*") "") + (("\\\\") "")))) (replace 'install (lambda* _ (install-file "kitsas/kitsas" base-commit: f2102cb5b9239be2ed2023b908b726af542e0124 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 13 06:31:58 2024 Received: (at 69068) by debbugs.gnu.org; 13 Feb 2024 11:31:58 +0000 Received: from localhost ([127.0.0.1]:42246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZr13-0007YB-Lv for submit@debbugs.gnu.org; Tue, 13 Feb 2024 06:31:57 -0500 Received: from mira.cbaines.net ([212.71.252.8]:43112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZr10-0007Xx-FC for 69068@debbugs.gnu.org; Tue, 13 Feb 2024 06:31:55 -0500 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 21FA227BBE2; Tue, 13 Feb 2024 11:31:36 +0000 (GMT) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id aa2ca4f1; Tue, 13 Feb 2024 11:31:35 +0000 (UTC) References: User-agent: mu4e 1.10.7; emacs 29.1 From: Christopher Baines To: Saku Laesvuori Subject: Re: [bug#69068] [PATCH] gnu: kitsas: Update to 5.4.1 Date: Tue, 13 Feb 2024 11:30:50 +0000 In-reply-to: Message-ID: <87le7obnxl.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69068 Cc: 69068@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Saku Laesvuori via Guix-patches via writes: > * gnu/packages/finance.scm (kitsas): Update to 5.4.1. > > Change-Id: I968579d762ebecef9f9e8b602682587a054c41ad > --- > gnu/packages/finance.scm | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm > index 98a220385b..96e2729dda 100644 > --- a/gnu/packages/finance.scm > +++ b/gnu/packages/finance.scm > @@ -1307,7 +1307,7 @@ (define-public keepkey-agent > (define-public kitsas > (package > (name "kitsas") > - (version "4.0.3") > + (version "5.4.1") > (source (origin > (method git-fetch) > (uri (git-reference > @@ -1316,17 +1316,24 @@ (define-public kitsas > (file-name (git-file-name name version)) > (sha256 > (base32 > - "0hrbsqqm6v2pmjq17s7i4akjgclz3d051mg02vcykq80xgxvbkgf")))) > + "16zkfpl5d9ia202fqg5vrhjqdw0g6wp044ih6n7nz2hbxj9y3m1z")))) > (build-system qt-build-system) > - (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5)) > + (inputs (list libzip qtsvg qtwebengine qt5compat)) > (arguments > (list #:tests? #f ;XXX: some tests fail and others segfault > #:test-target "check" > + #:qtbase qtbase > #:phases > #~(modify-phases %standard-phases > (replace 'configure > (lambda* _ > (invoke "qmake" "kitsasproject.pro" "CONFIG+=release"))) > + ;; The tests are not maintained and some don't even build > + (add-before 'configure 'disable-broken-tests > + (lambda _ > + (substitute* "kitsasproject.pro" > + ((" *(unittest|testit).*") "") > + (("\\\\") "")))) > (replace 'install > (lambda* _ > (install-file "kitsas/kitsas" > > base-commit: f2102cb5b9239be2ed2023b908b726af542e0124 The commit message is missing information on the non-version changes to the package. In particular, the removal of qtbase from inputs confuses me, is this not needed? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmXLUxZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XeGNQ/9HkhE4DLgiugTZmnIq1p8n7juRqSiinZT eQ/2KEZ77d5FxrieLUQI5bg+xM0DlTqw7kI54m9cyZpmNydjeMqSpy9hTyVodz49 Makj0S8l8/rFLaL6/iQHWMaBQ5N1N0cLvGOAlTPegImYQFf8tPthAOrjewDds0Zc TTZNPn2t4P1Vfp44kEYKqegtiVTK8wIP3raVgxd02SClcPSqxATWWxk2uvgx/nuc Tqa9XwhiPev7TUylNYfKPttweq3xfENzNJqvWLkOweILg3CeJyKAem9joZ8lXiG1 jBn/JoKLw/cIbw6Yg3l+USJRqPj9uTIy/weHAqLvOSfWsU7A6Af2dBew7xPP6m4b k41yHB5uar9ilLHBYYOpFEVJFJVYzZXlz9XmMSLd4A5jq2fxggwQHruiV/u4x2Oi f5EZjWRueCQQJFzX88+uiFOBgq8j0IQ/WTTgp2wWnkTJm8VNoQ7YjIaD0gZUfwiz anBC6Ck7kZ94vFHNC5wHOdQBjkFOR5ktnBKw2XlgG5xF15pKWmROHJCqnGNbhXxc WBo/Cz7b//X9FFeY4q+B+1up23KgavBgaiWd9FnXzva5ytFLepqUnT+mUImAVH3p cvw6YohRJqGZwT+iQrYOXVNIaa14n3CQnyy4hhiKfjvYQOf4o0KzhrPmTfcsLtYV vruVuRT1odA= =ASbU -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 13 07:18:29 2024 Received: (at submit) by debbugs.gnu.org; 13 Feb 2024 12:18:29 +0000 Received: from localhost ([127.0.0.1]:42546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZrk4-00013d-UG for submit@debbugs.gnu.org; Tue, 13 Feb 2024 07:18:29 -0500 Received: from lists.gnu.org ([209.51.188.17]:60292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZrk2-00013T-S1 for submit@debbugs.gnu.org; Tue, 13 Feb 2024 07:18:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZrjj-0002fT-1T for guix-patches@gnu.org; Tue, 13 Feb 2024 07:18:08 -0500 Received: from vmi571514.contaboserver.net ([75.119.130.101] helo=mail.laesvuori.fi) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZrjf-0005D7-43 for guix-patches@gnu.org; Tue, 13 Feb 2024 07:18:06 -0500 Received: from X-kone (unknown [130.233.144.187]) by mail.laesvuori.fi (Postfix) with ESMTPSA id 0073F3400E1; Tue, 13 Feb 2024 13:18:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laesvuori.fi; s=mail; t=1707826716; bh=meAmSi/3IWG1SKzIUWcROlbYKpcngDwM+3mm573wXPk=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=K2+v31/jOXNZEZW475VtKhb7xm8NiPGwNiUxMPwUH7PA44AiM2YYyLDHNnxY+Gz8D 7m4DuvGz6hcw3XjIl7tiT2u6gTgNqoUCJosc3fcIiVj3s4enKCO5j48esECfsSXXva uogc/s89JpVlixZKzjS5pU0Q4peMl7BvdsGsxn68= Date: Tue, 13 Feb 2024 14:17:56 +0200 From: Saku Laesvuori To: Christopher Baines Subject: Re: [bug#69068] [PATCH] gnu: kitsas: Update to 5.4.1 Message-ID: References: <87le7obnxl.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3gdmtymtotssz4mx" Content-Disposition: inline In-Reply-To: <87le7obnxl.fsf@cbaines.net> Received-SPF: pass client-ip=75.119.130.101; envelope-from=saku@laesvuori.fi; helo=mail.laesvuori.fi X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_PDS_PRO_TLD=0.01, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 69068@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --3gdmtymtotssz4mx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 13, 2024 at 11:30:50AM +0000, Christopher Baines wrote: >=20 > Saku Laesvuori via Guix-patches via writes: >=20 > > * gnu/packages/finance.scm (kitsas): Update to 5.4.1. > > > > Change-Id: I968579d762ebecef9f9e8b602682587a054c41ad > > --- > > gnu/packages/finance.scm | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > > > > diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm > > index 98a220385b..96e2729dda 100644 > > --- a/gnu/packages/finance.scm > > +++ b/gnu/packages/finance.scm > > @@ -1307,7 +1307,7 @@ (define-public keepkey-agent > > (define-public kitsas > > (package > > (name "kitsas") > > - (version "4.0.3") > > + (version "5.4.1") > > (source (origin > > (method git-fetch) > > (uri (git-reference > > @@ -1316,17 +1316,24 @@ (define-public kitsas > > (file-name (git-file-name name version)) > > (sha256 > > (base32 > > - "0hrbsqqm6v2pmjq17s7i4akjgclz3d051mg02vcykq80xgxvbkgf"= )))) > > + "16zkfpl5d9ia202fqg5vrhjqdw0g6wp044ih6n7nz2hbxj9y3m1z"= )))) > > (build-system qt-build-system) > > - (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5)) > > + (inputs (list libzip qtsvg qtwebengine qt5compat)) > > (arguments > > (list #:tests? #f ;XXX: some tests fail and others = segfault > > #:test-target "check" > > + #:qtbase qtbase > > #:phases > > #~(modify-phases %standard-phases > > (replace 'configure > > (lambda* _ > > (invoke "qmake" "kitsasproject.pro" "CONFIG+=3Drele= ase"))) > > + ;; The tests are not maintained and some don't even bui= ld > > + (add-before 'configure 'disable-broken-tests > > + (lambda _ > > + (substitute* "kitsasproject.pro" > > + ((" *(unittest|testit).*") "") > > + (("\\\\") "")))) > > (replace 'install > > (lambda* _ > > (install-file "kitsas/kitsas" > > > > base-commit: f2102cb5b9239be2ed2023b908b726af542e0124 >=20 > The commit message is missing information on the non-version changes to > the package. All the changes are part of updating the package. The new version is built against Qt6 and requires different inputs, which also makes compiling the tests fail as they are not maintained to work with those new inputs. Earlier just passing #:tests? #f was sufficient to bypass them because they compiled fine and only failed when ran. I can try to write a better commit message if you tell which parts require their own lines, or you can clarify it yourself when applying. > In particular, the removal of qtbase from inputs confuses me, is this > not needed? It is added implicitly by qt-build-system based on the #:qtbase argument. I don't know if qt-build-system worked like that when I submitted the first version of this package, but it probably did and I just didn't realize it. --3gdmtymtotssz4mx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoMkZR3NPB29fCOn/JX0oSiodOjIFAmXLXfQACgkQJX0oSiod OjLB4Q//QHYlKGNx8asB0DpODqZ0CzbNL/i2QdPVetvNBolZVxlO397ag3u/tl4a qofXykQs2wzXmCshtYpijf0QHmxvopjn2gqow8qBy2q7WiDFk//yWMhu59HvxaFv WxGZfoFBJS6Y6Y5Kl9aaP2ktY9U/JUbZp+HEW5tyPeH+XYCr2zs19CHKzF1JYB1M vChj18itlktjcmdzsIcBgajOnh2mi4hGDcqTOYtMtH05ZDPiAvdoVNOjJqx3OpIp puzANaygK5rArD82LHwW4A7R4BfK6YtH5H/RxW/JKP8PpC2d7TDeVkLYb2xSvRHy 9oIqb3myI1OHSnmqdWJ0ZOr6wkFXtdO20j+LuCFrGDD1Dl4ifM4TH5Vb+MoTzSR9 uqjG6yLsYd3+v2rmsyYuaHisZvmuHwZtw/Wm2mUplj1lw/mxwLTMSp9YZtI9oZB0 TnWbr6ftfAiosTuyjLwL1MSDzD/5r4jhUHTQNrfeWhkugOljI36qYO5IheZ8ZoJ6 Cql5Dkgy4sRcN2Swpw7OKm8/io2YbZIU4F3CiE7Wx6dgWUpFEehGm+EgMYE8avvp R4TIPVzFazRDt+uFXYJD5JwMTCd8h8GXsPUxLeffRHh7sIMGUMdFvdGQL87IPNxc v9GZDW7LvmX4IIPUehIS3xyowRFZR1kVNx6h5KHVSTRxgFylTmw= =sqFZ -----END PGP SIGNATURE----- --3gdmtymtotssz4mx-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 28 05:51:40 2024 Received: (at 69068) by debbugs.gnu.org; 28 Feb 2024 10:51:41 +0000 Received: from localhost ([127.0.0.1]:57917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfHXI-0004w6-MW for submit@debbugs.gnu.org; Wed, 28 Feb 2024 05:51:40 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:60468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfHXG-0004vk-G1 for 69068@debbugs.gnu.org; Wed, 28 Feb 2024 05:51:38 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 95AA7490; Wed, 28 Feb 2024 11:32:48 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B2c5ufg_GLRG; Wed, 28 Feb 2024 11:32:48 +0100 (CET) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 264FC18E; Wed, 28 Feb 2024 11:32:48 +0100 (CET) Date: Wed, 28 Feb 2024 11:32:43 +0100 From: Andreas Enge To: 69068@debbugs.gnu.org Subject: To test or not to test? Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69068 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, I also looked at this just now and am confused by the test situation. Should one not either disable tests altogether, or just comment out some of them? Andreas From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 28 06:48:20 2024 Received: (at 69068) by debbugs.gnu.org; 28 Feb 2024 11:48:20 +0000 Received: from localhost ([127.0.0.1]:33419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfIQ7-0007m2-PA for submit@debbugs.gnu.org; Wed, 28 Feb 2024 06:48:20 -0500 Received: from vmi571514.contaboserver.net ([75.119.130.101]:42972 helo=mail.laesvuori.fi) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfIQ5-0007lj-Kx for 69068@debbugs.gnu.org; Wed, 28 Feb 2024 06:48:18 -0500 Received: from X-kone (unknown [130.233.144.71]) by mail.laesvuori.fi (Postfix) with ESMTPSA id 3CC193400F9; Wed, 28 Feb 2024 12:48:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=laesvuori.fi; s=mail; t=1709120914; bh=R2ZXXg6X7XixVuxgXWVt2QVbJGVEjmzjRUHMNIABS9g=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=EHZMIqRRz23I3a+cgFX1LXqmwrWb2+30Nm6BOkuCjdrdfyxsB0e7LFRq+fwoMKuaH v9P3qcKR3Z+doCD+zghaJdIEPYBNE0ny5wYQbKBlIc92O0SeCJtU5hslPg3wE9NNBC JCpr/AKnwt1kOYY550X8E6A7Ust+5lKnqkqk0i3U= Date: Wed, 28 Feb 2024 13:47:47 +0200 From: Saku Laesvuori To: Andreas Enge Subject: Re: [bug#69068] To test or not to test? Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="v745dber6pxghqsg" Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69068 Cc: 69068@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --v745dber6pxghqsg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 28, 2024 at 11:32:43AM +0100, Andreas Enge wrote: > Hello, >=20 > I also looked at this just now and am confused by the test situation. > Should one not either disable tests altogether, or just comment out > some of them? I don't believe any of them even compile with Qt6. The test suite has been unmaintained for years, so it doesn't really tell anything about whether the program works correctly or not. I would certainly agree that it is better to remove just the failing ones if the issues were actual test failures due to how Guix packaging works. Here the problem is that the project effectively no longer has a test suite. --v745dber6pxghqsg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoMkZR3NPB29fCOn/JX0oSiodOjIFAmXfHWMACgkQJX0oSiod OjL1pxAAmUz+aHKdZnpralyIAybMnbtdKr7Od0QHlm+iJHAnwZ1602CTGiqcHZk3 KW6f0AM76VgvHOLEFPggQ4rD0lvEC/U1mf6tnpMlosx71KPLLLeeg3yQFGmeyGo4 AQITteuQRNssq1xrYkVGw5yLYyperqeSQCBCdtGszEEufEH2zVF1duCFXIWJFU+1 IPDWDxD8zEvwlfWGGZMcLWmw97FHb/JoJwvytAgnuWxhlIbDsqjfi1fwg83mHS8z h1v4EmhoCvcMg2baKcgJCrBxbXe6H/YhoIeTRyXPHfm/AzOnO/mCIOMm3nTCCB2m JyjuXz9l1yYeByZN+v9uu8tTHSteZ9vvYRnNCMzIzh0QqDtXiekUXNdF5BuLWpKY 0G3T64QdiprH4JXj/KqV8Y7XTBZlsPdZ1TwD39UR60XtinYbH5CMP8gLc07cWuE8 W61BpESYP9WHLHrx8wdJ9Z1HU+0FJ0XTYSDr5KpbxDPykKf2b9I4Qnc56RzVlwTb w5ojKwK6n5xSZatwhPauyKPWICBLlTVLDY56e6/0bLaVujboB0eTYI0p/xWnBUHV DYY4lsqhDut1ER30vevhZLPr1Lid9xZ3dXcgvpeu4LU6K5K8VuW/Dcfmvt5ABfRa gXRGXB8nhdCSHns53rIdI21c7+XF0RoocgjMbol+dDLBDrcp2KU= =WBrs -----END PGP SIGNATURE----- --v745dber6pxghqsg-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 28 07:38:16 2024 Received: (at 69068) by debbugs.gnu.org; 28 Feb 2024 12:38:16 +0000 Received: from localhost ([127.0.0.1]:36483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfJCR-0004Lg-Ec for submit@debbugs.gnu.org; Wed, 28 Feb 2024 07:38:15 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:42054) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfJCB-0004Kc-IE for 69068@debbugs.gnu.org; Wed, 28 Feb 2024 07:38:13 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id B61EF707; Wed, 28 Feb 2024 13:36:56 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mjDvMPhJHQTJ; Wed, 28 Feb 2024 13:36:56 +0100 (CET) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 1AD952BF; Wed, 28 Feb 2024 13:36:56 +0100 (CET) Date: Wed, 28 Feb 2024 13:36:54 +0100 From: Andreas Enge To: Saku Laesvuori Subject: Re: [bug#69068] To test or not to test? Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69068 Cc: 69068@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Wed, Feb 28, 2024 at 01:47:47PM +0200 schrieb Saku Laesvuori: > I don't believe any of them even compile with Qt6. The test suite has > been unmaintained for years, so it doesn't really tell anything about > whether the program works correctly or not. Sorry for not being more precise: I am wondering if this part of the patch: + ;; The tests are not maintained and some don't even build + (add-before 'configure 'disable-broken-tests + (lambda _ + (substitute* "kitsasproject.pro" + ((" *(unittest|testit).*") "") + (("\\\\") "")))) is of interest given that there already is (list #:tests? #f ;XXX: some tests fail and others segfault #:test-target "check" ? Andreas From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 28 07:50:30 2024 Received: (at 69068) by debbugs.gnu.org; 28 Feb 2024 12:50:30 +0000 Received: from localhost ([127.0.0.1]:37346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfJOI-00051c-6v for submit@debbugs.gnu.org; Wed, 28 Feb 2024 07:50:30 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:40800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfJOG-00051A-DZ for 69068@debbugs.gnu.org; Wed, 28 Feb 2024 07:50:29 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 6641763B; Wed, 28 Feb 2024 13:49:25 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HNF8SEJ9Rf3E; Wed, 28 Feb 2024 13:49:24 +0100 (CET) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 8D7CC4D6; Wed, 28 Feb 2024 13:49:24 +0100 (CET) Date: Wed, 28 Feb 2024 13:49:22 +0100 From: Andreas Enge To: Saku Laesvuori Subject: Re: [bug#69068] To test or not to test? Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69068 Cc: 69068@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sorry, I see that you already answered this question before. I will prepare to push. Andreas From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 28 10:37:19 2024 Received: (at 69068-done) by debbugs.gnu.org; 28 Feb 2024 15:37:19 +0000 Received: from localhost ([127.0.0.1]:49391 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfLzd-0007bJ-Ps for submit@debbugs.gnu.org; Wed, 28 Feb 2024 10:37:19 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:57722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rfLzZ-0007aj-Bl for 69068-done@debbugs.gnu.org; Wed, 28 Feb 2024 10:37:13 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 1A62F9C7; Wed, 28 Feb 2024 16:36:06 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9GprTq57UzPX; Wed, 28 Feb 2024 16:36:05 +0100 (CET) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 8A53B1E6; Wed, 28 Feb 2024 16:36:05 +0100 (CET) Date: Wed, 28 Feb 2024 16:36:04 +0100 From: Andreas Enge To: Saku Laesvuori Subject: Re: [bug#69068] To test or not to test? Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 69068-done Cc: 69068-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Wed, Feb 28, 2024 at 01:49:22PM +0100 schrieb Andreas Enge: > Sorry, I see that you already answered this question before. I will > prepare to push. Following the rust team merge, I wanted to rebuild the package once more, which succeeded. Pushed, thanks for your patience! Andreas From unknown Sun Jun 22 03:57:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 28 Mar 2024 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator