From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 24 11:49:12 2010 Received: (at submit) by debbugs.gnu.org; 24 Aug 2010 15:49:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnvkO-00050o-3t for submit@debbugs.gnu.org; Tue, 24 Aug 2010 11:49:12 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnvOb-0004rJ-HG for submit@debbugs.gnu.org; Tue, 24 Aug 2010 11:26:42 -0400 Received: from lists.gnu.org ([199.232.76.165]:36363) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OnvPt-0004A1-Ti for submit@debbugs.gnu.org; Tue, 24 Aug 2010 11:28:01 -0400 Received: from [140.186.70.92] (port=58658 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OnvPp-0008GI-7v for bug-gnu-emacs@gnu.org; Tue, 24 Aug 2010 11:28:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OnvPk-0001XP-7l for bug-gnu-emacs@gnu.org; Tue, 24 Aug 2010 11:27:57 -0400 Received: from mail-qy0-f176.google.com ([209.85.216.176]:64023) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnvPk-0001XI-4v for bug-gnu-emacs@gnu.org; Tue, 24 Aug 2010 11:27:52 -0400 Received: by qyk2 with SMTP id 2so6754946qyk.0 for ; Tue, 24 Aug 2010 08:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:to:subject:date :message-id:mime-version:content-type; bh=0VbRP5X0gLQFIyBwbSrxJgyqLiqzIkFGOhqJS4pTEYQ=; b=l6Vu1Tiz8/8bwmuBOBpufDFXDvFWi3AZiIbnjeQwoUQS1Y66mtqQa+bcRrum418Udn wXYY+W+hsYy7UljXxIM/+4SiKzDPKA72+kxtKnE3NWYcnLA6mncLRK+w2Dyu3WT9geso x2n0DgSPGiOywcUxA7WpRv7tAYFHJTH4Eddyo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:mime-version:content-type; b=sbLwyjQsUoDWHycRWmJcGt7Xq6dV9TxKokmUIoeNLYIhylGcumxqcr3R5Cs7a+wZ8g fTNHtHhjnhKyxRtkpC6trqZ9jBxbvrjUMT+19eLO105GyBQ6gG57R6alYqn0oRkT8PDL 2N+7dKi8IQp08tkZ7HJKavYW5rDHLh3Sw008Q= Received: by 10.224.20.7 with SMTP id d7mr4597608qab.90.1282663671017; Tue, 24 Aug 2010 08:27:51 -0700 (PDT) Received: from eromajin.arikm.com (c-71-233-149-191.hsd1.ma.comcast.net [71.233.149.191]) by mx.google.com with ESMTPS id t1sm206037qcs.45.2010.08.24.08.27.48 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 24 Aug 2010 08:27:49 -0700 (PDT) Received: by eromajin.arikm.com (Postfix, from userid 1000) id 9975211E290; Tue, 24 Aug 2010 11:27:47 -0400 (EDT) From: Arik Mitschang To: bug-gnu-emacs@gnu.org Subject: 23.2; indent-line-to possible devide by zero error bug Date: Tue, 24 Aug 2010 11:27:47 -0400 Message-ID: <87pqx8ghe4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 24 Aug 2010 11:49:11 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) In indent.el the indent-line-to function has a comparison that devides the current column count by tab-width, whose value is an integerp and allowed to be zero (and in my experience is often 0). I noticed the issue in specific with org mode which utilizes this function for a lot of interesting tasks. I can provide the following patch which makes a check to avoid an arithmetic error: === modified file 'lisp/indent.el' --- lisp/indent.el 2010-05-19 03:06:48 +0000 +++ lisp/indent.el 2010-08-24 15:20:39 +0000 @@ -177,7 +177,9 @@ (back-to-indentation) (let ((cur-col (current-column))) (cond ((< cur-col column) - (if (>= (- column (* (/ cur-col tab-width) tab-width)) tab-width) + (if (and (> tab-width 0) + (>= (- column (* (/ cur-col tab-width) tab-width)) + tab-width)) (delete-region (point) (progn (skip-chars-backward " ") (point)))) (indent-to column)) Thanks, ~Arik From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 25 15:31:15 2010 Received: (at 6902) by debbugs.gnu.org; 25 Aug 2010 19:31:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OoLgo-0002Gh-S3 for submit@debbugs.gnu.org; Wed, 25 Aug 2010 15:31:15 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OoLgm-0002Gc-Uf for 6902@debbugs.gnu.org; Wed, 25 Aug 2010 15:31:13 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OoLi7-0002km-4w; Wed, 25 Aug 2010 15:32:35 -0400 To: Arik Mitschang Subject: Re: bug#6902: 23.2; indent-line-to possible devide by zero error bug References: <87pqx8ghe4.fsf@gmail.com> From: Glenn Morris X-Spook: IRA Mantis sniper Downing Street import LLNL security X-Ran: CJkNp0"(`W\(0v{,)dK9BW/BP+?LPAbk$^diAI"?e_\TPYC}vtUa"FvU/bBv/'uwbIM07Q X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 25 Aug 2010 15:32:35 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: 6902 Cc: 6902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) Arik Mitschang wrote: > In indent.el the indent-line-to function has a comparison that devides > the current column count by tab-width, whose value is an integerp and > allowed to be zero (and in my experience is often 0). Why do you want to set tab-width to 0? A quick grep for tab-width shows other places that will break. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 25 16:03:28 2010 Received: (at 6902) by debbugs.gnu.org; 25 Aug 2010 20:03:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OoMC0-0002TB-32 for submit@debbugs.gnu.org; Wed, 25 Aug 2010 16:03:28 -0400 Received: from mail-qw0-f44.google.com ([209.85.216.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OoMBy-0002T5-HZ for 6902@debbugs.gnu.org; Wed, 25 Aug 2010 16:03:26 -0400 Received: by qwc9 with SMTP id 9so850076qwc.3 for <6902@debbugs.gnu.org>; Wed, 25 Aug 2010 13:04:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:received:from:mime-version :content-type:content-transfer-encoding:message-id:date:to:cc :subject:in-reply-to:references:x-mailer; bh=zYrn4sYRPO/ZwuBSlDaSsizHu+BzvHX4pSgyzE/bMC4=; b=f6GX7cc9bWmDH86qkB3hbkPioOLqDIrtTjNITIskAFeR01FyyBUa1ECtk6WoypdaM1 0fPMNhLT+gUM904iLUFZIbMRYnWeF2ggTpcqpU6sojN6Ci4wOgAtDFq58BhoUqlFMrtL 28yqv7nRm2MDf+OfWDNoV4Nh9Qp0nHFAE1ipc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:mime-version:content-type:content-transfer-encoding:message-id :date:to:cc:subject:in-reply-to:references:x-mailer; b=XyO8ChZp+TwjwwkBTckNJAqZnCmMYBHO9va4tZHrnuoAzAWFBPAOd5pwUKj/y+NST3 CaLAiPSQwXpOkaQWN/APf2KkaqsXqgwEfHs2dPD00gkzv+9L7vl1hWKaKhEYs36euDe+ V3BpQmrM/n+jMRc99TX/al5aV5axD3aU5kMv8= Received: by 10.224.53.8 with SMTP id k8mr5941721qag.89.1282766689642; Wed, 25 Aug 2010 13:04:49 -0700 (PDT) Received: from eromajin.arikm.com (c-71-233-149-191.hsd1.ma.comcast.net [71.233.149.191]) by mx.google.com with ESMTPS id l8sm1970863qck.6.2010.08.25.13.04.47 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 25 Aug 2010 13:04:48 -0700 (PDT) Received: by eromajin.arikm.com (Postfix, from userid 1000) id E0D7C11E290; Wed, 25 Aug 2010 16:04:45 -0400 (EDT) From: Arik Mitschang MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19573.30557.896201.265597@gargle.gargle.HOWL> Date: Wed, 25 Aug 2010 16:04:45 -0400 To: Glenn Morris Subject: Re: bug#6902: 23.2; indent-line-to possible devide by zero error bug In-Reply-To: References: <87pqx8ghe4.fsf@gmail.com> X-Mailer: VM 8.1.92a under 23.2.1 (x86_64-unknown-linux-gnu) X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: 6902 Cc: Arik Mitschang , 6902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) Glenn Morris writes: > Arik Mitschang wrote: > > > In indent.el the indent-line-to function has a comparison that devides > > the current column count by tab-width, whose value is an integerp and > > allowed to be zero (and in my experience is often 0). > > Why do you want to set tab-width to 0? Honestly I cannot remember, but I had it set there and I assume there was a reason. > > A quick grep for tab-width shows other places that will break. The fact that it's value can be zero (without even warning in the doc string) and this value causes functionality to break doesn't seem good to me. If nobody but me ever had it set to zero, then perhaps just updating its doc-string to warn users away from that value would be nice. Thanks, ~Arik From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 10 16:56:59 2011 Received: (at 6902) by debbugs.gnu.org; 10 Apr 2011 20:56:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q91gp-0006uQ-HU for submit@debbugs.gnu.org; Sun, 10 Apr 2011 16:56:59 -0400 Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q91go-0006uG-Oq for 6902@debbugs.gnu.org; Sun, 10 Apr 2011 16:56:58 -0400 Received: from furball (dhcp128036159042.central.yale.edu [128.36.159.42]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p3AKurLC013498 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 10 Apr 2011 16:56:53 -0400 Received: by furball (Postfix, from userid 1000) id DA4B3160461; Sun, 10 Apr 2011 16:56:52 -0400 (EDT) From: Chong Yidong To: Arik Mitschang Subject: Re: bug#6902: 23.2; indent-line-to possible devide by zero error bug References: <87pqx8ghe4.fsf@gmail.com> <19573.30557.896201.265597@gargle.gargle.HOWL> Date: Sun, 10 Apr 2011 16:56:52 -0400 In-Reply-To: <19573.30557.896201.265597@gargle.gargle.HOWL> (Arik Mitschang's message of "Wed, 25 Aug 2010 16:04:45 -0400") Message-ID: <8739lplt9n.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 6902 Cc: Glenn Morris , 6902@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Arik Mitschang writes: > > A quick grep for tab-width shows other places that will break. > > The fact that it's value can be zero (without even warning in the doc > string) and this value causes functionality to break doesn't seem good > to me. If nobody but me ever had it set to zero, then perhaps just > updating its doc-string to warn users away from that value would be > nice. I have made such an update to the doc-string. It doesn't seem worthwhile to try to handle zero tab-widths in all the places where it could be problematic. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 10 16:57:22 2011 Received: (at control) by debbugs.gnu.org; 10 Apr 2011 20:57:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q91hB-0006vJ-Q5 for submit@debbugs.gnu.org; Sun, 10 Apr 2011 16:57:22 -0400 Received: from vm-emlprdomr-06.its.yale.edu ([130.132.50.147]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q91hA-0006v8-FV for control@debbugs.gnu.org; Sun, 10 Apr 2011 16:57:20 -0400 Received: from furball (dhcp128036159042.central.yale.edu [128.36.159.42]) (authenticated bits=0) by vm-emlprdomr-06.its.yale.edu (8.14.4/8.14.4) with ESMTP id p3AKvEWI002540 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sun, 10 Apr 2011 16:57:15 -0400 Received: by furball (Postfix, from userid 1000) id 5B28C160461; Sun, 10 Apr 2011 16:57:14 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 6902 Date: Sun, 10 Apr 2011 16:57:14 -0400 Message-ID: <8762qlq0yd.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.147 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 6902 thanks From unknown Sat Sep 13 02:39:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 09 May 2011 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator