GNU bug report logs - #69019
[PATCH] package-vc: scan the correct directory for lisp files

Previous Next

Full log

Message #14 received at 69019 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Steven Allen <steven <at> stebalien.com>
Cc: 69019 <at> debbugs.gnu.org
Subject: Re: bug#69019: [PATCH] package-vc: scan the correct directory for
 lisp files
Date: Mon, 12 Feb 2024 17:45:59 +0000

[Message part 1 (text/plain, inline)]

(Don't forget to keep the bug tracker in the CC's; I have resent your
message so that everything remains in the archives)

Steven Allen <steven <at> stebalien.com> writes:

>>> Following up on my previous patch (Bug#68761), we need to scan for
>>> package requirements inside the lisp-dir (if set), not in the root
>>> package directory.
>>
>> Looks good, do you have any specific examples where this caused
>> problems?
>
> pdf-tools puts all its files in a "lisp" dir, so they weren't getting
> searched when scanning for dependencies. The package definition is:
>
>     (:url "https://github.com/vedang/pdf-tools/pulls"
>      :lisp-dir "lisp")
>
> This patch causes package-vc to scan for dependencies in elisp files in
> "$pkg-dir/lisp/", instead of looking for elisp files in "$pkg-dir/".

OK, I have slightly modified the commit, can you check if it still works
for you:

[0001-Respect-lisp-dir-whilst-scanning-for-VC-package-depe.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

>>> * lisp/emacs-lisp/package-vc.el (package-vc--unpack-1):
>>>   Scan 'lisp-dir', if set, for lisp files instead of scanning the root
>>>   package directory.
>>
>> Just note that the convention of the commit message logs is not to
>> indent the lines here.  I can take care of that.
>
> I did not, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.