Subject: bug#69005: closed (Re: [bug#69005] [PATCH] gnu: Add ckdl.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 16 Feb 2024 18:56:01 +0000

Your bug report

#69005: [PATCH] gnu: Add ckdl.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
69005: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69005
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#69005] [PATCH] gnu: Add ckdl.
From: Clément Lassieur <[email-masked]>
To: "Paul A. Patience" <[email-masked]>
Cc: [email-masked]
Date: Fri, 16 Feb 2024 19:54:54 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

On Fri, Feb 09 2024, Paul A. Patience wrote:

> * gnu/packages/serialization.scm (ckdl): New variable.
>
> Change-Id: I658369e85c80c985da3e61d2809d36e6e703ed8c
> ---
> Should kdlpp be provided in a separate package that inherits from ckdl?
> For now ckdl provides both libkdl.so and libkdlpp.so.

I think it's good as is.

LGDM, pushed, thank you.

Subject: [PATCH] gnu: Add ckdl.
From: "Paul A. Patience" <[email-masked]>
To: [email-masked]
Cc: "Paul A. Patience" <[email-masked]>
Date: Fri, 09 Feb 2024 19:55:14 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/serialization.scm (ckdl): New variable.

Change-Id: I658369e85c80c985da3e61d2809d36e6e703ed8c
---
Should kdlpp be provided in a separate package that inherits from ckdl?
For now ckdl provides both libkdl.so and libkdlpp.so.

 gnu/packages/serialization.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/serialization.scm b/gnu/packages/serialization.scm
index ccafb8e802..a69245274a 100644
--- a/gnu/packages/serialization.scm
+++ b/gnu/packages/serialization.scm
@@ -17,6 +17,7 @@
 ;;; Copyright © 2023 Vinicius Monego <[email-masked]>
 ;;; Copyright © 2023 Maxim Cournoyer <[email-masked]>
 ;;; Copyright © 2023 Zheng Junjie <[email-masked]>
+;;; Copyright © 2024 Paul A. Patience <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -622,6 +623,29 @@ (define-public json.sh
       (home-page "https://github.com/dominictarr/JSON.sh")
       (license (list license:expat license:asl2.0))))) ;dual-licensed
 
+(define-public ckdl
+  (package
+    (name "ckdl")
+    (version "0.1.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/tjol/ckdl")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32 "1zdpil61lm141lcxmfrg7jvfjp2n98v5q2rfqzm4wiqcdprgmasv"))))
+    (build-system cmake-build-system)
+    (arguments
+     (list #:configure-flags #~(list "-DBUILD_SHARED_LIBS=ON"
+                                     "-DDOWNLOAD_TEST_DATA=OFF")))
+    (home-page "https://ckdl.readthedocs.io/en/latest/")
+    (synopsis "C library for parsing and emitting KDL")
+    (description "@samp{ckdl} is a C library for parsing and emitting KDL.
+This package also provides @samp{kdlpp}, a C++20 wrapper around @samp{ckdl}.")
+    (license license:expat)))
+
 (define-public capnproto
   (package
     (name "capnproto")

base-commit: 570ef13a87bb54d3410c431700ba78316a2641e2
-- 
2.41.0