GNU bug report logs - #68996
[PATCH] Respect warnings added in GNU Make 4.4.90

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68996 in the body.
You can then email your comments to 68996 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Collin Funk <collinfunk38 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Respect warnings added in GNU Make 4.4.90
Date: Thu, 08 Feb 2024 19:00:02 -0800

[Message part 1 (text/plain, inline)]

Tags: patch

Tags: patch

When building Emacs with recent versions of GNU Make every object file
built will result in a warning like so:

../src/verbose.mk:58: warning: invalid variable reference ' '
  CC       emacs-module.o

This doesn't prevent Emacs from building but makes it slightly harder
to see any build output. I attached a patch that should work for all
versions of GNU Make, both before and after the change. However it
also causes the indentation to disappear in-front of CC and ELC which
looks a bit strange. It doesn't seem like there is a valid way to do
this at the moment. More discussion about this change can be seen
here: https://savannah.gnu.org/bugs/?65273

Feel free to change my patch if you see a better way to solve these
warnings.

Also, I have never committed to Emacs. This change feels trivial but
results in 34 lines changed. Therefore I was unsure if this patch
could be Copyright-paperwork-exempt tagged. Feel free to email me off
list if I must fill them out. Thanks

Collin

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.16.0) of 2024-02-07 built on debian
Repository revision: ed2450e79b597e0306f14b542e934a90dfd9786f
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101007
System Description: Debian GNU/Linux 12 (bookworm)

Configured using:
 'configure --prefix=/home/collin/.local --with-sound=no
 --with-libsystemd --without-gconf --without-compress-install
 --with-native-compilation=yes --with-cairo --with-x=yes
 --with-x-toolkit=gtk3 --with-harfbuzz --with-tree-sitter --with-json
 --with-imagemagick'

[0001-Respect-warnings-added-in-GNU-Make-4.4.90.patch (text/patch, attachment)]

Message #8 received at 68996 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Collin Funk <collinfunk38 <at> gmail.com>, Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 68996 <at> debbugs.gnu.org
Subject: Re: bug#68996: [PATCH] Respect warnings added in GNU Make 4.4.90
Date: Fri, 09 Feb 2024 08:25:26 +0200

> From: Collin Funk <collinfunk38 <at> gmail.com>
> Date: Thu, 08 Feb 2024 19:00:02 -0800
> 
> When building Emacs with recent versions of GNU Make every object file
> built will result in a warning like so:
> 
> ../src/verbose.mk:58: warning: invalid variable reference ' '
>   CC       emacs-module.o

Why did Make have to break Makefiles that depend on this "feature"?

> This doesn't prevent Emacs from building but makes it slightly harder
> to see any build output. I attached a patch that should work for all
> versions of GNU Make, both before and after the change. However it
> also causes the indentation to disappear in-front of CC and ELC which
> looks a bit strange. It doesn't seem like there is a valid way to do
> this at the moment. More discussion about this change can be seen
> here: https://savannah.gnu.org/bugs/?65273
> 
> Feel free to change my patch if you see a better way to solve these
> warnings.

My vote is for GNU Make to support this feature, since there's no good
way of having it otherwise (given what Paul Smith says in that
discussion).  Adding Paul Eggert in case he has ideas.  Paul, how do
other project produce the same indented "CC foo.o"? do they also use
this trick? or something else?

> Also, I have never committed to Emacs. This change feels trivial but
> results in 34 lines changed. Therefore I was unsure if this patch
> could be Copyright-paperwork-exempt tagged. Feel free to email me off
> list if I must fill them out. Thanks

Let's see if we want to install this.  I'm not sure.

Message #13 received at 68996-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>, Collin Funk <collinfunk38 <at> gmail.com>
Cc: 68996-done <at> debbugs.gnu.org
Subject: Re: bug#68996: [PATCH] Respect warnings added in GNU Make 4.4.90
Date: Thu, 8 Feb 2024 23:27:47 -0800

[Message part 1 (text/plain, inline)]

On 2024-02-08 22:25, Eli Zaretskii wrote:
> Paul, how do
> other project produce the same indented "CC foo.o"? do they also use
> this trick? or something else?

Nobody else does it as far as I know. It was my invention, just for Emacs.

I expect the new GNU 'make' behavior will be better for most software 
projects, as it's likely to catch typos that cause bugs. So let's port 
to it; it's not hard. To do that, I installed the attached patch into 
Emacs master. It uses Paul Smith's suggestion, so that 'make' still 
outputs nicely-indented info.

Boldly marking this bug as done.

[0001-Port-to-GNU-Make-03ecd94488b85adc38746ec3e7c2a297a52.patch (text/x-patch, attachment)]

Message #16 received at 68996 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: collinfunk38 <at> gmail.com, 68996 <at> debbugs.gnu.org
Subject: Re: bug#68996: [PATCH] Respect warnings added in GNU Make 4.4.90
Date: Fri, 09 Feb 2024 13:43:53 +0200

> Date: Thu, 8 Feb 2024 23:27:47 -0800
> Cc: 68996-done <at> debbugs.gnu.org
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> 
> I expect the new GNU 'make' behavior will be better for most software 
> projects, as it's likely to catch typos that cause bugs. So let's port 
> to it; it's not hard. To do that, I installed the attached patch into 
> Emacs master. It uses Paul Smith's suggestion, so that 'make' still 
> outputs nicely-indented info.

Thanks, the results look good here.

Message #19 received at 68996 <at> debbugs.gnu.org (full text, mbox):

From: Collin Funk <collin.funk1 <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 68996 <at> debbugs.gnu.org
Subject: Re: bug#68996: [PATCH] Respect warnings added in GNU Make 4.4.90
Date: Fri, 9 Feb 2024 04:18:07 -0800

On 2/9/24 3:43 AM, Eli Zaretskii wrote:
> Thanks, the results look good here.

Works for me with GNU Make 4.3 and 4.4.90 as well.
Hopefully nothing breaks the $. workaround in the future. :)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.