Subject: [bug#68994] [PATCH] adding xmake

From: Mathieu Othacehe <[email-masked]>
Date: Fri, 09 Feb 2024 16:42:01 +0100

Hello,

Thanks for this patch.

> ---
>  gnu/packages/build-tools.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)

You are missing a commit message here. The commit message should follow
the conventions explained here:
https://www.gnu.org/prep/standards/html_node/Change-Logs.html

You can also have a look the `git log` for examples.

> +(define-public xmake
> +  (package
> +    (name "xmake")
> +    (version "2.8.6")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/xmake-io/xmake.git")
> +	     (recursive? #t)

        ^
        that's a tabulation

Reported by `guix lint`:

gnu/packages/build-tools.scm:1027:0: [email-masked]: tabulation on line 1027, column 0

> +    (arguments
> +     `(#:tests? #f))

There is a test directory so the tests should not be disabled.

> +    (home-page "https://xmake.io/")

`guix lint` reports that:

gnu/packages/build-tools.scm:1023:5: [email-masked]: permanent redirect
from https://github.com/xmake-io/xmake.git to
https://github.com/xmake-io/xmake

> +    (synopsis "Cross-platform build utility based on Lua")
> +    (description "Xmake is a cross-platform build utility based on Lua.")

Please expand a bit on that description. What are the features of xmake
for instance?

> +    (license gpl3+)))

There's an issue preventing this from compiling. You should use
licence:gpl3+. By the way, it seems to be license:asl2.0 rather than
license:gplv3+.

Please make sure that `make` reports no error on your package.

Don't hesitate to ask if some remarks are unclear :)

Thanks,

Mathieu