Subject: Re: bug#68980: [Matto Fransen] Propose to add rcirc-sqlite to ELPA

From: Stefan Monnier <[email-masked]>
Date: Wed, 07 Feb 2024 20:11:24 -0500

> I would like to propose to add the package `rcirc-sqlite' to ELPA.
>
> rcirc is a default, simple IRC client in Emacs. rcirc can be
> enabled to log to files.
>
> rcirc-sqlite diverts the rcirc logs to a SQLite database and offers
> some functionality to query this database.
>
> Please see: https://codeberg.org/mattof/rcirc-sqlite/

LGTM, thank you.
I just added it to `elpa.git`.
See below for a few minor changes that would be desirable.

        Stefan

diff --git a/.gitignore b/.gitignore
index 92112bec18..a475b22e90 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,3 +11,6 @@
 # Undo-tree save-files
 *.~undo-tree
 
+# ELPA-generated files
+/rcirc-sqlite-autoloads.el
+/rcirc-sqlite-pkg.el
diff --git a/rcirc-sqlite.el b/rcirc-sqlite.el
index 9928695d0d..f37440361c 100644
--- a/rcirc-sqlite.el
+++ b/rcirc-sqlite.el
@@ -45,6 +45,9 @@
 
 ;;; Code:
 
+(defvar rcirc-log-alist)
+(defvar rcirc-log-time-format)
+
 (defgroup rcirc-sqlite nil
   "Rcirc logging in SQLite."
   :prefix "rcirc-sqlite-"