From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 07 12:47:52 2024 Received: (at submit) by debbugs.gnu.org; 7 Feb 2024 17:47:52 +0000 Received: from localhost ([127.0.0.1]:57867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXm1Y-0004TE-1z for submit@debbugs.gnu.org; Wed, 07 Feb 2024 12:47:52 -0500 Received: from lists.gnu.org ([2001:470:142::17]:58132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXm1W-0004Si-5Z for submit@debbugs.gnu.org; Wed, 07 Feb 2024 12:47:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXm1C-00015x-M1 for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2024 12:47:30 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXm1B-0002I1-87 for bug-gnu-emacs@gnu.org; Wed, 07 Feb 2024 12:47:30 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 068F660007 for ; Wed, 7 Feb 2024 17:47:25 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: Outline mode menu Organization: LINKOV.NET Date: Wed, 07 Feb 2024 19:40:50 +0200 Message-ID: <86o7csf9zx.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: juri@linkov.net Received-SPF: pass client-ip=217.70.183.195; envelope-from=juri@linkov.net; helo=relay3-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) While adding new commands ‘outline-cycle’ and ‘outline-cycle-buffer’ to the outline mode menu, I noticed a strange menu definition. It looks like "Hide", "Show" and "Headings" were intended to be a submenu, but due to the broken menus these titles are not used. (define-key map [hide] (cons "Hide" (make-sparse-keymap "Hide"))) (define-key map [hide outline-hide-other] (define-key map [show] (cons "Show" (make-sparse-keymap "Show"))) (define-key map [show outline-show-subtree] (define-key map [headings] (cons "Headings" (make-sparse-keymap "Headings"))) (define-key map [headings demote-subtree] Probably this should be transformed to 'easy-menu-define'. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 09 02:22:26 2024 Received: (at 68979) by debbugs.gnu.org; 9 Feb 2024 07:22:26 +0000 Received: from localhost ([127.0.0.1]:41435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYLDO-0007Uk-1w for submit@debbugs.gnu.org; Fri, 09 Feb 2024 02:22:26 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:45181) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYLDL-0007Tr-PE for 68979@debbugs.gnu.org; Fri, 09 Feb 2024 02:22:24 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 029CA1BF203 for <68979@debbugs.gnu.org>; Fri, 9 Feb 2024 07:22:01 +0000 (UTC) From: Juri Linkov To: 68979@debbugs.gnu.org Subject: Re: bug#68979: Outline mode menu In-Reply-To: <86o7csf9zx.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 07 Feb 2024 19:40:50 +0200") Organization: LINKOV.NET References: <86o7csf9zx.fsf@mail.linkov.net> Date: Fri, 09 Feb 2024 09:12:58 +0200 Message-ID: <86o7cqjgnl.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68979 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > While adding new commands ‘outline-cycle’ and ‘outline-cycle-buffer’ > to the outline mode menu, I noticed a strange menu definition. > > It looks like "Hide", "Show" and "Headings" were intended to be a submenu, > but due to the broken menus these titles are not used. > > (define-key map [hide] (cons "Hide" (make-sparse-keymap "Hide"))) > (define-key map [hide outline-hide-other] > > (define-key map [show] (cons "Show" (make-sparse-keymap "Show"))) > (define-key map [show outline-show-subtree] > > (define-key map [headings] (cons "Headings" (make-sparse-keymap "Headings"))) > (define-key map [headings demote-subtree] > > Probably this should be transformed to 'easy-menu-define'. Actually this implementation is intentional as the comments explain. So there is nothing to do here. Also I failed to add new commands ‘outline-cycle’ and ‘outline-cycle-buffer’ because they equally fit into both submenus "Show" and "Hide". So this request could be closed with the following patch that adds the menu item for outline-minor-mode to make it more prominent as discussed in bug#68824. diff --git a/lisp/menu-bar.el b/lisp/menu-bar.el index 47c6a8f0613..5b290899ff5 100644 --- a/lisp/menu-bar.el +++ b/lisp/menu-bar.el @@ -1353,6 +1353,15 @@ menu-bar-showhide-menu (frame-visible-p (symbol-value 'speedbar-frame)))))) + (bindings--define-key menu [showhide-outline-minor-mode] + '(menu-item "Outlines" outline-minor-mode + :help "Turn outline-minor-mode on/off" + :visible (seq-some #'local-variable-p + '(outline-search-function + outline-regexp outline-level)) + :button (:toggle . (and (boundp 'outline-minor-mode) + outline-minor-mode)))) + (bindings--define-key menu [showhide-tab-line-mode] '(menu-item "Window Tab Line" global-tab-line-mode :help "Turn window-local tab-lines on/off" From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 12:37:04 2024 Received: (at 68979) by debbugs.gnu.org; 10 Feb 2024 17:37:04 +0000 Received: from localhost ([127.0.0.1]:56975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYrHj-0002yX-Qy for submit@debbugs.gnu.org; Sat, 10 Feb 2024 12:37:04 -0500 Received: from relay8-d.mail.gandi.net ([2001:4b98:dc4:8::228]:44823) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYrHg-0002xD-Jy; Sat, 10 Feb 2024 12:37:01 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id E5AE71BF203; Sat, 10 Feb 2024 17:36:37 +0000 (UTC) From: Juri Linkov To: 68979@debbugs.gnu.org Subject: Re: bug#68979: Outline mode menu In-Reply-To: <86o7cqjgnl.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 09 Feb 2024 09:12:58 +0200") Organization: LINKOV.NET References: <86o7csf9zx.fsf@mail.linkov.net> <86o7cqjgnl.fsf@mail.linkov.net> Date: Sat, 10 Feb 2024 19:34:32 +0200 Message-ID: <86y1bs6x5j.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68979 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) close 68979 30.0.50 quit > So this request could be closed with the following patch that adds the > menu item for outline-minor-mode to make it more prominent as discussed > in bug#68824. Now pushed to master and closed. From unknown Tue Aug 19 04:05:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 10 Mar 2024 11:24:13 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator