GNU bug report logs - #68970
30.0.50; Info.el: Info-url-alist should support format-sequence that encodes "Top" node as "index"

Previous Next

Full log

Message #38 received at 68970 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mekeor Melire <mekeor <at> posteo.de>
Cc: 68970 <at> debbugs.gnu.org
Subject: Re: bug#68970: [PATCH] In Info-url-alist, add .html extension to %e
 format-sequence
Date: Sat, 10 Feb 2024 15:56:04 +0200

> From: Mekeor Melire <mekeor <at> posteo.de>
> Cc: Eli Zaretskii <eliz <at> gnu.org>
> Date: Sat, 10 Feb 2024 13:16:21 +0000
> 
> 2024-02-10 09:46 eliz <at> gnu.org:
> 
> > > From: Mekeor Melire <mekeor <at> posteo.de>
> > > Cc: Eli Zaretskii <eliz <at> gnu.org>
> > > Date: Fri, 09 Feb 2024 22:00:47 +0000
> > >
> > > Note that in the mean time, the fill-column has been changed for the
> > > Emacs repository via directory-local variables. For this patch, I
> > > did not use the "new" fill-column value so that the changes to the
> > > docstring can be seen well in the diff. Please let me know if you'd
> > > like the docstrings to be refilled according to the new fill-column.
> >
> > From where I stand, the fill-column for commit log messages is just a
> > guideline, not a hard requirement.  It is more important to have the
> > doc strings filled so they are easily readable.  The hard requirements
> > are spelled out in CONTRIBUTE.
> 
> Sorry, I was referring to emacs-lisp-docstring-fill-column which Stefan
> Kangas increased from 65 to 72 on 2nd February 2024. Should I refill the
> docstring of Info-url-alist to match the new value?

I understood, and answered your question above.  To clarify: if the
doc string looks okay to you, there's no need to refill.

> > Two spaces between sentences, please.
> 
> Sorry, I will fix it.
> 
> > Should we add here tests for the Top node?
> 
> Yes, that's a good idea. I will do so.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.