GNU bug report logs - #68954
[PATCH] Crasher in treesit_traverse_get_predicate

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#68954: closed ([PATCH] Crasher in treesit_traverse_get_predicate)
Date: Fri, 09 Feb 2024 05:29:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 8 Feb 2024 21:27:43 -0800
with message-id <90A203CD-DC72-4C5D-B64C-21C036B4B1FD <at> gmail.com>
and subject line Re: bug#68954: Offending commit
has caused the debbugs.gnu.org bug report #68954,
regarding [PATCH] Crasher in treesit_traverse_get_predicate
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
68954: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68954
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dominique Quatravaux <dominique <at> quatravaux.org>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Crasher in treesit_traverse_get_predicate
Date: Tue, 6 Feb 2024 18:08:18 +0100

[Message part 3 (text/plain, inline)]

Because nothing guarantees or enforces that either Vtreesit_thing_settings,
or the cdrs of its elements, are cons cells, it is easy to construct values
for `treesit-thing-settings' that make Emacs crash (e.g., when calling
`prog-fill-reindent-defun' from any tree-sitter enabled mode).

The attached patch fixes that.

--
 Dominique Quatravaux
 dominique <at> quatravaux.org

[Message part 4 (text/html, inline)]

[treesit.diff (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Dominique Quatravaux <dominique <at> quatravaux.org>
Cc: 68954-done <at> debbugs.gnu.org
Subject: Re: bug#68954: Offending commit
Date: Thu, 8 Feb 2024 21:27:43 -0800

> On Feb 8, 2024, at 1:36 AM, Dominique Quatravaux <dominique <at> quatravaux.org> wrote:
> 
> 
> 
> Le jeu. 8 févr. 2024 à 02:35, Yuan Fu <casouri <at> gmail.com> a écrit :
> 
> 
> Actually, here’s what I would write for your change, feel free to modify it as you like.
> 
> 
> Many thanks for the step-by-step instructions! Attached is what `git format-patch` gave me, I hope that I got everything right.
> 
> Yours truly,
>  

Great! Merged to master. Closing this. I also recommend you start your copyright assignment process, in case you contribute more in the future. You can ask for the from and instructions on emacs-devel, or just CC Eli (eliz <at> gnu.org) in this thread and ask him to send you one.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.