From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 06 12:08:55 2024 Received: (at submit) by debbugs.gnu.org; 6 Feb 2024 17:08:55 +0000 Received: from localhost ([127.0.0.1]:55031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXOwJ-0005p6-I2 for submit@debbugs.gnu.org; Tue, 06 Feb 2024 12:08:55 -0500 Received: from lists.gnu.org ([2001:470:142::17]:52944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXOwH-0005oq-HN for submit@debbugs.gnu.org; Tue, 06 Feb 2024 12:08:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXOvy-00030S-Qf for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2024 12:08:34 -0500 Received: from mail-yw1-x1134.google.com ([2607:f8b0:4864:20::1134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXOvx-0002XJ-7Y for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2024 12:08:34 -0500 Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-6002317a427so51191987b3.2 for ; Tue, 06 Feb 2024 09:08:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quatravaux-org.20230601.gappssmtp.com; s=20230601; t=1707239311; x=1707844111; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=IPCvNimqr7cAttpIkQIaIgIn+0NEfDTSpAv9xl7ZxcI=; b=Kq+k1Tb2MXc01H4z3jGRbVP2hA0lVuopREU95wU/ComDnta9+FMKfB/BZP/JShRIWf rxK6NASd3gRyEyxpHdu46kzdfZlV5LTUDF0Ee47wY0bdOasaaVatwNb76Ff+KgeQ+CYd e+hZLIKUfUl3IA4ZTvV+xpxYFKQPjJszkLvkZyNzbgLPuqmL8DSQpaiZif2cUKRvaBS0 7MrF4Chk65B5SKv7Qndd98+/TadWxdu2y9VpTgDsHwlTfV447T/ROcmArYFuby4eROpz ebnVTF361tAF0zBtr/cxhllaMpxvYzR0KldOqStUzveTgyz+Kl9PS5PSioNKCy+6OgSD xTxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707239311; x=1707844111; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IPCvNimqr7cAttpIkQIaIgIn+0NEfDTSpAv9xl7ZxcI=; b=Ob+oUeEi+oR2YojApAP6zaXEzKobfZ8DGQ1OZiQgFMJNRAa3i577piN6Zsm2ca1ygE CY14YcR8mhjcPtAJZGoDNCttlAv/I3FL9muAuA/YrzmrEaTTolbgEQX7LDMJNi6bYF+u c1UwYAybniddG46ITPVQY6DOy16bcmN3t3WE+fKeEGnXrO/xv57HWeFQQoJTRMEyRscM 0E/yK5+NPp5dKArz8ba9T9r52KEpXHGTIHYBxGZ3/U2f7SOaxaYEtpCADBca/mGDmGBZ qwknTfYaxIaiq5p+pxoR2FXcrbEa4o3xn5bJIu10MV14BHGXqdN8fBxzk+BXRc3ZJKQI PAhw== X-Gm-Message-State: AOJu0YyvWi5reongDuzB2kMZ9goPrS4cHqdE/H1dxwqlIacfxJht/rZu C4X43N4sEpk00OYhZzOGRg48jC+L2+lcSsfKw0GsHVcXNr/lmBB43BUTZBpCAZ+L7Aw+FQs9tG7 vPs3Q5j9xp2F2t6qtUPcc/0nwW5P4oB0P3ZeMO98u4OFgrsn6tQFFog== X-Google-Smtp-Source: AGHT+IFX2JtRrMgYcFuqcthFgRaHXBQD3Adw8OiyjwFK7YKWE4KdCnn4QVn32feTP6Py+DLYxk6NWib4JuYLa/GmCHY= X-Received: by 2002:a25:b81:0:b0:dc6:bafe:6a53 with SMTP id 123-20020a250b81000000b00dc6bafe6a53mr2102886ybl.4.1707239310752; Tue, 06 Feb 2024 09:08:30 -0800 (PST) MIME-Version: 1.0 From: Dominique Quatravaux Date: Tue, 6 Feb 2024 18:08:18 +0100 Message-ID: Subject: [PATCH] Crasher in treesit_traverse_get_predicate To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000aa4f4c0610b9a024" Received-SPF: none client-ip=2607:f8b0:4864:20::1134; envelope-from=dominique@quatravaux.org; helo=mail-yw1-x1134.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000aa4f4c0610b9a024 Content-Type: multipart/alternative; boundary="000000000000aa4f490610b9a022" --000000000000aa4f490610b9a022 Content-Type: text/plain; charset="UTF-8" Because nothing guarantees or enforces that either Vtreesit_thing_settings, or the cdrs of its elements, are cons cells, it is easy to construct values for `treesit-thing-settings' that make Emacs crash (e.g., when calling `prog-fill-reindent-defun' from any tree-sitter enabled mode). The attached patch fixes that. -- Dominique Quatravaux dominique@quatravaux.org --000000000000aa4f490610b9a022 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Because nothing guarantees or enforces that either Vt= reesit_thing_settings, or the cdrs of its elements, are cons cells, it is e= asy to construct values for `treesit-thing-settings' that make Emacs cr= ash (e.g., when calling `prog-fill-reindent-defun' from any tree-sitter= enabled mode).

The attached patch fixes that.

--
=C2=A0Dominique Quatravaux
=C2=A0dominique@quatravaux.org
--000000000000aa4f490610b9a022-- --000000000000aa4f4c0610b9a024 Content-Type: application/octet-stream; name="treesit.diff" Content-Disposition: attachment; filename="treesit.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lsam6n700 LS0tIHRyZWVzaXQuYy5vcmlnCTIwMjQtMDItMDYgMTg6MDE6MjMKKysrIHRyZWVzaXQuYwkyMDI0 LTAyLTA2IDE4OjAxOjQxCkBAIC0zMjY4LDExICszMjY4LDExIEBACiBzdGF0aWMgTGlzcF9PYmpl Y3QKIHRyZWVzaXRfdHJhdmVyc2VfZ2V0X3ByZWRpY2F0ZSAoTGlzcF9PYmplY3QgdGhpbmcsIExp c3BfT2JqZWN0IGxhbmd1YWdlKQogewotICBMaXNwX09iamVjdCBjb25zID0gYXNzcV9ub19xdWl0 IChsYW5ndWFnZSwgVnRyZWVzaXRfdGhpbmdfc2V0dGluZ3MpOworICBMaXNwX09iamVjdCBjb25z ID0gYXNzcV9ub19zaWduYWwgKGxhbmd1YWdlLCBWdHJlZXNpdF90aGluZ19zZXR0aW5ncyk7CiAg IGlmIChOSUxQIChjb25zKSkKICAgICByZXR1cm4gUW5pbDsKICAgTGlzcF9PYmplY3QgZGVmaW5p dGlvbnMgPSBYQ0RSIChjb25zKTsKLSAgTGlzcF9PYmplY3QgZW50cnkgPSBhc3NxX25vX3F1aXQg KHRoaW5nLCBkZWZpbml0aW9ucyk7CisgIExpc3BfT2JqZWN0IGVudHJ5ID0gYXNzcV9ub19zaWdu YWwgKHRoaW5nLCBkZWZpbml0aW9ucyk7CiAgIGlmIChOSUxQIChlbnRyeSkpCiAgICAgcmV0dXJu IFFuaWw7CiAgIC8qIEVOVFJZIGxvb2tzIGxpa2UgKFRISU5HIFBSRUQpLiAgKi8K --000000000000aa4f4c0610b9a024-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 06 12:15:37 2024 Received: (at 68954) by debbugs.gnu.org; 6 Feb 2024 17:15:37 +0000 Received: from localhost ([127.0.0.1]:55042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXP2m-00060Z-O0 for submit@debbugs.gnu.org; Tue, 06 Feb 2024 12:15:36 -0500 Received: from mail-oo1-xc2c.google.com ([2607:f8b0:4864:20::c2c]:55358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXP2k-00060F-Hl for 68954@debbugs.gnu.org; Tue, 06 Feb 2024 12:15:35 -0500 Received: by mail-oo1-xc2c.google.com with SMTP id 006d021491bc7-59883168a83so2957486eaf.2 for <68954@debbugs.gnu.org>; Tue, 06 Feb 2024 09:15:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quatravaux-org.20230601.gappssmtp.com; s=20230601; t=1707239715; x=1707844515; darn=debbugs.gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=tKAKwQzHEBkM8YCbMGXoUg2z7dXMVTC7VxPykonKoJo=; b=BoPNfkAqt2ivswZeu6IQ4sZztzoOThxK0VWANl88wrG1GFpRkufqTmUAF5Kct7w3IA 2+zZNwgRkmcM10hx8Cu9hJT+XQb9FIIX6jw5YLLZIc+chl8ZJ0kQ8Wg8EuBMEPaZI4Jy zntGTFCO6O0GDJHk/lRL3ffKBdKeXyjzNib1/EGTM+0Su4PGKA9NSBgrpF5wQXhEhnM1 lumCcYLoFJ6lz8Itjd0EGhpEqjbABv6GawnUqqmSBw4MjNZhwC05yFsvPUXpgGic4TV/ o+k5rWIYu/8DTv3ZhwbnjZywIoLPPxy54Qw2Fuad2Sxb5K4MwBx/5crK6rmK4IwTo6EG Vjbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707239715; x=1707844515; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=tKAKwQzHEBkM8YCbMGXoUg2z7dXMVTC7VxPykonKoJo=; b=h0liR4nxvBNhBYcZvQdScdXOI6U4dkEv1BmJIkYPh2y3WnDrN3y3EINzfmkSWQG8lw +q+A7FXE3GSY/T0wW1wqt7ncmOoJK//UI/EU7E7Lt4uQwIPgf8h/Mhv/kwZ+arYZuO2F 54f+R6TAdLsfI+3vFKpD4fggyEDJ4HILdKEqVp9xrgFe9v0SmDp5Xu2GM22W8+XLUsGm 7IHNGvNLt5TlQJw+zvKaYn9WTIoy29tb1EFN1I6Jl4CZM0+rXMd9igm260wcH1kqsjOl gzd38F2wZDRmHAxN9Men53JuQft9X548SuZUqRjxYNgXwJQT/HWUMIISdBahDB506wl9 ngQw== X-Gm-Message-State: AOJu0YxWGiTYrp3aVrMzyQG22t8NooaC76I02YqketqBRna6FJleX2Md Hg7Bp+LA/Xypsf8VX7liQ3DBSl1D5G8jutMb9p/DAYJguyZZPnDP5Y+gCCEKVPSaBGhAWX6iUZF Fk7c/XE/NDcrgZgh4vYNmt8V20lh3GnElg99OVGuAuV+S/kUrZS/FIg== X-Google-Smtp-Source: AGHT+IH8arR29F008x5U7gOQgkemE/POuEgj8apOikPvM9ABsQvGWGPzU9IOa+q47Cu5e6jbS0DH735PdXTgXmfgVLo= X-Received: by 2002:a05:6358:7e52:b0:176:a14c:544b with SMTP id p18-20020a0563587e5200b00176a14c544bmr190852rwm.11.1707239715523; Tue, 06 Feb 2024 09:15:15 -0800 (PST) MIME-Version: 1.0 From: Dominique Quatravaux Date: Tue, 6 Feb 2024 18:15:04 +0100 Message-ID: Subject: Offending commit To: 68954@debbugs.gnu.org Content-Type: multipart/alternative; boundary="000000000000ca653e0610b9b873" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68954 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000ca653e0610b9b873 Content-Type: text/plain; charset="UTF-8" https://github.com/emacs-mirror/emacs/commit/d005e685e1df7692085378633348db39a5190374 doesn't do what it says it does in the commit header, and is very likely the one that introduced the crash. -- Dominique Quatravaux dominique@quatravaux.org --000000000000ca653e0610b9b873 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
https://github.com/emacs-mirro= r/emacs/commit/d005e685e1df7692085378633348db39a5190374 doesn't do = what it says it does in the commit header, and is very likely the one that = introduced the crash.

--
=C2=A0Dominique Quatrava= ux
=C2=A0d= ominique@quatravaux.org
--000000000000ca653e0610b9b873-- From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 06 20:58:51 2024 Received: (at 68954) by debbugs.gnu.org; 7 Feb 2024 01:58:51 +0000 Received: from localhost ([127.0.0.1]:55458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXXD8-0006Vy-WF for submit@debbugs.gnu.org; Tue, 06 Feb 2024 20:58:51 -0500 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]:47535) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXXD7-0006Vf-Ud for 68954@debbugs.gnu.org; Tue, 06 Feb 2024 20:58:50 -0500 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-6e065e5f721so109558b3a.3 for <68954@debbugs.gnu.org>; Tue, 06 Feb 2024 17:58:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707271110; x=1707875910; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PH2TXdsqg0m19O8gNPIgIm2xsjtH8TB8fuiVnCujdbI=; b=S2EpwhxioLFvGchr98SQCIN4nzCHbJKCoOKjpVCDVh+0jBFHsVmYz/e8Feoxg21r2Z wYq7Cx36H3c5IF7LJIm35wfnieEjGxuqwL2OCw1XgNYr2cNbq9/xm0CycN/wcv5Y6YUI hXZP32xiJUT7u0LDPODkOTozRUEabdkKywywmY1CtgI80W6TQSd2X2uow/w73kI+Fm4f YAJgj31AQTu8jrt82xoozf8991s3mHgIDrB8nEStm+ITjiaZwKWG3HHt3fAk5Gu2YV26 Yl0ZFHMD9LmC+gT9J0SLzZVdfxhl02AqsUge8C9IV5upr3cvVgah+XCVH7ybZ50+FXr7 5uGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707271110; x=1707875910; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PH2TXdsqg0m19O8gNPIgIm2xsjtH8TB8fuiVnCujdbI=; b=ODcfnLVBxokI4/vDp6baNcYs9A6FOcbnZCIDDPMvq/CBVd4dvzq3iwysKjiXjNKJ7h 7spFxdB3V5QXFreSlZQU9cS7z4N1CqAvvXDyEttppTTm2jARwdcZGG5mR8Q2k6lmeAni lE9oz0+JOEcQ8l1LIigM1v2lnANsp0rjQ4Dq/lPBPKJolpQOJ1Tcu1oCs4WPjLBomVUc ShVJemqLlTNTKK8+nskvltc5jpDvQHuUHU+DBpKzVb6hp0IIxyLl0QulYCtvpQZp8guO LjvfSS9KWH+3xD1WMZYhF7wduTcM0uKu+eZyrDmUi8wQj4fqkVmrUjw/s3WZfkE4JdFW D8OA== X-Gm-Message-State: AOJu0Yz9AHyunws74Q2DllqR6XEtSyz1Hd2NnL1iKN98Ii6no7WijhT6 t/+Z85rAkgB3RZIJltYomjUnRJ4OOEOjw2JboevPAgEvL9r0OkCI X-Google-Smtp-Source: AGHT+IFKlCIWVdafePr5ohNpoCUt10hvENUweKw/EZHbow8sO9p5fuQU0McjuWRGrYfaps+vTuBpUg== X-Received: by 2002:a05:6a00:2fd4:b0:6de:1d04:c600 with SMTP id fn20-20020a056a002fd400b006de1d04c600mr1167121pfb.34.1707271110418; Tue, 06 Feb 2024 17:58:30 -0800 (PST) Received: from smtpclient.apple (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id f26-20020aa79d9a000000b006d638fd230bsm187892pfq.93.2024.02.06.17.58.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Feb 2024 17:58:29 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#68954: Offending commit From: Yuan Fu In-Reply-To: Date: Tue, 6 Feb 2024 17:58:18 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <24815EED-0F10-4EC9-B7EC-49C295B139D4@gmail.com> References: To: Dominique Quatravaux X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68954 Cc: 68954@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Feb 6, 2024, at 9:15 AM, Dominique Quatravaux = wrote: >=20 > = https://github.com/emacs-mirror/emacs/commit/d005e685e1df7692085378633348d= b39a5190374 doesn't do what it says it does in the commit header, and is = very likely the one that introduced the crash. Thanks! If you want to submit a patch I=E2=80=99m more than happy to = apply it for you (you don=E2=80=99t need to sign the copyright = assignment since it=E2=80=99s well under 15 LOC). Otherwise I can apply = the change myself. Also it=E2=80=99s a good idea to not change the email title, sometime = that might break threading in email clients. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 07 02:25:00 2024 Received: (at 68954) by debbugs.gnu.org; 7 Feb 2024 07:25:00 +0000 Received: from localhost ([127.0.0.1]:55617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXcIm-000756-9b for submit@debbugs.gnu.org; Wed, 07 Feb 2024 02:25:00 -0500 Received: from mail-yb1-xb2f.google.com ([2607:f8b0:4864:20::b2f]:42126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXcIk-00074r-FE for 68954@debbugs.gnu.org; Wed, 07 Feb 2024 02:24:59 -0500 Received: by mail-yb1-xb2f.google.com with SMTP id 3f1490d57ef6-dc6d8f31930so248152276.0 for <68954@debbugs.gnu.org>; Tue, 06 Feb 2024 23:24:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quatravaux-org.20230601.gappssmtp.com; s=20230601; t=1707290679; x=1707895479; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0J6FhdG8tmlO2yYdQGHzCnSrGfQl6qrjgFaAkapQGMQ=; b=qpKEDUECvH0R+Oq6t0VOYzZbk46j/KPYpHyb2fKUqjiCD7+I/WjEbHNu8D/Y4x4SlL 7YowL1uA2SKjFJLlW+u0sxL4v0+g5DkA8T6qoGD376Ptfw/+YzNrrQZwIzGf95dMZxO0 0sPnIrYXIHj8xm3AROS0GpooSyFkhxmhivufJZc8UKNidvlRdU3wEKzdiiVgOtAgsr+F n584jLhU20LRrAXF6RJ6KH3kEA0Od1GrPtQPppa/0HRzOBP9bF6dwxf2pQp6CKwWxi2T RYgulSuvP64phRmyftQoeB9twJHvNTntS9KtIaulCIM8f/mRkfZ2UBIRwR7nNUSSIQ1i C7cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707290679; x=1707895479; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0J6FhdG8tmlO2yYdQGHzCnSrGfQl6qrjgFaAkapQGMQ=; b=JBkUXCkeMUsN9nFMJWX15XCuLk/xjSrUWUkt2qx82sxzJLyxJWKMaJy8ojuUQAqDqn /k4is+aasRaxj30nx0a4bQAy/mKRPGw+tK1HyoKNADcbSNrAZS1M/v9yQux7n4zkQokP a1gL5yr07KQKdwv2x2T5pzmY/fyc5SWVcaDv+X1baRWBLKqsRq7AoF39Zgu1GubCpIS9 A+yNjrAMlWjnd9Fc8gh0kyNnUhv0HfN6J4bIy0qlJnYxtsiWNmet3/TVVQgmjRmR+OWu DA683NM3RJ2/dtyFAh1i4UE/u1egYled9so5XnP1IFpuKu9krBch30K2kXB/DDVdTGxP 4RHQ== X-Gm-Message-State: AOJu0YxTVB6n+EmlhGh+R5AWBpHeOsB8dC+S1RAdifh7ldem8xkzLfqW t5m512IMGmFJLaBE4X5FW3mNy9WfuRZhKH45896Lx5RnxWQX2bmNUahhrcxE88IS3uXft4nxEL5 NnV1X3IskJ6bpT77i0dSM5u9bNy9uVPLNgqzeZw== X-Google-Smtp-Source: AGHT+IG+LR9/K0hIecGbtGAeOJ4ofJUjxAAauIqB1XaXMyqXC1ZUuPZ/ySHs7RvhBBYwBky74v9YpfZKpf8PdIUelTU= X-Received: by 2002:a25:aba5:0:b0:dbe:d2ec:e31 with SMTP id v34-20020a25aba5000000b00dbed2ec0e31mr3097916ybi.27.1707290679088; Tue, 06 Feb 2024 23:24:39 -0800 (PST) MIME-Version: 1.0 References: <24815EED-0F10-4EC9-B7EC-49C295B139D4@gmail.com> In-Reply-To: <24815EED-0F10-4EC9-B7EC-49C295B139D4@gmail.com> From: Dominique Quatravaux Date: Wed, 7 Feb 2024 08:24:18 +0100 Message-ID: Subject: Re: bug#68954: Offending commit To: Yuan Fu Content-Type: multipart/alternative; boundary="00000000000074aac20610c596d1" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68954 Cc: 68954@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000074aac20610c596d1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le mer. 7 f=C3=A9vr. 2024 =C3=A0 02:58, Yuan Fu a =C3= =A9crit : Thanks! If you want to submit a patch I=E2=80=99m more than happy to apply = it for you I attached a patch to my first email already. Also it=E2=80=99s a good idea to not change the email title, sometime that = might break threading in email clients. Indeed, as can be seen right here with the patch! I'll be more careful next time. --=20 Dominique Quatravaux dominique@quatravaux.org --00000000000074aac20610c596d1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Le mer. 7 f=C3=A9vr. 2= 024 =C3=A0 02:58, Yuan Fu <casouri@= gmail.com> a =C3=A9crit=C2=A0:


Thanks! If you want to submit a patch I=E2=80=99m m= ore than happy to apply it for you

=
I attached a patch to my first email already.
=

Also it=E2=80=99s a good idea to not change the email title,= sometime that might break threading in email clients.

Indeed, as can be seen righ= t here with the patch! I'll be more careful next time.

-- Dominique Quatravaux
domin= ique@quatravaux.org


--00000000000074aac20610c596d1-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 07 20:36:18 2024 Received: (at 68954) by debbugs.gnu.org; 8 Feb 2024 01:36:18 +0000 Received: from localhost ([127.0.0.1]:58681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXtKs-0000jZ-3I for submit@debbugs.gnu.org; Wed, 07 Feb 2024 20:36:18 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:44450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXtKq-0000jJ-31 for 68954@debbugs.gnu.org; Wed, 07 Feb 2024 20:36:17 -0500 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1d932f6ccfaso11646555ad.1 for <68954@debbugs.gnu.org>; Wed, 07 Feb 2024 17:36:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707356156; x=1707960956; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4iV1x24v/Z9zJUGLkL/pbnPT4tjyaOx57LRe5xTs//M=; b=gyhNYIIa03C68Njt6fqipd81MeKCyz9uW85P/tMeasl3p4PK4+eWiZOWSDsvbL6n+m WhaDpW6Eo/CCzpoHLnsIeV1QbVk6E9gjVxntQsUXhG8ipOTwyZxTOleRAIB8JlSU99vo xbZYBSjWT35hphzEXdzvHhwzjmljdRzxfQr07Vr5Bdc4Kd34p6jFdjSQoJMKgaRDTiZL 9Ty7+xih31cQxus9mgdM/F82Hy7tgWBT+IK9mhSUoDhtY7t+vXjKB/KArGAG0G91f8NX uIIwIG1MmK2O2GkmquU4jSjyQKzypkeeXKGKLTEJWk8ucqMyaOYQ/9wZ2ghyz3XMAm43 zVrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707356156; x=1707960956; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4iV1x24v/Z9zJUGLkL/pbnPT4tjyaOx57LRe5xTs//M=; b=KFMCpAXpcWfN/OlcC5DdKonvmL8gtakKyIdH8eu+KyWS86KNCRnkjfxri36i1INh6Z n4HSz6EsmAzJJ/Mh7lOS4lNUGtOo+8bW8nC+5GV7dgwaxDheoeNj9hKk8QqOCLjLsGd7 vHf0wXwPM/waP4TGe1KUxAe5NF2xIr20F7XTAeRw8RcoE+e95IOI7l+DScgELlzuPk8T 2lj9/GDcy0DoVztqDxoIzZiiCU1Ro3nizHf6nBgNXMoYw4sRbcVOa/E5zTYEYC7KyZI1 183Ju+hblIHS17wyVsw9ID/FInVOtTItzPtC/MxYIp3+paytz0vGGZbax+kUKXc6LL0K cPjw== X-Gm-Message-State: AOJu0Ywti3ZX/R8Qjn7f+1jhPhSui3DptEBm5FlF5eANrCZs5BrEcHaf oE7a5cb6FOHcVtiurxWC0uFsWf92a5jdxBJDT/91FS5LsHeowMft X-Google-Smtp-Source: AGHT+IHJXXs2tDj+x+pR42vwNPfs+uC7o+MS/9zT7nWI6U9VnAlnqE5KFJo36iG95ll5LiboV0M/Dg== X-Received: by 2002:a17:903:25d3:b0:1d9:9c67:58f4 with SMTP id jc19-20020a17090325d300b001d99c6758f4mr5677734plb.52.1707356155821; Wed, 07 Feb 2024 17:35:55 -0800 (PST) Received: from smtpclient.apple ([2600:1700:42c1:a5f0:9078:deba:b479:939]) by smtp.gmail.com with ESMTPSA id ko7-20020a17090307c700b001d96a0cddccsm2128021plb.296.2024.02.07.17.35.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 07 Feb 2024 17:35:55 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#68954: Offending commit From: Yuan Fu In-Reply-To: Date: Wed, 7 Feb 2024 17:35:44 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <55B46203-821D-40CF-86CD-19C4481B4DFC@gmail.com> References: <24815EED-0F10-4EC9-B7EC-49C295B139D4@gmail.com> To: Dominique Quatravaux X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68954 Cc: 68954@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Feb 6, 2024, at 11:24 PM, Dominique Quatravaux = wrote: >=20 > Le mer. 7 f=C3=A9vr. 2024 =C3=A0 02:58, Yuan Fu a = =C3=A9crit : >=20 >=20 > Thanks! If you want to submit a patch I=E2=80=99m more than happy to = apply it for you >=20 > I attached a patch to my first email already. My bad, I wasn=E2=80=99t clear enough. I meant a patch generated by git = format-patch, which includes a commit message, etc. This way when I = apply it it=E2=80=99ll show your as the author. If you don=E2=80=99t = care about it, I can apply the diff myself and push it. Btw, there=E2=80=99s a specific format for commit messages, you can = check out the CONTRIBUTE file under repo root, in the =E2=80=9CCommit = messages=E2=80=9D section. Actually, here=E2=80=99s what I would write for your change, feel free = to modify it as you like. Fix treesit_traverse_get_predicate (bug#68954) Commit d005e685e1df7692085378633348db39a5190374 should have replaced assq_no_quit with assq_no_signal, but didn't, this commit fixes that. * src/treesit.c (treesit_traverse_get_predicate): Replace assq_no_quit with assq_no_signal. Yuan= From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 08 04:36:39 2024 Received: (at 68954) by debbugs.gnu.org; 8 Feb 2024 09:36:39 +0000 Received: from localhost ([127.0.0.1]:59062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rY0pj-0006G7-AX for submit@debbugs.gnu.org; Thu, 08 Feb 2024 04:36:39 -0500 Received: from mail-yw1-x1135.google.com ([2607:f8b0:4864:20::1135]:48153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rY0ph-0006FF-7z for 68954@debbugs.gnu.org; Thu, 08 Feb 2024 04:36:37 -0500 Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-604a1d2b54eso7698737b3.0 for <68954@debbugs.gnu.org>; Thu, 08 Feb 2024 01:36:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quatravaux-org.20230601.gappssmtp.com; s=20230601; t=1707384977; x=1707989777; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0BoNntQjJoXrbUsGPpxIA3TLuTX1xrQ5GFR8AYAFqUw=; b=xoq55jqLXpdvd1xldjeXS4Oj/y1+yVPg8mtXqNNXUqfj2FMjZVyD28gYIevRIAeKDP CzLJ3A/uZJ+XzRCLZP/6pDVUgmZLumuq41zk2YRhtLz/4bQXx41hVP+mruT0cUyJUjcm htMAmwzuYD7tGL0Pn/fEAhNozEKNOxNkppHY2O7jeh9WeN8fGve6l1PpPEZhwErq6iIR VqBmruhOfh1R0rAkg87OiKVmxYABlOEykbKH7OFcV5VGCxV2/Q1dosTiPveD+UckEdrv r+uvkVFtPHZ5S7Gu7kc2pHraiOPIUQLVnv/A+7tp9FSwy1axBeABvBIWXlqRf/73qAPU 3PCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707384977; x=1707989777; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0BoNntQjJoXrbUsGPpxIA3TLuTX1xrQ5GFR8AYAFqUw=; b=vIqlHHdSJ/P/QsLJ7E/zpPD/nyj4YcKtUZNnYoYyOR5+DjvBqBX0y0ODRIpBBCI4H/ QJaZzIAsa3jeLBIFpgtbk8OZLK2/Q/1c4veDid0X9BqTqdTDd9cwsRU9FdviwL+GN4s6 mVb5kOa76Yl5mwOk1kQM1ZMUP4TdnMedmMSy5K7drVABbTIedFm3vMDDLOFUlFg89a0I EJbVLxH6TV5igHTW3lkVuO4h4ae5oxf10Pb9EYWRtldI1ZvP2zM9c9SqLutPkqzgQnIS +BkPxuIss7tceV7U0fF7N61Zj7eVoMNra3nE2GSZHPbO0Wz7Sdy3xlcZKATqhCiirQVg rq4w== X-Gm-Message-State: AOJu0YzuoD+Jzsfzar2NHfu5WC9EDAeoL3QJaNuG7fMXof7Lg2qL0dd5 FiEgBoMal/ga52AXCzozkWn2m19jQAiiRSbbg7rCCAcL020Vu1Z92tqiGss8Ilyy53f1ld9nohH Y3WZsyjVB+0nYcuC0c3eRpaXfUaJm2qMCodyYxw== X-Google-Smtp-Source: AGHT+IFbVE1lONfoRaYrEzBAvMGwWTRqkGauunxSeP4A3+NSTwCmdfZepYQ8fEOaa7G9yutHnMl0+dpKtDRKC6EOTQA= X-Received: by 2002:a81:ed0c:0:b0:5ff:6319:6b0e with SMTP id k12-20020a81ed0c000000b005ff63196b0emr7540464ywm.21.1707384977068; Thu, 08 Feb 2024 01:36:17 -0800 (PST) MIME-Version: 1.0 References: <24815EED-0F10-4EC9-B7EC-49C295B139D4@gmail.com> <55B46203-821D-40CF-86CD-19C4481B4DFC@gmail.com> In-Reply-To: <55B46203-821D-40CF-86CD-19C4481B4DFC@gmail.com> From: Dominique Quatravaux Date: Thu, 8 Feb 2024 10:36:05 +0100 Message-ID: Subject: Re: bug#68954: Offending commit To: Yuan Fu Content-Type: multipart/mixed; boundary="0000000000000ddaf60610db8b1f" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68954 Cc: 68954@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000000ddaf60610db8b1f Content-Type: multipart/alternative; boundary="0000000000000ddaf50610db8b1d" --0000000000000ddaf50610db8b1d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Le jeu. 8 f=C3=A9vr. 2024 =C3=A0 02:35, Yuan Fu a =C3= =A9crit : > > > Actually, here=E2=80=99s what I would write for your change, feel free to= modify > it as you like. > > Many thanks for the step-by-step instructions! Attached is what `git format-patch` gave me, I hope that I got everything right. Yours truly, -- Dominique Quatravaux dominique@quatravaux.org --0000000000000ddaf50610db8b1d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
Le=C2=A0jeu. 8 f=C3=A9vr. 2024 =C3=A0= =C2=A002:35, Yuan Fu <casouri@gmail= .com> a =C3=A9crit=C2=A0:


Actually, here=E2=80=99s what I would write for your change, feel free to m= odify it as you like.


Many thanks for the step-by-step instr= uctions! Attached is what `git format-patch` gave me, I hope that I got eve= rything right.

Yours truly,
=C2=A0
--
=C2=A0Domini= que Quatravaux
=C2=A0dominique@quatravaux.org
--0000000000000ddaf50610db8b1d-- --0000000000000ddaf60610db8b1f Content-Type: application/octet-stream; name="0001-Fix-treesit_traverse_get_predicate-bug-68954.patch" Content-Disposition: attachment; filename="0001-Fix-treesit_traverse_get_predicate-bug-68954.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lsd0x7x10 RnJvbSAwZWI2YzAyYjNmMTZiNDU2NzA1M2I3NDc2MDM5YjBmYmY2YTBmNTVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBEb21pbmlxdWUgUXVhdHJhdmF1eCA8ZG9taW5pcXVlLnF1YXRy YXZhdXhAZXBmbC5jaD4KRGF0ZTogVGh1LCA4IEZlYiAyMDI0IDEwOjE5OjEwICswMTAwClN1Ympl Y3Q6IFtQQVRDSF0gRml4IHRyZWVzaXRfdHJhdmVyc2VfZ2V0X3ByZWRpY2F0ZSAoYnVnIzY4OTU0 KQoKQ29tbWl0IGQwMDVlNjg1ZTFkZjc2OTIwODUzNzg2MzMzNDhkYjM5YTUxOTAzNzQgc2hvdWxk IGhhdmUgcmVwbGFjZWQKYXNzcV9ub19xdWl0IHdpdGggYXNzcV9ub19zaWduYWwsIGJ1dCBkaWRu J3QsIHRoaXMgY29tbWl0IGZpeGVzIHRoYXQuCgoqIHNyYy90cmVlc2l0LmMgKHRyZWVzaXRfdHJh dmVyc2VfZ2V0X3ByZWRpY2F0ZSk6IFJlcGxhY2UgYXNzcV9ub19xdWl0CndpdGggYXNzcV9ub19z aWduYWwuCgpDb3B5cmlnaHQtcGFwZXJ3b3JrLWV4ZW1wdDogeWVzCi0tLQogc3JjL3RyZWVzaXQu YyB8IDQgKystLQogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9zcmMvdHJlZXNpdC5jIGIvc3JjL3RyZWVzaXQuYwppbmRleCA2OWI1 OWZjYTExMS4uYWVjZTNhNzcyOGUgMTAwNjQ0Ci0tLSBhL3NyYy90cmVlc2l0LmMKKysrIGIvc3Jj L3RyZWVzaXQuYwpAQCAtMzI2OCwxMSArMzI2OCwxMSBAQCB0cmVlc2l0X3RyYXZlcnNlX2NoaWxk X2hlbHBlciAoVFNUcmVlQ3Vyc29yICpjdXJzb3IsCiBzdGF0aWMgTGlzcF9PYmplY3QKIHRyZWVz aXRfdHJhdmVyc2VfZ2V0X3ByZWRpY2F0ZSAoTGlzcF9PYmplY3QgdGhpbmcsIExpc3BfT2JqZWN0 IGxhbmd1YWdlKQogewotICBMaXNwX09iamVjdCBjb25zID0gYXNzcV9ub19xdWl0IChsYW5ndWFn ZSwgVnRyZWVzaXRfdGhpbmdfc2V0dGluZ3MpOworICBMaXNwX09iamVjdCBjb25zID0gYXNzcV9u b19zaWduYWwgKGxhbmd1YWdlLCBWdHJlZXNpdF90aGluZ19zZXR0aW5ncyk7CiAgIGlmIChOSUxQ IChjb25zKSkKICAgICByZXR1cm4gUW5pbDsKICAgTGlzcF9PYmplY3QgZGVmaW5pdGlvbnMgPSBY Q0RSIChjb25zKTsKLSAgTGlzcF9PYmplY3QgZW50cnkgPSBhc3NxX25vX3F1aXQgKHRoaW5nLCBk ZWZpbml0aW9ucyk7CisgIExpc3BfT2JqZWN0IGVudHJ5ID0gYXNzcV9ub19zaWduYWwgKHRoaW5n LCBkZWZpbml0aW9ucyk7CiAgIGlmIChOSUxQIChlbnRyeSkpCiAgICAgcmV0dXJuIFFuaWw7CiAg IC8qIEVOVFJZIGxvb2tzIGxpa2UgKFRISU5HIFBSRUQpLiAgKi8KLS0gCjIuNDMuMAoK --0000000000000ddaf60610db8b1f-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 09 00:28:19 2024 Received: (at 68954-done) by debbugs.gnu.org; 9 Feb 2024 05:28:19 +0000 Received: from localhost ([127.0.0.1]:34911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYJQx-0002GY-E5 for submit@debbugs.gnu.org; Fri, 09 Feb 2024 00:28:19 -0500 Received: from mail-oa1-x2b.google.com ([2001:4860:4864:20::2b]:48409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYJQu-0002GC-EY for 68954-done@debbugs.gnu.org; Fri, 09 Feb 2024 00:28:17 -0500 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-206689895bfso337602fac.1 for <68954-done@debbugs.gnu.org>; Thu, 08 Feb 2024 21:28:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707456476; x=1708061276; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zDqjTuZwwd2o65gJ7DgfWHw1cLzqgMpg3muYjSPD4pI=; b=JjCsfEVJYSqrZurMcYOVNlE5MgvtjORwU4bZ6Cp5cLNIegSvXfIEzZgalS9uzAepI0 aOSj2H/ON0s7sO6xPxVit6hqqcyO/XewHT9UDm3tNM2WN9ZFEpZQGidw8su7krVAMXAd czvfTZy6oyNr8GnULUpzmPqnkA3lnQNPQouSJC158PYT1K71+CkUBTfp+oFkNs8aS//y t1eGXmNT8q1CfoxyUvOn6NPOaMPlK22+sgeXuFbaXRmh42vn2vNCfdIbn3xhiBW1TXIT 5a78QedP1p5tNtDcwgg4NJsRVHjxYwU6KVcqBqPDPS7sTbYjg1N9EeedWG0O5hW8GBVW tydA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707456476; x=1708061276; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zDqjTuZwwd2o65gJ7DgfWHw1cLzqgMpg3muYjSPD4pI=; b=XsDF8S8dR1RV9ZdPrIw/mvKSyoWrfk73rGjhEP3kq6yYaxC2gyl6z9q5irE9C9zkZu WpauT+GOrQebBRfXhA22CkH1fXND3hB2GHL2aDs8DwPqFKApel2qTdlR896xQq1GnC6S KEM3rY6Io8gnKD7eIErB6AgUxf5dI6z72vdsVpycxRCstw1SPSyFHkqsbgN+D+WX+kQy OuPIRn5EiA7cRZC/rPZsMJ8Z9i5wVReU5Y7ql/3dcOGwKO1U355ezf2wc83bHWNNLVOp 6LakVaw5M2LuatWV5CmL6UDwlvSFOfkOCeUIDxkKOFXCiLN05zJ3iWXDEHhQndHJLR/S 3tAA== X-Gm-Message-State: AOJu0Yw4Svpby26chq2Y4xlKru/2whk1bs5Dx7bLvbxZ/98IHJ+DXTsr 9jf+78iSZDy1Ed5Rn15LHqtKqqNyii+Vp+NfWBFFzi0lIEGYeRYh X-Google-Smtp-Source: AGHT+IFeBIEQ7KaFkhYNtSC8KXwJHOlgTZjiEviA3Emiw19juu3DpnckyZysWzddSC/xJFLmpsLiJw== X-Received: by 2002:a05:6870:7010:b0:219:c77e:db7d with SMTP id u16-20020a056870701000b00219c77edb7dmr638186oae.18.1707456475588; Thu, 08 Feb 2024 21:27:55 -0800 (PST) Received: from smtpclient.apple (172-117-161-177.res.spectrum.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id p20-20020a635b14000000b005d6c208fbd2sm823736pgb.35.2024.02.08.21.27.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Feb 2024 21:27:55 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: bug#68954: Offending commit From: Yuan Fu In-Reply-To: Date: Thu, 8 Feb 2024 21:27:43 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <90A203CD-DC72-4C5D-B64C-21C036B4B1FD@gmail.com> References: <24815EED-0F10-4EC9-B7EC-49C295B139D4@gmail.com> <55B46203-821D-40CF-86CD-19C4481B4DFC@gmail.com> To: Dominique Quatravaux X-Mailer: Apple Mail (2.3731.700.6) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68954-done Cc: 68954-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Feb 8, 2024, at 1:36 AM, Dominique Quatravaux = wrote: >=20 >=20 >=20 > Le jeu. 8 f=C3=A9vr. 2024 =C3=A0 02:35, Yuan Fu a = =C3=A9crit : >=20 >=20 > Actually, here=E2=80=99s what I would write for your change, feel free = to modify it as you like. >=20 >=20 > Many thanks for the step-by-step instructions! Attached is what `git = format-patch` gave me, I hope that I got everything right. >=20 > Yours truly, > =20 Great! Merged to master. Closing this. I also recommend you start your = copyright assignment process, in case you contribute more in the future. = You can ask for the from and instructions on emacs-devel, or just CC Eli = (eliz@gnu.org) in this thread and ask him to send you one. Yuan= From unknown Thu Sep 11 16:22:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 08 Mar 2024 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator