From unknown Mon Jun 16 23:29:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68949: [PATCH] Optionally show internal buffers in Buffer Menu mode Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Feb 2024 12:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 68949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 68949@debbugs.gnu.org X-Debbugs-Original-To: Emacs Bug Report Received: via spool by submit@debbugs.gnu.org id=B.170722230112799 (code B ref -1); Tue, 06 Feb 2024 12:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 6 Feb 2024 12:25:01 +0000 Received: from localhost ([127.0.0.1]:53345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXKVZ-0003KN-ER for submit@debbugs.gnu.org; Tue, 06 Feb 2024 07:25:01 -0500 Received: from lists.gnu.org ([2001:470:142::17]:42708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXKVX-0003KA-QV for submit@debbugs.gnu.org; Tue, 06 Feb 2024 07:25:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXKVF-0005GC-Cy for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2024 07:24:41 -0500 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXKVA-0002NI-Bz for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2024 07:24:41 -0500 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-51032e62171so8935805e87.3 for ; Tue, 06 Feb 2024 04:24:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707222272; x=1707827072; darn=gnu.org; h=to:date:message-id:subject:mime-version:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=yT1JTIHdB8a9uwqpActBVpkM6oYC93a6IfgIhVMjPjs=; b=OaEi3VFMii6WT/mfmpmnrilsMjvxYgnRf+ClK49jjSGbeqFNN7fMXt6wZrtQB0L9PV jd3zxUc4YoLr27cSpVAcEJASFywmNO3/2968qo5JUWjA/M6K8LS5ci+rg/5NWfHfKyjF pPZxarQqYmN9OfbmllKca6YJjiGJk4m3hpefmHOlfN8y294YI41PgV/W4CpBP3GPGOpD inysRQXCmHGtfebp3M8s01bu0bSXL5GHyUTWshd91pMCvd3Zk+PEM7JLpq4wsgvIZS32 bpIrJ5OnpbHipN/70quKUoqQS/gXiCJIbEc0V9nXnLaMFB9jqs/ywXnLTQr+IOUBGd0H G4fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707222272; x=1707827072; h=to:date:message-id:subject:mime-version:from:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yT1JTIHdB8a9uwqpActBVpkM6oYC93a6IfgIhVMjPjs=; b=T98jsfVl2QHG1EXhp5+OIDtYZcd8AckpTvwKp/BHQhW2xGVpm1rarf2icA99gBhcKW lfEu3lCMqyYx9VsBHQGpLkrM7drjt9FtiJvoYfPeX2+MEc1KHHnN6iNYVml6s/vZG1dD WzEnx+Sz1yKl3hewio0qRCkluSx0uHiEYQIp8IVAuNBNxnq/uuhoTybMJDUtqD1ZtWKs rsZOJXeMRk6cJXX6Hdg6gSxy1VV56sILw9w1R8MpYR4qvi7ga+ilcv8WZKSMwqF00IvM dGM5aSn453wHT+pdc5dRsSAsJHBtYaz0Wl3ThrQYjh1ZNaq3TfJWS2DAeVWy6z1vBSgC uuyw== X-Gm-Message-State: AOJu0Yw9b53lUa7g8q9mPO0EvXijxMWB0/GsHLP1DDPCCBEf/oFWcAk2 +wbTcfR1RgDak0giWsaVdseEZmsKGo4XaLur5eEpsaHIaokZ4VQDaksZEDMV X-Google-Smtp-Source: AGHT+IHbogfNJ0L9Yd2u3f2k+vvVG8M7IeKtmk75M93siaWVmce+qG7BA2qYXwdhuhX9MGMe5HLaig== X-Received: by 2002:a05:6512:33cc:b0:50e:a789:dd3b with SMTP id d12-20020a05651233cc00b0050ea789dd3bmr2058628lfg.1.1707222271595; Tue, 06 Feb 2024 04:24:31 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id q15-20020ac2528f000000b005113fa5be95sm225060lfm.85.2024.02.06.04.24.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Feb 2024 04:24:31 -0800 (PST) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_9A2D58F5-9651-4253-9693-29A1524396B4" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Message-Id: <0390E086-FAEF-4012-AF03-F115B125C1A2@gmail.com> Date: Tue, 6 Feb 2024 13:24:30 +0100 X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::12d; envelope-from=mattias.engdegard@gmail.com; helo=mail-lf1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_9A2D58F5-9651-4253-9693-29A1524396B4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii `list-buffers` (C-x C-b) never shows internal buffers but it would = sometimes be very useful if it did. This patch adds a toggle. --Apple-Mail=_9A2D58F5-9651-4253-9693-29A1524396B4 Content-Disposition: attachment; filename=buff-menu-show-internal.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="buff-menu-show-internal.diff" Content-Transfer-Encoding: 7bit diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index 5796544c534..512ee608edb 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -100,6 +100,10 @@ Buffer-menu-files-only This is set by the prefix argument to `buffer-menu' and related commands.") +(defvar-local Buffer-menu-show-internal nil + "Non-nil if the current Buffer Menu lists internal buffers. +Internal buffers are those whose name start with a space.") + (defvar-local Buffer-menu-filter-predicate nil "Function to filter out buffers in the buffer list. Buffers that don't satisfy the predicate will be skipped. @@ -140,6 +144,7 @@ Buffer-menu-mode-map "V" #'Buffer-menu-view "O" #'Buffer-menu-view-other-window "T" #'Buffer-menu-toggle-files-only + "I" #'Buffer-menu-toggle-internal "M-s a C-s" #'Buffer-menu-isearch-buffers "M-s a C-M-s" #'Buffer-menu-isearch-buffers-regexp "M-s a C-o" #'Buffer-menu-multi-occur @@ -197,6 +202,10 @@ Buffer-menu-mode-menu :help "Toggle whether the current buffer-menu displays only file buffers" :style toggle :selected Buffer-menu-files-only] + ["Show Internal Buffers" Buffer-menu-toggle-internal + :help "Toggle whether the current buffer-menu displays internal buffers" + :style toggle + :selected Buffer-menu-show-internal] "---" ["Refresh" revert-buffer :help "Refresh the *Buffer List* buffer contents"] @@ -317,6 +326,11 @@ list-buffers (interactive "P") (display-buffer (list-buffers-noselect arg))) +(defun Buffer-menu--selection-message () + (message (cond (Buffer-menu-files-only "Showing only file-visiting buffers.") + (Buffer-menu-show-internal "Showing all buffers.") + (t "Showing all non-internal buffers.")))) + (defun Buffer-menu-toggle-files-only (arg) "Toggle whether the current `buffer-menu' displays only file buffers. With a positive ARG, display only file buffers. With zero or @@ -325,9 +339,18 @@ Buffer-menu-toggle-files-only (setq Buffer-menu-files-only (cond ((not arg) (not Buffer-menu-files-only)) ((> (prefix-numeric-value arg) 0) t))) - (message (if Buffer-menu-files-only - "Showing only file-visiting buffers." - "Showing all non-internal buffers.")) + (Buffer-menu--selection-message) + (revert-buffer)) + +(defun Buffer-menu-toggle-internal (arg) + "Toggle whether the current `buffer-menu' displays internal buffers. +With a positive ARG, display non-internal buffers only. With zero or +negative ARG, display internal buffers as well." + (interactive "P" Buffer-menu-mode) + (setq Buffer-menu-show-internal + (cond ((not arg) (not Buffer-menu-show-internal)) + ((> (prefix-numeric-value arg) 0) t))) + (Buffer-menu--selection-message) (revert-buffer)) (define-obsolete-function-alias 'Buffer-menu-sort 'tabulated-list-sort @@ -667,6 +690,7 @@ list-buffers--refresh (marked-buffers (Buffer-menu-marked-buffers)) (buffer-menu-buffer (current-buffer)) (show-non-file (not Buffer-menu-files-only)) + (show-internal Buffer-menu-show-internal) (filter-predicate (and (functionp Buffer-menu-filter-predicate) Buffer-menu-filter-predicate)) entries name-width) @@ -686,7 +710,8 @@ list-buffers--refresh (file buffer-file-name)) (when (and (buffer-live-p buffer) (or buffer-list - (and (or (not (string= (substring name 0 1) " ")) + (and (or show-internal + (not (string= (substring name 0 1) " ")) file) (not (eq buffer buffer-menu-buffer)) (or file show-non-file) --Apple-Mail=_9A2D58F5-9651-4253-9693-29A1524396B4-- From unknown Mon Jun 16 23:29:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68949: [PATCH] Optionally show internal buffers in Buffer Menu mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Feb 2024 12:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 68949@debbugs.gnu.org Received: via spool by 68949-submit@debbugs.gnu.org id=B68949.170722341425097 (code B ref 68949); Tue, 06 Feb 2024 12:44:01 +0000 Received: (at 68949) by debbugs.gnu.org; 6 Feb 2024 12:43:34 +0000 Received: from localhost ([127.0.0.1]:53368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXKnW-0006Wi-EU for submit@debbugs.gnu.org; Tue, 06 Feb 2024 07:43:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59564) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXKnU-0006WQ-7i for 68949@debbugs.gnu.org; Tue, 06 Feb 2024 07:43:32 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXKnB-0006GW-K6; Tue, 06 Feb 2024 07:43:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=o3yM3Z6tM3K79Uug8p59k4+nH8F7Ie9FrhxSFPuTSkU=; b=Ir44Gy8UB7+6mXxhQ8vW kv366wGbMrKWs7lvGSzJLfojUkGuNv8m/NJ2prIb71oBsyJvPoe5cyjh7yTEunaCrfkdeBHsYkZeY BMbibPti1yaJVp0Id6LgfjNTvktCPEiYhrGRjrgcFK7DwBMBjAR4Xvuz83YXm5YHaabgqkrfqTpEQ WQgrM1HQ0+c6oWgeU3mem/1aBWnKGP5jwe6A3gftXxqpPANDinkhnT13BYz1c+7HihcRx+lmLcV+D xcnzJdtG5igDSVqNeTH0NgKJ0QIz7QUt8b/PHfQBB432Oz+VsSO2bw4E9VXbEG5fKp/A+nJiaaqpP AnMtIsl0glsb0A==; Date: Tue, 06 Feb 2024 14:43:10 +0200 Message-Id: <86zfwdzrtt.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <0390E086-FAEF-4012-AF03-F115B125C1A2@gmail.com> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Tue, 6 Feb 2024 13:24:30 +0100) References: <0390E086-FAEF-4012-AF03-F115B125C1A2@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Tue, 6 Feb 2024 13:24:30 +0100 > > `list-buffers` (C-x C-b) never shows internal buffers but it would sometimes be very useful if it did. > This patch adds a toggle. Thanks. Would a special value of prefix argument be better, perhaps? Like in "C-u 0 C-x C-b"? Or maybe in addition to the toggle you suggest? In any case, this should be in NEWS and perhaps also in the user manual. From unknown Mon Jun 16 23:29:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68949: [PATCH] Optionally show internal buffers in Buffer Menu mode Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Feb 2024 12:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 68949@debbugs.gnu.org Received: via spool by 68949-submit@debbugs.gnu.org id=B68949.170722410526708 (code B ref 68949); Tue, 06 Feb 2024 12:56:02 +0000 Received: (at 68949) by debbugs.gnu.org; 6 Feb 2024 12:55:05 +0000 Received: from localhost ([127.0.0.1]:53377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXKyf-0006wh-1b for submit@debbugs.gnu.org; Tue, 06 Feb 2024 07:55:05 -0500 Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:59772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXKyc-0006wA-Rx for 68949@debbugs.gnu.org; Tue, 06 Feb 2024 07:55:03 -0500 Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-51124e08565so8582941e87.3 for <68949@debbugs.gnu.org>; Tue, 06 Feb 2024 04:54:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707224083; x=1707828883; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=FR7CwKTnili9Mv/sRBQ8IXu5y6igc2nSlwI5ZXUZHQE=; b=EFj0Bd5+Q+NX/g/MLn+QV6ZStmHJgBkSFE6Lk3wijI9O/3vjFzmCGFhEw/AJ40NhYt r0+rSXZRKvam4/CIcGb56BGM8OrJ1+wr4WqsuC59jaTrEv3LGYE0/BbHf57Hb/lzQa2t iUabQ2fZ2wLP3+bo04iUoWonMs8xBsdu30Gqu8kUzVl8ASCZ55/vjU2kSwCQie7IaWXr Oh3seYqBCBoOk2SL3Eh9+0yCIPHuJQkKJfyu35MOJR1M+ssnXTWkSM+2k1+a2fU44K58 Wc9d5OTQvkccxxjQ1UMYuc1HrWQ7QSPyYmifa66XQH14pEXQ5sHqyy/+5YTKu9+RLTYH 8STg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707224083; x=1707828883; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=FR7CwKTnili9Mv/sRBQ8IXu5y6igc2nSlwI5ZXUZHQE=; b=hbYw/f+hMEMzDVy61EwwjL7shYEJj+6lCWYFBQyl23JiKDiC7MmUmKkxsMSlvHANZo O1aE2wjEfuWU2/siFtX9qFPfonjSGNB9uK3hcjsNIfYQkiJOebNqAlgQlCjEGQszSQ88 S9sks7z5FGAaYk+wZretSFCzo5lAvT7rLrwCZl2789pA5kQo9fcZPYpiG/tZul23TcfL J1K12C1BhjSWEVua5NFYC0hpwNiuCfOaTdtjgnYrOGA+wvC4l13DQFjcUGCBDpsgjfro je2gf5An2RuoYG6zzXmqZqMTBfNf+lxoWWiQuR76z0i2nu48iwmqAMe8BSrDt2EPQpS0 kmGw== X-Gm-Message-State: AOJu0YxCDZhkZqxEx9yP30S6DkAxoYvT4G/JnCVI3f8vUZOKnlEkbGeG UMgKfaMpwRZ2+jD+sBH8u8iqEvz2NMylEN7ZRio1L2kwkjuAOMAc X-Google-Smtp-Source: AGHT+IHm+vtZq8wCKIZDAFvuW59l2b3RBnWV5dzHHhSLcX2OwPYWqa+cGtXF7sh+++2xYao8RvoQlg== X-Received: by 2002:a05:6512:3987:b0:511:5f38:76e with SMTP id j7-20020a056512398700b005115f38076emr1446462lfu.1.1707224083063; Tue, 06 Feb 2024 04:54:43 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id g11-20020a0565123b8b00b005110fb4ba01sm231166lfv.182.2024.02.06.04.54.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Feb 2024 04:54:42 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <86zfwdzrtt.fsf@gnu.org> Date: Tue, 6 Feb 2024 13:54:41 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <06D6EF41-2C92-49E7-83C1-89F48A09F6F3@gmail.com> References: <0390E086-FAEF-4012-AF03-F115B125C1A2@gmail.com> <86zfwdzrtt.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 6 feb. 2024 kl. 13.43 skrev Eli Zaretskii : > Would a special value of prefix argument be better, perhaps? Like in > "C-u 0 C-x C-b"? Or maybe in addition to the toggle you suggest? It wouldn't help usability for myself because I find it a lot more = natural to toggle after displaying than remembering a particular prefix, = but if someone prefers the prefix then I'm happy to let them add it. > In any case, this should be in NEWS and perhaps also in the user > manual. I've written a NEWS entry, but I'm not sure it belongs in the user = manual since it's mainly of interest to Elisp programmers. It's = well-visible in the menu, however. Thanks for looking at it! I'm pushing it to master now; we can amend it = as necessary. From unknown Mon Jun 16 23:29:29 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Subject: bug#68949: closed (Re: bug#68949: [PATCH] Optionally show internal buffers in Buffer Menu mode) Message-ID: References: <14AD2714-03AD-4C5B-A8C2-9EE36180F291@gmail.com> <0390E086-FAEF-4012-AF03-F115B125C1A2@gmail.com> X-Gnu-PR-Message: they-closed 68949 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 68949@debbugs.gnu.org Date: Tue, 06 Feb 2024 15:35:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1707233702-11946-1" This is a multi-part message in MIME format... ------------=_1707233702-11946-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #68949: [PATCH] Optionally show internal buffers in Buffer Menu mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 68949@debbugs.gnu.org. --=20 68949: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D68949 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1707233702-11946-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 68949-done) by debbugs.gnu.org; 6 Feb 2024 15:34:36 +0000 Received: from localhost ([127.0.0.1]:54936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXNT1-000362-Sr for submit@debbugs.gnu.org; Tue, 06 Feb 2024 10:34:36 -0500 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:50674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXNSz-00035p-Pd for 68949-done@debbugs.gnu.org; Tue, 06 Feb 2024 10:34:34 -0500 Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2d09faadba5so36516471fa.1 for <68949-done@debbugs.gnu.org>; Tue, 06 Feb 2024 07:34:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707233654; x=1707838454; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=OyB9ovBHcruAvZVk6RNEg2sX0BZouC2AhziL/IiG7Zk=; b=Ztg9cUfP1RfTJwi+68kt8F+zn6+2mzaqSXLIilgQTwoJbn7AZX1vzlqW5FxtghngQM Vz57AwyteKV0gzdDSIuZyF3V2rolsylCwIMXE87GreqLmOXSE64MVl53M+ZxCcVK2aQM TgJTma0COhb4cV3XMFpGt1M6sWX0z4wirkuoREbjkJx0fv7AokgDKK79m5YJsVDA5j5O vDlm5lsXaNIwV5KKNxoU/qOWb+DbTS1F1oSPN2iMJ/UJE6GNyD5jo61PzUIaCogxYGQf geF44JpmVPPs2N1cKZsCjkEDq8IBPnnZZyrN883lOQHrlaaiBnD95EAFJaoEY3q1T8br rlkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707233654; x=1707838454; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OyB9ovBHcruAvZVk6RNEg2sX0BZouC2AhziL/IiG7Zk=; b=buYK8hNslOAr9Oj7c6ItmwppdWdrdMt5jCvnycUknGXnOlQSs73ASLusVm/8zoF99Q OLjcvPrt7D6WVbw8MiLQj9TVcNYuf5KD3VKyFzk2hVFEzsMsSoRdLItYfg3M9kdYUqad ZAmwY4e1ngMMB3tCaUC0/TFAnuXdufrKC/9y75i6ooKYoKtIkiRC5LfAao6xOkXP6pu2 WN/way1PekMWaj8W51oFrP5iT5shQU2/Aw+TkAMGqexG+1aavjIp43ii7XS55luvCJPx tAwwlaHTw9L+PSrLGtdToxfAMLwKzGiRlkSyxk/QyFCla/JKAIihOnPRPytqGfAfs6G3 q3/Q== X-Gm-Message-State: AOJu0YxsmH76KEbz9HVbqyF+qQOn/qmYhigaBDs0gNW7+JcD9KxbEO0Z ZToHELGSVbJDTtcIWwDU4EDmP0d1OzqLgSWreTLEfouEryNSEWZxj2uBnGdi X-Google-Smtp-Source: AGHT+IE+wzBMToyLTcdq9+cFCCyI0lP6rDqSyPFeCtV0Rs5ijyKLcEuBSTJn0WUZOV+tUrut9poFAg== X-Received: by 2002:a05:6512:4894:b0:511:4d0e:212f with SMTP id eq20-20020a056512489400b005114d0e212fmr2124167lfb.6.1707233634111; Tue, 06 Feb 2024 07:33:54 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id v16-20020a197410000000b00511557ae3a0sm265049lfe.289.2024.02.06.07.33.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Feb 2024 07:33:53 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#68949: [PATCH] Optionally show internal buffers in Buffer Menu mode From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <06D6EF41-2C92-49E7-83C1-89F48A09F6F3@gmail.com> Date: Tue, 6 Feb 2024 16:33:53 +0100 Content-Transfer-Encoding: 7bit Message-Id: <14AD2714-03AD-4C5B-A8C2-9EE36180F291@gmail.com> References: <0390E086-FAEF-4012-AF03-F115B125C1A2@gmail.com> <86zfwdzrtt.fsf@gnu.org> <06D6EF41-2C92-49E7-83C1-89F48A09F6F3@gmail.com> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68949-done Cc: 68949-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Pushed and closed. ------------=_1707233702-11946-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 6 Feb 2024 12:25:01 +0000 Received: from localhost ([127.0.0.1]:53345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXKVZ-0003KN-ER for submit@debbugs.gnu.org; Tue, 06 Feb 2024 07:25:01 -0500 Received: from lists.gnu.org ([2001:470:142::17]:42708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXKVX-0003KA-QV for submit@debbugs.gnu.org; Tue, 06 Feb 2024 07:25:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXKVF-0005GC-Cy for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2024 07:24:41 -0500 Received: from mail-lf1-x12d.google.com ([2a00:1450:4864:20::12d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rXKVA-0002NI-Bz for bug-gnu-emacs@gnu.org; Tue, 06 Feb 2024 07:24:41 -0500 Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-51032e62171so8935805e87.3 for ; Tue, 06 Feb 2024 04:24:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707222272; x=1707827072; darn=gnu.org; h=to:date:message-id:subject:mime-version:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=yT1JTIHdB8a9uwqpActBVpkM6oYC93a6IfgIhVMjPjs=; b=OaEi3VFMii6WT/mfmpmnrilsMjvxYgnRf+ClK49jjSGbeqFNN7fMXt6wZrtQB0L9PV jd3zxUc4YoLr27cSpVAcEJASFywmNO3/2968qo5JUWjA/M6K8LS5ci+rg/5NWfHfKyjF pPZxarQqYmN9OfbmllKca6YJjiGJk4m3hpefmHOlfN8y294YI41PgV/W4CpBP3GPGOpD inysRQXCmHGtfebp3M8s01bu0bSXL5GHyUTWshd91pMCvd3Zk+PEM7JLpq4wsgvIZS32 bpIrJ5OnpbHipN/70quKUoqQS/gXiCJIbEc0V9nXnLaMFB9jqs/ywXnLTQr+IOUBGd0H G4fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707222272; x=1707827072; h=to:date:message-id:subject:mime-version:from:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yT1JTIHdB8a9uwqpActBVpkM6oYC93a6IfgIhVMjPjs=; b=T98jsfVl2QHG1EXhp5+OIDtYZcd8AckpTvwKp/BHQhW2xGVpm1rarf2icA99gBhcKW lfEu3lCMqyYx9VsBHQGpLkrM7drjt9FtiJvoYfPeX2+MEc1KHHnN6iNYVml6s/vZG1dD WzEnx+Sz1yKl3hewio0qRCkluSx0uHiEYQIp8IVAuNBNxnq/uuhoTybMJDUtqD1ZtWKs rsZOJXeMRk6cJXX6Hdg6gSxy1VV56sILw9w1R8MpYR4qvi7ga+ilcv8WZKSMwqF00IvM dGM5aSn453wHT+pdc5dRsSAsJHBtYaz0Wl3ThrQYjh1ZNaq3TfJWS2DAeVWy6z1vBSgC uuyw== X-Gm-Message-State: AOJu0Yw9b53lUa7g8q9mPO0EvXijxMWB0/GsHLP1DDPCCBEf/oFWcAk2 +wbTcfR1RgDak0giWsaVdseEZmsKGo4XaLur5eEpsaHIaokZ4VQDaksZEDMV X-Google-Smtp-Source: AGHT+IHbogfNJ0L9Yd2u3f2k+vvVG8M7IeKtmk75M93siaWVmce+qG7BA2qYXwdhuhX9MGMe5HLaig== X-Received: by 2002:a05:6512:33cc:b0:50e:a789:dd3b with SMTP id d12-20020a05651233cc00b0050ea789dd3bmr2058628lfg.1.1707222271595; Tue, 06 Feb 2024 04:24:31 -0800 (PST) Received: from smtpclient.apple (c80-217-1-132.bredband.tele2.se. [80.217.1.132]) by smtp.gmail.com with ESMTPSA id q15-20020ac2528f000000b005113fa5be95sm225060lfm.85.2024.02.06.04.24.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Feb 2024 04:24:31 -0800 (PST) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: multipart/mixed; boundary="Apple-Mail=_9A2D58F5-9651-4253-9693-29A1524396B4" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: [PATCH] Optionally show internal buffers in Buffer Menu mode Message-Id: <0390E086-FAEF-4012-AF03-F115B125C1A2@gmail.com> Date: Tue, 6 Feb 2024 13:24:30 +0100 To: Emacs Bug Report X-Mailer: Apple Mail (2.3654.120.0.1.15) Received-SPF: pass client-ip=2a00:1450:4864:20::12d; envelope-from=mattias.engdegard@gmail.com; helo=mail-lf1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Apple-Mail=_9A2D58F5-9651-4253-9693-29A1524396B4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii `list-buffers` (C-x C-b) never shows internal buffers but it would = sometimes be very useful if it did. This patch adds a toggle. --Apple-Mail=_9A2D58F5-9651-4253-9693-29A1524396B4 Content-Disposition: attachment; filename=buff-menu-show-internal.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="buff-menu-show-internal.diff" Content-Transfer-Encoding: 7bit diff --git a/lisp/buff-menu.el b/lisp/buff-menu.el index 5796544c534..512ee608edb 100644 --- a/lisp/buff-menu.el +++ b/lisp/buff-menu.el @@ -100,6 +100,10 @@ Buffer-menu-files-only This is set by the prefix argument to `buffer-menu' and related commands.") +(defvar-local Buffer-menu-show-internal nil + "Non-nil if the current Buffer Menu lists internal buffers. +Internal buffers are those whose name start with a space.") + (defvar-local Buffer-menu-filter-predicate nil "Function to filter out buffers in the buffer list. Buffers that don't satisfy the predicate will be skipped. @@ -140,6 +144,7 @@ Buffer-menu-mode-map "V" #'Buffer-menu-view "O" #'Buffer-menu-view-other-window "T" #'Buffer-menu-toggle-files-only + "I" #'Buffer-menu-toggle-internal "M-s a C-s" #'Buffer-menu-isearch-buffers "M-s a C-M-s" #'Buffer-menu-isearch-buffers-regexp "M-s a C-o" #'Buffer-menu-multi-occur @@ -197,6 +202,10 @@ Buffer-menu-mode-menu :help "Toggle whether the current buffer-menu displays only file buffers" :style toggle :selected Buffer-menu-files-only] + ["Show Internal Buffers" Buffer-menu-toggle-internal + :help "Toggle whether the current buffer-menu displays internal buffers" + :style toggle + :selected Buffer-menu-show-internal] "---" ["Refresh" revert-buffer :help "Refresh the *Buffer List* buffer contents"] @@ -317,6 +326,11 @@ list-buffers (interactive "P") (display-buffer (list-buffers-noselect arg))) +(defun Buffer-menu--selection-message () + (message (cond (Buffer-menu-files-only "Showing only file-visiting buffers.") + (Buffer-menu-show-internal "Showing all buffers.") + (t "Showing all non-internal buffers.")))) + (defun Buffer-menu-toggle-files-only (arg) "Toggle whether the current `buffer-menu' displays only file buffers. With a positive ARG, display only file buffers. With zero or @@ -325,9 +339,18 @@ Buffer-menu-toggle-files-only (setq Buffer-menu-files-only (cond ((not arg) (not Buffer-menu-files-only)) ((> (prefix-numeric-value arg) 0) t))) - (message (if Buffer-menu-files-only - "Showing only file-visiting buffers." - "Showing all non-internal buffers.")) + (Buffer-menu--selection-message) + (revert-buffer)) + +(defun Buffer-menu-toggle-internal (arg) + "Toggle whether the current `buffer-menu' displays internal buffers. +With a positive ARG, display non-internal buffers only. With zero or +negative ARG, display internal buffers as well." + (interactive "P" Buffer-menu-mode) + (setq Buffer-menu-show-internal + (cond ((not arg) (not Buffer-menu-show-internal)) + ((> (prefix-numeric-value arg) 0) t))) + (Buffer-menu--selection-message) (revert-buffer)) (define-obsolete-function-alias 'Buffer-menu-sort 'tabulated-list-sort @@ -667,6 +690,7 @@ list-buffers--refresh (marked-buffers (Buffer-menu-marked-buffers)) (buffer-menu-buffer (current-buffer)) (show-non-file (not Buffer-menu-files-only)) + (show-internal Buffer-menu-show-internal) (filter-predicate (and (functionp Buffer-menu-filter-predicate) Buffer-menu-filter-predicate)) entries name-width) @@ -686,7 +710,8 @@ list-buffers--refresh (file buffer-file-name)) (when (and (buffer-live-p buffer) (or buffer-list - (and (or (not (string= (substring name 0 1) " ")) + (and (or show-internal + (not (string= (substring name 0 1) " ")) file) (not (eq buffer buffer-menu-buffer)) (or file show-non-file) --Apple-Mail=_9A2D58F5-9651-4253-9693-29A1524396B4-- ------------=_1707233702-11946-1-- From unknown Mon Jun 16 23:29:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68949: [PATCH] Optionally show internal buffers in Buffer Menu mode Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Feb 2024 17:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: Dmitry Gutov , 68949@debbugs.gnu.org Received: via spool by 68949-submit@debbugs.gnu.org id=B68949.170724225327594 (code B ref 68949); Tue, 06 Feb 2024 17:58:01 +0000 Received: (at 68949) by debbugs.gnu.org; 6 Feb 2024 17:57:33 +0000 Received: from localhost ([127.0.0.1]:55073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXPhN-0007Az-BJ for submit@debbugs.gnu.org; Tue, 06 Feb 2024 12:57:33 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:50549) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXPhL-0007Am-C3 for 68949@debbugs.gnu.org; Tue, 06 Feb 2024 12:57:32 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id DE2A9C0006; Tue, 6 Feb 2024 17:57:10 +0000 (UTC) From: Juri Linkov In-Reply-To: <14AD2714-03AD-4C5B-A8C2-9EE36180F291@gmail.com> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Tue, 6 Feb 2024 16:33:53 +0100") Organization: LINKOV.NET References: <0390E086-FAEF-4012-AF03-F115B125C1A2@gmail.com> <86zfwdzrtt.fsf@gnu.org> <06D6EF41-2C92-49E7-83C1-89F48A09F6F3@gmail.com> <14AD2714-03AD-4C5B-A8C2-9EE36180F291@gmail.com> Date: Tue, 06 Feb 2024 19:55:44 +0200 Message-ID: <86cyt979zz.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Pushed and closed. Thanks, now also added support for internal buffers to project-list-buffers as well. From unknown Mon Jun 16 23:29:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68949: [PATCH] Optionally show internal buffers in Buffer Menu mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Feb 2024 19:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Cc: 68949@debbugs.gnu.org Received: via spool by 68949-submit@debbugs.gnu.org id=B68949.17072493757917 (code B ref 68949); Tue, 06 Feb 2024 19:57:01 +0000 Received: (at 68949) by debbugs.gnu.org; 6 Feb 2024 19:56:15 +0000 Received: from localhost ([127.0.0.1]:55154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXRYE-00023c-R6 for submit@debbugs.gnu.org; Tue, 06 Feb 2024 14:56:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXRYC-00023M-Jc for 68949@debbugs.gnu.org; Tue, 06 Feb 2024 14:56:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXRXt-0000w4-RB; Tue, 06 Feb 2024 14:55:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=gKhb+36NhPT7eR+JkyGAYXosVXMR1ZwVUhM8NhiVZ+Q=; b=fKDCMdDKuIk/TbJjiENT Ki6PJPnauZB2LlLhzbgcK4NjGp0Wa1rHQaphXRh2tImSNQJG643tSu/MFHVod6KFReLD4w9CFVA5M D3zwohbr476tZUJyl3igfxWB/KhIXvUbg01XdjSpmyF0M/dBimakH4LKxd0fQk2sXij4wMQr0wp9x ulxXTmmAfYdqKYdw8i7SJj1Y2BSdnqSaA3d0cvanL+OvCbkh6H/pvj8ISr0NOSu01QTaCHXRorOdm wEraoLiIi141jL9Quwr0m0XCpvn3NxH4QfgU8i+sX14a3fJk1N55LrrQxyg3LouT9N2yM6/cvzOht 3z9wPiLurYIdRg==; Date: Tue, 06 Feb 2024 21:55:44 +0200 Message-Id: <86plx9z7sv.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <14AD2714-03AD-4C5B-A8C2-9EE36180F291@gmail.com> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Tue, 6 Feb 2024 16:33:53 +0100) References: <0390E086-FAEF-4012-AF03-F115B125C1A2@gmail.com> <86zfwdzrtt.fsf@gnu.org> <06D6EF41-2C92-49E7-83C1-89F48A09F6F3@gmail.com> <14AD2714-03AD-4C5B-A8C2-9EE36180F291@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Tue, 6 Feb 2024 16:33:53 +0100 > Cc: 68949-done@debbugs.gnu.org > > Pushed and closed. Thanks, but please always remember to mention the bug number in the log message. From unknown Mon Jun 16 23:29:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68949: [PATCH] Optionally show internal buffers in Buffer Menu mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 06 Feb 2024 20:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: dmitry@gutov.dev, mattias.engdegard@gmail.com, 68949@debbugs.gnu.org Received: via spool by 68949-submit@debbugs.gnu.org id=B68949.17072495468188 (code B ref 68949); Tue, 06 Feb 2024 20:00:03 +0000 Received: (at 68949) by debbugs.gnu.org; 6 Feb 2024 19:59:06 +0000 Received: from localhost ([127.0.0.1]:55159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXRb0-000280-CF for submit@debbugs.gnu.org; Tue, 06 Feb 2024 14:59:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXRax-00027V-Vm for 68949@debbugs.gnu.org; Tue, 06 Feb 2024 14:59:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXRae-0001Va-Qo; Tue, 06 Feb 2024 14:58:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=lsKnQAHujeP5Bt+0o08JkeRSe1j2l6EhlMhAZog21cM=; b=lH/Nb4GtEoWH 4VtWkb40U/okM6QL+f/xa6OhFCRM/aRvrp+bnustXCg3PE2ZqdIjXs8S7zHLxoD5y3YEfkl1PDzGx MZ/BWXSIAfKzyLhP5YLrXL7XqY2hcMryEZ6or8Wljmy+ldvbTWhSP4W/VMTEazOAht7eKvhWwArXW rHQdvqGCs4JuhwThOEZ/Y2La09foj538e+Gf+CkYJ7WRZStF5voWnwBBkuf3fp9zI/0csqd3gURzP J+GO+8ZyGIAdhUNFQ76IyxsbumXyKnjmIVIRVE4bQYs4T8LR3vtIm2ZQpJRbMWKuLe07b8HGjUCdg oeVNUjjpnCZ1azU9dQvQhA==; Date: Tue, 06 Feb 2024 21:58:42 +0200 Message-Id: <86o7ctz7nx.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86cyt979zz.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 06 Feb 2024 19:55:44 +0200) References: <0390E086-FAEF-4012-AF03-F115B125C1A2@gmail.com> <86zfwdzrtt.fsf@gnu.org> <06D6EF41-2C92-49E7-83C1-89F48A09F6F3@gmail.com> <14AD2714-03AD-4C5B-A8C2-9EE36180F291@gmail.com> <86cyt979zz.fsf@mail.linkov.net> X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) > Cc: Dmitry Gutov , 68949@debbugs.gnu.org > From: Juri Linkov > Date: Tue, 06 Feb 2024 19:55:44 +0200 > > > Pushed and closed. > > Thanks, now also added support for internal buffers > to project-list-buffers as well. Is it really a good idea to make a variable specific to Buffer menu mode affect a completely unrelated command? In any case, if this stays in the code, the corresponding doc strings should mention this fact. From unknown Mon Jun 16 23:29:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68949: [PATCH] Optionally show internal buffers in Buffer Menu mode Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Feb 2024 07:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: dmitry@gutov.dev, mattias.engdegard@gmail.com, 68949@debbugs.gnu.org Received: via spool by 68949-submit@debbugs.gnu.org id=B68949.170729241230254 (code B ref 68949); Wed, 07 Feb 2024 07:54:02 +0000 Received: (at 68949) by debbugs.gnu.org; 7 Feb 2024 07:53:32 +0000 Received: from localhost ([127.0.0.1]:55635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXckN-0007ru-Ne for submit@debbugs.gnu.org; Wed, 07 Feb 2024 02:53:31 -0500 Received: from relay1-d.mail.gandi.net ([2001:4b98:dc4:8::221]:40787) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXckM-0007rh-4s for 68949@debbugs.gnu.org; Wed, 07 Feb 2024 02:53:30 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id B3F2A240005; Wed, 7 Feb 2024 07:53:09 +0000 (UTC) From: Juri Linkov In-Reply-To: <86o7ctz7nx.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 06 Feb 2024 21:58:42 +0200") Organization: LINKOV.NET References: <0390E086-FAEF-4012-AF03-F115B125C1A2@gmail.com> <86zfwdzrtt.fsf@gnu.org> <06D6EF41-2C92-49E7-83C1-89F48A09F6F3@gmail.com> <14AD2714-03AD-4C5B-A8C2-9EE36180F291@gmail.com> <86cyt979zz.fsf@mail.linkov.net> <86o7ctz7nx.fsf@gnu.org> Date: Wed, 07 Feb 2024 09:50:10 +0200 Message-ID: <86y1bwiurc.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Is it really a good idea to make a variable specific to Buffer menu > mode affect a completely unrelated command? Sorry, I don't understand where is a completely unrelated command? From unknown Mon Jun 16 23:29:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#68949: [PATCH] Optionally show internal buffers in Buffer Menu mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 07 Feb 2024 13:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Juri Linkov Cc: dmitry@gutov.dev, mattias.engdegard@gmail.com, 68949@debbugs.gnu.org Received: via spool by 68949-submit@debbugs.gnu.org id=B68949.17073110538636 (code B ref 68949); Wed, 07 Feb 2024 13:05:01 +0000 Received: (at 68949) by debbugs.gnu.org; 7 Feb 2024 13:04:13 +0000 Received: from localhost ([127.0.0.1]:55866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXhb3-0002FD-Gn for submit@debbugs.gnu.org; Wed, 07 Feb 2024 08:04:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXhb1-0002F0-8w for 68949@debbugs.gnu.org; Wed, 07 Feb 2024 08:04:11 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rXhag-0000OQ-0U; Wed, 07 Feb 2024 08:03:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Jfqp4Gh+VlE5OrEbZ8hFFbWVXTslisWBP/PIOOeJlsQ=; b=ABf9NTPjAMCu eULKenQy2gigvdIr8uKIqqyc+n6TOtSb9F6JP76ygCjK5z/bFWrAAwfuuSFPsh+SAzZFIYt+XSOtc fWVslwUrCEa4A1/jVbowx7jvZyRhAnIpc7NUZ+qfIx6oBhB6QySwBtFN/sCNDmJ4Cp95lcw1M5RpB /VyB/PW5szGv4wGQHPClz58MinkNaN+Wtn4GaCuolTcG8fHnJiXKmZ5h7JmE52IST0PBsxHuAM3LK gA0Zk3XWAbVv8COzEtQzWjW8ItILw23Yd7xQ4NW86/l6ydibLXcvnRoBzt98ITUh6i9EIyn48i3lQ GDSV4n3a9xN64zALkXcZXw==; Date: Wed, 07 Feb 2024 15:03:45 +0200 Message-Id: <86a5oczary.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86y1bwiurc.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 07 Feb 2024 09:50:10 +0200) References: <0390E086-FAEF-4012-AF03-F115B125C1A2@gmail.com> <86zfwdzrtt.fsf@gnu.org> <06D6EF41-2C92-49E7-83C1-89F48A09F6F3@gmail.com> <14AD2714-03AD-4C5B-A8C2-9EE36180F291@gmail.com> <86cyt979zz.fsf@mail.linkov.net> <86o7ctz7nx.fsf@gnu.org> <86y1bwiurc.fsf@mail.linkov.net> X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) > From: Juri Linkov > Cc: mattias.engdegard@gmail.com, dmitry@gutov.dev, 68949@debbugs.gnu.org > Date: Wed, 07 Feb 2024 09:50:10 +0200 > > > Is it really a good idea to make a variable specific to Buffer menu > > mode affect a completely unrelated command? > > Sorry, I don't understand where is a completely unrelated command? The variable is called Buffer-menu-show-internal, which hints that it is applicable to Buffer Menu mode, whereas your change makes project-list-buffers, a command unrelated to Buffer Menu, obey that variable.