GNU bug report logs - #68949
[PATCH] Optionally show internal buffers in Buffer Menu mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68949 in the body.
You can then email your comments to 68949 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Emacs Bug Report <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Optionally show internal buffers in Buffer Menu mode
Date: Tue, 6 Feb 2024 13:24:30 +0100

[Message part 1 (text/plain, inline)]

`list-buffers` (C-x C-b) never shows internal buffers but it would sometimes be very useful if it did.
This patch adds a toggle.

[buff-menu-show-internal.diff (application/octet-stream, attachment)]

Message #8 received at 68949 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: 68949 <at> debbugs.gnu.org
Subject: Re: bug#68949: [PATCH] Optionally show internal buffers in Buffer Menu
 mode
Date: Tue, 06 Feb 2024 14:43:10 +0200

> From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
> Date: Tue, 6 Feb 2024 13:24:30 +0100
> 
> `list-buffers` (C-x C-b) never shows internal buffers but it would sometimes be very useful if it did.
> This patch adds a toggle.

Thanks.

Would a special value of prefix argument be better, perhaps?  Like in
"C-u 0 C-x C-b"?  Or maybe in addition to the toggle you suggest?

In any case, this should be in NEWS and perhaps also in the user
manual.

Message #11 received at 68949 <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68949 <at> debbugs.gnu.org
Subject: Re: bug#68949: [PATCH] Optionally show internal buffers in Buffer
 Menu mode
Date: Tue, 6 Feb 2024 13:54:41 +0100

6 feb. 2024 kl. 13.43 skrev Eli Zaretskii <eliz <at> gnu.org>:

> Would a special value of prefix argument be better, perhaps?  Like in
> "C-u 0 C-x C-b"?  Or maybe in addition to the toggle you suggest?

It wouldn't help usability for myself because I find it a lot more natural to toggle after displaying than remembering a particular prefix, but if someone prefers the prefix then I'm happy to let them add it.

> In any case, this should be in NEWS and perhaps also in the user
> manual.

I've written a NEWS entry, but I'm not sure it belongs in the user manual since it's mainly of interest to Elisp programmers. It's well-visible in the menu, however.

Thanks for looking at it! I'm pushing it to master now; we can amend it as necessary.

Message #16 received at 68949-done <at> debbugs.gnu.org (full text, mbox):

From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68949-done <at> debbugs.gnu.org
Subject: Re: bug#68949: [PATCH] Optionally show internal buffers in Buffer
 Menu mode
Date: Tue, 6 Feb 2024 16:33:53 +0100

Pushed and closed.

Message #19 received at 68949 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, 68949 <at> debbugs.gnu.org
Subject: Re: bug#68949: [PATCH] Optionally show internal buffers in Buffer
 Menu mode
Date: Tue, 06 Feb 2024 19:55:44 +0200

> Pushed and closed.

Thanks, now also added support for internal buffers
to project-list-buffers as well.

Message #22 received at 68949 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mattias Engdegård <mattias.engdegard <at> gmail.com>
Cc: 68949 <at> debbugs.gnu.org
Subject: Re: bug#68949: [PATCH] Optionally show internal buffers in Buffer
 Menu mode
Date: Tue, 06 Feb 2024 21:55:44 +0200

> From: Mattias Engdegård <mattias.engdegard <at> gmail.com>
> Date: Tue, 6 Feb 2024 16:33:53 +0100
> Cc: 68949-done <at> debbugs.gnu.org
> 
> Pushed and closed.

Thanks, but please always remember to mention the bug number in the
log message.

Message #25 received at 68949 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: dmitry <at> gutov.dev, mattias.engdegard <at> gmail.com, 68949 <at> debbugs.gnu.org
Subject: Re: bug#68949: [PATCH] Optionally show internal buffers in Buffer Menu
 mode
Date: Tue, 06 Feb 2024 21:58:42 +0200

> Cc: Dmitry Gutov <dmitry <at> gutov.dev>, 68949 <at> debbugs.gnu.org
> From: Juri Linkov <juri <at> linkov.net>
> Date: Tue, 06 Feb 2024 19:55:44 +0200
> 
> > Pushed and closed.
> 
> Thanks, now also added support for internal buffers
> to project-list-buffers as well.

Is it really a good idea to make a variable specific to Buffer menu
mode affect a completely unrelated command?

In any case, if this stays in the code, the corresponding doc strings
should mention this fact.

Message #28 received at 68949 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: dmitry <at> gutov.dev, mattias.engdegard <at> gmail.com, 68949 <at> debbugs.gnu.org
Subject: Re: bug#68949: [PATCH] Optionally show internal buffers in Buffer
 Menu mode
Date: Wed, 07 Feb 2024 09:50:10 +0200

> Is it really a good idea to make a variable specific to Buffer menu
> mode affect a completely unrelated command?

Sorry, I don't understand where is a completely unrelated command?

Message #31 received at 68949 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: dmitry <at> gutov.dev, mattias.engdegard <at> gmail.com, 68949 <at> debbugs.gnu.org
Subject: Re: bug#68949: [PATCH] Optionally show internal buffers in Buffer
 Menu mode
Date: Wed, 07 Feb 2024 15:03:45 +0200

> From: Juri Linkov <juri <at> linkov.net>
> Cc: mattias.engdegard <at> gmail.com,  dmitry <at> gutov.dev,  68949 <at> debbugs.gnu.org
> Date: Wed, 07 Feb 2024 09:50:10 +0200
> 
> > Is it really a good idea to make a variable specific to Buffer menu
> > mode affect a completely unrelated command?
> 
> Sorry, I don't understand where is a completely unrelated command?

The variable is called Buffer-menu-show-internal, which hints that it
is applicable to Buffer Menu mode, whereas your change makes
project-list-buffers, a command unrelated to Buffer Menu, obey that
variable.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.