From unknown Fri Jun 20 20:10:47 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6894 <6894@debbugs.gnu.org> To: bug#6894 <6894@debbugs.gnu.org> Subject: Status: 23.2; rcirc bug fix and enhancement for /IGNORE etc. Reply-To: bug#6894 <6894@debbugs.gnu.org> Date: Sat, 21 Jun 2025 03:10:47 +0000 retitle 6894 23.2; rcirc bug fix and enhancement for /IGNORE etc. reassign 6894 emacs submitter 6894 Leo severity 6894 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 22 05:25:07 2010 Received: (at submit) by debbugs.gnu.org; 22 Aug 2010 09:25:07 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1On6nb-0007Ni-4k for submit@debbugs.gnu.org; Sun, 22 Aug 2010 05:25:07 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1On6nZ-0007NI-VE for submit@debbugs.gnu.org; Sun, 22 Aug 2010 05:25:06 -0400 Received: from lists.gnu.org ([199.232.76.165]:35734) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1On6om-0004yZ-7U for submit@debbugs.gnu.org; Sun, 22 Aug 2010 05:26:20 -0400 Received: from [140.186.70.92] (port=46229 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1On6ok-00048i-8W for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2010 05:26:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL, T_TVD_MIME_NO_HEADERS autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1On6oj-0002rO-2V for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2010 05:26:18 -0400 Received: from ppsw-33.csi.cam.ac.uk ([131.111.8.133]:59374) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1On6oi-0002rB-S8 for bug-gnu-emacs@gnu.org; Sun, 22 Aug 2010 05:26:17 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from cpc1-cmbg13-0-0-cust596.5-4.cable.virginmedia.com ([86.9.122.85]:50534 helo=Victoria.local) by ppsw-33.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.159]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1On6oh-0000X4-hF (Exim 4.72) (return-path ); Sun, 22 Aug 2010 10:26:15 +0100 From: Leo To: bug-gnu-emacs@gnu.org Subject: 23.2; rcirc bug fix and enhancement for /IGNORE etc. Date: Sun, 22 Aug 2010 10:26:14 +0100 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: rcyeske@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) --=-=-= This was discussed with Ryan on #rcirc channel a while ago. It is a bug fix with small enhancement. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=rcirc.patch commit c37cec9427c49ea42525fd77ba3702adca69ef80 Date: Mon May 31 19:15:43 2010 +0100 Enhance IGNORE DIM BRIGHT and KEYWORD to handle multiple entries Incidentally it also fix a bug in those commands whereby if a user accidentally type a space following a nick, that space is taken as part of the nick. Modified lisp/net/rcirc.el diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el index 453ff86..258f7cb 100644 --- a/lisp/net/rcirc.el +++ b/lisp/net/rcirc.el @@ -2136,12 +2136,13 @@ With a prefix arg, prompt for new topic." (rcirc-send-string process (format "PRIVMSG %s :\C-aACTION %s\C-a" target args))) -(defun rcirc-add-or-remove (set &optional elt) - (if (and elt (not (string= "" elt))) - (if (member-ignore-case elt set) - (delete elt set) - (cons elt set)) - set)) +(defun rcirc-add-or-remove (set &rest elements) + (dolist (elt elements) + (if (and elt (not (string= "" elt))) + (setq set (if (member-ignore-case elt set) + (delete elt set) + (cons elt set))))) + set) (defun-rcirc-command ignore (nick) "Manage the ignore list. @@ -2149,7 +2150,9 @@ Ignore NICK, unignore NICK if already ignored, or list ignored nicks when no NICK is given. When listing ignored nicks, the ones added to the list automatically are marked with an asterisk." (interactive "sToggle ignoring of nick: ") - (setq rcirc-ignore-list (rcirc-add-or-remove rcirc-ignore-list nick)) + (setq rcirc-ignore-list + (apply #'rcirc-add-or-remove rcirc-ignore-list + (split-string nick nil t))) (rcirc-print process nil "IGNORE" target (mapconcat (lambda (nick) @@ -2161,14 +2164,18 @@ ones added to the list automatically are marked with an asterisk." (defun-rcirc-command bright (nick) "Manage the bright nick list." (interactive "sToggle emphasis of nick: ") - (setq rcirc-bright-nicks (rcirc-add-or-remove rcirc-bright-nicks nick)) + (setq rcirc-bright-nicks + (apply #'rcirc-add-or-remove rcirc-bright-nicks + (split-string nick nil t))) (rcirc-print process nil "BRIGHT" target (mapconcat 'identity rcirc-bright-nicks " "))) (defun-rcirc-command dim (nick) "Manage the dim nick list." (interactive "sToggle deemphasis of nick: ") - (setq rcirc-dim-nicks (rcirc-add-or-remove rcirc-dim-nicks nick)) + (setq rcirc-dim-nicks + (apply #'rcirc-add-or-remove rcirc-dim-nicks + (split-string nick nil t))) (rcirc-print process nil "DIM" target (mapconcat 'identity rcirc-dim-nicks " "))) @@ -2177,7 +2184,9 @@ ones added to the list automatically are marked with an asterisk." Mark KEYWORD, unmark KEYWORD if already marked, or list marked keywords when no KEYWORD is given." (interactive "sToggle highlighting of keyword: ") - (setq rcirc-keywords (rcirc-add-or-remove rcirc-keywords keyword)) + (setq rcirc-keywords + (apply #'rcirc-add-or-remove rcirc-keywords + (split-string keyword nil t))) (rcirc-print process nil "KEYWORD" target (mapconcat 'identity rcirc-keywords " "))) --=-=-= Thanks. Leo --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 22 18:43:51 2010 Received: (at 6894) by debbugs.gnu.org; 22 Aug 2010 22:43:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnJGZ-000740-65 for submit@debbugs.gnu.org; Sun, 22 Aug 2010 18:43:51 -0400 Received: from pantheon-po23.its.yale.edu ([130.132.50.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnJGX-00073v-Jn for 6894@debbugs.gnu.org; Sun, 22 Aug 2010 18:43:50 -0400 Received: from furry (173-9-75-145-NewEngland.hfc.comcastbusiness.net [173.9.75.145]) (authenticated bits=0) by pantheon-po23.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o7MMj56W014048 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 22 Aug 2010 18:45:05 -0400 Received: by furry (Postfix, from userid 1000) id 3EC9416D402; Sun, 22 Aug 2010 18:45:04 -0400 (EDT) From: Chong Yidong To: Leo Subject: Re: bug#6894: 23.2; rcirc bug fix and enhancement for /IGNORE etc. References: Date: Sun, 22 Aug 2010 18:45:04 -0400 In-Reply-To: (Leo's message of "Sun, 22 Aug 2010 10:26:14 +0100") Message-ID: <87tymmcln3.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 6894 Cc: rcyeske@gmail.com, 6894@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Leo writes: > This was discussed with Ryan on #rcirc channel a while ago. It is a bug > fix with small enhancement. Thanks. I've checked it into the repository. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 22 18:44:04 2010 Received: (at control) by debbugs.gnu.org; 22 Aug 2010 22:44:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnJGm-00074V-HO for submit@debbugs.gnu.org; Sun, 22 Aug 2010 18:44:04 -0400 Received: from pantheon-po23.its.yale.edu ([130.132.50.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OnJGk-000746-TN for control@debbugs.gnu.org; Sun, 22 Aug 2010 18:44:03 -0400 Received: from furry (173-9-75-145-NewEngland.hfc.comcastbusiness.net [173.9.75.145]) (authenticated bits=0) by pantheon-po23.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o7MMjIqA014087 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sun, 22 Aug 2010 18:45:19 -0400 Received: by furry (Postfix, from userid 1000) id 7C96216D402; Sun, 22 Aug 2010 18:45:18 -0400 (EDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 6894 Date: Sun, 22 Aug 2010 18:45:18 -0400 Message-ID: <87eidquv0h.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 6894 thanks From unknown Fri Jun 20 20:10:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 Sep 2010 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator