GNU bug report logs - #68918
[PATCH] gnu: go-github-com-operatorfoundation-ed25519: Add missing input.

Previous Next

Package: guix-patches;

Reported by: Troy Figiel <troy <at> troyfigiel.com>

Date: Sun, 4 Feb 2024 00:36:02 UTC

Severity: normal

Tags: patch

Done: Sharlatan Hellseher <sharlatanus <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68918 in the body.
You can then email your comments to 68918 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#68918; Package guix-patches. (Sun, 04 Feb 2024 00:36:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Troy Figiel <troy <at> troyfigiel.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 04 Feb 2024 00:36:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: go-github-com-operatorfoundation-ed25519: Add missing
 input.
Date: Sun, 4 Feb 2024 01:30:43 +0100

* gnu/packages/golang-crypto.scm (go-github-com-operatorfoundation-ed25519)
[native-inputs]: Add go-golang-org-x-crypto.
---
 gnu/packages/golang-crypto.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/golang-crypto.scm b/gnu/packages/golang-crypto.scm
index 688523a8f7..c8aa7fec0a 100644
--- a/gnu/packages/golang-crypto.scm
+++ b/gnu/packages/golang-crypto.scm
@@ -699,6 +699,8 @@ (define-public go-github-com-operatorfoundation-ed25519
                (delete-file-recursively
                 (string-append "src/" import-path "/testdata"))
                #t)))))
+      (native-inputs
+       (list go-golang-org-x-crypto))
       (home-page "https://github.com/OperatorFoundation/ed25519")
       (synopsis "Ed25519 for go")
       (description "Package ed25519 implements the Ed25519 signature

base-commit: abeffc82379c4f9bd2e6226ea27453b22cb4e0c8
-- 
2.42.0
Information forwarded to guix-patches <at> gnu.org:
bug#68918; Package guix-patches. (Sun, 04 Feb 2024 00:44:01 GMT) Full text and rfc822 format available.

Message #8 received at 68918 <at> debbugs.gnu.org (full text, mbox):

From: Troy Figiel <troy <at> troyfigiel.com>
To: 68918 <at> debbugs.gnu.org
Subject: Re: [bug#68918] [PATCH] gnu:
 go-github-com-operatorfoundation-ed25519: Add missing input.
Date: Sun, 4 Feb 2024 01:42:37 +0100

[Message part 1 (text/plain, inline)]
Currently, this has no effect on the build because the test file
extra25519/extra25519_test.go that contains this requirement is not
being tested and hence not being built.

This patch already adds go-golang-org-x-crypto to native-inputs, so
running all tests in the future, i.e. a change in the check phase, does
not break the build.

Best wishes,

Troy
[OpenPGP_0xC67C9181B3893FB0.asc (application/pgp-keys, attachment)]
[OpenPGP_signature.asc (application/pgp-signature, attachment)]
Reply sent to Sharlatan Hellseher <sharlatanus <at> gmail.com>:
You have taken responsibility. (Mon, 05 Feb 2024 22:41:02 GMT) Full text and rfc822 format available.
Notification sent to Troy Figiel <troy <at> troyfigiel.com>:
bug acknowledged by developer. (Mon, 05 Feb 2024 22:41:02 GMT) Full text and rfc822 format available.

Message #13 received at 68918-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 68918-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: go-github-com-operatorfoundation-ed25519: Add missing
 input.
Date: Mon, 05 Feb 2024 22:39:49 +0000

[Message part 1 (text/plain, inline)]
Hi,

Pushed as 1eda62a26692f20bc29d32f3ee09ac719e7483a5 to master.

Thanks,
Oleg

[signature.asc (application/pgp-signature, inline)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 05 Mar 2024 12:24:07 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 101 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.