GNU bug report logs - #68913
[PATCH] Fix browse-url-url-at-point so that scheme does not duplicate

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#68913: closed ([PATCH] Fix browse-url-url-at-point so that
 scheme does not duplicate)
Date: Thu, 08 Feb 2024 12:08:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 08 Feb 2024 14:07:03 +0200
with message-id <86ttmjw460.fsf <at> gnu.org>
and subject line Re: bug#68913: [PATCH] Fix browse-url-url-at-point so that scheme does not duplicate
has caused the debbugs.gnu.org bug report #68913,
regarding [PATCH] Fix browse-url-url-at-point so that scheme does not duplicate
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
68913: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68913
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kenta USAMI <zonuexe <at> zonu.me>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix browse-url-url-at-point so that scheme does not duplicate
Date: Sun, 4 Feb 2024 04:17:29 +0900

[Message part 3 (text/plain, inline)]

Hi,

In the text below, move point to the second half of the URL and
execute M-x browse-url-at-point.

```
[![Emacs](
https://www.gnu.org/software/emacs/images/emacs.png)](https://www.gnu.org/software/emacs/download.html
)
```

Firefox and Chromium-based browsers appear to open the URL "https//
www.gnu.org/software/emacs/download.html".
It seems that the ":" following https is deleted, but the browser actually
normalizes
the URL with the duplicate scheme "http://https://".

You can check this by executing M-: (browse-url-url-at-point).

Because thing-at-point-bounds-of-url-at-point function cannot correctly
recognize
URL bounds in the text.

I considered changing the thing-at-point-bounds-of-url-at-point algorithm,
but it would be a pain to change it without negatively impacting the
current behavior.
Ideally, thing-at-point-bounds-of-url-at-point will be fixed eventually,
but for now, the attached patch should easily fix the problem.

[Message part 4 (text/html, inline)]

[0001-Fix-browse-url-url-at-point-so-that-scheme-does-not-.patch (application/octet-stream, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Kenta USAMI <zonuexe <at> zonu.me>
Cc: 68913-done <at> debbugs.gnu.org
Subject: Re: bug#68913: [PATCH] Fix browse-url-url-at-point so that scheme
 does not duplicate
Date: Thu, 08 Feb 2024 14:07:03 +0200

> From: Kenta USAMI <zonuexe <at> zonu.me>
> Date: Sun, 4 Feb 2024 05:48:27 +0900
> Cc: 68913 <at> debbugs.gnu.org
> 
> I'm using Emacs 29.2 on macOS.
> GNU Emacs 29.2 (build 2, aarch64-apple-darwin23.3.0, NS appkit-2487.40 Version 14.3 (Build 23D56))
>  of 2024-01-26
> 
> This problem is most noticeable when using markdown-mode and goto-address-mode, 
> but it also seems to occur even if goto-address-mode is disabled in text-mode or fundamental-mode.
> 
> You can see the problem by evaluating the Lisp code below.

Thanks, I installed your patch on the master branch, and I'm closing
this bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.