GNU bug report logs - #68907
[PATCH] website: Fix language order.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68907 in the body.
You can then email your comments to 68907 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH] website: Fix language order.
Date: Sat,  3 Feb 2024 08:56:45 +0100

* website/apps/base/templates/components.scm (navbar): Fix sorting of
languages.
---
 website/apps/base/templates/components.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/website/apps/base/templates/components.scm b/website/apps/base/templates/components.scm
index 241c27e..2a6881e 100644
--- a/website/apps/base/templates/components.scm
+++ b/website/apps/base/templates/components.scm
@@ -516,7 +516,7 @@ manual.
            (sort (delete %current-lingua
                          ietf-tags-file-contents
                          (lambda (a b) (string=? a (car b))))
-                 (lambda (a b) string<?)))
+                 (lambda (a b) (string<? (car a) (car b)))))
           (list
             (menu-item #:label (G_ "Translate")
                        #:active-item active-item

base-commit: 2bf7c25f4bd5f13a2248839f47de972589c9a2f6
-- 
2.41.0

Message #8 received at 68907 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 68907 <at> debbugs.gnu.org
Subject: Re: [bug#68907] [PATCH] website: Fix language order.
Date: Sat, 03 Feb 2024 17:27:16 +0100

Julien Lepiller <julien <at> lepiller.eu> writes:
> -                 (lambda (a b) string<?)))
> +                 (lambda (a b) (string<? (car a) (car b)))))

Whoops.  LGTM.  Now as a consequence of the patch, the English website
will be listed as one among many.  I do agree this is better.

Regards,
Florian

Message #13 received at 68907-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: 68907-done <at> debbugs.gnu.org
Subject: Re: [bug#68907] [PATCH] website: Fix language order.
Date: Sat, 3 Feb 2024 22:53:37 +0100

Le Sat, 03 Feb 2024 17:27:16 +0100,
"pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de> a écrit :

> Julien Lepiller <julien <at> lepiller.eu> writes:
> > -                 (lambda (a b) string<?)))
> > +                 (lambda (a b) (string<? (car a) (car b)))))  
> 
> Whoops.  LGTM.  Now as a consequence of the patch, the English website
> will be listed as one among many.  I do agree this is better.
> 
> Regards,
> Florian

Thanks, pushed to master as 8dfafa0a91f1e3ca84f7fe7fb8e5e31bf1bb1e8f.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.