GNU bug report logs - #68893
30.0.50; pixel-fill-region errors when folding message headers in Gnus

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stephen Berman <stephen.berman <at> gmx.net>, No Wayman <iarchivedmywholelife <at> gmail.com>
Cc: 68893 <at> debbugs.gnu.org
Subject: bug#68893: 30.0.50; pixel-fill-region errors when folding message headers in Gnus
Date: Fri, 02 Feb 2024 21:38:52 +0200

> From: Stephen Berman <stephen.berman <at> gmx.net>
> Cc: 68893 <at> debbugs.gnu.org
> Date: Fri, 02 Feb 2024 20:35:29 +0100
> 
> Ah, I actually had seen that report and also the recent other one that
> you merged with it, but unfortunately I didn't remember them when I
> encountered the issue myself today.  Thanks for the pointer.  And
> indeed, not only does Katsumi Yamaoka's patch to
> gnus-article-treat-fold-headers fix the problem for me too, but also
> your suggestion to apply the fix to pixel-fill-region instead, as in the
> following patch, works just as well:
> 
> diff --git a/lisp/textmodes/pixel-fill.el b/lisp/textmodes/pixel-fill.el
> index 25c0b46cee9..dcd57acc2e5 100644
> --- a/lisp/textmodes/pixel-fill.el
> +++ b/lisp/textmodes/pixel-fill.el
> @@ -73,7 +73,8 @@ pixel-fill-region
>  If START isn't at the start of a line, the horizontal position of
>  START, converted to pixel units, will be used as the indentation
>  prefix on subsequent lines."
> -  (save-excursion
> +  (save-window-excursion
> +    (set-window-buffer nil (current-buffer))
>      (goto-char start)
>      (let ((indentation
>             (car (window-text-pixel-size nil (line-beginning-position)

No Wayman, does the above fix the problem for you as well?

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.