From unknown Fri Jun 20 07:22:21 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#68881 <68881@debbugs.gnu.org> To: bug#68881 <68881@debbugs.gnu.org> Subject: Status: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' Reply-To: bug#68881 <68881@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:22:21 +0000 retitle 68881 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' reassign 68881 emacs submitter 68881 Jim Porter severity 68881 normal tag 68881 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 01 18:52:21 2024 Received: (at submit) by debbugs.gnu.org; 1 Feb 2024 23:52:21 +0000 Received: from localhost ([127.0.0.1]:43341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVgqz-0002al-2Z for submit@debbugs.gnu.org; Thu, 01 Feb 2024 18:52:21 -0500 Received: from lists.gnu.org ([2001:470:142::17]:33674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rVgqv-0002aO-V5 for submit@debbugs.gnu.org; Thu, 01 Feb 2024 18:52:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVgqf-0006td-Py for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 18:52:01 -0500 Received: from mail-oo1-xc33.google.com ([2607:f8b0:4864:20::c33]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rVgqd-0005dH-No for bug-gnu-emacs@gnu.org; Thu, 01 Feb 2024 18:52:01 -0500 Received: by mail-oo1-xc33.google.com with SMTP id 006d021491bc7-59a8ecbadf7so656924eaf.0 for ; Thu, 01 Feb 2024 15:51:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706831518; x=1707436318; darn=gnu.org; h=subject:from:to:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=sIcJnrV8eM15y21k8BUZKoMfHBM4DH2Fb6NLj483bXM=; b=XdiyBrcbMONfdInqB0YAB7auLFh50Dcals0z0uAPFK0eqsENuzyymw2hE1BUUKReWy 4cOAfWX24XCLzq11Q/Q0xlctKWUuKTz8L4qcAt9VaNK+BVbbGuBsQTrOs8mF1s9DaRry R2Xe+MEc0uNa3DlU/mTdspeytqA8U8Dg340zHInFhgknBgtRND0AFd5bWtMZXo9d1w7k 3gu/F8QJElEwjV9bT9Mg0igWrtOZOsnKZYG0QNmkPeH7nuMOEaSMiGXCyGb1t69fGSWh gypWkzW8VRW+jgkq4t4ZAML5tLQoafI5gDKqzy2g7ClcVSQDVEJ+CSpTsc73BjYBfpEg FyqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706831518; x=1707436318; h=subject:from:to:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sIcJnrV8eM15y21k8BUZKoMfHBM4DH2Fb6NLj483bXM=; b=J7l5zH+rA0ElPnIMgiB5C9h7kiHsiBMA55GzkvFPGnlGJsFzyIZRFQwHSiROcryjm3 eJdY1TKcHf9YjziuSYvEVCM272+Dsxs6T0kJ5S+huLDFKDgUvb3QIKmlWBxA9p5emCLu 2vAjGB2vos6nxzGh0SOyxOUuhNPgPGqDaqUjQcUYs6J/iUZAxcA+6+hQFTwNIfDbZh4H 6sFGEJsC32jmjE+VHR4rdKMSlyF1R5fEeK9MljqLiPBgOCehSLPhJdee6i685NyWnmdR /H5XRLLEj4oA5Da7Vkc17lD5yA6bj59h3I0ZEKNyXLEhpJR7qawc2U908k9w/+WWEalG UcIQ== X-Gm-Message-State: AOJu0Yx/aYdKKcTQVHVsjZHTv+8oluCNwTg325w4ZatQ9gEJh9gDAKEE kxmQd/MGP+08uqinj6DYrGBefjzaBkWVOGVs8TnQwbzoYvn6XX+IZWioVfyE X-Google-Smtp-Source: AGHT+IEuVHVscXPRuDM6xtcCdOjVDvLo30rqdu196C/RbA4s0lzKhb8qqVazOJBNGnPM/YfMRRCq5Q== X-Received: by 2002:a05:6358:721:b0:178:8cc8:4c7b with SMTP id e33-20020a056358072100b001788cc84c7bmr3957872rwj.24.1706831518098; Thu, 01 Feb 2024 15:51:58 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id v1-20020aa799c1000000b006d99c6c0f1fsm303020pfi.100.2024.02.01.15.51.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Feb 2024 15:51:57 -0800 (PST) Content-Type: multipart/mixed; boundary="------------ItyODbWPSbEktLWwM8O8fb3s" Message-ID: <83986cee-a32d-707f-6ee0-ec1ba2bd42c2@gmail.com> Date: Thu, 1 Feb 2024 15:51:57 -0800 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Jim Porter Subject: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' Received-SPF: pass client-ip=2607:f8b0:4864:20::c33; envelope-from=jporterbugs@gmail.com; helo=mail-oo1-xc33.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------ItyODbWPSbEktLWwM8O8fb3s Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I'd like to add support for 'outline-minor-mode' in Eshell. However, Eshell's use of field properties confuses outline.el. Attached is a WIP patch + demo code for Eshell that should resolve this. The main issue was that outline.el uses 'line-beginning-position' and friends, which respects field boundaries, but I think we want to avoid that for 'outline-minor-mode'. Maybe we could use 'pos-bol' and friends instead, but my understanding is that 'line-beginning-position' respects display directionality (which we probably want), but 'pos-bol' doesn't. You can try things out here by starting Eshell and activating 'outline-minor-mode'. You can also see the problems by applying only the Eshell part of the patch. Any thoughts? Is this the right way to go about this? (Note: I think the Eshell side of things will take more work, which I'll address in a later bug. However, this should be enough to show off the problems on the outline.el side.) --------------ItyODbWPSbEktLWwM8O8fb3s Content-Type: text/plain; charset=UTF-8; name="0001-WIP-Make-outline.el-able-to-handle-buffers-with-fiel.patch" Content-Disposition: attachment; filename*0="0001-WIP-Make-outline.el-able-to-handle-buffers-with-fiel.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBmYWQ2NGEyM2UzOGZiYzQzY2VlMTIxZGI3OGYwMGUyNTVkZjNlY2Q4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMSBGZWIgMjAyNCAxMzo1ODoyMCAtMDgwMApTdWJqZWN0OiBbUEFU Q0hdIFtXSVBdIE1ha2Ugb3V0bGluZS5lbCBhYmxlIHRvIGhhbmRsZSBidWZmZXJzIHdpdGgg ZmllbGQKIHByb3BlcnRpZXMKCiogbGlzcC9vdXRsaW5lLmVsIChvdXRsaW5lLWJhY2stdG8t aGVhZGluZywgb3V0bGluZS1vbi1oZWFkaW5nLXApCihvdXRsaW5lLW5leHQtdmlzaWJsZS1o ZWFkaW5nLCBvdXRsaW5lLW1hcmstc3VidHJlZSkKKG91dGxpbmUtaGlkZS1zdWJsZXZlbHMs IG91dGxpbmUtLWluc2VydC1idXR0b24pCihvdXRsaW5lLS1maXgtdXAtYWxsLWJ1dHRvbnMp OiBJbmhpYml0IGZpZWxkIHRleHQgbW90aW9uLgoKKiBsaXNwL2VzaGVsbC9lbS1wcm9tcHQu ZWwgKGVzaGVsbC1vdXRsaW5lLXNlYXJjaCk6IE5ldyBmdW5jdGlvbiAoZm9yCnRlc3Rpbmcg b25seSkuCihlc2hlbGwtcHJvbXB0LWluaXRpYWxpemUpOiBJbml0aWFsaXplIG91dGxpbmUt bW9kZSB2YXJpYWJsZXMuCi0tLQogbGlzcC9lc2hlbGwvZW0tcHJvbXB0LmVsIHwgMTQgKysr KysrKysrKysrKy0KIGxpc3Avb3V0bGluZS5lbCAgICAgICAgICB8IDMyICsrKysrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDM0IGluc2VydGlvbnMo KyksIDEyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VtLXByb21w dC5lbCBiL2xpc3AvZXNoZWxsL2VtLXByb21wdC5lbAppbmRleCAzNjYyYzFmYTg5NS4uYmYz YTI0Njg5ZjggMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VtLXByb21wdC5lbAorKysgYi9s aXNwL2VzaGVsbC9lbS1wcm9tcHQuZWwKQEAgLTEwNyw2ICsxMDcsMTQgQEAgZXNoZWxsLXBy b21wdC1yZXBlYXQtbWFwCiAKIDs7OyBGdW5jdGlvbnM6CiAKKyhkZWZ1biBlc2hlbGwtb3V0 bGluZS1zZWFyY2ggKCZvcHRpb25hbCBib3VuZCBtb3ZlIGJhY2t3YXJkIGxvb2tpbmctYXQp CisgICJTZWFyY2ggZm9yIG91dGxpbmUgaGVhZGluZ3MuICBTZWUgYG91dGxpbmUtc2VhcmNo LWZ1bmN0aW9uJy4iCisgIDs7IEZJWE1FOiBUaGlzIHByb2JhYmx5IGlzbid0IHRoZSByaWdo dCB3YXkgdG8gZG8gdGhpbmdzLiAgRG9lcyBpdAorICA7OyB3b3JrIHdpdGggbXVsdGlsaW5l IHByb21wdHM/ICBTdGlsbCwgaXQncyB1c2VmdWwgZm9yIGEgcHJvb2Ygb2YKKyAgOzsgY29u Y2VwdC4KKyAgKG91dGxpbmUtc2VhcmNoLXRleHQtcHJvcGVydHkgJ2ZpZWxkICdwcm9tcHQg Ym91bmQgbW92ZSBiYWNrd2FyZAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBs b29raW5nLWF0KSkKKwogKGRlZmluZS1taW5vci1tb2RlIGVzaGVsbC1wcm9tcHQtbW9kZQog ICAiTWlub3IgbW9kZSBmb3IgZXNoZWxsLXByb21wdCBtb2R1bGUuCiAKQEAgLTExNyw3ICsx MjUsMTEgQEAgZXNoZWxsLXByb21wdC1pbml0aWFsaXplCiAgICJJbml0aWFsaXplIHRoZSBw cm9tcHRpbmcgY29kZS4iCiAgICh1bmxlc3MgZXNoZWxsLW5vbi1pbnRlcmFjdGl2ZS1wCiAg ICAgKGFkZC1ob29rICdlc2hlbGwtcG9zdC1jb21tYW5kLWhvb2sgJ2VzaGVsbC1lbWl0LXBy b21wdCBuaWwgdCkKLSAgICAoZXNoZWxsLXByb21wdC1tb2RlKSkpCisgICAgKGVzaGVsbC1w cm9tcHQtbW9kZSkKKworICAgIChzZXRxLWxvY2FsIG91dGxpbmUtc2VhcmNoLWZ1bmN0aW9u ICMnZXNoZWxsLW91dGxpbmUtc2VhcmNoCisgICAgICAgICAgICAgICAgb3V0bGluZS1sZXZl bCAobGFtYmRhICgpIDEpCisgICAgICAgICAgICAgICAgb3V0bGluZS1taW5vci1tb2RlLXVz ZS1idXR0b25zICdpbi1tYXJnaW5zKSkpCiAKIChkZWZ1biBlc2hlbGwtZW1pdC1wcm9tcHQg KCkKICAgIkVtaXQgYSBwcm9tcHQgaWYgZXNoZWxsIGlzIGJlaW5nIHVzZWQgaW50ZXJhY3Rp dmVseS4iCmRpZmYgLS1naXQgYS9saXNwL291dGxpbmUuZWwgYi9saXNwL291dGxpbmUuZWwK aW5kZXggYjUwNzA4YzFhN2IuLmU3ZThkMjY5NjQwIDEwMDY0NAotLS0gYS9saXNwL291dGxp bmUuZWwKKysrIGIvbGlzcC9vdXRsaW5lLmVsCkBAIC02ODYsNyArNjg2LDggQEAgJ291dGxp bmUtYmVmb3JlLWZpcnN0LWhlYWRpbmcKIChkZWZ1biBvdXRsaW5lLWJhY2stdG8taGVhZGlu ZyAoJm9wdGlvbmFsIGludmlzaWJsZS1vaykKICAgIk1vdmUgdG8gcHJldmlvdXMgaGVhZGlu ZyBsaW5lLCBvciBiZWcgb2YgdGhpcyBsaW5lIGlmIGl0J3MgYSBoZWFkaW5nLgogT25seSB2 aXNpYmxlIGhlYWRpbmcgbGluZXMgYXJlIGNvbnNpZGVyZWQsIHVubGVzcyBJTlZJU0lCTEUt T0sgaXMgbm9uLW5pbC4iCi0gIChiZWdpbm5pbmctb2YtbGluZSkKKyAgKGxldCAoKGluaGli aXQtZmllbGQtdGV4dC1tb3Rpb24gdCkpCisgICAgKGJlZ2lubmluZy1vZi1saW5lKSkKICAg KG9yIChvdXRsaW5lLW9uLWhlYWRpbmctcCBpbnZpc2libGUtb2spCiAgICAgICAobGV0IChm b3VuZCkKIAkoc2F2ZS1leGN1cnNpb24KQEAgLTcwNSw3ICs3MDYsOCBAQCBvdXRsaW5lLW9u LWhlYWRpbmctcAogICAiUmV0dXJuIHQgaWYgcG9pbnQgaXMgb24gYSAodmlzaWJsZSkgaGVh ZGluZyBsaW5lLgogSWYgSU5WSVNJQkxFLU9LIGlzIG5vbi1uaWwsIGFuIGludmlzaWJsZSBo ZWFkaW5nIGxpbmUgaXMgb2sgdG9vLiIKICAgKHNhdmUtZXhjdXJzaW9uCi0gICAgKGJlZ2lu bmluZy1vZi1saW5lKQorICAgIChsZXQgKChpbmhpYml0LWZpZWxkLXRleHQtbW90aW9uIHQp KQorICAgICAgKGJlZ2lubmluZy1vZi1saW5lKSkKICAgICAoYW5kIChib2xwKSAob3IgaW52 aXNpYmxlLW9rIChub3QgKG91dGxpbmUtaW52aXNpYmxlLXApKSkKIAkgKGlmIG91dGxpbmUt c2VhcmNoLWZ1bmN0aW9uCiAgICAgICAgICAgICAgKGZ1bmNhbGwgb3V0bGluZS1zZWFyY2gt ZnVuY3Rpb24gbmlsIG5pbCBuaWwgdCkKQEAgLTk0MSw5ICs5NDMsMTAgQEAgb3V0bGluZS1u ZXh0LXZpc2libGUtaGVhZGluZwogQSBoZWFkaW5nIGxpbmUgaXMgb25lIHRoYXQgc3RhcnRz IHdpdGggYSBgKicgKG9yIHRoYXQKIGBvdXRsaW5lLXJlZ2V4cCcgbWF0Y2hlcykuIgogICAo aW50ZXJhY3RpdmUgInAiKQotICAoaWYgKDwgYXJnIDApCi0gICAgICAoYmVnaW5uaW5nLW9m LWxpbmUpCi0gICAgKGVuZC1vZi1saW5lKSkKKyAgKGxldCAoKGluaGliaXQtZmllbGQtdGV4 dC1tb3Rpb24gdCkpCisgICAgKGlmICg8IGFyZyAwKQorICAgICAgICAoYmVnaW5uaW5nLW9m LWxpbmUpCisgICAgICAoZW5kLW9mLWxpbmUpKSkKICAgKGxldCAoKHJlZ2V4cCAodW5sZXNz IG91dGxpbmUtc2VhcmNoLWZ1bmN0aW9uCiAgICAgICAgICAgICAgICAgICAoY29uY2F0ICJe XFwoPzoiIG91dGxpbmUtcmVnZXhwICJcXCkiKSkpCiAgICAgICAgIGZvdW5kLWhlYWRpbmct cCkKQEAgLTk2Myw3ICs5NjYsOSBAQCBvdXRsaW5lLW5leHQtdmlzaWJsZS1oZWFkaW5nCiAg ICAgICAgICAgICAgICAgICAgICAgICAgIChyZS1zZWFyY2gtZm9yd2FyZCByZWdleHAgbmls ICdtb3ZlKSkpCiAJCSAgKG91dGxpbmUtaW52aXNpYmxlLXAgKG1hdGNoLWJlZ2lubmluZyAw KSkpKQogICAgICAgKHNldHEgYXJnICgxLSBhcmcpKSkKLSAgICAoaWYgZm91bmQtaGVhZGlu Zy1wIChiZWdpbm5pbmctb2YtbGluZSkpKSkKKyAgICAoaWYgZm91bmQtaGVhZGluZy1wCisg ICAgICAgIChsZXQgKChpbmhpYml0LWZpZWxkLXRleHQtbW90aW9uIHQpKQorICAgICAgICAg IChiZWdpbm5pbmctb2YtbGluZSkpKSkpCiAKIChkZWZ1biBvdXRsaW5lLXByZXZpb3VzLXZp c2libGUtaGVhZGluZyAoYXJnKQogICAiTW92ZSB0byB0aGUgcHJldmlvdXMgaGVhZGluZyBs aW5lLgpAQCAtOTgwLDcgKzk4NSw4IEBAIG91dGxpbmUtbWFyay1zdWJ0cmVlCiAgIChsZXQg KChiZWcpKQogICAgIChpZiAob3V0bGluZS1vbi1oZWFkaW5nLXApCiAJOzsgd2UgYXJlIGFs cmVhZHkgbG9va2luZyBhdCBhIGhlYWRpbmcKLQkoYmVnaW5uaW5nLW9mLWxpbmUpCisgICAg ICAgIChsZXQgKChpbmhpYml0LWZpZWxkLXRleHQtbW90aW9uIHQpKQorICAgICAgICAgIChi ZWdpbm5pbmctb2YtbGluZSkpCiAgICAgICA7OyBlbHNlIGdvIGJhY2sgdG8gcHJldmlvdXMg aGVhZGluZwogICAgICAgKG91dGxpbmUtcHJldmlvdXMtdmlzaWJsZS1oZWFkaW5nIDEpKQog ICAgIChzZXRxIGJlZyAocG9pbnQpKQpAQCAtMTE4Myw3ICsxMTg5LDggQEAgb3V0bGluZS1o aWRlLXN1YmxldmVscwogCQkoY29uZAogCQkgKGN1cnJlbnQtcHJlZml4LWFyZyAocHJlZml4 LW51bWVyaWMtdmFsdWUgY3VycmVudC1wcmVmaXgtYXJnKSkKIAkJICgoc2F2ZS1leGN1cnNp b24KLSAgICAgICAgICAgICAgICAgICAgKGJlZ2lubmluZy1vZi1saW5lKQorICAgICAgICAg ICAgICAgICAgICAobGV0ICgoaW5oaWJpdC1maWVsZC10ZXh0LW1vdGlvbiB0KSkKKyAgICAg ICAgICAgICAgICAgICAgICAoYmVnaW5uaW5nLW9mLWxpbmUpKQogCQkgICAgKGlmIG91dGxp bmUtc2VhcmNoLWZ1bmN0aW9uCiAgICAgICAgICAgICAgICAgICAgICAgICAoZnVuY2FsbCBv dXRsaW5lLXNlYXJjaC1mdW5jdGlvbiBuaWwgbmlsIG5pbCB0KQogICAgICAgICAgICAgICAg ICAgICAgIChsb29raW5nLWF0IG91dGxpbmUtcmVnZXhwKSkpCkBAIC0xODM0LDEzICsxODQx LDE1IEBAIG91dGxpbmUtLWNyZWF0ZS1idXR0b24taWNvbnMKIChkZWZ1biBvdXRsaW5lLS1p bnNlcnQtYnV0dG9uICh0eXBlKQogICAod2l0aC1zaWxlbnQtbW9kaWZpY2F0aW9ucwogICAg IChzYXZlLWV4Y3Vyc2lvbgotICAgICAgKGJlZ2lubmluZy1vZi1saW5lKQorICAgICAgKGxl dCAoKGluaGliaXQtZmllbGQtdGV4dC1tb3Rpb24gdCkpCisgICAgICAgIChiZWdpbm5pbmct b2YtbGluZSkpCiAgICAgICAobGV0ICgoaWNvbiAobnRoIChpZiAoZXEgdHlwZSAnY2xvc2Up IDEgMCkgb3V0bGluZS0tYnV0dG9uLWljb25zKSkKICAgICAgICAgICAgIChvIChzZXEtZmlu ZCAobGFtYmRhIChvKSAob3ZlcmxheS1nZXQgbyAnb3V0bGluZS1idXR0b24pKQogICAgICAg ICAgICAgICAgICAgICAgICAgIChvdmVybGF5cy1hdCAocG9pbnQpKSkpKQogICAgICAgICAo dW5sZXNzIG8KICAgICAgICAgICAod2hlbiAoZXEgb3V0bGluZS1taW5vci1tb2RlLXVzZS1i dXR0b25zICdpbnNlcnQpCi0gICAgICAgICAgICAobGV0ICgoaW5oaWJpdC1yZWFkLW9ubHkg dCkpCisgICAgICAgICAgICAobGV0ICgoaW5oaWJpdC1yZWFkLW9ubHkgdCkKKyAgICAgICAg ICAgICAgICAgIChpbmhpYml0LWZpZWxkLXRleHQtbW90aW9uIHQpKQogICAgICAgICAgICAg ICAoaW5zZXJ0IChhcHBseSAjJ3Byb3BlcnRpemUgIiAgIiAodGV4dC1wcm9wZXJ0aWVzLWF0 IChwb2ludCkpKSkKICAgICAgICAgICAgICAgKGJlZ2lubmluZy1vZi1saW5lKSkpCiAgICAg ICAgICAgKHNldHEgbyAobWFrZS1vdmVybGF5IChwb2ludCkgKDErIChwb2ludCkpKSkKQEAg LTE4NjYsNyArMTg3NSw4IEBAIG91dGxpbmUtLWZpeC11cC1hbGwtYnV0dG9ucwogICAgICh3 aGVuIGZyb20KICAgICAgIChzYXZlLWV4Y3Vyc2lvbgogICAgICAgICAoZ290by1jaGFyIGZy b20pCi0gICAgICAgIChzZXRxIGZyb20gKGxpbmUtYmVnaW5uaW5nLXBvc2l0aW9uKSkpKQor ICAgICAgICAobGV0ICgoaW5oaWJpdC1maWVsZC10ZXh0LW1vdGlvbiB0KSkKKyAgICAgICAg ICAoc2V0cSBmcm9tIChsaW5lLWJlZ2lubmluZy1wb3NpdGlvbikpKSkpCiAgICAgKG91dGxp bmUtbWFwLXJlZ2lvbgogICAgICAobGFtYmRhICgpCiAgICAgICAgKGxldCAoKGNsb3NlLXAg KHNhdmUtZXhjdXJzaW9uCi0tIAoyLjI1LjEKCg== --------------ItyODbWPSbEktLWwM8O8fb3s-- From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 07 12:47:45 2024 Received: (at 68881) by debbugs.gnu.org; 7 Feb 2024 17:47:45 +0000 Received: from localhost ([127.0.0.1]:57861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXm1R-0004Sj-CZ for submit@debbugs.gnu.org; Wed, 07 Feb 2024 12:47:45 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:33905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rXm1P-0004SI-Fs for 68881@debbugs.gnu.org; Wed, 07 Feb 2024 12:47:43 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 680FF240004; Wed, 7 Feb 2024 17:47:23 +0000 (UTC) From: Juri Linkov To: Jim Porter Subject: Re: bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' In-Reply-To: <83986cee-a32d-707f-6ee0-ec1ba2bd42c2@gmail.com> (Jim Porter's message of "Thu, 1 Feb 2024 15:51:57 -0800") Organization: LINKOV.NET References: <83986cee-a32d-707f-6ee0-ec1ba2bd42c2@gmail.com> Date: Wed, 07 Feb 2024 19:37:11 +0200 Message-ID: <86a5ocgp74.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68881 Cc: 68881@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I'd like to add support for 'outline-minor-mode' in Eshell. However, > Eshell's use of field properties confuses outline.el. Attached is a WIP > patch + demo code for Eshell that should resolve this. > > The main issue was that outline.el uses 'line-beginning-position' and > friends, which respects field boundaries, but I think we want to avoid that > for 'outline-minor-mode'. Maybe we could use 'pos-bol' and friends instead, > but my understanding is that 'line-beginning-position' respects display > directionality (which we probably want), but 'pos-bol' doesn't. I'm not aware of any cases that would require restricting outlines to field boundaries. > You can try things out here by starting Eshell and activating > 'outline-minor-mode'. You can also see the problems by applying only the > Eshell part of the patch. Thanks. I tried and confirm that your outline.el patch fixes the issue. > Any thoughts? Is this the right way to go about this? (Note: I think the > Eshell side of things will take more work, which I'll address in a later > bug. However, this should be enough to show off the problems on the > outline.el side.) There is also one occurrence of 'line-end-position' in outline.el. Should it have 'inhibit-field-text-motion' as well? From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 13:55:17 2024 Received: (at 68881) by debbugs.gnu.org; 10 Feb 2024 18:55:17 +0000 Received: from localhost ([127.0.0.1]:33411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYsVQ-0003hA-AQ for submit@debbugs.gnu.org; Sat, 10 Feb 2024 13:55:17 -0500 Received: from mail-pg1-f173.google.com ([209.85.215.173]:58434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYs7Q-0002bc-VY for 68881@debbugs.gnu.org; Sat, 10 Feb 2024 13:30:29 -0500 Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-5d8ddbac4fbso1789513a12.0 for <68881@debbugs.gnu.org>; Sat, 10 Feb 2024 10:30:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707589807; x=1708194607; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=X1y2zz6jW0HqivT7IE0u3MNAKoGzod3vt8dbbImCj9w=; b=kfRXdjGaJXtge/cl/VpiCmEGt6noQVn7Qq1F8fIeCBKH/1D9enIOIztw2v988eUH+f GbuTuJ4QVJBldKhwhe/KtkFeNbSEtbC5nJKHMmsxvmFLrqKKjTv8DVU0DB1A9H9+0iqr KgBTlIjxX4WE3NjriT0qAoW0y34OCX5skI/gdYRYIfM+mCOpvcy1pslFWYxTD84y4Hi0 BDz0JcmwPjvnHJPrG0DWKMcOs/khKpaaLOgWBRgM+U24JbmpzlM7lxnm116qrUEnTWNu wZaYgNHxdQGeAPJHO3L3mWOzrtyhzkeCGCIsOSkX0U2CjckUkc+NXa6RDiznaiFa+NvU 9urQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707589807; x=1708194607; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=X1y2zz6jW0HqivT7IE0u3MNAKoGzod3vt8dbbImCj9w=; b=jr13r+hK79M3Sba5jzHoClkVu0NUGkpFccBcQ4u48/MoIBNDRmbSsyGViMY3pGmKAO UMh+mluIh2VyHlp7dfb507FFeQhehvAQ/8Rz3NlkS2wg5G59nUhoNa6W6vbRhHm8ulQj mY+83Xb6AeTnV2G6LHCS4JN2v8XeLXZp651IBfb0GfW7bDAN86RPee8o/gPA7eM4Ho6v tcf8Xqo9G2GW8tH3YXntaNLn+vril8HfA7JRE7gJ20aGrLhQOPlv7VE94pMerwiJoT6S VDecWmLcNj8vVw8uLGZax6I+VQBBOuTl1b7/o05eIMvA16+RQE8lPQMBNPgwRT+DDMMn ZwIg== X-Gm-Message-State: AOJu0YzYb/ynGlLZpod8h5pcmCtfLUGO07Tnbn4ZaRFS5DW9FWmCZoTj DCaxVWZHJAzJynA9zCq7vojLudAHU4UIz9YxKhUPqSkaYQivBMG8bYv36nvx X-Google-Smtp-Source: AGHT+IFCN8bl0bdXeTRXkaKUoF+hI6O5Z9jP2/SVblxTjWveyWOkHfuIwaJZ9Nsy/2NqaSUlWxI7eA== X-Received: by 2002:a17:902:9a07:b0:1d9:ee5f:a975 with SMTP id v7-20020a1709029a0700b001d9ee5fa975mr3195488plp.25.1707589334418; Sat, 10 Feb 2024 10:22:14 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id ok8-20020a17090b1d4800b00297022db05dsm3881287pjb.40.2024.02.10.10.22.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Feb 2024 10:22:13 -0800 (PST) Content-Type: multipart/mixed; boundary="------------3hWMSeY4qU0x9jjG5tnXWAse" Message-ID: Date: Sat, 10 Feb 2024 10:22:16 -0800 MIME-Version: 1.0 Subject: Re: bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' Content-Language: en-US To: Juri Linkov References: <83986cee-a32d-707f-6ee0-ec1ba2bd42c2@gmail.com> <86a5ocgp74.fsf@mail.linkov.net> From: Jim Porter In-Reply-To: <86a5ocgp74.fsf@mail.linkov.net> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68881 Cc: 68881@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------3hWMSeY4qU0x9jjG5tnXWAse Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/7/2024 9:37 AM, Juri Linkov wrote: >> The main issue was that outline.el uses 'line-beginning-position' and >> friends, which respects field boundaries, but I think we want to avoid that >> for 'outline-minor-mode'. Maybe we could use 'pos-bol' and friends instead, >> but my understanding is that 'line-beginning-position' respects display >> directionality (which we probably want), but 'pos-bol' doesn't. > > I'm not aware of any cases that would require restricting > outlines to field boundaries. Thanks. After reading the source (generally a good idea), I now see that 'line-beginning-position' doesn't respect display directionality, so there's no reason to use it over 'pos-bol' and friends. I've therefore updated the patch to use those, which makes things a bit simpler. (In any case, I think for RTL, we'd want to use the logical ordering of the text anyway, but possibly add the outline buttons on the right side of the window instead. That's out of scope for this bug though.) > There is also one occurrence of 'line-end-position' in outline.el. > Should it have 'inhibit-field-text-motion' as well? Thanks for the catch. Updated this as well. (I also split out the Eshell demonstration patch so that I can drop the commit more easily before merging. It's still attached here though in case you or anyone else want to try it out.) --------------3hWMSeY4qU0x9jjG5tnXWAse Content-Type: text/plain; charset=UTF-8; name="0001-Make-outline.el-ignore-field-properties-in-text.patch" Content-Disposition: attachment; filename*0="0001-Make-outline.el-ignore-field-properties-in-text.patch" Content-Transfer-Encoding: base64 RnJvbSAyOWEzNmMxYzMyYmNlNjY0NjhiODVhYTkzMWZlMmM3YThjYzQ5MWUyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMSBGZWIgMjAyNCAxMzo1ODoyMCAtMDgwMApTdWJqZWN0OiBbUEFU Q0ggMS8yXSBNYWtlIG91dGxpbmUuZWwgaWdub3JlIGZpZWxkIHByb3BlcnRpZXMgaW4gdGV4 dAoKKiBsaXNwL291dGxpbmUuZWwgKG91dGxpbmUtYmFjay10by1oZWFkaW5nLCBvdXRsaW5l LW9uLWhlYWRpbmctcCkKKG91dGxpbmUtbmV4dC12aXNpYmxlLWhlYWRpbmcsIG91dGxpbmUt bWFyay1zdWJ0cmVlKQoob3V0bGluZS1oaWRlLXN1YmxldmVscywgb3V0bGluZS0taW5zZXJ0 LWJ1dHRvbikKKG91dGxpbmUtLWZpeC11cC1hbGwtYnV0dG9ucyk6IEluaGliaXQgZmllbGQg dGV4dCBtb3Rpb24gKGJ1ZyM2ODg4MSkuCi0tLQogbGlzcC9vdXRsaW5lLmVsIHwgMjQgKysr KysrKysrKystLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygr KSwgMTMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vdXRsaW5lLmVsIGIvbGlz cC9vdXRsaW5lLmVsCmluZGV4IGI1MDcwOGMxYTdiLi4zMzQ0NzQ3MjEwMCAxMDA2NDQKLS0t IGEvbGlzcC9vdXRsaW5lLmVsCisrKyBiL2xpc3Avb3V0bGluZS5lbApAQCAtNjg2LDcgKzY4 Niw3IEBAICdvdXRsaW5lLWJlZm9yZS1maXJzdC1oZWFkaW5nCiAoZGVmdW4gb3V0bGluZS1i YWNrLXRvLWhlYWRpbmcgKCZvcHRpb25hbCBpbnZpc2libGUtb2spCiAgICJNb3ZlIHRvIHBy ZXZpb3VzIGhlYWRpbmcgbGluZSwgb3IgYmVnIG9mIHRoaXMgbGluZSBpZiBpdCdzIGEgaGVh ZGluZy4KIE9ubHkgdmlzaWJsZSBoZWFkaW5nIGxpbmVzIGFyZSBjb25zaWRlcmVkLCB1bmxl c3MgSU5WSVNJQkxFLU9LIGlzIG5vbi1uaWwuIgotICAoYmVnaW5uaW5nLW9mLWxpbmUpCisg IChmb3J3YXJkLWxpbmUgMCkKICAgKG9yIChvdXRsaW5lLW9uLWhlYWRpbmctcCBpbnZpc2li bGUtb2spCiAgICAgICAobGV0IChmb3VuZCkKIAkoc2F2ZS1leGN1cnNpb24KQEAgLTcwNSw3 ICs3MDUsNyBAQCBvdXRsaW5lLW9uLWhlYWRpbmctcAogICAiUmV0dXJuIHQgaWYgcG9pbnQg aXMgb24gYSAodmlzaWJsZSkgaGVhZGluZyBsaW5lLgogSWYgSU5WSVNJQkxFLU9LIGlzIG5v bi1uaWwsIGFuIGludmlzaWJsZSBoZWFkaW5nIGxpbmUgaXMgb2sgdG9vLiIKICAgKHNhdmUt ZXhjdXJzaW9uCi0gICAgKGJlZ2lubmluZy1vZi1saW5lKQorICAgIChmb3J3YXJkLWxpbmUg MCkKICAgICAoYW5kIChib2xwKSAob3IgaW52aXNpYmxlLW9rIChub3QgKG91dGxpbmUtaW52 aXNpYmxlLXApKSkKIAkgKGlmIG91dGxpbmUtc2VhcmNoLWZ1bmN0aW9uCiAgICAgICAgICAg ICAgKGZ1bmNhbGwgb3V0bGluZS1zZWFyY2gtZnVuY3Rpb24gbmlsIG5pbCBuaWwgdCkKQEAg LTcyNSw3ICs3MjUsNyBAQCBvdXRsaW5lLWluc2VydC1oZWFkaW5nCiAJCShub3QgKHN0cmlu Zy1tYXRjaCAoY29uY2F0ICJcXGBcXCg/OiIgb3V0bGluZS1yZWdleHAgIlxcKSIpCiAJCQkJ ICAgKGNvbmNhdCBoZWFkICIgIikpKSkKICAgICAgIChzZXRxIGhlYWQgKGNvbmNhdCBoZWFk ICIgIikpKQotICAgICh1bmxlc3MgKGJvbHApIChlbmQtb2YtbGluZSkgKG5ld2xpbmUpKQor ICAgICh1bmxlc3MgKGJvbHApIChnb3RvLWNoYXIgKHBvcy1ib2wpKSAobmV3bGluZSkpCiAg ICAgKGluc2VydCBoZWFkKQogICAgICh1bmxlc3MgKGVvbHApCiAgICAgICAoc2F2ZS1leGN1 cnNpb24gKG5ld2xpbmUtYW5kLWluZGVudCkpKQpAQCAtOTQxLDkgKzk0MSw3IEBAIG91dGxp bmUtbmV4dC12aXNpYmxlLWhlYWRpbmcKIEEgaGVhZGluZyBsaW5lIGlzIG9uZSB0aGF0IHN0 YXJ0cyB3aXRoIGEgYConIChvciB0aGF0CiBgb3V0bGluZS1yZWdleHAnIG1hdGNoZXMpLiIK ICAgKGludGVyYWN0aXZlICJwIikKLSAgKGlmICg8IGFyZyAwKQotICAgICAgKGJlZ2lubmlu Zy1vZi1saW5lKQotICAgIChlbmQtb2YtbGluZSkpCisgIChnb3RvLWNoYXIgKGlmICg8IGFy ZyAwKSAocG9zLWJvbCkgKHBvcy1lb2wpKSkKICAgKGxldCAoKHJlZ2V4cCAodW5sZXNzIG91 dGxpbmUtc2VhcmNoLWZ1bmN0aW9uCiAgICAgICAgICAgICAgICAgICAoY29uY2F0ICJeXFwo PzoiIG91dGxpbmUtcmVnZXhwICJcXCkiKSkpCiAgICAgICAgIGZvdW5kLWhlYWRpbmctcCkK QEAgLTk2Myw3ICs5NjEsNyBAQCBvdXRsaW5lLW5leHQtdmlzaWJsZS1oZWFkaW5nCiAgICAg ICAgICAgICAgICAgICAgICAgICAgIChyZS1zZWFyY2gtZm9yd2FyZCByZWdleHAgbmlsICdt b3ZlKSkpCiAJCSAgKG91dGxpbmUtaW52aXNpYmxlLXAgKG1hdGNoLWJlZ2lubmluZyAwKSkp KQogICAgICAgKHNldHEgYXJnICgxLSBhcmcpKSkKLSAgICAoaWYgZm91bmQtaGVhZGluZy1w IChiZWdpbm5pbmctb2YtbGluZSkpKSkKKyAgICAoaWYgZm91bmQtaGVhZGluZy1wIChmb3J3 YXJkLWxpbmUgMCkpKSkKIAogKGRlZnVuIG91dGxpbmUtcHJldmlvdXMtdmlzaWJsZS1oZWFk aW5nIChhcmcpCiAgICJNb3ZlIHRvIHRoZSBwcmV2aW91cyBoZWFkaW5nIGxpbmUuCkBAIC05 ODAsNyArOTc4LDcgQEAgb3V0bGluZS1tYXJrLXN1YnRyZWUKICAgKGxldCAoKGJlZykpCiAg ICAgKGlmIChvdXRsaW5lLW9uLWhlYWRpbmctcCkKIAk7OyB3ZSBhcmUgYWxyZWFkeSBsb29r aW5nIGF0IGEgaGVhZGluZwotCShiZWdpbm5pbmctb2YtbGluZSkKKyAgICAgICAgKGZvcndh cmQtbGluZSAwKQogICAgICAgOzsgZWxzZSBnbyBiYWNrIHRvIHByZXZpb3VzIGhlYWRpbmcK ICAgICAgIChvdXRsaW5lLXByZXZpb3VzLXZpc2libGUtaGVhZGluZyAxKSkKICAgICAoc2V0 cSBiZWcgKHBvaW50KSkKQEAgLTExODMsNyArMTE4MSw3IEBAIG91dGxpbmUtaGlkZS1zdWJs ZXZlbHMKIAkJKGNvbmQKIAkJIChjdXJyZW50LXByZWZpeC1hcmcgKHByZWZpeC1udW1lcmlj LXZhbHVlIGN1cnJlbnQtcHJlZml4LWFyZykpCiAJCSAoKHNhdmUtZXhjdXJzaW9uCi0gICAg ICAgICAgICAgICAgICAgIChiZWdpbm5pbmctb2YtbGluZSkKKyAgICAgICAgICAgICAgICAg ICAgKGZvcndhcmQtbGluZSAwKQogCQkgICAgKGlmIG91dGxpbmUtc2VhcmNoLWZ1bmN0aW9u CiAgICAgICAgICAgICAgICAgICAgICAgICAoZnVuY2FsbCBvdXRsaW5lLXNlYXJjaC1mdW5j dGlvbiBuaWwgbmlsIG5pbCB0KQogICAgICAgICAgICAgICAgICAgICAgIChsb29raW5nLWF0 IG91dGxpbmUtcmVnZXhwKSkpCkBAIC0xMjQzLDcgKzEyNDEsNyBAQCBvdXRsaW5lLXRvZ2ds ZS1jaGlsZHJlbgogICAoaW50ZXJhY3RpdmUpCiAgIChzYXZlLWV4Y3Vyc2lvbgogICAgIChv dXRsaW5lLWJhY2stdG8taGVhZGluZykKLSAgICAoaWYgKG5vdCAob3V0bGluZS1pbnZpc2li bGUtcCAobGluZS1lbmQtcG9zaXRpb24pKSkKKyAgICAoaWYgKG5vdCAob3V0bGluZS1pbnZp c2libGUtcCAocG9zLWVvbCkpKQogICAgICAgICAob3V0bGluZS1oaWRlLXN1YnRyZWUpCiAg ICAgICAob3V0bGluZS1zaG93LWNoaWxkcmVuKQogICAgICAgKG91dGxpbmUtc2hvdy1lbnRy eSkpKSkKQEAgLTE4MzQsNyArMTgzMiw3IEBAIG91dGxpbmUtLWNyZWF0ZS1idXR0b24taWNv bnMKIChkZWZ1biBvdXRsaW5lLS1pbnNlcnQtYnV0dG9uICh0eXBlKQogICAod2l0aC1zaWxl bnQtbW9kaWZpY2F0aW9ucwogICAgIChzYXZlLWV4Y3Vyc2lvbgotICAgICAgKGJlZ2lubmlu Zy1vZi1saW5lKQorICAgICAgKGZvcndhcmQtbGluZSAwKQogICAgICAgKGxldCAoKGljb24g KG50aCAoaWYgKGVxIHR5cGUgJ2Nsb3NlKSAxIDApIG91dGxpbmUtLWJ1dHRvbi1pY29ucykp CiAgICAgICAgICAgICAobyAoc2VxLWZpbmQgKGxhbWJkYSAobykgKG92ZXJsYXktZ2V0IG8g J291dGxpbmUtYnV0dG9uKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAob3ZlcmxheXMt YXQgKHBvaW50KSkpKSkKQEAgLTE4NDIsNyArMTg0MCw3IEBAIG91dGxpbmUtLWluc2VydC1i dXR0b24KICAgICAgICAgICAod2hlbiAoZXEgb3V0bGluZS1taW5vci1tb2RlLXVzZS1idXR0 b25zICdpbnNlcnQpCiAgICAgICAgICAgICAobGV0ICgoaW5oaWJpdC1yZWFkLW9ubHkgdCkp CiAgICAgICAgICAgICAgIChpbnNlcnQgKGFwcGx5ICMncHJvcGVydGl6ZSAiICAiICh0ZXh0 LXByb3BlcnRpZXMtYXQgKHBvaW50KSkpKQotICAgICAgICAgICAgICAoYmVnaW5uaW5nLW9m LWxpbmUpKSkKKyAgICAgICAgICAgICAgKGZvcndhcmQtbGluZSAwKSkpCiAgICAgICAgICAg KHNldHEgbyAobWFrZS1vdmVybGF5IChwb2ludCkgKDErIChwb2ludCkpKSkKICAgICAgICAg ICAob3ZlcmxheS1wdXQgbyAnb3V0bGluZS1idXR0b24gdCkKICAgICAgICAgICAob3Zlcmxh eS1wdXQgbyAnZXZhcG9yYXRlIHQpKQpAQCAtMTg2Niw3ICsxODY0LDcgQEAgb3V0bGluZS0t Zml4LXVwLWFsbC1idXR0b25zCiAgICAgKHdoZW4gZnJvbQogICAgICAgKHNhdmUtZXhjdXJz aW9uCiAgICAgICAgIChnb3RvLWNoYXIgZnJvbSkKLSAgICAgICAgKHNldHEgZnJvbSAobGlu ZS1iZWdpbm5pbmctcG9zaXRpb24pKSkpCisgICAgICAgIChzZXRxIGZyb20gKHBvcy1ib2wp KSkpCiAgICAgKG91dGxpbmUtbWFwLXJlZ2lvbgogICAgICAobGFtYmRhICgpCiAgICAgICAg KGxldCAoKGNsb3NlLXAgKHNhdmUtZXhjdXJzaW9uCi0tIAoyLjI1LjEKCg== --------------3hWMSeY4qU0x9jjG5tnXWAse Content-Type: text/plain; charset=UTF-8; name="0002-DO-NOT-MERGE-Test-commit-for-previous-patch.patch" Content-Disposition: attachment; filename="0002-DO-NOT-MERGE-Test-commit-for-previous-patch.patch" Content-Transfer-Encoding: base64 RnJvbSBmYTdlNGFjYWE4MDc5OTA1NTg2Njg2NmYxY2YzZjljN2IzZmY1NWU1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IEZyaSwgOSBGZWIgMjAyNCAyMjoxODozNSAtMDgwMApTdWJqZWN0OiBbUEFU Q0ggMi8yXSBbRE8gTk9UIE1FUkdFXSBUZXN0IGNvbW1pdCBmb3IgcHJldmlvdXMgcGF0Y2gK Ci0tLQogbGlzcC9lc2hlbGwvZW0tcHJvbXB0LmVsIHwgMTQgKysrKysrKysrKysrKy0KIDEg ZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEvbGlzcC9lc2hlbGwvZW0tcHJvbXB0LmVsIGIvbGlzcC9lc2hlbGwvZW0tcHJvbXB0 LmVsCmluZGV4IDM2NjJjMWZhODk1Li5iZjNhMjQ2ODlmOCAxMDA2NDQKLS0tIGEvbGlzcC9l c2hlbGwvZW0tcHJvbXB0LmVsCisrKyBiL2xpc3AvZXNoZWxsL2VtLXByb21wdC5lbApAQCAt MTA3LDYgKzEwNywxNCBAQCBlc2hlbGwtcHJvbXB0LXJlcGVhdC1tYXAKIAogOzs7IEZ1bmN0 aW9uczoKIAorKGRlZnVuIGVzaGVsbC1vdXRsaW5lLXNlYXJjaCAoJm9wdGlvbmFsIGJvdW5k IG1vdmUgYmFja3dhcmQgbG9va2luZy1hdCkKKyAgIlNlYXJjaCBmb3Igb3V0bGluZSBoZWFk aW5ncy4gIFNlZSBgb3V0bGluZS1zZWFyY2gtZnVuY3Rpb24nLiIKKyAgOzsgRklYTUU6IFRo aXMgcHJvYmFibHkgaXNuJ3QgdGhlIHJpZ2h0IHdheSB0byBkbyB0aGluZ3MuICBEb2VzIGl0 CisgIDs7IHdvcmsgd2l0aCBtdWx0aWxpbmUgcHJvbXB0cz8gIFN0aWxsLCBpdCdzIHVzZWZ1 bCBmb3IgYSBwcm9vZiBvZgorICA7OyBjb25jZXB0LgorICAob3V0bGluZS1zZWFyY2gtdGV4 dC1wcm9wZXJ0eSAnZmllbGQgJ3Byb21wdCBib3VuZCBtb3ZlIGJhY2t3YXJkCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIGxvb2tpbmctYXQpKQorCiAoZGVmaW5lLW1pbm9y LW1vZGUgZXNoZWxsLXByb21wdC1tb2RlCiAgICJNaW5vciBtb2RlIGZvciBlc2hlbGwtcHJv bXB0IG1vZHVsZS4KIApAQCAtMTE3LDcgKzEyNSwxMSBAQCBlc2hlbGwtcHJvbXB0LWluaXRp YWxpemUKICAgIkluaXRpYWxpemUgdGhlIHByb21wdGluZyBjb2RlLiIKICAgKHVubGVzcyBl c2hlbGwtbm9uLWludGVyYWN0aXZlLXAKICAgICAoYWRkLWhvb2sgJ2VzaGVsbC1wb3N0LWNv bW1hbmQtaG9vayAnZXNoZWxsLWVtaXQtcHJvbXB0IG5pbCB0KQotICAgIChlc2hlbGwtcHJv bXB0LW1vZGUpKSkKKyAgICAoZXNoZWxsLXByb21wdC1tb2RlKQorCisgICAgKHNldHEtbG9j YWwgb3V0bGluZS1zZWFyY2gtZnVuY3Rpb24gIydlc2hlbGwtb3V0bGluZS1zZWFyY2gKKyAg ICAgICAgICAgICAgICBvdXRsaW5lLWxldmVsIChsYW1iZGEgKCkgMSkKKyAgICAgICAgICAg ICAgICBvdXRsaW5lLW1pbm9yLW1vZGUtdXNlLWJ1dHRvbnMgJ2luLW1hcmdpbnMpKSkKIAog KGRlZnVuIGVzaGVsbC1lbWl0LXByb21wdCAoKQogICAiRW1pdCBhIHByb21wdCBpZiBlc2hl bGwgaXMgYmVpbmcgdXNlZCBpbnRlcmFjdGl2ZWx5LiIKLS0gCjIuMjUuMQoK --------------3hWMSeY4qU0x9jjG5tnXWAse-- From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 14:24:03 2024 Received: (at 68881) by debbugs.gnu.org; 10 Feb 2024 19:24:03 +0000 Received: from localhost ([127.0.0.1]:35074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYsxH-0004zU-Cp for submit@debbugs.gnu.org; Sat, 10 Feb 2024 14:24:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYsxF-0004yf-4y for 68881@debbugs.gnu.org; Sat, 10 Feb 2024 14:24:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYswt-00079X-Cq; Sat, 10 Feb 2024 14:23:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ax5Wi/h3598TMJIq8JKi/YA/xGTpdCgbQOL9AntupYM=; b=pMNeKi+uAyrn qkPgsIxBJemUbdqjtTDlMJFOQlqrK28UkYiKXmjksDxyd+kHzxbw7/jbc5labMFJ3l8MqHxf21NIo akkAI2nT/5o36MbqbROzFEtl+BUx9T5PxDGzT9SGmVrwEJtnUFHEFYcRYQit/3L32IraDSfqlSr4u 00kryHhanlZ8qhV9V+l2qeYscAgK/v1KDUbq6X1eQOkt+W46oGiWj8ut20EDNUcqIvZknt6KxYN/9 827KXA37qL+wDXiGJBL7Zmh1yDcaU6unHwTGNzlsxCI3ChtpKgDMulwh3TW3VK9APgI1ZaHEF1UJd NO+GVGhE5rTM/felj0wRvA==; Date: Sat, 10 Feb 2024 21:23:37 +0200 Message-Id: <86cyt4t96u.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Sat, 10 Feb 2024 10:22:16 -0800) Subject: Re: bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' References: <83986cee-a32d-707f-6ee0-ec1ba2bd42c2@gmail.com> <86a5ocgp74.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68881 Cc: 68881@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 68881@debbugs.gnu.org > Date: Sat, 10 Feb 2024 10:22:16 -0800 > From: Jim Porter > > On 2/7/2024 9:37 AM, Juri Linkov wrote: > >> The main issue was that outline.el uses 'line-beginning-position' and > >> friends, which respects field boundaries, but I think we want to avoid that > >> for 'outline-minor-mode'. Maybe we could use 'pos-bol' and friends instead, > >> but my understanding is that 'line-beginning-position' respects display > >> directionality (which we probably want), but 'pos-bol' doesn't. > > > > I'm not aware of any cases that would require restricting > > outlines to field boundaries. > > Thanks. After reading the source (generally a good idea), I now see that > 'line-beginning-position' doesn't respect display directionality, so > there's no reason to use it over 'pos-bol' and friends. I've therefore > updated the patch to use those, which makes things a bit simpler. > > (In any case, I think for RTL, we'd want to use the logical ordering of > the text anyway, but possibly add the outline buttons on the right side > of the window instead. That's out of scope for this bug though.) I don't understand what text directionality has to do with the issue at hand. If you elaborate, I could perhaps be of assistance in this matter. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 10 16:25:18 2024 Received: (at 68881) by debbugs.gnu.org; 10 Feb 2024 21:25:18 +0000 Received: from localhost ([127.0.0.1]:42764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYuqb-0007j2-JQ for submit@debbugs.gnu.org; Sat, 10 Feb 2024 16:25:18 -0500 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]:46507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYugX-0007EG-DY for 68881@debbugs.gnu.org; Sat, 10 Feb 2024 16:14:53 -0500 Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-5d8b519e438so1746539a12.1 for <68881@debbugs.gnu.org>; Sat, 10 Feb 2024 13:14:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707599671; x=1708204471; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=AnERSqfkA8JGsUrShui6Py6Np1JfaCJTrWewqRMiHy0=; b=cn9pSKrdYyHovcQhFuHYVaVox9PSkB1e7YAr732Ppdc9Y4CiGl2Nvm27YVyN+QD3Tx 57Hly7XGs7bThyC6WqlhvbK0m0xiRF/RobKB9wL6gV+zeyjH5FwasZfA/FDYy7hRTEkD uHQaWjU9KTjL0RJ35Vi91Ot+SOArhOdTQwq/kO4zHQQ0d5xT9L8mheXq11seQyqgb5tZ kup2NLUfZIfjYOrs8CoqSZH2rax+VmaPb/RY1fZ6u9Xo9EqcWub+ih8Mp1fFc8Dd5NfY i8th+uNWCWgSZ3e3F2YYbvCb3t3GB4svF+hdztrlA3y9KOVO0ulPHiilB71n/067cPg4 GdqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707599671; x=1708204471; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AnERSqfkA8JGsUrShui6Py6Np1JfaCJTrWewqRMiHy0=; b=Rb+mK4ngAzBQN1dPJpO2ZklTAQ11hBshLHLbZzymnNpJiyu1TnvrX+XCXkOmYgxuef fbEziM4BVdkU59KyCgeJelpJ/UPZx/pCbSgOwlxKBI9f+H/cjcmkMEW1e4CT0kJCIswU mqmRZmWzOZrd4cQ/R03BX6/lgvnu39x5oqAzYQQEhFq7tAsJYIYuuPuUmYZJTbp2z6wu jwAtnFPNIxjXEQi2RCQqZFCSToeBiAcKJcc8gzp6HGGWLG8bjUAZr/EVgSz/CMgnFXOC N8r3WPLto3Dn6HHtsbk4l/bkTM1aoBvmwyQAOmqhEWHJfYr79o6E23S41caOI6sBn03Y Go/Q== X-Gm-Message-State: AOJu0YzBTtxFXXQZOCauUiiAX7EIOWSs9GH1AB/lLaY4he6WzAdnbUCR vpEuEuQ5xI+D42VK9zO5yoDhwxiNEfJALXmXPcXAxQP6OQ1ah/hD X-Google-Smtp-Source: AGHT+IHSMh2GBRU1KqxLvOcKHyR2uf8k2S78MCP5m33rVC6vQdOd+o1h9ScDtH3oEkakPHTJ1QtK6g== X-Received: by 2002:a05:6a20:9d91:b0:19e:b192:1db2 with SMTP id mu17-20020a056a209d9100b0019eb1921db2mr2079398pzb.30.1707599671503; Sat, 10 Feb 2024 13:14:31 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWEasbcwUeJpn6waVahV8iyvjtBGnG9EFAUC9rwAGJwxmZk5znDGz3iGjscwycIXFBruJyJ6wypuGPiIS5TPjg= Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id q5-20020a632a05000000b005d34cf68664sm4048765pgq.25.2024.02.10.13.14.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Feb 2024 13:14:30 -0800 (PST) Message-ID: <254d7a98-d39d-2481-5a2a-01eea80fb657@gmail.com> Date: Sat, 10 Feb 2024 13:14:34 -0800 MIME-Version: 1.0 Subject: Re: bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' Content-Language: en-US To: Eli Zaretskii References: <83986cee-a32d-707f-6ee0-ec1ba2bd42c2@gmail.com> <86a5ocgp74.fsf@mail.linkov.net> <86cyt4t96u.fsf@gnu.org> From: Jim Porter In-Reply-To: <86cyt4t96u.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68881 Cc: 68881@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/10/2024 11:23 AM, Eli Zaretskii wrote: > I don't understand what text directionality has to do with the issue > at hand. If you elaborate, I could perhaps be of assistance in this > matter. I think nothing in this case. I just wasn't sure initially whether 'pos-bol' and 'line-beginning-position' handled directionality differently. Since they handle it the same way, I think there's no harm in using 'pos-bol' in this case. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 01:08:17 2024 Received: (at 68881) by debbugs.gnu.org; 11 Feb 2024 06:08:17 +0000 Received: from localhost ([127.0.0.1]:51194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZ30i-0004JP-R9 for submit@debbugs.gnu.org; Sun, 11 Feb 2024 01:08:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZ30e-0004J1-Dv for 68881@debbugs.gnu.org; Sun, 11 Feb 2024 01:08:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZ30H-0007H5-Vh; Sun, 11 Feb 2024 01:07:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=omBU1vcJ6oBpzyhOv0nc5RnNYnSUoiR2kACYev6t5kY=; b=pIgVxJ5QE+Cj YoVzlwUTKhLcOIlAWMY93PSPo2gniaFD6H6NN6IdkI+3niMN5KnoX7F7CPWGs3pjkRYns0NaaQj5y Apd7t2x+GZyOIwZcd7xYi2XVOmXQh1toewvGSOAXKFE3L3NeTF4nCm35ZT4nb/QARVXWIaa6hyhK5 1RJGbosJ3N25YdNezIff46IyiwPfAoQQnxZhKs0HgUmS3N7a96XN/EQoHRZ22j9Jr+CA92LSe5sBv Pjeiwgw/iLmQyyUBJkVIbVmWikuzpwi03luxpMj1Q1LQ9WOZNdhpd+F4UeKzCM5f1uzgdptfh8bDM yt5Vee77WbhznwUlbp9rig==; Date: Sun, 11 Feb 2024 08:07:47 +0200 Message-Id: <865xyvttxo.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <254d7a98-d39d-2481-5a2a-01eea80fb657@gmail.com> (message from Jim Porter on Sat, 10 Feb 2024 13:14:34 -0800) Subject: Re: bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' References: <83986cee-a32d-707f-6ee0-ec1ba2bd42c2@gmail.com> <86a5ocgp74.fsf@mail.linkov.net> <86cyt4t96u.fsf@gnu.org> <254d7a98-d39d-2481-5a2a-01eea80fb657@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68881 Cc: 68881@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 10 Feb 2024 13:14:34 -0800 > Cc: 68881@debbugs.gnu.org, juri@linkov.net > From: Jim Porter > > On 2/10/2024 11:23 AM, Eli Zaretskii wrote: > > I don't understand what text directionality has to do with the issue > > at hand. If you elaborate, I could perhaps be of assistance in this > > matter. > > I think nothing in this case. I just wasn't sure initially whether > 'pos-bol' and 'line-beginning-position' handled directionality > differently. Since they handle it the same way, I think there's no harm > in using 'pos-bol' in this case. They both go to the smallest buffer position of the line (modulo the fields issue). If an LTR line starts with RTL characters, that buffer position will not be the leftmost one, but that's all. (I don't think we have a function to go to the position that is the leftmost on display, probably because that was never needed.) From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 02:09:17 2024 Received: (at 68881) by debbugs.gnu.org; 11 Feb 2024 07:09:17 +0000 Received: from localhost ([127.0.0.1]:54316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZ3xl-0001Xv-6Q for submit@debbugs.gnu.org; Sun, 11 Feb 2024 02:09:17 -0500 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]:61879) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZ3xi-0001XZ-8I for 68881@debbugs.gnu.org; Sun, 11 Feb 2024 02:09:15 -0500 Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-363b2cc93a8so9561355ab.3 for <68881@debbugs.gnu.org>; Sat, 10 Feb 2024 23:08:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707635332; x=1708240132; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=U4oJ1MLflQE/hgpNy/k0/JAtKQVnVi3bjQBj5LGWyjA=; b=Lae24z4lI1niSho6jr/yeNJ9Z1kHUOagG/9v5k361oLpxmvAFkfIk4NEhEIWDK/sMC j7NYOPtN5bfQeD47NBKGAfLJH9TUhXitF3UCfBgwW9rNRqukJR7Faq6ANsHCGrKc/nua BbInJvbHj/q2morgkUDBtgafoWJ4h5BKv4scvb6iZQx5VX9liu0aaK6jnHWchfKDRlzm Y2Gs4yrdXMRrj2G3AfTGw5mbZJCouseBp/xqywS49F94l1N0aFynP1IsxysiZWCPj5Cp OplHT/CH0DQI1hB6szBceWf2KbCRIttLFct+YYVUoaoAlq0BicIRfjRDLeoyAFtmfQmi gxFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707635332; x=1708240132; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=U4oJ1MLflQE/hgpNy/k0/JAtKQVnVi3bjQBj5LGWyjA=; b=Xzn8SiU2n/Xm0uqm+YxrYA5d1SviM7LX0HV5UTPb1GooSJEEgc0s0yQRNGbEhcMYjA hlcI8GsLMfpMyFcvT1h9uvrAYuNhNkbboiMCsQunDos+H0yzOhmkVrk4pjAoETJtw5lp 0PNUaq5GX6hNNtO74u9FIzx8PfmLC51+q8/SDN+22t6G19+jJMosqSZI/nw2ZW+H2nEM hlHCsLH5Be8RfmqboEwhqQMrXy1tecIk2udIzLoYsRnRmDYFTud5cOsv0f6RH5Np5a4G 0/5gCapElcptE+HAbX4rGKJN/4avOXEGNpd8mjw4FvPdSoZGW1dMaFLTPRmIARcDczGE 1jlQ== X-Gm-Message-State: AOJu0Yy1s5xTEJA5Z8iWGFy/fYLfnmYmABN/WZMXKK3SMDsbeVyeXYun NM7UzFPt8asxmcH9884TG70JlEo2iLet+rfKjs0OIkXLs+5YhIue X-Google-Smtp-Source: AGHT+IHiIVJYl5j/DJpeQbtPGNMbBOlfD88573LoMKkNBFXkBVpqbt9N+wtJy2GIJRO4mBZZTOSAjQ== X-Received: by 2002:a5e:a904:0:b0:7c4:583:bdfe with SMTP id c4-20020a5ea904000000b007c40583bdfemr5064912iod.1.1707635332303; Sat, 10 Feb 2024 23:08:52 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWwRU6bP3v1MDz/bqQA1MMtbPLB3bbIhk7tJX6RlSz63dj4gxKwrFyiUjYR0k2q96JQ2u0Enfgzz8CY6EHN8Zw= Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id kf3-20020a17090305c300b001d90b9ec345sm3924061plb.114.2024.02.10.23.08.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 10 Feb 2024 23:08:51 -0800 (PST) Message-ID: Date: Sat, 10 Feb 2024 23:08:51 -0800 MIME-Version: 1.0 Subject: Re: bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' Content-Language: en-US To: Eli Zaretskii References: <83986cee-a32d-707f-6ee0-ec1ba2bd42c2@gmail.com> <86a5ocgp74.fsf@mail.linkov.net> <86cyt4t96u.fsf@gnu.org> <254d7a98-d39d-2481-5a2a-01eea80fb657@gmail.com> <865xyvttxo.fsf@gnu.org> From: Jim Porter In-Reply-To: <865xyvttxo.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68881 Cc: 68881@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/10/2024 10:07 PM, Eli Zaretskii wrote: > They both go to the smallest buffer position of the line (modulo the > fields issue). If an LTR line starts with RTL characters, that buffer > position will not be the leftmost one, but that's all. (I don't think > we have a function to go to the position that is the leftmost on > display, probably because that was never needed.) Looking further in the outline.el code, it seems that RTL support is handled elsewhere, so as far as I can tell (as a non-RTL user), everything's good on the text directionality front. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 12:55:20 2024 Received: (at 68881) by debbugs.gnu.org; 11 Feb 2024 17:55:20 +0000 Received: from localhost ([127.0.0.1]:35531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZE2x-0001u6-SS for submit@debbugs.gnu.org; Sun, 11 Feb 2024 12:55:20 -0500 Received: from mslow1.mail.gandi.net ([217.70.178.240]:56525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZDzF-0001ip-AU for 68881@debbugs.gnu.org; Sun, 11 Feb 2024 12:51:29 -0500 Received: from relay6-d.mail.gandi.net (unknown [217.70.183.198]) by mslow1.mail.gandi.net (Postfix) with ESMTP id EDEF8C152E for <68881@debbugs.gnu.org>; Sun, 11 Feb 2024 17:51:10 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id CD2A7C0003; Sun, 11 Feb 2024 17:51:09 +0000 (UTC) From: Juri Linkov To: Jim Porter Subject: Re: bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' In-Reply-To: (Jim Porter's message of "Sat, 10 Feb 2024 10:22:16 -0800") Organization: LINKOV.NET References: <83986cee-a32d-707f-6ee0-ec1ba2bd42c2@gmail.com> <86a5ocgp74.fsf@mail.linkov.net> Date: Sun, 11 Feb 2024 19:40:56 +0200 Message-ID: <86y1bqx5jr.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 68881 Cc: 68881@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) >> There is also one occurrence of 'line-end-position' in outline.el. >> Should it have 'inhibit-field-text-motion' as well? > > Thanks for the catch. Updated this as well. Here is another catch: > @@ -725,7 +725,7 @@ outline-insert-heading > (not (string-match (concat "\\`\\(?:" outline-regexp "\\)") > (concat head " ")))) > (setq head (concat head " "))) > - (unless (bolp) (end-of-line) (newline)) > + (unless (bolp) (goto-char (pos-bol)) (newline)) This looks like a typo. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 11 13:19:47 2024 Received: (at 68881) by debbugs.gnu.org; 11 Feb 2024 18:19:47 +0000 Received: from localhost ([127.0.0.1]:37254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZEQc-00031G-Fr for submit@debbugs.gnu.org; Sun, 11 Feb 2024 13:19:47 -0500 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]:42033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZEQX-00030n-AT for 68881@debbugs.gnu.org; Sun, 11 Feb 2024 13:19:44 -0500 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-6e0dcf0a936so74756b3a.0 for <68881@debbugs.gnu.org>; Sun, 11 Feb 2024 10:19:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707675559; x=1708280359; darn=debbugs.gnu.org; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=G9ClXpI/BznrPlVoh0RMrLjuYehoNtbV4NO8cYDhdfo=; b=YX4cDHcFTvRtbp7fe2UF+44Yh7ZYOJlGzD5u3FBmMLPB9eqTM3jA7HzK53/7IzJUhZ sigB4SwpVK2a5hmWzFVW2bDjMOyr1PRxeoH+v8EUJfc52kDGV9glyqGDSR9H2QuQb5kw LBb+l1aqJRq28xoqdmlHtgmfi22ChCU/tZ04pLDgNQwTnQx74XCtcivh8SHChp4cQX3a EHVEg80WTQ78NcRMbCdctqYEDj9ReFXYKq2b6XL/rhNjzcrq4e+ojnhsXVoRW4pYPcTy I+KRseSpwlDqEog4qqy7C0hNC+TS8lGtbgxldAW823JC0iRpHebnGfEevOza8gZckw7X 1TxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707675559; x=1708280359; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=G9ClXpI/BznrPlVoh0RMrLjuYehoNtbV4NO8cYDhdfo=; b=qWkUVkn8i9DTlSc2gwf2+x1qd8TcVSkk9exG9m2AWJi53X09irin3z7R0WRK86BgiG 58ROwMIWgfjhRJDeuoNwfq2rJ8ItjUKrXXNWBEJlwqrspSQbMMrpCf3A7iy/nsQ8zCYj 9QhaxM3ZXq1BIm4MQ9d6tXqyAidLpH8l6C+PP6dAtnseauhrqZIDeXw/KBRUAC9r2Uvk lLgZMRId127nVqdqAGdZhnqTkdHREMbWrt8B/fOctgXtStEqlP81RADbW87zkjCyQtf+ y6Og12hGYKsc7Abjzk18mQuld15aRtS6Zogd17gJKHWDnPQO62SVLyMlSqsLZwEBd3kY jRgA== X-Gm-Message-State: AOJu0YwMYZvcobHUhEKm7pBZ523183lxG94fHnKGZs8exmHcvuMTQ9TN kpnQ4uwFAEJb8PujX2tAE+E5f/zItn8aaSF1jHPW7+euAGVR0/BkkgtpXBW+ X-Google-Smtp-Source: AGHT+IGaiePziFzSOIs6Y0ltxg+s1brz4jijK2U+hsapfp53WxdYntoy3VnaiEaNODeybS9ctAM78g== X-Received: by 2002:a05:6a20:9d8f:b0:19e:2d00:10c6 with SMTP id mu15-20020a056a209d8f00b0019e2d0010c6mr9535126pzb.23.1707675558822; Sun, 11 Feb 2024 10:19:18 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a27-20020a63705b000000b005bd980cca56sm5375808pgn.29.2024.02.11.10.19.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 11 Feb 2024 10:19:17 -0800 (PST) Content-Type: multipart/mixed; boundary="------------4fDQaKGO94sxClwnjX9Dm929" Message-ID: <45bf907f-f5b7-9bbb-ada2-43f262902029@gmail.com> Date: Sun, 11 Feb 2024 10:19:18 -0800 MIME-Version: 1.0 Subject: Re: bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' Content-Language: en-US To: Juri Linkov References: <83986cee-a32d-707f-6ee0-ec1ba2bd42c2@gmail.com> <86a5ocgp74.fsf@mail.linkov.net> <86y1bqx5jr.fsf@mail.linkov.net> From: Jim Porter In-Reply-To: <86y1bqx5jr.fsf@mail.linkov.net> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68881 Cc: 68881@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------4fDQaKGO94sxClwnjX9Dm929 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/11/2024 9:40 AM, Juri Linkov wrote: >> @@ -725,7 +725,7 @@ outline-insert-heading >> (not (string-match (concat "\\`\\(?:" outline-regexp "\\)") >> (concat head " ")))) >> (setq head (concat head " "))) >> - (unless (bolp) (end-of-line) (newline)) >> + (unless (bolp) (goto-char (pos-bol)) (newline)) > > This looks like a typo. So it is. Fixed. --------------4fDQaKGO94sxClwnjX9Dm929 Content-Type: text/plain; charset=UTF-8; name="0001-Make-outline.el-ignore-field-properties-in-text.patch" Content-Disposition: attachment; filename*0="0001-Make-outline.el-ignore-field-properties-in-text.patch" Content-Transfer-Encoding: base64 RnJvbSA2ZGM0Yjc4MDJlZjM2YTUwNjQ3ZWJmMmExZTlhMTk4MmZiOWVkYmIzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMSBGZWIgMjAyNCAxMzo1ODoyMCAtMDgwMApTdWJqZWN0OiBbUEFU Q0ggMS80XSBNYWtlIG91dGxpbmUuZWwgaWdub3JlIGZpZWxkIHByb3BlcnRpZXMgaW4gdGV4 dAoKKiBsaXNwL291dGxpbmUuZWwgKG91dGxpbmUtYmFjay10by1oZWFkaW5nLCBvdXRsaW5l LW9uLWhlYWRpbmctcCkKKG91dGxpbmUtbmV4dC12aXNpYmxlLWhlYWRpbmcsIG91dGxpbmUt bWFyay1zdWJ0cmVlKQoob3V0bGluZS1oaWRlLXN1YmxldmVscywgb3V0bGluZS0taW5zZXJ0 LWJ1dHRvbikKKG91dGxpbmUtLWZpeC11cC1hbGwtYnV0dG9ucyk6IEluaGliaXQgZmllbGQg dGV4dCBtb3Rpb24gKGJ1ZyM2ODg4MSkuCi0tLQogbGlzcC9vdXRsaW5lLmVsIHwgMjQgKysr KysrKysrKystLS0tLS0tLS0tLS0tCiAxIGZpbGUgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygr KSwgMTMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9vdXRsaW5lLmVsIGIvbGlz cC9vdXRsaW5lLmVsCmluZGV4IGI1MDcwOGMxYTdiLi41YWMwZjA3MDdmMSAxMDA2NDQKLS0t IGEvbGlzcC9vdXRsaW5lLmVsCisrKyBiL2xpc3Avb3V0bGluZS5lbApAQCAtNjg2LDcgKzY4 Niw3IEBAICdvdXRsaW5lLWJlZm9yZS1maXJzdC1oZWFkaW5nCiAoZGVmdW4gb3V0bGluZS1i YWNrLXRvLWhlYWRpbmcgKCZvcHRpb25hbCBpbnZpc2libGUtb2spCiAgICJNb3ZlIHRvIHBy ZXZpb3VzIGhlYWRpbmcgbGluZSwgb3IgYmVnIG9mIHRoaXMgbGluZSBpZiBpdCdzIGEgaGVh ZGluZy4KIE9ubHkgdmlzaWJsZSBoZWFkaW5nIGxpbmVzIGFyZSBjb25zaWRlcmVkLCB1bmxl c3MgSU5WSVNJQkxFLU9LIGlzIG5vbi1uaWwuIgotICAoYmVnaW5uaW5nLW9mLWxpbmUpCisg IChmb3J3YXJkLWxpbmUgMCkKICAgKG9yIChvdXRsaW5lLW9uLWhlYWRpbmctcCBpbnZpc2li bGUtb2spCiAgICAgICAobGV0IChmb3VuZCkKIAkoc2F2ZS1leGN1cnNpb24KQEAgLTcwNSw3 ICs3MDUsNyBAQCBvdXRsaW5lLW9uLWhlYWRpbmctcAogICAiUmV0dXJuIHQgaWYgcG9pbnQg aXMgb24gYSAodmlzaWJsZSkgaGVhZGluZyBsaW5lLgogSWYgSU5WSVNJQkxFLU9LIGlzIG5v bi1uaWwsIGFuIGludmlzaWJsZSBoZWFkaW5nIGxpbmUgaXMgb2sgdG9vLiIKICAgKHNhdmUt ZXhjdXJzaW9uCi0gICAgKGJlZ2lubmluZy1vZi1saW5lKQorICAgIChmb3J3YXJkLWxpbmUg MCkKICAgICAoYW5kIChib2xwKSAob3IgaW52aXNpYmxlLW9rIChub3QgKG91dGxpbmUtaW52 aXNpYmxlLXApKSkKIAkgKGlmIG91dGxpbmUtc2VhcmNoLWZ1bmN0aW9uCiAgICAgICAgICAg ICAgKGZ1bmNhbGwgb3V0bGluZS1zZWFyY2gtZnVuY3Rpb24gbmlsIG5pbCBuaWwgdCkKQEAg LTcyNSw3ICs3MjUsNyBAQCBvdXRsaW5lLWluc2VydC1oZWFkaW5nCiAJCShub3QgKHN0cmlu Zy1tYXRjaCAoY29uY2F0ICJcXGBcXCg/OiIgb3V0bGluZS1yZWdleHAgIlxcKSIpCiAJCQkJ ICAgKGNvbmNhdCBoZWFkICIgIikpKSkKICAgICAgIChzZXRxIGhlYWQgKGNvbmNhdCBoZWFk ICIgIikpKQotICAgICh1bmxlc3MgKGJvbHApIChlbmQtb2YtbGluZSkgKG5ld2xpbmUpKQor ICAgICh1bmxlc3MgKGJvbHApIChnb3RvLWNoYXIgKHBvcy1lb2wpKSAobmV3bGluZSkpCiAg ICAgKGluc2VydCBoZWFkKQogICAgICh1bmxlc3MgKGVvbHApCiAgICAgICAoc2F2ZS1leGN1 cnNpb24gKG5ld2xpbmUtYW5kLWluZGVudCkpKQpAQCAtOTQxLDkgKzk0MSw3IEBAIG91dGxp bmUtbmV4dC12aXNpYmxlLWhlYWRpbmcKIEEgaGVhZGluZyBsaW5lIGlzIG9uZSB0aGF0IHN0 YXJ0cyB3aXRoIGEgYConIChvciB0aGF0CiBgb3V0bGluZS1yZWdleHAnIG1hdGNoZXMpLiIK ICAgKGludGVyYWN0aXZlICJwIikKLSAgKGlmICg8IGFyZyAwKQotICAgICAgKGJlZ2lubmlu Zy1vZi1saW5lKQotICAgIChlbmQtb2YtbGluZSkpCisgIChnb3RvLWNoYXIgKGlmICg8IGFy ZyAwKSAocG9zLWJvbCkgKHBvcy1lb2wpKSkKICAgKGxldCAoKHJlZ2V4cCAodW5sZXNzIG91 dGxpbmUtc2VhcmNoLWZ1bmN0aW9uCiAgICAgICAgICAgICAgICAgICAoY29uY2F0ICJeXFwo PzoiIG91dGxpbmUtcmVnZXhwICJcXCkiKSkpCiAgICAgICAgIGZvdW5kLWhlYWRpbmctcCkK QEAgLTk2Myw3ICs5NjEsNyBAQCBvdXRsaW5lLW5leHQtdmlzaWJsZS1oZWFkaW5nCiAgICAg ICAgICAgICAgICAgICAgICAgICAgIChyZS1zZWFyY2gtZm9yd2FyZCByZWdleHAgbmlsICdt b3ZlKSkpCiAJCSAgKG91dGxpbmUtaW52aXNpYmxlLXAgKG1hdGNoLWJlZ2lubmluZyAwKSkp KQogICAgICAgKHNldHEgYXJnICgxLSBhcmcpKSkKLSAgICAoaWYgZm91bmQtaGVhZGluZy1w IChiZWdpbm5pbmctb2YtbGluZSkpKSkKKyAgICAoaWYgZm91bmQtaGVhZGluZy1wIChmb3J3 YXJkLWxpbmUgMCkpKSkKIAogKGRlZnVuIG91dGxpbmUtcHJldmlvdXMtdmlzaWJsZS1oZWFk aW5nIChhcmcpCiAgICJNb3ZlIHRvIHRoZSBwcmV2aW91cyBoZWFkaW5nIGxpbmUuCkBAIC05 ODAsNyArOTc4LDcgQEAgb3V0bGluZS1tYXJrLXN1YnRyZWUKICAgKGxldCAoKGJlZykpCiAg ICAgKGlmIChvdXRsaW5lLW9uLWhlYWRpbmctcCkKIAk7OyB3ZSBhcmUgYWxyZWFkeSBsb29r aW5nIGF0IGEgaGVhZGluZwotCShiZWdpbm5pbmctb2YtbGluZSkKKyAgICAgICAgKGZvcndh cmQtbGluZSAwKQogICAgICAgOzsgZWxzZSBnbyBiYWNrIHRvIHByZXZpb3VzIGhlYWRpbmcK ICAgICAgIChvdXRsaW5lLXByZXZpb3VzLXZpc2libGUtaGVhZGluZyAxKSkKICAgICAoc2V0 cSBiZWcgKHBvaW50KSkKQEAgLTExODMsNyArMTE4MSw3IEBAIG91dGxpbmUtaGlkZS1zdWJs ZXZlbHMKIAkJKGNvbmQKIAkJIChjdXJyZW50LXByZWZpeC1hcmcgKHByZWZpeC1udW1lcmlj LXZhbHVlIGN1cnJlbnQtcHJlZml4LWFyZykpCiAJCSAoKHNhdmUtZXhjdXJzaW9uCi0gICAg ICAgICAgICAgICAgICAgIChiZWdpbm5pbmctb2YtbGluZSkKKyAgICAgICAgICAgICAgICAg ICAgKGZvcndhcmQtbGluZSAwKQogCQkgICAgKGlmIG91dGxpbmUtc2VhcmNoLWZ1bmN0aW9u CiAgICAgICAgICAgICAgICAgICAgICAgICAoZnVuY2FsbCBvdXRsaW5lLXNlYXJjaC1mdW5j dGlvbiBuaWwgbmlsIG5pbCB0KQogICAgICAgICAgICAgICAgICAgICAgIChsb29raW5nLWF0 IG91dGxpbmUtcmVnZXhwKSkpCkBAIC0xMjQzLDcgKzEyNDEsNyBAQCBvdXRsaW5lLXRvZ2ds ZS1jaGlsZHJlbgogICAoaW50ZXJhY3RpdmUpCiAgIChzYXZlLWV4Y3Vyc2lvbgogICAgIChv dXRsaW5lLWJhY2stdG8taGVhZGluZykKLSAgICAoaWYgKG5vdCAob3V0bGluZS1pbnZpc2li bGUtcCAobGluZS1lbmQtcG9zaXRpb24pKSkKKyAgICAoaWYgKG5vdCAob3V0bGluZS1pbnZp c2libGUtcCAocG9zLWVvbCkpKQogICAgICAgICAob3V0bGluZS1oaWRlLXN1YnRyZWUpCiAg ICAgICAob3V0bGluZS1zaG93LWNoaWxkcmVuKQogICAgICAgKG91dGxpbmUtc2hvdy1lbnRy eSkpKSkKQEAgLTE4MzQsNyArMTgzMiw3IEBAIG91dGxpbmUtLWNyZWF0ZS1idXR0b24taWNv bnMKIChkZWZ1biBvdXRsaW5lLS1pbnNlcnQtYnV0dG9uICh0eXBlKQogICAod2l0aC1zaWxl bnQtbW9kaWZpY2F0aW9ucwogICAgIChzYXZlLWV4Y3Vyc2lvbgotICAgICAgKGJlZ2lubmlu Zy1vZi1saW5lKQorICAgICAgKGZvcndhcmQtbGluZSAwKQogICAgICAgKGxldCAoKGljb24g KG50aCAoaWYgKGVxIHR5cGUgJ2Nsb3NlKSAxIDApIG91dGxpbmUtLWJ1dHRvbi1pY29ucykp CiAgICAgICAgICAgICAobyAoc2VxLWZpbmQgKGxhbWJkYSAobykgKG92ZXJsYXktZ2V0IG8g J291dGxpbmUtYnV0dG9uKSkKICAgICAgICAgICAgICAgICAgICAgICAgICAob3ZlcmxheXMt YXQgKHBvaW50KSkpKSkKQEAgLTE4NDIsNyArMTg0MCw3IEBAIG91dGxpbmUtLWluc2VydC1i dXR0b24KICAgICAgICAgICAod2hlbiAoZXEgb3V0bGluZS1taW5vci1tb2RlLXVzZS1idXR0 b25zICdpbnNlcnQpCiAgICAgICAgICAgICAobGV0ICgoaW5oaWJpdC1yZWFkLW9ubHkgdCkp CiAgICAgICAgICAgICAgIChpbnNlcnQgKGFwcGx5ICMncHJvcGVydGl6ZSAiICAiICh0ZXh0 LXByb3BlcnRpZXMtYXQgKHBvaW50KSkpKQotICAgICAgICAgICAgICAoYmVnaW5uaW5nLW9m LWxpbmUpKSkKKyAgICAgICAgICAgICAgKGZvcndhcmQtbGluZSAwKSkpCiAgICAgICAgICAg KHNldHEgbyAobWFrZS1vdmVybGF5IChwb2ludCkgKDErIChwb2ludCkpKSkKICAgICAgICAg ICAob3ZlcmxheS1wdXQgbyAnb3V0bGluZS1idXR0b24gdCkKICAgICAgICAgICAob3Zlcmxh eS1wdXQgbyAnZXZhcG9yYXRlIHQpKQpAQCAtMTg2Niw3ICsxODY0LDcgQEAgb3V0bGluZS0t Zml4LXVwLWFsbC1idXR0b25zCiAgICAgKHdoZW4gZnJvbQogICAgICAgKHNhdmUtZXhjdXJz aW9uCiAgICAgICAgIChnb3RvLWNoYXIgZnJvbSkKLSAgICAgICAgKHNldHEgZnJvbSAobGlu ZS1iZWdpbm5pbmctcG9zaXRpb24pKSkpCisgICAgICAgIChzZXRxIGZyb20gKHBvcy1ib2wp KSkpCiAgICAgKG91dGxpbmUtbWFwLXJlZ2lvbgogICAgICAobGFtYmRhICgpCiAgICAgICAg KGxldCAoKGNsb3NlLXAgKHNhdmUtZXhjdXJzaW9uCi0tIAoyLjI1LjEKCg== --------------4fDQaKGO94sxClwnjX9Dm929-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 12 13:32:51 2024 Received: (at 68881) by debbugs.gnu.org; 12 Feb 2024 18:32:51 +0000 Received: from localhost ([127.0.0.1]:48174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZb6o-0000Ak-O4 for submit@debbugs.gnu.org; Mon, 12 Feb 2024 13:32:50 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:59857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZb6m-0000AA-3O for 68881@debbugs.gnu.org; Mon, 12 Feb 2024 13:32:48 -0500 Received: by mail.gandi.net (Postfix) with ESMTPSA id 4264E60002; Mon, 12 Feb 2024 18:32:23 +0000 (UTC) From: Juri Linkov To: Jim Porter Subject: Re: bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' In-Reply-To: <45bf907f-f5b7-9bbb-ada2-43f262902029@gmail.com> (Jim Porter's message of "Sun, 11 Feb 2024 10:19:18 -0800") Organization: LINKOV.NET References: <83986cee-a32d-707f-6ee0-ec1ba2bd42c2@gmail.com> <86a5ocgp74.fsf@mail.linkov.net> <86y1bqx5jr.fsf@mail.linkov.net> <45bf907f-f5b7-9bbb-ada2-43f262902029@gmail.com> Date: Mon, 12 Feb 2024 20:25:37 +0200 Message-ID: <86y1bpwndq.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 68881 Cc: 68881@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> @@ -725,7 +725,7 @@ outline-insert-heading >>> (not (string-match (concat "\\`\\(?:" outline-regexp "\\)") >>> (concat head " ")))) >>> (setq head (concat head " "))) >>> - (unless (bolp) (end-of-line) (newline)) >>> + (unless (bolp) (goto-char (pos-bol)) (newline)) >> This looks like a typo. > > So it is. Fixed. Thanks. I see no more problems. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 12 23:05:05 2024 Received: (at 68881-done) by debbugs.gnu.org; 13 Feb 2024 04:05:05 +0000 Received: from localhost ([127.0.0.1]:39545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZk2b-00029V-J2 for submit@debbugs.gnu.org; Mon, 12 Feb 2024 23:05:05 -0500 Received: from mail-pl1-f170.google.com ([209.85.214.170]:53332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rZk2Y-00028n-VS for 68881-done@debbugs.gnu.org; Mon, 12 Feb 2024 23:05:03 -0500 Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-1d95d67ff45so28304395ad.2 for <68881-done@debbugs.gnu.org>; Mon, 12 Feb 2024 20:04:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707797020; x=1708401820; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=F7gD86EDlG0D6FzlDe4d74C6aqlL/kC5c+V5kEWJWTM=; b=ZM1KTEnyLuvYv/t53K4RWwtOsHz73byMqTGdN7MYDlndTa0i5Jkm9xyfeSePc6t+D3 9lOKYNyrtqPtcJRmlKxASORAZV6C+Jxq1Xh309BeVU371AMOJPHZyPq9uka3GsJfn1Mj N3R6si1KIid2UIec9AP3nfKMegBsr8RXzdfnirVeeAhcLinOkTZ9HzR25Fy4jQKN6U3t duvKfT/arTeHA150NAKV0a7i4wuQkhyJ1FaDuWiafXygVTZTlysT01CKuwqnAc5wHmGI EVygP19lSYLW4LswSJrcuKA+SjPDSOi+i66XM63YOz2uZkDhX5zolMiF/xKo3pyqP+EQ zx3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707797020; x=1708401820; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F7gD86EDlG0D6FzlDe4d74C6aqlL/kC5c+V5kEWJWTM=; b=TbxCgJIwuxpf1eMEGwp/vssoTcYu2J0jk1mFK3815ixcK9s8b5cJMf9JS/Q3CQO3PC 3/cwv2oq9tcSW4EJwcPQZFaZOxQUJxrykZIKluTD2r/Px86B8QUKIVB95Qrcp7zxqjMn odwMKUDPod0AldBlmd0Thk5DqjTf7btA9gFlJy4+88FgA/YE+ohp97Rtcm9EOBh2Xjiz rR2K9Sp2eBOb6xYT7/oZd1frOzs1XEAxWfaRvAfn/yVjOzOivLDGpoFhsFwdW2ghf8Rq avziYjHvtCkGqLEE1VRRCdmoUJZMTg7Y9HNLJlz/LFwG+Wz9At0Wwc5tVpKZx6ElFzgn xXLA== X-Gm-Message-State: AOJu0Yw2PdO3bLcOaCiZcpmAE9qp3+GDEX9azir9qEnqQ4xDprvpqrrJ D9vAR7akSrwPSXlqRLVs41QBlLHr3lJa/asqZDTFEZPfGOqc4y4+ X-Google-Smtp-Source: AGHT+IFt7QtS2YFL4AwRxYNX0PtLxxMukJ+glDKeFWaAkCIumh5aIGJK15Dm2KNuOV3XLHzIFZyJJA== X-Received: by 2002:a17:902:e811:b0:1d9:e180:478c with SMTP id u17-20020a170902e81100b001d9e180478cmr9066439plg.24.1707797019699; Mon, 12 Feb 2024 20:03:39 -0800 (PST) Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id lc13-20020a170902fa8d00b001d9fcd343edsm1069979plb.208.2024.02.12.20.03.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Feb 2024 20:03:39 -0800 (PST) Message-ID: <1fa89ce8-6c78-f104-b15a-231673e00b82@gmail.com> Date: Mon, 12 Feb 2024 20:03:38 -0800 MIME-Version: 1.0 Subject: Re: bug#68881: 30.0.50; [PATCH] Field properties confuse 'outline-minor-mode' Content-Language: en-US To: Juri Linkov References: <83986cee-a32d-707f-6ee0-ec1ba2bd42c2@gmail.com> <86a5ocgp74.fsf@mail.linkov.net> <86y1bqx5jr.fsf@mail.linkov.net> <45bf907f-f5b7-9bbb-ada2-43f262902029@gmail.com> <86y1bpwndq.fsf@mail.linkov.net> From: Jim Porter In-Reply-To: <86y1bpwndq.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 68881-done Cc: 68881-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2/12/2024 10:25 AM, Juri Linkov wrote: >>>> @@ -725,7 +725,7 @@ outline-insert-heading >>>> (not (string-match (concat "\\`\\(?:" outline-regexp "\\)") >>>> (concat head " ")))) >>>> (setq head (concat head " "))) >>>> - (unless (bolp) (end-of-line) (newline)) >>>> + (unless (bolp) (goto-char (pos-bol)) (newline)) >>> This looks like a typo. >> >> So it is. Fixed. > > Thanks. I see no more problems. Thanks. Merged as d570864bebf, so closing this now. (I'll file a new bug later for adding outline-minor-mode support to Eshell once I've worked out all the remaining issues.) From unknown Fri Jun 20 07:22:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 12 Mar 2024 11:24:23 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator