GNU bug report logs - #68879
[PATCH] Compatibility issue with a newer version of tree-sitter-javascript

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68879 in the body.
You can then email your comments to 68879 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <vincenzo.pupillo <at> unimi.it>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Compatibility issue with a newer version of
 tree-sitter-javascript
Date: Thu, 1 Feb 2024 16:18:38 +0000

[Message part 1 (text/plain, inline)]

Hi, 
starting from version 0.20.2 (released yesterday) of tree-sitter-javascript 
the "function" primary expression has been renamed to "function_expression". 

The attached patch (for emacs 29) supports the old and new versions.
I also have a version for emacs 30.

Thank you. 
V.


-- 
Vincenzo Pupillo
Direzione ICT
Università degli Studi di Milano / University of Milan (Italy)
Via Giuseppe Colombo, 46, 20133 Milano

[0001-Fixed-incompatibility-with-tree-sitter-javascrip-0.2.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 68879 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vincenzo Pupillo <vincenzo.pupillo <at> unimi.it>
Cc: 68879 <at> debbugs.gnu.org
Subject: Re: bug#68879: [PATCH] Compatibility issue with a newer version of
 tree-sitter-javascript
Date: Fri, 02 Feb 2024 08:26:50 +0200

> From: Vincenzo Pupillo <vincenzo.pupillo <at> unimi.it>
> Date: Thu, 1 Feb 2024 16:18:38 +0000
> 
> starting from version 0.20.2 (released yesterday) of tree-sitter-javascript 
> the "function" primary expression has been renamed to "function_expression". 
> 
> The attached patch (for emacs 29) supports the old and new versions.
> I also have a version for emacs 30.

Thanks.

If the version for Emacs 30 is different, i.e. it is not just a matter
of merging the changes you sent with the master branch, please post
the Emacs 30 version as well.

Message #11 received at 68879 <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <v.pupillo <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68879 <at> debbugs.gnu.org
Subject: Re: bug#68879: [PATCH] Compatibility issue with a newer version of
 tree-sitter-javascript
Date: Fri, 02 Feb 2024 09:52:20 +0100

[Message part 1 (text/plain, inline)]

Hi Eli,
the patch for Emacs 30 is the same.
Thank you
V.


In data venerdì 2 febbraio 2024 07:26:54 CET, Eli Zaretskii ha scritto:
> [Non ricevi spesso messaggi di posta elettronica da eliz <at> gnu.org. Per informazioni sull'importanza di questo fatto, visita https://aka.ms/LearnAboutSenderIdentification.]
> 
> > From: Vincenzo Pupillo <vincenzo.pupillo <at> unimi.it>
> > Date: Thu, 1 Feb 2024 16:18:38 +0000
> >
> > starting from version 0.20.2 (released yesterday) of tree-sitter-javascript
> > the "function" primary expression has been renamed to "function_expression".
> >
> > The attached patch (for emacs 29) supports the old and new versions.
> > I also have a version for emacs 30.
> 
> Thanks.
> 
> If the version for Emacs 30 is different, i.e. it is not just a matter
> of merging the changes you sent with the master branch, please post
> the Emacs 30 version as well.
> 

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 68879-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Vincenzo Pupillo <vincenzo.pupillo <at> unimi.it>
Cc: 68879-done <at> debbugs.gnu.org
Subject: Re: bug#68879: [PATCH] Compatibility issue with a newer version of
 tree-sitter-javascript
Date: Sat, 03 Feb 2024 11:21:34 +0200

> From: Vincenzo Pupillo <vincenzo.pupillo <at> unimi.it>
> Date: Thu, 1 Feb 2024 16:18:38 +0000
> 
> starting from version 0.20.2 (released yesterday) of tree-sitter-javascript 
> the "function" primary expression has been renamed to "function_expression". 
> 
> The attached patch (for emacs 29) supports the old and new versions.
> I also have a version for emacs 30.

Thanks, installed on the emacs-29 branch, and closing the bug.

Please note the minor changes I made in your commit log message, and
try to follow these conventions in the future.

Message #19 received at 68879-done <at> debbugs.gnu.org (full text, mbox):

From: Vincenzo Pupillo <vincenzo.pupillo <at> unimi.it>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "68879-done <at> debbugs.gnu.org" <68879-done <at> debbugs.gnu.org>
Subject: Re: bug#68879: [PATCH] Compatibility issue with a newer version of
 tree-sitter-javascript
Date: Sat, 3 Feb 2024 10:52:39 +0000

[Message part 1 (text/plain, inline)]

Ok. Thank you. 
V.

In data sabato 3 febbraio 2024 10:22:04 CET, Eli Zaretskii ha scritto:
> [Non ricevi spesso messaggi di posta elettronica da eliz <at> gnu.org. Per
> informazioni sull'importanza di questo fatto, visita
> https://aka.ms/LearnAboutSenderIdentification.]
> > From: Vincenzo Pupillo <vincenzo.pupillo <at> unimi.it>
> > Date: Thu, 1 Feb 2024 16:18:38 +0000
> > 
> > starting from version 0.20.2 (released yesterday) of
> > tree-sitter-javascript
> > the "function" primary expression has been renamed to
> > "function_expression".
> > 
> > The attached patch (for emacs 29) supports the old and new versions.
> > I also have a version for emacs 30.
> 
> Thanks, installed on the emacs-29 branch, and closing the bug.
> 
> Please note the minor changes I made in your commit log message, and
> try to follow these conventions in the future.


-- 
Vincenzo Pupillo
Direzione ICT
Università degli Studi di Milano / University of Milan (Italy)
Via Giuseppe Colombo, 46, 20133 Milano

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.