Subject: bug#68869: closed (Re: [bug#68869] [PATCH v2] guix: channels: Fix typos.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 13 May 2024 08:22:02 +0000

Your bug report

#68869: [PATCH] channels: Fix typos.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
68869: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68869
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#68869] [PATCH v2] guix: channels: Fix typos.
From: Christopher Baines <[email-masked]>
To: Dale Mellor <[email-masked]>
Cc: [email-masked], [email-masked]
Date: Mon, 13 May 2024 09:21:28 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Dale Mellor <[email-masked]> writes:

> From: Rostislav Svoboda <[email-masked]>
>
> * guix/channels.scm (authenticate-channel): Pluralise commit numbers.
>
> Review:
>   * Microscopic documentation change, harmless, but will invoke some i18n
>     activity
>   * Not sure this justifies adding two names to the copyright holders list, if
>     any at all?
>   * Works for me
>
> Reviewed-by: Dale Mellor <[email-masked]>
> Change-Id: I7759607f37405e6d3bd4b7f5958fd11d908db204
> ---
>  guix/channels.scm | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Thanks both, I've tweaked the commit message and pushed this to master
as e5fa18b6285c59b6e9f8debe0ffde9ef5055f3a2.

Chris

Subject: [PATCH] channels: Fix typos.
From: Rostislav Svoboda <[email-masked]>
To: [email-masked]
Cc: Rostislav Svoboda <[email-masked]>
Date: Thu, 1 Feb 2024 13:42:27 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

* guix/channels.scm (authenticate-channel): Pluralise commit numbers.

Change-Id: I7759607f37405e6d3bd4b7f5958fd11d908db204
---
 guix/channels.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/guix/channels.scm b/guix/channels.scm
index 1b07eb5221..a0df5459d4 100644
--- a/guix/channels.scm
+++ b/guix/channels.scm
@@ -3,6 +3,8 @@
 ;;; Copyright © 2018 Ricardo Wurmus <[email-masked]>
 ;;; Copyright © 2019 Jan (janneke) Nieuwenhuizen <[email-masked]>
 ;;; Copyright © 2021 Brice Waegeneire <[email-masked]>
+;;; Copyright © 2024 Julien Lepiller <[email-masked]>
+;;; Copyright © 2024 Rostislav Svoboda <[email-masked]>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -361,8 +363,11 @@ (define* (authenticate-channel channel checkout commit
 
   (define (make-reporter start-commit end-commit commits)
     (format (current-error-port)
-            (G_ "Authenticating channel '~a', commits ~a to ~a (~h new \
-commits)...~%")
+            (N_ "Authenticating channel '~a', commits ~a to ~a (~h new \
+commit)...~%"
+                "Authenticating channel '~a', commits ~a to ~a (~h new \
+commits)...~%"
+                (length commits))
             (channel-name channel)
             (commit-short-id start-commit)
             (commit-short-id end-commit)

base-commit: 7bf8b7c33304d6e69f36190f0444576da1863efc
-- 
2.41.0