Subject: bug#68859: closed (Re: [bug#68859] [PATCH v2] gnu: Add cl-modf.)

From: [email-masked] (GNU bug Tracking System)
Date: Mon, 05 Feb 2024 13:42:02 +0000

Your bug report

#68859: [PATCH] gnu: Add cl-modf.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
68859: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68859
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#68859] [PATCH v2] gnu: Add cl-modf.
From: Guillaume Le Vaillant <[email-masked]>
To: Charles <[email-masked]>
Cc: [email-masked]
Date: Mon, 05 Feb 2024 13:37:23 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Charles <[email-masked]> skribis:

> I just saw that you change the git-file-name to use the package name, so I updated this patch to do the same.

Usually when packaging the xyz Common Lisp package, we use "cl-xyz" as
name for the sources instead of "sbcl-xyz" to indicate that the sources
are not specific to sbcl (as they are also used for the cl-xyz and
ecl-xyz packages).

Patch applied as 87f5876e60922a032b253c43964d2e455d14955a.
Thanks.

Subject: [PATCH] gnu: Add cl-modf.
From: Charles <[email-masked]>
To: [email-masked]
Cc: Charles <[email-masked]>
Date: Wed, 31 Jan 2024 17:58:07 -0600
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/lisp-xyz.scm (sbcl-modf, cl-modf, ecl-modf): New variables.

Change-Id: Ic7e8e4511ca537531a7d9aa134e671aca060aa09
---
I used the quicklisp importer again for this one.

Also guix lint complains about "synopsis should start with an upper-case letter or digit", but I figure it should be fine to start with a @code.

 gnu/packages/lisp-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index ae71c67009..afe9c1bdbb 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -11550,6 +11550,42 @@ (define-public ecl-fset
      ;; Tests fails on ECL with "The function FSET::MAKE-CHAR is undefined".
      '(#:tests? #f))))
 
+(define-public sbcl-modf
+  (let ((commit "dea93fe62c6bf7f66f32f52ac0c555aedbf7abad")
+        (revision "0"))
+    (package
+      (name "sbcl-modf")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/smithzvk/modf")
+               (commit commit)))
+         (file-name (git-file-name "sbcl-modf" version))
+         (sha256
+          (base32
+           "1aap7ldy7lv942khp026pgndgdzfkkqa9xcq1ykinrmflrgdazay"))))
+      (build-system asdf-build-system/sbcl)
+      (inputs
+       (list sbcl-alexandria
+             sbcl-closer-mop
+             sbcl-iterate))
+      (native-inputs
+       (list sbcl-stefil))
+      (home-page "https://github.com/smithzvk/modf")
+      (synopsis "@code{setf} like macro for functional programming in Common Lisp")
+      (description "This library simplifies functional programming in Common
+Lisp by making it easier to make new data structures with specified changes in
+place.")
+      (license license:bsd-3))))
+
+(define-public cl-modf
+  (sbcl-package->cl-source-package sbcl-modf))
+
+(define-public ecl-modf
+  (sbcl-package->ecl-package sbcl-modf))
+
 (define-public sbcl-cl-cont
   (let ((commit "fc1fa7e6eb64894fdca13e688e6015fad5290d2a")
         (revision "1"))

base-commit: 73d8e5a9352304a5192b22e04ef022234488e0da
prerequisite-patch-id: 45d179497c5c23d36ba555ff93d47a18276835ab
prerequisite-patch-id: 57958f0ec7271916a336f2d490f8edeabb429322
-- 
2.41.0