From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 31 07:41:09 2024 Received: (at submit) by debbugs.gnu.org; 31 Jan 2024 12:41:09 +0000 Received: from localhost ([127.0.0.1]:37648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rV9tt-0000Ld-3G for submit@debbugs.gnu.org; Wed, 31 Jan 2024 07:41:09 -0500 Received: from lists.gnu.org ([2001:470:142::17]:48604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rV9tr-0000LD-J1 for submit@debbugs.gnu.org; Wed, 31 Jan 2024 07:41:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rV9tY-0005BG-3f for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2024 07:40:48 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rV9tU-0004no-HU for bug-gnu-emacs@gnu.org; Wed, 31 Jan 2024 07:40:47 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id E31F8240101 for ; Wed, 31 Jan 2024 13:40:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1706704839; bh=LKHDkV0IHUuH87aC16Ta+8ATLTInTGHYnSi81vnxlFw=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=PFlPdPu3ygGkKbeSLfHb0ytdtSw49X9CwUhuHYRLSCr/pFaHr+YIjVEmYgI+bFLCF eUuxTY0RZmBjPdvdeHWlai4tdgHcquwgkWzZU/qoIP7XMhuZbQW/25YMDKJ1EFvCOA 1crL7pTXSCYym5ePM5wMau+Tmnqpdde/1YyU0Jro2pNzTbbySl6MQM1DWUQYGIPttF WZCMjhlwjkdZWcx9y9VzzezarD9XU3p2iVjA0FxaiklnTbfZnoDBYL+LcL5Gh7c2nH zCX112l4H+NSiB8T9TLLOmaNii5wK9aZ6Iu9BhmB8UxGqYZMx4xreEcWUMMjd8iSke I3tP5V7MZCJTQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TQ1pv0Z5wz6tsb for ; Wed, 31 Jan 2024 13:40:38 +0100 (CET) From: Ihor Radchenko To: bug-gnu-emacs@gnu.org Subject: 30.0.50; font-lock does not flush fontification after calling open-line X-Debbugs-Cc: Kostas Papadakis Date: Wed, 31 Jan 2024 12:44:09 +0000 Message-ID: <875xz9oep2.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This bug was originally reported in https://orgmode.org/list/c5fb9f63-185c-4e36-b13f-e887a4a29aae@yandex.com I am not 100% sure if is Emacs bug, but my preliminary testing showed anomalies in `jit-lock-after-change' - (put-text-property jit-lock-start jit-lock-end 'fontified nil) somehow did not apply the text properties. I suspect that I missed something though. May someone please help debugging this and figuring out if the problem is on Emacs side? Steps to reproduce: 1. Create bug.el: (require 'org-faces) (set-face-underline 'org-block-end-line t) (setq org-fontify-whole-block-delimiter-line t) 2. Create bug.org: #+begin_src #+end_src asd 3. Move point to the end of #+end_src line: #+end_src 4. M-x open-lien 5. Observe underline face being applied to the empty line _after_ #+end_src. In GNU Emacs 30.0.50 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.39, cairo version 1.18.0) of 2024-01-30 built on localhost Repository revision: 9de29fb5b0396cb3929bd5668604fda076ca5ec4 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101011 System Description: Gentoo Linux Configured using: 'configure JAVAC=/etc/java-config-2/current-system-vm/bin/javac' -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 03 04:55:58 2024 Received: (at 68849) by debbugs.gnu.org; 3 Feb 2024 09:55:58 +0000 Received: from localhost ([127.0.0.1]:45887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rWCkf-0002ug-JV for submit@debbugs.gnu.org; Sat, 03 Feb 2024 04:55:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rWCkc-0002uQ-JA for 68849@debbugs.gnu.org; Sat, 03 Feb 2024 04:55:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rWCkL-0002PF-OH; Sat, 03 Feb 2024 04:55:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gsXPlEANP4rm3A/W+2fYbEWCJ4bqPKBnAVfp5kbKq/A=; b=jkDLYyRvfK1H GAkbFPqDVD6fMG4RlpfsicUwGi4ES0RPKddcfbZRm+/Lop1cDoVzBp3DDg1NDp4xSAQE6NcA9mc+3 uOEAqAYSbMJQRwTMnaDJ2D40HnIpLiDwXWodE49IrZvF+YCmLz8CWMsJ5bMaQI4+SPj5Sx5eQsAgd b+6Xw/HACImQSNcybKpsBg87p0K4zNFpi9RuftLOuZGP3K+UFKD4n/UcWwVQFZWN8XQZEx03j+XHw MN4RldiU367d5DISEDkTsrEg/G5AEB0tX1pkHmtUy3koAdv7yqJCt4rYkyewFWLyP5jjM64Huo0t3 /Yo3OBEmZII8CQSoStuDNw==; Date: Sat, 03 Feb 2024 11:55:27 +0200 Message-Id: <864jep50ts.fsf@gnu.org> From: Eli Zaretskii To: Ihor Radchenko , Stefan Monnier In-Reply-To: <875xz9oep2.fsf@localhost> (message from Ihor Radchenko on Wed, 31 Jan 2024 12:44:09 +0000) Subject: Re: bug#68849: 30.0.50; font-lock does not flush fontification after calling open-line References: <875xz9oep2.fsf@localhost> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68849 Cc: 68849@debbugs.gnu.org, papadakis.k@yandex.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Kostas Papadakis > From: Ihor Radchenko > Date: Wed, 31 Jan 2024 12:44:09 +0000 > > This bug was originally reported in > https://orgmode.org/list/c5fb9f63-185c-4e36-b13f-e887a4a29aae@yandex.com > > I am not 100% sure if is Emacs bug, but my preliminary testing showed > anomalies in `jit-lock-after-change' - > (put-text-property jit-lock-start jit-lock-end 'fontified nil) somehow > did not apply the text properties. I suspect that I missed something > though. > > May someone please help debugging this and figuring out if the problem > is on Emacs side? > > Steps to reproduce: > > 1. Create bug.el: > (require 'org-faces) > (set-face-underline 'org-block-end-line t) > (setq org-fontify-whole-block-delimiter-line t) > > 2. Create bug.org: > #+begin_src > #+end_src > > asd > > 3. Move point to the end of #+end_src line: > #+end_src > > 4. M-x open-lien > > 5. Observe underline face being applied to the empty line _after_ > #+end_src. Stefan, any suggestions? From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 03 13:47:21 2024 Received: (at 68849) by debbugs.gnu.org; 3 Feb 2024 18:47:21 +0000 Received: from localhost ([127.0.0.1]:47073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rWL2v-0002f7-2O for submit@debbugs.gnu.org; Sat, 03 Feb 2024 13:47:21 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:6882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rWL2s-0002eq-Co for 68849@debbugs.gnu.org; Sat, 03 Feb 2024 13:47:19 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9A2B710035E; Sat, 3 Feb 2024 13:47:00 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706986019; bh=hxiDJkBcRLDF333Pai2cMjxQSLTGLAqomU8dmiPZi20=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=dJxghZov0EwRRFVTrDyWQdMp/Oc33f/0E1BaAAfUwyK3xsrc7H9FN/ks0wsTAv+yS pka+cDui+f4dvCePGcFrpLhDX9/3aGT73iXHDFqt04JrjQPmgRSIxZ27i62wtt6ouE wN41fhKDvBCGy/W4GpzBGacHCibUVARL87XK1gcUn8HrGzD7pqEDsi9bV/5vBoKgA/ HIvAJFSw81iY5Bj1YIe9dCTcCvqBzXqghT0Yph+wHanb6e4xyr/ROTlCXdXD/v/ajf X24UYgKTMOYeZXgFj2TEEv5fsANNfpJq128VcfQ4rjKD/0c7ByfqnqvNWxK0oV5YQo gXq2TvVsGB3Xg== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id AD1B11002EA; Sat, 3 Feb 2024 13:46:59 -0500 (EST) Received: from alfajor (69-165-153-17.dsl.teksavvy.com [69.165.153.17]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7E2C91201E7; Sat, 3 Feb 2024 13:46:59 -0500 (EST) From: Stefan Monnier To: Ihor Radchenko Subject: Re: bug#68849: 30.0.50; font-lock does not flush fontification after calling open-line In-Reply-To: <875xz9oep2.fsf@localhost> (Ihor Radchenko's message of "Wed, 31 Jan 2024 12:44:09 +0000") Message-ID: References: <875xz9oep2.fsf@localhost> Date: Sat, 03 Feb 2024 13:46:58 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.205 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68849 Cc: 68849@debbugs.gnu.org, Kostas Papadakis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I am not 100% sure if is Emacs bug, but my preliminary testing showed > anomalies in `jit-lock-after-change' - > (put-text-property jit-lock-start jit-lock-end 'fontified nil) somehow > did not apply the text properties. I suspect that I missed something > though. AFAICT the `put-text-property` works fine :-) The problem is that your `org-fontify-extend-region` does not spread the change to the "next line". When `font-lock-extend-after-change-region-function` is nil, Emacs does that for you. Quoting `font-lock-extend-jit-lock-region-after-change`: (when (< end (point-max)) (setq end (cond ((get-text-property end 'font-lock-multiline) (or (text-property-any end (point-max) 'font-lock-multiline nil) (point-max))) ;; If `end' has been set by the function above, don't corrupt it. (font-lock-extend-after-change-region-function end) ;; Rounding up to a whole number of lines should include the ;; line right after `end'. Typical case: the first char of ;; the line was deleted. Or a \n was inserted in the middle ;; of a line. (t (1+ end))))) I still hope you can change Org mode so it uses `font-lock-extend-region-functions` instead of `font-lock-extend-after-change-region-function`. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 04 08:30:43 2024 Received: (at 68849) by debbugs.gnu.org; 4 Feb 2024 13:30:43 +0000 Received: from localhost ([127.0.0.1]:48426 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rWca2-0008KZ-OV for submit@debbugs.gnu.org; Sun, 04 Feb 2024 08:30:43 -0500 Received: from mout02.posteo.de ([185.67.36.66]:37617) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rWcZz-0008K4-1J for 68849@debbugs.gnu.org; Sun, 04 Feb 2024 08:30:40 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 75E7F24010A for <68849@debbugs.gnu.org>; Sun, 4 Feb 2024 14:30:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707053420; bh=/b9s6OGm3S9FpUDCnV9oMrYWh/Expl2HJga9jjbeGRs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=m6pU0bE5bT+VQTgSzTxomvme0ptPeubg4Ngq1upV/mPqyOmqTOF2leTS5AlHm5fwy +qTl5Gq/5VIbu0uIdVxsbiUWcEAtGNs46GNsYJWYVwfoqpkM6ULGQ1izi9JKhMEFMa cQ3HpDPegqtaz1GER0bT8CBUuW+0xCIUeFpTSoYa+Vl73SpAwN0dhZSfxZUgYxsKfY qDHQvQWT0PJ24GumK8Y7sPg/ErsHo9cE0ALvOEU6gfdFT3qoF4yZvJHyy4WXtlXpjN kHbhoHl9AkoEBr4UBcVo936lnuK7UhVuvbSgZ5w0pGB++Es2EJYFvOsKGMGA5Bvq3H WVLCLJIDIVM+Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TSVkM41wDz6tvq; Sun, 4 Feb 2024 14:30:18 +0100 (CET) From: Ihor Radchenko To: Stefan Monnier Subject: Re: bug#68849: 30.0.50; font-lock does not flush fontification after calling open-line In-Reply-To: References: <875xz9oep2.fsf@localhost> Date: Sun, 04 Feb 2024 13:33:48 +0000 Message-ID: <87wmrkz743.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68849 Cc: 68849@debbugs.gnu.org, Kostas Papadakis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >> I am not 100% sure if is Emacs bug, but my preliminary testing showed >> anomalies in `jit-lock-after-change' - >> (put-text-property jit-lock-start jit-lock-end 'fontified nil) somehow >> did not apply the text properties. I suspect that I missed something >> though. > > AFAICT the `put-text-property` works fine :-) > The problem is that your `org-fontify-extend-region` does not spread the > change to the "next line". > > When `font-lock-extend-after-change-region-function` is nil, Emacs does > that for you. Quoting `font-lock-extend-jit-lock-region-after-change`: > ... Thanks for the pointer! Fixed, on bugfix. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=1abff3859 > I still hope you can change Org mode so it uses > `font-lock-extend-region-functions` instead of > `font-lock-extend-after-change-region-function`. I am not taking on any major changes in the existing Org fontification as it needs to be rewritten completely. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 04 09:24:51 2024 Received: (at 68849) by debbugs.gnu.org; 4 Feb 2024 14:24:51 +0000 Received: from localhost ([127.0.0.1]:48479 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rWdQQ-0001H8-Tw for submit@debbugs.gnu.org; Sun, 04 Feb 2024 09:24:51 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:39185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rWdQM-0001Gq-70 for 68849@debbugs.gnu.org; Sun, 04 Feb 2024 09:24:49 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E7CB2100390; Sun, 4 Feb 2024 09:24:27 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1707056666; bh=26J8NFTSs3NgWOcXDGhBhM3Dzf9vBR+N8gazg62iWMQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=BoxyzKbWpRB96U6d/fTKa5F6YpNdX674pMl4uut1OJUqkkO9aXdURaa2Do+I8qJ/g nmzUm0MH5zoxbDme6pycsYQm7NgkUcPmG5RWzF4O851Z2nLp6nO2sOoMSuHQhO0zHI I5Txxe+LJjVPmQsOZDL2UC6OKqJcEH/jqFgLK6QHq593oKCg0onrei0JZnf+bojejW YALEcuHf7st1RiobkGkD+Y3AC0iGntDng4+GGILZPlRWqxpTCxQrY0Madulkcjcp5W L9UYCJwj3tFhpbB0sZDYAM1jdQeMwlJdwmEUUriVMA6SM4QBsyMuf5wptYxpuucLvs CSGZQNGUxPI8w== Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E1772100301; Sun, 4 Feb 2024 09:24:26 -0500 (EST) Received: from pastel (69-165-153-17.dsl.teksavvy.com [69.165.153.17]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id B6E5112016C; Sun, 4 Feb 2024 09:24:26 -0500 (EST) From: Stefan Monnier To: Ihor Radchenko Subject: Re: bug#68849: 30.0.50; font-lock does not flush fontification after calling open-line In-Reply-To: <87wmrkz743.fsf@localhost> (Ihor Radchenko's message of "Sun, 04 Feb 2024 13:33:48 +0000") Message-ID: References: <875xz9oep2.fsf@localhost> <87wmrkz743.fsf@localhost> Date: Sun, 04 Feb 2024 09:24:26 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.335 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68849 Cc: 68849@debbugs.gnu.org, Kostas Papadakis X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I still hope you can change Org mode so it uses >> `font-lock-extend-region-functions` instead of >> `font-lock-extend-after-change-region-function`. > > I am not taking on any major changes in the existing Org fontification > as it needs to be rewritten completely. So I heard, yes. You won't crush my hopes so easily. Oh, and BTW, in order to try and prevent that famous rewrite from making the same mistake, a FIXME would be appreciated. Stefan