GNU bug report logs - #68839
[PATCH] gnu: Include company icons and documentation images

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tom Willemse <tom <at> ryuslash.org>
Subject: bug#68839: closed (Re: [bug#68839] [PATCH] gnu: Include company
 icons and documentation images)
Date: Mon, 19 Feb 2024 14:20:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#68839: [PATCH] gnu: Include company icons and documentation images

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 68839 <at> debbugs.gnu.org.

-- 
68839: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68839
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Andrew Tropin <andrew <at> trop.in>
To: Tom Willemse <tom <at> ryuslash.org>, 68839-done <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Tom Willemse <tom <at> ryuslash.org>
Subject: Re: [bug#68839] [PATCH] gnu: Include company icons and
 documentation images
Date: Mon, 19 Feb 2024 17:18:46 +0300

[Message part 3 (text/plain, inline)]

On 2024-01-30 22:28, Tom Willemse wrote:

> * gnu/packages/emacs-xyz.scm (emacs-company): Include icons and documentation
> images.
>
> Change-Id: I8b7515141fa71fcb4b199bfaa268ddd4ab117743
> ---
>  gnu/packages/emacs-xyz.scm | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 4514bd1b25..61174f03ac 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -9261,6 +9261,18 @@ (define-public emacs-company
>         (sha256
>          (base32 "0j2qrnx2w2al4f2n37b89q0pkabh5ccv00gsknvgaylhy0za5gq9"))))
>      (build-system emacs-build-system)
> +    (arguments
> +     (list
> +      #:include #~(cons* "icons/" %default-include)
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'move-doc 'install-doc-images
> +            (lambda* (#:key outputs #:allow-other-keys)
> +              (let ((images (find-files "./images/small/" ".*\\.png$")))
> +                (for-each (lambda (image)
> +                            (install-file image
> +                                          (string-append #$output "/share/info/images/small")))
> +                          images)))))))
>      (home-page "https://company-mode.github.io/")
>      (synopsis "Modular text completion framework")
>      (description
>
> base-commit: c4687f5437ad89a7e87deed1933b60f6eac83176

LGTM, thank you for the patch, slightly adjusted the code to fit 80
column, added a trailing dot to commit message, pushed as
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=55c94d68df

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Tom Willemse <tom <at> ryuslash.org>
To: guix-patches <at> gnu.org
Cc: Tom Willemse <tom <at> ryuslash.org>
Subject: [PATCH] gnu: Include company icons and documentation images
Date: Tue, 30 Jan 2024 22:28:32 -0800

* gnu/packages/emacs-xyz.scm (emacs-company): Include icons and documentation
images.

Change-Id: I8b7515141fa71fcb4b199bfaa268ddd4ab117743
---
 gnu/packages/emacs-xyz.scm | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 4514bd1b25..61174f03ac 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9261,6 +9261,18 @@ (define-public emacs-company
        (sha256
         (base32 "0j2qrnx2w2al4f2n37b89q0pkabh5ccv00gsknvgaylhy0za5gq9"))))
     (build-system emacs-build-system)
+    (arguments
+     (list
+      #:include #~(cons* "icons/" %default-include)
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'move-doc 'install-doc-images
+            (lambda* (#:key outputs #:allow-other-keys)
+              (let ((images (find-files "./images/small/" ".*\\.png$")))
+                (for-each (lambda (image)
+                            (install-file image
+                                          (string-append #$output "/share/info/images/small")))
+                          images)))))))
     (home-page "https://company-mode.github.io/")
     (synopsis "Modular text completion framework")
     (description

base-commit: c4687f5437ad89a7e87deed1933b60f6eac83176
-- 
2.43.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.