From unknown Sun Aug 10 07:28:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6883: 23.2; `read-key' echos keys in the minibuffer Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 19 Aug 2010 15:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6883@debbugs.gnu.org Cc: Stefan Monnier , thierry.volpiatto@gmail.com X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.128223118828373 (code B ref -1); Thu, 19 Aug 2010 15:20:03 +0000 Received: (at submit) by debbugs.gnu.org; 19 Aug 2010 15:19:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Om6u7-0007Na-15 for submit@debbugs.gnu.org; Thu, 19 Aug 2010 11:19:48 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Om6u5-0007NV-MT for submit@debbugs.gnu.org; Thu, 19 Aug 2010 11:19:42 -0400 Received: from lists.gnu.org ([199.232.76.165]:57160) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Om6vA-0002u5-Q6 for submit@debbugs.gnu.org; Thu, 19 Aug 2010 11:20:48 -0400 Received: from [140.186.70.92] (port=42573 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Om6v9-00076W-4U for bug-gnu-emacs@gnu.org; Thu, 19 Aug 2010 11:20:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Om6v4-00066O-4l for bug-gnu-emacs@gnu.org; Thu, 19 Aug 2010 11:20:47 -0400 Received: from ppsw-31.csi.cam.ac.uk ([131.111.8.131]:49003) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Om6v3-000661-Rr for bug-gnu-emacs@gnu.org; Thu, 19 Aug 2010 11:20:42 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from cpc1-cmbg13-0-0-cust596.5-4.cable.virginmedia.com ([86.9.122.85]:62382 helo=Victoria.local) by ppsw-31.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.157]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1Om6v2-0000AO-Jk (Exim 4.72) (return-path ); Thu, 19 Aug 2010 16:20:40 +0100 From: Leo Date: Thu, 19 Aug 2010 16:20:38 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) 1. Define bookmark-read-search-input as this which inserts a (sit-for 1) to demonstrate the bug easily: (defun bookmark-read-search-input () (let ((prompt (propertize "Pattern: " 'face 'minibuffer-prompt)) (tmp-list ())) (while (let ((char (read-key (concat prompt bookmark-search-pattern)))) (sit-for 1) (case char ((?\e ?\r) nil) ; RET or ESC break the search loop. (?\C-g (setq bookmark-quit-flag t) nil) (?\d (pop tmp-list) t) ; Delete last char of pattern with DEL (t (if (characterp char) (push char tmp-list) (setq unread-command-events (nconc (mapcar 'identity (this-single-command-raw-keys)) unread-command-events)) nil)))) (setq bookmark-search-pattern (apply 'string (reverse tmp-list)))))) 2. and eval (let (bookmark-search-pattern) (bookmark-read-search-input)) 3. then start typing away. You should see each key is echoed. So for example if you hit backspace you may see backspace or DEL in the echo area twice. With the original definition back (ie without the sit-for) you can observe a trail for each key you type by for example doing something like this: 1. C-x r l to list bookmarks 2. M-g s and start typing away That breaks the smooth flow of key strokes. Thierry Volpiatto, YAMAMOTO Mitsuharu and I can observe this on all three major platforms. On some platforms, it happens so fast that it is hardly annoying, on others you can read the echoing literally. `read-char' does not have this problem and thus Thierry's suggestion to use it instead. Leo From unknown Sun Aug 10 07:28:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6883: 23.2; `read-key' echos keys in the minibuffer Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Aug 2010 07:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Cc: bug-gnu-emacs@gnu.org, thierry.volpiatto@gmail.com Received: via spool by submit@debbugs.gnu.org id=B.128237709312009 (code B ref -1); Sat, 21 Aug 2010 07:52:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Aug 2010 07:51:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmirU-00037e-LH for submit@debbugs.gnu.org; Sat, 21 Aug 2010 03:51:32 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmirS-00037X-PB for submit@debbugs.gnu.org; Sat, 21 Aug 2010 03:51:31 -0400 Received: from lists.gnu.org ([199.232.76.165]:35983) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Omisc-0006x7-JT for submit@debbugs.gnu.org; Sat, 21 Aug 2010 03:52:42 -0400 Received: from [140.186.70.92] (port=37007 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Omisb-0003IE-41 for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2010 03:52:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Omisa-0004F9-4v for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2010 03:52:40 -0400 Received: from impaqm2.telefonica.net ([213.4.138.2]:23523) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmisZ-0004Ex-UQ for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2010 03:52:40 -0400 Received: from IMPmailhost4.adm.correo ([10.20.102.125]) by IMPaqm2.telefonica.net with bizsmtp id wtiH1e00X2iL0W23MvseLZ; Sat, 21 Aug 2010 09:52:38 +0200 Received: from ceviche.home ([83.61.35.93]) by IMPmailhost4.adm.correo with BIZ IMP id wvsd1e00220aCvn1kvsdQG; Sat, 21 Aug 2010 09:52:38 +0200 X-Brightmail-Tracker: AAAAAA== X-TE-authinfo: authemail="monnier$movistar.es" |auth_email="monnier@movistar.es" X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01" Received: by ceviche.home (Postfix, from userid 20848) id 4219D660E9; Sat, 21 Aug 2010 09:52:37 +0200 (CEST) From: Stefan Monnier Message-ID: References: Date: Sat, 21 Aug 2010 09:52:37 +0200 In-Reply-To: (Leo's message of "Thu, 19 Aug 2010 16:20:38 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) Does the trivial patch below fix the problem? Stefan === modified file 'lisp/subr.el' --- lisp/subr.el 2010-07-10 18:52:53 +0000 +++ lisp/subr.el 2010-08-21 07:45:07 +0000 @@ -1818,6 +1818,7 @@ some sort of escape sequence, the ambiguity is resolved via `read-key-delay'." (let ((overriding-terminal-local-map read-key-empty-map) (overriding-local-map nil) + (echo-keystrokes 0) (old-global-map (current-global-map)) (timer (run-with-idle-timer ;; Wait long enough that Emacs has the time to receive and From unknown Sun Aug 10 07:28:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6883: 23.2; `read-key' echos keys in the minibuffer Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Aug 2010 08:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: bug-gnu-emacs@gnu.org, thierry.volpiatto@gmail.com Received: via spool by submit@debbugs.gnu.org id=B.128237895412766 (code B ref -1); Sat, 21 Aug 2010 08:23:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Aug 2010 08:22:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmjLV-0003Jr-S1 for submit@debbugs.gnu.org; Sat, 21 Aug 2010 04:22:34 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmjLT-0003Jk-Dp for submit@debbugs.gnu.org; Sat, 21 Aug 2010 04:22:32 -0400 Received: from lists.gnu.org ([199.232.76.165]:43761) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OmjMd-00072T-1v for submit@debbugs.gnu.org; Sat, 21 Aug 2010 04:23:43 -0400 Received: from [140.186.70.92] (port=46408 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OmjMb-0006gm-Eg for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2010 04:23:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OmjMa-0008C6-F2 for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2010 04:23:41 -0400 Received: from ppsw-33.csi.cam.ac.uk ([131.111.8.133]:56486) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmjMa-0008Bl-B8 for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2010 04:23:40 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from cpc1-cmbg13-0-0-cust596.5-4.cable.virginmedia.com ([86.9.122.85]:57389 helo=Victoria.local) by ppsw-33.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.159]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1OmjMY-0002WN-gc (Exim 4.72) (return-path ); Sat, 21 Aug 2010 09:23:38 +0100 From: Leo References: Date: Sat, 21 Aug 2010 09:23:37 +0100 In-Reply-To: (Stefan Monnier's message of "Sat, 21 Aug 2010 09:52:37 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (Mac OS X 10.6.4) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.3 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) On 2010-08-21 08:52 +0100, Stefan Monnier wrote: > Does the trivial patch below fix the problem? > > Stefan > > === modified file 'lisp/subr.el' > --- lisp/subr.el 2010-07-10 18:52:53 +0000 > +++ lisp/subr.el 2010-08-21 07:45:07 +0000 > @@ -1818,6 +1818,7 @@ > some sort of escape sequence, the ambiguity is resolved via `read-key-delay'." > (let ((overriding-terminal-local-map read-key-empty-map) > (overriding-local-map nil) > + (echo-keystrokes 0) > (old-global-map (current-global-map)) > (timer (run-with-idle-timer > ;; Wait long enough that Emacs has the time to receive and > Yes and thanks. Leo From unknown Sun Aug 10 07:28:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6883: 23.2; `read-key' echos keys in the minibuffer In-Reply-To: Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Aug 2010 10:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.128238661316107 (code B ref -1); Sat, 21 Aug 2010 10:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 21 Aug 2010 10:30:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmlL3-0004Bk-FQ for submit@debbugs.gnu.org; Sat, 21 Aug 2010 06:30:13 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmlL0-0004Bf-0J for submit@debbugs.gnu.org; Sat, 21 Aug 2010 06:30:11 -0400 Received: from lists.gnu.org ([199.232.76.165]:59229) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OmlM8-0007iz-9U for submit@debbugs.gnu.org; Sat, 21 Aug 2010 06:31:20 -0400 Received: from [140.186.70.92] (port=57540 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OmlM6-0000Up-Cq for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2010 06:31:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_SORBS_WEB, T_RP_MATCHES_RCVD, T_TO_NO_BRKTS_FREEMAIL autolearn=no version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OmlM1-0007vg-79 for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2010 06:31:14 -0400 Received: from lo.gmane.org ([80.91.229.12]:53287) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmlM1-0007vY-1H for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2010 06:31:13 -0400 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OmlLu-0004uU-OM for bug-gnu-emacs@gnu.org; Sat, 21 Aug 2010 12:31:06 +0200 Received: from 89.211.85-79.rev.gaoland.net ([79.85.211.89]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 21 Aug 2010 12:31:06 +0200 Received: from thierry.volpiatto by 89.211.85-79.rev.gaoland.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 21 Aug 2010 12:31:06 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Thierry Volpiatto Date: Sat, 21 Aug 2010 12:28:43 +0200 Organization: ThierryVolpiatto Lines: 28 Message-ID: <87zkwgb6p0.fsf@tux.homenetwork> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 89.211.85-79.rev.gaoland.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:VcN0q4Nj+EdlYdPyMPsTzRW46VI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.3 (-----) Leo writes: > On 2010-08-21 08:52 +0100, Stefan Monnier wrote: >> Does the trivial patch below fix the problem? >> >> Stefan >> >> === modified file 'lisp/subr.el' >> --- lisp/subr.el 2010-07-10 18:52:53 +0000 >> +++ lisp/subr.el 2010-08-21 07:45:07 +0000 >> @@ -1818,6 +1818,7 @@ >> some sort of escape sequence, the ambiguity is resolved via `read-key-delay'." >> (let ((overriding-terminal-local-map read-key-empty-map) >> (overriding-local-map nil) >> + (echo-keystrokes 0) >> (old-global-map (current-global-map)) >> (timer (run-with-idle-timer >> ;; Wait long enough that Emacs has the time to receive and >> > > Yes and thanks. Glad this is fixed, thanks Stefan. -- Thierry Volpiatto Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 From unknown Sun Aug 10 07:28:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Subject: bug#6883: closed (Re: 23.2; `read-key' echos keys in the minibuffer) Message-ID: References: X-Gnu-PR-Message: they-closed 6883 X-Gnu-PR-Package: emacs Reply-To: 6883@debbugs.gnu.org Date: Sat, 21 Aug 2010 13:09:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1282396142-23176-1" This is a multi-part message in MIME format... ------------=_1282396142-23176-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #6883: 23.2; `read-key' echos keys in the minibuffer which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 6883@debbugs.gnu.org. --=20 6883: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D6883 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1282396142-23176-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 6883-done) by debbugs.gnu.org; 21 Aug 2010 13:08:06 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Omnno-00061V-Je for submit@debbugs.gnu.org; Sat, 21 Aug 2010 09:08:05 -0400 Received: from impaqm3.telefonica.net ([213.4.138.3]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OmjvO-0003aL-2Q for 6883-done@debbugs.gnu.org; Sat, 21 Aug 2010 04:59:39 -0400 Received: from IMPmailhost3.adm.correo ([10.20.102.124]) by IMPaqm3.telefonica.net with bizsmtp id wwxN1e0182h2L9m3Px0GbZ; Sat, 21 Aug 2010 11:00:16 +0200 Received: from ceviche.home ([83.61.35.93]) by IMPmailhost3.adm.correo with BIZ IMP id wx0F1e00320aCvn1jx0FAM; Sat, 21 Aug 2010 11:00:16 +0200 X-Brightmail-Tracker: AAAAAA== X-TE-authinfo: authemail="monnier$movistar.es" |auth_email="monnier@movistar.es" X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01" Received: by ceviche.home (Postfix, from userid 20848) id 0F927660E9; Sat, 21 Aug 2010 11:00:15 +0200 (CEST) From: Stefan Monnier To: Leo Subject: Re: 23.2; `read-key' echos keys in the minibuffer Message-ID: References: Date: Sat, 21 Aug 2010 11:00:15 +0200 In-Reply-To: (Leo's message of "Sat, 21 Aug 2010 09:23:37 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 6883-done X-Mailman-Approved-At: Sat, 21 Aug 2010 09:08:03 -0400 Cc: thierry.volpiatto@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> Does the trivial patch below fix the problem? > Yes and thanks. Great, I've installed it in the emacs-23 branch, Stefan ------------=_1282396142-23176-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 Aug 2010 15:19:48 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Om6u7-0007Na-15 for submit@debbugs.gnu.org; Thu, 19 Aug 2010 11:19:48 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Om6u5-0007NV-MT for submit@debbugs.gnu.org; Thu, 19 Aug 2010 11:19:42 -0400 Received: from lists.gnu.org ([199.232.76.165]:57160) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Om6vA-0002u5-Q6 for submit@debbugs.gnu.org; Thu, 19 Aug 2010 11:20:48 -0400 Received: from [140.186.70.92] (port=42573 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Om6v9-00076W-4U for bug-gnu-emacs@gnu.org; Thu, 19 Aug 2010 11:20:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED,T_RP_MATCHES_RCVD,T_TO_NO_BRKTS_FREEMAIL autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Om6v4-00066O-4l for bug-gnu-emacs@gnu.org; Thu, 19 Aug 2010 11:20:47 -0400 Received: from ppsw-31.csi.cam.ac.uk ([131.111.8.131]:49003) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Om6v3-000661-Rr for bug-gnu-emacs@gnu.org; Thu, 19 Aug 2010 11:20:42 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from cpc1-cmbg13-0-0-cust596.5-4.cable.virginmedia.com ([86.9.122.85]:62382 helo=Victoria.local) by ppsw-31.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.157]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1Om6v2-0000AO-Jk (Exim 4.72) (return-path ); Thu, 19 Aug 2010 16:20:40 +0100 From: Leo To: bug-gnu-emacs@gnu.org Subject: 23.2; `read-key' echos keys in the minibuffer Date: Thu, 19 Aug 2010 16:20:38 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: submit Cc: Stefan Monnier , thierry.volpiatto@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) 1. Define bookmark-read-search-input as this which inserts a (sit-for 1) to demonstrate the bug easily: (defun bookmark-read-search-input () (let ((prompt (propertize "Pattern: " 'face 'minibuffer-prompt)) (tmp-list ())) (while (let ((char (read-key (concat prompt bookmark-search-pattern)))) (sit-for 1) (case char ((?\e ?\r) nil) ; RET or ESC break the search loop. (?\C-g (setq bookmark-quit-flag t) nil) (?\d (pop tmp-list) t) ; Delete last char of pattern with DEL (t (if (characterp char) (push char tmp-list) (setq unread-command-events (nconc (mapcar 'identity (this-single-command-raw-keys)) unread-command-events)) nil)))) (setq bookmark-search-pattern (apply 'string (reverse tmp-list)))))) 2. and eval (let (bookmark-search-pattern) (bookmark-read-search-input)) 3. then start typing away. You should see each key is echoed. So for example if you hit backspace you may see backspace or DEL in the echo area twice. With the original definition back (ie without the sit-for) you can observe a trail for each key you type by for example doing something like this: 1. C-x r l to list bookmarks 2. M-g s and start typing away That breaks the smooth flow of key strokes. Thierry Volpiatto, YAMAMOTO Mitsuharu and I can observe this on all three major platforms. On some platforms, it happens so fast that it is hardly annoying, on others you can read the echoing literally. `read-char' does not have this problem and thus Thierry's suggestion to use it instead. Leo ------------=_1282396142-23176-1--