GNU bug report logs - #68829
[PATCH 0/3] Add git-sizer.

Previous Next

Package: guix-patches;

Reported by: Greg Hogan <code <at> greghogan.com>

Date: Tue, 30 Jan 2024 20:07:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #19 received at 68829-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Greg Hogan <code <at> greghogan.com>
Cc: 68829-done <at> debbugs.gnu.org
Subject: Re: [bug#68829] [PATCH 3/3] gnu: Add git-sizer.
Date: Sun, 18 Feb 2024 16:09:28 +0100
[Message part 1 (text/plain, inline)]
Hi,

Greg Hogan <code <at> greghogan.com> skribis:

> * gnu/packages/version-control.scm (git-sizer): New variable.
>
> Change-Id: I82a61e364782dabfd59d0e81ff310fa916b5ff23

Applied with the change below (suggested by ‘guix lint’).

Thanks,
Ludo’.

[Message part 2 (text/x-patch, inline)]
diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index ee6cd78107..afef900bbb 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -4028,12 +4028,14 @@ (define-public git-sizer
                 (string-append (assoc-ref outputs "out")
                                "/bin/git-sizer")))))
          (replace 'check
-           (lambda* (#:key import-path #:allow-other-keys)
-             (for-each (lambda (test)
-                         (invoke "go" "test" "-v" "-run" test import-path))
-                       ;; TestExec and TestSubmodule require a copy of the Git repository.
-                       '("TestBomb" "TestFromSubdir" "TestRefgroups"
-                         "TestRefSelections" "TestTaggedTags")))))))
+           (lambda* (#:key tests? import-path #:allow-other-keys)
+             (when tests?
+               (for-each (lambda (test)
+                           (invoke "go" "test" "-v" "-run" test import-path))
+                         ;; TestExec and TestSubmodule require a copy of the
+                         ;; Git repository.
+                         '("TestBomb" "TestFromSubdir" "TestRefgroups"
+                           "TestRefSelections" "TestTaggedTags"))))))))
     (native-inputs (list git))
     (propagated-inputs
      (list go-github-com-cli-safeexec

This bug report was last modified 1 year and 150 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.