GNU bug report logs - #68829
[PATCH 0/3] Add git-sizer.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#68829: closed ([PATCH 0/3] Add git-sizer.)
Date: Sun, 18 Feb 2024 15:10:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 18 Feb 2024 16:09:28 +0100
with message-id <874je5n713.fsf <at> gnu.org>
and subject line Re: [bug#68829] [PATCH 3/3] gnu: Add git-sizer.
has caused the debbugs.gnu.org bug report #68829,
regarding [PATCH 0/3] Add git-sizer.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
68829: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68829
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Greg Hogan <code <at> greghogan.com>
To: guix-patches <at> gnu.org
Cc: Greg Hogan <code <at> greghogan.com>
Subject: [PATCH 0/3] Add git-sizer.
Date: Tue, 30 Jan 2024 20:06:07 +0000

Greg Hogan (3):
  gnu: Add go-github-com-cli-safeexec.
  gnu: Add go-go-uber-org-goleak.
  gnu: Add git-sizer.

 gnu/packages/golang.scm          | 55 ++++++++++++++++++++++++++++++++
 gnu/packages/version-control.scm | 48 ++++++++++++++++++++++++++++
 2 files changed, 103 insertions(+)


base-commit: bef2560c6c4240664c5a9f773a38e2e917adcace
-- 
2.43.0

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Greg Hogan <code <at> greghogan.com>
Cc: 68829-done <at> debbugs.gnu.org
Subject: Re: [bug#68829] [PATCH 3/3] gnu: Add git-sizer.
Date: Sun, 18 Feb 2024 16:09:28 +0100

[Message part 4 (text/plain, inline)]

Hi,

Greg Hogan <code <at> greghogan.com> skribis:

> * gnu/packages/version-control.scm (git-sizer): New variable.
>
> Change-Id: I82a61e364782dabfd59d0e81ff310fa916b5ff23

Applied with the change below (suggested by ‘guix lint’).

Thanks,
Ludo’.

[Message part 5 (text/x-patch, inline)]

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index ee6cd78107..afef900bbb 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -4028,12 +4028,14 @@ (define-public git-sizer
                 (string-append (assoc-ref outputs "out")
                                "/bin/git-sizer")))))
          (replace 'check
-           (lambda* (#:key import-path #:allow-other-keys)
-             (for-each (lambda (test)
-                         (invoke "go" "test" "-v" "-run" test import-path))
-                       ;; TestExec and TestSubmodule require a copy of the Git repository.
-                       '("TestBomb" "TestFromSubdir" "TestRefgroups"
-                         "TestRefSelections" "TestTaggedTags")))))))
+           (lambda* (#:key tests? import-path #:allow-other-keys)
+             (when tests?
+               (for-each (lambda (test)
+                           (invoke "go" "test" "-v" "-run" test import-path))
+                         ;; TestExec and TestSubmodule require a copy of the
+                         ;; Git repository.
+                         '("TestBomb" "TestFromSubdir" "TestRefgroups"
+                           "TestRefSelections" "TestTaggedTags"))))))))
     (native-inputs (list git))
     (propagated-inputs
      (list go-github-com-cli-safeexec

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.