Subject: bug#68829: closed (Re: [bug#68829] [PATCH 3/3] gnu: Add git-sizer.)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 18 Feb 2024 15:10:02 +0000

Your bug report

#68829: [PATCH 0/3] Add git-sizer.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
68829: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68829
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#68829] [PATCH 3/3] gnu: Add git-sizer.
From: Ludovic Courtès <[email-masked]>
To: Greg Hogan <[email-masked]>
Cc: [email-masked]
Date: Sun, 18 Feb 2024 16:09:28 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Greg Hogan <[email-masked]> skribis:

> * gnu/packages/version-control.scm (git-sizer): New variable.
>
> Change-Id: I82a61e364782dabfd59d0e81ff310fa916b5ff23

Applied with the change below (suggested by ‘guix lint’).

Thanks,
Ludo’.

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index ee6cd78107..afef900bbb 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -4028,12 +4028,14 @@ (define-public git-sizer
                 (string-append (assoc-ref outputs "out")
                                "/bin/git-sizer")))))
          (replace 'check
-           (lambda* (#:key import-path #:allow-other-keys)
-             (for-each (lambda (test)
-                         (invoke "go" "test" "-v" "-run" test import-path))
-                       ;; TestExec and TestSubmodule require a copy of the Git repository.
-                       '("TestBomb" "TestFromSubdir" "TestRefgroups"
-                         "TestRefSelections" "TestTaggedTags")))))))
+           (lambda* (#:key tests? import-path #:allow-other-keys)
+             (when tests?
+               (for-each (lambda (test)
+                           (invoke "go" "test" "-v" "-run" test import-path))
+                         ;; TestExec and TestSubmodule require a copy of the
+                         ;; Git repository.
+                         '("TestBomb" "TestFromSubdir" "TestRefgroups"
+                           "TestRefSelections" "TestTaggedTags"))))))))
     (native-inputs (list git))
     (propagated-inputs
      (list go-github-com-cli-safeexec

Subject: [PATCH 0/3] Add git-sizer.
From: Greg Hogan <[email-masked]>
To: [email-masked]
Cc: Greg Hogan <[email-masked]>
Date: Tue, 30 Jan 2024 20:06:07 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

Greg Hogan (3):
  gnu: Add go-github-com-cli-safeexec.
  gnu: Add go-go-uber-org-goleak.
  gnu: Add git-sizer.

 gnu/packages/golang.scm          | 55 ++++++++++++++++++++++++++++++++
 gnu/packages/version-control.scm | 48 ++++++++++++++++++++++++++++
 2 files changed, 103 insertions(+)

base-commit: bef2560c6c4240664c5a9f773a38e2e917adcace
-- 
2.43.0