GNU bug report logs - #68824
treesitter support for outline-minor-mode

Previous Next

Full log

Message #93 received at control <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Yuan Fu <casouri <at> gmail.com>, 68824 <at> debbugs.gnu.org
Subject: Re: bug#68824: treesitter support for outline-minor-mode
Date: Tue, 13 Feb 2024 19:02:31 +0200

close 68824 30.0.50
thanks

>>> >>> Then maybe just move the text about outline-search-function to the
>>> >>> place where you describe treesit-outline-predicate?
>>> >> 
>>> >> 'outline-search-function' is unsuitable for "Tree-sitter Major Modes".
>>> > 
>>> > All of this thread clearly indicates otherwise.
>>> 
>>> The real problem is probably that outline-minor-mode’s api wasn’t
>>> described in the Elisp manual (Imenu, OTOH, has a node in Elisp
>>> manual). I think we can create a node for outline in (elisp)Modes (that’s
>>> where the node for Imenu is). We can start out with only
>>> outline-search-function in there, and over time populate it with
>>> outline-level, outline-regexp, etc.
>>
>> That'd be fine by me.  But since Juri said he was uncomfortable with
>> such a short node, I tried to suggest alternative ideas.  If having a
>> short new node is deemed our best option, then let's do that.
>
> Ok, let's add a new node.
>
> This is now done and pushed to master.
>
> Please check if everything is correct.

I pushed more fixes, and added treesit-outline-predicate to ruby-ts-mode,
and everything works, so now closing this request.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.