From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 30 00:29:43 2024 Received: (at submit) by debbugs.gnu.org; 30 Jan 2024 05:29:44 +0000 Received: from localhost ([127.0.0.1]:34137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUggp-00025u-4w for submit@debbugs.gnu.org; Tue, 30 Jan 2024 00:29:43 -0500 Received: from lists.gnu.org ([2001:470:142::17]:35318) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rUevN-0007c5-Dw for submit@debbugs.gnu.org; Mon, 29 Jan 2024 22:36:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUev8-0001J0-UX for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 22:36:23 -0500 Received: from omta037.useast.a.cloudfilter.net ([44.202.169.36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rUev7-00049p-5Z for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 22:36:22 -0500 Received: from eig-obgw-6003a.ext.cloudfilter.net ([10.0.30.151]) by cmsmtp with ESMTPS id UeM2rPZBf9gG6UeusrHmly; Tue, 30 Jan 2024 03:36:06 +0000 Received: from leaf.websitewelcome.com ([192.185.82.99]) by cmsmtp with ESMTPS id UeurrGRWttzh2Ueurrr8DN; Tue, 30 Jan 2024 03:36:05 +0000 X-Authority-Analysis: v=2.4 cv=Ra6Dtnhv c=1 sm=1 tr=0 ts=65b86ea5 a=mow2sqwWDa2c9/UKe2ehnA==:117 a=ZqMZf5Na1d1vt6BxWdHeHA==:17 a=wk_meIHUpVQo_52e:21 a=kj9zAlcOel0A:10 a=dEuoMetlWLkA:10 a=oZ_iSjobsX4A:10 a=iy7jycZUomiq1EpIt9wA:9 a=CjuIK1q_8ugA:10 Received: from leaf.websitewelcome.com ([192.185.82.99]:30220) by leaf.websitewelcome.com with esmtpa (Exim 4.96.2) (envelope-from ) id 1rUeuq-002bLN-2e for bug-gnu-emacs@gnu.org; Mon, 29 Jan 2024 21:36:04 -0600 Received: from pool-74-96-66-178.washdc.fios.verizon.net ([74.96.66.178]) by jovi.net with HTTP (HTTP/1.1 POST); Mon, 29 Jan 2024 21:36:04 -0600 MIME-Version: 1.0 Date: Mon, 29 Jan 2024 21:36:04 -0600 From: Devon Sean McCullough To: bug-gnu-emacs@gnu.org Subject: 29.1; dired fails to mark links to . or .. for deletion User-Agent: Roundcube Webmail/1.6.0 Message-ID: <05e0fef1bcc8e0d6a66b44bf084df9bc@jovi.net> X-Sender: Emacs-hacker2023@jovi.net Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - leaf.websitewelcome.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - jovi.net X-BWhitelist: no X-Source-IP: 192.185.82.99 X-Source-L: No X-Exim-ID: 1rUeuq-002bLN-2e X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: leaf.websitewelcome.com [192.185.82.99]:30220 X-Source-Auth: devon2011@jovi.net X-Email-Count: 1 X-Org: HG=hgreseller;ORG=hostgator; X-Source-Cap: am92aW5ldDtkZXZvbjtsZWFmLndlYnNpdGV3ZWxjb21lLmNvbQ== X-Local-Domain: yes X-CMAE-Envelope: MS4xfEcRTf0PImwx1ZcBfhtyH0cuNvYM8+cGODJ8nZsATe2lkKqCdVBfBBfoh7HzgmyOMdmRdi6Vkhco8dlPyPdGAlyyaPaCNKC6YSPXAPtwOoteuF+Y+7Ww D/cpV+PJm9K45qnZhTRcT8YdW3QOQadqjhf12VT87BYTBaQioKZzECJiANbJEh4s6JH7kkBUjF/VViZ2G99oDbKRoX4Fs4hLEj0= Received-SPF: pass client-ip=44.202.169.36; envelope-from=emacs-hacker2023@jovi.net; helo=omta037.useast.a.cloudfilter.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 30 Jan 2024 00:29:42 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) $ mkdir /tmp/scratch $ cd /tmp/scratch $ ln -s . self $ ln -s .. up $ ln -s ... ... $ emacs . Type the letter d three times. Dired fails to mark all three files for deletion, unlike prior versions. In GNU Emacs 29.1 (build 1, x86_64-apple-darwin18.7.0, NS appkit-1671.60 Version 10.14.6 (Build 18G9323)) of 2023-08-16 built on builder10-14.lan Windowing system distributor 'Apple', version 10.3.1671 System Description: Mac OS X 10.14.6 Configured using: 'configure --with-ns '--enable-locallisppath=/Library/Application Support/Emacs/${version}/site-lisp:/Library/Application Support/Emacs/site-lisp' --with-modules 'CFLAGS=-DFD_SETSIZE=10000 -DDARWIN_UNLIMITED_SELECT' --with-x-toolkit=no' Configured features: ACL GLIB GMP GNUTLS JPEG JSON LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER ZLIB Important settings: locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: shell-dirtrack-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils dired-aux dired dired-loaddefs sh-script rx smie treesit cl-seq cl-loaddefs cl-lib executable files-x shell subr-x pcomplete comint ansi-osc ansi-color ring rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 55090 8899) (symbols 48 6568 0) (strings 32 20027 1921) (string-bytes 1 574682) (vectors 16 13706) (vector-slots 8 204004 10049) (floats 8 24 56) (intervals 56 382 0) (buffers 984 16)) From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 03 05:40:59 2024 Received: (at 68814) by debbugs.gnu.org; 3 Feb 2024 10:41:00 +0000 Received: from localhost ([127.0.0.1]:45905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rWDSF-0003z8-IO for submit@debbugs.gnu.org; Sat, 03 Feb 2024 05:40:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rWDSC-0003yv-Om for 68814@debbugs.gnu.org; Sat, 03 Feb 2024 05:40:58 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rWDRv-000644-TO; Sat, 03 Feb 2024 05:40:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dGLhbDl/QhUiOwjl/+MJVDOQVUFabdXxhv2M3EPsHDE=; b=geNrZWc0aXtv cSfiNG2TJCTf4m5mI6vU6RMllgW0JQ7eH2jqD0c7ptkA8AdVg3Aq3WwWJxoWI1JxnblyQDvEG1oah cMO0AJaQH7NGyx6Ob2nyQ2tPCtbjCAYNzollRgCfCJ+P7j0gEbceOiYVitvpt0cfddNXX1tSPK/mr lNoNhqSw/O1Fm+urR1CShQD+AHRavFmHMo/5yjuR8A55a9kfUXp201JkJI5CBtQLefncAZvAdZjHI QoHxI3yEVPu5rr8N7Td2xh5xrSTYvpDHijxbHismcWW5NeDcIeyG56qFB9aKQfmD8gt631A3uLVM7 SQTQlG9pFQY0xBRkSj462Q==; Date: Sat, 03 Feb 2024 12:40:34 +0200 Message-Id: <861q9t4yql.fsf@gnu.org> From: Eli Zaretskii To: Devon Sean McCullough In-Reply-To: <05e0fef1bcc8e0d6a66b44bf084df9bc@jovi.net> (message from Devon Sean McCullough on Mon, 29 Jan 2024 21:36:04 -0600) Subject: Re: bug#68814: 29.1; dired fails to mark links to . or .. for deletion References: <05e0fef1bcc8e0d6a66b44bf084df9bc@jovi.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68814 Cc: 68814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 29 Jan 2024 21:36:04 -0600 > From: Devon Sean McCullough > > $ mkdir /tmp/scratch > $ cd /tmp/scratch > $ ln -s . self > $ ln -s .. up > $ ln -s ... ... > $ emacs . > Type the letter d three times. > Dired fails to mark all three files for deletion, unlike prior versions. Thanks. This is the (unintended) result of fixing bug#38729. How does the patch below look? Do you see any possible problems with it? That is, would exempting symlinks from the dot-dot rule cause any problems? diff --git a/lisp/dired.el b/lisp/dired.el index c33569d..d9fbafb 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -4110,6 +4110,11 @@ dired-mark (prefix-numeric-value arg) (lambda () (when (or (not (looking-at-p dired-re-dot)) + ;; Don't skip symlinks to ".", "..", etc. + (save-excursion + (re-search-forward + dired-permission-flags-regexp nil t) + (eq (char-after (match-beginning 1)) ?l)) (not (equal dired-marker-char dired-del-marker))) (delete-char 1) (insert dired-marker-char)))))))) From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 08 06:55:15 2024 Received: (at 68814-done) by debbugs.gnu.org; 8 Feb 2024 11:55:15 +0000 Received: from localhost ([127.0.0.1]:59283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rY2zq-00024n-SZ for submit@debbugs.gnu.org; Thu, 08 Feb 2024 06:55:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rY2zo-00024X-Vx for 68814-done@debbugs.gnu.org; Thu, 08 Feb 2024 06:55:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rY2zV-00010p-0g; Thu, 08 Feb 2024 06:54:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8hy2ST6QIfYk76/KZ/OK0VpAXtqeQBHNdrJiot75a2s=; b=G7nJE7xzAzDU js8k08hb3lzcXQw9ZObv6LkUSYmqWQDsc7DQqz3UkZwsf/Nrd5PBTyJdBaoyShY7UBGPbpMrTSeCE +sXwUahKQX0+/CDioE1Jbx4+exafuxq0R53rYLmQT0mQG1o0FMH9GdTuyXnV8p69F6uuUlg5DfY0x Wo8UI1cqVbC7RgQLydZF+vLBePP/g1LcrCM6unwX2Vb3/6WsIjOcGm1PG9cGjymhXisFXpKaaq7Uo lIaDhDumYEHMiF/nryiICJZJG/tQQ0Yd7lXxCCVRgwVf/ClCDQ3MvWWADzpHbf2MeyTLGnvrqTdlp LV3z0d+FBERaFcZFij68Bw==; Date: Thu, 08 Feb 2024 13:54:27 +0200 Message-Id: <86v86zw4r0.fsf@gnu.org> From: Eli Zaretskii To: Devon Sean McCullough In-Reply-To: <3752af386f3390232e20b17bf135c5a9@jovi.net> (message from Devon Sean McCullough on Sat, 03 Feb 2024 06:11:50 -0600) Subject: Re: bug#68814: 29.1; dired fails to mark links to . or .. for deletion References: <05e0fef1bcc8e0d6a66b44bf084df9bc@jovi.net> <861q9t4yql.fsf@gnu.org> <3752af386f3390232e20b17bf135c5a9@jovi.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 68814-done Cc: 68814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 03 Feb 2024 06:11:50 -0600 > From: Devon Sean McCullough > > On 2024-02-03 04:40, Eli Zaretskii wrote: > > That is, would exempting symlinks from the dot-dot rule cause any > > problems? > > Seems sensible to me. Thanks, I've now installed this on the emacs-29 branch, and I'm closing this bug. > P.S. I am uncomfortable with how dired deals with $ touch '. . .' > but perhaps that can of worms can remain unopened for now, > LOL, wonder what will happen with $ touch $'foo\nbar' Yes, that's a separate issue. From unknown Sat Aug 16 19:16:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 07 Mar 2024 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator